Alexey Serbin has posted comments on this change. Change subject: Kudu Jepsen Tests - Initial Commit ......................................................................
Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/5492/12/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: PS12, Line 358: /opt/apache-maven-3.3.9/bin Are we ready to migrate to the new maven to build everything Java? If doing so, why not to transition to Java8 for everything as well? >From the other side, if we are using Java8 and just for kudu-jepsen, why not >to leave it as a special profile/configuration? At least, that works right >now, and since we are not about to run kudu-jepsen as a pre-commit >verification test, having a separate profile for kudu-jepsen makes sense IMO. PS12, Line 369: /opt/apache-maven-3.3.9/bin/mvn If this path is used twice already, may be introduce a variable for that and use it everywhere? http://gerrit.cloudera.org:8080/#/c/5492/12/build-support/jenkins/toolchains.xml File build-support/jenkins/toolchains.xml: PS12, Line 13: an extra-space -- To view, visit http://gerrit.cloudera.org:8080/5492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I590c6e78840304b3131666c7037ff9a08dc77dea Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
