[kudu-CR] Clean up spurious declarations in messenger.cc

[Sailesh Mukil (Code Review)]

Sailesh Mukil has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7583

Change subject: Clean up spurious declarations in messenger.cc
..

Clean up spurious declarations in messenger.cc

Change-Id: I105524bab85bef9c08205e3d1f262fa5234745d9
---
M src/kudu/rpc/messenger.cc
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/7583/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I105524bab85bef9c08205e3d1f262fa5234745d9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 

[kudu-CR] Expose running maintenance op info

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change.

Change subject: Expose running maintenance op info
..


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7537/5/src/kudu/util/maintenance_manager.cc
File src/kudu/util/maintenance_manager.cc:

PS5, Line 501: MaintenanceManagerStatusPB_OpInstancePB* running_pb = 
out_pb->add_running_operations();
 : running_op->DumpToPB(running_pb);
How about making DumpToPB return the pb directly and maybe changing this to 
something like:
*out_pb->add_running_operations() = std::move(running_op->DumpToPB()) ?

Same below.


http://gerrit.cloudera.org:8080/#/c/7537/2/src/kudu/util/maintenance_manager.h
File src/kudu/util/maintenance_manager.h:

PS2, Line 245: 
> Maps thread ids to instances of this op that they (the threads) are running
Ah my mistake, misread that.


http://gerrit.cloudera.org:8080/#/c/7537/5/src/kudu/util/maintenance_manager.h
File src/kudu/util/maintenance_manager.h:

PS5, Line 155: Value is negative if instance is still running.
Can you add a similar comment to the .proto?


PS5, Line 332: std::map running_instances_;
Maybe mention locking requirements?


http://gerrit.cloudera.org:8080/#/c/7537/5/src/kudu/util/maintenance_manager.proto
File src/kudu/util/maintenance_manager.proto:

PS5, Line 37: required int32 duration_millis = 3;
Did you consider making this optional in the case of currently-running 
instances? Might not be necessary, but might be worth thinking about if you 
haven't.


-- 
To view, visit http://gerrit.cloudera.org:8080/7537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide228d7e70deae3ae89d108cbd270f3f0f2580ca
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] WIP: [iwyu] first pass

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4738

to look at the new patch set (#8).

Change subject: WIP: [iwyu] first pass
..

WIP: [iwyu] first pass

Updated C++ source files in accordance with include-what-you-use
recommendations:
  * remove unused header files
  * add missing header files
  * use forward declarations when possible

As a result, time of compilation reduced ~10% if building with GNU make
in parallel with 48 jobs (make -j48) at ve0518.halxg.cloudera.com:

prior:
  real  1m21.858s
  user  33m26.685s
  sys 2m19.831s

after:
  real  1m12.686s
  user  30m26.891s
  sys 2m7.627s

The next step is automating the checks, so the IWYU check would run
automatically (like the LINT build).

Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa
---
M src/kudu/benchmarks/rle.cc
M src/kudu/benchmarks/tpch/line_item_tsv_importer.h
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch-schemas.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/benchmarks/wal_hiccup.cc
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/binary_dict_block.h
M src/kudu/cfile/binary_plain_block.cc
M src/kudu/cfile/binary_plain_block.h
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/binary_prefix_block.h
M src/kudu/cfile/block_cache-test.cc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/block_cache.h
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/block_compression.h
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/bloomfile.h
M src/kudu/cfile/bshuf_block.h
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_util.cc
M src/kudu/cfile/cfile_util.h
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/index_block.cc
M src/kudu/cfile/index_block.h
M src/kudu/cfile/index_btree.cc
M src/kudu/cfile/index_btree.h
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/cfile/type_encodings.h
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test-util.h
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.h
M src/kudu/client/error-internal.cc
M src/kudu/client/error-internal.h
M src/kudu/client/error_collector.cc
M src/kudu/client/error_collector.h
M src/kudu/client/master_rpc.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/partitioner-internal.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
M src/kudu/client/resource_metrics.cc
M src/kudu/client/resource_metrics.h
M src/kudu/client/samples/sample.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/client/scan_configuration.cc
M src/kudu/client/scan_configuration.h
M src/kudu/client/scan_predicate.cc
M src/kudu/client/scan_predicate.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-internal.h
M src/kudu/client/scan_token-test.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
M src/kudu/client/shared_ptr.h
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/client/tablet-internal.h
M src/kudu/client/tablet_server-internal.cc
M src/kudu/client/tablet_server-internal.h
M src/kudu/client/value-internal.h
M src/kudu/client/value.cc
M src/kudu/client/value.h
M src/kudu/client/write_op.cc
M src/kudu/client/write_op.h
M src/kudu/clock/clock.h
M src/kudu/clock/hybrid_clock-test.cc
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/hybrid_clock.h
M src/kudu/clock/logical_clock-test.cc
M src/kudu/clock/logical_clock.cc
M src/kudu/clock/logical_clock.h
M src/kudu/codegen/code_cache.cc
M src/kudu/codegen/code_cache.h
M src/kudu/codegen/code_generator.cc
M src/kudu/codegen/code_generator.h
M src/kudu/codegen/codegen-test.cc
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/compilation_manager.h
M src/kudu/codegen/jit_wrapper.cc
M src/kudu/codegen/jit_wrapper.h
M src/kudu/codegen/module_builder.cc
M 

[kudu-CR] disk failure: reassign failed tablets

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change.

Change subject: disk failure: reassign failed tablets
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7440/2/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:

Line 642: peer->needs_tablet_copy = true;
> Why Tablet Copy? Why not evict and let the master reassign the replica?
Hrm, good point. This would probably introduce a cases where a disk fails and a 
single server has to take on a bunch of tablet copies. Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/7440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f61585b02fbe270d215bf7f49c0d390ceee3345
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] WIP: support for running Java tests in dist-test

[Todd Lipcon (Code Review)]

Hello Grant Henke,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/7579

to review the following change.

Change subject: WIP: support for running Java tests in dist-test
..

WIP: support for running Java tests in dist-test

Probably not worth a serious review yet, since this has a few hacks and
one of the tests is still failing when run in this environment, but
maybe worth glancing over the "big idea".

Change-Id: I163c3d88b0cfbb6c2aa9af3af5a308c4196c0451
---
M build-support/dist_test.py
M build-support/run-test.sh
M build-support/run_dist_test.py
M java/build.gradle
A java/buildSrc/build.gradle
A java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java
M java/gradle/shadow.gradle
M java/gradle/tests.gradle
A java/kudu-flume-sink/src/test/resources/testAvroKuduOperationsProducer.avsc
9 files changed, 417 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/7579/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I163c3d88b0cfbb6c2aa9af3af5a308c4196c0451
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Grant Henke 

[kudu-CR] [clock] fixed link error on OS X

[Alexey Serbin (Code Review)]

Alexey Serbin has submitted this change and it was merged.

Change subject: [clock] fixed link error on OS X
..


[clock] fixed link error on OS X

kudu_common is needed to link the clock library, otherwise the following
error is output on OS X:

  Undefined symbols for architecture x86_64:
"kudu::Timestamp::kInvalidTimestamp", referenced from:
kudu::Timestamp::Timestamp() in hybrid_clock.cc.o
kudu::clock::LogicalClock::Update(kudu::Timestamp const&) \
in logical_clock.cc.o
"kudu::Timestamp::ToUint64() const", referenced from:
kudu::clock::HybridClock::NowForMetrics() in hybrid_clock.cc.o
kudu::clock::LogicalClock::Stringify(kudu::Timestamp) \
in logical_clock.cc.o
  ld: symbol(s) not found for architecture x86_64
  clang: error: linker command failed with exit code 1 \
  (use -v to see invocation)

Change-Id: I5e5442333fb667b50aca2f8229e223d44edffd14
Reviewed-on: http://gerrit.cloudera.org:8080/7578
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M src/kudu/clock/CMakeLists.txt
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e5442333fb667b50aca2f8229e223d44edffd14
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] clock: refactor interaction with NTP into a new interface

[Adar Dembo (Code Review)]

Adar Dembo has submitted this change and it was merged.

Change subject: clock: refactor interaction with NTP into a new interface
..


clock: refactor interaction with NTP into a new interface

This refactors HybridClock to interact with the system NTP service (or
its mock) via a new TimeService interface. This encapsulates the
NTP-specific code in such a way that we can easily swap it out with a
built-in NTP client implementation in a future patch.

This also cleans up the 'mock' and OSX (unsynchronized) clock mode to
simply be new implementations of the above interface.

Change-Id: If0653ec32016c588fb63c74f7bc962593aa6c4a0
Reviewed-on: http://gerrit.cloudera.org:8080/7520
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
---
M src/kudu/clock/CMakeLists.txt
M src/kudu/clock/hybrid_clock-test.cc
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/hybrid_clock.h
A src/kudu/clock/mock_ntp.cc
A src/kudu/clock/mock_ntp.h
A src/kudu/clock/system_ntp.cc
A src/kudu/clock/system_ntp.h
A src/kudu/clock/system_unsync_time.cc
A src/kudu/clock/system_unsync_time.h
A src/kudu/clock/time_service.h
M src/kudu/integration-tests/consistency-itest.cc
M src/kudu/integration-tests/tablet_history_gc-itest.cc
M src/kudu/server/generic_service.cc
M src/kudu/server/server_base.proto
M src/kudu/tablet/tablet_history_gc-test.cc
16 files changed, 534 insertions(+), 179 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0653ec32016c588fb63c74f7bc962593aa6c4a0
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Adar Dembo (Code Review)]

Adar Dembo has submitted this change and it was merged.

Change subject: KUDU-2066. Add experimental Gradle build support
..


KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Reviewed-on: http://gerrit.cloudera.org:8080/7258
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
A java/kudu-flume-sink/build.gradle
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducer.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKeyedKuduOperationsProducer.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKuduOperationsProducer.java
A java/kudu-jepsen/build.gradle
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
A java/settings.gradle
34 files changed, 1,453 insertions(+), 6 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 19
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] clock: refactor interaction with NTP into a new interface

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: clock: refactor interaction with NTP into a new interface
..


Patch Set 6: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0653ec32016c588fb63c74f7bc962593aa6c4a0
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [clock] fixed link error on OS X

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [clock] fixed link error on OS X
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e5442333fb667b50aca2f8229e223d44edffd14
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [clock] fixed link error on OS X

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [clock] fixed link error on OS X
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7578/1/src/kudu/clock/CMakeLists.txt
File src/kudu/clock/CMakeLists.txt:

Line 27:   kudu_common)
> I think the rule of thumb is that a module's direct dependencies should be 
That makes sense, thanks for the clarification.


-- 
To view, visit http://gerrit.cloudera.org:8080/7578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e5442333fb667b50aca2f8229e223d44edffd14
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [clock] fixed link error on OS X

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7578

to look at the new patch set (#2).

Change subject: [clock] fixed link error on OS X
..

[clock] fixed link error on OS X

kudu_common is needed to link the clock library, otherwise the following
error is output on OS X:

  Undefined symbols for architecture x86_64:
"kudu::Timestamp::kInvalidTimestamp", referenced from:
kudu::Timestamp::Timestamp() in hybrid_clock.cc.o
kudu::clock::LogicalClock::Update(kudu::Timestamp const&) \
in logical_clock.cc.o
"kudu::Timestamp::ToUint64() const", referenced from:
kudu::clock::HybridClock::NowForMetrics() in hybrid_clock.cc.o
kudu::clock::LogicalClock::Stringify(kudu::Timestamp) \
in logical_clock.cc.o
  ld: symbol(s) not found for architecture x86_64
  clang: error: linker command failed with exit code 1 \
  (use -v to see invocation)

Change-Id: I5e5442333fb667b50aca2f8229e223d44edffd14
---
M src/kudu/clock/CMakeLists.txt
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/7578/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5e5442333fb667b50aca2f8229e223d44edffd14
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] clock: refactor interaction with NTP into a new interface

[Todd Lipcon (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7520

to look at the new patch set (#6).

Change subject: clock: refactor interaction with NTP into a new interface
..

clock: refactor interaction with NTP into a new interface

This refactors HybridClock to interact with the system NTP service (or
its mock) via a new TimeService interface. This encapsulates the
NTP-specific code in such a way that we can easily swap it out with a
built-in NTP client implementation in a future patch.

This also cleans up the 'mock' and OSX (unsynchronized) clock mode to
simply be new implementations of the above interface.

Change-Id: If0653ec32016c588fb63c74f7bc962593aa6c4a0
---
M src/kudu/clock/CMakeLists.txt
M src/kudu/clock/hybrid_clock-test.cc
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/hybrid_clock.h
A src/kudu/clock/mock_ntp.cc
A src/kudu/clock/mock_ntp.h
A src/kudu/clock/system_ntp.cc
A src/kudu/clock/system_ntp.h
A src/kudu/clock/system_unsync_time.cc
A src/kudu/clock/system_unsync_time.h
A src/kudu/clock/time_service.h
M src/kudu/integration-tests/consistency-itest.cc
M src/kudu/integration-tests/tablet_history_gc-itest.cc
M src/kudu/server/generic_service.cc
M src/kudu/server/server_base.proto
M src/kudu/tablet/tablet_history_gc-test.cc
16 files changed, 534 insertions(+), 179 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/7520/6
-- 
To view, visit http://gerrit.cloudera.org:8080/7520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If0653ec32016c588fb63c74f7bc962593aa6c4a0
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [clock] fixed link error on OS X

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [clock] fixed link error on OS X
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7578/1/src/kudu/clock/CMakeLists.txt
File src/kudu/clock/CMakeLists.txt:

Line 27:   kudu_common)
> Good observation.  BTW, what about other places where we link the clock lib
I think the rule of thumb is that a module's direct dependencies should be the 
set of all modules referenced by its code. Suppose A->B->C. If A does not 
actually reference C, A would only list B in its dependencies. If A did use C, 
it'd list both B and C in its dependencies, even though A already depends on C 
transitively through B.

The idea being that even though cmake satisfies transitive dependencies, it's 
useful to know in CMakeLists.txt that a module makes use of another module.


-- 
To view, visit http://gerrit.cloudera.org:8080/7578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e5442333fb667b50aca2f8229e223d44edffd14
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [clock] fixed link error on OS X

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [clock] fixed link error on OS X
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7578/1/src/kudu/clock/CMakeLists.txt
File src/kudu/clock/CMakeLists.txt:

Line 27:   kudu_common)
> Can we remove kudu_common from here then, since it's expected to be pulled 
Good observation.  BTW, what about other places where we link the clock library 
(like src/kudu/consensus/CMakeLists.txt)?  Should we remove it from other 
places as well or it's just for the local context?


-- 
To view, visit http://gerrit.cloudera.org:8080/7578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e5442333fb667b50aca2f8229e223d44edffd14
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [clock] fixed link error on OS X

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [clock] fixed link error on OS X
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7578/1/src/kudu/clock/CMakeLists.txt
File src/kudu/clock/CMakeLists.txt:

Line 27:   kudu_common)
Can we remove kudu_common from here then, since it's expected to be pulled in 
transitively via 'clock'?


-- 
To view, visit http://gerrit.cloudera.org:8080/7578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e5442333fb667b50aca2f8229e223d44edffd14
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [clock] fixed link error on OS X

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7578

Change subject: [clock] fixed link error on OS X
..

[clock] fixed link error on OS X

kudu_common is needed to link the clock library, otherwise the following
error is output on OS X:

  Undefined symbols for architecture x86_64:
"kudu::Timestamp::kInvalidTimestamp", referenced from:
kudu::Timestamp::Timestamp() in hybrid_clock.cc.o
kudu::clock::LogicalClock::Update(kudu::Timestamp const&) \
in logical_clock.cc.o
"kudu::Timestamp::ToUint64() const", referenced from:
kudu::clock::HybridClock::NowForMetrics() in hybrid_clock.cc.o
kudu::clock::LogicalClock::Stringify(kudu::Timestamp) \
in logical_clock.cc.o
  ld: symbol(s) not found for architecture x86_64
  clang: error: linker command failed with exit code 1 \
  (use -v to see invocation)

Change-Id: I5e5442333fb667b50aca2f8229e223d44edffd14
---
M src/kudu/clock/CMakeLists.txt
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/7578/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e5442333fb667b50aca2f8229e223d44edffd14
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.4

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged.

Change subject: Add backdated announcement blog post for 1.4
..


Add backdated announcement blog post for 1.4

Change-Id: I9bea8c7f0d54d4b96a33f910383a38237d0db765
Reviewed-on: http://gerrit.cloudera.org:8080/7576
Reviewed-by: Jean-Daniel Cryans 
Tested-by: Todd Lipcon 
---
A _posts/2017-06-13-apache-kudu-1-4-0-released.md
1 file changed, 33 insertions(+), 0 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Todd Lipcon: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9bea8c7f0d54d4b96a33f910383a38237d0db765
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.4

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: Add backdated announcement blog post for 1.4
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bea8c7f0d54d4b96a33f910383a38237d0db765
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add Maintenance Manager visualizer

[Sam Okrent (Code Review)]

Sam Okrent has posted comments on this change.

Change subject: Add Maintenance Manager visualizer
..


Patch Set 1:

The last two builds failed with different tests, and both seem unrelated.

-- 
To view, visit http://gerrit.cloudera.org:8080/7570
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e7f18ac4834791a94d935b540930b11ea14532
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] kudu client tools for hadoop and spark import/export(csv,parquet,avro)

[Sandish Kumar HN (Code Review)]

Sandish Kumar HN has posted comments on this change.

Change subject: kudu client tools for hadoop and spark 
import/export(csv,parquet,avro)
..


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7421/5/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
File 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java:

Line 99:   if (!schema.containsField(columnSchema.getName())) {
Kudu has primitive-types, parquet has just Type. Example: In Kudu binary type 
and in parquet its string type. How can I compare ?. please give some idea on 
this??


Line 100: LOG.error("The column " + columnSchema.getName() + " does not 
exists in parquet schema");
what should I use instead of system.exit(0). just LOG.error("") enough??


-- 
To view, visit http://gerrit.cloudera.org:8080/7421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If462af948651f3869b444e82151c3559fde19142
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sandish Kumar HN 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sandish Kumar HN 
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.4

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change.

Change subject: Add backdated announcement blog post for 1.4
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bea8c7f0d54d4b96a33f910383a38237d0db765
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.4

[Todd Lipcon (Code Review)]

Hello Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/7576

to review the following change.

Change subject: Add backdated announcement blog post for 1.4
..

Add backdated announcement blog post for 1.4

Change-Id: I9bea8c7f0d54d4b96a33f910383a38237d0db765
---
A _posts/2017-06-13-apache-kudu-1-4-0-released.md
1 file changed, 33 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/7576/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9bea8c7f0d54d4b96a33f910383a38237d0db765
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Jean-Daniel Cryans 

[kudu-CR] kudu client tools for hadoop and spark import/export(csv,parquet,avro)

[Sandish Kumar HN (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7421

to look at the new patch set (#5).

Change subject: kudu client tools for hadoop and spark 
import/export(csv,parquet,avro)
..

kudu client tools for hadoop and spark import/export(csv,parquet,avro)

Change-Id: If462af948651f3869b444e82151c3559fde19142
---
M java/kudu-client-tools/pom.xml
A 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsv.java
A 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
A 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
A 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquetMapper.java
A 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ParquetReadSupport.java
A 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
A 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
A 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-spark-tools/pom.xml
A 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
A 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
M java/pom.xml
13 files changed, 1,167 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/7421/5
-- 
To view, visit http://gerrit.cloudera.org:8080/7421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If462af948651f3869b444e82151c3559fde19142
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sandish Kumar HN 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sandish Kumar HN 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 18: Code-Review+2

Thanks for addressing all of my concerns. We can decide whether or not to shade 
kudu-mapreduce later.

-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 18
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#18).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
A java/kudu-flume-sink/build.gradle
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducer.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKeyedKuduOperationsProducer.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKuduOperationsProducer.java
A java/kudu-jepsen/build.gradle
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
A java/settings.gradle
34 files changed, 1,453 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/18
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 18
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 17:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7258/17/java/build.gradle
File java/build.gradle:

Line 19: // common logic for the various subprojects in the build. 
> Got trailing whitespace here.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 17
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 14:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7258/17/java/build.gradle
File java/build.gradle:

Line 19: buildscript { apply from: file('gradle/buildscript.gradle'), to: 
buildscript }
Got trailing whitespace here.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/dependencies.gradle
File java/gradle/dependencies.gradle:

Line 60: versions["scalaBase"] = versions.scala.substring(0, 
versions.scala.lastIndexOf("."))
> Oh sorry meant to respond. If the Scala version doesn't match this expected
Sure.


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 14
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 14:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/compile.gradle
File java/gradle/compile.gradle:

Line 24: options.fork = true // enable compilation in a separate daemon 
process.
> I didn't mean to suggest it should be removed. I just didn't know whether i
I didn't have a great reason either. So removing it keeps things simple.


Line 31: }
> You'd have to add a Maven profile. See https://stackoverflow.com/a/16743137
After spending more time on this and making the maven profile work. It turns 
out Kudu doesn't have too many errors to overcome like other projects I have 
worked on. I think I will drop this and fix the lint errors. It should make for 
cleaner javadoc in the long run.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/dependencies.gradle
File java/gradle/dependencies.gradle:

Line 60: versions["scalaBase"] = versions.scala.substring(0, 
versions.scala.lastIndexOf("."))
> Missed this?
Oh sorry meant to respond. If the Scala version doesn't match this expected 
pattern, the build would fail and it would show that the "malformed" version 
couldn't be resolved. Perhaps that is good enough?


http://gerrit.cloudera.org:8080/#/c/7258/16/java/gradle/quality.gradle
File java/gradle/quality.gradle:

Line 22: 
> for
Done


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

Line 28:   doLast {
> Could you add a comment explaining that?
Done


http://gerrit.cloudera.org:8080/#/c/7258/16/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

Line 27: task bootstrapWrapper() {
> Single quote was better here.
oopsa little trigger happy on the find and replace.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/kudu-mapreduce/build.gradle
File java/kudu-mapreduce/build.gradle:

Line 17: 
> Hmm, ask Dan?
Will ask.


Line 23:   }
> Nice. Can you add a link to the pull request in each place where you apply 
Done


http://gerrit.cloudera.org:8080/#/c/7258/16/java/kudu-spark/pom.xml
File java/kudu-spark/pom.xml:

Line 108: process-resources
> I didn't see this in the gradle build. Is it built-in to gradle's scala plu
I was playing with the args and left these in. Fixed to match the gradle build 
in compile.gradle. I also added docs for the flags.


http://gerrit.cloudera.org:8080/#/c/7258/16/java/settings.gradle
File java/settings.gradle:

> File-level comment.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 14
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#17).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
A java/kudu-flume-sink/build.gradle
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducer.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKeyedKuduOperationsProducer.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKuduOperationsProducer.java
A java/kudu-jepsen/build.gradle
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
A java/settings.gradle
34 files changed, 1,453 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/17
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 17
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] kudu client tools for hadoop and spark import/export(csv,parquet,avro)

[Sandish Kumar HN (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7421

to look at the new patch set (#4).

Change subject: kudu client tools for hadoop and spark 
import/export(csv,parquet,avro)
..

kudu client tools for hadoop and spark import/export(csv,parquet,avro)

Change-Id: If462af948651f3869b444e82151c3559fde19142
---
M java/kudu-client-tools/pom.xml
A 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsv.java
A 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
A 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
A 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquetMapper.java
A 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ParquetReadSupport.java
A 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
A 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
A 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-spark-tools/pom.xml
A 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
A 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
M java/pom.xml
13 files changed, 1,167 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/7421/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If462af948651f3869b444e82151c3559fde19142
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sandish Kumar HN 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sandish Kumar HN