date:20170901

Hello Dan Burkert, Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/7950

to review the following change.

Change subject: catalog_manager: improve IsAlterInProgress performance
..

catalog_manager: improve IsAlterInProgress performance

To mentally prepare for KUDU-1807, I decided to also tackle the O(n)
behavior of IsAlterInProgress. It's not nearly as bad as IsCreateInProgress
(since we aren't taking cow locks on each tablet) but is still not great
since IsAlterInProgress is called repeatedly by clients.

The solution involves a new map in TableInfo to track the schema versions
of all tablets. Keeping the map up-to-date requires additional work when
adding/removing tablets and when tablet reports include a schema change, but
these are infrequent operations relative to IsAlterInProgress so I figured
the trade off is worth it.

I'm not particularly happy about the lock acquisition in
set_reported_schema_version() but couldn't see a good way to avoid it.

I looped 1000 runs of alter_table-randomized-test. The ~5 failures I saw
were due to KUDU-1539, which I don't think this patch makes us any more or
less vulnerable to.

Change-Id: Id8c1f48c0febad038833edd555ee88f1db83249d
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
2 files changed, 99 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/7950/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8c1f48c0febad038833edd555ee88f1db83249d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [tidy] updated the 'tidy' target

Alexey Serbin has submitted this change and it was merged.

Change subject: [tidy] updated the 'tidy' target
..


[tidy] updated the 'tidy' target

Now the 'tidy' target runs against the set of changelists since the
last committed upstream one.  This makes it consistent with how
the 'ilint' and 'iwyu' targets work.

Change-Id: I2f8db9076d5113ac44fb8200d00965f120126ac4
Reviewed-on: http://gerrit.cloudera.org:8080/7947
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
M build-support/clang_tidy_gerrit.py
A build-support/tidy.sh
3 files changed, 45 insertions(+), 5 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f8db9076d5113ac44fb8200d00965f120126ac4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy

[kudu-CR] [tidy] updated the 'tidy' target

Adar Dembo has posted comments on this change.

Change subject: [tidy] updated the 'tidy' target
..


Patch Set 1: Code-Review+2

Thanks for doing this.

-- 
To view, visit http://gerrit.cloudera.org:8080/7947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f8db9076d5113ac44fb8200d00965f120126ac4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] [tidy] updated the 'tidy' target

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7947

Change subject: [tidy] updated the 'tidy' target
..

[tidy] updated the 'tidy' target

Now the 'tidy' target runs against the set of changelists since the
last committed upstream one.  This makes it consistent with how
the 'ilint' and 'iwyu' targets work.

Change-Id: I2f8db9076d5113ac44fb8200d00965f120126ac4
---
M CMakeLists.txt
M build-support/clang_tidy_gerrit.py
A build-support/tidy.sh
3 files changed, 45 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/7947/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f8db9076d5113ac44fb8200d00965f120126ac4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin

[kudu-CR] java: clarify the use of several compile scopes

Adar Dembo has submitted this change and it was merged.

Change subject: java: clarify the use of several compile scopes
..


java: clarify the use of several compile scopes

After some testing, we've learned that parquet-hadoop and sparkavro should
be in the compile scope because it's pretty rare to see them provided by
platform providers. I added some comments to help clarify this.

Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Reviewed-on: http://gerrit.cloudera.org:8080/7944
Reviewed-by: Dan Burkert 
Tested-by: Kudu Jenkins
---
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
4 files changed, 29 insertions(+), 16 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] java: clarify the use of several compile scopes

Dan Burkert has posted comments on this change.

Change subject: java: clarify the use of several compile scopes
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] java: clarify the use of several compile scopes

Adar Dembo has posted comments on this change.

Change subject: java: clarify the use of several compile scopes
..


Patch Set 2: -Code-Review

-- 
To view, visit http://gerrit.cloudera.org:8080/7944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] java: clarify the use of several compile scopes

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7944

to look at the new patch set (#2).

Change subject: java: clarify the use of several compile scopes
..

java: clarify the use of several compile scopes

After some testing, we've learned that parquet-hadoop and sparkavro should
be in the compile scope because it's pretty rare to see them provided by
platform providers. I added some comments to help clarify this.

Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
---
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
4 files changed, 29 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/7944/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2127: use provided scope for several dependencies

Adar Dembo has posted comments on this change.

Change subject: KUDU-2127: use provided scope for several dependencies
..


Patch Set 1: Code-Review-2

Doing some cluster testing with Dan and it looks like we may need to keep 
spark-avro at compile scope, because it doesn't appear to be commonly provided 
by platform vendors.

-- 
To view, visit http://gerrit.cloudera.org:8080/7944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR](branch-1.5.x) Fixup iwyu and Java header license issues

Dan Burkert has posted comments on this change.

Change subject: Fixup iwyu and Java header license issues
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR](branch-1.5.x) Fixup iwyu and Java header license issues

Dan Burkert has submitted this change and it was merged.

Change subject: Fixup iwyu and Java header license issues
..


Fixup iwyu and Java header license issues

Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Reviewed-on: http://gerrit.cloudera.org:8080/7941
Reviewed-by: Mike Percy 
Tested-by: Kudu Jenkins
(cherry picked from commit 311755895e48a5d52b9f398c8b89847aa808fa19)
Reviewed-on: http://gerrit.cloudera.org:8080/7946
Reviewed-by: Dan Burkert 
Tested-by: Dan Burkert 
---
M LICENSE.txt
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquetMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ParquetReadSupport.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M 
java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M 
java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
17 files changed, 230 insertions(+), 197 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR](branch-1.5.x) Fixup iwyu and Java header license issues

Dan Burkert has posted comments on this change.

Change subject: Fixup iwyu and Java header license issues
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR](branch-1.5.x) Fixup iwyu and Java header license issues

Dan Burkert has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7946

Change subject: Fixup iwyu and Java header license issues
..

Fixup iwyu and Java header license issues

Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Reviewed-on: http://gerrit.cloudera.org:8080/7941
Reviewed-by: Mike Percy 
Tested-by: Kudu Jenkins
(cherry picked from commit 311755895e48a5d52b9f398c8b89847aa808fa19)
---
M LICENSE.txt
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquetMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ParquetReadSupport.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M 
java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M 
java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
17 files changed, 230 insertions(+), 197 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/7946/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert

[kudu-CR] Fixup iwyu and Java header license issues

Dan Burkert has submitted this change and it was merged.

Change subject: Fixup iwyu and Java header license issues
..


Fixup iwyu and Java header license issues

Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Reviewed-on: http://gerrit.cloudera.org:8080/7941
Reviewed-by: Mike Percy 
Tested-by: Kudu Jenkins
---
M LICENSE.txt
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquetMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ParquetReadSupport.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M 
java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M 
java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
17 files changed, 230 insertions(+), 197 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy

[kudu-CR](branch-1.5.x) gradle: also inject mkdir when modifying gradlew

Adar Dembo has submitted this change and it was merged.

Change subject: gradle: also inject mkdir when modifying gradlew
..


gradle: also inject mkdir when modifying gradlew

Now that there are no committed files in the gradle/wrapper subdirectory,
it isn't guaranteed to exist, and if it doesn't, curl fails.

Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Reviewed-on: http://gerrit.cloudera.org:8080/7939
Reviewed-by: Grant Henke 
Reviewed-by: Dan Burkert 
Tested-by: Kudu Jenkins
(cherry picked from commit c8ad6668e8ebe17ff12c70cc77a8ed351595d1e3)
Reviewed-on: http://gerrit.cloudera.org:8080/7940
Reviewed-by: Adar Dembo 
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Fixup iwyu and Java header license issues

2017-09-01 Thread Mike Percy (Code Review)

Mike Percy has posted comments on this change.

Change subject: Fixup iwyu and Java header license issues
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] KUDU-2127: use provided scope for several dependencies

Hello Dan Burkert, Grant Henke,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/7944

to review the following change.

Change subject: KUDU-2127: use provided scope for several dependencies
..

KUDU-2127: use provided scope for several dependencies

Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
---
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
4 files changed, 22 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/7944/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke

[kudu-CR] Fixup iwyu and Java header license issues

Hello Mike Percy, Alexey Serbin,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7941

to look at the new patch set (#2).

Change subject: Fixup iwyu and Java header license issues
..

Fixup iwyu and Java header license issues

Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
---
M LICENSE.txt
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquetMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ParquetReadSupport.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M 
java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M 
java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
17 files changed, 230 insertions(+), 197 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/7941/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy

[kudu-CR] Fixup iwyu and Java header license issues

Dan Burkert has posted comments on this change.

Change subject: Fixup iwyu and Java header license issues
..


Patch Set 2: -Code-Review

-- 
To view, visit http://gerrit.cloudera.org:8080/7941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] [periodic-test] fix flaky PeriodicTimerTest.TestReset

Alexey Serbin has submitted this change and it was merged.

Change subject: [periodic-test] fix flaky PeriodicTimerTest.TestReset
..


[periodic-test] fix flaky PeriodicTimerTest.TestReset

Fixed flake in PeriodicTimerTest.TestReset. The test was a little bit
flaky because sometimes the main test thread might have slept for much
longer than requested, sometimes longer than the period of the task.
If that happened, the test failed with messages like the following:

  src/kudu/rpc/periodic-test.cc:116: Failure
Expected: 0
  To be equal to: counter_
Which is: 1

This fix just increases the period of the task across the board.

Prior to this fix, if running a DEBUG or ASAN build with
--stress-cpu-threads=64, there were about 2 failures every 1K run:
  http://dist-test.cloudera.org//job?job_id=aserbin.1504248200.5336

After the fix there are no failures anymore:
  http://dist-test.cloudera.org//job?job_id=aserbin.1504299298.23673

Change-Id: I6848bee0e830075aba3ae5d8ed49f99038043063
Reviewed-on: http://gerrit.cloudera.org:8080/7932
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/periodic-test.cc
1 file changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6848bee0e830075aba3ae5d8ed49f99038043063
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [periodic-test] fix flaky PeriodicTimerTest.TestReset

Alexey Serbin has posted comments on this change.

Change subject: [periodic-test] fix flaky PeriodicTimerTest.TestReset
..


Patch Set 3:

Thank you for the review.

Please see below for the answers.

 > Two questions:
 > 1. The new period also deflakes the test when looped with stress
 > threads?

Yes, it does -- I ran different build configurations (DEBUG, RELEASE, ASAN, 
TSAN) with --stress-cpu-threads=64 for multiples of 1K, and found no flakes in 
any of my runs.

 > 2. How much slower is a regular run of periodic-test now?

Prior to this fix, the test ran about 1 second for a DEBUG build.  After the 
fix, it runs about 9 seconds.

-- 
To view, visit http://gerrit.cloudera.org:8080/7932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6848bee0e830075aba3ae5d8ed49f99038043063
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Add iwyu note to LICENSE.txt

Dan Burkert has posted comments on this change.

Change subject: Add iwyu note to LICENSE.txt
..


Patch Set 1: Code-Review-2

-- 
To view, visit http://gerrit.cloudera.org:8080/7941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Add iwyu note to LICENSE.txt

2017-09-01 Thread Mike Percy (Code Review)

Mike Percy has posted comments on this change.

Change subject: Add iwyu note to LICENSE.txt
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Add iwyu note to LICENSE.txt

Alexey Serbin has posted comments on this change.

Change subject: Add iwyu note to LICENSE.txt
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Add iwyu note to LICENSE.txt

Hello Mike Percy,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/7941

to review the following change.

Change subject: Add iwyu note to LICENSE.txt
..

Add iwyu note to LICENSE.txt

Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
---
M LICENSE.txt
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/7941/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b1dd4ab4ad0c785e8f5b3652301fed5deb3a962
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Mike Percy

[kudu-CR](branch-1.5.x) gradle: also inject mkdir when modifying gradlew

Adar Dembo has posted comments on this change.

Change subject: gradle: also inject mkdir when modifying gradlew
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR](branch-1.5.x) gradle: also inject mkdir when modifying gradlew

Adar Dembo has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7940

Change subject: gradle: also inject mkdir when modifying gradlew
..

gradle: also inject mkdir when modifying gradlew

Now that there are no committed files in the gradle/wrapper subdirectory,
it isn't guaranteed to exist, and if it doesn't, curl fails.

Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Reviewed-on: http://gerrit.cloudera.org:8080/7939
Reviewed-by: Grant Henke 
Reviewed-by: Dan Burkert 
Tested-by: Kudu Jenkins
(cherry picked from commit c8ad6668e8ebe17ff12c70cc77a8ed351595d1e3)
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/7940/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Adar Dembo

[kudu-CR] gradle: also inject mkdir when modifying gradlew

Adar Dembo has submitted this change and it was merged.

Change subject: gradle: also inject mkdir when modifying gradlew
..


gradle: also inject mkdir when modifying gradlew

Now that there are no committed files in the gradle/wrapper subdirectory,
it isn't guaranteed to exist, and if it doesn't, curl fails.

Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Reviewed-on: http://gerrit.cloudera.org:8080/7939
Reviewed-by: Grant Henke 
Reviewed-by: Dan Burkert 
Tested-by: Kudu Jenkins
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Grant Henke: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [periodic-test] fix flaky PeriodicTimerTest.TestReset

Adar Dembo has posted comments on this change.

Change subject: [periodic-test] fix flaky PeriodicTimerTest.TestReset
..


Patch Set 3: Code-Review+2

Two questions:
1. The new period also deflakes the test when looped with stress threads?
2. How much slower is a regular run of periodic-test now?

-- 
To view, visit http://gerrit.cloudera.org:8080/7932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6848bee0e830075aba3ae5d8ed49f99038043063
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [periodic-test] fix flaky PeriodicTimerTest.TestReset

Alexey Serbin has posted comments on this change.

Change subject: [periodic-test] fix flaky PeriodicTimerTest.TestReset
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7932/2/src/kudu/rpc/periodic-test.cc
File src/kudu/rpc/periodic-test.cc:

Line 44: #ifdef THREAD_SANITIZER
> The other option is to just increase the period across the board. Todd reco
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6848bee0e830075aba3ae5d8ed49f99038043063
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [periodic-test] fix flaky PeriodicTimerTest.TestReset

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7932

to look at the new patch set (#3).

Change subject: [periodic-test] fix flaky PeriodicTimerTest.TestReset
..

[periodic-test] fix flaky PeriodicTimerTest.TestReset

Fixed flake in PeriodicTimerTest.TestReset. The test was a little bit
flaky because sometimes the main test thread might have slept for much
longer than requested, sometimes longer than the period of the task.
If that happened, the test failed with messages like the following:

  src/kudu/rpc/periodic-test.cc:116: Failure
Expected: 0
  To be equal to: counter_
Which is: 1

This fix just increases the period of the task across the board.

Prior to this fix, if running a DEBUG or ASAN build with
--stress-cpu-threads=64, there were about 2 failures every 1K run:
  http://dist-test.cloudera.org//job?job_id=aserbin.1504248200.5336

After the fix there are no failures anymore:
  http://dist-test.cloudera.org//job?job_id=aserbin.1504299298.23673

Change-Id: I6848bee0e830075aba3ae5d8ed49f99038043063
---
M src/kudu/rpc/periodic-test.cc
1 file changed, 8 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/7932/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6848bee0e830075aba3ae5d8ed49f99038043063
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] gradle: also inject mkdir when modifying gradlew

Dan Burkert has posted comments on this change.

Change subject: gradle: also inject mkdir when modifying gradlew
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] gradle: also inject mkdir when modifying gradlew

2017-09-01 Thread Grant Henke (Code Review)

Grant Henke has posted comments on this change.

Change subject: gradle: also inject mkdir when modifying gradlew
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] gradle: also inject mkdir when modifying gradlew

Hello Dan Burkert, Grant Henke,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/7939

to review the following change.

Change subject: gradle: also inject mkdir when modifying gradlew
..

gradle: also inject mkdir when modifying gradlew

Now that there are no committed files in the gradle/wrapper subdirectory,
it isn't guaranteed to exist, and if it doesn't, curl fails.

Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/7939/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke

[kudu-CR] KUDU-1976. java: use ephemeral ports for MiniKDC

Alexey Serbin has submitted this change and it was merged.

Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..


KUDU-1976. java: use ephemeral ports for MiniKDC

This fixes an issue where Java tests would occasionally fail due to failure to
kinit as a principal just after adding it. We initially interpreted this as
a race, but it turns out to be an issue with concurrent test execution on
the same slave:

- We were using Testutils.findFreePort() to look for an open port. This was
  in turn calling TestUtils.getUniqueLocalHost() when it was testing binding
  to ports. Because it used the "unique localhost", it would always successfully
  bind on the first port it tried, since another concurrently-running test
  would not have used that port.

- Meanwhile, when we actually started the KDC, we bound it to 0.0.0.0:
  rather than the unique loopback. This is because the KDC does not actually
  support specifying a bind-address.

- Even worse, the KDC would successfully start up in this case and only log
  a warning that it had failed to bind to the requested port. So, we'd merrily
  continue on our way with a lame-duck KDC.

The tests would often pass despite this, since we'd create our KDC, add a user
to it, and then connect to the _other_ test's KDC. That KDC would likely also
have the appropriate user "testuser". However there was a small window where
the other KDC would have started already but not yet created the "testuser"
user, in which case the test would fail.

This patch fixes the issue by following the same approach as the C++ tests:
we start the KDC on an ephemeral port and then use lsof to figure out which
port it picked.

Change-Id: I1e75d89616e6dbca6e8687eeb23f807c3c7eb952
Reviewed-on: http://gerrit.cloudera.org:8080/7850
Reviewed-by: Dan Burkert 
Tested-by: Alexey Serbin 
---
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
2 files changed, 87 insertions(+), 52 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Alexey Serbin: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e75d89616e6dbca6e8687eeb23f807c3c7eb952
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-1976. java: use ephemeral ports for MiniKDC

Alexey Serbin has posted comments on this change.

Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..


Patch Set 3: Verified+1

Unrelated flake in RaftConsensusITest.TestReplicaBehaviorViaRPC and another 
flake in gradle build.

-- 
To view, visit http://gerrit.cloudera.org:8080/7850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e75d89616e6dbca6e8687eeb23f807c3c7eb952
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-2098. Drop Spark 1 Support

Dan Burkert has submitted this change and it was merged.

Change subject: KUDU-2098. Drop Spark 1 Support
..


KUDU-2098. Drop Spark 1 Support

Spark 2 has been available for over a year and the value of
shipping a seperate Spark 1 artifact is decreasing.
In the case where another Spark 1 release occurs or bug fixes
are needed, updates to the Kudu Spark 1 integration can still
exist via maintenance releases.

This allows us to clean up deprecated mehods that are used for
compatibility purposes and simplifies the build.

Here is the dev mailing list discussion for reference:
https://s.apache.org/PCfg

Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Reviewed-on: http://gerrit.cloudera.org:8080/7690
Reviewed-by: Dan Burkert 
Tested-by: Kudu Jenkins
---
M build-support/jenkins/build-and-test.sh
M java/README.md
M java/gradle/dependencies.gradle
M java/kudu-spark-tools/pom.xml
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
M 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
R java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/package.scala
D java/kudu-spark/src/main/spark1/org/apache/kudu/spark/kudu/package.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduRDDTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
M java/pom.xml
18 files changed, 85 insertions(+), 248 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-01 Thread Mike Percy (Code Review)

Mike Percy has posted comments on this change.

Change subject: KUDU-2124. Don't hold session lock while initializing a 
TabletCopySession
..


Patch Set 2:

> > the remote can time out and retry based on the leader telling
 > > it to retry, and those requests can be stuck in the server's
 > > RPC queue.
 > 
 > Hmm, and we don't want to pay the cost of instantiating any
 > sessions beyond the first one? Okay, I guess I can buy that.
 > 
 > I was asking because if we didn't mind creating the occasional
 > extra session or two (and just let them get cleaned up via
 > "expiration"), we could use an incrementing integer as the session
 > key, which would guarantee no session reuse at all, thus avoiding
 > the thorny synchronization around session creation.
 > 
 > What do you think about using a per-session std::once to guarantee
 > Init is called? The synchronization would be something like this:

On the Init() issue, I think we could make it guaranteed by simply giving the 
session itself a factory method that initializes it before returning it. 
However, I'm concerned about being able to get into a state where the server is 
doing a lot of wasted work initializing sessions, and the client is busy 
retrying and creating lots of extra sessions, resulting in a kind of livelock 
situation. I think the current implementation is simple enough, with the right 
abstractions, to merit using in order to avoid those kinds of nasty issues. In 
the current implementation, the client can start a session, and the RPC can 
time out, but the session will eventually be created. The next time the client 
retries, if the session is already being created, the client will be told to 
try again later. Once the session is initialized, the next time the client asks 
for the session to be created, the initialized session will be returned to the 
client and the client can continue with tablet copy.

-- 
To view, visit http://gerrit.cloudera.org:8080/7919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05f5b3c6a012067c95bb54f040bee2bb19388bfe
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] KUDU-1976. java: use ephemeral ports for MiniKDC

Dan Burkert has posted comments on this change.

Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e75d89616e6dbca6e8687eeb23f807c3c7eb952
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [periodic-test] fix flaky PeriodicTimerTest.TestReset

Adar Dembo has posted comments on this change.

Change subject: [periodic-test] fix flaky PeriodicTimerTest.TestReset
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7932/2/src/kudu/rpc/periodic-test.cc
File src/kudu/rpc/periodic-test.cc:

Line 44: #ifdef THREAD_SANITIZER
The other option is to just increase the period across the board. Todd 
recommended that at first; I pushed back because I wanted the test to run 
quickly. But maybe it's the better move.


-- 
To view, visit http://gerrit.cloudera.org:8080/7932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6848bee0e830075aba3ae5d8ed49f99038043063
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] add outputmetric collecting for the kudu data writing

Dan Burkert has abandoned this change.

Change subject:  add outputmetric collecting for the kudu data writing
..


Abandoned

I'm going to close this for now, but don't hesitate to reopen if a new way 
forward is found.

-- 
To view, visit http://gerrit.cloudera.org:8080/7754
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic3ca4389090f25834d165d36b83f77f1cfa3f726
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: caiconghui 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: caiconghui

[kudu-CR] KUDU-2098. Drop Spark 1 Support

Dan Burkert has posted comments on this change.

Change subject: KUDU-2098. Drop Spark 1 Support
..


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [docs] fixup releasing git instructions

Dan Burkert has posted comments on this change.

Change subject: [docs] fixup releasing git instructions
..


Patch Set 2:

I'll keep updating this as necessary as I work through the 1.5 release, so no 
need to review yet.

-- 
To view, visit http://gerrit.cloudera.org:8080/7876
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83f98350ddcaf062477db1ee0b90f1811f87524b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [docs] fixup releasing git instructions

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7876

to look at the new patch set (#2).

Change subject: [docs] fixup releasing git instructions
..

[docs] fixup releasing git instructions

Change-Id: I83f98350ddcaf062477db1ee0b90f1811f87524b
---
M RELEASING.adoc
1 file changed, 26 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/7876/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7876
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83f98350ddcaf062477db1ee0b90f1811f87524b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2098. Drop Spark 1 Support

2017-09-01 Thread Grant Henke (Code Review)

Grant Henke has posted comments on this change.

Change subject: KUDU-2098. Drop Spark 1 Support
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7690/3//COMMIT_MSG
Commit Message:

Line 13: exist via maintenance relases.
> releases
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1976. java: use ephemeral ports for MiniKDC

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7850

to look at the new patch set (#3).

Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
..

KUDU-1976. java: use ephemeral ports for MiniKDC

This fixes an issue where Java tests would occasionally fail due to failure to
kinit as a principal just after adding it. We initially interpreted this as
a race, but it turns out to be an issue with concurrent test execution on
the same slave:

- We were using Testutils.findFreePort() to look for an open port. This was
  in turn calling TestUtils.getUniqueLocalHost() when it was testing binding
  to ports. Because it used the "unique localhost", it would always successfully
  bind on the first port it tried, since another concurrently-running test
  would not have used that port.

- Meanwhile, when we actually started the KDC, we bound it to 0.0.0.0:
  rather than the unique loopback. This is because the KDC does not actually
  support specifying a bind-address.

- Even worse, the KDC would successfully start up in this case and only log
  a warning that it had failed to bind to the requested port. So, we'd merrily
  continue on our way with a lame-duck KDC.

The tests would often pass despite this, since we'd create our KDC, add a user
to it, and then connect to the _other_ test's KDC. That KDC would likely also
have the appropriate user "testuser". However there was a small window where
the other KDC would have started already but not yet created the "testuser"
user, in which case the test would fail.

This patch fixes the issue by following the same approach as the C++ tests:
we start the KDC on an ephemeral port and then use lsof to figure out which
port it picked.

Change-Id: I1e75d89616e6dbca6e8687eeb23f807c3c7eb952
---
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
2 files changed, 87 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/7850/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e75d89616e6dbca6e8687eeb23f807c3c7eb952
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] WIP: use C++ ExternalMiniCluster for Java and Python tests

Dan Burkert has posted comments on this change.

Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests
..

Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG
Commit Message:

PS2, Line 36: run_cluster
bikesheddy, but I'd prefer 'kudu mini_cluster'. Mini cluster is a pretty well
established term of art.

PS2, Line 47: WIP because, well, it should be pretty obvious. I was able to get
through a
: full run of "mvn verify" locally, so I have confidence that this
can work.
: But I'd like to solicit feedback on the general approach before
spending
: more time applying spit and polish.
> Would it be possible to use JSON format as an internal format of the tool,
I'm on board with protobuf for schema / json as encoded format as well.

http://gerrit.cloudera.org:8080/#/c/7853/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:

Line 83: if (responses.size() == 0) {
Is this possible? I would expect not due to the do part of do/while.

--
To view, visit http://gerrit.cloudera.org:8080/7853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes

[kudu-CR] feat: add task interruption checking for RowIterator

Dan Burkert has posted comments on this change.

Change subject: feat: add task interruption checking for RowIterator
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7753/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala:

Line 23: import org.apache.spark.{InterruptibleIterator, Partition, 
SparkContext, TaskContext}
This is no longer necessary, right?


Line 64: new InterruptibleIterator[Row](taskContext, new 
RowIterator(scanner))
likewise


-- 
To view, visit http://gerrit.cloudera.org:8080/7753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b4284f2c0a40cd7ba8cf2b76e0403592552c814
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: caiconghui 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: caiconghui 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2098. Drop Spark 1 Support

Dan Burkert has posted comments on this change.

Change subject: KUDU-2098. Drop Spark 1 Support
..


Patch Set 3:

(1 comment)

one final nit, but otherwise LGTM

http://gerrit.cloudera.org:8080/#/c/7690/3//COMMIT_MSG
Commit Message:

PS3, Line 13: relases
releases


-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2098. Drop Spark 1 Support

Dan Burkert has posted comments on this change.

Change subject: KUDU-2098. Drop Spark 1 Support
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7690/2/java/kudu-spark-tools/pom.xml
File java/kudu-spark-tools/pom.xml:

Line 30: 
kudu-${spark.version.label}-tools_${scala.binary.version}
> I suspect down the line we will need to support spark3 or Scala 2.12. If it
OK that's reasonable.


-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR](branch-1.5.x) Fix RAT warnings

Dan Burkert has submitted this change and it was merged.

Change subject: Fix RAT warnings
..


Fix RAT warnings

Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Reviewed-on: http://gerrit.cloudera.org:8080/7925
Reviewed-by: Dan Burkert 
Tested-by: Dan Burkert 
(cherry picked from commit ea58982e51fd3f701c734e0ac52b0ee218d7eda3)
Reviewed-on: http://gerrit.cloudera.org:8080/7935
---
M build-support/release/rat_exclude_files.txt
M java/gradle.properties
2 files changed, 7 insertions(+), 10 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR](branch-1.5.x) Fix RAT warnings

Dan Burkert has posted comments on this change.

Change subject: Fix RAT warnings
..


Patch Set 1: Code-Review+2 Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR](branch-1.5.x) gradle: convert gradle-wrapper.properties into a real generated file

Dan Burkert has restored this change.

Change subject: gradle: convert gradle-wrapper.properties into a real generated 
file
..


Restored

-- 
To view, visit http://gerrit.cloudera.org:8080/7934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR](branch-1.5.x) gradle: convert gradle-wrapper.properties into a real generated file

Dan Burkert has submitted this change and it was merged.

Change subject: gradle: convert gradle-wrapper.properties into a real generated 
file
..


gradle: convert gradle-wrapper.properties into a real generated file

Let's handle gradle-wrapper.properties the same way as gradle-wrapper.jar:
by downloading it during invocations of gradlew if it's not already there.

I also put gradle/wrapper into .gitignore since it is only expected to
contain generated files.

Finally, I added an ASL2 header to gradlew and linked to it from Kudu's
central license file.

Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Reviewed-on: http://gerrit.cloudera.org:8080/7927
Reviewed-by: Mike Percy 
Tested-by: Kudu Jenkins
(cherry picked from commit cc0b19e912de7126a25695466215803c3efbaa4c)
Reviewed-on: http://gerrit.cloudera.org:8080/7934
Reviewed-by: Dan Burkert 
Tested-by: Dan Burkert 
---
M LICENSE.txt
M java/.gitignore
M java/gradle/wrapper.gradle
D java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
5 files changed, 31 insertions(+), 10 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR](branch-1.5.x) gradle: convert gradle-wrapper.properties into a real generated file

Dan Burkert has posted comments on this change.

Change subject: gradle: convert gradle-wrapper.properties into a real generated 
file
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Fix RAT warnings

Dan Burkert has submitted this change and it was merged.

Change subject: Fix RAT warnings
..


Fix RAT warnings

Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Reviewed-on: http://gerrit.cloudera.org:8080/7925
Reviewed-by: Dan Burkert 
Tested-by: Dan Burkert 
---
M build-support/release/rat_exclude_files.txt
M java/gradle.properties
2 files changed, 7 insertions(+), 10 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy

[kudu-CR](branch-1.5.x) Fix RAT warnings

Dan Burkert has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7935

Change subject: Fix RAT warnings
..

Fix RAT warnings

Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Reviewed-on: http://gerrit.cloudera.org:8080/7925
Reviewed-by: Dan Burkert 
Tested-by: Dan Burkert 
(cherry picked from commit ea58982e51fd3f701c734e0ac52b0ee218d7eda3)
---
M build-support/release/rat_exclude_files.txt
M java/gradle.properties
2 files changed, 7 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/7935/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert

[kudu-CR] Fix RAT warnings

Dan Burkert has posted comments on this change.

Change subject: Fix RAT warnings
..


Patch Set 4: Code-Review+2 Verified+1

(4 comments)

We discussed all of these changes yesterday and I think everyone's on board, so 
I'm going to go ahead in order to make progress on the release.

http://gerrit.cloudera.org:8080/#/c/7925/1/build-support/release/rat_exclude_files.txt
File build-support/release/rat_exclude_files.txt:

Line 16: java/kudu-flume-sink/src/test/avro/testAvroKuduOperationsProducer.avsc
> Can remove this w/ the patch I posted
Done


Line 17: 
java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
> Same
We didn't author this file.


Line 30: python/README.md
> actually since this is from AsyncHBase I think we are already covered in li
Done


Line 175: www/epoch.0.5.2.min.css
> cool, this stuff is already there in LICENSE.txt
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR](branch-1.5.x) gradle: convert gradle-wrapper.properties into a real generated file

Dan Burkert has abandoned this change.

Change subject: gradle: convert gradle-wrapper.properties into a real generated 
file
..


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/7934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Fix RAT warnings

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7925

to look at the new patch set (#4).

Change subject: Fix RAT warnings
..

Fix RAT warnings

Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
---
M build-support/release/rat_exclude_files.txt
M java/gradle.properties
2 files changed, 7 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/7925/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy

[kudu-CR](branch-1.5.x) gradle: convert gradle-wrapper.properties into a real generated file

Dan Burkert has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7934

Change subject: gradle: convert gradle-wrapper.properties into a real generated 
file
..

gradle: convert gradle-wrapper.properties into a real generated file

Let's handle gradle-wrapper.properties the same way as gradle-wrapper.jar:
by downloading it during invocations of gradlew if it's not already there.

I also put gradle/wrapper into .gitignore since it is only expected to
contain generated files.

Finally, I added an ASL2 header to gradlew and linked to it from Kudu's
central license file.

Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Reviewed-on: http://gerrit.cloudera.org:8080/7927
Reviewed-by: Mike Percy 
Tested-by: Kudu Jenkins
(cherry picked from commit cc0b19e912de7126a25695466215803c3efbaa4c)
---
M LICENSE.txt
M java/.gitignore
M java/gradle/wrapper.gradle
D java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
5 files changed, 31 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/7934/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo

[kudu-CR](branch-1.5.x) gradle: convert gradle-wrapper.properties into a real generated file

Dan Burkert has posted comments on this change.

Change subject: gradle: convert gradle-wrapper.properties into a real generated 
file
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] gradle: convert gradle-wrapper.properties into a real generated file

Dan Burkert has submitted this change and it was merged.

Change subject: gradle: convert gradle-wrapper.properties into a real generated 
file
..


gradle: convert gradle-wrapper.properties into a real generated file

Let's handle gradle-wrapper.properties the same way as gradle-wrapper.jar:
by downloading it during invocations of gradlew if it's not already there.

I also put gradle/wrapper into .gitignore since it is only expected to
contain generated files.

Finally, I added an ASL2 header to gradlew and linked to it from Kudu's
central license file.

Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Reviewed-on: http://gerrit.cloudera.org:8080/7927
Reviewed-by: Mike Percy 
Tested-by: Kudu Jenkins
---
M LICENSE.txt
M java/.gitignore
M java/gradle/wrapper.gradle
D java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
5 files changed, 31 insertions(+), 10 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy

[kudu-CR] [periodic-test] fix flaky PeriodicTimerTest.TestReset