Dan Burkert has posted comments on this change. Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG Commit Message: PS2, Line 36: run_cluster bikesheddy, but I'd prefer 'kudu mini_cluster'. Mini cluster is a pretty well established term of art. PS2, Line 47: WIP because, well, it should be pretty obvious. I was able to get through a : full run of "mvn verify" locally, so I have confidence that this can work. : But I'd like to solicit feedback on the general approach before spending : more time applying spit and polish. > Would it be possible to use JSON format as an internal format of the tool, I'm on board with protobuf for schema / json as encoded format as well. http://gerrit.cloudera.org:8080/#/c/7853/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java: Line 83: if (responses.size() == 0) { Is this possible? I would expect not due to the do part of do/while. -- To view, visit http://gerrit.cloudera.org:8080/7853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
