[kudu-CR] add a tool to create table
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14306 to look at the new patch set (#13). Change subject: add a tool to create table .. add a tool to create table Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 --- M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool.proto M src/kudu/tools/tool_action_table.cc 5 files changed, 1,406 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/14306/13 -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 13 Gerrit-Owner: YangSong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong
[kudu-CR] add a tool to create table
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14306 to look at the new patch set (#12). Change subject: add a tool to create table .. add a tool to create table Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 --- M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool.proto M src/kudu/tools/tool_action_table.cc 5 files changed, 1,407 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/14306/12 -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 12 Gerrit-Owner: YangSong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong
[kudu-CR] add a tool to create table
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 ) Change subject: add a tool to create table .. Patch Set 11: > I can't understand the failure in the jenkins. In `IWYU.log` no > error message found. I suspect there is something wrong with the > code version. Right, it's not an error message, but IWYU says it wants you to fix include directives in src/kudu/tools/tool_action_table.cc Basically, you need to update your code as it says and submit the new version of the patch for review. You can save the following into the file (say, /tmp/iwyu.diff) and then apply it from the root of your kudu workspace: patch -p0 < /tmp/iwyu.diff # snip # --- src/kudu/tools/tool_action_table.cc +++ src/kudu/tools/tool_action_table.cc @@ -17,7 +17,6 @@ #include #include - #include #include #include @@ -32,6 +31,8 @@ #include #include #include +#include +#include #include #include # snip # -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 11 Gerrit-Owner: YangSong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong Gerrit-Comment-Date: Sat, 12 Oct 2019 02:29:42 + Gerrit-HasComments: No
[kudu-CR] KUDU-2800 Test long bootstrapping tablet replicas
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14300 ) Change subject: KUDU-2800 Test long bootstrapping tablet replicas .. Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/14300/15/src/kudu/integration-tests/raft_config_change-itest.cc File src/kudu/integration-tests/raft_config_change-itest.cc: http://gerrit.cloudera.org:8080/#/c/14300/15/src/kudu/integration-tests/raft_config_change-itest.cc@519 PS15, Line 519: tablet_open_bootstrap_inject_latency_ms tablet_bootstrap_inject_latency_ms http://gerrit.cloudera.org:8080/#/c/14300/15/src/kudu/integration-tests/raft_config_change-itest.cc@563 PS15, Line 563: tablet_open_bootstrap_inject_latency_ms tablet_bootstrap_inject_latency_ms -- To view, visit http://gerrit.cloudera.org:8080/14300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 Gerrit-Change-Number: 14300 Gerrit-PatchSet: 15 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 12 Oct 2019 02:15:28 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2800 Test long bootstrapping tablet replicas
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14300 ) Change subject: KUDU-2800 Test long bootstrapping tablet replicas .. Patch Set 15: > > Build Failed > > > > http://jenkins.kudu.apache.org/job/kudu-gerrit/19081/ : FAILURE > > It seems something went wrong: the newly introduced tests reported > an error: > > http://jenkins.kudu.apache.org/job/kudu-gerrit/19081/ > > One of the failures: > http://dist-test.cloudera.org/job?job_id=jenkins-slave.1570832890.32521 Ah, the problem is with --tablet_open_bootstrap_inject_latency_ms flag: the flag has been renamed, and the tests failed because of that. It's necessary to update the tests as well to reflect the new name of the flag. -- To view, visit http://gerrit.cloudera.org:8080/14300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 Gerrit-Change-Number: 14300 Gerrit-PatchSet: 15 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 12 Oct 2019 02:14:08 + Gerrit-HasComments: No
[kudu-CR] KUDU-2800 Test long bootstrapping tablet replicas
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14300 ) Change subject: KUDU-2800 Test long bootstrapping tablet replicas .. Patch Set 15: > Build Failed > > http://jenkins.kudu.apache.org/job/kudu-gerrit/19081/ : FAILURE It seems something went wrong: the newly introduced tests reported an error: http://jenkins.kudu.apache.org/job/kudu-gerrit/19081/ One of the failures: http://dist-test.cloudera.org/job?job_id=jenkins-slave.1570832890.32521 -- To view, visit http://gerrit.cloudera.org:8080/14300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 Gerrit-Change-Number: 14300 Gerrit-PatchSet: 15 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 12 Oct 2019 02:11:39 + Gerrit-HasComments: No
[kudu-CR] KUDU-2800 Test long bootstrapping tablet replicas
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14300 ) Change subject: KUDU-2800 Test long bootstrapping tablet replicas .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc@142 PS11, Line 142: "Injects latency into the tablet bootstrapping." > Sorry, missed that comment. I think the space is missing after the period in the first sentence: "Injects latency into the tablet bootstrapping." "For use in tests only." Once those two lines are merged, there will be no space in the description of the flag. -- To view, visit http://gerrit.cloudera.org:8080/14300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 Gerrit-Change-Number: 14300 Gerrit-PatchSet: 15 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 12 Oct 2019 02:08:24 + Gerrit-HasComments: Yes
[kudu-CR] util: gscoped ptr -> unique ptr
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14419 ) Change subject: util: gscoped_ptr -> unique_ptr .. util: gscoped_ptr -> unique_ptr This replaces all usages of gscoped_ptr with unique_ptr. I also made some trivial gscoped_ptr -> unique_ptr conversions here and there, and replaced a couple `ifndef`s with `pragma once`s. There are no functional changes in this patch. Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983 Reviewed-on: http://gerrit.cloudera.org:8080/14419 Reviewed-by: Alexey Serbin Tested-by: Kudu Jenkins --- M src/kudu/codegen/compilation_manager.h M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/consensus_peers-test.cc M src/kudu/consensus/consensus_queue-test.cc M src/kudu/consensus/leader_election-test.cc M src/kudu/consensus/log.cc M src/kudu/consensus/log.h M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/fs/data_dirs.cc M src/kudu/kserver/kserver.h M src/kudu/master/catalog_manager.h M src/kudu/master/master.h M src/kudu/rpc/messenger.h M src/kudu/tablet/tablet_replica-test.cc M src/kudu/thrift/client.h M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_checksum.h M src/kudu/tools/table_scanner.h M src/kudu/tserver/tablet_copy_source_session-test.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/util/countdown_latch-test.cc M src/kudu/util/curl_util-test.cc M src/kudu/util/maintenance_manager.h M src/kudu/util/net/dns_resolver.h M src/kudu/util/threadpool-test.cc M src/kudu/util/threadpool.cc M src/kudu/util/threadpool.h M src/kudu/util/trace.h 29 files changed, 66 insertions(+), 89 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983 Gerrit-Change-Number: 14419 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] util: gscoped ptr -> unique ptr
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14419 ) Change subject: util: gscoped_ptr -> unique_ptr .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14419/1/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/14419/1/src/kudu/util/threadpool.cc@128 PS1, Line 128: return (*pool)->Init(); : } > Done Thank you! -- To view, visit http://gerrit.cloudera.org:8080/14419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983 Gerrit-Change-Number: 14419 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 12 Oct 2019 01:48:50 + Gerrit-HasComments: Yes
[kudu-CR] util: gscoped ptr -> unique ptr
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14419 to look at the new patch set (#2). Change subject: util: gscoped_ptr -> unique_ptr .. util: gscoped_ptr -> unique_ptr This replaces all usages of gscoped_ptr with unique_ptr. I also made some trivial gscoped_ptr -> unique_ptr conversions here and there, and replaced a couple `ifndef`s with `pragma once`s. There are no functional changes in this patch. Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983 --- M src/kudu/codegen/compilation_manager.h M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/consensus_peers-test.cc M src/kudu/consensus/consensus_queue-test.cc M src/kudu/consensus/leader_election-test.cc M src/kudu/consensus/log.cc M src/kudu/consensus/log.h M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/fs/data_dirs.cc M src/kudu/kserver/kserver.h M src/kudu/master/catalog_manager.h M src/kudu/master/master.h M src/kudu/rpc/messenger.h M src/kudu/tablet/tablet_replica-test.cc M src/kudu/thrift/client.h M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_checksum.h M src/kudu/tools/table_scanner.h M src/kudu/tserver/tablet_copy_source_session-test.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/util/countdown_latch-test.cc M src/kudu/util/curl_util-test.cc M src/kudu/util/maintenance_manager.h M src/kudu/util/net/dns_resolver.h M src/kudu/util/threadpool-test.cc M src/kudu/util/threadpool.cc M src/kudu/util/threadpool.h M src/kudu/util/trace.h 29 files changed, 66 insertions(+), 89 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/14419/2 -- To view, visit http://gerrit.cloudera.org:8080/14419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983 Gerrit-Change-Number: 14419 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] util: gscoped ptr -> unique ptr
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14419 ) Change subject: util: gscoped_ptr -> unique_ptr .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14419/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14419/1//COMMIT_MSG@15 PS1, Line 15: are no funct > It sounds like you are not quite sure? :) :) http://gerrit.cloudera.org:8080/#/c/14419/1/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/14419/1/src/kudu/util/threadpool.cc@128 PS1, Line 128: return (*pool)->Init(); : } > nit: while you are at it, maybe you could merge these two lines into Done -- To view, visit http://gerrit.cloudera.org:8080/14419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983 Gerrit-Change-Number: 14419 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 12 Oct 2019 01:30:38 + Gerrit-HasComments: Yes
[kudu-CR] util: gscoped ptr -> unique ptr
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14419 ) Change subject: util: gscoped_ptr -> unique_ptr .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/14419/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14419/1//COMMIT_MSG@15 PS1, Line 15: should be no It sounds like you are not quite sure? :) http://gerrit.cloudera.org:8080/#/c/14419/1/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/14419/1/src/kudu/util/threadpool.cc@128 PS1, Line 128: RETURN_NOT_OK((*pool)->Init()); : return Status::OK(); nit: while you are at it, maybe you could merge these two lines into return (*pool)->Init(); ? -- To view, visit http://gerrit.cloudera.org:8080/14419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983 Gerrit-Change-Number: 14419 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 12 Oct 2019 00:50:50 + Gerrit-HasComments: Yes
[kudu-CR] util: gscoped ptr -> unique ptr
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14419 Change subject: util: gscoped_ptr -> unique_ptr .. util: gscoped_ptr -> unique_ptr This replaces all usages of gscoped_ptr with unique_ptr. I also made some trivial gscoped_ptr -> unique_ptr conversions here and there, and replaced a couple `ifndef`s with `pragma once`s. There should be no functional changes in this patch. Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983 --- M src/kudu/codegen/compilation_manager.h M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/consensus_peers-test.cc M src/kudu/consensus/consensus_queue-test.cc M src/kudu/consensus/leader_election-test.cc M src/kudu/consensus/log.cc M src/kudu/consensus/log.h M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/fs/data_dirs.cc M src/kudu/kserver/kserver.h M src/kudu/master/catalog_manager.h M src/kudu/master/master.h M src/kudu/rpc/messenger.h M src/kudu/tablet/tablet_replica-test.cc M src/kudu/thrift/client.h M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_checksum.h M src/kudu/tools/table_scanner.h M src/kudu/tserver/tablet_copy_source_session-test.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/util/countdown_latch-test.cc M src/kudu/util/curl_util-test.cc M src/kudu/util/maintenance_manager.h M src/kudu/util/net/dns_resolver.h M src/kudu/util/threadpool-test.cc M src/kudu/util/threadpool.cc M src/kudu/util/threadpool.h M src/kudu/util/trace.h 29 files changed, 65 insertions(+), 87 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/14419/1 -- To view, visit http://gerrit.cloudera.org:8080/14419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983 Gerrit-Change-Number: 14419 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
[kudu-CR](branch-1.11.x) [docs] add 1.11.0 release notes
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14418 ) Change subject: [docs] add 1.11.0 release notes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14418/1//COMMIT_MSG Commit Message: PS1: A pre-rendered version is available at: https://gist.github.com/alexeyserbin/53200325d07f4c922682580489e3d45f -- To view, visit http://gerrit.cloudera.org:8080/14418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.11.x Gerrit-MessageType: comment Gerrit-Change-Id: I64ac48bfdcc4eb1b9c87af5be6dc9d8ecc219074 Gerrit-Change-Number: 14418 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: ZhangYao Gerrit-Comment-Date: Sat, 12 Oct 2019 00:06:55 + Gerrit-HasComments: Yes
[kudu-CR] [docs] add 1.11.0 release notes
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14414 ) Change subject: [docs] add 1.11.0 release notes .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14414/1/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/14414/1/docs/release_notes.adoc@42 PS1, Line 42: [[rn_1.11.0_obsoletions]] > do we need an empty Obsoletions section in RNs? I suggest that we either r Done http://gerrit.cloudera.org:8080/#/c/14414/1/docs/release_notes.adoc@46 PS1, Line 46: == Deprecations > same here, empty section looks strange. Done -- To view, visit http://gerrit.cloudera.org:8080/14414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64ac48bfdcc4eb1b9c87af5be6dc9d8ecc219074 Gerrit-Change-Number: 14414 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 11 Oct 2019 23:56:51 + Gerrit-HasComments: Yes
[kudu-CR] [docs] add 1.11.0 release notes
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/14414 ) Change subject: [docs] add 1.11.0 release notes .. Abandoned It seems I submitted the review against wrong version (master). I re-submitted the patch after addressing Greg's comments as https://gerrit.cloudera.org/#/c/14418/ -- To view, visit http://gerrit.cloudera.org:8080/14414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I64ac48bfdcc4eb1b9c87af5be6dc9d8ecc219074 Gerrit-Change-Number: 14414 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR](branch-1.11.x) [docs] add 1.11.0 release notes
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14418 Change subject: [docs] add 1.11.0 release notes .. [docs] add 1.11.0 release notes Change-Id: I64ac48bfdcc4eb1b9c87af5be6dc9d8ecc219074 --- M docs/release_notes.adoc 1 file changed, 191 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14418/1 -- To view, visit http://gerrit.cloudera.org:8080/14418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.11.x Gerrit-MessageType: newchange Gerrit-Change-Id: I64ac48bfdcc4eb1b9c87af5be6dc9d8ecc219074 Gerrit-Change-Number: 14418 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] KUDU-2800 Test long bootstrapping tablet replicas
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14300 ) Change subject: KUDU-2800 Test long bootstrapping tablet replicas .. Patch Set 15: (16 comments) http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@10 PS14, Line 10: a tablet repli > nit: a tablet replica Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@11 PS14, Line 11: The follow > nit: The following cases Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@13 PS14, Line 13: A tablet repli > A tablet replica Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@14 PS14, Line 14: he replica is not evicted from > It might be a bit of overstatement: leader replica might change during that Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@14 PS14, Line 14: that time. > nit: during this time Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@16 PS14, Line 16: ished. > A tablet replica Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@17 PS14, Line 17: > the replica Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@18 PS14, Line 18: ca is s > The replica Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@18 PS14, Line 18: ome > finds Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@18 PS14, Line 18: During this time > that is has been evicted from the tablet Raft configuration Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@20 PS14, Line 20: replication). > A tablet replica Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@22 PS14, Line 22: > The replica eventually starts Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@22 PS14, Line 22: > that it has been evicted from the tablet Raft configuration Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@22 PS14, Line 22: > finds Done http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc@141 PS11, Line 141: tablet_bootstrap_inject_latency_ms, 0, > It seems you didn't address (missed?) this comment. Sorry, missed that comment. http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc@142 PS11, Line 142: "Injects latency into the tablet bootstrapping." > It seems you didn't address (missed?) this comment. Sorry, missed that comment. Where to add a space ? -- To view, visit http://gerrit.cloudera.org:8080/14300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 Gerrit-Change-Number: 14300 Gerrit-PatchSet: 15 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 11 Oct 2019 22:19:46 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2800 Test long bootstrapping tablet replicas
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14300 to look at the new patch set (#15). Change subject: KUDU-2800 Test long bootstrapping tablet replicas .. KUDU-2800 Test long bootstrapping tablet replicas These tests cover change of consensus state in case of long bootstrapping of a tablet replica. The following cases are covered: 1) A tablet replica bootstraps long time. No data modications happen during that time. The replica is not evicted from the tablet Raft configuration and joins the quorum after the bootstrapping process is finished. 2) A tablet replica is shut down for some time. During this time a lot of data modifications happen, log rolls, the replica is replaced (with re-replication). The replica restarts and finds out that is has been evicted from the tablet Raft configuration. 3) A tablet replica bootstraps long time. During this time a lot of data modifications happen, log rolls, the replica is replaced (with re-replication). The replica eventually finishes boostrap and finds out that is has been evicted from the tablet Raft configuration. Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 --- M src/kudu/integration-tests/raft_config_change-itest.cc M src/kudu/tserver/ts_tablet_manager.cc 2 files changed, 163 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/14300/15 -- To view, visit http://gerrit.cloudera.org:8080/14300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 Gerrit-Change-Number: 14300 Gerrit-PatchSet: 15 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] KUDU-2800 Test long bootstrapping tablet replicas
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14300 ) Change subject: KUDU-2800 Test long bootstrapping tablet replicas .. Patch Set 14: (16 comments) http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@10 PS14, Line 10: tablet replica nit: a tablet replica http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@11 PS14, Line 11: There case nit: The following cases http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@13 PS14, Line 13: Tablet replica A tablet replica http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@14 PS14, Line 14: these time nit: during this time http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@14 PS14, Line 14: Consensus state does not change It might be a bit of overstatement: leader replica might change during that period, etc. To be specific, maybe rephrase with: The replica is not evicted from the tablet Raft configuration and joins the quorum after the bootstrapping process is finished. http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@16 PS14, Line 16: Tablet replica A tablet replica http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@17 PS14, Line 17: replica the replica http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@18 PS14, Line 18: Replica The replica http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@18 PS14, Line 18: the it fell behind that is has been evicted from the tablet Raft configuration http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@18 PS14, Line 18: find finds http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@20 PS14, Line 20: Tablet replica A tablet replica http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@22 PS14, Line 22: the it fell behind that it has been evicted from the tablet Raft configuration http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@22 PS14, Line 22: find finds http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@22 PS14, Line 22: Replica restarts The replica eventually starts http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc@141 PS11, Line 141: tablet_open_bootstrap_inject_latency_ms > nit: why not simply tablet_bootstrap_inject_latency_ms ? It seems you didn't address (missed?) this comment. http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc@142 PS11, Line 142: "Injects latency into the tablet bootstrapping." > nit: add a space It seems you didn't address (missed?) this comment. -- To view, visit http://gerrit.cloudera.org:8080/14300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 Gerrit-Change-Number: 14300 Gerrit-PatchSet: 14 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 11 Oct 2019 21:47:27 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2800 Test long bootstrapping tablet replicas
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14300 ) Change subject: KUDU-2800 Test long bootstrapping tablet replicas .. Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/14300/13/src/kudu/integration-tests/raft_config_change-itest.cc File src/kudu/integration-tests/raft_config_change-itest.cc: http://gerrit.cloudera.org:8080/#/c/14300/13/src/kudu/integration-tests/raft_config_change-itest.cc@484 PS13, Line 484: ery > server Done http://gerrit.cloudera.org:8080/#/c/14300/13/src/kudu/integration-tests/raft_config_change-itest.cc@518 PS13, Line 518: > nit: While this helps emphasize that we're not falling behind in this test, Done http://gerrit.cloudera.org:8080/#/c/14300/13/src/kudu/integration-tests/raft_config_change-itest.cc@571 PS13, Line 571: ASSERT_OK(GetLeaderReplicaWithRetries(tablet_id_, )); > nit: Isn't this just `ts`? Done -- To view, visit http://gerrit.cloudera.org:8080/14300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 Gerrit-Change-Number: 14300 Gerrit-PatchSet: 14 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 11 Oct 2019 21:05:16 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2800 Test long bootstrapping tablet replicas
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14300 to look at the new patch set (#14). Change subject: KUDU-2800 Test long bootstrapping tablet replicas .. KUDU-2800 Test long bootstrapping tablet replicas These tests cover change of consensus state in case of long bootstrapping of tablet replica. There case are covered: 1) Tablet replica bootstraps long time. No data modications happen during these time. Consensus state does not change. 2) Tablet replica is shutdown for some time. During this time a lot of data modifications happen, log rolls, replica is replaced (with re-replication). Replica restarts and find out the it fell behind. 3) Tablet replica bootstraps long time. During this time a lot of data modifications happen, log rolls, replica is replaced (with re-replication). Replica restarts and find out the it fell behind. Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 --- M src/kudu/integration-tests/raft_config_change-itest.cc M src/kudu/tserver/ts_tablet_manager.cc 2 files changed, 163 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/14300/14 -- To view, visit http://gerrit.cloudera.org:8080/14300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 Gerrit-Change-Number: 14300 Gerrit-PatchSet: 14 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR](branch-1.11.x) [clock] log on CombineClocks() status only via VLOG
Hello Kudu Jenkins, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14417 to review the following change. Change subject: [clock] log on CombineClocks() status only via VLOG .. [clock] log on CombineClocks() status only via VLOG The logs about the walltime-would-move-back outcome of BuiltInNtp::CombineClocks() look a bit scary, but de facto they are benign and of nothing irregular in case of jittery reference servers. Let's output them as VLOG(1) messages. These should eventually be gone once the proper clock selection algorithm is implemented (see KUDU-2939 for details). Change-Id: I77ba6ea37b0e94058eaab018ae4d66976f0482cd Reviewed-on: http://gerrit.cloudera.org:8080/14416 Tested-by: Kudu Jenkins Reviewed-by: Grant Henke (cherry picked from commit 2768c156186e3da9693ddeff78a8d3206827fb88) --- M src/kudu/clock/builtin_ntp.cc 1 file changed, 8 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14417/1 -- To view, visit http://gerrit.cloudera.org:8080/14417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.11.x Gerrit-MessageType: newchange Gerrit-Change-Id: I77ba6ea37b0e94058eaab018ae4d66976f0482cd Gerrit-Change-Number: 14417 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [clock] log on CombineClocks() status only via VLOG
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14416 ) Change subject: [clock] log on CombineClocks() status only via VLOG .. [clock] log on CombineClocks() status only via VLOG The logs about the walltime-would-move-back outcome of BuiltInNtp::CombineClocks() look a bit scary, but de facto they are benign and of nothing irregular in case of jittery reference servers. Let's output them as VLOG(1) messages. These should eventually be gone once the proper clock selection algorithm is implemented (see KUDU-2939 for details). Change-Id: I77ba6ea37b0e94058eaab018ae4d66976f0482cd Reviewed-on: http://gerrit.cloudera.org:8080/14416 Tested-by: Kudu Jenkins Reviewed-by: Grant Henke --- M src/kudu/clock/builtin_ntp.cc 1 file changed, 8 insertions(+), 12 deletions(-) Approvals: Kudu Jenkins: Verified Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I77ba6ea37b0e94058eaab018ae4d66976f0482cd Gerrit-Change-Number: 14416 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Update version to 1.12.0-SNAPSHOT
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14413 ) Change subject: Update version to 1.12.0-SNAPSHOT .. Update version to 1.12.0-SNAPSHOT Change-Id: Ifd7a8e1de46cc4ac548c57337326e3f25a6a2099 Reviewed-on: http://gerrit.cloudera.org:8080/14413 Tested-by: Alexey Serbin Reviewed-by: Grant Henke --- M docs/release_notes.adoc M examples/java/java-example/pom.xml M version.txt 3 files changed, 30 insertions(+), 40 deletions(-) Approvals: Alexey Serbin: Verified Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifd7a8e1de46cc4ac548c57337326e3f25a6a2099 Gerrit-Change-Number: 14413 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Update version to 1.12.0-SNAPSHOT
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14413 ) Change subject: Update version to 1.12.0-SNAPSHOT .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd7a8e1de46cc4ac548c57337326e3f25a6a2099 Gerrit-Change-Number: 14413 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Oct 2019 18:19:02 + Gerrit-HasComments: No
[kudu-CR] [clock] log on CombineClocks() status only via VLOG
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14416 ) Change subject: [clock] log on CombineClocks() status only via VLOG .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77ba6ea37b0e94058eaab018ae4d66976f0482cd Gerrit-Change-Number: 14416 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Oct 2019 18:18:20 + Gerrit-HasComments: No
[kudu-CR] [clock] log on CombineClocks() status only via VLOG
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14416 Change subject: [clock] log on CombineClocks() status only via VLOG .. [clock] log on CombineClocks() status only via VLOG The logs about the walltime-would-move-back outcome of BuiltInNtp::CombineClocks() look a bit scary, but de facto they are benign and of nothing irregular in case of jittery reference servers. Let's output them as VLOG(1) messages. These should eventually be gone once the proper clock selection algorithm is implemented (see KUDU-2939 for details). Change-Id: I77ba6ea37b0e94058eaab018ae4d66976f0482cd --- M src/kudu/clock/builtin_ntp.cc 1 file changed, 8 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/14416/1 -- To view, visit http://gerrit.cloudera.org:8080/14416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I77ba6ea37b0e94058eaab018ae4d66976f0482cd Gerrit-Change-Number: 14416 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [build] Fix a bug for memory gc-itest
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14415 ) Change subject: [build] Fix a bug for memory_gc-itest .. Patch Set 1: Code-Review+2 Good catch! -- To view, visit http://gerrit.cloudera.org:8080/14415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2982af9c7070ffd0f53791d4960c3bccfee4a8cc Gerrit-Change-Number: 14415 Gerrit-PatchSet: 1 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Fri, 11 Oct 2019 16:48:24 + Gerrit-HasComments: No
[kudu-CR] [build] Fix a bug for memory gc-itest
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14415 ) Change subject: [build] Fix a bug for memory_gc-itest .. [build] Fix a bug for memory_gc-itest In CMakeList.txt, we should use KUDU_TCMALLOC_AVAILABLE to determine whether tcmalloc is enabled instead of TCMALLOC_ENABLED. Change-Id: I2982af9c7070ffd0f53791d4960c3bccfee4a8cc Reviewed-on: http://gerrit.cloudera.org:8080/14415 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/integration-tests/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2982af9c7070ffd0f53791d4960c3bccfee4a8cc Gerrit-Change-Number: 14415 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
[kudu-CR] [docs] add 1.11.0 release notes
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14414 ) Change subject: [docs] add 1.11.0 release notes .. Patch Set 1: Verified+1 Unrelated failures in tests: * org.apache.kudu.mapreduce.tools.ITExportCsv * org.apache.kudu.spark.kudu.DefaultSourceTest * -- To view, visit http://gerrit.cloudera.org:8080/14414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64ac48bfdcc4eb1b9c87af5be6dc9d8ecc219074 Gerrit-Change-Number: 14414 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 11 Oct 2019 16:11:37 + Gerrit-HasComments: No
[kudu-CR] [docs] add 1.11.0 release notes
Alexey Serbin has removed a vote on this change. Change subject: [docs] add 1.11.0 release notes .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I64ac48bfdcc4eb1b9c87af5be6dc9d8ecc219074 Gerrit-Change-Number: 14414 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] Update version to 1.12.0-SNAPSHOT
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14413 ) Change subject: Update version to 1.12.0-SNAPSHOT .. Patch Set 2: Verified+1 Unrelated failures of tests: * org.apache.kudu.flume.sink.SecureKuduSinkTest -- To view, visit http://gerrit.cloudera.org:8080/14413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd7a8e1de46cc4ac548c57337326e3f25a6a2099 Gerrit-Change-Number: 14413 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Oct 2019 16:09:37 + Gerrit-HasComments: No
[kudu-CR] Update version to 1.12.0-SNAPSHOT
Alexey Serbin has removed a vote on this change. Change subject: Update version to 1.12.0-SNAPSHOT .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ifd7a8e1de46cc4ac548c57337326e3f25a6a2099 Gerrit-Change-Number: 14413 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2914: Rebalance tool support moving replicas from some specific tablet servers
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14154 ) Change subject: KUDU-2914: Rebalance tool support moving replicas from some specific tablet servers .. Patch Set 6: > Patch Set 4: > > I added a comment on the JIRA for more context. I hope it's useful: > > https://issues.apache.org/jira/browse/KUDU-2914?focusedCommentId=16941152=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16941152 According to the latest recommendations on the JIRA, the progress of moving replicas on a tablet server has been implemented by marking all replicas with REPLACE attribute. And before starting to move replicas, we'll check whether all specified tablet servers are set into maintenance mode first. Please have a look at the new patch set:) -- To view, visit http://gerrit.cloudera.org:8080/14154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86cfb740030946c13db1a9ca63d241f4907d6c89 Gerrit-Change-Number: 14154 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Fri, 11 Oct 2019 12:19:35 + Gerrit-HasComments: No
[kudu-CR] add a tool to create table
YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 ) Change subject: add a tool to create table .. Patch Set 11: I can't understand the failure in the jenkins. In `IWYU.log` no error message found. I suspect there is something wrong with the code version. -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 11 Gerrit-Owner: YangSong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong Gerrit-Comment-Date: Fri, 11 Oct 2019 11:45:00 + Gerrit-HasComments: No
[kudu-CR] add a tool to create table
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14306 to look at the new patch set (#11). Change subject: add a tool to create table .. add a tool to create table Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 --- M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool.proto M src/kudu/tools/tool_action_table.cc 5 files changed, 1,406 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/14306/11 -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 11 Gerrit-Owner: YangSong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong
[kudu-CR] add a tool to create table
YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 ) Change subject: add a tool to create table .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/14306/10/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/14306/10/src/kudu/tools/tool_action_table.cc@753 PS10, Line 753: } Here I'm not sure if decimal type supports setting default value. Anad no similar example has been found. I try to use `KuduValue::FromDecimal`, I split the value string with `.`, first value used as precision, second used as scale, but it doesn't look right. -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 10 Gerrit-Owner: YangSong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong Gerrit-Comment-Date: Fri, 11 Oct 2019 09:45:45 + Gerrit-HasComments: Yes
[kudu-CR] add a tool to create table
YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 ) Change subject: add a tool to create table .. Patch Set 10: Yes, the test case TestAlterColumn failed because the string value of compression type and encoding type are modified. I update the code. -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 10 Gerrit-Owner: YangSong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong Gerrit-Comment-Date: Fri, 11 Oct 2019 09:35:12 + Gerrit-HasComments: No
[kudu-CR] [build] Fix a bug for memory gc-itest
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14415 Change subject: [build] Fix a bug for memory_gc-itest .. [build] Fix a bug for memory_gc-itest In CMakeList.txt, we should use KUDU_TCMALLOC_AVAILABLE to determine whether tcmalloc is enabled instead of TCMALLOC_ENABLED. Change-Id: I2982af9c7070ffd0f53791d4960c3bccfee4a8cc --- M src/kudu/integration-tests/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/14415/1 -- To view, visit http://gerrit.cloudera.org:8080/14415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2982af9c7070ffd0f53791d4960c3bccfee4a8cc Gerrit-Change-Number: 14415 Gerrit-PatchSet: 1 Gerrit-Owner: Yao Xu
[kudu-CR] add a tool to create table
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14306 to look at the new patch set (#10). Change subject: add a tool to create table .. add a tool to create table Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 --- M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool.proto M src/kudu/tools/tool_action_table.cc 5 files changed, 1,403 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/14306/10 -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 10 Gerrit-Owner: YangSong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong
[kudu-CR] add a tool to create table
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14306 to look at the new patch set (#9). Change subject: add a tool to create table .. add a tool to create table Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 --- M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool.proto M src/kudu/tools/tool_action_table.cc 5 files changed, 1,401 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/14306/9 -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 9 Gerrit-Owner: YangSong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong
[kudu-CR] add a tool to create table
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14306 to look at the new patch set (#8). Change subject: add a tool to create table .. add a tool to create table Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 --- M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool.proto M src/kudu/tools/tool_action_table.cc 5 files changed, 1,402 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/14306/8 -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 8 Gerrit-Owner: YangSong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong
[kudu-CR] Update version to 1.12.0-SNAPSHOT
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14413 to look at the new patch set (#2). Change subject: Update version to 1.12.0-SNAPSHOT .. Update version to 1.12.0-SNAPSHOT Change-Id: Ifd7a8e1de46cc4ac548c57337326e3f25a6a2099 --- M docs/release_notes.adoc M examples/java/java-example/pom.xml M version.txt 3 files changed, 30 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/14413/2 -- To view, visit http://gerrit.cloudera.org:8080/14413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifd7a8e1de46cc4ac548c57337326e3f25a6a2099 Gerrit-Change-Number: 14413 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [docs] Kudu 1.11 release notes draft
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/14404 ) Change subject: WIP [docs] Kudu 1.11 release notes draft .. Abandoned Obsoleted by https://gerrit.cloudera.org/#/c/14414/ -- To view, visit http://gerrit.cloudera.org:8080/14404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35 Gerrit-Change-Number: 14404 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: honeyhexin
[kudu-CR] [docs] add 1.11.0 release notes
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14414 ) Change subject: [docs] add 1.11.0 release notes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14414/1//COMMIT_MSG Commit Message: PS1: The rendered version is available at: https://gist.github.com/alexeyserbin/53200325d07f4c922682580489e3d45f -- To view, visit http://gerrit.cloudera.org:8080/14414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64ac48bfdcc4eb1b9c87af5be6dc9d8ecc219074 Gerrit-Change-Number: 14414 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 11 Oct 2019 08:21:32 + Gerrit-HasComments: Yes
[kudu-CR] [docs] add 1.11.0 release notes
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14414 Change subject: [docs] add 1.11.0 release notes .. [docs] add 1.11.0 release notes Change-Id: I64ac48bfdcc4eb1b9c87af5be6dc9d8ecc219074 --- M docs/release_notes.adoc 1 file changed, 191 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/14414/1 -- To view, visit http://gerrit.cloudera.org:8080/14414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I64ac48bfdcc4eb1b9c87af5be6dc9d8ecc219074 Gerrit-Change-Number: 14414 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] WIP [docs] Kudu 1.11 release notes draft
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/14404 )
Change subject: WIP [docs] Kudu 1.11 release notes draft
..
Patch Set 7:
(22 comments)
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@34
PS7, Line 34: * Flume 1.8+ requires Java 8 at runtime even though the Kudu
Flume integration
: is Java 7 compatible. Flume 1.9 is the default dependency
version as of
: Kudu 1.9.0.
:
: * Hadoop 3.0+ requires Java 8 at runtime even though the Kudu
Hadoop integration
: is Java 7 compatible. Hadoop 3.2 is the default dependency
version as of
: Kudu 1.9.0.
> Should probably modify these bits too. See KUDU-2099 for more details on th
Ah, great. I removed this sice Java8 is already a requirement in Kudu 1.10.0
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@48
PS7, Line 48: * `TabletLocationsPB.ReplicaPB` has been deprecated since Kudu
1.11.0 in both
: {cpp} and Java Kudu clients. The server side still recognizes
the
: `TabletLocationsPB.ReplicaPB` message for backward
compatibility with clients
: of prior versions.
> While accurate, we should try to describe this in concrete user-facing term
Done
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@52
PS7, Line 52:
: * Support for Java 7 has been deprecated since Kudu 1.5.0 and may
be removed in
: the next major release.
> Java 7 support was removed in 1.10.0. Not sure why this carried over into h
Done
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@59
PS7, Line 59: While a tablet
: server is in maintenance, its downtime does not automatically
trigger
: re-replication of its replicas
> Nit: perhaps "While in this mode, the tablet server's replicas will not be
Done
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@68
PS7, Line 68: With the built-in NTP
: client enabled
> Nit: "When enabled,"
Done
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@69
PS7, Line 69: it's no longer required to keep the system clock of Kudu
: nodes synchronzed with NTP (might be useful in case of
containerized
: deployments)
> Nit: "system clock synchronization for nodes running Kudu is no longer nece
The idea was to mention that the built-in NTP client might be useful for
containerized deployments.
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@71
PS7, Line 71: With the built-in NTP client enabled, the internal wallclock
: is synchronized with NTP servers specified with the
`--builtin_ntp_servers`
: flag. By default, the built-in NTP client uses public servers
of the
: `pool.ntp.org` project
> Nit: "The list of NTP servers to synchronize against is specified with the
Done
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@75
PS7, Line 75: `0.pool.ntp.org,1.pool.ntp.org,2.pool.ntp.org,3.pool.ntp.org`
> I don't think we need to get this specific; just referencing pool.ntp.org i
Done
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@75
PS7, Line 75: To switch Kudu
: masters and tablet servers to use the built-in NTP client, add
: `--time_source=builtin` into the set of their flags,
customizing the
: `--builtin_ntp_servers` flag if necessary
: (see
link:https://issues.apache.org/jira/browse/KUDU-2935[KUDU-2935]).
:
> Nit: "To use the built-in NTP client, set `--time_source=builtin` and recon
Done
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@81
PS7, Line 81: via
: GetTableStatistics master's RPC
> Let's refer to specific APIs rather than to RPCs, as users interact with th
Done
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@87
PS7, Line 87: uuid
> Should we surround this with triangular brackets to emphasize that it's not
Done
http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@91
PS7, Line 91: * The `kudu` CLI tool now supports altering and dropping table
columns. Using
: the newly introduced `kudu table delete_column` sub-command,
it's possible to
: drop a column of the specified table. The newly introduced
commands such as
: `kudu table column_set_default`, `kudu table
column_remove_default`,
: `kudu table column_set_compression`, `kudu table
column_set_encoding`,
: and `kudu table column_set_block_size` allows for altering a
column of the
: specified table correspondingly.
> Given the asymmetry between
[kudu-CR] WIP [docs] Kudu 1.11 release notes draft
Hello honeyhexin, Attila Bukor, Kudu Jenkins, Andrew Wong, Yao Xu, Adar Dembo, Grant Henke, Greg Solovyev, Hao Hao, Volodymyr Verovkin, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14404 to look at the new patch set (#8). Change subject: WIP [docs] Kudu 1.11 release notes draft .. WIP [docs] Kudu 1.11 release notes draft The rendered version is available at: https://gist.github.com/alexeyserbin/53200325d07f4c922682580489e3d45f WIP: * this is published just as working draft to iterate upon * the branch is wrong (should be in branch-1.11.x): DO NOT COMMIT into the master branch Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35 --- M docs/release_notes.adoc 1 file changed, 191 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/14404/8 -- To view, visit http://gerrit.cloudera.org:8080/14404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35 Gerrit-Change-Number: 14404 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: honeyhexin
[kudu-CR] Update version to 1.12.0-SNAPSHOT
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14413 Change subject: Update version to 1.12.0-SNAPSHOT .. Update version to 1.12.0-SNAPSHOT Change-Id: Ifd7a8e1de46cc4ac548c57337326e3f25a6a2099 --- M docs/release_notes.adoc M examples/java/java-example/pom.xml M version.txt 3 files changed, 30 insertions(+), 30 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/14413/1 -- To view, visit http://gerrit.cloudera.org:8080/14413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd7a8e1de46cc4ac548c57337326e3f25a6a2099 Gerrit-Change-Number: 14413 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
