[kudu-CR] KUDU-2612: C++ client sets txn id in WriteRequestPB
Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/16625 )
Change subject: KUDU-2612: C++ client sets txn_id in WriteRequestPB
..
KUDU-2612: C++ client sets txn_id in WriteRequestPB
This patch introduces an optional 'txn_id' field into WriteRequestPB
protobuf message and changes Kudu C++ client to populate it for
all requests sent out from a transactional KuduSession. In addition,
this patch contains unit-level test to verify that KuduSession and
Batcher have their txn_id_ fields set correspondingly. It's assumed
that follow-up changelists will add more comprehensive end-to-end
coverage once transactional API for Kudu client is introduced and
tablet servers process the WriteRequestPB:txn_id field as prescribed
by the design document [1].
A follow-up changelist will introduce corresponding client API changes
for transaction-related operations, and with those it will be possible
to begin, commit, and rollback a transaction. However, I think it's
important to highlight a few assumptions that Andrew and I discussed
offline: this patch assumes that a single KuduSession isn't allowed
to have a mix of transactional and non-transactional write operations.
Also, all write operations handled by a KuduSession instance can be
attributed only to a single (the same) transaction. In other words,
it's assumed that a separate KuduSession instances should be created
to handle operations pertaining to different transactions. This
restriction doesn't seem to be too harsh, but it helps to avoid a
complicated dance in handling already accumulated write operation in
KuduClient. Otherwise, it would be necessary to flush buffered
operations if switching from non-transactional writes to transactional
ones and back. If it turns out that the functionality of mixing
transactional and non-transactional write operations is necessary,
this restriction can be removed: it's feasible to add transaction
control operations into KuduSession in future (i.e.
{Begin,Commit,Abort}Transaction() methods), but it will entail adding
more complexity into already convoluted client-side code of handling
buffered write operations.
For now, I decided not to expose txn_id via the public client API.
Also, I specifically avoided exposing txn_id via KuduWriteOperation as
well, keeping it a private member of internal classes KuduSession::Data
and Batcher.
[1] https://s.apache.org/kudu-multi-row-transaction-design
Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1
Reviewed-on: http://gerrit.cloudera.org:8080/16625
Reviewed-by: Andrew Wong
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
M src/kudu/tserver/tserver.proto
8 files changed, 107 insertions(+), 21 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
Hao Hao: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1
Gerrit-Change-Number: 16625
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Fix order of clearing openssl error and printing it
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/16631 )
Change subject: Fix order of clearing openssl error and printing it
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16631/1//COMMIT_MSG
Commit Message:
PS1:
> What was the error we saw here? Is there any way to test this so we don't r
+1
It would be great to add a test scenario which reproduces the issue. You can
take a look at available cert-related cases in
src/kudu/security/test/test_certs.cc, in particular comments for the
CreateTestSSLCertSignedByChain() function. I guess it might be possible to
generate a certificate chain that has similar issue.
http://gerrit.cloudera.org:8080/#/c/16631/1/src/kudu/security/tls_context.cc
File src/kudu/security/tls_context.cc:
http://gerrit.cloudera.org:8080/#/c/16631/1/src/kudu/security/tls_context.cc@248
PS1, Line 248: ERR_clear_error(); // in case it left anything on the queue.
> nit: Can you also note that it's important to call this before X509NameToSt
Maybe, it's also worth outputting the collected error information along with
cert_details when returning RuntimeError at line 256?
It's about calling GetOpenSSLErrors() (which does extracts all errors from the
error stack as well) after X509_verify_cert() storing the result in string, and
the using the string when forming the RuntimeError message.
int rc = X509_verify_cert(store_ctx.get());
if (rc != 1) {
const auto verify_err_msg = GetOpenSSLErrors();
...
}
--
To view, visit http://gerrit.cloudera.org:8080/16631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f78bdedce7a976a6e8117bb8683032dd917c626
Gerrit-Change-Number: 16631
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 23 Oct 2020 00:29:00 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2612: C++ client sets txn id in WriteRequestPB
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16625 ) Change subject: KUDU-2612: C++ client sets txn_id in WriteRequestPB .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1 Gerrit-Change-Number: 16625 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 23 Oct 2020 00:24:43 + Gerrit-HasComments: No
[kudu-CR] KUDU-2612: C++ client sets txn id in WriteRequestPB
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16625 ) Change subject: KUDU-2612: C++ client sets txn_id in WriteRequestPB .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1 Gerrit-Change-Number: 16625 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 22 Oct 2020 23:37:55 + Gerrit-HasComments: No
[kudu-CR] KUDU-2612: C++ client sets txn id in WriteRequestPB
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16625 ) Change subject: KUDU-2612: C++ client sets txn_id in WriteRequestPB .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16625/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16625/1//COMMIT_MSG@23 PS1, Line 23: signle > nit: single Done -- To view, visit http://gerrit.cloudera.org:8080/16625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1 Gerrit-Change-Number: 16625 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 22 Oct 2020 23:31:57 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2612: C++ client sets txn id in WriteRequestPB
Hello Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16625
to look at the new patch set (#2).
Change subject: KUDU-2612: C++ client sets txn_id in WriteRequestPB
..
KUDU-2612: C++ client sets txn_id in WriteRequestPB
This patch introduces an optional 'txn_id' field into WriteRequestPB
protobuf message and changes Kudu C++ client to populate it for
all requests sent out from a transactional KuduSession. In addition,
this patch contains unit-level test to verify that KuduSession and
Batcher have their txn_id_ fields set correspondingly. It's assumed
that follow-up changelists will add more comprehensive end-to-end
coverage once transactional API for Kudu client is introduced and
tablet servers process the WriteRequestPB:txn_id field as prescribed
by the design document [1].
A follow-up changelist will introduce corresponding client API changes
for transaction-related operations, and with those it will be possible
to begin, commit, and rollback a transaction. However, I think it's
important to highlight a few assumptions that Andrew and I discussed
offline: this patch assumes that a single KuduSession isn't allowed
to have a mix of transactional and non-transactional write operations.
Also, all write operations handled by a KuduSession instance can be
attributed only to a single (the same) transaction. In other words,
it's assumed that a separate KuduSession instances should be created
to handle operations pertaining to different transactions. This
restriction doesn't seem to be too harsh, but it helps to avoid a
complicated dance in handling already accumulated write operation in
KuduClient. Otherwise, it would be necessary to flush buffered
operations if switching from non-transactional writes to transactional
ones and back. If it turns out that the functionality of mixing
transactional and non-transactional write operations is necessary,
this restriction can be removed: it's feasible to add transaction
control operations into KuduSession in future (i.e.
{Begin,Commit,Abort}Transaction() methods), but it will entail adding
more complexity into already convoluted client-side code of handling
buffered write operations.
For now, I decided not to expose txn_id via the public client API.
Also, I specifically avoided exposing txn_id via KuduWriteOperation as
well, keeping it a private member of internal classes KuduSession::Data
and Batcher.
[1] https://s.apache.org/kudu-multi-row-transaction-design
Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
M src/kudu/tserver/tserver.proto
8 files changed, 107 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/16625/2
--
To view, visit http://gerrit.cloudera.org:8080/16625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1
Gerrit-Change-Number: 16625
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Hao Hao
[kudu-CR] [common] introduce TxnId wrapper
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16624 ) Change subject: [common] introduce TxnId wrapper .. [common] introduce TxnId wrapper TxnId is a wrapper around int64_t with transaction-related specifics. It's an alternative to boost::optional since it lightweight and it's possible to use it as an atomic (i.e. std::atomic works as expected). This patch also contains appropriate test coverage for the newly introduced functionality. Change-Id: I0511637702e946f140dc617ee6bf7e1c3d5289e3 Reviewed-on: http://gerrit.cloudera.org:8080/16624 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong --- M src/kudu/common/CMakeLists.txt A src/kudu/common/txn_id-test.cc A src/kudu/common/txn_id.cc A src/kudu/common/txn_id.h 4 files changed, 219 insertions(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0511637702e946f140dc617ee6bf7e1c3d5289e3 Gerrit-Change-Number: 16624 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [partitioning] KUDU-2671: Support for range specific HashSchemas.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16596 to look at the new patch set (#2). Change subject: [partitioning] KUDU-2671: Support for range specific HashSchemas. .. [partitioning] KUDU-2671: Support for range specific HashSchemas. This patch updates Partition::CreatePartitions() to support the ability to add different hash schemas per each range. If no hash schema per range is specified, the table wide hash schema is used. Currently, this only works if no split_rows are specified (more info in design doc). Currently, RangeHashSchema within partition.h maps each range's vector of hash schemas to a filler string. Ideally, it would be mapped to the range's lower bound but if we support split_rows the bounds would not be finalized until within CreatePartitions(). Inspiration from Vlad: https://gerrit.cloudera.org/c/15758/ Change-Id: I8725f4bd072a81b05b36dfc7df0c074c172b4ce8 --- M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/partition_pruner-test.cc M src/kudu/integration-tests/ts_tablet_manager-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet-harness.h M src/kudu/tserver/tablet_server-test.cc 9 files changed, 299 insertions(+), 50 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/16596/2 -- To view, visit http://gerrit.cloudera.org:8080/16596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8725f4bd072a81b05b36dfc7df0c074c172b4ce8 Gerrit-Change-Number: 16596 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy
[kudu-CR] [partitioning] KUDU-2671: Support for range specific HashSchemas.
Mahesh Reddy has posted comments on this change. (
http://gerrit.cloudera.org:8080/16596 )
Change subject: [partitioning] KUDU-2671: Support for range specific
HashSchemas.
..
Patch Set 1:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/16596/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16596/1//COMMIT_MSG@12
PS1, Line 12: Open to discussion on whether or
: not we should support this feature with split_rows.
> Done
will add a section for this in design doc
http://gerrit.cloudera.org:8080/#/c/16596/1/src/kudu/common/partition.h
File src/kudu/common/partition.h:
http://gerrit.cloudera.org:8080/#/c/16596/1/src/kudu/common/partition.h@149
PS1, Line 149: integer
> I guess it would be enough to have just the lower bound for a range given t
hm yeh just the lower bound should suffice. Right now, the 'int' is just a
placeholder for the bound that should replace it. In hindsight, using an 'int'
wasn't very clear and perhaps I should have used 'std::string' instead.
http://gerrit.cloudera.org:8080/#/c/16596/1/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:
http://gerrit.cloudera.org:8080/#/c/16596/1/src/kudu/common/partition.cc@366
PS1, Line 366: partitions
> +1
Done
http://gerrit.cloudera.org:8080/#/c/16596/1/src/kudu/common/partition.cc@398
PS1, Line 398: RETURN_NOT_OK(EncodeRangeBounds(range_bounds, schema,
));
: RETURN_NOT_OK(EncodeRangeSplits(split_rows, schema,
));
: RETURN_NOT_OK(SplitRangeBounds(schema, std::move(splits),
));
> style nit: it seems there three lines has shifted right; what might be the
yeh I noticed that as soon as I uploaded the patch, fixed it for next one
http://gerrit.cloudera.org:8080/#/c/16596/1/src/kudu/common/partition.cc@410
PS1, Line 410: vector current_bound_hash_partitions =
vector(1);
> nit: a shorter form might be
Done
http://gerrit.cloudera.org:8080/#/c/16596/1/src/kudu/common/partition.cc@413
PS1, Line 413: second
> answered in definition of 'range_hash_schema' in header file
Done
http://gerrit.cloudera.org:8080/#/c/16596/1/src/kudu/common/partition.cc@669
PS1, Line 669: string PartitionSchema::HashSchemaPerPartitionDebugString(const
Partition& partition,
: const
vector& range_hash_schema,
: const Schema&
schema) const {
> style nit: the parameters are not aligned properly
Done
http://gerrit.cloudera.org:8080/#/c/16596/1/src/kudu/common/partition.cc@675
PS1, Line 675:
> nit: reserving the space for 'components' might be a good idea; I guess her
Done
http://gerrit.cloudera.org:8080/#/c/16596/1/src/kudu/common/partition.cc@686
PS1, Line 686: use default HashSchema when no range-specific hash partitions
are provided
> style nit: in comments like this, in Kudu code we tend to use full sentence
Done
http://gerrit.cloudera.org:8080/#/c/16596/1/src/kudu/common/partition.cc@695
PS1, Line 695: hash_buckets_[i]
> How is it guaranteed that partition.hash_buckets_ has enough elements to ha
The for loop runs through the hash schemas that were applied to the current
partition. The current partition will have as many elements in
'partition.hash_buckets_' as the hash schemas because the amount of necessary
hash buckets has already been generated from the hash schemas per each range.
For example, if two different hash schemas apply to a range, a partition with
two different hash buckets will be created.
--
To view, visit http://gerrit.cloudera.org:8080/16596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8725f4bd072a81b05b36dfc7df0c074c172b4ce8
Gerrit-Change-Number: 16596
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy
Gerrit-Comment-Date: Thu, 22 Oct 2020 23:15:47 +
Gerrit-HasComments: Yes
[kudu-CR] Fix order of clearing openssl error and printing it
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16631 ) Change subject: Fix order of clearing openssl error and printing it .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16631/1//COMMIT_MSG Commit Message: PS1: What was the error we saw here? Is there any way to test this so we don't regress it in the future? http://gerrit.cloudera.org:8080/#/c/16631/1/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: http://gerrit.cloudera.org:8080/#/c/16631/1/src/kudu/security/tls_context.cc@248 PS1, Line 248: ERR_clear_error(); // in case it left anything on the queue. nit: Can you also note that it's important to call this before X509NameToString() and why? -- To view, visit http://gerrit.cloudera.org:8080/16631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f78bdedce7a976a6e8117bb8683032dd917c626 Gerrit-Change-Number: 16631 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 22 Oct 2020 21:45:35 + Gerrit-HasComments: Yes
[kudu-CR] Add locking to TLSContext & handshake
Attila Bukor has abandoned this change. ( http://gerrit.cloudera.org:8080/16635 ) Change subject: Add locking to TLSContext & handshake .. Abandoned wanted to push only the first commit -- To view, visit http://gerrit.cloudera.org:8080/16635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ie3896b22c27f3aa7458cbe4b9ddb2303114320df Gerrit-Change-Number: 16635 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] fips changes
Attila Bukor has abandoned this change. ( http://gerrit.cloudera.org:8080/16633 ) Change subject: fips changes .. Abandoned wanted to push only the first commit -- To view, visit http://gerrit.cloudera.org:8080/16633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Id4c04ccfc88073cb91f68d91022b2966fbf3925a Gerrit-Change-Number: 16633 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] add lock before verifying signature
Attila Bukor has abandoned this change. ( http://gerrit.cloudera.org:8080/16634 ) Change subject: add lock before verifying signature .. Abandoned wanted to push only the first commit -- To view, visit http://gerrit.cloudera.org:8080/16634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I6427043bdf1176a07419c2f99f3f1e0744839b11 Gerrit-Change-Number: 16634 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Fix order of clearing openssl error and printing it
Hello Alexey Serbin, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16631 to review the following change. Change subject: Fix order of clearing openssl error and printing it .. Fix order of clearing openssl error and printing it When verifying the certificate chain fails with an error other than self-signed certificate, we try to get the subject and issuer to print in the error message. Unfortunately X509NameToString(), the method doing the conversion, also checks that there are no leftover OpenSSL errors, so it fails immediately on call. This commit changes the behavior to clear the errors *before* calling X509NameToString(). Change-Id: I3f78bdedce7a976a6e8117bb8683032dd917c626 --- M src/kudu/security/tls_context.cc 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/16631/1 -- To view, visit http://gerrit.cloudera.org:8080/16631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3f78bdedce7a976a6e8117bb8683032dd917c626 Gerrit-Change-Number: 16631 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke
[kudu-CR] Add FIPS mode
Attila Bukor has abandoned this change. ( http://gerrit.cloudera.org:8080/16632 ) Change subject: Add FIPS mode .. Abandoned wanted to push only the first commit -- To view, visit http://gerrit.cloudera.org:8080/16632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I9034fb4972383fce5fa1172414d83f60218e3495 Gerrit-Change-Number: 16632 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] add lock before verifying signature
Hello Alexey Serbin, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16634 to review the following change. Change subject: add lock before verifying signature .. add lock before verifying signature Change-Id: I6427043bdf1176a07419c2f99f3f1e0744839b11 --- M src/kudu/security/crypto.cc 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/16634/1 -- To view, visit http://gerrit.cloudera.org:8080/16634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6427043bdf1176a07419c2f99f3f1e0744839b11 Gerrit-Change-Number: 16634 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke
[kudu-CR] Add locking to TLSContext & handshake
Hello Alexey Serbin, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16635 to review the following change. Change subject: Add locking to TLSContext & handshake .. Add locking to TLSContext & handshake Change-Id: Ie3896b22c27f3aa7458cbe4b9ddb2303114320df --- M src/kudu/security/tls_context.cc M src/kudu/security/tls_handshake.cc 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/16635/1 -- To view, visit http://gerrit.cloudera.org:8080/16635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie3896b22c27f3aa7458cbe4b9ddb2303114320df Gerrit-Change-Number: 16635 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke
[kudu-CR] Add FIPS mode
Hello Alexey Serbin, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16632 to review the following change. Change subject: Add FIPS mode .. Add FIPS mode Change-Id: I9034fb4972383fce5fa1172414d83f60218e3495 --- M src/kudu/security/openssl_util.cc 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/16632/1 -- To view, visit http://gerrit.cloudera.org:8080/16632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9034fb4972383fce5fa1172414d83f60218e3495 Gerrit-Change-Number: 16632 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke
[kudu-CR] fips changes
Hello Alexey Serbin, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16633 to review the following change. Change subject: fips changes .. fips changes Change-Id: I9e898b2065827c2da8baf47c754464e4ccbaf9da increase key size in tests Change-Id: Id4c04ccfc88073cb91f68d91022b2966fbf3925a --- M src/kudu/integration-tests/authz_token-itest.cc M src/kudu/integration-tests/master_cert_authority-itest.cc M src/kudu/integration-tests/security-unknown-tsk-itest.cc M src/kudu/master/master-test.cc M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/security/ca/cert_management-test.cc M src/kudu/security/token-test.cc M src/kudu/tserver/tablet_server_authorization-test.cc M src/kudu/util/test_util.cc 9 files changed, 15 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/16633/1 -- To view, visit http://gerrit.cloudera.org:8080/16633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id4c04ccfc88073cb91f68d91022b2966fbf3925a Gerrit-Change-Number: 16633 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke
[kudu-CR] KUDU-2612: C++ client sets txn id in WriteRequestPB
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16625 ) Change subject: KUDU-2612: C++ client sets txn_id in WriteRequestPB .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16625/1//COMMIT_MSG Commit Message: PS1: Thank you for summarizing our discussion! http://gerrit.cloudera.org:8080/#/c/16625/1//COMMIT_MSG@23 PS1, Line 23: signle nit: single -- To view, visit http://gerrit.cloudera.org:8080/16625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1 Gerrit-Change-Number: 16625 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Comment-Date: Thu, 22 Oct 2020 19:21:07 + Gerrit-HasComments: Yes
[kudu-CR] [backup] Fix Spark 2 and Scala 2.11 compilation
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16629 ) Change subject: [backup] Fix Spark 2 and Scala 2.11 compilation .. [backup] Fix Spark 2 and Scala 2.11 compilation When compiling with Spark 2 and Scala 2.11, the build fails due to the use of `java.util.concurrent.ForkJoinPool` which was added in 41a7c4e. This patch reverts that part of the change. Change-Id: I75110921a536b6c78d3231251ff68f6f25dba6dc Reviewed-on: http://gerrit.cloudera.org:8080/16629 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong --- M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I75110921a536b6c78d3231251ff68f6f25dba6dc Gerrit-Change-Number: 16629 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [backup] Fix Spark 2 and Scala 2.11 compilation
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16629 ) Change subject: [backup] Fix Spark 2 and Scala 2.11 compilation .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75110921a536b6c78d3231251ff68f6f25dba6dc Gerrit-Change-Number: 16629 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 22 Oct 2020 18:59:21 + Gerrit-HasComments: No
[kudu-CR](gh-pages) site: add an ecosystem page
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16615 ) Change subject: site: add an ecosystem page .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Ib22d09afdf3ae8240f1ff64c7121b5216f6b3345 Gerrit-Change-Number: 16615 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Comment-Date: Thu, 22 Oct 2020 18:02:47 + Gerrit-HasComments: No
[kudu-CR](gh-pages) site: add an ecosystem page
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16615 ) Change subject: site: add an ecosystem page .. site: add an ecosystem page I mostly pasted blurbs I found on each components' websites. A staged version can be seen here: https://github.com/andrwng/kudu/blob/ecosystem/ecosystem.md Change-Id: Ib22d09afdf3ae8240f1ff64c7121b5216f6b3345 Reviewed-on: http://gerrit.cloudera.org:8080/16615 Reviewed-by: Grant Henke Reviewed-by: Attila Bukor Tested-by: Andrew Wong --- M _includes/top_common.html M community.md A ecosystem.md 3 files changed, 188 insertions(+), 0 deletions(-) Approvals: Grant Henke: Looks good to me, approved Attila Bukor: Looks good to me, approved Andrew Wong: Verified -- To view, visit http://gerrit.cloudera.org:8080/16615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: merged Gerrit-Change-Id: Ib22d09afdf3ae8240f1ff64c7121b5216f6b3345 Gerrit-Change-Number: 16615 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke
[kudu-CR] [common] introduce TxnId wrapper
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16624 ) Change subject: [common] introduce TxnId wrapper .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0511637702e946f140dc617ee6bf7e1c3d5289e3 Gerrit-Change-Number: 16624 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 22 Oct 2020 17:59:08 + Gerrit-HasComments: No
[kudu-CR](gh-pages) site: add an ecosystem page
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16615 ) Change subject: site: add an ecosystem page .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Ib22d09afdf3ae8240f1ff64c7121b5216f6b3345 Gerrit-Change-Number: 16615 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Comment-Date: Thu, 22 Oct 2020 16:58:19 + Gerrit-HasComments: No
[kudu-CR](gh-pages) site: add an ecosystem page
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16615 ) Change subject: site: add an ecosystem page .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Ib22d09afdf3ae8240f1ff64c7121b5216f6b3345 Gerrit-Change-Number: 16615 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Comment-Date: Thu, 22 Oct 2020 16:55:20 + Gerrit-HasComments: No
[kudu-CR] [backup] Fix Spark 2 and Scala 2.11 compilation
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16629 Change subject: [backup] Fix Spark 2 and Scala 2.11 compilation .. [backup] Fix Spark 2 and Scala 2.11 compilation When compiling with Spark 2 and Scala 2.11, the build fails due to the use of `java.util.concurrent.ForkJoinPool` which was added in 41a7c4e. This patch reverts that part of the change. Change-Id: I75110921a536b6c78d3231251ff68f6f25dba6dc --- M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala 2 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/16629/1 -- To view, visit http://gerrit.cloudera.org:8080/16629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I75110921a536b6c78d3231251ff68f6f25dba6dc Gerrit-Change-Number: 16629 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16618 ) Change subject: [tool] fix inconsistent definition among tool_action_common header and src .. Patch Set 6: Code-Review+2 Looks good to me. Thank you for your contribution! -- To view, visit http://gerrit.cloudera.org:8080/16618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada Gerrit-Change-Number: 16618 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 22 Oct 2020 15:23:40 + Gerrit-HasComments: No
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16618 ) Change subject: [tool] fix inconsistent definition among tool_action_common header and src .. [tool] fix inconsistent definition among tool_action_common header and src Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada Reviewed-on: http://gerrit.cloudera.org:8080/16618 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h 2 files changed, 38 insertions(+), 45 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada Gerrit-Change-Number: 16618 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612: C++ client sets txn id in WriteRequestPB
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/16625 ) Change subject: KUDU-2612: C++ client sets txn_id in WriteRequestPB .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1 Gerrit-Change-Number: 16625 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao
[kudu-CR] KUDU-2612: C++ client sets txn id in WriteRequestPB
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16625 ) Change subject: KUDU-2612: C++ client sets txn_id in WriteRequestPB .. Patch Set 1: Verified+1 unrelated test failure already reported as KUDU-3171 -- To view, visit http://gerrit.cloudera.org:8080/16625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1 Gerrit-Change-Number: 16625 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 22 Oct 2020 15:19:30 + Gerrit-HasComments: No
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16618 to look at the new patch set (#6). Change subject: [tool] fix inconsistent definition among tool_action_common header and src .. [tool] fix inconsistent definition among tool_action_common header and src Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada --- M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h 2 files changed, 38 insertions(+), 45 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/16618/6 -- To view, visit http://gerrit.cloudera.org:8080/16618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada Gerrit-Change-Number: 16618 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16618 to look at the new patch set (#5). Change subject: [tool] fix inconsistent definition among tool_action_common header and src .. [tool] fix inconsistent definition among tool_action_common header and src Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada --- M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h 2 files changed, 38 insertions(+), 44 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/16618/5 -- To view, visit http://gerrit.cloudera.org:8080/16618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada Gerrit-Change-Number: 16618 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16618 to look at the new patch set (#4). Change subject: [tool] fix inconsistent definition among tool_action_common header and src .. [tool] fix inconsistent definition among tool_action_common header and src Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada --- M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h 2 files changed, 38 insertions(+), 44 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/16618/4 -- To view, visit http://gerrit.cloudera.org:8080/16618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada Gerrit-Change-Number: 16618 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16618 to look at the new patch set (#3). Change subject: [tool] fix inconsistent definition among tool_action_common header and src .. [tool] fix inconsistent definition among tool_action_common header and src Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada --- M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h 2 files changed, 40 insertions(+), 44 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/16618/3 -- To view, visit http://gerrit.cloudera.org:8080/16618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada Gerrit-Change-Number: 16618 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16618 to look at the new patch set (#2). Change subject: [tool] fix inconsistent definition among tool_action_common header and src .. [tool] fix inconsistent definition among tool_action_common header and src Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada --- M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h 2 files changed, 32 insertions(+), 44 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/16618/2 -- To view, visit http://gerrit.cloudera.org:8080/16618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada Gerrit-Change-Number: 16618 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612: C++ client sets txn id in WriteRequestPB
Alexey Serbin has uploaded this change for review. (
http://gerrit.cloudera.org:8080/16625
Change subject: KUDU-2612: C++ client sets txn_id in WriteRequestPB
..
KUDU-2612: C++ client sets txn_id in WriteRequestPB
This patch introduces an optional 'txn_id' field into WriteRequestPB
protobuf message and changes Kudu C++ client to populate it for
all requests sent out from a transactional KuduSession. In addition,
this patch contains unit-level test to verify that KuduSession and
Batcher have their txn_id_ fields set correspondingly. It's assumed
that follow-up changelists will add more comprehensive end-to-end
coverage once transactional API for Kudu client is introduced and
tablet servers process the WriteRequestPB:txn_id field as prescribed
by the design document [1].
A follow-up changelist will introduce corresponding client API changes
for transaction-related operations, and with those it will be possible
to begin, commit, and rollback a transaction. However, I think it's
important to highlight a few assumptions that Andrew and I discussed
offline: this patch assumes that a signle KuduSession isn't allowed
to have a mix of transactional and non-transactional write operations.
Also, all write operations handled by a KuduSession instance can be
attributed only to a single (the same) transaction. In other words,
it's assumed that a separate KuduSession instances should be created
to handle operations pertaining to different transactions. This
restriction doesn't seem to be too harsh, but it helps to avoid a
complicated dance in handling already accumulated write operation in
KuduClient. Otherwise, it would be necessary to flush buffered
operations if switching from non-transactional writes to transactional
ones and back. If it turns out that the functionality of mixing
transactional and non-transactional write operations is necessary,
this restriction can be removed: it's feasible to add transaction
control operations into KuduSession in future (i.e.
{Begin,Commit,Abort}Transaction() methods), but it will entail adding
more complexity into already convoluted client-side code of handling
buffered write operations.
For now, I decided not to expose txn_id via the public client API.
Also, I specifically avoided exposing txn_id via KuduWriteOperation as
well, keeping it a private member of internal classes KuduSession::Data
and Batcher.
[1] https://s.apache.org/kudu-multi-row-transaction-design
Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
M src/kudu/tserver/tserver.proto
8 files changed, 107 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/16625/1
--
To view, visit http://gerrit.cloudera.org:8080/16625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1
Gerrit-Change-Number: 16625
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin
[kudu-CR] [common] introduce TxnId wrapper
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16624 Change subject: [common] introduce TxnId wrapper .. [common] introduce TxnId wrapper TxnId is a wrapper around int64_t with transaction-related specifics. It's an alternative to boost::optional since it lightweight and it's possible to use it as an atomic (i.e. std::atomic works as expected). This patch also contains appropriate test coverage for the newly introduced functionality. Change-Id: I0511637702e946f140dc617ee6bf7e1c3d5289e3 --- M src/kudu/common/CMakeLists.txt A src/kudu/common/txn_id-test.cc A src/kudu/common/txn_id.cc A src/kudu/common/txn_id.h 4 files changed, 219 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/16624/1 -- To view, visit http://gerrit.cloudera.org:8080/16624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0511637702e946f140dc617ee6bf7e1c3d5289e3 Gerrit-Change-Number: 16624 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
