[kudu-CR] [tserver] fix typo in generating name of tablet copy pool

2024-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/21374


Change subject: [tserver] fix typo in generating name of tablet copy pool
..

[tserver] fix typo in generating name of tablet copy pool

Don't use std::string instance after calling std::move() on it:
even if it's in valid state, it's contents is unspecified, so
the result name for the thread pool isn't what it expected to be.

Change-Id: If7287fd1255e174482e81fdfc863f5f4140199d7
---
M src/kudu/tserver/tablet_copy_client.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/21374/1
--
To view, visit http://gerrit.cloudera.org:8080/21374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7287fd1255e174482e81fdfc863f5f4140199d7
Gerrit-Change-Number: 21374
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 


[kudu-CR] [metrics] Add metrics for create and delete op time

2024-04-29 Thread KeDeng (Code Review)
Hello Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/21316

to look at the new patch set (#3).

Change subject: [metrics] Add metrics for create and delete op time
..

[metrics] Add metrics for create and delete op time

Add server-level statistics to track the time consumption of
create tablet and delete tablet operations.
These monitoring metrics will be very helpful for analyzing
issues related to high CPU usage.

Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4
---
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
4 files changed, 70 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/21316/3
--
To view, visit http://gerrit.cloudera.org:8080/21316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4
Gerrit-Change-Number: 21316
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] [tserver] fix typo in generating name of tablet copy pool

2024-04-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21374 )

Change subject: [tserver] fix typo in generating name of tablet copy pool
..


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/63/


--
To view, visit http://gerrit.cloudera.org:8080/21374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7287fd1255e174482e81fdfc863f5f4140199d7
Gerrit-Change-Number: 21374
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 30 Apr 2024 06:17:30 +
Gerrit-HasComments: No


[kudu-CR] [metrics] Add metrics for create and delete op time

2024-04-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21316 )

Change subject: [metrics] Add metrics for create and delete op time
..


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/62/


--
To view, visit http://gerrit.cloudera.org:8080/21316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4
Gerrit-Change-Number: 21316
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 30 Apr 2024 06:14:15 +
Gerrit-HasComments: No


[kudu-CR] [metrics] Add tablet level metrics for scans op time

2024-04-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21291 )

Change subject: [metrics] Add tablet level metrics for scans op time
..


Patch Set 3: Verified-1

Build Failed

http://jenkins.kudu.apache.org/job/pre_commit/60/ : FAILURE


--
To view, visit http://gerrit.cloudera.org:8080/21291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f490cfb6f37aef60b34697100fb502374fcc503
Gerrit-Change-Number: 21291
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Comment-Date: Tue, 30 Apr 2024 04:57:57 +
Gerrit-HasComments: No


[kudu-CR] [metrics] Add tablet level metrics for alter schema op time

2024-04-29 Thread KeDeng (Code Review)
Hello Yingchun Lai, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/21300

to look at the new patch set (#4).

Change subject: [metrics] Add tablet level metrics for alter schema op time
..

[metrics] Add tablet level metrics for alter schema op time

Add tablet-level statistics to track the time consumption of
alter schema operations.

Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
---
M src/kudu/tablet/ops/alter_schema_op.cc
M src/kudu/tablet/ops/alter_schema_op.h
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/tablet/tablet_replica-test.cc
5 files changed, 52 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/21300/4
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 


[kudu-CR] [metrics] Add tablet level metrics for alter schema op time

2024-04-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21300 )

Change subject: [metrics] Add tablet level metrics for alter schema op time
..


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/61/


--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Comment-Date: Tue, 30 Apr 2024 04:17:05 +
Gerrit-HasComments: No


[kudu-CR] Remove the replace flag if the move fails in auto rebalancing.

2024-04-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21073 )

Change subject: Remove the replace flag if the move fails in auto rebalancing.
..


Patch Set 14: Verified-1

Build Failed

http://jenkins.kudu.apache.org/job/pre_commit/59/ : FAILURE


--
To view, visit http://gerrit.cloudera.org:8080/21073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99dafa654878b9d6d8162d84500913ae0655692b
Gerrit-Change-Number: 21073
Gerrit-PatchSet: 14
Gerrit-Owner: Song Jiacheng 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy 
Gerrit-Reviewer: Song Jiacheng 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 30 Apr 2024 03:16:29 +
Gerrit-HasComments: No


[kudu-CR] [metrics] Add tablet level metrics for scans op time

2024-04-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21291 )

Change subject: [metrics] Add tablet level metrics for scans op time
..


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/60/


--
To view, visit http://gerrit.cloudera.org:8080/21291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f490cfb6f37aef60b34697100fb502374fcc503
Gerrit-Change-Number: 21291
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Comment-Date: Tue, 30 Apr 2024 03:11:54 +
Gerrit-HasComments: No


[kudu-CR] [metrics] Add tablet level metrics for scans op time

2024-04-29 Thread KeDeng (Code Review)
Hello Alexey Serbin, Yingchun Lai, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/21291

to look at the new patch set (#3).

Change subject: [metrics] Add tablet level metrics for scans op time
..

[metrics] Add tablet level metrics for scans op time

We currently have monitoring in place for scan data volume and
slow scans, but we are still lacking monitoring data for scan time.
In this patch, I have added monitoring for scan time at the tablet
level to assist us in pinpointing specific scenarios of high CPU
usage during scanning operations.

Change-Id: I8f490cfb6f37aef60b34697100fb502374fcc503
---
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/tserver/scanners.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/stopwatch.h
6 files changed, 205 insertions(+), 45 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/21291/3
--
To view, visit http://gerrit.cloudera.org:8080/21291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f490cfb6f37aef60b34697100fb502374fcc503
Gerrit-Change-Number: 21291
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 


[kudu-CR] Remove the replace flag if the move fails in auto rebalancing.

2024-04-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21073 )

Change subject: Remove the replace flag if the move fails in auto rebalancing.
..


Patch Set 14:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/59/


--
To view, visit http://gerrit.cloudera.org:8080/21073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99dafa654878b9d6d8162d84500913ae0655692b
Gerrit-Change-Number: 21073
Gerrit-PatchSet: 14
Gerrit-Owner: Song Jiacheng 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy 
Gerrit-Reviewer: Song Jiacheng 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 30 Apr 2024 03:10:44 +
Gerrit-HasComments: No


[kudu-CR] Minor refactoring on Op class

2024-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/21342 )

Change subject: Minor refactoring on Op class
..

Minor refactoring on Op class

We have derived various types of operations based on the Op class.
Now, if we need to add time statistics for these operations, it
would be repetitive to add an initial timestamp separately for
each derived class.

In this patch, I moved the 'start_time_' from the WriteOp class to
the OpState class, making it easier for subsequent derived classes
to use.

Since there are no logical changes, no additional unit tests have
been added.

Change-Id: Ie391d4a55b8da08a62025a05cc466fc2b947099c
Reviewed-on: http://gerrit.cloudera.org:8080/21342
Reviewed-by: Yingchun Lai 
Tested-by: Yingchun Lai 
Reviewed-by: Alexey Serbin 
---
M src/kudu/tablet/ops/op.h
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
3 files changed, 14 insertions(+), 8 deletions(-)

Approvals:
  Yingchun Lai: Looks good to me, but someone else must approve; Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/21342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie391d4a55b8da08a62025a05cc466fc2b947099c
Gerrit-Change-Number: 21342
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 


[kudu-CR] Minor refactoring on Op class

2024-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change.

Change subject: Minor refactoring on Op class
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie391d4a55b8da08a62025a05cc466fc2b947099c
Gerrit-Change-Number: 21342
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 


[kudu-CR] Minor refactoring on Op class

2024-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21342 )

Change subject: Minor refactoring on Op class
..


Patch Set 3: Code-Review+2

Thank you for timely addressing review feedback!


--
To view, visit http://gerrit.cloudera.org:8080/21342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie391d4a55b8da08a62025a05cc466fc2b947099c
Gerrit-Change-Number: 21342
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Comment-Date: Mon, 29 Apr 2024 20:57:33 +
Gerrit-HasComments: No


[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-04-29 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21370 )

Change subject: [build] Fix RocksDB Snappy dependency.
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21370/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21370/1//COMMIT_MSG@9
PS1, Line 9: RocksDB uses Snappy. When statically
lines can be longer (up to 72 characters) in the body of the commit message.



--
To view, visit http://gerrit.cloudera.org:8080/21370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ce75f69d94436f732dbe9a0011546b1ae494824
Gerrit-Change-Number: 21370
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 29 Apr 2024 17:19:17 +
Gerrit-HasComments: Yes


[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-04-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21370 )

Change subject: [build] Fix RocksDB Snappy dependency.
..


Patch Set 1: Verified-1

Build Failed

http://jenkins.kudu.apache.org/job/pre_commit/58/ : FAILURE


--
To view, visit http://gerrit.cloudera.org:8080/21370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ce75f69d94436f732dbe9a0011546b1ae494824
Gerrit-Change-Number: 21370
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 29 Apr 2024 14:26:18 +
Gerrit-HasComments: No


[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-04-29 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/21370


Change subject: [build] Fix RocksDB Snappy dependency.
..

[build] Fix RocksDB Snappy dependency.

RocksDB uses Snappy. When statically
linking Kudu, librocksdb.a contains
multiple undefined symbols that are
defined in libsnappy.a. In the case of
static linking, the order of libraries
passed to the linker matters, and
libsnappy.a must come after
librocksdb.a. This causes the release
build to fail on RHEL 9.3.

Change-Id: I3ce75f69d94436f732dbe9a0011546b1ae494824
---
M CMakeLists.txt
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/21370/1
--
To view, visit http://gerrit.cloudera.org:8080/21370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ce75f69d94436f732dbe9a0011546b1ae494824
Gerrit-Change-Number: 21370
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka 


[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-04-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21370 )

Change subject: [build] Fix RocksDB Snappy dependency.
..


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/58/


--
To view, visit http://gerrit.cloudera.org:8080/21370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ce75f69d94436f732dbe9a0011546b1ae494824
Gerrit-Change-Number: 21370
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 29 Apr 2024 13:10:02 +
Gerrit-HasComments: No


[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-04-29 Thread KeDeng (Code Review)
KeDeng has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21356 )

Change subject: [metrics] Add metrics for tablet copy op time
..


Patch Set 6:

(5 comments)

Thanks for your reviews.

http://gerrit.cloudera.org:8080/#/c/21356/5/src/kudu/tablet/tablet_metrics.cc
File src/kudu/tablet/tablet_metrics.cc:

http://gerrit.cloudera.org:8080/#/c/21356/5/src/kudu/tablet/tablet_metrics.cc@231
PS5, Line 231: 600
> While the unit is kMicroseconds, so the 'max_val' maybe 60,000,000, or even
Done


http://gerrit.cloudera.org:8080/#/c/21356/5/src/kudu/tserver/tablet_copy_client-test.cc
File src/kudu/tserver/tablet_copy_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/21356/5/src/kudu/tserver/tablet_copy_client-test.cc@336
PS5, Line 336: void TearDown() override {
 : client_.reset();
 : TabletCopyClientTest::TearDown();
 :   }
> Can we define these in SetUp() ?
Done


http://gerrit.cloudera.org:8080/#/c/21356/5/src/kudu/tserver/tablet_copy_client-test.cc@345
PS5, Line 345:
> Can we define it in TearDown() ?
Done


http://gerrit.cloudera.org:8080/#/c/21356/5/src/kudu/tserver/tablet_copy_client.cc
File src/kudu/tserver/tablet_copy_client.cc:

http://gerrit.cloudera.org:8080/#/c/21356/5/src/kudu/tserver/tablet_copy_client.cc@561
PS5, Line 561: int64_t dur = GetMonoTimeMicros() - start_time_micros_;
> This metric is in microsecond unit [1], don't divide by 1000.
Done


http://gerrit.cloudera.org:8080/#/c/21356/5/src/kudu/tserver/tablet_copy_client.cc@605
PS5, Line 605: int64_t dur = GetMonoTimeMicros() - start_time_micros_;
> Ditto.
Done



--
To view, visit http://gerrit.cloudera.org:8080/21356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I088f6a9a8a07ad39ca95ae8b4995ce00d1a0d00c
Gerrit-Change-Number: 21356
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Comment-Date: Mon, 29 Apr 2024 07:09:18 +
Gerrit-HasComments: Yes


[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-04-29 Thread KeDeng (Code Review)
Hello Yingchun Lai, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/21356

to look at the new patch set (#6).

Change subject: [metrics] Add metrics for tablet copy op time
..

[metrics] Add metrics for tablet copy op time

Add tablet-level statistics to track the time consumption of
copy tablet operations.

These monitoring metrics will be very useful for us to track
CPU usage.

Change-Id: I088f6a9a8a07ad39ca95ae8b4995ce00d1a0d00c
---
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_client.cc
M src/kudu/tserver/tablet_copy_client.h
M src/kudu/tserver/ts_tablet_manager.cc
6 files changed, 118 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/21356/6
--
To view, visit http://gerrit.cloudera.org:8080/21356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I088f6a9a8a07ad39ca95ae8b4995ce00d1a0d00c
Gerrit-Change-Number: 21356
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 


[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-04-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21356 )

Change subject: [metrics] Add metrics for tablet copy op time
..


Patch Set 6:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/57/


--
To view, visit http://gerrit.cloudera.org:8080/21356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I088f6a9a8a07ad39ca95ae8b4995ce00d1a0d00c
Gerrit-Change-Number: 21356
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Comment-Date: Mon, 29 Apr 2024 07:09:01 +
Gerrit-HasComments: No


[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-04-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21356 )

Change subject: [metrics] Add metrics for tablet copy op time
..


Patch Set 5:

Build Aborted

http://jenkins.kudu.apache.org/job/pre_commit/56/ : ABORTED


--
To view, visit http://gerrit.cloudera.org:8080/21356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I088f6a9a8a07ad39ca95ae8b4995ce00d1a0d00c
Gerrit-Change-Number: 21356
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Comment-Date: Mon, 29 Apr 2024 07:08:53 +
Gerrit-HasComments: No