Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21342 )
Change subject: Minor refactoring on Op class ...................................................................... Minor refactoring on Op class We have derived various types of operations based on the Op class. Now, if we need to add time statistics for these operations, it would be repetitive to add an initial timestamp separately for each derived class. In this patch, I moved the 'start_time_' from the WriteOp class to the OpState class, making it easier for subsequent derived classes to use. Since there are no logical changes, no additional unit tests have been added. Change-Id: Ie391d4a55b8da08a62025a05cc466fc2b947099c Reviewed-on: http://gerrit.cloudera.org:8080/21342 Reviewed-by: Yingchun Lai <laiyingc...@apache.org> Tested-by: Yingchun Lai <laiyingc...@apache.org> Reviewed-by: Alexey Serbin <ale...@apache.org> --- M src/kudu/tablet/ops/op.h M src/kudu/tablet/ops/write_op.cc M src/kudu/tablet/ops/write_op.h 3 files changed, 14 insertions(+), 8 deletions(-) Approvals: Yingchun Lai: Looks good to me, but someone else must approve; Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie391d4a55b8da08a62025a05cc466fc2b947099c Gerrit-Change-Number: 21342 Gerrit-PatchSet: 4 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>