[kudu-CR] [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15808 ) Change subject: [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message .. Patch Set 7: I have moved changes in src/kudu/common/partition.cc and src/kudu/common/partition-test.cc to part 1 -- To view, visit http://gerrit.cloudera.org:8080/15808 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c Gerrit-Change-Number: 15808 Gerrit-PatchSet: 7 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Tue, 05 May 2020 19:12:31 + Gerrit-HasComments: No
[kudu-CR] [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15808 to look at the new patch set (#7). Change subject: [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message .. [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message Added RangeBoundsPB protobuf message to describe range partitions with different hash partitioning schemas. Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c --- M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java M src/kudu/client/client.cc M src/kudu/client/table_alterer-internal.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master-test.cc M src/kudu/master/master.proto 9 files changed, 59 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/15808/7 -- To view, visit http://gerrit.cloudera.org:8080/15808 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c Gerrit-Change-Number: 15808 Gerrit-PatchSet: 7 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15808 ) Change subject: [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/15808/5/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java: http://gerrit.cloudera.org:8080/#/c/15808/5/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@271 PS5, Line 271: RowOperationsPB rowOps = new Operation.OperationsEncoder() > nit: prefer camel case for rowOps, per the GSG Done -- To view, visit http://gerrit.cloudera.org:8080/15808 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c Gerrit-Change-Number: 15808 Gerrit-PatchSet: 7 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Tue, 05 May 2020 19:11:01 + Gerrit-HasComments: Yes
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15758 to look at the new patch set (#9). Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. .. [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. Updated algorithm in Partition::CreatePartitions() to support different hash partitioning per range partition. Current range bounds represented as std::pair, but we need to add third parameter. For that it would be nice to replace std::pair with std::tuple. But replacing std::pair with std::tuple would require to change a lot of code. Thus, I added another parameter to Partition::CreatePartitions(), which describes hash partitiong schema for every range bound and must have same size as range bounds. Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 --- M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/partition_pruner-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet-harness.h M src/kudu/tserver/tablet_server-test.cc 8 files changed, 225 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15758/9 -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 9 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 ) Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@415 PS7, Line 415: // Copy all partitions created in the begin of the function > nit: I think we can be a bit more descriptive with what we're doing here, m Done http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@419 PS7, Line 419: // Create a partition per range bound and hash bucket combination. > nit: maybe, "Combine each bucket from this bucket schema with every partiti Done -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 8 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Tue, 05 May 2020 19:02:19 + Gerrit-HasComments: Yes
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Volodymyr Verovkin has posted comments on this change. (
http://gerrit.cloudera.org:8080/15758 )
Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash
partitioning per range partition.
..
Patch Set 8:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc
File src/kudu/common/partition-test.cc:
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc@864
PS7, Line 864: // CREATE TABLE t (k INT, f INT),
> nit: there's no "f" column (any more?)
Sorry, I committed change to wrong patch. Just fixed it. Please review the code
again.
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc@877
PS7, Line 877: vector hash_buckets1;
:
hash_buckets1.emplace_back(PartitionSchema::HashBucketSchema{{ColumnId(0)}, 2,
0});
: vector hash_buckets2;
:
hash_buckets2.emplace_back(PartitionSchema::HashBucketSchema{{ColumnId(0)}, 3,
0});
: vector hash_buckets3;
> Thanks! Did you mean to push review feedback from this patch into the part
Sorry, I committed change to wrong patch. Just fixed it. Please review the code
again.
--
To view, visit http://gerrit.cloudera.org:8080/15758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011
Gerrit-Change-Number: 15758
Gerrit-PatchSet: 8
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin
Gerrit-Comment-Date: Tue, 05 May 2020 18:51:25 +
Gerrit-HasComments: Yes
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15758 to look at the new patch set (#8). Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. .. [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. Updated algorithm in Partition::CreatePartitions() to support different hash partitioning per range partition. Current range bounds represented as std::pair, but we need to add third parameter. For that it would be nice to replace std::pair with std::tuple. But replacing std::pair with std::tuple would require to change a lot of code. Thus, I added another parameter to Partition::CreatePartitions(), which describes hash partitiong schema for every range bound and must have same size as range bounds. Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 --- M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/partition_pruner-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet-harness.h M src/kudu/tserver/tablet_server-test.cc 8 files changed, 222 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15758/8 -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 8 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [partitioning] KUDU-2671 [part 3] Added hash partitions per range partition to Kudu tool
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15852 Change subject: [partitioning] KUDU-2671 [part 3] Added hash partitions per range partition to Kudu tool .. [partitioning] KUDU-2671 [part 3] Added hash partitions per range partition to Kudu tool Added hash partitions per range partition to Kudu tool in order to pass parameters from Kudu client to server Change-Id: If23794d82378d284938ebcea841a164725d7f2b1 --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/table_creator-internal.h M src/kudu/tools/tool.proto M src/kudu/tools/tool_action_table.cc 5 files changed, 58 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/15852/1 -- To view, visit http://gerrit.cloudera.org:8080/15852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If23794d82378d284938ebcea841a164725d7f2b1 Gerrit-Change-Number: 15852 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Volodymyr Verovkin has posted comments on this change. (
http://gerrit.cloudera.org:8080/15758 )
Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash
partitioning per range partition.
..
Patch Set 7:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:
http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@368
PS3, Line 368:
> Ack
Here we compute hash partitions for "outer" hash
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@357
PS7, Line 357: const RangeBounds& range_bounds,
:const boost::optional&
range_hash_buckets,
:const Schema& schema,
:vector* partitions) const {
> nit: fix spacing
Done
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@369
PS7, Line 369: // Step 1
> nit: drop this if there's no step 2?
Done
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@411
PS7, Line 411: // range_hash_buckets.szie() == bounds.size()
> nit: you could consider bringing that DCHECK from L363 down here with a DCH
Done
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@412
PS7, Line 412: int
> nit: auto ?
Done
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@414
PS7, Line 414: vector
> nit: maybe, use auto?
Done
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@429
PS7, Line 429: new_partitions.push_back(partition);
> nit: does it make sense to use emplace_back(std::move(partion)) here?
Done
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@432
PS7, Line 432: all_hash_partitions.swap(new_partitions);
> Is std::move() any better here or that's the same?
Done
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@432
PS7, Line 432: all_hash_partitions.swap(new_partitions);
> Maybe i'm missing something, but I don't think this addresses my concern fr
That's correct. Multiple hash schemas produce combination.
https://kudu.apache.org/docs/schema_design.html#hash-hash-partitioning-example
--
To view, visit http://gerrit.cloudera.org:8080/15758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011
Gerrit-Change-Number: 15758
Gerrit-PatchSet: 7
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin
Gerrit-Comment-Date: Sun, 03 May 2020 20:13:17 +
Gerrit-HasComments: Yes
[kudu-CR] [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15808 to look at the new patch set (#5). Change subject: [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message .. [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message Added RangeBoundsPB protobuf message to describe range partitions with different hash partitioning schemas. Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c --- M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java M src/kudu/client/client.cc M src/kudu/client/table_alterer-internal.cc M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master-test.cc M src/kudu/master/master.proto 11 files changed, 109 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/15808/5 -- To view, visit http://gerrit.cloudera.org:8080/15808 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c Gerrit-Change-Number: 15808 Gerrit-PatchSet: 5 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15808 to look at the new patch set (#4). Change subject: [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message .. [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message Added RangeBoundsPB protobuf message to describe range partitions with different hash partitioning schemas Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c --- M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java M src/kudu/client/client.cc M src/kudu/client/table_alterer-internal.cc M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master-test.cc M src/kudu/master/master.proto 11 files changed, 109 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/15808/4 -- To view, visit http://gerrit.cloudera.org:8080/15808 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c Gerrit-Change-Number: 15808 Gerrit-PatchSet: 4 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15808 to look at the new patch set (#3). Change subject: [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message .. [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message Added RangeBoundsPB protobuf message to describe range partitions with different hash partitioning schemas Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c --- M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java M src/kudu/client/client.cc M src/kudu/client/table_alterer-internal.cc M src/kudu/common/partition-test.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master-test.cc M src/kudu/master/master.proto 10 files changed, 93 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/15808/3 -- To view, visit http://gerrit.cloudera.org:8080/15808 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c Gerrit-Change-Number: 15808 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Volodymyr Verovkin has posted comments on this change. (
http://gerrit.cloudera.org:8080/15758 )
Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash
partitioning per range partition.
..
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc
File src/kudu/common/partition-test.cc:
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc@867
PS7, Line 867: Schema schema({ ColumnSchema("k", INT32) },
> nit: add 'const' if it's not going to change in this scenario?
Done
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc@877
PS7, Line 877: vector hash_buckets1;
:
hash_buckets1.emplace_back(PartitionSchema::HashBucketSchema{{ColumnId(0)}, 2,
0});
: vector hash_buckets2;
:
hash_buckets2.emplace_back(PartitionSchema::HashBucketSchema{{ColumnId(0)}, 3,
0});
: boost::optional
range_hash_buckets = {
> Could you also add a test that this works if these have more than one eleme
Done
--
To view, visit http://gerrit.cloudera.org:8080/15758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011
Gerrit-Change-Number: 15758
Gerrit-PatchSet: 7
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin
Gerrit-Comment-Date: Sat, 02 May 2020 21:31:01 +
Gerrit-HasComments: Yes
[kudu-CR] [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15808 to look at the new patch set (#2). Change subject: [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message .. [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message Added RangeBoundsPB protobuf message to describe range partitions with different hash partitioning schemas Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c --- M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java M src/kudu/client/client.cc M src/kudu/client/table_alterer-internal.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master-test.cc M src/kudu/master/master.proto 9 files changed, 59 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/15808/2 -- To view, visit http://gerrit.cloudera.org:8080/15808 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c Gerrit-Change-Number: 15808 Gerrit-PatchSet: 2 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15808 Change subject: [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message .. [partitioning] KUDU-2671 [part 2] Added RangeBoundsPB protobuf message Added RangeBoundsPB protobuf message to describe range partitions with different hash partitioning schemas Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c --- M src/kudu/client/client.cc M src/kudu/client/table_alterer-internal.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master-test.cc M src/kudu/master/master.proto 6 files changed, 39 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/15808/1 -- To view, visit http://gerrit.cloudera.org:8080/15808 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic407d54970475fb1522b3801f62341d0ff1ccd2c Gerrit-Change-Number: 15808 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin
[kudu-CR] transaction: avoid locking for TransactionState::timestamp
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15791 ) Change subject: transaction: avoid locking for TransactionState::timestamp_ .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c6bc8b85a066426bcf4bc2d1c058bc75c1c38ec Gerrit-Change-Number: 15791 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 25 Apr 2020 00:58:06 + Gerrit-HasComments: No
[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/binary_dict_block.h File src/kudu/cfile/binary_dict_block.h: http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/binary_dict_block.h@176 PS1, Line 176: scoped_refptr block_; Why we do not use std::shared_ptr ? -- To view, visit http://gerrit.cloudera.org:8080/15800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1077fcc841ca31a2cb523769fffeed2d27782bc1 Gerrit-Change-Number: 15800 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 25 Apr 2020 00:49:52 + Gerrit-HasComments: Yes
[kudu-CR] row serialization: dedupe string columns
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15806 ) Change subject: row_serialization: dedupe string columns .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I056cd57b9eea1d6988b8ab053d86a3493361dc6b Gerrit-Change-Number: 15806 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 25 Apr 2020 00:52:58 + Gerrit-HasComments: No
[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1077fcc841ca31a2cb523769fffeed2d27782bc1 Gerrit-Change-Number: 15800 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 25 Apr 2020 00:51:45 + Gerrit-HasComments: No
[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15802 ) Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15802/2/src/kudu/common/rowblock_memory.h File src/kudu/common/rowblock_memory.h: http://gerrit.cloudera.org:8080/#/c/15802/2/src/kudu/common/rowblock_memory.h@51 PS2, Line 51: item->AddRef(); Why we do not use std::shared_ptr ? -- To view, visit http://gerrit.cloudera.org:8080/15802 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93fa1f9fd401814a42dc5a1f3fd2ffb1286ac441 Gerrit-Change-Number: 15802 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 24 Apr 2020 23:04:12 + Gerrit-HasComments: Yes
[kudu-CR] [warning] Fixed GCC warning "control reaches end of non-void function"
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15795 ) Change subject: [warning] Fixed GCC warning "control reaches end of non-void function" .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15795/2/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: http://gerrit.cloudera.org:8080/#/c/15795/2/src/kudu/util/net/sockaddr.cc@154 PS2, Line 154: return "unknown"; > nit: I don't think we need the comment. Done http://gerrit.cloudera.org:8080/#/c/15795/2/src/kudu/util/net/sockaddr.cc@154 PS2, Line 154: return "unknown"; > +1 Done -- To view, visit http://gerrit.cloudera.org:8080/15795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c22cbc18892374966975bee9e50f4119580006b Gerrit-Change-Number: 15795 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 24 Apr 2020 22:56:55 + Gerrit-HasComments: Yes
[kudu-CR] [warning] Fixed GCC warning "control reaches end of non-void function"
Hello Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15795 to look at the new patch set (#3). Change subject: [warning] Fixed GCC warning "control reaches end of non-void function" .. [warning] Fixed GCC warning "control reaches end of non-void function" GCC 7.5 on Ubuntu 18 produced warning: [194/827] Building CXX object src/kudu/util/CMakeFiles/kudu_util.dir/ net/sockaddr.cc.o ../../src/kudu/util/net/sockaddr.cc: In member function ‘std::__cxx11::string kudu::Sockaddr::UnixDomainPath() const’: ../../src/kudu/util/net/sockaddr.cc:152:1: warning: control reaches end of non-void function [-Wreturn-type] Change-Id: I8c22cbc18892374966975bee9e50f4119580006b --- M src/kudu/util/net/sockaddr.cc 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/15795/3 -- To view, visit http://gerrit.cloudera.org:8080/15795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8c22cbc18892374966975bee9e50f4119580006b Gerrit-Change-Number: 15795 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [warning] Fixed GCC warning "control reaches end of non-void function"
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15795 ) Change subject: [warning] Fixed GCC warning "control reaches end of non-void function" .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15795/1/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: http://gerrit.cloudera.org:8080/#/c/15795/1/src/kudu/util/net/sockaddr.cc@152 PS1, Line 152: } : default: > It'd be better to add default switch case instead. Done -- To view, visit http://gerrit.cloudera.org:8080/15795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c22cbc18892374966975bee9e50f4119580006b Gerrit-Change-Number: 15795 Gerrit-PatchSet: 2 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 24 Apr 2020 07:39:06 + Gerrit-HasComments: Yes
[kudu-CR] [warning] Fixed GCC warning "control reaches end of non-void function"
Hello Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15795 to look at the new patch set (#2). Change subject: [warning] Fixed GCC warning "control reaches end of non-void function" .. [warning] Fixed GCC warning "control reaches end of non-void function" GCC 7.5 on Ubuntu 18 produced warning: [194/827] Building CXX object src/kudu/util/CMakeFiles/kudu_util.dir/ net/sockaddr.cc.o ../../src/kudu/util/net/sockaddr.cc: In member function ‘std::__cxx11::string kudu::Sockaddr::UnixDomainPath() const’: ../../src/kudu/util/net/sockaddr.cc:152:1: warning: control reaches end of non-void function [-Wreturn-type] Change-Id: I8c22cbc18892374966975bee9e50f4119580006b --- M src/kudu/util/net/sockaddr.cc 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/15795/2 -- To view, visit http://gerrit.cloudera.org:8080/15795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8c22cbc18892374966975bee9e50f4119580006b Gerrit-Change-Number: 15795 Gerrit-PatchSet: 2 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15758 to look at the new patch set (#7). Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. .. [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. Updated algorithm in Partition::CreatePartitions() to support different hash partitioning per range partition. Current range bounds represented as std::pair, but we need to add third parameter. For that it would be nice to replace std::pair with std::tuple. But replacing std::pair with std::tuple would require to change a lot of code. Thus, I added another parameter to Partition::CreatePartitions(), which describes hash partitiong schema for every range bound and must have same size as range bounds. Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 --- M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/partition_pruner-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet-harness.h M src/kudu/tserver/tablet_server-test.cc 8 files changed, 194 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15758/7 -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 7 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15782 to look at the new patch set (#2). Change subject: [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9 .. [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9 gcc-9.2.1 produced error: kudu/thirdparty/src/breakpad-9eac2058b70615519b2c4d8c6bdbfca1bd079e39/ src/third_party/lss/linux_syscall_support.h: In member function ‘bool google_breakpad::ExceptionHandler::GenerateDump( google_breakpad::ExceptionHandler::CrashContext*)’: kudu/thirdparty/src/breakpad-9eac2058b70615519b2c4d8c6bdbfca1bd079e39/ src/third_party/lss/linux_syscall_support.h:2379:75: error: listing the stack pointer register ‘rsp’ in a clobber list is deprecated [-Werror=deprecated] : "rsp", "memory", "r8", "r10", "r11", "rcx"); It's fixed by patch from Google Chromium team. Reference patch: https://chromium.googlesource.com/linux-syscall-support/+/8048ece6c16c91acfe0d36d1d3cc0890ab6e945c%5E%21/ Change-Id: I75706392c5347a1b13f39b04d8c21b6ea528797a --- M thirdparty/download-thirdparty.sh A thirdparty/patches/breakpad-syscall-rsp-clobber-fix.patch 2 files changed, 25 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/15782/2 -- To view, visit http://gerrit.cloudera.org:8080/15782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I75706392c5347a1b13f39b04d8c21b6ea528797a Gerrit-Change-Number: 15782 Gerrit-PatchSet: 2 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Volodymyr Verovkin has posted comments on this change. (
http://gerrit.cloudera.org:8080/15758 )
Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash
partitioning per range partition.
..
Patch Set 6:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:
http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@405
PS3, Line 405: RETURN_NOT_OK(SplitRangeBounds(schema, std::m
> nit: while I appreciate the hints, I think it'd be much more helpful in und
Done
http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@409
PS3, Line 409: // We have to simultaneously iterate through range bounds
vector
: // and hash schema per range vector (range_hash_buckets).
: // range_hash_buckets.szie() == bounds.size()
: for (int i = 0; i < bounds.size(); i++) {
:
> nit: may be slightly less error-prone to iterate via an index and just refe
Done
http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@420
PS3, Line 420: vector new_partitions;
:
: for (const Partition& base_partition :
all_hash_partitions) {
> nit: maybe "For every hash partition created above, replace it with multipl
Done
http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@431
PS3, Line 431: }
> Shouldn't we only swap after we've created all of the range-hash buckets? O
Done
--
To view, visit http://gerrit.cloudera.org:8080/15758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011
Gerrit-Change-Number: 15758
Gerrit-PatchSet: 6
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin
Gerrit-Comment-Date: Fri, 24 Apr 2020 05:34:17 +
Gerrit-HasComments: Yes
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15758 to look at the new patch set (#6). Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. .. [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. Updated algorithm in Partition::CreatePartitions() to support different hash partitioning per range partition. Current range bounds represented as std::pair, but we need to add third parameter. For that it would be nice to replace std::pair with std::tuple. But replacing std::pair with std::tuple would require to change a lot of code. Thus, I added another parameter to Partition::CreatePartitions(), which describes hash partitiong schema for every range bound and must have same size as range bounds. Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 --- M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/partition_pruner-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet-harness.h M src/kudu/tserver/tablet_server-test.cc 8 files changed, 194 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15758/6 -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 6 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 ) Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@368 PS3, Line 368: hash_bucket_schemas_ > Here we may have something like: Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@368 PS3, Line 368: hash_bucket_schemas_ > If we are supposed to be using 'range_hash_buckets', why are we using 'hash Done -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 4 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 24 Apr 2020 03:17:10 + Gerrit-HasComments: Yes
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 ) Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc@894 PS3, Line 894: EXPECT_EQ(R"(HASH (k) PARTITION 0, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[0], (*range_hash_buckets)[0], schema)); : EXPECT_EQ(R"(HASH (k) PARTITION 1, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[1], (*range_hash_buckets)[0], schema)); > I thought the goal of this test was to test the ability to create range par Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc@894 PS3, Line 894: EXPECT_EQ(R"(HASH (k) PARTITION 0, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[0], (*range_hash_buckets)[0], schema)); : EXPECT_EQ(R"(HASH (k) PARTITION 1, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[1], (*range_hash_buckets)[0], schema)); > +1 Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h@150 PS3, Line 150: using RangeHashBuckets = boost::optional>>; > +1 for using boost::optional<> in function signatures and call sites. Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h@150 PS3, Line 150: using RangeHashBuckets = boost::optional>>; > nit: I think it'd be more self-documenting and easier to immediately unders Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h@151 PS3, Line 151: using RangeBounds > Style nit: is there a reason to use 'using' instead of 'typedef' here? In Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h@151 PS3, Line 151: using RangeBounds > Exactly, and the ask here is to use 'typedef' here since we use it elsewher Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@316 PS3, Line 316: PartitionSchema:: > nit: Don't need? Same elsewhere. Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@368 PS3, Line 368: hash_bucket_schemas_ > If we are supposed to be using 'range_hash_buckets', why are we using 'hash Here we may have something like: // hash_bucket_schemas_ PARTITION BY HASH (id) PARTITIONS 4, RANGE (sku) ( //range_hash_buckets PARTITION VALUES < 'g' HASH PARTITIONS 2 -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 4 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 24 Apr 2020 03:16:28 + Gerrit-HasComments: Yes
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15758 to look at the new patch set (#5). Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. .. [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. Updated algorithm in Partition::CreatePartitions() to support different hash partitioning per range partition. Current range bounds represented as std::pair, but we need to add third parameter. For that it would be nice to replace std::pair with std::tuple. But replacing std::pair with std::tuple would require to change a lot of code. Thus, I added another parameter to Partition::CreatePartitions(), which describes hash partitiong schema for every range bound and must have same size as range bounds. Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 --- M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/partition_pruner-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet-harness.h M src/kudu/tserver/tablet_server-test.cc 8 files changed, 170 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15758/5 -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 5 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 ) Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc@862 PS3, Line 862: Partition > nit: Partitions Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc@894 PS3, Line 894: EXPECT_EQ(R"(HASH (k) PARTITION 0, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[0], (*range_hash_buckets)[0], schema)); : EXPECT_EQ(R"(HASH (k) PARTITION 1, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[1], (*range_hash_buckets)[0], schema)); > I see. Could you then at least reflect that fact in the commit message, li Done -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 4 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 24 Apr 2020 01:14:44 + Gerrit-HasComments: Yes
[kudu-CR] [warning] Fixed GCC warning "control reaches end of non-void function"
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15795 Change subject: [warning] Fixed GCC warning "control reaches end of non-void function" .. [warning] Fixed GCC warning "control reaches end of non-void function" GCC 7.5 on Ubuntu 18 produced warning: [194/827] Building CXX object src/kudu/util/CMakeFiles/kudu_util.dir/ net/sockaddr.cc.o ../../src/kudu/util/net/sockaddr.cc: In member function ‘std::__cxx11::string kudu::Sockaddr::UnixDomainPath() const’: ../../src/kudu/util/net/sockaddr.cc:152:1: warning: control reaches end of non-void function [-Wreturn-type] Change-Id: I8c22cbc18892374966975bee9e50f4119580006b --- M src/kudu/util/net/sockaddr.cc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/15795/1 -- To view, visit http://gerrit.cloudera.org:8080/15795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8c22cbc18892374966975bee9e50f4119580006b Gerrit-Change-Number: 15795 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15758 to look at the new patch set (#4). Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. .. [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. Updated algorithm in Partition::CreatePartitions() to support different hash partitioning per range partition. Current range bounds represented as std::pair, but we need to add third parameter. For that it would be nice to replace std::pair with std::tuple. But replacing std::pair with std::tuple would require to change a lot of code. Thus, I added another parameter to Partition::CreatePartitions(), which describes hash partitiong schema for every range bound and must have same size as range bounds. Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 --- M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/partition_pruner-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet-harness.h M src/kudu/tserver/tablet_server-test.cc 8 files changed, 166 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15758/4 -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 4 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [partitioning] KUDU-2671 Support for different hash partitioning per range partition.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 ) Change subject: [partitioning] KUDU-2671 Support for different hash partitioning per range partition. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h@151 PS3, Line 151: using RangeBounds > Style nit: is there a reason to use 'using' instead of 'typedef' here? In "using" is just "typedef" in C++11 -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Thu, 23 Apr 2020 23:48:46 + Gerrit-HasComments: Yes
[kudu-CR] [partitioning] KUDU-2671 Support for different hash partitioning per range partition.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 ) Change subject: [partitioning] KUDU-2671 Support for different hash partitioning per range partition. .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc@894 PS3, Line 894: EXPECT_EQ(R"(HASH (k) PARTITION 0, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[0], (*range_hash_buckets)[0], schema)); : EXPECT_EQ(R"(HASH (k) PARTITION 1, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[1], (*range_hash_buckets)[0], schema)); > I thought the goal of this test was to test the ability to create range par No, it isn't. This function is different. But I have to think how to produce another output to distinguish it from single partition with multiple hash buckets. http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc@894 PS3, Line 894: EXPECT_EQ(R"(HASH (k) PARTITION 0, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[0], (*range_hash_buckets)[0], schema)); : EXPECT_EQ(R"(HASH (k) PARTITION 1, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[1], (*range_hash_buckets)[0], schema)); > +1 It's a little change which only describes change in partition creation algorithm. Testing CREATE TABLE will follow in other commits. -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Thu, 23 Apr 2020 21:46:07 + Gerrit-HasComments: Yes
[kudu-CR] [c++17] Corrected call of boost::make optional()
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15781 ) Change subject: [c++17] Corrected call of boost::make_optional() .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15781/1/src/kudu/master/placement_policy-test.cc File src/kudu/master/placement_policy-test.cc: http://gerrit.cloudera.org:8080/#/c/15781/1/src/kudu/master/placement_policy-test.cc@44 PS1, Line 44: using std::initializer_list; > +1 to Alexey's comment. Done http://gerrit.cloudera.org:8080/#/c/15781/1/src/kudu/master/placement_policy-test.cc@1014 PS1, Line 1014: > There is 'using boost::make_optional' directive in the beginning of this fi Done -- To view, visit http://gerrit.cloudera.org:8080/15781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad Gerrit-Change-Number: 15781 Gerrit-PatchSet: 2 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Thu, 23 Apr 2020 21:41:01 + Gerrit-HasComments: Yes
[kudu-CR] [c++17] Corrected call of boost::make optional()
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15781 to look at the new patch set (#2). Change subject: [c++17] Corrected call of boost::make_optional() .. [c++17] Corrected call of boost::make_optional() Without specifying "boost" namespace C++17 compiler treats make_optional() as std::make_optional() and produces error: ./../src/kudu/master/placement_policy-test.cc:1014:49: error: no viable conversion from 'optional > >' (aka 'optional >') to 'const boost::optional' (aka 'const optional >') ASSERT_OK(policy.PlaceTabletReplicas(3, make_optional(string(label)), )); Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad --- M src/kudu/master/placement_policy-test.cc 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/15781/2 -- To view, visit http://gerrit.cloudera.org:8080/15781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad Gerrit-Change-Number: 15781 Gerrit-PatchSet: 2 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15782 Change subject: [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9 .. [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9 gcc-9.2.1 produced error: kudu/thirdparty/src/breakpad-9eac2058b70615519b2c4d8c6bdbfca1bd079e39/ src/third_party/lss/linux_syscall_support.h: In member function ‘bool google_breakpad::ExceptionHandler::GenerateDump( google_breakpad::ExceptionHandler::CrashContext*)’: kudu/thirdparty/src/breakpad-9eac2058b70615519b2c4d8c6bdbfca1bd079e39/ src/third_party/lss/linux_syscall_support.h:2379:75: error: listing the stack pointer register ‘rsp’ in a clobber list is deprecated [-Werror=deprecated] : "rsp", "memory", "r8", "r10", "r11", "rcx"); Change-Id: I75706392c5347a1b13f39b04d8c21b6ea528797a --- M thirdparty/build-definitions.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/15782/1 -- To view, visit http://gerrit.cloudera.org:8080/15782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I75706392c5347a1b13f39b04d8c21b6ea528797a Gerrit-Change-Number: 15782 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin
[kudu-CR] [c++17] Corrected call of boost::make optional()
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15781 Change subject: [c++17] Corrected call of boost::make_optional() .. [c++17] Corrected call of boost::make_optional() Without specifying "boost" namespace C++17 compiler treats make_optional() as std::make_optional() and produces error: ./../src/kudu/master/placement_policy-test.cc:1014:49: error: no viable conversion from 'optional > >' (aka 'optional >') to 'const boost::optional' (aka 'const optional >') ASSERT_OK(policy.PlaceTabletReplicas(3, make_optional(string(label)), )); Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad --- M src/kudu/master/placement_policy-test.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/15781/1 -- To view, visit http://gerrit.cloudera.org:8080/15781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad Gerrit-Change-Number: 15781 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin
[kudu-CR] [script] Added --unlock unsafe flags to start kudu.sh
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15780 Change subject: [script] Added --unlock_unsafe_flags to start_kudu.sh .. [script] Added --unlock_unsafe_flags to start_kudu.sh Without --unlock_unsafe_flags start_kudu.sh shows warning: WARNING: Logging before InitGoogleLogging() is written to STDERR WARNING: Logging before InitGoogleLogging() is written to STDERR E0421 21:54:53.600564 17547 hybrid_clock.cc:157] --unlock_unsafe_flags should be set if configuring --time_source to be system_unsync or mock E0421 21:54:53.600500 17545 hybrid_clock.cc:157] --unlock_unsafe_flags should be set if configuring --time_source to be system_unsync or mock Change-Id: If7cc93849cf61d5a80001f4fd544dd678426fa5d --- M src/kudu/scripts/start_kudu.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/15780/1 -- To view, visit http://gerrit.cloudera.org:8080/15780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If7cc93849cf61d5a80001f4fd544dd678426fa5d Gerrit-Change-Number: 15780 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin
[kudu-CR] [webserver-test] fix TestInvalidHeaders on macOS
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15779 ) Change subject: [webserver-test] fix TestInvalidHeaders on macOS .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1 Gerrit-Change-Number: 15779 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Wed, 22 Apr 2020 03:59:52 + Gerrit-HasComments: No
[kudu-CR] [util] Don't use static function ptrs for non-static member functions in BlockBloom filter
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15767 ) Change subject: [util] Don't use static function ptrs for non-static member functions in BlockBloom filter .. Patch Set 1: I think using static pointers to initialize members of class instance is incorrect. Thus, commit message should say something like "Fixed incorrect code". -- To view, visit http://gerrit.cloudera.org:8080/15767 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39703fd1a7e256ff60ef86d0b370590fbb526380 Gerrit-Change-Number: 15767 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 21 Apr 2020 19:38:12 + Gerrit-HasComments: No
[kudu-CR] [HybridClockTest] update TestNtpDiagnostics scenario
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15774 ) Change subject: [HybridClockTest] update TestNtpDiagnostics scenario .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70 Gerrit-Change-Number: 15774 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Tue, 21 Apr 2020 19:28:12 + Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) [test] Fix types-test on MacOS
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15773 ) Change subject: [test] Fix types-test on MacOS .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: Ic11d2e1828e141f678ea8f417c57b188e322c660 Gerrit-Change-Number: 15773 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Tue, 21 Apr 2020 19:22:37 + Gerrit-HasComments: No
[kudu-CR] [partitioning] KUDU-2671 Support for different hash partitioning per range partition.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15758 to look at the new patch set (#3). Change subject: [partitioning] KUDU-2671 Support for different hash partitioning per range partition. .. [partitioning] KUDU-2671 Support for different hash partitioning per range partition. Updated algorithm in Partition::CreatePartitions() to support different hash partitioning per range partition. Current range bounds represented as std::pair, but we need to add third parameter. For that it would be nice to replace std::pair with std::tuple. But replacing std::pair with std::tuple would require to change a lot of code. Thus, I added another parameter to Partition::CreatePartitions(), which describes hash partitiong schema for every range bound and must have same size as range bounds. Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 --- M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/partition_pruner-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet-harness.h M src/kudu/tserver/tablet_server-test.cc 8 files changed, 166 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15758/3 -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [partitioning] KUDU-2671 Support for different hash partitioning per range partition.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15758 to look at the new patch set (#2). Change subject: [partitioning] KUDU-2671 Support for different hash partitioning per range partition. .. [partitioning] KUDU-2671 Support for different hash partitioning per range partition. Updated algorithm in Partition::CreatePartitions() to support different hash partitioning per range partition. Current range bounds represented as std::pair, but we need to add third parameter. For that it would be nice to replace std::pair with std::tuple. But replacing std::pair with std::tuple would require to change a lot of code. Thus, I added another parameter to Partition::CreatePartitions(), which describes hash partitiong schema for every range bound and must have same size as range bounds. Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 --- M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/partition_pruner-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet-harness.h M src/kudu/tserver/tablet_server-test.cc 8 files changed, 165 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15758/2 -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 2 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [docs] Update schema documentation
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15757 ) Change subject: [docs] Update schema documentation .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I681e0af517b08c348420b3b217c393797717d3fc Gerrit-Change-Number: 15757 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Mon, 20 Apr 2020 11:22:43 + Gerrit-HasComments: No
[kudu-CR] [partitioning] CDPD-6141 Support for different hash partitioning per range partition.
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15758 Change subject: [partitioning] CDPD-6141 Support for different hash partitioning per range partition. .. [partitioning] CDPD-6141 Support for different hash partitioning per range partition. Updated algorithm in Partition::CreatePartitions() to support different hash partitioning per range partition. Current range bounds represented as std::pair, but we need to add third parameter. For that it would be nice to replace std::pair with std::tuple. But replacing std::pair with std::tuple would require to change a lot of code. Thus, I added another parameter to Partition::CreatePartitions(), which describes hash partitiong schema for every range bound and must have same size as range bounds. Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 --- M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/partition_pruner-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet-harness.h M src/kudu/tserver/tablet_server-test.cc 8 files changed, 160 insertions(+), 45 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15758/1 -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin
[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a Gerrit-Change-Number: 15685 Gerrit-PatchSet: 8 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Lieber-Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hannah Nguyen Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 18 Apr 2020 05:59:22 + Gerrit-HasComments: No
[kudu-CR] WIP: Add basic support for unix sockets
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15691 ) Change subject: WIP: Add basic support for unix sockets .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40ce3e4e1b98f806f0c29d2fbd88789657218c4b Gerrit-Change-Number: 15691 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Thu, 09 Apr 2020 07:10:57 + Gerrit-HasComments: No
[kudu-CR] net: make Sockaddr more generic for other address families
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifff57e13a0e9b86b191d776ead67371b1e2ed4e3 Gerrit-Change-Number: 15690 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Thu, 09 Apr 2020 00:19:36 + Gerrit-HasComments: No
[kudu-CR] [python] KUDU-2632 Add DATE type support
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 ) Change subject: [python] KUDU-2632 Add DATE type support .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py File python/kudu/util.py: http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py@197 PS3, Line 197: nday > nit: ndays Done -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 5 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Tue, 07 Apr 2020 01:01:54 + Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-2632 Add DATE type support
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15645 to look at the new patch set (#5). Change subject: [python] KUDU-2632 Add DATE type support .. [python] KUDU-2632 Add DATE type support There are two utility functions which perfrom conversion between Kudu DATE and Python datetime.date: unix_epoch_days_to_date() - converts number of days since Unix ecpoch to datetime.date() date_to_unix_epoch_days() - converts datetime.date() to number of days since Unix ecpoch Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 --- M python/kudu/__init__.py M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/schema.pyx M python/kudu/tests/test_scanner.py M python/kudu/tests/test_scantoken.py M python/kudu/tests/test_schema.py M python/kudu/tests/util.py M python/kudu/util.py 9 files changed, 113 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/15645/5 -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 5 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [python] KUDU-2632 Add DATE type support
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 ) Change subject: [python] KUDU-2632 Add DATE type support .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/tests/test_scanner.py@a365 PS3, Line 365: > What happened to types[8] here? Should the change to be to add types[9]? Done http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py File python/kudu/util.py: http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py@201 PS3, Line 201: dat > nit: date Done http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py@208 PS3, Line 208: dat > here too Done -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 4 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Tue, 07 Apr 2020 01:00:32 + Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-2632 Add DATE type support
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15645 to look at the new patch set (#4). Change subject: [python] KUDU-2632 Add DATE type support .. [python] KUDU-2632 Add DATE type support There are two utility functions which perfrom conversion between Kudu DATE and Python datetime.date: unix_epoch_days_to_date() - converts number of days since Unix ecpoch to datetime.date() date_to_unix_epoch_days() - converts datetime.date() to number of days since Unix ecpoch Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 --- M python/kudu/__init__.py M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/schema.pyx M python/kudu/tests/test_scanner.py M python/kudu/tests/test_scantoken.py M python/kudu/tests/test_schema.py M python/kudu/tests/util.py M python/kudu/util.py 9 files changed, 113 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/15645/4 -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 4 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [python] KUDU-2632 Add DATE type support
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 ) Change subject: [python] KUDU-2632 Add DATE type support .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py File python/kudu/tests/util.py: http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py@112 PS1, Line 112: datetime.date(2020,1,1) > For the sake of covering corner cases and making sure datetime.date() prope I think for this kind of testing we just need to write tests for util functions unix_epoch_days_to_date() and date_to_unix_epoch_days() -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Mon, 06 Apr 2020 17:34:19 + Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-2632 Add DATE type support
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 ) Change subject: [python] KUDU-2632 Add DATE type support .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/test_scanner.py@349 PS1, Line 349: self.assertEqual(types[0], np.int64) : self.assertEqual(types[1], 'datetime64[ns, UTC]') : self.assertEqual(types[2], np.object) : self.assertEqual(types[3], np.object) : self.assertEqual(types[4], np.bool) : self.assertEqual(types[5], np.float64) : self.assertEqual(types[6], np.int8) : self.assertEqual(types[7], np.object) : self.assertEqual(types[8], np.object) : self.assertEqual(types[9], np.object) : self.assertEqual(types[10], np.float32) : else: : self.assertEqual(types[0], np.int64) : self.assertEqual(types[1], 'datetime64[ns, UTC]') : self.assertEqual(types[2], np.object) : self.assertEqual(types[3], np.bool) : self.assertEqual(types[4], np.float64) : self.assertEqual(types[5], np.int8) : self.assertEqual(types[6], np.object) > It seems this needs to be updated to accommodate for newly added columns of Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py File python/kudu/util.py: http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@186 PS1, Line 186: Convert > If following the same style of the docs as for the other functions in this Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@188 PS1, Line 188: of seconds per day (86400). > nit: add a period Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@189 PS1, Line 189: > extra spaces Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@190 PS1, Line 190: Parameters > Could you add information about the parameter of this function into the doc Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@198 PS1, Line 198: """ > Convert Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@199 PS1, Line 199: return datetime.datetime.utcfromtimestamp(ndays * 86400).date() > nit: add a period Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@203 PS1, Line 203: Convert d > Is this a mismatch between the actual name of the parameter and the documen Done -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Mon, 06 Apr 2020 16:53:20 + Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-2632 Add DATE type support
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15645 to look at the new patch set (#3). Change subject: [python] KUDU-2632 Add DATE type support .. [python] KUDU-2632 Add DATE type support There are two utility functions which perfrom conversion between Kudu DATE and Python datetime.date: unix_epoch_days_to_date() - converts number of days since Unix ecpoch to datetime.date() date_to_unix_epoch_days() - converts datetime.date() to number of days since Unix ecpoch Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 --- M python/kudu/__init__.py M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/schema.pyx M python/kudu/tests/test_scanner.py M python/kudu/tests/test_scantoken.py M python/kudu/tests/test_schema.py M python/kudu/tests/util.py M python/kudu/util.py 9 files changed, 113 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/15645/3 -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] KUDU-2632 Add DATE type support
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15645 to look at the new patch set (#2). Change subject: [python] KUDU-2632 Add DATE type support .. [python] KUDU-2632 Add DATE type support There are two utility functions which perfrom conversion between Kudu DATE and Python datetime.date: unix_epoch_days_to_date() - converts number of days since Unix ecpoch to datetime.date() date_to_unix_epoch_days() - converts datetime.date() to number of days since Unix ecpoch Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 --- M python/kudu/__init__.py M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/schema.pyx M python/kudu/tests/test_scanner.py M python/kudu/tests/test_scantoken.py M python/kudu/tests/test_schema.py M python/kudu/tests/util.py M python/kudu/util.py 9 files changed, 108 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/15645/2 -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 2 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] KUDU-2632 Add DATE type support
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15645 Change subject: [python] KUDU-2632 Add DATE type support .. [python] KUDU-2632 Add DATE type support There are two utility functions which perfrom conversion between Kudu DATE and Python datetime.date: unix_epoch_days_to_date() - converts number of days since Unix ecpoch to datetime.date() date_to_unix_epoch_days() - converts datetime.date() to number of days since Unix ecpoch Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 --- M python/kudu/__init__.py M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/schema.pyx M python/kudu/tests/test_scanner.py M python/kudu/tests/test_scantoken.py M python/kudu/tests/test_schema.py M python/kudu/tests/util.py M python/kudu/util.py 9 files changed, 104 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/15645/1 -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Replaced new Date(0) with DateUtil.epochDaysToSqlDate(0)
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15425 Change subject: [KUDU-2632] Replaced new Date(0) with DateUtil.epochDaysToSqlDate(0) .. [KUDU-2632] Replaced new Date(0) with DateUtil.epochDaysToSqlDate(0) "new Date" creates different dates depending on timezone. That causes tests to fail. In order to avoid it, "new Date" is replaced with DateUtil.epochDaysToSqlDate(0) which internally calls LocalDate which is timezone irrespective. Change-Id: Ic381bac8c68499445b6f00a1a76881dac513aede --- M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java 4 files changed, 12 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/15425/1 -- To view, visit http://gerrit.cloudera.org:8080/15425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic381bac8c68499445b6f00a1a76881dac513aede Gerrit-Change-Number: 15425 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin
[kudu-CR] WIP KUDU-1625: background op to GC ancient, empty rowsets
Volodymyr Verovkin has uploaded a new patch set (#2) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: WIP KUDU-1625: background op to GC ancient, empty rowsets .. WIP KUDU-1625: background op to GC ancient, empty rowsets This adds an experimental background op that deletes disk rowsets that have had all of their rows deleted. Only rowsets that meet the following criteria are considered for deletion: - For the sake of simplicity on bootstrap, the rowset should not have a DMS. I don't see a clear way to rebuild a DMS if the underlying DRS has been deleted. - The most recent update to the rowset must be later than the ancient history mark. It'd be nice if we could have the policy work for rowsets that are mostly deleted, but such a solution would come with difficult questions around write amplification and compatibility with the existing compactions strategies. At the very least, this patch should make the behavior less surprising in some delete-heavy workloads. WIP: - collect feedback - add tests Change-Id: I696e2a29ea52ad4e54801b495c322bc371787124 --- M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/delta_tracker.h M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/rowset.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet_metrics.cc M src/kudu/tablet/tablet_metrics.h M src/kudu/tablet/tablet_mm_ops.cc M src/kudu/tablet/tablet_mm_ops.h 13 files changed, 301 insertions(+), 41 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/15145/2 -- To view, visit http://gerrit.cloudera.org:8080/15145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I696e2a29ea52ad4e54801b495c322bc371787124 Gerrit-Change-Number: 15145 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [clock] update on Clock interface
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15215 ) Change subject: [clock] update on Clock interface .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c1944d54bf50e54c06c12e2fb9e57fc452b877 Gerrit-Change-Number: 15215 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Thu, 13 Feb 2020 19:22:44 + Gerrit-HasComments: No
[kudu-CR] [clock] cleanup on accessing HybridClock::next timestamp
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15216 ) Change subject: [clock] cleanup on accessing HybridClock::next_timestamp_ .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15216 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I251c538c65bfc75a882218c2d946c795e69bcbbe Gerrit-Change-Number: 15216 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Thu, 13 Feb 2020 08:34:52 + Gerrit-HasComments: No
[kudu-CR] [clock] update on Clock interface
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15215 ) Change subject: [clock] update on Clock interface .. Patch Set 1: You added several new metrics. What is their purpose ? Should be be documented ? -- To view, visit http://gerrit.cloudera.org:8080/15215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c1944d54bf50e54c06c12e2fb9e57fc452b877 Gerrit-Change-Number: 15215 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Thu, 13 Feb 2020 08:32:33 + Gerrit-HasComments: No
[kudu-CR] [clock] introduce time source auto selection
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 ) Change subject: [clock] introduce time source auto selection .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/15161/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15161/8//COMMIT_MSG@16 PS8, Line 16: * AWS and GCE cloud environments: the 'builtin' time source is 'builtin' + 'builtin_ntp_client_enable_auto_config' can be replaced with 'builtin_with_auto_config' and 'builtin_with_server_list' in order to simplify logic and reduce number of flags. -- To view, visit http://gerrit.cloudera.org:8080/15161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9f2bc94f4a1ad32fe365d4f6f0707913fb476a4 Gerrit-Change-Number: 15161 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Wed, 12 Feb 2020 21:09:55 + Gerrit-HasComments: Yes
[kudu-CR] [clock] introduce time source auto selection
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 ) Change subject: [clock] introduce time source auto selection .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock-test.cc File src/kudu/clock/hybrid_clock-test.cc: http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock-test.cc@382 PS6, Line 382: clock_.reset(new HybridClock); Why not to use std::make_unique() ? http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock.cc@91 PS6, Line 91: TIME_SOURCE_AUTO ", " Looks a bit cryptic. I suggest to replace macro with text (here and below). http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock.cc@466 PS6, Line 466: case TimeSource::SYSTEM_NTP_SYNC: Should it be wrapped into #if defined(KUDU_HAS_SYSTEM_TIME_SOURCE) ? -- To view, visit http://gerrit.cloudera.org:8080/15161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9f2bc94f4a1ad32fe365d4f6f0707913fb476a4 Gerrit-Change-Number: 15161 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 07 Feb 2020 20:40:25 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14517
to look at the new patch set (#17).
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
from
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestDateUtil.java
M
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
25 files changed, 490 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/17
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 17
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14517 ) Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client) .. Patch Set 15: Changes in Java code do not induce Scala code recompilation. Seems like there is no dependency between Java and Scala code. -- To view, visit http://gerrit.cloudera.org:8080/14517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2 Gerrit-Change-Number: 14517 Gerrit-PatchSet: 15 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 07 Feb 2020 09:21:41 + Gerrit-HasComments: No
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14517
to look at the new patch set (#16).
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
from
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestDateUtil.java
M
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
25 files changed, 489 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/16
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 16
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14517 ) Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client) .. Patch Set 15: (9 comments) http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@316 PS14, Line 316: checkColumn(schema.getColumnByIndex(columnIndex), Type.INT32); > I don't think we need to let users call getInt on a Date column. They can a Done http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@622 PS14, Line 622:*/ > Can we simplify the interface and only accept Date instead of int. Is there Done http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@1079 PS14, Line 1079: } > Can you add Date to this Java doc? Done http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@1175 PS14, Line 1175:* Type.INT8 -> java.lang.Byte > Here too. Done http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java File java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java: http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java@274 PS14, Line 274: case INT16: > I think this also needs to handle the Date object. This is called for defau Done http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java@308 PS14, Line 308: return buf.get(); > I think this should return a Date object. Done http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java: http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@624 PS14, Line 624:* Type.BOOL -> java.lang.Boolean > Can you update this Javadoc? Done http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java File java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java: http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java@142 PS14, Line 142:*/ > This should return a Date object. That will help eliminated the need for a Done http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java: http://gerrit.cloudera.org:8080/#/c/14517/14/java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java@470 PS14, Line 470: > Do we test default values anywhere? I think We do not test default values anywhere. -- To view, visit http://gerrit.cloudera.org:8080/14517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2 Gerrit-Change-Number: 14517 Gerrit-PatchSet: 15 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Thu, 06 Feb 2020 23:02:26 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14517
to look at the new patch set (#15).
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
from
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestDateUtil.java
M
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
25 files changed, 487 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/15
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 15
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14517 ) Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client) .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/14517/13/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala File java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala: http://gerrit.cloudera.org:8080/#/c/14517/13/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala@302 PS13, Line 302: .toString // TODO: Explicitly control print format : case Type.DATE => > I'm not a Scala expert, but this looks a bit strange. Actually, behavior of this function is same like https://github.com/apache/kudu/blob/0a555961c6dfa672bfc2d90d4fb26d0bff21c299/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java#L1149 And there we read comment "Returns the string value of serialized value according to the type of column." Thus, the type must Int. Fixed. -- To view, visit http://gerrit.cloudera.org:8080/14517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2 Gerrit-Change-Number: 14517 Gerrit-PatchSet: 14 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Fri, 31 Jan 2020 20:42:25 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14517
to look at the new patch set (#14).
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
from
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestDateUtil.java
M
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
25 files changed, 505 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/14
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 14
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [util] add error buffer for EasyCurl wrapper
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15101 ) Change subject: [util] add error buffer for EasyCurl wrapper .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e4a8a8a42671f141842ff6051aa18820a8f7f5a Gerrit-Change-Number: 15101 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 25 Jan 2020 02:22:34 + Gerrit-HasComments: No
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14517
to look at the new patch set (#13).
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
from
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestDateUtil.java
M
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
25 files changed, 507 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/13
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 13
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14517
to look at the new patch set (#11).
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
from
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestDateUtil.java
M
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
25 files changed, 501 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/11
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 11
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14517 ) Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client) .. Patch Set 10: Added new tests to https://gerrit.cloudera.org/#/c/14517/10/java/kudu-client/src/test/java/org/apache/kudu/util/TestDateUtil.java -- To view, visit http://gerrit.cloudera.org:8080/14517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2 Gerrit-Change-Number: 14517 Gerrit-PatchSet: 10 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Mon, 13 Jan 2020 08:41:03 + Gerrit-HasComments: No
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14517
to look at the new patch set (#10).
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
from
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestDateUtil.java
M
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
21 files changed, 485 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/10
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 10
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] WIP [util] utilities to get info on cloud instance
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14866 ) Change subject: WIP [util] utilities to get info on cloud instance .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc File src/kudu/util/cloud/instance_metadata.cc: http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc@86 PS1, Line 86: "169.254.169.123" > I'm not sure I follow. Configuration file for what? This is a pre-defined Sorry, I never saw IP address hardcoded. IMHO, it should be placed in textual configuration file. -- To view, visit http://gerrit.cloudera.org:8080/14866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I083f4803decaef5d6e7d44184bbd98b074d2578b Gerrit-Change-Number: 14866 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Mon, 13 Jan 2020 05:52:31 + Gerrit-HasComments: Yes
[kudu-CR] WIP [util] utilities to get info on cloud instance
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14866 ) Change subject: WIP [util] utilities to get info on cloud instance .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/14866/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14866/1//COMMIT_MSG@20 PS1, Line 20: builg Mistyped "build" http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc File src/kudu/util/cloud/instance_metadata.cc: http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc@86 PS1, Line 86: "169.254.169.123" This kind of information should be stored in some configuration file. http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc@104 PS1, Line 104: "http://169.254.169.254; : "/latest/meta-data/instance-id" This kind of information should be stored in some configuration file. http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc@121 PS1, Line 121: "http://169.254.169.254; : "/metadata/instance/compute/vmId?api-version=2018-10-01=text" This kind of information should be stored in some configuration file. http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc@142 PS1, Line 142: "http://metadata.google.internal; : "/computeMetadata/v1/instance/id" This kind of information should be stored in some configuration file. -- To view, visit http://gerrit.cloudera.org:8080/14866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I083f4803decaef5d6e7d44184bbd98b074d2578b Gerrit-Change-Number: 14866 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Thu, 09 Jan 2020 01:27:01 + Gerrit-HasComments: Yes
[kudu-CR] [tools] Fix create table tool for VARCHAR and DATE columns
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14983 ) Change subject: [tools] Fix create table tool for VARCHAR and DATE columns .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/14983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I249348e16dc06616b59ac92212a0a075aac2b2fa Gerrit-Change-Number: 14983 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Wed, 08 Jan 2020 19:17:22 + Gerrit-HasComments: No
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14517
to look at the new patch set (#9).
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
from
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestDateUtil.java
M
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
21 files changed, 462 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/9
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 9
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)
Volodymyr Verovkin has posted comments on this change. (
http://gerrit.cloudera.org:8080/14427 )
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)
..
Patch Set 12:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/14427/11/src/kudu/common/partial_row.h
File src/kudu/common/partial_row.h:
http://gerrit.cloudera.org:8080/#/c/14427/11/src/kudu/common/partial_row.h@450
PS11, Line 450:
> style nit: if continuing a statement on the next line, shift is two times o
Done
http://gerrit.cloudera.org:8080/#/c/14427/11/src/kudu/common/partial_row.cc
File src/kudu/common/partial_row.cc:
http://gerrit.cloudera.org:8080/#/c/14427/11/src/kudu/common/partial_row.cc@50
PS11, Line 50: const Schema& schema
> style nit: I'm not sure we widely use constant pointers as input parameters
Done
http://gerrit.cloudera.org:8080/#/c/14427/11/src/kudu/common/partial_row.cc@715
PS11, Line 715:int32_t* d
> nit: fix the alignment
Done
http://gerrit.cloudera.org:8080/#/c/14427/11/src/kudu/common/types-test.cc
File src/kudu/common/types-test.cc:
http://gerrit.cloudera.org:8080/#/c/14427/11/src/kudu/common/types-test.cc@56
PS11, Line 56: TestDateToString("1-01-01",
*DataTypeTraits::min_value());
: TestDateToString("-12-31",
*DataTypeTraits::max_value());
> Does it make sense to add a couple more cases to test for off-by-one issues
Done
http://gerrit.cloudera.org:8080/#/c/14427/11/src/kudu/common/types.h
File src/kudu/common/types.h:
http://gerrit.cloudera.org:8080/#/c/14427/11/src/kudu/common/types.h@604
PS11, Line 604: };
> nit: remove the extra line
Done
http://gerrit.cloudera.org:8080/#/c/14427/7/src/kudu/integration-tests/all_types-itest.cc
File src/kudu/integration-tests/all_types-itest.cc:
http://gerrit.cloudera.org:8080/#/c/14427/7/src/kudu/integration-tests/all_types-itest.cc@578
PS7, Line 578: KuduScanner scanner(table_.get());
> This seems like pretty important test coverage for data types that can be p
Done
--
To view, visit http://gerrit.cloudera.org:8080/14427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986
Gerrit-Change-Number: 14427
Gerrit-PatchSet: 12
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Greg Solovyev
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin
Gerrit-Comment-Date: Tue, 17 Dec 2019 01:36:44 +
Gerrit-HasComments: Yes
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14427 to look at the new patch set (#12). Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) .. [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) This adds a new DATE type, represented by an INT32 and that should store the number of days from the Unix epoch, January 1, 1970. Range: 0001-01-01 to -12-31 or -719162 to 2932896 (days; computed with mktime()/(24*60*60), timezone = GMT, daylight saving = 0) Range validation is done in KuduPartialRow::SetDate() function. Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 --- M src/kudu/client/client-unittest.cc M src/kudu/client/predicate-test.cc M src/kudu/client/scan_batch.cc M src/kudu/client/scan_batch.h M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/client/value.cc M src/kudu/common/common.proto M src/kudu/common/key_util.cc M src/kudu/common/partial_row.cc M src/kudu/common/partial_row.h M src/kudu/common/partition.cc M src/kudu/common/row.h M src/kudu/common/types-test.cc M src/kudu/common/types.cc M src/kudu/common/types.h M src/kudu/hms/hms_catalog-test.cc M src/kudu/hms/hms_catalog.cc M src/kudu/integration-tests/all_types-itest.cc M src/kudu/integration-tests/data_gen_util.cc M src/kudu/integration-tests/hms_itest-base.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/tools/tool_action_table.cc 24 files changed, 315 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/14427/12 -- To view, visit http://gerrit.cloudera.org:8080/14427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 Gerrit-Change-Number: 14427 Gerrit-PatchSet: 12 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14427 to look at the new patch set (#11). Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) .. [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) This adds a new DATE type, represented by an INT32 and that should store the number of days from the Unix epoch, January 1, 1970. Range: 0001-01-01 to -12-31 or -719162 to 2932896 (days; computed with mktime()/(24*60*60), timezone = GMT, daylight saving = 0) Range validation is done in KuduPartialRow::SetDate() function. Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 --- M src/kudu/client/client-unittest.cc M src/kudu/client/predicate-test.cc M src/kudu/client/scan_batch.cc M src/kudu/client/scan_batch.h M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/client/value.cc M src/kudu/common/common.proto M src/kudu/common/key_util.cc M src/kudu/common/partial_row.cc M src/kudu/common/partial_row.h M src/kudu/common/partition.cc M src/kudu/common/row.h M src/kudu/common/types-test.cc M src/kudu/common/types.cc M src/kudu/common/types.h M src/kudu/hms/hms_catalog-test.cc M src/kudu/hms/hms_catalog.cc M src/kudu/integration-tests/all_types-itest.cc M src/kudu/integration-tests/data_gen_util.cc M src/kudu/integration-tests/hms_itest-base.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/tools/tool_action_table.cc 24 files changed, 235 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/14427/11 -- To view, visit http://gerrit.cloudera.org:8080/14427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 Gerrit-Change-Number: 14427 Gerrit-PatchSet: 11 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14427 to look at the new patch set (#10). Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) .. [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) This adds a new DATE type, represented by an INT32 and that should store the number of days from the Unix epoch, January 1, 1970. Range: 0001-01-01 to -12-31 or -719162 to 2932896 (days; computed with mktime()/(24*60*60), timezone = GMT, daylight saving = 0) Range validation is done in KuduPartialRow::SetDate() function. Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 --- M src/kudu/client/client-unittest.cc M src/kudu/client/predicate-test.cc M src/kudu/client/scan_batch.cc M src/kudu/client/scan_batch.h M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/client/value.cc M src/kudu/common/common.proto M src/kudu/common/key_util.cc M src/kudu/common/partial_row.cc M src/kudu/common/partial_row.h M src/kudu/common/partition.cc M src/kudu/common/row.h M src/kudu/common/types-test.cc M src/kudu/common/types.cc M src/kudu/common/types.h M src/kudu/hms/hms_catalog-test.cc M src/kudu/hms/hms_catalog.cc M src/kudu/integration-tests/all_types-itest.cc M src/kudu/integration-tests/data_gen_util.cc M src/kudu/integration-tests/hms_itest-base.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/tools/tool_action_table.cc 24 files changed, 235 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/14427/10 -- To view, visit http://gerrit.cloudera.org:8080/14427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 Gerrit-Change-Number: 14427 Gerrit-PatchSet: 10 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14517
to look at the new patch set (#5).
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
from
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestDateUtil.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
18 files changed, 449 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/5
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 5
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14427 to look at the new patch set (#9). Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) .. [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) This adds a new DATE type, represented by an INT32 and that should store the number of days from the Unix epoch, January 1, 1970. Range: 0001-01-01 to -12-31 or -719162 to 2932896 (days; computed with mktime()/(24*60*60), timezone = GMT, daylight saving = 0) Range validation is done in KuduPartialRow::SetDate() function. Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 --- M src/kudu/client/client-unittest.cc M src/kudu/client/predicate-test.cc M src/kudu/client/scan_batch.cc M src/kudu/client/scan_batch.h M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/client/value.cc M src/kudu/common/common.proto M src/kudu/common/key_util.cc M src/kudu/common/partial_row.cc M src/kudu/common/partial_row.h M src/kudu/common/partition.cc M src/kudu/common/row.h M src/kudu/common/types-test.cc M src/kudu/common/types.cc M src/kudu/common/types.h M src/kudu/hms/hms_catalog-test.cc M src/kudu/hms/hms_catalog.cc M src/kudu/integration-tests/all_types-itest.cc M src/kudu/integration-tests/data_gen_util.cc M src/kudu/integration-tests/hms_itest-base.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/tools/tool_action_table.cc 24 files changed, 223 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/14427/9 -- To view, visit http://gerrit.cloudera.org:8080/14427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 Gerrit-Change-Number: 14427 Gerrit-PatchSet: 9 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] KUDU-1938 Add VARCHAR to schema design docs
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14865 ) Change subject: KUDU-1938 Add VARCHAR to schema design docs .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/14865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieae3000dde14f68a900dd63624d2778ce01cfa26 Gerrit-Change-Number: 14865 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Sat, 07 Dec 2019 01:26:39 + Gerrit-HasComments: No
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14517
to look at the new patch set (#4).
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
from
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestDateUtil.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
18 files changed, 443 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/4
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 4
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Volodymyr Verovkin has posted comments on this change. (
http://gerrit.cloudera.org:8080/14517 )
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
Patch Set 3:
(19 comments)
http://gerrit.cloudera.org:8080/#/c/14517/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14517/2//COMMIT_MSG@13
PS2, Line 13: from
> from
Done
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java:
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java@172
PS2, Line 172:
> trailing space
Done
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@646
PS2, Line 646: IllegalArgumentException
> Is it possible with given the Date range constraints? Overall, I think it
Done
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@674
PS2, Line 674: a Date
> nit: Date value stored in the column?
I just copied comments from Timestamp method. And it similar to other methods
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@692
PS2, Line 692: checkColumnExists(schema.getColumnByIndex(columnIndex));
: checkColumn(schema.getColumnByIndex(columnIndex), Type.D
> Should these two be swapped?
Done
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@698
PS2, Line 698:
> nit: trailing spaces
Done
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
File java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java:
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java@128
PS2, Line 128: inte
> nit: int value representable as DATE ?
Done
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java:
PS2:
> Add Apache license header.
Done
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java@9
PS2, Line 9: // http://www.apache.org/licenses/LICENSE-2.0
> It would be great to add unit tests for the methods of this class. Points
Done
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java@10
PS2, Line 10:
> Trailing spaces here and in few lines in this file.
Done
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java@11
PS2, Line 11: // Unless required by applicable law or agreed to in writing,
: // software distributed under the License is distributed on an
: // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> Could you add information on how these numbers were produced? I understand
Those numbers are produced by printing result Java expressions
System.out.println(LocalDate.parse("0001-01-01").toEpochDay()) -> -719162
System.out.println(LocalDate.parse("-12-31").toEpochDay()) -> 2932896
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java@22
PS2, Line 22:
> Does it make sense to provide the value in the error message?
Done
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java@27
PS2, Line 27:
> number of days
Done
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java@57
PS2, Line 57: /**
> Does it make sense to call checkDateWithinRange() here as it's done in epoc
It works correctly for all dates. It's useful to print out of range dates in
readable form.
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@653
PS2, Line 653: date colu
> date ?
Done
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java:
http://gerrit.cloudera.org:8080/#/c/14517/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java@440
PS2, Line
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14517
to look at the new patch set (#3).
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
from
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestDateUtil.java
M
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducer.java
M
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
20 files changed, 449 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/3
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 3
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14427 to look at the new patch set (#6). Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) .. [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) This adds a new DATE type, represented by an INT32 and that should store the number of days from the Unix epoch, January 1, 1970. Range: 0001-01-01 to -12-31 or -719162 to 2932896 (days; computed with mktime()/(24*60*60), timezone = GMT, daylight saving = 0) Range validation is done in KuduPartialRow::SetDate() function. Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 --- M src/kudu/client/client-unittest.cc M src/kudu/client/predicate-test.cc M src/kudu/client/scan_batch.cc M src/kudu/client/scan_batch.h M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/client/value.cc M src/kudu/common/common.proto M src/kudu/common/key_util.cc M src/kudu/common/partial_row.cc M src/kudu/common/partial_row.h M src/kudu/common/partition.cc M src/kudu/common/row.h M src/kudu/common/types-test.cc M src/kudu/common/types.cc M src/kudu/common/types.h M src/kudu/hms/hms_catalog-test.cc M src/kudu/hms/hms_catalog.cc M src/kudu/integration-tests/all_types-itest.cc M src/kudu/integration-tests/data_gen_util.cc M src/kudu/integration-tests/hms_itest-base.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/tools/tool_action_table.cc 24 files changed, 223 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/14427/6 -- To view, visit http://gerrit.cloudera.org:8080/14427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 Gerrit-Change-Number: 14427 Gerrit-PatchSet: 6 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14517
to look at the new patch set (#2).
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducer.java
M
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
M src/kudu/common/common.proto
20 files changed, 368 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/2
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 2
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
Volodymyr Verovkin has uploaded this change for review. (
http://gerrit.cloudera.org:8080/14517
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java
client)
..
[KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
This adds a new DATE type, represented by an INT32 and that should
store the number of days from the Unix epoch, January 1, 1970.
Range:
LocalDate.parse("0001-01-01").toEpochDay()
to
LocalDate.parse("-12-31").toEpochDay()
Range validation is done in DateUtil::checkDateWithinRange() function.
Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
---
M
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducer.java
M
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
M src/kudu/common/common.proto
20 files changed, 367 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/14517/1
--
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 1
Gerrit-Owner: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14427 to look at the new patch set (#5). Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) .. [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) This adds a new DATE type, represented by an INT32 and that should store the number of days from the Unix epoch, January 1, 1970. Range: 0001-01-01 to -12-31 or -719162 to 2932896 (days; computed with mktime()/(24*60*60), timezone = GMT, daylight saving = 0) Range validation is done in KuduPartialRow::SetDate() function. Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 --- M src/kudu/client/client-unittest.cc M src/kudu/client/predicate-test.cc M src/kudu/client/scan_batch.cc M src/kudu/client/scan_batch.h M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/client/value.cc M src/kudu/common/common.proto M src/kudu/common/key_util.cc M src/kudu/common/partial_row.cc M src/kudu/common/partial_row.h M src/kudu/common/partition.cc M src/kudu/common/row.h M src/kudu/common/types-test.cc M src/kudu/common/types.cc M src/kudu/common/types.h M src/kudu/hms/hms_catalog-test.cc M src/kudu/hms/hms_catalog.cc M src/kudu/integration-tests/all_types-itest.cc M src/kudu/integration-tests/hms_itest-base.cc M src/kudu/tools/data_gen_util.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/tools/tool_action_table.cc 24 files changed, 224 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/14427/5 -- To view, visit http://gerrit.cloudera.org:8080/14427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 Gerrit-Change-Number: 14427 Gerrit-PatchSet: 5 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)
Volodymyr Verovkin has posted comments on this change. (
http://gerrit.cloudera.org:8080/14427 )
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)
..
Patch Set 5:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/14427/4/src/kudu/common/partial_row.cc
File src/kudu/common/partial_row.cc:
http://gerrit.cloudera.org:8080/#/c/14427/4/src/kudu/common/partial_row.cc@298
PS4, Line 298: Status KuduPartialRow::SetInt32(int col_idx, int32_t val) {
> Could add a PREDICT_FALSE here.
Done
http://gerrit.cloudera.org:8080/#/c/14427/4/src/kudu/common/partial_row.cc@296
PS4, Line 296: return Set >(col_idx, val);
: }
: Status KuduPartialRow::SetInt32(int col_idx, int32_t val) {
: return Set >(col_idx, val);
: }
: Status KuduPartialRow::SetInt64(int col_idx, int64_t val) {
: return Set >(col_idx, val);
: }
: Status KuduPartialRow::SetUnixTimeMicros(int col_idx, int64_t
micros_since_utc_epoch) {
: return Set Nit: move to the top of the file. That's where we usually stash static func
Done
http://gerrit.cloudera.org:8080/#/c/14427/4/src/kudu/common/types-test.cc
File src/kudu/common/types-test.cc:
http://gerrit.cloudera.org:8080/#/c/14427/4/src/kudu/common/types-test.cc@54
PS4, Line 54: TestDateToString("1-01-01", *DataTypeTraits::min_value());
> What are the expectations around leading 0s? Should this be "0001-01-01"?
1) It's just AppendDebugStringForValue() function.
2) There is no built-in format for 4 digit year.
http://gerrit.cloudera.org:8080/#/c/14427/4/src/kudu/common/types.h
File src/kudu/common/types.h:
http://gerrit.cloudera.org:8080/#/c/14427/4/src/kudu/common/types.h@583
PS4, Line 583: static constexpr int32_t kMinValue = -719162; //
mktime(0001-01-01)
: static constexpr int32_t kMaxValue = 2932896; // mkti
> These two could be static variables declared in the body of AppendDebugStri
Done
http://gerrit.cloudera.org:8080/#/c/14427/4/src/kudu/common/types.h@603
PS4, Line 603: }
> Nit: should be IsValidValue
Done
http://gerrit.cloudera.org:8080/#/c/14427/4/src/kudu/common/types.cc
File src/kudu/common/types.cc:
http://gerrit.cloudera.org:8080/#/c/14427/4/src/kudu/common/types.cc@116
PS4, Line 116: strin
> Nit: add using and drop.
Done
http://gerrit.cloudera.org:8080/#/c/14427/4/src/kudu/common/types.cc@122
PS4, Line 122: ix_e
> Nit: "DATE"
Done
--
To view, visit http://gerrit.cloudera.org:8080/14427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986
Gerrit-Change-Number: 14427
Gerrit-PatchSet: 5
Gerrit-Owner: Volodymyr Verovkin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Greg Solovyev
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin
Gerrit-Comment-Date: Thu, 17 Oct 2019 01:29:23 +
Gerrit-HasComments: Yes
[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14427 to look at the new patch set (#4). Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) .. [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) This adds a new DATE type, represented by an INT32 and that should store the number of days from the Unix epoch, January 1, 1970. Range: 0001-01-01 to -12-31 or -719162 to 2932896 (days; computed with mktime()/(24*60*60), timezone = GMT, daylight saving = 0) Range validation is done in KuduPartialRow::SetDate() function. Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 --- M src/kudu/client/client-unittest.cc M src/kudu/client/predicate-test.cc M src/kudu/client/scan_batch.cc M src/kudu/client/scan_batch.h M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/client/value.cc M src/kudu/common/common.proto M src/kudu/common/key_util.cc M src/kudu/common/partial_row.cc M src/kudu/common/partial_row.h M src/kudu/common/partition.cc M src/kudu/common/row.h M src/kudu/common/types-test.cc M src/kudu/common/types.cc M src/kudu/common/types.h M src/kudu/hms/hms_catalog-test.cc M src/kudu/hms/hms_catalog.cc M src/kudu/integration-tests/all_types-itest.cc M src/kudu/integration-tests/hms_itest-base.cc M src/kudu/tools/data_gen_util.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/tools/tool_action_table.cc 24 files changed, 222 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/14427/4 -- To view, visit http://gerrit.cloudera.org:8080/14427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 Gerrit-Change-Number: 14427 Gerrit-PatchSet: 4 Gerrit-Owner: Volodymyr Verovkin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin
