[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-16 Thread Yifan Zhang (Code Review) 
Yifan Zhang has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19594 )

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..

[KUDU-3452] Make validate tablet creating task not affected

Currently, creating a table with RF=n when the number of
healthy tservers is less than n will get stuck. Because
catalog manager creates tablets for it will fail and retry
continuously. At the same time, creating a table with RF=m
also will get stuck even if there are more than m healthy
tservers. Because catalog manager will return when finds a
tablet-creating task failed and will not try to select replicas
for other PREPARING tablets. For example, creating a three
replicas table times out when one of three tablet servers becomes
unavailable. After that, creating a two-replicas table also
will timeout even if there are enough tablet servers to place
its replicas. The validate two-replicas table-creating task will
be affected by invalidate three-replicas table-creating task.

This patch fixes this problem. If a task of creating tablet fail,
it will not return immediately, but let other tasks of creating
other tablets keep on running.

Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Reviewed-on: http://gerrit.cloudera.org:8080/19594
Reviewed-by: Yifan Zhang 
Tested-by: Yifan Zhang 
---
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 109 insertions(+), 5 deletions(-)

Approvals:
  Yifan Zhang: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 25
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-16 Thread Yifan Zhang (Code Review) 
Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19594 )

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..


Patch Set 24: Verified+1

Unrelated test failures in log-rolling-itest (RELEASE mode).


--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 24
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Tue, 16 May 2023 10:20:45 +
Gerrit-HasComments: No

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-16 Thread Yifan Zhang (Code Review) 
Yifan Zhang has removed a vote on this change.

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 24
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-16 Thread Yifan Zhang (Code Review) 
Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19594 )

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..


Patch Set 24: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 24
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Tue, 16 May 2023 09:40:24 +
Gerrit-HasComments: No

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-16 Thread Wang Xixu (Code Review) 
Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19594 )

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..


Patch Set 24:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19594/23/src/kudu/integration-tests/create-table-itest.cc
File src/kudu/integration-tests/create-table-itest.cc:

http://gerrit.cloudera.org:8080/#/c/19594/23/src/kudu/integration-tests/create-table-itest.cc@782
PS23, Line 782: const
> nit: What about using 'constexpr const'? Same as elsewhere.
Done


http://gerrit.cloudera.org:8080/#/c/19594/23/src/kudu/integration-tests/create-table-itest.cc@801
PS23, Line 801:   // Wait until the tablet server become unavailable for 
replicas placement.
> nit: Wait until the tablet server become unavailable for replicas placement
Done



--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 24
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Tue, 16 May 2023 09:20:15 +
Gerrit-HasComments: Yes

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-16 Thread Wang Xixu (Code Review) 
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu 
Jenkins, KeDeng,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19594

to look at the new patch set (#24).

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..

[KUDU-3452] Make validate tablet creating task not affected

Currently, creating a table with RF=n when the number of
healthy tservers is less than n will get stuck. Because
catalog manager creates tablets for it will fail and retry
continuously. At the same time, creating a table with RF=m
also will get stuck even if there are more than m healthy
tservers. Because catalog manager will return when finds a
tablet-creating task failed and will not try to select replicas
for other PREPARING tablets. For example, creating a three
replicas table times out when one of three tablet servers becomes
unavailable. After that, creating a two-replicas table also
will timeout even if there are enough tablet servers to place
its replicas. The validate two-replicas table-creating task will
be affected by invalidate three-replicas table-creating task.

This patch fixes this problem. If a task of creating tablet fail,
it will not return immediately, but let other tasks of creating
other tablets keep on running.

Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
---
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 109 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/19594/24
--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 24
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-16 Thread Yifan Zhang (Code Review) 
Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19594 )

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..


Patch Set 23: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19594/23/src/kudu/integration-tests/create-table-itest.cc
File src/kudu/integration-tests/create-table-itest.cc:

http://gerrit.cloudera.org:8080/#/c/19594/23/src/kudu/integration-tests/create-table-itest.cc@782
PS23, Line 782: const
nit: What about using 'constexpr const'? Same as elsewhere.


http://gerrit.cloudera.org:8080/#/c/19594/23/src/kudu/integration-tests/create-table-itest.cc@801
PS23, Line 801:   // Wait for tablet server heartbeat timeout.
nit: Wait until the tablet server become unavailable for replicas placement.



--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 23
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Tue, 16 May 2023 08:57:38 +
Gerrit-HasComments: Yes

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-15 Thread Wang Xixu (Code Review) 
Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19594 )

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..


Patch Set 23:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19594/21/src/kudu/integration-tests/create-table-itest.cc
File src/kudu/integration-tests/create-table-itest.cc:

http://gerrit.cloudera.org:8080/#/c/19594/21/src/kudu/integration-tests/create-table-itest.cc@685
PS21, Line 685: // Shutdown 3 tablet ser
> Check the result is OK?
One tablet server is still stopped, the result of KSCK will be not OK, please 
see line 703.


http://gerrit.cloudera.org:8080/#/c/19594/21/src/kudu/integration-tests/create-table-itest.cc@704
PS21, Line 704: // Restart the first tablet server.
> Although the ksck is OK, but didn't check the existence of kNotEnoughTServe
Done



--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 23
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Tue, 16 May 2023 02:58:51 +
Gerrit-HasComments: Yes

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-15 Thread Wang Xixu (Code Review) 
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu 
Jenkins, KeDeng,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19594

to look at the new patch set (#23).

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..

[KUDU-3452] Make validate tablet creating task not affected

Currently, creating a table with RF=n when the number of
healthy tservers is less than n will get stuck. Because
catalog manager creates tablets for it will fail and retry
continuously. At the same time, creating a table with RF=m
also will get stuck even if there are more than m healthy
tservers. Because catalog manager will return when finds a
tablet-creating task failed and will not try to select replicas
for other PREPARING tablets. For example, creating a three
replicas table times out when one of three tablet servers becomes
unavailable. After that, creating a two-replicas table also
will timeout even if there are enough tablet servers to place
its replicas. The validate two-replicas table-creating task will
be affected by invalidate three-replicas table-creating task.

This patch fixes this problem. If a task of creating tablet fail,
it will not return immediately, but let other tasks of creating
other tablets keep on running.

Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
---
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 109 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/19594/23
--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 23
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-15 Thread Wang Xixu (Code Review) 
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu 
Jenkins, KeDeng,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19594

to look at the new patch set (#22).

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..

[KUDU-3452] Make validate tablet creating task not affected

Currently, creating a table with RF=n when the number of
healthy tservers is less than n will get stuck. Because
catalog manager creates tablets for it will fail and retry
continuously. At the same time, creating a table with RF=m
also will get stuck even if there are more than m healthy
tservers. Because catalog manager will return when finds a
tablet-creating task failed and will not try to select replicas
for other PREPARING tablets. For example, creating a three
replicas table times out when one of three tablet servers becomes
unavailable. After that, creating a two-replicas table also
will timeout even if there are enough tablet servers to place
its replicas. The validate two-replicas table-creating task will
be affected by invalidate three-replicas table-creating task.

This patch fixes this problem. If a task of creating tablet fail,
it will not return immediately, but let other tasks of creating
other tablets keep on running.

Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
---
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 110 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/19594/22
--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 22
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-15 Thread Yingchun Lai (Code Review) 
Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19594 )

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..


Patch Set 21:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19594/21/src/kudu/integration-tests/create-table-itest.cc
File src/kudu/integration-tests/create-table-itest.cc:

http://gerrit.cloudera.org:8080/#/c/19594/21/src/kudu/integration-tests/create-table-itest.cc@685
PS21, Line 685: kudu::tools::RunKuduTool
Check the result is OK?


http://gerrit.cloudera.org:8080/#/c/19594/21/src/kudu/integration-tests/create-table-itest.cc@704
PS21, Line 704: ClusterVerifier cv(cluster_.get());
Although the ksck is OK, but didn't check the existence of 
kNotEnoughTServersTableId, should check that?



--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 21
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Mon, 15 May 2023 10:03:15 +
Gerrit-HasComments: Yes

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-15 Thread Yuqi Du (Code Review) 
Yuqi Du has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19594 )

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..


Patch Set 21: Code-Review+1

LGTM.

Jenkins task failed seems not due to this patch.


--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 21
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Mon, 15 May 2023 06:44:05 +
Gerrit-HasComments: No

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-11 Thread Wang Xixu (Code Review) 
Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19594 )

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..


Patch Set 21:

(1 comment)

> Patch Set 20:
>
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/19594/20/src/kudu/integration-tests/create-table-itest.cc
File src/kudu/integration-tests/create-table-itest.cc:

http://gerrit.cloudera.org:8080/#/c/19594/20/src/kudu/integration-tests/create-table-itest.cc@641
PS20, Line 641: Substitute("--tserver_unresponsive_timeout_
> nit: This comment about flag value is not correct.
Done



--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 21
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Fri, 12 May 2023 02:02:37 +
Gerrit-HasComments: Yes

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-11 Thread Wang Xixu (Code Review) 
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu 
Jenkins, KeDeng,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19594

to look at the new patch set (#21).

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..

[KUDU-3452] Make validate tablet creating task not affected

Currently, creating a table with RF=n when the number of
healthy tservers is less than n will get stuck. Because
catalog manager creates tablets for it will fail and retry
continuously. At the same time, creating a table with RF=m
also will get stuck even if there are more than m healthy
tservers. Because catalog manager will return when finds a
tablet-creating task failed and will not try to select replicas
for other PREPARING tablets. For example, creating a three
replicas table times out when one of three tablet servers becomes
unavailable. After that, creating a two-replicas table also
will timeout even if there are enough tablet servers to place
its replicas. The validate two-replicas table-creating task will
be affected by invalidate three-replicas table-creating task.

This patch fixes this problem. If a task of creating tablet fail,
it will not return immediately, but let other tasks of creating
other tablets keep on running.

Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
---
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 98 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/19594/21
--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 21
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-11 Thread Yifan Zhang (Code Review) 
Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19594 )

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..


Patch Set 20:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19594/20/src/kudu/integration-tests/create-table-itest.cc
File src/kudu/integration-tests/create-table-itest.cc:

http://gerrit.cloudera.org:8080/#/c/19594/20/src/kudu/integration-tests/create-table-itest.cc@641
PS20, Line 641: // Set tablet server heart beat timeout 1s.
nit: This comment about flag value is not correct.



--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 20
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Thu, 11 May 2023 16:49:25 +
Gerrit-HasComments: Yes

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-11 Thread Wang Xixu (Code Review) 
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu 
Jenkins, KeDeng,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19594

to look at the new patch set (#20).

Change subject: [KUDU-3452] Make validate tablet creating task not affected
..

[KUDU-3452] Make validate tablet creating task not affected

Currently, creating a table with RF=n when the number of
healthy tservers is less than n will get stuck. Because
catalog manager creates tablets for it will fail and retry
continuously. At the same time, creating a table with RF=m
also will get stuck even if there are more than m healthy
tservers. Because catalog manager will return when finds a
tablet-creating task failed and will not try to select replicas
for other PREPARING tablets. For example, creating a three
replicas table times out when one of three tablet servers becomes
unavailable. After that, creating a two-replicas table also
will timeout even if there are enough tablet servers to place
its replicas. The validate two-replicas table-creating task will
be affected by invalidate three-replicas table-creating task.

This patch fixes this problem. If a task of creating tablet fail,
it will not return immediately, but let other tasks of creating
other tablets keep on running.

Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
---
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 99 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/19594/20
--
To view, visit http://gerrit.cloudera.org:8080/19594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9
Gerrit-Change-Number: 19594
Gerrit-PatchSet: 20
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du