[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20527 ) Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. [Python] KUDU-3353 add support for UPSERT IGNORE This patch is a follow-up to commit: ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0, it adds UPSERT IGNORE support to the Python client. Extended the already existing tests: * added write op metrics verification for immutable column tests, * extended immutable column tests with UPSERT IGNORE test, * addressed an UPSERT IGNORE TODO in the auto-incrementing column tests. Change-Id: I9112b96a5688287352307c05e60030a217154cbd Reviewed-on: http://gerrit.cloudera.org:8080/20527 Tested-by: Kudu Jenkins Reviewed-by: Yingchun Lai --- M python/kudu/__init__.py M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/tests/test_client.py 4 files changed, 139 insertions(+), 16 deletions(-) Approvals: Kudu Jenkins: Verified Yingchun Lai: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9112b96a5688287352307c05e60030a217154cbd Gerrit-Change-Number: 20527 Gerrit-PatchSet: 6 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20527 ) Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. Patch Set 5: Code-Review+2 Thanks for the contribution! -- To view, visit http://gerrit.cloudera.org:8080/20527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9112b96a5688287352307c05e60030a217154cbd Gerrit-Change-Number: 20527 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 11 Oct 2023 15:53:51 + Gerrit-HasComments: No
[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20527 ) Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/client.pyx@3201 PS3, Line 3201: del self.op > Please follow standard python blank line conventions as rest of the file do Done http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/tests/test_client.py@530 PS3, Line 530: # successful_upsers++, upsert_ignore_errors++ > nit: remove the extra blank line. Done -- To view, visit http://gerrit.cloudera.org:8080/20527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9112b96a5688287352307c05e60030a217154cbd Gerrit-Change-Number: 20527 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 11 Oct 2023 13:02:50 + Gerrit-HasComments: Yes
[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE
Hello Alexey Serbin, Zoltan Martonka, Yingchun Lai, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20527 to look at the new patch set (#5). Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. [Python] KUDU-3353 add support for UPSERT IGNORE This patch is a follow-up to commit: ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0, it adds UPSERT IGNORE support to the Python client. Extended the already existing tests: * added write op metrics verification for immutable column tests, * extended immutable column tests with UPSERT IGNORE test, * addressed an UPSERT IGNORE TODO in the auto-incrementing column tests. Change-Id: I9112b96a5688287352307c05e60030a217154cbd --- M python/kudu/__init__.py M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/tests/test_client.py 4 files changed, 139 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/20527/5 -- To view, visit http://gerrit.cloudera.org:8080/20527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9112b96a5688287352307c05e60030a217154cbd Gerrit-Change-Number: 20527 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20527 ) Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/tests/test_client.py@530 PS3, Line 530: nit: remove the extra blank line. -- To view, visit http://gerrit.cloudera.org:8080/20527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9112b96a5688287352307c05e60030a217154cbd Gerrit-Change-Number: 20527 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 11 Oct 2023 03:06:12 + Gerrit-HasComments: Yes
[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20527 ) Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/client.pyx@3201 PS3, Line 3201: Please follow standard python blank line conventions as rest of the file does: https://peps.python.org/pep-0008/#blank-lines 2 blanks between top level classes and functions. -- To view, visit http://gerrit.cloudera.org:8080/20527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9112b96a5688287352307c05e60030a217154cbd Gerrit-Change-Number: 20527 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Mon, 09 Oct 2023 12:58:11 + Gerrit-HasComments: Yes
[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20527 to look at the new patch set (#2). Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. [Python] KUDU-3353 add support for UPSERT IGNORE This patch is a follow-up to commit: ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0, it adds UPSERT IGNORE support to the Python client. Extended the already existing tests: * added write op metrics verification for immutable column tests, * extended immutable column tests with UPSERT IGNORE test, * addressed an UPSERT IGNORE TODO in the auto-incrementing column tests. Change-Id: I9112b96a5688287352307c05e60030a217154cbd --- M python/kudu/__init__.py M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/tests/test_client.py 4 files changed, 137 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/20527/2 -- To view, visit http://gerrit.cloudera.org:8080/20527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9112b96a5688287352307c05e60030a217154cbd Gerrit-Change-Number: 20527 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20527 Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. [Python] KUDU-3353 add support for UPSERT IGNORE This patch is a follow-up to commit: ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0, it adds UPSERT IGNORE support to the Python client. Extended the already existing tests: * added write op metrics verification for immutable column tests, * extended immutable column tests with UPSERT IGNORE test, * addressed an UPSERT IGNORE TODO in the auto-incrementing column tests. Change-Id: I9112b96a5688287352307c05e60030a217154cbd --- M python/kudu/__init__.py M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/tests/test_client.py 4 files changed, 145 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/20527/1 -- To view, visit http://gerrit.cloudera.org:8080/20527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9112b96a5688287352307c05e60030a217154cbd Gerrit-Change-Number: 20527 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber
