[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Will Berkeley (Code Review)]

Will Berkeley has submitted this change and it was merged.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


[java] Replace interface-annotations with Apache Yetus annotations

Apache Yetus, like our interface-annotations module, was forked
from Hadoop's audience annotations. It does everything
interface-annotations does, using the same vocabulary, and
possibly more, so let's use it instead.

Projects with dependencies on kudu-client or kudu-spark won't
need to change anything in their poms.

This is a binary incompatible change since a jar built after
this change can't be swapped in for a jar built before it-- this
would also require swapping the interface-annotations jar on the
classpath with the appropriate Yetus jar.

I also manually checked that the generated javadocs for the
client look the same as before.

Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Reviewed-on: http://gerrit.cloudera.org:8080/7235
Reviewed-by: Dan Burkert 
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
D java/interface-annotations/pom.xml
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceAudience.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceStability.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsJDiffDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/IncludePublicAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/RootDocProcessor.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/StabilityOptions.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/package-info.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
M java/kudu-client/pom.xml
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/BatchResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Delete.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/HasFailedRpcException.java
M 

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


Patch Set 9: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


Patch Set 9: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Will Berkeley (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7235

to look at the new patch set (#9).

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..

[java] Replace interface-annotations with Apache Yetus annotations

Apache Yetus, like our interface-annotations module, was forked
from Hadoop's audience annotations. It does everything
interface-annotations does, using the same vocabulary, and
possibly more, so let's use it instead.

Projects with dependencies on kudu-client or kudu-spark won't
need to change anything in their poms.

This is a binary incompatible change since a jar built after
this change can't be swapped in for a jar built before it-- this
would also require swapping the interface-annotations jar on the
classpath with the appropriate Yetus jar.

I also manually checked that the generated javadocs for the
client look the same as before.

Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
---
D java/interface-annotations/pom.xml
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceAudience.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceStability.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsJDiffDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/IncludePublicAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/RootDocProcessor.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/StabilityOptions.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/package-info.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
M java/kudu-client/pom.xml
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/BatchResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Delete.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/HasFailedRpcException.java
M java/kudu-client/src/main/java/org/apache/kudu/client/IPCUtil.java
M 

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


Patch Set 8:

the should have been 'point it to the new version of kudu-client'

-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


Patch Set 8:

> The reason I said that is that the interface-annotations jar ends up packaged 
> with Impala in CDH. Maybe it's a stray, though.

Right, but when they do another build of impala and point it to the new version 
of Kudu, maven will automatically pull in yet annotations instead of the old 
interface annotations jar, so it shouldn't require a change.

> That actually seems like binary compat to me, with the compat breakage being 
> something different that I don't have a name for ("dependency switcheroo"?)

Yah, it's a somewhat pedantic definition of binary compat, which is why I don't 
think we should tie ourselves to it.

-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7235/7//COMMIT_MSG
Commit Message:

PS7, Line 14: This is a binary-incompatible change (but we aren't
: guaranteeing binary compatibility).
> > regardless of whether they are explicitly depending on the interface-anno
Man what'd I do here?


-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


Patch Set 8:

(1 comment)

> I don't see Impala depending on interface-annotations, but I may
 > have missed it.  If this _does_ break Impala, I think we should
 > rethink.  I would consider Impala's usage of the Kudu client to be
 > typical, and would be very concerned if they have to update
 > anything.

The reason I said that is that the interface-annotations jar ends up packaged 
with Impala in CDH. Maybe it's a stray, though.

http://gerrit.cloudera.org:8080/#/c/7235/7//COMMIT_MSG
Commit Message:

PS7, Line 14: Projects with dependencies on kudu-client or kudu-spark won't
: need to change anything, though if 
> My understanding is that this won't break anyone who's doing a from-source 
> regardless of whether they are explicitly depending on the 
> interface-annotations jar
Right. I was assuming people would bump their interface-annotations version, in 
which case it wouldn't be found since it won't exist anymore.

> It _will_ break people who want to swap out the kudu 1.3 jar for the new jar 
> on their classpath without swapping out the old interface jar for the new 
> yetus one
So if you swap both you're ok? That actually seems like binary compat to me, 
with the compat breakage being something different that I don't have a name for 
("dependency switcheroo"?)


-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


Patch Set 7:

> No worries. Speaking of people with interface annotations in their poms, we 
> should tell Impala about this change.

I don't see Impala depending on interface-annotations, but I may have missed 
it.  If this _does_ break Impala, I think we should rethink.  I would consider 
Impala's usage of the Kudu client to be typical, and would be very concerned if 
they have to update anything.

-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


Patch Set 7:

(1 comment)

It looks like most of the imports have been resorted, except in the 
kudu-client-tools jar.

http://gerrit.cloudera.org:8080/#/c/7235/7//COMMIT_MSG
Commit Message:

PS7, Line 14: This is a binary-incompatible change (but we aren't
: guaranteeing binary compatibility).
> No worries. Speaking of people with interface annotations in their poms, we
My understanding is that this won't break anyone who's doing a from-source 
rebuild of Kudu using the new version, regardless of whether they are 
explicitly depending on the interface-annotations jar (I'm not sure why anyone 
would do that).  It _will_ break people who want to swap out the kudu 1.3 jar 
for the new jar on their classpath without swapping out the old interface jar 
for the new yetus one.  I think that's a sufficiently weird usecase that we 
shouldn't tie ourselves to it.  I've worked at places that tried to maintain 
binary jar compat between releases, and it end up being a huge headache.


-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7235/7//COMMIT_MSG
Commit Message:

PS7, Line 14: This is a binary-incompatible change (but we aren't
: guaranteeing binary compatibility).
> Sorry to press on this, but can you be more specific/detailed? What exactly
No worries. Speaking of people with interface annotations in their poms, we 
should tell Impala about this change.


-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Will Berkeley (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7235

to look at the new patch set (#8).

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..

[java] Replace interface-annotations with Apache Yetus annotations

Apache Yetus, like our interface-annotations module, was forked
from Hadoop's audience annotations. It does everything
interface-annotations does, using the same vocabulary, and
possibly more, so let's use it instead.

Projects with dependencies on kudu-client or kudu-spark won't
need to change anything, though if for some reason the project
depends on interface-annotations directly then that will need to
be removed from the pom.

This is also a binary-incompatible change, so consumers of the
jars dependent on interface-annotations (kudu-client and
kudu-spark are the most notable) will need to recompile their
applications to work with those jars after this this change.
This will most likely happen automatically when they update the
kudu dependency versions in their poms.

I also manually checked that the generated javadocs for the
client look the same as before.

Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
---
D java/interface-annotations/pom.xml
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceAudience.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceStability.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsJDiffDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/IncludePublicAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/RootDocProcessor.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/StabilityOptions.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/package-info.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
M java/kudu-client/pom.xml
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/BatchResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Delete.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M 

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7235/7//COMMIT_MSG
Commit Message:

PS7, Line 14: This is a binary-incompatible change (but we aren't
: guaranteeing binary compatibility).
Sorry to press on this, but can you be more specific/detailed? What exactly 
breaks? If I'm your average kudu-client/kudu-spark artifact consumer, what 
happens to me? If I (for some reason) have interface-annotations in my pom, 
what happens to me?


-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7235/6//COMMIT_MSG
Commit Message:

> Could you add some notes here about the backwards compatibility implication
Done


http://gerrit.cloudera.org:8080/#/c/7235/6/java/kudu-client/pom.xml
File java/kudu-client/pom.xml:

Line 37: compile
> Isn't this the default scope? Can it be omitted?
Done


http://gerrit.cloudera.org:8080/#/c/7235/6/java/kudu-jepsen/pom.xml
File java/kudu-jepsen/pom.xml:

Line 104: compile
> Likewise.
Done


http://gerrit.cloudera.org:8080/#/c/7235/6/java/kudu-spark/pom.xml
File java/kudu-spark/pom.xml:

Line 68: compile
> And here too.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Will Berkeley (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7235

to look at the new patch set (#7).

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..

[java] Replace interface-annotations with Apache Yetus annotations

Apache Yetus, like our interface-annotations module, was forked
from Hadoop's audience annotations. It does everything
interface-annotations does, using the same vocabulary, and
possibly more, so let's use it instead.

This is a binary-incompatible change (but we aren't
guaranteeing binary compatibility).

I also manually checked that the generated javadocs for the
client look the same as before.

Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
---
D java/interface-annotations/pom.xml
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceAudience.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceStability.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsJDiffDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/IncludePublicAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/RootDocProcessor.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/StabilityOptions.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/package-info.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
M java/kudu-client/pom.xml
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/BatchResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Delete.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/HasFailedRpcException.java
M java/kudu-client/src/main/java/org/apache/kudu/client/IPCUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Insert.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneResponse.java
M 

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7235/6//COMMIT_MSG
Commit Message:

Could you add some notes here about the backwards compatibility implications? I 
think we discussed this on Slack but it would be good to capture it in the git 
commit too.


http://gerrit.cloudera.org:8080/#/c/7235/6/java/kudu-client/pom.xml
File java/kudu-client/pom.xml:

Line 37: compile
Isn't this the default scope? Can it be omitted?


http://gerrit.cloudera.org:8080/#/c/7235/6/java/kudu-jepsen/pom.xml
File java/kudu-jepsen/pom.xml:

Line 104: compile
Likewise.


http://gerrit.cloudera.org:8080/#/c/7235/6/java/kudu-spark/pom.xml
File java/kudu-spark/pom.xml:

Line 68: compile
And here too.


-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Will Berkeley (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7235

to look at the new patch set (#6).

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..

[java] Replace interface-annotations with Apache Yetus annotations

Apache Yetus, like our interface-annotations module, was forked
from Hadoop's audience annotations. It does everything
interface-annotations does, using the same vocabulary, and
possibly more, so let's use it instead.

I also manually checked that the generated javadocs for the
client look the same as before.

Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
---
D java/interface-annotations/pom.xml
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceAudience.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceStability.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsJDiffDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/IncludePublicAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/RootDocProcessor.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/StabilityOptions.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/package-info.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
M java/kudu-client/pom.xml
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/BatchResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Delete.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/HasFailedRpcException.java
M java/kudu-client/src/main/java/org/apache/kudu/client/IPCUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Insert.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsCreateTableDoneRequest.java
M 

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Will Berkeley (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7235

to look at the new patch set (#5).

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..

[java] Replace interface-annotations with Apache Yetus annotations

Apache Yetus, like our interface-annotations module, was forked
from Hadoop's audience annotations. It does everything
interface-annotations does, using the same vocabulary, and
possibly more, so let's use it instead.

I also manually checked that the generated javadocs for the
client look the same as before.

Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
---
D java/interface-annotations/pom.xml
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceAudience.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceStability.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsJDiffDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/IncludePublicAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/RootDocProcessor.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/StabilityOptions.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/package-info.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
M java/kudu-client/pom.xml
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/BatchResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Delete.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/HasFailedRpcException.java
M java/kudu-client/src/main/java/org/apache/kudu/client/IPCUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Insert.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsCreateTableDoneRequest.java
M 

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Will Berkeley (Code Review)]

Will Berkeley has uploaded a new patch set (#2).

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..

[java] Replace interface-annotations with Apache Yetus annotations

Apache Yetus, like our interface-annotations module, was forked
from Hadoop's audience annotations. It does everything
interface-annotations does, using the same vocabulary, and
possibly more, so let's use it instead.

I also manually checked that the generated javadocs for the
client look the same as before.

Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
---
D java/interface-annotations/pom.xml
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceAudience.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceStability.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsJDiffDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/IncludePublicAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/RootDocProcessor.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/StabilityOptions.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/package-info.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
M java/kudu-client/pom.xml
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/BatchResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Delete.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/HasFailedRpcException.java
M java/kudu-client/src/main/java/org/apache/kudu/client/IPCUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Insert.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsCreateTableDoneRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M 

[kudu-CR] [java] Replace interface-annotations with Apache Yetus annotations

[Will Berkeley (Code Review)]

Will Berkeley has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7235

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
..

[java] Replace interface-annotations with Apache Yetus annotations

Apache Yetus, like our interface-annotations module, was forked
from Hadoop's audience annotations. It does everything
interface-annotations does, using the same vocabulary, and
possibly more, so let's use it instead.

Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
---
D java/interface-annotations/pom.xml
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceAudience.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceStability.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsJDiffDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/IncludePublicAnnotationsStandardDoclet.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/RootDocProcessor.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/StabilityOptions.java
D 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/package-info.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
M java/kudu-client/pom.xml
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/BatchResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Delete.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/HasFailedRpcException.java
M java/kudu-client/src/main/java/org/apache/kudu/client/IPCUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Insert.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsCreateTableDoneRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M