[kudu-CR] [ranger] update description of Ranger integration related flags
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15670 ) Change subject: [ranger] update description of Ranger integration related flags .. [ranger] update description of Ranger integration related flags This patch updates the description of Ranger related flags to make it more clear how to enable Ranger integration. Change-Id: If782f022ada6606b31d720f1dba793af45e8003e Reviewed-on: http://gerrit.cloudera.org:8080/15670 Reviewed-by: Andrew Wong Tested-by: Kudu Jenkins --- M src/kudu/ranger/ranger_client.cc 1 file changed, 15 insertions(+), 12 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If782f022ada6606b31d720f1dba793af45e8003e Gerrit-Change-Number: 15670 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [ranger] update description of Ranger integration related flags
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15670 ) Change subject: [ranger] update description of Ranger integration related flags .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If782f022ada6606b31d720f1dba793af45e8003e Gerrit-Change-Number: 15670 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 Apr 2020 18:04:48 + Gerrit-HasComments: No
[kudu-CR] [ranger] update description of Ranger integration related flags
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15670 ) Change subject: [ranger] update description of Ranger integration related flags .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15670/1/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15670/1/src/kudu/ranger/ranger_client.cc@55 PS1, Line 55: , and clients > I thought that scan operations are authorized by tablet servers using authz Done http://gerrit.cloudera.org:8080/#/c/15670/1/src/kudu/ranger/ranger_client.cc@56 PS1, Line 56: path and --range > nit: I think it would be easier to read if it was written as --ranger_java_ Done -- To view, visit http://gerrit.cloudera.org:8080/15670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If782f022ada6606b31d720f1dba793af45e8003e Gerrit-Change-Number: 15670 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 Apr 2020 17:47:26 + Gerrit-HasComments: Yes
[kudu-CR] [ranger] update description of Ranger integration related flags
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15670 to look at the new patch set (#2). Change subject: [ranger] update description of Ranger integration related flags .. [ranger] update description of Ranger integration related flags This patch updates the description of Ranger related flags to make it more clear how to enable Ranger integration. Change-Id: If782f022ada6606b31d720f1dba793af45e8003e --- M src/kudu/ranger/ranger_client.cc 1 file changed, 15 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15670/2 -- To view, visit http://gerrit.cloudera.org:8080/15670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If782f022ada6606b31d720f1dba793af45e8003e Gerrit-Change-Number: 15670 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [ranger] update description of Ranger integration related flags
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15670 ) Change subject: [ranger] update description of Ranger integration related flags .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15670/1/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15670/1/src/kudu/ranger/ranger_client.cc@55 PS1, Line 55: in the master I thought that scan operations are authorized by tablet servers using authz tokens, no? Maybe, drop this piece, if so? http://gerrit.cloudera.org:8080/#/c/15670/1/src/kudu/ranger/ranger_client.cc@56 PS1, Line 56: ranger_java_path nit: I think it would be easier to read if it was written as --ranger_java_path Same of other flags mentioned in these docs. -- To view, visit http://gerrit.cloudera.org:8080/15670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If782f022ada6606b31d720f1dba793af45e8003e Gerrit-Change-Number: 15670 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 Apr 2020 16:16:10 + Gerrit-HasComments: Yes
[kudu-CR] [ranger] update description of Ranger integration related flags
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15670 Change subject: [ranger] update description of Ranger integration related flags .. [ranger] update description of Ranger integration related flags This patch updates the description of Ranger related flags to make it more clear how to enable Ranger integration. Change-Id: If782f022ada6606b31d720f1dba793af45e8003e --- M src/kudu/ranger/ranger_client.cc 1 file changed, 15 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15670/1 -- To view, visit http://gerrit.cloudera.org:8080/15670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If782f022ada6606b31d720f1dba793af45e8003e Gerrit-Change-Number: 15670 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao
