[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Marton Greber has uploaded a new patch set (#9) to the change originally created by Attila Bukor. ( http://gerrit.cloudera.org:8080/18460 ) Change subject: [thirdparty] Upgrade glog to 0.6.0 .. [thirdparty] Upgrade glog to 0.6.0 Our current glog version is 0.3.5, which is very old, and apparently broken on MacOS Monterey, as it doesn't print integers when appended to the log stream, and it can also crash the process in certain cases. Some of the glog API changed, requiring small changes in the code, and the internal API, some of which Kudu relies on (stack traces, symbolizing addresses), is now hidden, so this commit also adds a patch to change glog's CMakeLists to make the internal API visible. Some older patches that were merged upstream have been removed, and the one adding stacktrace support for aarch64 had to be modified. Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 --- M cmake_modules/FindGLog.cmake M src/kudu/common/row_operations-test.cc M src/kudu/fs/dir_util-test.cc M src/kudu/ranger/ranger_client.cc M src/kudu/server/diagnostics_log.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/util/async_logger.cc M src/kudu/util/async_logger.h M src/kudu/util/debug-util.cc M src/kudu/util/debug/trace_logging.h M src/kudu/util/flags.cc M src/kudu/util/logging-test.cc M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/logging_test_util.h M src/kudu/util/rw_mutex-test.cc M thirdparty/build-definitions.sh M thirdparty/download-thirdparty.sh D thirdparty/patches/glog-fix-symbolization.patch D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch D thirdparty/patches/glog-issue-54-dont-build-tests.patch A thirdparty/patches/glog-make-internals-visible.patch M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch M thirdparty/vars.sh 24 files changed, 117 insertions(+), 526 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/18460/9 -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 9 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Marton Greber has uploaded a new patch set (#7) to the change originally created by Attila Bukor. ( http://gerrit.cloudera.org:8080/18460 ) Change subject: [thirdparty] Upgrade glog to 0.6.0 .. [thirdparty] Upgrade glog to 0.6.0 Our current glog version is 0.3.5, which is very old, and apparently broken on MacOS Monterey, as it doesn't print integers when appended to the log stream, and it can also crash the process in certain cases. Some of the glog API changed, requiring small changes in the code, and the internal API, some of which Kudu relies on (stack traces, symbolizing addresses), is now hidden, so this commit also adds a patch to change glog's CMakeLists to make the internal API visible. Some older patches that were merged upstream have been removed, and the one adding stacktrace support for aarch64 had to be modified. Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 --- M cmake_modules/FindGLog.cmake M src/kudu/common/row_operations-test.cc M src/kudu/fs/dir_util-test.cc M src/kudu/gutil/dynamic_annotations.c M src/kudu/gutil/dynamic_annotations.h M src/kudu/ranger/ranger_client.cc M src/kudu/server/diagnostics_log.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/util/async_logger.cc M src/kudu/util/async_logger.h M src/kudu/util/debug-util.cc M src/kudu/util/debug/trace_logging.h M src/kudu/util/flags.cc M src/kudu/util/logging-test.cc M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/logging_test_util.h M src/kudu/util/minidump.cc M src/kudu/util/rw_mutex-test.cc M thirdparty/build-definitions.sh M thirdparty/download-thirdparty.sh D thirdparty/patches/glog-fix-symbolization.patch D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch D thirdparty/patches/glog-issue-54-dont-build-tests.patch A thirdparty/patches/glog-make-internals-visible.patch M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch M thirdparty/vars.sh 27 files changed, 121 insertions(+), 529 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/18460/7 -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Marton Greber has uploaded a new patch set (#4) to the change originally created by Attila Bukor. ( http://gerrit.cloudera.org:8080/18460 ) Change subject: [thirdparty] Upgrade glog to 0.6.0 .. [thirdparty] Upgrade glog to 0.6.0 Our current glog version is 0.3.5, which is very old, and apparently broken on MacOS Monterey, as it doesn't print integers when appended to the log stream, and it can also crash the process in certain cases. Some of the glog API changed, requiring small changes in the code, and the internal API, some of which Kudu relies on (stack traces, symbolizing addresses), is now hidden, so this commit also adds a patch to change glog's CMakeLists to make the internal API visible. Some older patches that were merged upstream have been removed, and the one adding stacktrace support for aarch64 had to be modified. Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 --- M cmake_modules/FindGLog.cmake M src/kudu/common/row_operations-test.cc M src/kudu/fs/dir_util-test.cc M src/kudu/ranger/ranger_client.cc M src/kudu/server/diagnostics_log.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/util/async_logger.cc M src/kudu/util/async_logger.h M src/kudu/util/debug-util.cc M src/kudu/util/debug/trace_logging.h M src/kudu/util/flags.cc M src/kudu/util/logging-test.cc M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/logging_test_util.h M src/kudu/util/rw_mutex-test.cc M thirdparty/build-definitions.sh M thirdparty/download-thirdparty.sh D thirdparty/patches/glog-fix-symbolization.patch D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch D thirdparty/patches/glog-issue-54-dont-build-tests.patch A thirdparty/patches/glog-make-internals-visible.patch M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch M thirdparty/vars.sh 24 files changed, 117 insertions(+), 526 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/18460/4 -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18460 ) Change subject: [thirdparty] Upgrade glog to 0.6.0 .. Patch Set 3: (1 comment) > Patch Set 2: > > The build is failing now with the errors as below. Is that something related > to the contaminated workspace? Did you try to build it on a Linux build > machine? > > 05:26:14 [ 6%] Running C++ protocol buffer compiler on transactions.proto > 05:26:14 > /home/jenkins-slave/workspace/kudu-master/2/build/debug/bin/protoc-gen-insertions: > error while loading shared libraries: libgflags.so.2.2: cannot open shared > object file: No such file or directory > 05:26:14 --insertions_out: protoc-gen-insertions: Plugin failed with status > code 127. > 05:26:14 > /home/jenkins-slave/workspace/kudu-master/2/build/debug/bin/protoc-gen-insertions: > error while loading shared libraries: libgflags.so.2.2: cannot open shared > object file: No such file or directory > 05:26:14 --insertions_out: protoc-gen-insertions: Plugin failed with status > code 127. > 05:26:14 src/kudu/util/CMakeFiles/kudu_util_hash_proto.dir/build.make:81: > recipe for target 'src/kudu/util/hash.pb.cc' failed > 05:26:14 make[2]: *** [src/kudu/util/hash.pb.cc] Error 1 > 05:26:14 > /home/jenkins-slave/workspace/kudu-master/2/build/debug/bin/protoc-gen-insertions: > error while loading shared libraries: libgflags.so.2.2: cannot open shared > object file: No such file or directory Yea, it seems this happens only on Jenkins, not sure why (tried to clean the workspace too). It worked fine on va1022 and on my CentOS7 box. http://gerrit.cloudera.org:8080/#/c/18460/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18460/2//COMMIT_MSG@18 PS2, Line 18: had to be modified > Do you mind explaining the reason for the modification? BTW, is it still b It seems it is, I was able to build it on Apple M1 at least. -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Mon, 02 May 2022 16:39:01 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Kudu Jenkins, Andrew Wong, Khazar Mammadli, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18460 to look at the new patch set (#3). Change subject: [thirdparty] Upgrade glog to 0.6.0 .. [thirdparty] Upgrade glog to 0.6.0 Our current glog version is 0.3.5, which is very old, and apparently broken on MacOS Monterey, as it doesn't print integers when appended to the log stream, and it can also crash the process in certain cases. Some of the glog API changed, requiring small changes in the code, and the internal API, some of which Kudu relies on (stack traces, symbolizing addresses), is now hidden, so this commit also adds a patch to change glog's CMakeLists to make the internal API visible. Some older patches that were merged upstream have been removed, and the one adding stacktrace support for aarch64 had to be modified to resolve some conflicts due to changes in some files between the two versions. Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 --- M cmake_modules/FindGLog.cmake M src/kudu/common/row_operations-test.cc M src/kudu/fs/dir_util-test.cc M src/kudu/ranger/ranger_client.cc M src/kudu/server/diagnostics_log.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/util/async_logger.cc M src/kudu/util/async_logger.h M src/kudu/util/debug-util.cc M src/kudu/util/debug/trace_logging.h M src/kudu/util/flags.cc M src/kudu/util/logging-test.cc M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/logging_test_util.h M src/kudu/util/rw_mutex-test.cc M thirdparty/build-definitions.sh M thirdparty/download-thirdparty.sh D thirdparty/patches/glog-fix-symbolization.patch D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch D thirdparty/patches/glog-issue-54-dont-build-tests.patch A thirdparty/patches/glog-make-internals-visible.patch M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch M thirdparty/vars.sh 24 files changed, 117 insertions(+), 526 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/18460/3 -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18460 ) Change subject: [thirdparty] Upgrade glog to 0.6.0 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18460/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18460/2//COMMIT_MSG@18 PS2, Line 18: had to be modified Do you mind explaining the reason for the modification? BTW, is it still buildable on aarch64 after the modification? http://gerrit.cloudera.org:8080/#/c/18460/2/thirdparty/patches/glog-make-internals-visible.patch File thirdparty/patches/glog-make-internals-visible.patch: http://gerrit.cloudera.org:8080/#/c/18460/2/thirdparty/patches/glog-make-internals-visible.patch@8 PS2, Line 8: > nit: whitespace That's a patch file, so whitespace in a must for the unified diff format here. -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 29 Apr 2022 16:49:11 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18460 ) Change subject: [thirdparty] Upgrade glog to 0.6.0 .. Patch Set 2: The build is failing now with the errors as below. Is that something related to the contaminated workspace? Did you try to build it on a Linux build machine? 05:26:14 [ 6%] Running C++ protocol buffer compiler on transactions.proto 05:26:14 /home/jenkins-slave/workspace/kudu-master/2/build/debug/bin/protoc-gen-insertions: error while loading shared libraries: libgflags.so.2.2: cannot open shared object file: No such file or directory 05:26:14 --insertions_out: protoc-gen-insertions: Plugin failed with status code 127. 05:26:14 /home/jenkins-slave/workspace/kudu-master/2/build/debug/bin/protoc-gen-insertions: error while loading shared libraries: libgflags.so.2.2: cannot open shared object file: No such file or directory 05:26:14 --insertions_out: protoc-gen-insertions: Plugin failed with status code 127. 05:26:14 src/kudu/util/CMakeFiles/kudu_util_hash_proto.dir/build.make:81: recipe for target 'src/kudu/util/hash.pb.cc' failed 05:26:14 make[2]: *** [src/kudu/util/hash.pb.cc] Error 1 05:26:14 /home/jenkins-slave/workspace/kudu-master/2/build/debug/bin/protoc-gen-insertions: error while loading shared libraries: libgflags.so.2.2: cannot open shared object file: No such file or directory -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 29 Apr 2022 16:46:30 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18460 ) Change subject: [thirdparty] Upgrade glog to 0.6.0 .. Patch Set 2: Code-Review+1 (1 comment) Thanks for this patch! Aside from the TidyBot and a few trailing whitespaces it looks good to me. I also built thirdparty and kudu locally on a 2019 MBP using macOs Monterey (12.1) successfully. Also did some simple manual tests, kudu seems to start up and function fine. http://gerrit.cloudera.org:8080/#/c/18460/2/thirdparty/patches/glog-make-internals-visible.patch File thirdparty/patches/glog-make-internals-visible.patch: http://gerrit.cloudera.org:8080/#/c/18460/2/thirdparty/patches/glog-make-internals-visible.patch@8 PS2, Line 8: nit: whitespace -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 29 Apr 2022 13:22:01 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins, Andrew Wong, Khazar Mammadli, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18460 to look at the new patch set (#2). Change subject: [thirdparty] Upgrade glog to 0.6.0 .. [thirdparty] Upgrade glog to 0.6.0 Our current glog version is 0.3.5, which is very old, and apparently broken on MacOS Monterey, as it doesn't print integers when appended to the log stream, and it can also crash the process in certain cases. Some of the glog API changed, requiring small changes in the code, and the internal API, some of which Kudu relies on (stack traces, symbolizing addresses), is now hidden, so this commit also adds a patch to change glog's CMakeLists to make the internal API visible. Some older patches that were merged upstream have been removed, and the one adding stacktrace support for aarch64 had to be modified. Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 --- M cmake_modules/FindGLog.cmake M src/kudu/common/row_operations-test.cc M src/kudu/fs/dir_util-test.cc M src/kudu/ranger/ranger_client.cc M src/kudu/server/diagnostics_log.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/util/async_logger.cc M src/kudu/util/async_logger.h M src/kudu/util/debug-util.cc M src/kudu/util/debug/trace_logging.h M src/kudu/util/flags.cc M src/kudu/util/logging-test.cc M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/logging_test_util.h M src/kudu/util/rw_mutex-test.cc M thirdparty/build-definitions.sh M thirdparty/download-thirdparty.sh D thirdparty/patches/glog-fix-symbolization.patch D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch D thirdparty/patches/glog-issue-54-dont-build-tests.patch A thirdparty/patches/glog-make-internals-visible.patch M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch M thirdparty/vars.sh 24 files changed, 117 insertions(+), 526 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/18460/2 -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Hello Zoltan Chovan, Alexey Serbin, Andrew Wong, Khazar Mammadli, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/18460 to review the following change. Change subject: [thirdparty] Upgrade glog to 0.6.0 .. [thirdparty] Upgrade glog to 0.6.0 Our current glog version is 0.3.5, which is very old, and apparently broken on MacOS Monterey, as it doesn't print integers when appended to the log stream, and it can also crash the process in certain cases. Some of the glog API changed, requiring small changes in the code, and the internal API, some of which Kudu relies on (stack traces, symbolizing addresses), is now hidden, so this commit also adds a patch to change glog's CMakeLists to make the internal API visible. Some older patches that were merged upstream have been removed, and the one adding stacktrace support for aarch64 had to be modified. Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 --- M cmake_modules/FindGLog.cmake M src/kudu/common/row_operations-test.cc M src/kudu/fs/dir_util-test.cc M src/kudu/ranger/ranger_client.cc M src/kudu/server/diagnostics_log.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/util/async_logger.cc M src/kudu/util/async_logger.h M src/kudu/util/debug-util.cc M src/kudu/util/debug/trace_logging.h M src/kudu/util/flags.cc M src/kudu/util/logging-test.cc M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/logging_test_util.h M src/kudu/util/rw_mutex-test.cc M thirdparty/build-definitions.sh M thirdparty/download-thirdparty.sh D thirdparty/patches/glog-fix-symbolization.patch D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch D thirdparty/patches/glog-issue-54-dont-build-tests.patch A thirdparty/patches/glog-make-internals-visible.patch M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch M thirdparty/vars.sh 24 files changed, 128 insertions(+), 500 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/18460/1 -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Zoltan Chovan
