[kudu-CR] KUDU-2113 SEGV because of consensus conflict and missing tablet server

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: KUDU-2113 SEGV because of consensus conflict and missing tablet 
server
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7864/2//COMMIT_MSG
Commit Message:

PS2, Line 7: SEGV
Nit: pedantry, but "SEGV" isn't really a thing. It's either a "segmentation 
fault" or "segfault" (a specific kind of illegal memory access) or a "SIGSEGV" 
(the signal delivered to the process by the kernel due to a segfault, which 
causes it to terminate abnormally).


http://gerrit.cloudera.org:8080/#/c/7864/2/src/kudu/tools/ksck.h
File src/kudu/tools/ksck.h:

PS2, Line 293:   FRIEND_TEST(KsckTest, TestMismatchedAssignments);
 :   FRIEND_TEST(KsckTest, TestConsensusConflictExtraPeer);
 :   FRIEND_TEST(KsckTest, TestConsensusConflictMissingPeer);
 :   FRIEND_TEST(KsckTest, TestConsensusConflictDifferentLeader);
 :   FRIEND_TEST(KsckTest, 
TestMasterNotReportingTabletServerWithConsensusConflict);
Nit: mind sorting this list alphabetically?


-- 
To view, visit http://gerrit.cloudera.org:8080/7864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2113 SEGV because of consensus conflict and missing tablet server

[Will Berkeley (Code Review)]

Will Berkeley has uploaded a new patch set (#2).

Change subject: KUDU-2113 SEGV because of consensus conflict and missing tablet 
server
..

KUDU-2113 SEGV because of consensus conflict and missing tablet server

Sometimes the master doesn't report all tablet servers. This can
happen, for example, when the master is starting. When this
happened and there was also a consensus conflict, it caused a
SEGV. This fixes the SEGV and contains a regression test.

Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
3 files changed, 46 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/7864/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2113 SEGV because of consensus conflict and missing tablet server

[Will Berkeley (Code Review)]

Will Berkeley has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7864

Change subject: KUDU-2113 SEGV because of consensus conflict and missing tablet 
server
..

KUDU-2113 SEGV because of consensus conflict and missing tablet server

Sometimes the master doesn't report all tablet servers. This can
happen, for example, when the master is starting. When this
happened and there was also a consensus conflict, it caused a
SEGV. This fixes the SEGV and contains a regression test.

Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
3 files changed, 45 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/7864/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley