[kudu-CR] disk failure: handle EIOs on I/O to blocks

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: disk failure: handle EIOs on I/O to blocks
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7030/3/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:

PS3, Line 628: KUDU_RETURN_OR_HANDLE_EIO
I like this version of the macro (without the second call to HandleEIO()) . 
Maybe drop the KUDU_ prefix (or add an alias)
How about:
RETURN_NOT_OK_HANDLE_EIO()


http://gerrit.cloudera.org:8080/#/c/7030/3/src/kudu/util/status.h
File src/kudu/util/status.h:

PS3, Line 104: breif
typo


-- 
To view, visit http://gerrit.cloudera.org:8080/7030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia03bfb711a1b022d7516f4adb37fe9fb28ec949c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] disk failure: handle EIOs on I/O to blocks

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: disk failure: handle EIOs on I/O to blocks
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7030/3/src/kudu/cfile/cfile_reader.cc
File src/kudu/cfile/cfile_reader.cc:

PS3, Line 184: KUDU_RETURN_OR_HANDLE(EIO, block_->Read(0, ), 
block_->HandleEIO());
don't quite follow this. if the read fails with an EIO will this continue to do 
anything? doesn't seem like it should but maybe I'm misunderstanding. also if 
the block knows how to handle EIOs why does this need to make an explicit call?

like I said in the other patch, give me a bit to come up with a suggestion.


-- 
To view, visit http://gerrit.cloudera.org:8080/7030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia03bfb711a1b022d7516f4adb37fe9fb28ec949c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] disk failure: handle EIOs on I/O to blocks

[Andrew Wong (Code Review)]

Andrew Wong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7030

Change subject: disk failure: handle EIOs on I/O to blocks
..

disk failure: handle EIOs on I/O to blocks

This patch adds the proper macros around operations that touch disk that
occur when writing or reading blocks.

Change-Id: Ia03bfb711a1b022d7516f4adb37fe9fb28ec949c
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/util/status.h
5 files changed, 45 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/7030/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia03bfb711a1b022d7516f4adb37fe9fb28ec949c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong