[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 8: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Dan Burkert has submitted this change and it was merged.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


docs: light editing on 1.5 release notes; spark security docs

Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Reviewed-on: http://gerrit.cloudera.org:8080/7914
Reviewed-by: Dan Burkert 
Tested-by: Dan Burkert 
---
M docs/developing.adoc
M docs/release_notes.adoc
2 files changed, 60 insertions(+), 35 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 8: Code-Review+2

Carrying over Alexey and Adar's +2

-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Hello Hao Hao, Andrew Wong, Adar Dembo, Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7914

to look at the new patch set (#8).

Change subject: docs: light editing on 1.5 release notes; spark security docs
..

docs: light editing on 1.5 release notes; spark security docs

Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
---
M docs/developing.adoc
M docs/release_notes.adoc
2 files changed, 60 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/7914/8
-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7914/6/docs/release_notes.adoc
File docs/release_notes.adoc:

PS6, Line 48: accepted
> nit: accepted by default?
Done


PS6, Line 140: upper case
> nit: single word
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 7: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7914/6/docs/release_notes.adoc
File docs/release_notes.adoc:

PS6, Line 48: accepted
nit: accepted by default?


PS6, Line 140: upper case
nit: single word


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7914/6/docs/release_notes.adoc
File docs/release_notes.adoc:

PS6, Line 82: 'tablet move tool'
> nit: 'tablet move' tool.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Hello Hao Hao, Andrew Wong, Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7914

to look at the new patch set (#7).

Change subject: docs: light editing on 1.5 release notes; spark security docs
..

docs: light editing on 1.5 release notes; spark security docs

Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
---
M docs/developing.adoc
M docs/release_notes.adoc
2 files changed, 59 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/7914/7
-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 6: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7914/6/docs/release_notes.adoc
File docs/release_notes.adoc:

PS6, Line 82: 'tablet move tool'
nit: 'tablet move' tool.


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 6: Code-Review+2

(1 comment)

LGTM.  You might want to get more feedback from Adar and other guys who already 
reviewed the draft.

http://gerrit.cloudera.org:8080/#/c/7914/5/docs/release_notes.adoc
File docs/release_notes.adoc:

Line 136:   details.
> I added a note about 2085.  As far as I know the rest have never been seen 
Yep, that makes sense.


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7914/5/docs/release_notes.adoc
File docs/release_notes.adoc:

PS5, Line 76: kudu` command line tool
> Does it make sense to mention about the new 'pbc edit' command?
I think we should skip that one, since it's very low level and dangerous.


Line 124: 
> Maybe, it's worth mentioning:
Done


Line 136: 
> What about adding the following:
I added a note about 2085.  As far as I know the rest have never been seen in 
the wild, so in my opinion they don't meet the bar of noteworthiness.


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Hello Andrew Wong, Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7914

to look at the new patch set (#6).

Change subject: docs: light editing on 1.5 release notes; spark security docs
..

docs: light editing on 1.5 release notes; spark security docs

Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
---
M docs/developing.adoc
M docs/release_notes.adoc
2 files changed, 59 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/7914/6
-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 5:

(4 comments)

A few other things which might worth mentioning.

http://gerrit.cloudera.org:8080/#/c/7914/3/docs/release_notes.adoc
File docs/release_notes.adoc:

PS3, Line 72: values
> Yes, I think values is correct here since there are multiple configuration 
All right, then choosing 'values' over 'settings'.


http://gerrit.cloudera.org:8080/#/c/7914/5/docs/release_notes.adoc
File docs/release_notes.adoc:

PS5, Line 76: kudu` command line tool
Does it make sense to mention about the new 'pbc edit' command?


Line 124: 
Maybe, it's worth mentioning:

* To improve security, world-readable Kerberos keytab files are no longer 
accepted.  Set --allow_world_readable_credentials=true to override that 
behavior.  See link:https://issues.apache.org/jira/browse/KUDU-1955[KUDU-1955] 
for details.


Line 136: 
What about adding the following:

* Fixed crash when seeking past end of prefix-encoded block: 
link:https://issues.apache.org/jira/browse/KUDU-2085[KUDU-2085]

* Fixed rare negotiation deadlock in the RPC subsystem: 
link:https://issues.apache.org/jira/browse/KUDU-2041[KUDU-2041]

* Fixed undefined behavior in TlsSocket::Writev(): 
link:https://issues.apache.org/jira/browse/KUDU-2004[KUDU-2004]

* Fixed potential race in the Java client: 
link:https://issues.apache.org/jira/browse/KUDU-1944[KUDU-1944]


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Hello Andrew Wong, Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7914

to look at the new patch set (#5).

Change subject: docs: light editing on 1.5 release notes; spark security docs
..

docs: light editing on 1.5 release notes; spark security docs

Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
---
M docs/developing.adoc
M docs/release_notes.adoc
2 files changed, 48 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/7914/5
-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7914/3/docs/release_notes.adoc
File docs/release_notes.adoc:

PS3, Line 72: values
> nit: it's still 'values', but if you think that's better wording, I'm fine 
Yes, I think values is correct here since there are multiple configuration 
options exposed.


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 3: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7914/3/docs/release_notes.adoc
File docs/release_notes.adoc:

PS3, Line 72: values
nit: it's still 'values', but if you think that's better wording, I'm fine with 
that since I'm not a native English speaker :)


Line 132: 
Probably, that's out of the intended scope of this review item, but are you 
going to add mention on fixed issues like KUDU-2032, KUDU-1942, and KUDU-2085?


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7914/2/docs/release_notes.adoc
File docs/release_notes.adoc:

PS2, Line 92: Kudu 1.5's log block manager now performs disk synchronization in 
batches.
> consider:
Done


PS2, Line 97: feature
> nit: does it make sense to mention that the feature is still in 'experiment
I don't think so in this case, since the feature itself is not really 
experimental (it's enabled by default), only the flag is.


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 2:

(2 comments)

Just a couple of other nits; sorry that I missed those in the previous pass.  
Feel free to ignore, though.

http://gerrit.cloudera.org:8080/#/c/7914/2/docs/release_notes.adoc
File docs/release_notes.adoc:

PS2, Line 92: Kudu 1.5's log block manager now performs disk synchronization in 
batches.
consider:

'Starting Kudu 1.5, the log block manager performs disk synchronization in 
batches.'

or

'The log block manager now performs disk synchronization in batches.'


PS2, Line 97: feature
nit: does it make sense to mention that the feature is still in 'experimental' 
phase?

Like 'A new experimental feature referred as ...'


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7914

to look at the new patch set (#3).

Change subject: docs: light editing on 1.5 release notes; spark security docs
..

docs: light editing on 1.5 release notes; spark security docs

Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
---
M docs/developing.adoc
M docs/release_notes.adoc
2 files changed, 43 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/7914/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 2:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/7914/1/docs/release_notes.adoc
File docs/release_notes.adoc:

PS1, Line 72: a 
> remove
Done


PS1, Line 97: was 
> nit: is
Done


PS1, Line 113: Tablet Server
> nit: it seems, at least in this doc, that we're standardizing to lower-case
Done


PS1, Line 119: Tablet Server
> same here?
Done


PS1, Line 139: * Kudu 1.0 clients may connect to servers running Kudu 1.5 with 
the exception of the
 :   below-mentioned restrictions regarding secure clusters.
> nit: maybe move one down so "below-mentioned" refers to the blob immediatel
Done


http://gerrit.cloudera.org:8080/#/c/7914/2/docs/release_notes.adoc
File docs/release_notes.adoc:

PS2, Line 64: beteween
> between
Done


PS2, Line 72: values
> nit: maybe replace with one of parameters/properties/settings?
Done


PS2, Line 84: functionality
> functionalities
I think both are correct, functionality can cover many items in American 
english.


PS2, Line 124: * The Java Kudu client now automatically requests new 
authentication tokens
 :   after expiration. So, long-lived Java clients are now 
supported. See
 :   
link:https://issues.apache.org/jira/browse/KUDU-2013[KUDU-2013] for more
 :   details.
> Should this be moved under the 'Fixed Issues' instead?
Yah good catch.


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7914/2/docs/release_notes.adoc
File docs/release_notes.adoc:

PS2, Line 124: * The Java Kudu client now automatically requests new 
authentication tokens
 :   after expiration. So, long-lived Java clients are now 
supported. See
 :   
link:https://issues.apache.org/jira/browse/KUDU-2013[KUDU-2013] for more
 :   details.
Should this be moved under the 'Fixed Issues' instead?


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7914/2/docs/release_notes.adoc
File docs/release_notes.adoc:

PS2, Line 76: tablet move tool
'tablet move' tool


PS2, Line 79: local replica data size
'local_replica_data_size'


PS2, Line 84: functionality
functionalities


PS2, Line 88: functionality
functionalities


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7914/2/docs/release_notes.adoc
File docs/release_notes.adoc:

PS2, Line 64: beteween
between


PS2, Line 72: values
nit: maybe replace with one of parameters/properties/settings?


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
..


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7914/1/docs/release_notes.adoc
File docs/release_notes.adoc:

PS1, Line 72: a 
remove


PS1, Line 97: was 
nit: is


PS1, Line 113: Tablet Server
nit: it seems, at least in this doc, that we're standardizing to lower-cased 
component names?


PS1, Line 119: Tablet Server
same here?


PS1, Line 139: * Kudu 1.0 clients may connect to servers running Kudu 1.5 with 
the exception of the
 :   below-mentioned restrictions regarding secure clusters.
nit: maybe move one down so "below-mentioned" refers to the blob immediately 
below it?


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

[Dan Burkert (Code Review)]

Dan Burkert has uploaded a new patch set (#2).

Change subject: docs: light editing on 1.5 release notes; spark security docs
..

docs: light editing on 1.5 release notes; spark security docs

Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
---
M docs/developing.adoc
M docs/release_notes.adoc
2 files changed, 31 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/7914/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins