[kudu-CR] jwt: expose MiniOidc to Kudu test binary
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18474 ) Change subject: jwt: expose MiniOidc to Kudu test binary .. jwt: expose MiniOidc to Kudu test binary Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Reviewed-on: http://gerrit.cloudera.org:8080/18474 Reviewed-by: Wenzhe Zhou Tested-by: Alexey Serbin Reviewed-by: Alexey Serbin --- M src/kudu/tools/tool.proto 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: Wenzhe Zhou: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] jwt: expose MiniOidc to Kudu test binary
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18474 ) Change subject: jwt: expose MiniOidc to Kudu test binary .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 10 Feb 2023 01:57:03 + Gerrit-HasComments: No
[kudu-CR] jwt: expose MiniOidc to Kudu test binary
Alexey Serbin has removed a vote on this change. Change subject: jwt: expose MiniOidc to Kudu test binary .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] jwt: expose MiniOidc to Kudu test binary
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18474 ) Change subject: jwt: expose MiniOidc to Kudu test binary .. Patch Set 7: Verified+1 (1 comment) unrelated test failure in CatalogManagerTskITest.LeadershipChangeOnTskGeneration http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@559 PS6, Line 559: is_valid_ > good to me. +1 -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 10 Feb 2023 01:56:58 + Gerrit-HasComments: Yes
[kudu-CR] jwt: expose MiniOidc to Kudu test binary
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18474 ) Change subject: jwt: expose MiniOidc to Kudu test binary .. Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@559 PS6, Line 559: is_valid_ > This determines if the returned token will be valid or not. This is control good to me. -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 09 Feb 2023 18:59:15 + Gerrit-HasComments: Yes
[kudu-CR] jwt: expose MiniOidc to Kudu test binary
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18474 ) Change subject: jwt: expose MiniOidc to Kudu test binary .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@75 PS6, Line 75: invalid_key > +1 Done http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@559 PS6, Line 559: valid_key > Maybe, keep this consistent with naming of other boolean fields in the file This determines if the returned token will be valid or not. This is controlled by placing the id of a valid or an invalid key into the token. So the returned value will still be a token. I think changing it to is_valid_key works the best. But it also could be simply is_valid I guess. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 09 Feb 2023 15:26:50 + Gerrit-HasComments: Yes
[kudu-CR] jwt: expose MiniOidc to Kudu test binary
Zoltan Chovan has uploaded a new patch set (#7) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18474 ) Change subject: jwt: expose MiniOidc to Kudu test binary .. jwt: expose MiniOidc to Kudu test binary Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 --- M src/kudu/tools/tool.proto 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18474/7 -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] jwt: expose MiniOidc to Kudu test binary
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18474 ) Change subject: jwt: expose MiniOidc to Kudu test binary .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@75 PS6, Line 75: invalid_key > It's better to keep consistent with CreateJwtPB to name it as valid_key? +1 Also, please follow the naming convention used in this file for other boolean fields: that should be something like 'is_xxx' http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@559 PS6, Line 559: valid_key > It's better to rename as valid_key_id Maybe, keep this consistent with naming of other boolean fields in the file and name this 'is_valid_key_id' or 'is_key_id_valid'? -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Tue, 07 Feb 2023 03:46:43 + Gerrit-HasComments: Yes
[kudu-CR] jwt: expose MiniOidc to Kudu test binary
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18474 ) Change subject: jwt: expose MiniOidc to Kudu test binary .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@75 PS6, Line 75: invalid_key It's better to keep consistent with CreateJwtPB to name it as valid_key? http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@559 PS6, Line 559: valid_key It's better to rename as valid_key_id -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Mon, 06 Feb 2023 22:03:17 + Gerrit-HasComments: Yes
[kudu-CR] jwt: expose MiniOidc to Kudu test binary
Zoltan Chovan has uploaded a new patch set (#5) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18474 ) Change subject: jwt: expose MiniOidc to Kudu test binary .. jwt: expose MiniOidc to Kudu test binary Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 --- M src/kudu/tools/tool.proto 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18474/5 -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] jwt: expose MiniOidc to Kudu test binary
Zoltan Chovan has uploaded a new patch set (#4) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18474 ) Change subject: jwt: expose MiniOidc to Kudu test binary .. jwt: expose MiniOidc to Kudu test binary Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 --- M src/kudu/tools/tool.proto 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18474/4 -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] jwt: expose MiniOidc to Kudu test binary
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18474 Change subject: jwt: expose MiniOidc to Kudu test binary .. jwt: expose MiniOidc to Kudu test binary Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 --- M src/kudu/tools/tool.proto 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18474/1 -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
