[kudu-CR] thirdparty: use ninja when possible
Todd Lipcon has submitted this change and it was merged. Change subject: thirdparty: use ninja when possible .. thirdparty: use ninja when possible Using ninja to build LLVM, etc, is a bit faster than using make, and produces less ugly output. Change-Id: Idacd6d8bc9ad371c3c925f7c628ad69785bb870e Reviewed-on: http://gerrit.cloudera.org:8080/7461 Reviewed-by: Adar DemboReviewed-by: Dan Burkert Tested-by: Kudu Jenkins --- M thirdparty/build-definitions.sh M thirdparty/build-thirdparty.sh 2 files changed, 28 insertions(+), 6 deletions(-) Approvals: Dan Burkert: Looks good to me, but someone else must approve Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idacd6d8bc9ad371c3c925f7c628ad69785bb870e Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] thirdparty: use ninja when possible
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7461 to look at the new patch set (#2). Change subject: thirdparty: use ninja when possible .. thirdparty: use ninja when possible Using ninja to build LLVM, etc, is a bit faster than using make, and produces less ugly output. Change-Id: Idacd6d8bc9ad371c3c925f7c628ad69785bb870e --- M thirdparty/build-definitions.sh M thirdparty/build-thirdparty.sh 2 files changed, 28 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/7461/2 -- To view, visit http://gerrit.cloudera.org:8080/7461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idacd6d8bc9ad371c3c925f7c628ad69785bb870e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] thirdparty: use ninja when possible
Todd Lipcon has posted comments on this change. Change subject: thirdparty: use ninja when possible .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7461/1//COMMIT_MSG Commit Message: PS1, Line 10: less ugly output. > What's the difference here? And is it still less ugly when outputting to so yea, with parallel builds, it buffers output in such a way that avoids interleaving http://gerrit.cloudera.org:8080/#/c/7461/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 54: # If ninja is on the path, use that instead of make for a slightly > Would prefer if this happened in build-thirdparty.sh; this file only defin Done Line 56: if which ninja > /dev/null ; then > RHEL installs ninja as ninja-build, perhaps you should add a case for that. Done Line 97: build_cmake() { > What about here? If it can't work, add a comment explaining why? Done -- To view, visit http://gerrit.cloudera.org:8080/7461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idacd6d8bc9ad371c3c925f7c628ad69785bb870e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] thirdparty: use ninja when possible
Dan Burkert has posted comments on this change. Change subject: thirdparty: use ninja when possible .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7461/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 56: if which ninja > /dev/null ; then RHEL installs ninja as ninja-build, perhaps you should add a case for that. -- To view, visit http://gerrit.cloudera.org:8080/7461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idacd6d8bc9ad371c3c925f7c628ad69785bb870e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] thirdparty: use ninja when possible
Adar Dembo has posted comments on this change. Change subject: thirdparty: use ninja when possible .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7461/1//COMMIT_MSG Commit Message: PS1, Line 10: less ugly output. What's the difference here? And is it still less ugly when outputting to something that's not a real terminal? http://gerrit.cloudera.org:8080/#/c/7461/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 54: # If ninja is on the path, use that instead of make for a slightly Would prefer if this happened in build-thirdparty.sh; this file only defines functions, it doesn't actually run anything when sourced. Line 97: build_cmake() { What about here? If it can't work, add a comment explaining why? -- To view, visit http://gerrit.cloudera.org:8080/7461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idacd6d8bc9ad371c3c925f7c628ad69785bb870e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] thirdparty: use ninja when possible
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7461 to review the following change. Change subject: thirdparty: use ninja when possible .. thirdparty: use ninja when possible Using ninja to build LLVM, etc, is a bit faster than using make, and produces less ugly output. Change-Id: Idacd6d8bc9ad371c3c925f7c628ad69785bb870e --- M thirdparty/build-definitions.sh 1 file changed, 23 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/7461/1 -- To view, visit http://gerrit.cloudera.org:8080/7461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idacd6d8bc9ad371c3c925f7c628ad69785bb870e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert