Re: Review Request 38011: Maintenance Primitives: Use the parse> helper instead of a plural MachineID protobuf.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/#review99190
---



src/common/protobuf_utils.hpp (line 115)


This should also be removed.


- Guangya Liu


On 九月 15, 2015, 5:47 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38011/
> ---
> 
> (Updated 九月 15, 2015, 5:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem 
> Harutyunyan, Joris Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This removes the MachineIDs protobuf and changes it to instead use the 
> RepeatedFieldPtr.
> This also changes the maintenance primitives (alpha) API for /machine/up and 
> /machine/down, which both take an array instead of an object now.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   include/mesos/v1/mesos.proto bcce340777f037053e1eab2d75c351e53420b9da 
>   src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0 
>   src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c 
>   src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71 
>   src/tests/master_maintenance_tests.cpp 
> 44785057f129a3e6a69f399f7d6db59d9d5c2e91 
>   src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955 
> 
> Diff: https://reviews.apache.org/r/38011/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review99188
---


Patch looks great!

Reviews applied: [37273, 37275]

All tests passed.

- Mesos ReviewBot


On Sept. 16, 2015, 3:51 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Sept. 16, 2015, 3:51 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> # Build steps:
> cmake ..  -DREBUNDLED=FALSE
> make
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

[Alexander Rojas]

> On Sept. 10, 2015, 1:46 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp, lines 
> > 96-97
> > 
> >
> > `s/std::make_pair(key, value)/{key, value}/`

I wasn't sure if we are allowing initializer lists constructors. Some people 
have complained about them in my reviews. Can you clarify? I for myself am all 
in.


> On Sept. 10, 2015, 1:46 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp, lines 
> > 107-117
> > 
> >
> > Can we just `auto` all of this away?
> > 
> > ```
> > auto range =
> >   std::unordered_multimap::equal_range(key);
> > for (auto it = range.first; it != range.second; ++it) {
> >   values.push_back(it->second);
> > }
> > ```

Same here, I have gotten complains about using auto. Are we allowed to use it, 
if so in which cases?


> On Sept. 10, 2015, 1:46 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp, lines 34-37
> > 
> >
> > Can I ask why we want these? Presumably the purpose of these classes 
> > are to eliminate the need for their `std::` counterparts.
> > 
> > If we look at a class like `Set`, it inherits from `std::set` but 
> > doesn't construct off of `std::set`. Similarly, `hashmap` inherits from 
> > `std::unordered_map`, but doesn't construct off of `std::unordered_map`.

I have no strong feelings about removing them. But if you check `hashset` it 
has a constructor from a `set` just like this one, so I am just trying to keep 
up with their signatures. I did find weird to have a constructor from `set` to 
`hashset` though. I'll drop this and if you think I really ought to remove it, 
please reopen.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37714/#review98293
---


On Sept. 16, 2015, 8:14 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37714/
> ---
> 
> (Updated Sept. 16, 2015, 8:14 a.m.)
> 
> 
> Review request for mesos, Joerg Schad, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-2924
> https://issues.apache.org/jira/browse/MESOS-2924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds extra template parameters to `multihashmap` which offer control over the 
> hash function to use as well as the equality operator.
> 
> Implements initializer_list, copy and move constructors for both, 
> `multihashmap` and `Multimap` in a similar way as it was done for `hashmap` 
> and `hashset`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
> d9e4031cee64e48ad50541c04ca11e7861d0a17c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp 
> fb3e7a1d0377001389980302342813217f49cf5f 
>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 
> 535cd2d10e3074c86c149ce85b205e73ca42ddd3 
> 
> Diff: https://reviews.apache.org/r/37714/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37714/
---

(Updated Sept. 16, 2015, 8:14 a.m.)


Review request for mesos, Joerg Schad, Michael Park, and Jan Schlicht.


Changes
---

Addresses Mpark and Till's comments.


Bugs: MESOS-2924
https://issues.apache.org/jira/browse/MESOS-2924


Repository: mesos


Description
---

Adds extra template parameters to `multihashmap` which offer control over the 
hash function to use as well as the equality operator.

Implements initializer_list, copy and move constructors for both, 
`multihashmap` and `Multimap` in a similar way as it was done for `hashmap` and 
`hashset`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
d9e4031cee64e48ad50541c04ca11e7861d0a17c 
  3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp 
fb3e7a1d0377001389980302342813217f49cf5f 
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 
535cd2d10e3074c86c149ce85b205e73ca42ddd3 

Diff: https://reviews.apache.org/r/37714/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38417: Unified the implementations of image provisioners.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38417/#review99181
---

Ship it!


Ship It!

- Timothy Chen


On Sept. 16, 2015, 1:28 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38417/
> ---
> 
> (Updated Sept. 16, 2015, 1:28 a.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified the implementations of image provisioners. See ticket for motivation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 509256f40ecc1ff5b3a5ce2b380facd153137a18 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 6cfe9fa2971d50f545587b57721f75a981f6d5ed 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> dbdbf8722d088ef671b705c0c42191d0f9e05be9 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1b83a8725b35435531038e37188b4c97189cef03 
>   src/slave/containerizer/provisioner/appc/provisioner.hpp 
> 764b119edf670a44cff4719a2301b1baac88c78a 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> c4ce4b90d71791c7fd558221cb2526b1ff245d3b 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> 33f692c9b7780bdde96fddd8b07a2f4eb3452471 
>   src/slave/containerizer/provisioner/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/containerizer/provisioner/provisioner.hpp 
> 9e0e0b8ef290a31b67bd2415253408e811e1c720 
>   src/slave/containerizer/provisioner/provisioner.cpp 
> 2ac9008243b0dc2ba6051e75c508d183068cebcb 
>   src/slave/containerizer/provisioner/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/store.cpp PRE-CREATION 
>   src/slave/flags.hpp 799c963806fadee814bac4b9bded679b0ebbbe9c 
>   src/slave/flags.cpp ff167ecd6ef224b061b37bbd3dbb4573448f8de2 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> ffa371fab69ce5eebe3b02afc2a1724a0f52110f 
>   src/tests/containerizer/provisioner.hpp 
> a26b8138d8cc3086058b15a797dd15354a84019f 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 8fee7ace4d8207796a5d3fb6d52fc25d002b783d 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38417/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38124: Add V1 Support for QuiesceOffers

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/
---

(Updated 九月 16, 2015, 6:01 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

Add V1 Support for QuiesceOffers


Diffs (updated)
-

  include/mesos/v1/scheduler/scheduler.proto 
0118b46afca8a5adecb0e65981dd44bb98333bab 
  src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
  src/master/validation.cpp f97eba650f91e975859c2bbf0614ee5d39cf035e 
  src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 

Diff: https://reviews.apache.org/r/38124/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated 九月 16, 2015, 5:51 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs (updated)
-

  include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
  include/mesos/scheduler/scheduler.proto 
19f548dba4b5d72fca8e692c5f15796feca17106 
  src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
  src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
  src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 38119: Add metrics of messages_quiesce_offers

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38119/
---

(Updated 九月 16, 2015, 5:50 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

Add metrics of messages_quiesce_offers


Diffs (updated)
-

  src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
  src/master/metrics.hpp 2d07a16f2dc6811973c82259c3cccff07401b542 
  src/master/metrics.cpp d79206f08181c99641bef697be57b5d57b627285 
  src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b 
  src/tests/metrics_tests.cpp 3e9d7c2eadfcdd2522d65e4a55dc76808ba39159 

Diff: https://reviews.apache.org/r/38119/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 37873: Add quiesce logic in allocator

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/
---

(Updated 九月 16, 2015, 5:50 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

Add quiesce logic in allocator


Diffs (updated)
-

  include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea 
  src/master/allocator/mesos/allocator.hpp 
171548b2017a0b97124f052c21345668e274d117 
  src/master/allocator/mesos/hierarchical.hpp 
3374d63b8311cf10b3108f56b7b167c12a9d7a37 
  src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
  src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 

Diff: https://reviews.apache.org/r/37873/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 38120: Add Java Support for QuiesceOffers

[Guangya Liu]

> On 九月 15, 2015, 7:12 p.m., Vinod Kone wrote:
> >
> 
> Vinod Kone wrote:
> can you also update the java test framework to test this call?

I see that the reviveOffers also do not have a example, I want to handle those 
two APIs together in another patch, make sense? Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38120/#review99071
---


On 九月 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38120/
> ---
> 
> (Updated 九月 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add Java Support for QuiesceOffers
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> a89ebed00f93801fc5bfb18e947f7120ef77d095 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
> b9b2ea8734bb910c543708dd8adcdac45e03c34b 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> 183eec898553ed25149c58d2c1f85cf6579d5660 
> 
> Diff: https://reviews.apache.org/r/38120/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38121: Add Python Support for QuiesceOffers

[Guangya Liu]

> On 九月 15, 2015, 7:14 p.m., Vinod Kone wrote:
> > Update the python test framework to send this call.

I see that the reviveOffers also do not have a test and I want to handle those 
two APIs in another patch, make sense? Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38121/#review99073
---


On 九月 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38121/
> ---
> 
> (Updated 九月 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add Python Support for QuiesceOffers
> 
> 
> Diffs
> -
> 
>   src/python/interface/src/mesos/interface/__init__.py 
> 686abb24d88765d7ec7cab5b76b57299339b7b00 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
> b1ad8e529806a047480e8d7affe4e7ecdc7d9725 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
> 609dfa3735f19eea2242dfb82ed3a4af3a0b8b9b 
> 
> Diff: https://reviews.apache.org/r/38121/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38120: Add Java Support for QuiesceOffers

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38120/
---

(Updated 九月 16, 2015, 5:50 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

Add Java Support for QuiesceOffers


Diffs (updated)
-

  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
a89ebed00f93801fc5bfb18e947f7120ef77d095 
  src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
b9b2ea8734bb910c543708dd8adcdac45e03c34b 
  src/java/src/org/apache/mesos/SchedulerDriver.java 
183eec898553ed25149c58d2c1f85cf6579d5660 

Diff: https://reviews.apache.org/r/38120/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 38121: Add Python Support for QuiesceOffers

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38121/
---

(Updated 九月 16, 2015, 5:49 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

Add Python Support for QuiesceOffers


Diffs (updated)
-

  src/python/interface/src/mesos/interface/__init__.py 
686abb24d88765d7ec7cab5b76b57299339b7b00 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
b1ad8e529806a047480e8d7affe4e7ecdc7d9725 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
609dfa3735f19eea2242dfb82ed3a4af3a0b8b9b 

Diff: https://reviews.apache.org/r/38121/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 38124: Add V1 Support for QuiesceOffers

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/
---

(Updated 九月 16, 2015, 5:49 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

Add V1 Support for QuiesceOffers


Diffs (updated)
-

  include/mesos/v1/scheduler/scheduler.proto 
0118b46afca8a5adecb0e65981dd44bb98333bab 
  src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
  src/master/validation.cpp f97eba650f91e975859c2bbf0614ee5d39cf035e 
  src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 

Diff: https://reviews.apache.org/r/38124/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 38126: Add UT for QuiesceOffers

[Guangya Liu]

> On 九月 15, 2015, 7:43 p.m., Vinod Kone wrote:
> > you should've merged this test review with the dependent review. i really 
> > like tests to be present in the same patch as the code change, to give me 
> > confidence that the code changes are correct.
> > 
> > also, no tests for the scheduler driver?

This is now merged to https://reviews.apache.org/r/38124/diff/2/ 

I'm now working on another patch to add some tests for schduler driver. I see 
that the reviveOffers also do not have a test, will try to see if the test can 
cover both cases: revive and quiesce offer.


> On 九月 15, 2015, 7:43 p.m., Vinod Kone wrote:
> > src/tests/scheduler_tests.cpp, lines 1004-1005
> > 
> >
> > // On revival scheduler should get another offer with the same amount 
> > of resources.
> > 
> > also, i'm a bit confused on how/why the scheduler gets another offer 
> > (for the same resources) considering the framework is holding on to the 
> > original offer?

I updated the logic a bit, the sequence is as this: subscribe->get 
offer->decline offer with a filter of 60min->enable quiesce offer-> wait 
100min, no offer->revive the offer->get offer, please refer to 
https://reviews.apache.org/r/38124/diff/2/ for detail. Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38126/#review99078
---


On 九月 16, 2015, 5:44 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38126/
> ---
> 
> (Updated 九月 16, 2015, 5:44 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add UT for QuiesceOffers
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
> 
> Diff: https://reviews.apache.org/r/38126/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38126: Add UT for QuiesceOffers

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38126/
---

(Updated 九月 16, 2015, 5:44 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

Add UT for QuiesceOffers


Diffs
-

  src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 

Diff: https://reviews.apache.org/r/38126/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38416/#review99171
---


Patch looks great!

Reviews applied: [38416]

All tests passed.

- Mesos ReviewBot


On Sept. 16, 2015, 1:03 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38416/
> ---
> 
> (Updated Sept. 16, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, Jojy Varghese, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-3429
> https://issues.apache.org/jira/browse/MESOS-3429
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow HTTP response codes to be checked with code.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> fbd6cf7967173495875a8ea90ed28ade88b982a2 
> 
> Diff: https://reviews.apache.org/r/38416/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

[Timothy Chen]

> On Sept. 16, 2015, 1:43 a.m., Guangya Liu wrote:
> >

it looks like the structs are ordered by response code, so just moving this to 
the right place assuming so


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38416/#review99147
---


On Sept. 16, 2015, 1:03 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38416/
> ---
> 
> (Updated Sept. 16, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, Jojy Varghese, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-3429
> https://issues.apache.org/jira/browse/MESOS-3429
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow HTTP response codes to be checked with code.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> fbd6cf7967173495875a8ea90ed28ade88b982a2 
> 
> Diff: https://reviews.apache.org/r/38416/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 38417: Unified the implementations of image provisioners.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38417/#review99163
---


Patch looks great!

Reviews applied: [38407, 38408, 38417]

All tests passed.

- Mesos ReviewBot


On Sept. 16, 2015, 1:28 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38417/
> ---
> 
> (Updated Sept. 16, 2015, 1:28 a.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified the implementations of image provisioners. See ticket for motivation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 509256f40ecc1ff5b3a5ce2b380facd153137a18 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 6cfe9fa2971d50f545587b57721f75a981f6d5ed 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> dbdbf8722d088ef671b705c0c42191d0f9e05be9 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1b83a8725b35435531038e37188b4c97189cef03 
>   src/slave/containerizer/provisioner/appc/provisioner.hpp 
> 764b119edf670a44cff4719a2301b1baac88c78a 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> c4ce4b90d71791c7fd558221cb2526b1ff245d3b 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> 33f692c9b7780bdde96fddd8b07a2f4eb3452471 
>   src/slave/containerizer/provisioner/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/containerizer/provisioner/provisioner.hpp 
> 9e0e0b8ef290a31b67bd2415253408e811e1c720 
>   src/slave/containerizer/provisioner/provisioner.cpp 
> 2ac9008243b0dc2ba6051e75c508d183068cebcb 
>   src/slave/containerizer/provisioner/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/store.cpp PRE-CREATION 
>   src/slave/flags.hpp 799c963806fadee814bac4b9bded679b0ebbbe9c 
>   src/slave/flags.cpp ff167ecd6ef224b061b37bbd3dbb4573448f8de2 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> ffa371fab69ce5eebe3b02afc2a1724a0f52110f 
>   src/tests/containerizer/provisioner.hpp 
> a26b8138d8cc3086058b15a797dd15354a84019f 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 8fee7ace4d8207796a5d3fb6d52fc25d002b783d 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38417/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Sept. 16, 2015, 3:51 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing (updated)
---

# Build steps:
cmake ..  -DREBUNDLED=FALSE
make


Thanks,

haosdent huang

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/
---

(Updated Sept. 16, 2015, 3:50 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Add CMake macro VsBuildCommand in libprocess.


Diffs
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
d13ba666740b4f2e382a0b1852724cfd519f8f64 
  3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/37273/diff/


Testing (updated)
---

# Build steps:
cmake ..  -DREBUNDLED=FALSE
make


Thanks,

haosdent huang

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/
---

(Updated Sept. 16, 2015, 2:55 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Changes
---

Use CMAKE_BUILD_TYPE as build params and make it pass in Windows 7 +  Visual 
Studio 2015


Repository: mesos


Description
---

Add CMake macro VsBuildCommand in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
d13ba666740b4f2e382a0b1852724cfd519f8f64 
  3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/37273/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Sept. 16, 2015, 2:55 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Changes
---

Use CMAKE_BUILD_TYPE as build params and make it pass in Windows 7 +  Visual 
Studio 2015


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs (updated)
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review99156
---


Patch looks great!

Reviews applied: [38278, 38143]

All tests passed.

- Mesos ReviewBot


On Sept. 15, 2015, 10:46 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> ---
> 
> (Updated Sept. 15, 2015, 10:46 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
> https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
> added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
> ought to be changed as the executor HTTP API design evolves.
> Note: This proto is a copy from the existing unversioned executor proto with 
> only the necessary changes.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 509256f 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review99153
---

Ship it!


Ship It!

- Yong Qiao Wang


On Sept. 15, 2015, 11 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Sept. 15, 2015, 11 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 19f548dba4b5d72fca8e692c5f15796feca17106 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
>   src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37873: Add quiesce logic in allocator

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review99152
---

Ship it!


Ship It!

- Yong Qiao Wang


On Sept. 6, 2015, 2:40 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> ---
> 
> (Updated Sept. 6, 2015, 2:40 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add quiesce logic in allocator
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp 
> aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp 
> cb4020dea897ef198cd9898cabecf61edfade834 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569 
> 
> Diff: https://reviews.apache.org/r/37873/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/
---

(Updated Sept. 16, 2015, 2:15 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Changes
---

Update according @Joseph Wu reviews.


Repository: mesos


Description
---

Add CMake macro VsBuildCommand in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
d13ba666740b4f2e382a0b1852724cfd519f8f64 
  3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/37273/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

[haosdent huang]

> On Sept. 15, 2015, 11:12 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, lines 223-225
> > 
> >
> > Just curious, why aren't you using the protobuf-2.5.0 tarball that's 
> > included in the mesos source?
> > 
> > I can imagine that you could use the included tarball for everything 
> > other than glog (which requires 0.3.4+).
> > 
> > See:
> > https://github.com/apache/mesos/tree/master/3rdparty/libprocess/3rdparty

Oh, this one contains the patch that could compiled upder vs 2015.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/#review99115
---


On Sept. 15, 2015, 6:42 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37273/
> ---
> 
> (Updated Sept. 15, 2015, 6:42 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add CMake macro VsBuildCommand in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> d13ba666740b4f2e382a0b1852724cfd519f8f64 
>   3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37273/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/
---

(Updated Sept. 15, 2015, 10:05 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.


Changes
---

rebased


Bugs: MESOS-3013
https://issues.apache.org/jira/browse/MESOS-3013


Repository: mesos


Description
---

This allows the frameworks to specify an intent to enable ip-per-container. The
IP information is supplied back to the framework as well as state.json endpoints
by including NetworkInfo inside TaskStatus.


Diffs (updated)
-

  include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
  src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 
  src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 
  src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842 
  src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b 
  src/tests/slave_tests.cpp 447c43c96ce0c043e37319bb213723ed33820f8a 

Diff: https://reviews.apache.org/r/38367/diff/


Testing
---

Added new tests and ran make check.


Thanks,

Kapil Arya

Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/
---

(Updated Sept. 15, 2015, 10:05 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.


Changes
---

rebased


Bugs: MESOS-3013
https://issues.apache.org/jira/browse/MESOS-3013


Repository: mesos


Description
---

This allows the hook to not only update TaskStatus::labels, but also
TaskStatus::container_status.

Enhanced example hook module and relevant test to reflect the change.


Diffs (updated)
-

  include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
  src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
  src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
  src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
  src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842 
  src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
  src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 

Diff: https://reviews.apache.org/r/38368/diff/


Testing
---

make check.


Thanks,

Kapil Arya

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38370/#review99149
---


Bad patch!

Reviews applied: [38363, 38364, 38365]

Failed command: ./support/apply-review.sh -n -r 38365

Error:
 2015-09-16 01:57:34 URL:https://reviews.apache.org/r/38365/diff/raw/ 
[16233/16233] -> "38365.patch" [1]
error: patch failed: src/slave/containerizer/isolators/filesystem/linux.cpp:243
error: src/slave/containerizer/isolators/filesystem/linux.cpp: patch does not 
apply
Failed to apply patch

- Mesos ReviewBot


On Sept. 15, 2015, 9:11 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38370/
> ---
> 
> (Updated Sept. 15, 2015, 9:11 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker executor to set container IP in TaskStatus::NetworkInfo.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a628922cc49b1dc8a37621a6a8b7ef6842cfb051 
> 
> Diff: https://reviews.apache.org/r/38370/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38416/#review99147
---



3rdparty/libprocess/include/process/http.hpp (lines 559 - 584)


Just curious why the order of the response are changed?


- Guangya Liu


On 九月 16, 2015, 1:03 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38416/
> ---
> 
> (Updated 九月 16, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, Jojy Varghese, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-3429
> https://issues.apache.org/jira/browse/MESOS-3429
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow HTTP response codes to be checked with code.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> fbd6cf7967173495875a8ea90ed28ade88b982a2 
> 
> Diff: https://reviews.apache.org/r/38416/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37903/#review99144
---


Patch looks great!

Reviews applied: [37903]

All tests passed.

- Mesos ReviewBot


On Sept. 15, 2015, 9:10 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37903/
> ---
> 
> (Updated Sept. 15, 2015, 9:10 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3328
> https://issues.apache.org/jira/browse/MESOS-3328
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous coding would try to shift a uint32_t value 32 bits to the left; 
> per
> C++ spec, this yields undefined behavior. On my machine, this resulted in
> treating a prefix of 0 as equivalent to a prefix of 32, which is obviously
> wrong.
> 
> Spotted via ubsan: see MESOS-3328.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 1ad119d54820e97497b1773518875be25ddbf98a 
>   3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp 
> b0cbcb38cfcb923ec7c185bacf139ceb0a28924f 
> 
> Diff: https://reviews.apache.org/r/37903/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 38417: Unified the implementations of image provisioners.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38417/
---

(Updated Sept. 16, 2015, 1:28 a.m.)


Review request for mesos, Timothy Chen and Jiang Yan Xu.


Changes
---

Changed image_types to container_image_providers


Bugs: MESOS-3432
https://issues.apache.org/jira/browse/MESOS-3432


Repository: mesos


Description
---

Unified the implementations of image provisioners. See ticket for motivation.


Diffs (updated)
-

  src/Makefile.am 509256f40ecc1ff5b3a5ce2b380facd153137a18 
  src/slave/containerizer/isolators/filesystem/linux.hpp 
6cfe9fa2971d50f545587b57721f75a981f6d5ed 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
dbdbf8722d088ef671b705c0c42191d0f9e05be9 
  src/slave/containerizer/mesos/containerizer.cpp 
1b83a8725b35435531038e37188b4c97189cef03 
  src/slave/containerizer/provisioner/appc/provisioner.hpp 
764b119edf670a44cff4719a2301b1baac88c78a 
  src/slave/containerizer/provisioner/appc/provisioner.cpp 
77f9cbe778785bd93c30eba5dfd7a470d9258661 
  src/slave/containerizer/provisioner/appc/store.hpp 
c4ce4b90d71791c7fd558221cb2526b1ff245d3b 
  src/slave/containerizer/provisioner/appc/store.cpp 
33f692c9b7780bdde96fddd8b07a2f4eb3452471 
  src/slave/containerizer/provisioner/paths.hpp 
5b82591fbe0d1ea48e4b09727424d0547f21adc2 
  src/slave/containerizer/provisioner/paths.cpp 
4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
  src/slave/containerizer/provisioner/provisioner.hpp 
9e0e0b8ef290a31b67bd2415253408e811e1c720 
  src/slave/containerizer/provisioner/provisioner.cpp 
2ac9008243b0dc2ba6051e75c508d183068cebcb 
  src/slave/containerizer/provisioner/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioner/store.cpp PRE-CREATION 
  src/slave/flags.hpp 799c963806fadee814bac4b9bded679b0ebbbe9c 
  src/slave/flags.cpp ff167ecd6ef224b061b37bbd3dbb4573448f8de2 
  src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
  src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
ffa371fab69ce5eebe3b02afc2a1724a0f52110f 
  src/tests/containerizer/provisioner.hpp 
a26b8138d8cc3086058b15a797dd15354a84019f 
  src/tests/containerizer/provisioner_appc_tests.cpp 
8fee7ace4d8207796a5d3fb6d52fc25d002b783d 
  src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 

Diff: https://reviews.apache.org/r/38417/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 38417: Unified the implementations of image provisioners.

[Jie Yu]

> On Sept. 16, 2015, 1:14 a.m., Timothy Chen wrote:
> > src/slave/flags.cpp, line 62
> > 
> >
> > image types sounds very generic, but I guess could be ok.
> > How about image_providers or image_formats?
> > Not really necessary to change but just a mere suggestion.

Changed it to container_image_providers


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38417/#review99142
---


On Sept. 16, 2015, 1:28 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38417/
> ---
> 
> (Updated Sept. 16, 2015, 1:28 a.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified the implementations of image provisioners. See ticket for motivation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 509256f40ecc1ff5b3a5ce2b380facd153137a18 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 6cfe9fa2971d50f545587b57721f75a981f6d5ed 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> dbdbf8722d088ef671b705c0c42191d0f9e05be9 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1b83a8725b35435531038e37188b4c97189cef03 
>   src/slave/containerizer/provisioner/appc/provisioner.hpp 
> 764b119edf670a44cff4719a2301b1baac88c78a 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> c4ce4b90d71791c7fd558221cb2526b1ff245d3b 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> 33f692c9b7780bdde96fddd8b07a2f4eb3452471 
>   src/slave/containerizer/provisioner/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/containerizer/provisioner/provisioner.hpp 
> 9e0e0b8ef290a31b67bd2415253408e811e1c720 
>   src/slave/containerizer/provisioner/provisioner.cpp 
> 2ac9008243b0dc2ba6051e75c508d183068cebcb 
>   src/slave/containerizer/provisioner/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/store.cpp PRE-CREATION 
>   src/slave/flags.hpp 799c963806fadee814bac4b9bded679b0ebbbe9c 
>   src/slave/flags.cpp ff167ecd6ef224b061b37bbd3dbb4573448f8de2 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> ffa371fab69ce5eebe3b02afc2a1724a0f52110f 
>   src/tests/containerizer/provisioner.hpp 
> a26b8138d8cc3086058b15a797dd15354a84019f 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 8fee7ace4d8207796a5d3fb6d52fc25d002b783d 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38417/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38417: Unified the implementations of image provisioners.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38417/#review99142
---



src/slave/flags.cpp (line 62)


image types sounds very generic, but I guess could be ok.
How about image_providers or image_formats?
Not really necessary to change but just a mere suggestion.


- Timothy Chen


On Sept. 16, 2015, 1:05 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38417/
> ---
> 
> (Updated Sept. 16, 2015, 1:05 a.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified the implementations of image provisioners. See ticket for motivation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 509256f40ecc1ff5b3a5ce2b380facd153137a18 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 6cfe9fa2971d50f545587b57721f75a981f6d5ed 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> dbdbf8722d088ef671b705c0c42191d0f9e05be9 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1b83a8725b35435531038e37188b4c97189cef03 
>   src/slave/containerizer/provisioner/appc/provisioner.hpp 
> 764b119edf670a44cff4719a2301b1baac88c78a 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> c4ce4b90d71791c7fd558221cb2526b1ff245d3b 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> 33f692c9b7780bdde96fddd8b07a2f4eb3452471 
>   src/slave/containerizer/provisioner/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/containerizer/provisioner/provisioner.hpp 
> 9e0e0b8ef290a31b67bd2415253408e811e1c720 
>   src/slave/containerizer/provisioner/provisioner.cpp 
> 2ac9008243b0dc2ba6051e75c508d183068cebcb 
>   src/slave/containerizer/provisioner/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/store.cpp PRE-CREATION 
>   src/slave/flags.hpp 799c963806fadee814bac4b9bded679b0ebbbe9c 
>   src/slave/flags.cpp ff167ecd6ef224b061b37bbd3dbb4573448f8de2 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> ffa371fab69ce5eebe3b02afc2a1724a0f52110f 
>   src/tests/containerizer/provisioner.hpp 
> a26b8138d8cc3086058b15a797dd15354a84019f 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 8fee7ace4d8207796a5d3fb6d52fc25d002b783d 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38417/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 38417: Unified the implementations of image provisioners.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38417/
---

Review request for mesos, Timothy Chen and Jiang Yan Xu.


Bugs: MESOS-3432
https://issues.apache.org/jira/browse/MESOS-3432


Repository: mesos


Description
---

Unified the implementations of image provisioners. See ticket for motivation.


Diffs
-

  src/Makefile.am 509256f40ecc1ff5b3a5ce2b380facd153137a18 
  src/slave/containerizer/isolators/filesystem/linux.hpp 
6cfe9fa2971d50f545587b57721f75a981f6d5ed 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
dbdbf8722d088ef671b705c0c42191d0f9e05be9 
  src/slave/containerizer/mesos/containerizer.cpp 
1b83a8725b35435531038e37188b4c97189cef03 
  src/slave/containerizer/provisioner/appc/provisioner.hpp 
764b119edf670a44cff4719a2301b1baac88c78a 
  src/slave/containerizer/provisioner/appc/provisioner.cpp 
77f9cbe778785bd93c30eba5dfd7a470d9258661 
  src/slave/containerizer/provisioner/appc/store.hpp 
c4ce4b90d71791c7fd558221cb2526b1ff245d3b 
  src/slave/containerizer/provisioner/appc/store.cpp 
33f692c9b7780bdde96fddd8b07a2f4eb3452471 
  src/slave/containerizer/provisioner/paths.hpp 
5b82591fbe0d1ea48e4b09727424d0547f21adc2 
  src/slave/containerizer/provisioner/paths.cpp 
4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
  src/slave/containerizer/provisioner/provisioner.hpp 
9e0e0b8ef290a31b67bd2415253408e811e1c720 
  src/slave/containerizer/provisioner/provisioner.cpp 
2ac9008243b0dc2ba6051e75c508d183068cebcb 
  src/slave/containerizer/provisioner/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioner/store.cpp PRE-CREATION 
  src/slave/flags.hpp 799c963806fadee814bac4b9bded679b0ebbbe9c 
  src/slave/flags.cpp ff167ecd6ef224b061b37bbd3dbb4573448f8de2 
  src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
  src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
ffa371fab69ce5eebe3b02afc2a1724a0f52110f 
  src/tests/containerizer/provisioner.hpp 
a26b8138d8cc3086058b15a797dd15354a84019f 
  src/tests/containerizer/provisioner_appc_tests.cpp 
8fee7ace4d8207796a5d3fb6d52fc25d002b783d 
  src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 

Diff: https://reviews.apache.org/r/38417/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Review Request 38416: Allow HTTP response codes to be checked with code.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38416/
---

Review request for mesos, Anand Mazumdar, Jie Yu, Jojy Varghese, and Jiang Yan 
Xu.


Bugs: MESOS-3429
https://issues.apache.org/jira/browse/MESOS-3429


Repository: mesos


Description
---

Allow HTTP response codes to be checked with code.


Diffs
-

  3rdparty/libprocess/include/process/http.hpp 
fbd6cf7967173495875a8ea90ed28ade88b982a2 

Diff: https://reviews.apache.org/r/38416/diff/


Testing
---

make


Thanks,

Timothy Chen

Re: Review Request 38158: Refactored Value::Ranges coalesce().

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/#review99124
---


Patch looks great!

Reviews applied: [38158]

All tests passed.

- Mesos ReviewBot


On Sept. 15, 2015, 8:46 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38158/
> ---
> 
> (Updated Sept. 15, 2015, 8:46 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
> 
> 
> Bugs: MESOS-3051
> https://issues.apache.org/jira/browse/MESOS-3051
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The goal of this refactoring was to reuse the Ranges objects as much as 
> possible, as prior there was substantial time spend in allocation/destruction 
> (MESOS-3051).
> 
> 
> Diffs
> -
> 
>   include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
>   src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f 
>   src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 
>   src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 
> 
> Diff: https://reviews.apache.org/r/38158/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/#review99115
---



3rdparty/libprocess/3rdparty/CMakeLists.txt (lines 223 - 225)


Just curious, why aren't you using the protobuf-2.5.0 tarball that's 
included in the mesos source?

I can imagine that you could use the included tarball for everything other 
than glog (which requires 0.3.4+).

See:
https://github.com/apache/mesos/tree/master/3rdparty/libprocess/3rdparty



3rdparty/libprocess/3rdparty/CMakeLists.txt (line 249)


There are a lot of over-80-character lines (in the existing cmake file too, 
but don't change those in this patch).

You'll want to space this line like:
```
  VS_BUILD_CMD(
  PROTOBUF 
  ${PROTOBUF_ROOT}/vsprojects/protobuf.sln 
  Release 
  "libprotobuf libprotoc protoc")
```



3rdparty/libprocess/cmake/macros/VsBuildCommand.bat (line 52)


s/is not/does not/


- Joseph Wu


On Sept. 15, 2015, 11:42 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37273/
> ---
> 
> (Updated Sept. 15, 2015, 11:42 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add CMake macro VsBuildCommand in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> d13ba666740b4f2e382a0b1852724cfd519f8f64 
>   3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37273/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

[Guangya Liu]

> On 九月 15, 2015, 7:01 p.m., Vinod Kone wrote:
> > include/mesos/scheduler.hpp, line 272
> > 
> >
> > Should we even bother adding this to the old API? Note that adding a 
> > new call to the driver will impose a upgrade dependency between schedulers 
> > and master (master first, libmesos for scheduler next, scheduler jar last)
> > 
> > more importantly, add a comment here that scheduler should call 
> > reviveOffers() to resume getting offers.
> 
> Guangya Liu wrote:
> I will consider adding this to old API in other patches.

Please ignore the comments above, I see that we are now having some discussion 
on this, I think that it is better to keep the old API before we drop it? 
Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review99061
---


On 九月 15, 2015, 11 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated 九月 15, 2015, 11 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 19f548dba4b5d72fca8e692c5f15796feca17106 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
>   src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated 九月 15, 2015, 11 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs (updated)
-

  include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
  include/mesos/scheduler/scheduler.proto 
19f548dba4b5d72fca8e692c5f15796feca17106 
  src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
  src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
  src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

[Guangya Liu]

> On 九月 15, 2015, 7:01 p.m., Vinod Kone wrote:
> > include/mesos/scheduler.hpp, line 272
> > 
> >
> > Should we even bother adding this to the old API? Note that adding a 
> > new call to the driver will impose a upgrade dependency between schedulers 
> > and master (master first, libmesos for scheduler next, scheduler jar last)
> > 
> > more importantly, add a comment here that scheduler should call 
> > reviveOffers() to resume getting offers.

I will consider adding this to old API in other patches.


> On 九月 15, 2015, 7:01 p.m., Vinod Kone wrote:
> > include/mesos/scheduler/scheduler.proto, line 173
> > 
> >
> > period at the end. also, does this fit within 80 chars?

Yes, it is 79 chars after adding the period.


> On 九月 15, 2015, 7:01 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 1747
> > 
> >
> > you also need to add a case statement to master/http.cpp.

This was handled in https://reviews.apache.org/r/38124/diff/1#index_header


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review99061
---


On 九月 5, 2015, 12:01 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated 九月 5, 2015, 12:01 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Isabel Jimenez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/
---

(Updated Sept. 15, 2015, 10:46 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone.


Bugs: MESOS-3375
https://issues.apache.org/jira/browse/MESOS-3375


Repository: mesos


Description (updated)
---

Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
ought to be changed as the executor HTTP API design evolves.
Note: This proto is a copy from the existing unversioned executor proto with 
only the necessary changes.


Diffs
-

  include/mesos/v1/executor/executor.hpp PRE-CREATION 
  include/mesos/v1/executor/executor.proto PRE-CREATION 
  src/Makefile.am 509256f 

Diff: https://reviews.apache.org/r/38143/diff/


Testing
---

make && make check


Thanks,

Isabel Jimenez

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Isabel Jimenez]

> On Sept. 15, 2015, 10:40 p.m., Anand Mazumdar wrote:
> > LGTM minus Two Nits:
> > 
> > 1. Can we update the description of the review to just say that this change 
> > just copies the existing unversioned protobuf to the V1 namespace.
> > 2. I am assuming that you would take care of Vinod's earlier comment around 
> > `invalid calls result in BadRequest` for `message Error` description in a 
> > separate patch as you had commented earlier.

1. Done
2. Yes, we have to capture this in both executor and scheduler protos. I'm 
sending a separate patch.


- Isabel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review99117
---


On Sept. 15, 2015, 10:46 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> ---
> 
> (Updated Sept. 15, 2015, 10:46 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
> https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
> added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
> ought to be changed as the executor HTTP API design evolves.
> Note: This proto is a copy from the existing unversioned executor proto with 
> only the necessary changes.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 509256f 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Isabel Jimenez]

- Isabel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review99117
---


On Sept. 15, 2015, 10:46 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> ---
> 
> (Updated Sept. 15, 2015, 10:46 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
> https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
> added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
> ought to be changed as the executor HTTP API design evolves.
> Note: This proto is a copy from the existing unversioned executor proto with 
> only the necessary changes.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 509256f 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review99117
---

Ship it!


LGTM minus Two Nits:

1. Can we update the description of the review to just say that this change 
just copies the existing unversioned protobuf to the V1 namespace.
2. I am assuming that you would take care of Vinod's earlier comment around 
`invalid calls result in BadRequest` for `message Error` description in a 
separate patch as you had commented earlier.

- Anand Mazumdar


On Sept. 15, 2015, 10:35 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> ---
> 
> (Updated Sept. 15, 2015, 10:35 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
> https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
> added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
> ought to be changed as the executor HTTP API design evolves.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 509256f 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Isabel Jimenez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/
---

(Updated Sept. 15, 2015, 10:35 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone.


Bugs: MESOS-3375
https://issues.apache.org/jira/browse/MESOS-3375


Repository: mesos


Description
---

Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
ought to be changed as the executor HTTP API design evolves.


Diffs (updated)
-

  include/mesos/v1/executor/executor.hpp PRE-CREATION 
  include/mesos/v1/executor/executor.proto PRE-CREATION 
  src/Makefile.am 509256f 

Diff: https://reviews.apache.org/r/38143/diff/


Testing
---

make && make check


Thanks,

Isabel Jimenez

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review99116
---


Patch looks great!

Reviews applied: [37273, 37275]

All tests passed.

- Mesos ReviewBot


On Sept. 15, 2015, 6:42 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Sept. 15, 2015, 6:42 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37540: Add perf event API

[Cong Wang]

> On Sept. 15, 2015, 12:31 a.m., Vinod Kone wrote:
> > my main question is regarding division of responsibilities between the 
> > wrapper class and the process class. Looks like opening the fd and mmaping 
> > is done by the wrapper and the rest by the process. Can everything be done 
> > by the process?

Hmm, but why should we expose the process class to user? With current code, 
user only sees the wrapper. Also, there are many similar code in 
src/linux/cgroup.cpp, pretty much because of the async IO interface in Mesos 
code base.


> On Sept. 15, 2015, 12:31 a.m., Vinod Kone wrote:
> > src/linux/perf.cpp, line 747
> > 
> >
> > is there any reason why we want close() as part of the public API? 
> > sounds like users can simply call delete on the PerfEvent object? i would 
> > recommend removing this method or making it private.
> > 
> > more importantly, what happens if close() is called twice? is that safe?

Good point. Fixed, just FYI it is a smart pointer, user should call reset() not 
delete.


> On Sept. 15, 2015, 12:31 a.m., Vinod Kone wrote:
> > src/linux/perf.cpp, lines 749-752
> > 
> >
> > can this be done by the process instead?

Probably we can do it in finialize() too, not sure what is the benifit over 
this?


> On Sept. 15, 2015, 12:31 a.m., Vinod Kone wrote:
> > src/linux/perf.cpp, line 563
> > 
> >
> > sharing the map between this class and the constituent process class is 
> > unfortunate. what happens if the process class deletes the pointer?
> > 
> > is it possible to have the process class create and own the map?

The map is created when user calls create(), then it is passed to the process 
class, so the process class only reads it when user calls read().


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37540/#review98924
---


On Sept. 4, 2015, 11:13 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37540/
> ---
> 
> (Updated Sept. 4, 2015, 11:13 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2769
> https://issues.apache.org/jira/browse/MESOS-2769
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Abstract Linux kernel perf event API and provide API to collect schedule 
> events.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5 
>   src/linux/perf.cpp 0011482cf9d920485728798518d32af0e9627724 
>   src/tests/containerizer/perf_tests.cpp 
> bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38 
> 
> Diff: https://reviews.apache.org/r/37540/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38003/#review99112
---



src/tests/master_tests.cpp (line 3596)


new line.



src/tests/master_tests.cpp (lines 3597 - 3598)


// This test ensures that a slave gets a unique SlaveID even after
// master fails over. Please refer to MESOS-3351 for further details.



src/tests/master_tests.cpp (lines 3607 - 3608)


Why specify a mock executor and test containerizer? There's a StartSlave() 
overload that takes just the detector (and optionally flags), which you can use?



src/tests/master_tests.cpp (line 3622)


// Start a new slave and make sure it registers before the old slave.



src/tests/master_tests.cpp (line 3630)


// Now let the first slave re-register.



src/tests/master_tests.cpp (lines 3633 - 3634)


// If both the slaves get the same SlaveID, the re-registration would fail 
here.



src/tests/master_tests.cpp (line 3636)


Also add a CHECK_NE() check with both the slave ids?



src/tests/master_tests.cpp (line 3637)


Does this test reliably fail (i.e., every time) without the code change in 
master.cpp?


- Vinod Kone


On Sept. 14, 2015, 6:08 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38003/
> ---
> 
> (Updated Sept. 14, 2015, 6:08 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3351
> https://issues.apache.org/jira/browse/MESOS-3351
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> __Phenomenon:__
> In some race condition, the slave was shutdown when after master failover.
> 
> __Root Cause:__
> The slave was shutdown because of duplicated SlavID: in master, the SlaveID 
> is genereated by masterInfo.id + "-S" + nextSlaveId; when master failover, 
> nextSlaveId was reset to 0 and masterInfo.id (generated by date + ip + port + 
> pid) maybe un-changed which lead to duplicated SlaveID. 
> 
> __Solution/Fix:__
> Generate masterInfo.id by UUID instead of "date + ip + port + pid".
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 5589eca 
>   src/tests/master_tests.cpp 8a6b98b 
> 
> Diff: https://reviews.apache.org/r/38003/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 38278: Updating unversioned Executor protobuf

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38278/#review99114
---

Ship it!


Ship It!

- Anand Mazumdar


On Sept. 15, 2015, 10:24 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38278/
> ---
> 
> (Updated Sept. 15, 2015, 10:24 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding last changes of the executor HTTP API design to the unversioned 
> protobuf
> 
> 
> Diffs
> -
> 
>   include/mesos/executor/executor.proto 52c84b3 
> 
> Diff: https://reviews.apache.org/r/38278/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 38278: Updating unversioned Executor protobuf

[Isabel Jimenez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38278/
---

(Updated Sept. 15, 2015, 10:24 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone.


Repository: mesos


Description
---

Adding last changes of the executor HTTP API design to the unversioned protobuf


Diffs (updated)
-

  include/mesos/executor/executor.proto 52c84b3 

Diff: https://reviews.apache.org/r/38278/diff/


Testing
---

make


Thanks,

Isabel Jimenez

Re: Review Request 38278: Updating unversioned Executor protobuf

[Anand Mazumdar]

> On Sept. 15, 2015, 10:10 p.m., Anand Mazumdar wrote:
> > include/mesos/executor/executor.proto, line 163
> > 
> >
> > Minor: Can we also have a comment before the `framework_id` field ?
> > 
> > // Identifies the framework which generated this call.

My bad, ignore. I did not see already that the `tuple` (`ExecutorID`, 
`FrameworkID`) in itself idenfies the executor.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38278/#review99109
---


On Sept. 15, 2015, 9:32 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38278/
> ---
> 
> (Updated Sept. 15, 2015, 9:32 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding last changes of the executor HTTP API design to the unversioned 
> protobuf
> 
> 
> Diffs
> -
> 
>   include/mesos/executor/executor.proto 52c84b3 
> 
> Diff: https://reviews.apache.org/r/38278/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 38278: Updating unversioned Executor protobuf

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38278/#review99109
---


Looks good, just a few more minor things. Also to save effort don't bother 
updating the corresponding V1 review for now. You can just copy paste once the 
changes in this review is finalized.


include/mesos/executor/executor.proto (line 129)


`message Subscribe` is not the first event received when the executor 
subscribes.

Can we change the comment to:
// Request to subscribe with the slave. If subscribing after a 
disconnection, it must include a list of all the tasks and updates which 
haven't been acknowledged by the scheduler.



include/mesos/executor/executor.proto (line 160)


Minor: Can we also have a comment before the `framework_id` field ?

// Identifies the framework which generated this call.


- Anand Mazumdar


On Sept. 15, 2015, 9:32 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38278/
> ---
> 
> (Updated Sept. 15, 2015, 9:32 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding last changes of the executor HTTP API design to the unversioned 
> protobuf
> 
> 
> Diffs
> -
> 
>   include/mesos/executor/executor.proto 52c84b3 
> 
> Diff: https://reviews.apache.org/r/38278/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 38278: Updating unversioned Executor protobuf

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38278/#review99110
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 15, 2015, 9:32 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38278/
> ---
> 
> (Updated Sept. 15, 2015, 9:32 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding last changes of the executor HTTP API design to the unversioned 
> protobuf
> 
> 
> Diffs
> -
> 
>   include/mesos/executor/executor.proto 52c84b3 
> 
> Diff: https://reviews.apache.org/r/38278/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 38011: Maintenance Primitives: Use the parse> helper instead of a plural MachineID protobuf.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/#review99105
---


Patch looks great!

Reviews applied: [38011]

All tests passed.

- Mesos ReviewBot


On Sept. 15, 2015, 5:47 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38011/
> ---
> 
> (Updated Sept. 15, 2015, 5:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem 
> Harutyunyan, Joris Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This removes the MachineIDs protobuf and changes it to instead use the 
> RepeatedFieldPtr.
> This also changes the maintenance primitives (alpha) API for /machine/up and 
> /machine/down, which both take an array instead of an object now.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   include/mesos/v1/mesos.proto bcce340777f037053e1eab2d75c351e53420b9da 
>   src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0 
>   src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c 
>   src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71 
>   src/tests/master_maintenance_tests.cpp 
> 44785057f129a3e6a69f399f7d6db59d9d5c2e91 
>   src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955 
> 
> Diff: https://reviews.apache.org/r/38011/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38278: Updating unversioned Executor protobuf

[Isabel Jimenez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38278/
---

(Updated Sept. 15, 2015, 9:32 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone.


Repository: mesos


Description
---

Adding last changes of the executor HTTP API design to the unversioned protobuf


Diffs (updated)
-

  include/mesos/executor/executor.proto 52c84b3 

Diff: https://reviews.apache.org/r/38278/diff/


Testing
---

make


Thanks,

Isabel Jimenez

Re: Review Request 38278: Updating unversioned Executor protobuf

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38278/#review99102
---



include/mesos/executor/executor.proto (line 131)


kill this.



include/mesos/executor/executor.proto (line 160)


make this required.

also add a "required FrameworkID framework_id" because executor id is only 
unique within a framework.


- Vinod Kone


On Sept. 15, 2015, 8:13 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38278/
> ---
> 
> (Updated Sept. 15, 2015, 8:13 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding last changes of the executor HTTP API design to the unversioned 
> protobuf
> 
> 
> Diffs
> -
> 
>   include/mesos/executor/executor.proto 52c84b3 
> 
> Diff: https://reviews.apache.org/r/38278/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38370/
---

(Updated Sept. 15, 2015, 5:11 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Timothy 
Chen.


Changes
---

addressed Tim's and Nik's comments.


Bugs: MESOS-3013
https://issues.apache.org/jira/browse/MESOS-3013


Repository: mesos


Description
---

Updated docker executor to set container IP in TaskStatus::NetworkInfo.


Diffs (updated)
-

  src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
  src/tests/containerizer/docker_containerizer_tests.cpp 
a628922cc49b1dc8a37621a6a8b7ef6842cfb051 

Diff: https://reviews.apache.org/r/38370/diff/


Testing
---

make check.


Thanks,

Kapil Arya

Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

[Kapil Arya]

> On Sept. 14, 2015, 6:11 p.m., Niklas Nielsen wrote:
> > src/examples/test_hook_module.cpp, line 198
> > 
> >
> > How about setting the protocol (for testing)? So maybe have two network 
> > infos (one with each)?

Apparently, the protocol is of no use for TaskStatus decorator. It's only used 
when requesting IP (as mentioned in the comments for the protobuf). Dropping 
the issue. Feel free to reopen if needed.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/#review98928
---


On Sept. 15, 2015, 5:10 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38368/
> ---
> 
> (Updated Sept. 15, 2015, 5:10 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows the hook to not only update TaskStatus::labels, but also
> TaskStatus::container_status.
> 
> Enhanced example hook module and relevant test to reflect the change.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
>   src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
>   src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
>   src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
>   src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
>   src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
>   src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 
> 
> Diff: https://reviews.apache.org/r/38368/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37903/
---

(Updated Sept. 15, 2015, 9:10 p.m.)


Review request for mesos.


Bugs: MESOS-3328
https://issues.apache.org/jira/browse/MESOS-3328


Repository: mesos


Description
---

The previous coding would try to shift a uint32_t value 32 bits to the left; per
C++ spec, this yields undefined behavior. On my machine, this resulted in
treating a prefix of 0 as equivalent to a prefix of 32, which is obviously
wrong.

Spotted via ubsan: see MESOS-3328.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
1ad119d54820e97497b1773518875be25ddbf98a 
  3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp 
b0cbcb38cfcb923ec7c185bacf139ceb0a28924f 

Diff: https://reviews.apache.org/r/37903/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/
---

(Updated Sept. 15, 2015, 5:10 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.


Changes
---

addressed comments.


Bugs: MESOS-3013
https://issues.apache.org/jira/browse/MESOS-3013


Repository: mesos


Description
---

This allows the hook to not only update TaskStatus::labels, but also
TaskStatus::container_status.

Enhanced example hook module and relevant test to reflect the change.


Diffs (updated)
-

  include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
  src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
  src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
  src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
  src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
  src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
  src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 

Diff: https://reviews.apache.org/r/38368/diff/


Testing
---

make check.


Thanks,

Kapil Arya

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

[Kapil Arya]

> On Sept. 14, 2015, 6:43 p.m., Niklas Nielsen wrote:
> > src/slave/slave.cpp, line 2760
> > 
> >
> > s/the container IP address if/the container IP address with the IP from 
> > the agent PID, if/ or something that specifies where you are getting the IP 
> > from.
> > 
> > Would it be more precise to get the IP from the executor PID?

Updated the comment and added a TODO.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98936
---


On Sept. 15, 2015, 5:06 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> ---
> 
> (Updated Sept. 15, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows the frameworks to specify an intent to enable ip-per-container. 
> The
> IP information is supplied back to the framework as well as state.json 
> endpoints
> by including NetworkInfo inside TaskStatus.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 
>   src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 
>   src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 
> 
> Diff: https://reviews.apache.org/r/38367/diff/
> 
> 
> Testing
> ---
> 
> Added new tests and ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

[Kapil Arya]

> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1163
> > 
> >
> > We still go by 70 col comments, right? If so, let's wrap the comment 
> > blocks.

It's been updated :-) 
https://github.com/apache/mesos/commit/f9c2604ea97b91f8a9ec3b2863317761679b1c86


> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1362
> > 
> >
> > Request _and_ resolution, right?
> > 
> > Can we capture this here?

Fixed.


> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1365
> > 
> >
> > We probably need to have a caveat about the pluggable nature of 
> > networking (and that if not enabled, this will be not be interpreted by 
> > mesos)

Extended the comment.


> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1376
> > 
> >
> > We should probably mention that it is up to the mesos networking 
> > 'provider' to interpret this as either a hint or a requirement for the 
> > assigned ip.

Done.


> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1386
> > 
> >
> > We could mention that these groups can be used for isolation

Fixed.


> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1390
> > 
> >
> > pop? :)

Removed.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98926
---


On Sept. 15, 2015, 5:06 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> ---
> 
> (Updated Sept. 15, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows the frameworks to specify an intent to enable ip-per-container. 
> The
> IP information is supplied back to the framework as well as state.json 
> endpoints
> by including NetworkInfo inside TaskStatus.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 
>   src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 
>   src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 
> 
> Diff: https://reviews.apache.org/r/38367/diff/
> 
> 
> Testing
> ---
> 
> Added new tests and ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

[Kapil Arya]

> On Sept. 14, 2015, 6:19 p.m., Vinod Kone wrote:
> > src/common/http.cpp, lines 153-194
> > 
> >
> > Why custom models? Can we not use the protobuf to json converters?

This is mostly due to Labels. The way they are setup right now, we get sth like:
```
{ "labels": { "labels": [ { "key": "k", "value": "v" } ... ] } }
```

The explicit modelling removes the extra label from within the JSON to make it 
more readable.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98932
---


On Sept. 15, 2015, 5:06 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> ---
> 
> (Updated Sept. 15, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3013
> https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows the frameworks to specify an intent to enable ip-per-container. 
> The
> IP information is supplied back to the framework as well as state.json 
> endpoints
> by including NetworkInfo inside TaskStatus.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 
>   src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 
>   src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 
> 
> Diff: https://reviews.apache.org/r/38367/diff/
> 
> 
> Testing
> ---
> 
> Added new tests and ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/
---

(Updated Sept. 15, 2015, 5:06 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.


Changes
---

Addressed Vinod's and Nik's comments.


Bugs: MESOS-3013
https://issues.apache.org/jira/browse/MESOS-3013


Repository: mesos


Description
---

This allows the frameworks to specify an intent to enable ip-per-container. The
IP information is supplied back to the framework as well as state.json endpoints
by including NetworkInfo inside TaskStatus.


Diffs (updated)
-

  include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
  src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 
  src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 
  src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
  src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
  src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 

Diff: https://reviews.apache.org/r/38367/diff/


Testing
---

Added new tests and ran make check.


Thanks,

Kapil Arya

Re: Review Request 38366: Added helper to model Labels message for state.json.

[Kapil Arya]

> On Sept. 15, 2015, 1:56 p.m., Niklas Nielsen wrote:
> > src/common/protobuf_utils.cpp, line 140
> > 
> >
> > This could break existing 3rd party parsing; why not leave it set?

I am not so sure. This is fairly inconsistent with the rest of the format. Is 
there is a guideline that we can follow for such changes?


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38366/#review99051
---


On Sept. 14, 2015, 4:55 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38366/
> ---
> 
> (Updated Sept. 14, 2015, 4:55 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also updated Task modelling to show labels only if Task.has_labels() is true. 
> This way, the "labels" field won't shown if there are no labels. This makes 
> it consistent with the modelling of rest of the "optional" fields.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 
>   src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 
>   src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
> 
> Diff: https://reviews.apache.org/r/38366/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 38365: Updated Isolator::prepare to return list of required namespaces.

[Kapil Arya]

> On Sept. 14, 2015, 6:50 p.m., Niklas Nielsen wrote:
> > include/mesos/slave/isolator.proto, line 75
> > 
> >
> > Taken we still wrap comments at 70, this needs to be wrapped :)

We don't :-). See 
https://github.com/apache/mesos/commit/f9c2604ea97b91f8a9ec3b2863317761679b1c86.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38365/#review98937
---


On Sept. 15, 2015, 5:05 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38365/
> ---
> 
> (Updated Sept. 15, 2015, 5:05 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3387
> https://issues.apache.org/jira/browse/MESOS-3387
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows the Isolators to decide whether or not to provide resource 
> isolation
> on a per-container level.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.hpp 4db23dc242039607e6444d15aa800207b415ca02 
>   include/mesos/slave/isolator.proto 12ea6ac3552c70a172ae9e8506f4b5d96457a3ec 
>   src/slave/containerizer/isolator.hpp 
> fbb7c8ab908192ae64f34e466c0c24705b3a134b 
>   src/slave/containerizer/isolator.cpp 
> 7973100ea1a58938c50962120b9ecb6722b2ee4e 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> ab60f0ccffa06cb6f1913a6fd4fce8a2ccf6cd94 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9 
>   src/slave/containerizer/isolators/filesystem/shared.hpp 
> a21bc79d342ece50c4924fc0ebd2186e57b3e899 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 4b4520e30ce1d1818bd3a13260f6dd55ab3900c9 
>   src/slave/containerizer/isolators/namespaces/pid.hpp 
> b22f5ba8e3743bb243ed2c5d204ab4ba21088630 
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> 35cb6645c9abc0cf533b844e2b2cccf4374bfd68 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 4bca0b81bf69fb4cd75e05aacd02d3e818e32d09 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 34ba2294b0bd7d57aa9de073692a2ea8ec62681d 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1b83a8725b35435531038e37188b4c97189cef03 
>   src/tests/containerizer/isolator_tests.cpp 
> d34c82a7f24da6f60cfb22790f516dc6065b1f6f 
> 
> Diff: https://reviews.apache.org/r/38365/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 38365: Updated Isolator::prepare to return list of required namespaces.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38365/
---

(Updated Sept. 15, 2015, 5:05 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.


Changes
---

rebased


Bugs: MESOS-3387
https://issues.apache.org/jira/browse/MESOS-3387


Repository: mesos


Description
---

This allows the Isolators to decide whether or not to provide resource isolation
on a per-container level.


Diffs (updated)
-

  include/mesos/slave/isolator.hpp 4db23dc242039607e6444d15aa800207b415ca02 
  include/mesos/slave/isolator.proto 12ea6ac3552c70a172ae9e8506f4b5d96457a3ec 
  src/slave/containerizer/isolator.hpp fbb7c8ab908192ae64f34e466c0c24705b3a134b 
  src/slave/containerizer/isolator.cpp 7973100ea1a58938c50962120b9ecb6722b2ee4e 
  src/slave/containerizer/isolators/filesystem/linux.hpp 
ab60f0ccffa06cb6f1913a6fd4fce8a2ccf6cd94 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9 
  src/slave/containerizer/isolators/filesystem/shared.hpp 
a21bc79d342ece50c4924fc0ebd2186e57b3e899 
  src/slave/containerizer/isolators/filesystem/shared.cpp 
4b4520e30ce1d1818bd3a13260f6dd55ab3900c9 
  src/slave/containerizer/isolators/namespaces/pid.hpp 
b22f5ba8e3743bb243ed2c5d204ab4ba21088630 
  src/slave/containerizer/isolators/namespaces/pid.cpp 
35cb6645c9abc0cf533b844e2b2cccf4374bfd68 
  src/slave/containerizer/isolators/network/port_mapping.hpp 
4bca0b81bf69fb4cd75e05aacd02d3e818e32d09 
  src/slave/containerizer/isolators/network/port_mapping.cpp 
34ba2294b0bd7d57aa9de073692a2ea8ec62681d 
  src/slave/containerizer/mesos/containerizer.cpp 
1b83a8725b35435531038e37188b4c97189cef03 
  src/tests/containerizer/isolator_tests.cpp 
d34c82a7f24da6f60cfb22790f516dc6065b1f6f 

Diff: https://reviews.apache.org/r/38365/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 38364: Minor refactor for MesosContainerizer.

[Kapil Arya]

> On Sept. 14, 2015, 6:55 p.m., Niklas Nielsen wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 832-843
> > 
> >
> > How about moving this up as well?

Fixed.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38364/#review98938
---


On Sept. 15, 2015, 5:02 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38364/
> ---
> 
> (Updated Sept. 15, 2015, 5:02 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3387
> https://issues.apache.org/jira/browse/MESOS-3387
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change moves two different pieces of code, that each iterate over list 
> of ContainerPrepareInfos, close together for readability. It becomes even 
> more relevant when looking at https://reviews.apache.org/r/38365/ that 
> iterates over yet another member from ContainerPrepareInfo.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1b83a8725b35435531038e37188b4c97189cef03 
> 
> Diff: https://reviews.apache.org/r/38364/diff/
> 
> 
> Testing
> ---
> 
> make  check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 38364: Minor refactor for MesosContainerizer.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38364/
---

(Updated Sept. 15, 2015, 5:02 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.


Changes
---

addressed comments.


Bugs: MESOS-3387
https://issues.apache.org/jira/browse/MESOS-3387


Repository: mesos


Description
---

This change moves two different pieces of code, that each iterate over list of 
ContainerPrepareInfos, close together for readability. It becomes even more 
relevant when looking at https://reviews.apache.org/r/38365/ that iterates over 
yet another member from ContainerPrepareInfo.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
1b83a8725b35435531038e37188b4c97189cef03 

Diff: https://reviews.apache.org/r/38364/diff/


Testing
---

make  check


Thanks,

Kapil Arya

Re: Review Request 38363: Refactored container Launcher to accept namespaces dynamically.

[Kapil Arya]

> On Sept. 14, 2015, 6:32 p.m., Niklas Nielsen wrote:
> > src/tests/containerizer/isolator_tests.cpp, line 507
> > 
> >
> > Have you verified the status (non-error) of namespaces() before you get 
> > here?

The Isolator::namespace() call simply returns an Option and so the future is 
always satisfied and so we don't check the status here. Further, this logic 
gets replaced by https://reviews.apache.org/r/38365 when we remove 
Isolator::prepare in lieu of Isolator::prepare returning namespaces. Dropping 
the issue.


> On Sept. 14, 2015, 6:32 p.m., Niklas Nielsen wrote:
> > src/tests/containerizer/isolator_tests.cpp, line 202
> > 
> >
> > Does it make sense to have None() as the default value?

It's a pure virtual function, so we can't really have defaults AFAIK :-/.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38363/#review98934
---


On Sept. 14, 2015, 4:55 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38363/
> ---
> 
> (Updated Sept. 14, 2015, 4:55 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3387
> https://issues.apache.org/jira/browse/MESOS-3387
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This prepares MesosContainerizer to allow isolators to specify namespaces for
> each individual containerizer. Thus, allowing isolators to decide whether or 
> not
> to enable isolation for a particular container.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/launcher.hpp 
> 8cc832e99838683c14d8158bdf52a267299508c7 
>   src/slave/containerizer/launcher.cpp 
> 5267eecbdf31c88cd3c7dc7172b5aff7bac534b0 
>   src/slave/containerizer/linux_launcher.hpp 
> bf6bf3f27dac007429c224d4f6798ac68316accb 
>   src/slave/containerizer/linux_launcher.cpp 
> 12acf4d08cb7fb1161820cf4bb480fd1bc2c6858 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1b83a8725b35435531038e37188b4c97189cef03 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> ffa371fab69ce5eebe3b02afc2a1724a0f52110f 
>   src/tests/containerizer/isolator_tests.cpp 
> d34c82a7f24da6f60cfb22790f516dc6065b1f6f 
>   src/tests/containerizer/launcher.hpp 
> 6f020f94b042eef0e6a69ba8c26dfb697f3e81a3 
> 
> Diff: https://reviews.apache.org/r/38363/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99087
---



src/tests/paths_tests.cpp (line 224)


This should still be provisioners right?


- Timothy Chen


On Sept. 15, 2015, 6:51 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> ---
> 
> (Updated Sept. 15, 2015, 6:51 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

[Timothy Chen]

> On Sept. 15, 2015, 8:51 p.m., Timothy Chen wrote:
> > Ship It!

Wierd, anyway fix it and ship it :)


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99088
---


On Sept. 15, 2015, 6:51 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> ---
> 
> (Updated Sept. 15, 2015, 6:51 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99088
---

Ship it!


Ship It!

- Timothy Chen


On Sept. 15, 2015, 6:51 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> ---
> 
> (Updated Sept. 15, 2015, 6:51 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38158: Refactored Value::Ranges coalesce().

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/
---

(Updated Sept. 15, 2015, 8:46 p.m.)


Review request for mesos, Bernd Mathiske and Till Toenshoff.


Bugs: MESOS-3051
https://issues.apache.org/jira/browse/MESOS-3051


Repository: mesos


Description
---

The goal of this refactoring was to reuse the Ranges objects as much as 
possible, as prior there was substantial time spend in allocation/destruction 
(MESOS-3051).


Diffs (updated)
-

  include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
  src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f 
  src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 
  src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 

Diff: https://reviews.apache.org/r/38158/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 38386: Fix 'operator=' spacing in the registry_client.hpp

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38386/#review99086
---

Ship it!


Ship It!


src/slave/containerizer/provisioners/docker/registry_client.hpp (line 154)


Nice catch :)


- Timothy Chen


On Sept. 15, 2015, 11:23 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38386/
> ---
> 
> (Updated Sept. 15, 2015, 11:23 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Joseph Wu, and 
> Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix 'operator=' spacing in the registry_client.hpp
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioners/docker/registry_client.hpp 
> b5e28587bc9adc2c02805b13fbc5c693612c99fb 
> 
> Diff: https://reviews.apache.org/r/38386/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38386: Fix 'operator=' spacing in the registry_client.hpp

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38386/#review99085
---


Patch looks great!

Reviews applied: [38386]

All tests passed.

- Mesos ReviewBot


On Sept. 15, 2015, 11:23 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38386/
> ---
> 
> (Updated Sept. 15, 2015, 11:23 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Joseph Wu, and 
> Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix 'operator=' spacing in the registry_client.hpp
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioners/docker/registry_client.hpp 
> b5e28587bc9adc2c02805b13fbc5c693612c99fb 
> 
> Diff: https://reviews.apache.org/r/38386/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

[Isabel Jimenez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/
---

(Updated Sept. 15, 2015, 8:16 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone.


Bugs: MESOS-3375
https://issues.apache.org/jira/browse/MESOS-3375


Repository: mesos


Description
---

Executor protobufswere introduced in Mesos for the HTTP API, they need to be 
added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf 
ought to be changed as the executor HTTP API design evolves.


Diffs (updated)
-

  include/mesos/v1/executor/executor.hpp PRE-CREATION 
  include/mesos/v1/executor/executor.proto PRE-CREATION 
  src/Makefile.am 509256f 

Diff: https://reviews.apache.org/r/38143/diff/


Testing
---

make && make check


Thanks,

Isabel Jimenez

Re: Review Request 38278: Updating unversioned Executor protobuf

[Isabel Jimenez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38278/
---

(Updated Sept. 15, 2015, 8:13 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone.


Repository: mesos


Description
---

Adding last changes of the executor HTTP API design to the unversioned protobuf


Diffs (updated)
-

  include/mesos/executor/executor.proto 52c84b3 

Diff: https://reviews.apache.org/r/38278/diff/


Testing
---

make


Thanks,

Isabel Jimenez

Re: Review Request 37969: Maintenance primitives: Tweak validation error messages to return JSON rather than protobuf.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37969/#review99079
---


Patch looks great!

Reviews applied: [37969]

All tests passed.

- Mesos ReviewBot


On Sept. 15, 2015, 12:10 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37969/
> ---
> 
> (Updated Sept. 15, 2015, 12:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaces `__.DebugString()` with `stringify(JSON::Protobuf(__))`, which looks 
> nicer and matches the JSON expected by the HTTP endpoints.
> 
> Addresses a comment found here: 
> https://reviews.apache.org/r/37358/#comment152513
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71 
> 
> Diff: https://reviews.apache.org/r/37969/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> This change will tweak the output from:
> ```
> Machine 'hostname: "myComputer"
> ' is not valid because ...
> 
> ```
> (`DebugString` ^ puts a newline there.)
> 
> To: 
> ```
> Machine '{"hostname":"myComputer"}' is not valid because ...
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38126: Add UT for QuiesceOffers

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38126/#review99078
---


you should've merged this test review with the dependent review. i really like 
tests to be present in the same patch as the code change, to give me confidence 
that the code changes are correct.

also, no tests for the scheduler driver?


src/tests/scheduler_tests.cpp (lines 1004 - 1005)


// On revival scheduler should get another offer with the same amount of 
resources.

also, i'm a bit confused on how/why the scheduler gets another offer (for 
the same resources) considering the framework is holding on to the original 
offer?


- Vinod Kone


On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38126/
> ---
> 
> (Updated Sept. 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add UT for QuiesceOffers
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
> 
> Diff: https://reviews.apache.org/r/38126/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37873: Add quiesce logic in allocator

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review99077
---



src/master/allocator/mesos/hierarchical.hpp (line 229)


s/quiescent/quiesced/ ?



src/master/allocator/mesos/hierarchical.hpp (line 989)


indent by 2 spaces.


- Vinod Kone


On Sept. 6, 2015, 2:40 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> ---
> 
> (Updated Sept. 6, 2015, 2:40 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add quiesce logic in allocator
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp 
> aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp 
> cb4020dea897ef198cd9898cabecf61edfade834 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569 
> 
> Diff: https://reviews.apache.org/r/37873/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38124: Add V1 Support for QuiesceOffers

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/#review99076
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38124/
> ---
> 
> (Updated Sept. 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add V1 Support for QuiesceOffers
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/scheduler/scheduler.proto 
> bd5e82a614b1163b29f9b20e562208efa1ba4b55 
>   src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
>   src/master/validation.cpp ffb7bf07b8a40d6e14f922eabcf46045462498b5 
> 
> Diff: https://reviews.apache.org/r/38124/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

[Jie Yu]

> On Sept. 15, 2015, 7:01 p.m., Jiang Yan Xu wrote:
> > src/slave/paths.cpp, line 378
> > 
> >
> > I don't think this needs to be changed to singular and the convention 
> > is that the plural form ("slaves", "frameworks", "executors", 
> > "provisioners", "volumes", etc.) is used for folders that serve as 
> > "container folders".
> 
> Jie Yu wrote:
> We use 'slaves' 'executors' ... because there could be multiple slaves, 
> executors.
> 
> But, there's only one provisioner.

OK, Chatted with YanX. The image_type part will be removed in the subsequent 
patch. I'll just keep it as it is for this patch.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99065
---


On Sept. 15, 2015, 6:51 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> ---
> 
> (Updated Sept. 15, 2015, 6:51 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

[Jiang Yan Xu]

> On Sept. 15, 2015, 12:01 p.m., Jiang Yan Xu wrote:
> > src/slave/paths.cpp, line 378
> > 
> >
> > I don't think this needs to be changed to singular and the convention 
> > is that the plural form ("slaves", "frameworks", "executors", 
> > "provisioners", "volumes", etc.) is used for folders that serve as 
> > "container folders".
> 
> Jie Yu wrote:
> We use 'slaves' 'executors' ... because there could be multiple slaves, 
> executors.
> 
> But, there's only one provisioner.
> 
> Jie Yu wrote:
> OK, Chatted with YanX. The image_type part will be removed in the 
> subsequent patch. I'll just keep it as it is for this patch.

Fine then. Chatted offline about removing the per-image-type dirs as well.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99065
---


On Sept. 15, 2015, 11:51 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> ---
> 
> (Updated Sept. 15, 2015, 11:51 a.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38121: Add Python Support for QuiesceOffers

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38121/#review99073
---


Update the python test framework to send this call.


src/python/interface/src/mesos/interface/__init__.py (lines 235 - 236)


ditto. Use the same wording as you did in scheduler.hpp.


- Vinod Kone


On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38121/
> ---
> 
> (Updated Sept. 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add Python Support for QuiesceOffers
> 
> 
> Diffs
> -
> 
>   src/python/interface/src/mesos/interface/__init__.py 
> 686abb24d88765d7ec7cab5b76b57299339b7b00 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
> b1ad8e529806a047480e8d7affe4e7ecdc7d9725 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
> 609dfa3735f19eea2242dfb82ed3a4af3a0b8b9b 
> 
> Diff: https://reviews.apache.org/r/38121/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38120: Add Java Support for QuiesceOffers

[Vinod Kone]

> On Sept. 15, 2015, 7:12 p.m., Vinod Kone wrote:
> >

can you also update the java test framework to test this call?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38120/#review99071
---


On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38120/
> ---
> 
> (Updated Sept. 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add Java Support for QuiesceOffers
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> a89ebed00f93801fc5bfb18e947f7120ef77d095 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
> b9b2ea8734bb910c543708dd8adcdac45e03c34b 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> 183eec898553ed25149c58d2c1f85cf6579d5660 
> 
> Diff: https://reviews.apache.org/r/38120/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38120: Add Java Support for QuiesceOffers

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38120/#review99071
---

Ship it!



src/java/src/org/apache/mesos/SchedulerDriver.java (lines 254 - 255)


Just have the same comment that you had on scheduler.hpp in the first 
review of this chain.


- Vinod Kone


On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38120/
> ---
> 
> (Updated Sept. 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add Java Support for QuiesceOffers
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> a89ebed00f93801fc5bfb18e947f7120ef77d095 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
> b9b2ea8734bb910c543708dd8adcdac45e03c34b 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> 183eec898553ed25149c58d2c1f85cf6579d5660 
> 
> Diff: https://reviews.apache.org/r/38120/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38119: Add metrics of messages_quiesce_offers

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38119/#review99070
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38119/
> ---
> 
> (Updated Sept. 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add metrics of messages_quiesce_offers
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
>   src/master/metrics.hpp 2d07a16f2dc6811973c82259c3cccff07401b542 
>   src/master/metrics.cpp d79206f08181c99641bef697be57b5d57b627285 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/metrics_tests.cpp 3e9d7c2eadfcdd2522d65e4a55dc76808ba39159 
> 
> Diff: https://reviews.apache.org/r/38119/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37873: Add quiesce logic in allocator

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review99069
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 6, 2015, 2:40 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> ---
> 
> (Updated Sept. 6, 2015, 2:40 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add quiesce logic in allocator
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp 
> aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp 
> cb4020dea897ef198cd9898cabecf61edfade834 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569 
> 
> Diff: https://reviews.apache.org/r/37873/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37873: Add quiesce logic in allocator

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review99066
---



include/mesos/master/allocator.hpp (line 145)


s/Allocator/allocator/

s/to the framework/for the framework./



src/master/allocator/mesos/hierarchical.hpp (line 398)


Remove this comment.


- Vinod Kone


On Sept. 6, 2015, 2:40 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> ---
> 
> (Updated Sept. 6, 2015, 2:40 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add quiesce logic in allocator
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp 
> aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp 
> cb4020dea897ef198cd9898cabecf61edfade834 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569 
> 
> Diff: https://reviews.apache.org/r/37873/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

[Jie Yu]

> On Sept. 15, 2015, 7:01 p.m., Jiang Yan Xu wrote:
> > src/slave/paths.cpp, line 378
> > 
> >
> > I don't think this needs to be changed to singular and the convention 
> > is that the plural form ("slaves", "frameworks", "executors", 
> > "provisioners", "volumes", etc.) is used for folders that serve as 
> > "container folders".

We use 'slaves' 'executors' ... because there could be multiple slaves, 
executors.

But, there's only one provisioner.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99065
---


On Sept. 15, 2015, 6:51 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> ---
> 
> (Updated Sept. 15, 2015, 6:51 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99065
---



src/slave/containerizer/provisioner/paths.hpp (line 32)


`provisoiners -> provisioner`: This is fine with me.



src/slave/paths.cpp (line 378)


I don't think this needs to be changed to singular and the convention is 
that the plural form ("slaves", "frameworks", "executors", "provisioners", 
"volumes", etc.) is used for folders that serve as "container folders".


- Jiang Yan Xu


On Sept. 15, 2015, 11:51 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> ---
> 
> (Updated Sept. 15, 2015, 11:51 a.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review99061
---



include/mesos/scheduler.hpp (line 272)


Should we even bother adding this to the old API? Note that adding a new 
call to the driver will impose a upgrade dependency between schedulers and 
master (master first, libmesos for scheduler next, scheduler jar last)

more importantly, add a comment here that scheduler should call 
reviveOffers() to resume getting offers.



include/mesos/scheduler/scheduler.proto (line 173)


period at the end. also, does this fit within 80 chars?



src/master/master.cpp (line 1747)


you also need to add a case statement to master/http.cpp.



src/master/master.cpp (line 2542)


s/just ignore/ignoring/


- Vinod Kone


On Sept. 5, 2015, 12:01 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Sept. 5, 2015, 12:01 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/
---

(Updated Sept. 15, 2015, 6:51 p.m.)


Review request for mesos, Timothy Chen and Jiang Yan Xu.


Changes
---

Upload the latest version.


Bugs: MESOS-3432
https://issues.apache.org/jira/browse/MESOS-3432


Repository: mesos


Description
---

Renamed provisioners::path to provisioner::path.


Diffs (updated)
-

  src/slave/containerizer/provisioner/appc/provisioner.cpp 
77f9cbe778785bd93c30eba5dfd7a470d9258661 
  src/slave/containerizer/provisioner/paths.hpp 
5b82591fbe0d1ea48e4b09727424d0547f21adc2 
  src/slave/containerizer/provisioner/paths.cpp 
4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
  src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
  src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
  src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 

Diff: https://reviews.apache.org/r/38408/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 38407: Moved files to prepare for unifying provisioners.

[Jie Yu]

> On Sept. 15, 2015, 6:38 p.m., Jiang Yan Xu wrote:
> > My only concern is whether this should be checked in before 
> > https://reviews.apache.org/r/38137/ as it's already in the review process 
> > for a long time. As long as Tim's OK with it.
> 
> Jie Yu wrote:
> r38137 has to fix problems in the provisioner (which is not updated 
> according to the newest appc provisioner). Having a unified provisioner first 
> should be able to help get rid of many code in that patch.
> 
> Jiang Yan Xu wrote:
> Copying code over is understandably subopitmal but for this to land 
> before https://reviews.apache.org/r/38137/ we also need to unify the store 
> interface in https://reviews.apache.org/r/38137/.
> The Appc store interface should work with Docker as well but we should 
> probably discuss that on a ticket with Tim.

Expecting more patches coming today. It should be done by EOD today.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38407/#review99057
---


On Sept. 15, 2015, 6:07 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38407/
> ---
> 
> (Updated Sept. 15, 2015, 6:07 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved files to prepare for unifying provisioners. See ticket for motivation.
> 
> This is the first patch toward a unified provisioner. Expecting more 
> subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 509256f40ecc1ff5b3a5ce2b380facd153137a18 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 6cfe9fa2971d50f545587b57721f75a981f6d5ed 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1b83a8725b35435531038e37188b4c97189cef03 
>   src/slave/containerizer/provisioner.hpp 
> 9e0e0b8ef290a31b67bd2415253408e811e1c720 
>   src/slave/containerizer/provisioner.cpp 
> 2ac9008243b0dc2ba6051e75c508d183068cebcb 
>   src/slave/containerizer/provisioners/appc/paths.hpp 
> 37bbf090c5358321e0fa66e7287fac888df6f011 
>   src/slave/containerizer/provisioners/appc/paths.cpp 
> e598df090ce55108c68b83dc276e714a4e352939 
>   src/slave/containerizer/provisioners/appc/provisioner.hpp 
> 764b119edf670a44cff4719a2301b1baac88c78a 
>   src/slave/containerizer/provisioners/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioners/appc/spec.hpp 
> 63c79301154a68b58f2437d452025a8839359b12 
>   src/slave/containerizer/provisioners/appc/spec.cpp 
> 15a32578396459151891b462c2b6fdf499a371ea 
>   src/slave/containerizer/provisioners/appc/store.hpp 
> c4ce4b90d71791c7fd558221cb2526b1ff245d3b 
>   src/slave/containerizer/provisioners/appc/store.cpp 
> 33f692c9b7780bdde96fddd8b07a2f4eb3452471 
>   src/slave/containerizer/provisioners/backend.hpp 
> a25b4eaa1894178d4816cfbf1d9da2690bbe24bd 
>   src/slave/containerizer/provisioners/backend.cpp 
> 6560ece14d8618878a35d1bfe27db3958da64358 
>   src/slave/containerizer/provisioners/backends/bind.hpp 
> 61a883898ec170e7a61d04f78650f357de52ff0f 
>   src/slave/containerizer/provisioners/backends/bind.cpp 
> 71861a9c971d12be4d77c8c39e99f2de4746f60f 
>   src/slave/containerizer/provisioners/backends/copy.hpp 
> 2abca37ed2479d42c634c23cac8e40d515249988 
>   src/slave/containerizer/provisioners/backends/copy.cpp 
> b56946562525e79bef3a7387cd71f39fd0690683 
>   src/slave/containerizer/provisioners/docker/registry_client.hpp 
> b5e28587bc9adc2c02805b13fbc5c693612c99fb 
>   src/slave/containerizer/provisioners/docker/registry_client.cpp 
> b262ef031e0373ee009273e50a16d0a58ed83e8e 
>   src/slave/containerizer/provisioners/docker/token_manager.hpp 
> 879269dab9a53192a6d2ddebf20d2cc25effa262 
>   src/slave/containerizer/provisioners/docker/token_manager.cpp 
> aec915f25f6aada0a1d8f22d63a093bdbac97b25 
>   src/slave/containerizer/provisioners/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioners/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/tests/containerizer/appc_provisioner_tests.cpp 
> 8fee7ace4d8207796a5d3fb6d52fc25d002b783d 
>   src/tests/containerizer/docker_provisioner_tests.cpp 
> a3ccbc0fefa38f39e4fa06542c01af42c26df822 
>   src/tests/containerizer/provisioner.hpp 
> a26b8138d8cc3086058b15a797dd15354a84019f 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> f2498b109c910fbf753a53b4b36a88b8d779aa69 
> 
> Diff: https://reviews.apache.org/r/38407/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38407: Moved files to prepare for unifying provisioners.

[Jiang Yan Xu]

> On Sept. 15, 2015, 11:38 a.m., Jiang Yan Xu wrote:
> > My only concern is whether this should be checked in before 
> > https://reviews.apache.org/r/38137/ as it's already in the review process 
> > for a long time. As long as Tim's OK with it.
> 
> Jie Yu wrote:
> r38137 has to fix problems in the provisioner (which is not updated 
> according to the newest appc provisioner). Having a unified provisioner first 
> should be able to help get rid of many code in that patch.

Copying code over is understandably subopitmal but for this to land before 
https://reviews.apache.org/r/38137/ we also need to unify the store interface 
in https://reviews.apache.org/r/38137/.
The Appc store interface should work with Docker as well but we should probably 
discuss that on a ticket with Tim.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38407/#review99057
---


On Sept. 15, 2015, 11:07 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38407/
> ---
> 
> (Updated Sept. 15, 2015, 11:07 a.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
> https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved files to prepare for unifying provisioners. See ticket for motivation.
> 
> This is the first patch toward a unified provisioner. Expecting more 
> subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 509256f40ecc1ff5b3a5ce2b380facd153137a18 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 6cfe9fa2971d50f545587b57721f75a981f6d5ed 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1b83a8725b35435531038e37188b4c97189cef03 
>   src/slave/containerizer/provisioner.hpp 
> 9e0e0b8ef290a31b67bd2415253408e811e1c720 
>   src/slave/containerizer/provisioner.cpp 
> 2ac9008243b0dc2ba6051e75c508d183068cebcb 
>   src/slave/containerizer/provisioners/appc/paths.hpp 
> 37bbf090c5358321e0fa66e7287fac888df6f011 
>   src/slave/containerizer/provisioners/appc/paths.cpp 
> e598df090ce55108c68b83dc276e714a4e352939 
>   src/slave/containerizer/provisioners/appc/provisioner.hpp 
> 764b119edf670a44cff4719a2301b1baac88c78a 
>   src/slave/containerizer/provisioners/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioners/appc/spec.hpp 
> 63c79301154a68b58f2437d452025a8839359b12 
>   src/slave/containerizer/provisioners/appc/spec.cpp 
> 15a32578396459151891b462c2b6fdf499a371ea 
>   src/slave/containerizer/provisioners/appc/store.hpp 
> c4ce4b90d71791c7fd558221cb2526b1ff245d3b 
>   src/slave/containerizer/provisioners/appc/store.cpp 
> 33f692c9b7780bdde96fddd8b07a2f4eb3452471 
>   src/slave/containerizer/provisioners/backend.hpp 
> a25b4eaa1894178d4816cfbf1d9da2690bbe24bd 
>   src/slave/containerizer/provisioners/backend.cpp 
> 6560ece14d8618878a35d1bfe27db3958da64358 
>   src/slave/containerizer/provisioners/backends/bind.hpp 
> 61a883898ec170e7a61d04f78650f357de52ff0f 
>   src/slave/containerizer/provisioners/backends/bind.cpp 
> 71861a9c971d12be4d77c8c39e99f2de4746f60f 
>   src/slave/containerizer/provisioners/backends/copy.hpp 
> 2abca37ed2479d42c634c23cac8e40d515249988 
>   src/slave/containerizer/provisioners/backends/copy.cpp 
> b56946562525e79bef3a7387cd71f39fd0690683 
>   src/slave/containerizer/provisioners/docker/registry_client.hpp 
> b5e28587bc9adc2c02805b13fbc5c693612c99fb 
>   src/slave/containerizer/provisioners/docker/registry_client.cpp 
> b262ef031e0373ee009273e50a16d0a58ed83e8e 
>   src/slave/containerizer/provisioners/docker/token_manager.hpp 
> 879269dab9a53192a6d2ddebf20d2cc25effa262 
>   src/slave/containerizer/provisioners/docker/token_manager.cpp 
> aec915f25f6aada0a1d8f22d63a093bdbac97b25 
>   src/slave/containerizer/provisioners/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioners/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/tests/containerizer/appc_provisioner_tests.cpp 
> 8fee7ace4d8207796a5d3fb6d52fc25d002b783d 
>   src/tests/containerizer/docker_provisioner_tests.cpp 
> a3ccbc0fefa38f39e4fa06542c01af42c26df822 
>   src/tests/containerizer/provisioner.hpp 
> a26b8138d8cc3086058b15a797dd15354a84019f 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> f2498b109c910fbf753a53b4b36a88b8d779aa69 
> 
> Diff: https://reviews.apache.org/r/38407/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/
---

(Updated Sept. 15, 2015, 6:42 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Changes
---

Get protobuf from Github.


Repository: mesos


Description
---

Add CMake macro VsBuildCommand in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
d13ba666740b4f2e382a0b1852724cfd519f8f64 
  3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/37273/diff/


Testing
---


Thanks,

haosdent huang