Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/
---

(Updated Oct. 20, 2015, 12:28 a.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
and Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/38705/diff/


Testing
---

Tested the script with python 2.7.


Thanks,

Artem Harutyunyan

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

[Artem Harutyunyan]

> On Oct. 19, 2015, 1:04 p.m., Vinod Kone wrote:
> > support/apply-reviews.py, lines 49-52
> > 
> >
> > i don't follow what's happening here. you are appending the same 
> >  pair multiple times to the list?

Not exactly, but I refactored this part so it should be clear now.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/#review103147
---


On Oct. 18, 2015, 3:30 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38705/
> ---
> 
> (Updated Oct. 18, 2015, 3:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38705/diff/
> 
> 
> Testing
> ---
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39211: Check for trailing characters in JSON::parse().

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39211/#review103223
---

Ship it!


Sorry for the delay. Just a concern about confusing names and then I'm ready to 
commit.


3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines 744 - 748)


I'm getting confused between `last_char` and `end`, since `end` isn't 
really the `end`. Also, we don't use camel_case. How about: `lastVisibleChar` 
and `parseEnd`? Maybe `parseBegin` too?


- Adam B


On Oct. 13, 2015, 10:51 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39211/
> ---
> 
> (Updated Oct. 13, 2015, 10:51 a.m.)
> 
> 
> Review request for mesos, Adam B and Joseph Wu.
> 
> 
> Bugs: MESOS-3698
> https://issues.apache.org/jira/browse/MESOS-3698
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check for trailing characters in JSON::parse().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 0870300c2d372722b4850155cb2a8e848b986ed5 
>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
> b95667f4c1a1c170016da024a5e4af02ccaa064e 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> 131d39b87e571f16c774a133eb3148e98d8b9dd4 
> 
> Diff: https://reviews.apache.org/r/39211/diff/
> 
> 
> Testing
> ---
> 
> Added tests to make sure that JSON::parse() is successfully returning errors 
> when passed invalid JSON objects. Ran `make check`.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38883/
---

(Updated Oct. 20, 2015, 12:42 a.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/38883/diff/


Testing
---

Tested the script with python 2.7.


Thanks,

Artem Harutyunyan

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

[David Forsythe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39345/
---

(Updated Oct. 20, 2015, 7:45 a.m.)


Review request for mesos and Ian Downes.


Bugs: https://issues.apache.org/jira/browse/MESOS-1563

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

Enable build on FreeBSD, start porting components.

My build steps are:

- Install dependencies from http://mesos.apache.org/gettingstarted/
- Install libexecinfo
- Install clang36 (system clang is 3.4)
- boostrap
- ../configure --with-curl=/usr/local --with-apr=/usr/local 
--with-svn=/usr/local CC=clang36 CXX=clang++36
- gmake CC=clang36 CXX=clang++36
- gmake CC=clang36 CXX=clang++36 check

I disabled one test because I haven't had a chance to debug it and I wanted to 
get a bit further in the test suite. A check run is attached.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 
53e83d4905945593e174601a0b791d01824dc34b 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
dc7c6522b283916b975a77957909f6cdc02944d3 
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
9428717fac4655898d7768957f02937592e1a398 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
e49783a438157706b1be9745436bf666f45cab8b 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
1c776cd2facfb86854c7b2a8fe6be7949b566587 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 
3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
1baf142d53fd06149c80d4b2677c2a976c05ef71 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
e9b05ef3b59fd068137cb12e36591de2d4a801a1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 
0a98e9e310d3931c2341053595b7d62f68214783 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
8a8ede325cfe8f024e1be4db24b0c8118d18f359 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
f16ef1998c9b271b35063a2f07cf1c15d6b8bea0 
  3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 
4cc781bddbf7ee10cc0671f62d710fb4fa80e293 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 
  3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff 
  3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 
  3rdparty/libprocess/src/tests/http_tests.cpp 
d13d3888abbf3db552df4a9f83e54667e598ded9 
  configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9 
  src/Makefile.am 0dc911251ade9c652da7db25a2824b76677499dc 
  src/slave/containerizer/isolators/posix/disk.cpp 
73e62a225da062733557287afa2273d8183d76fd 
  src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 
  src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
  src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 

Diff: https://reviews.apache.org/r/39345/diff/


Testing
---

make check on coreos (I'll get a ubuntu instance for future testing)

gmake check on freebsd 10.2 (failing) (log attached)


File Attachments (updated)


check3.log
  
https://reviews.apache.org/media/uploaded/files/2015/10/20/c6757057-d221-444f-8b61-0f853e568e9e__check3.log


Thanks,

David Forsythe

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
---

(Updated Oct. 20, 2015, 12:45 a.m.)


Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and 
Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

Added '--parent' option and made apply-review.sh call apply-reviews.py.


Diffs (updated)
-

  support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/39420/diff/


Testing
---

Tested with python 2.7.

- with and without '-p'.
- Tested reviews with and without parents.


Thanks,

Artem Harutyunyan

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/
---

(Updated Oct. 20, 2015, 12:45 a.m.)


Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
Massenzio, and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

Added support for github to apply-reviews.py.


Diffs (updated)
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/39410/diff/


Testing
---

Tested with python 2.7


Thanks,

Artem Harutyunyan

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103229
---


Patch looks great!

Reviews applied: [39452]

All tests passed.

- Mesos ReviewBot


On Oct. 19, 2015, 9:07 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 19, 2015, 9:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review103227
---

Ship it!


Worked flawlessly for me the first time! So much simpler now that it's all in 
one repo too. Great work!


support/site-docker/README.md (line 7)


Since you specify `.`, shouldn't you `cd support/site-docker` first?
Otherwise, you could suggest `docker build -t mesos/website 
support/site-docker`
I don't like assuming that they're already in `support/site` just because 
they're reading the README


- Adam B


On Oct. 19, 2015, 5:42 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> ---
> 
> (Updated Oct. 19, 2015, 5:42 p.m.)
> 
> 
> Review request for mesos, Adam B and Dave Lester.
> 
> 
> Bugs: MESOS-3694
> https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/site-docker/Dockerfile PRE-CREATION 
>   support/site-docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39457: Document messages in messages.proto.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39457/#review103218
---



src/messages/messages.proto (line 77)


s/from the agent up to the framework/from the agent to the framework ?



src/messages/messages.proto (lines 123 - 128)


Seems it is OK to remove this as I did not see anyone who is using it.

If this removed, then the master also needs to be updated by removing such 
message.



src/messages/messages.proto (line 139)


s/sent/sends?



src/messages/messages.proto (line 153)


s/sent/sends?



src/messages/messages.proto (line 413)


s/slave/agent and other places?



src/messages/messages.proto (lines 499 - 500)


s/slave/agent



src/messages/messages.proto (line 508)


s/slave/agent



src/messages/messages.proto (line 527)


s/slave/agent



src/messages/messages.proto (line 546)


s/slave/agent



src/messages/messages.proto (line 603)


What about make all of the comments using same tone?

For example:
Notifies the scheduler about terminated executors.

Ditto as following



src/messages/messages.proto (line 640)


Not only the agent but also all of the frameworks on the agent will be 
shutdown, can we put this in the document?



src/messages/messages.proto (line 665)


s/faiure/failure


- Guangya Liu


On 十月 20, 2015, 12:42 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39457/
> ---
> 
> (Updated 十月 20, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3759
> https://issues.apache.org/jira/browse/MESOS-3759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A brief summary of each message was added.  
> 
> For messages with an associated Event/Call API object, a reference to the 
> object was added.
> Additionally, there is a great deal of documentation overlap between these 
> messages and the comments in mesos/scheduler.hpp and 
> v1/scheduler/scheduler.proto.  Where necessary, some notes were added about 
> the backwards compatibility of messages which are not instantiated in the 
> code base.
> 
> 
> Diffs
> -
> 
>   src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 
> 
> Diff: https://reviews.apache.org/r/39457/diff/
> 
> 
> Testing
> ---
> 
> None.  (Comment change only)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38335/#review103231
---


Bad patch!

Reviews applied: [38342, 38335]

Failed command: ./support/apply-review.sh -n -r 38335

Error:
 2015-10-20 08:29:53 URL:https://reviews.apache.org/r/38335/diff/raw/ 
[26873/26873] -> "38335.patch" [1]
Successfully applied: Add JSON::protobuf for google::protobuf::RepeatedPtrField

Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
converts a `google::protobuf::Message` into a `JSON::Object`.
We should add the support for `google::protobuf::RepeatedPtrField` by 
introducing overloaded functions.


Review: https://reviews.apache.org/r/38335
Checking 24 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
src/tests/reservation_endpoints_tests.cpp:830:  Lines should be <= 80 
characters long  [whitespace/line_length] [2]
Total errors found: 1
Failed to commit patch

- Mesos ReviewBot


On Oct. 20, 2015, 5:37 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38335/
> ---
> 
> (Updated Oct. 20, 2015, 5:37 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3405
> https://issues.apache.org/jira/browse/MESOS-3405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
> converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField` by 
> introducing overloaded functions.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp f56d8a1 
>   src/docker/executor.cpp 1e49013 
>   src/examples/persistent_volume_framework.cpp 176ac3d 
>   src/launcher/executor.cpp 50b3c6e 
>   src/master/contender.cpp c641305 
>   src/master/http.cpp 093f793 
>   src/master/maintenance.cpp 5fe9358 
>   src/master/registrar.cpp 1117232 
>   src/slave/containerizer/fetcher.cpp e0d02d5 
>   src/slave/containerizer/mesos/containerizer.cpp d1fc5a4 
>   src/slave/monitor.cpp aa6e958 
>   src/tests/containerizer/launch_tests.cpp de655ec 
>   src/tests/fault_tolerance_tests.cpp f78a291 
>   src/tests/master_maintenance_tests.cpp e89ce3b 
>   src/tests/master_tests.cpp ee24739 
>   src/tests/mesos.hpp 3e58b45 
>   src/tests/mesos.cpp ab2d85b 
>   src/tests/monitor_tests.cpp 583e711 
>   src/tests/reservation_endpoints_tests.cpp f5f9c48 
>   src/tests/resources_tests.cpp 6584fc6 
>   src/tests/scheduler_http_api_tests.cpp d338a1b 
>   src/tests/script.cpp bcc1fab 
>   src/tests/slave_tests.cpp 10a4fa7 
>   src/usage/main.cpp 86fd796 
> 
> Diff: https://reviews.apache.org/r/38335/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 37998: Made ProcessManager::handle() a void returning method.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37998/
---

(Updated Oct. 20, 2015, 10:44 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Rebase to new dependency.


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

`ProcessManager::handle()` is a method used to process HTTP requests, its 
signature returns a boolean which is not used anywhere and it doesn't allow for 
asynchronous operations within handle.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 

Diff: https://reviews.apache.org/r/37998/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39345/#review103232
---


Bad patch!

Reviews applied: [39345]

Failed command: ./support/apply-review.sh -n -r 39345

Error:
 2015-10-20 08:52:33 URL:https://reviews.apache.org/r/39345/diff/raw/ 
[26851/26851] -> "39345.patch" [1]
Successfully applied: Enable build on FreeBSD, start porting components.

Enable build on FreeBSD, start porting components.

My build steps are:

- Install dependencies from http://mesos.apache.org/gettingstarted/
- Install libexecinfo
- Install clang36 (system clang is 3.4)
- boostrap
- ../configure --with-curl=/usr/local --with-apr=/usr/local 
--with-svn=/usr/local CC=clang36 CXX=clang++36
- gmake CC=clang36 CXX=clang++36
- gmake CC=clang36 CXX=clang++36 check

I disabled one test because I haven't had a chance to debug it and I wanted to 
get a bit further in the test suite. A check run is attached.


Review: https://reviews.apache.org/r/39345
Checking 20 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
mesos:
  configure.ac
  src/Makefile.am
  src/slave/containerizer/isolators/posix/disk.cpp
  src/tests/attributes_tests.cpp
  src/tests/resources_tests.cpp
  src/tests/values_tests.cpp
stout:
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
  3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
libprocess:
  3rdparty/libprocess/3rdparty/Makefile.am
  3rdparty/libprocess/configure.ac
  3rdparty/libprocess/src/config.hpp
  3rdparty/libprocess/src/tests/http_tests.cpp
Failed to commit patch

- Mesos ReviewBot


On Oct. 20, 2015, 7:45 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39345/
> ---
> 
> (Updated Oct. 20, 2015, 7:45 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-1563
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable build on FreeBSD, start porting components.
> 
> My build steps are:
> 
> - Install dependencies from http://mesos.apache.org/gettingstarted/
> - Install libexecinfo
> - Install clang36 (system clang is 3.4)
> - boostrap
> - ../configure --with-curl=/usr/local --with-apr=/usr/local 
> --with-svn=/usr/local CC=clang36 CXX=clang++36
> - gmake CC=clang36 CXX=clang++36
> - gmake CC=clang36 CXX=clang++36 check
> 
> I disabled one test because I haven't had a chance to debug it and I wanted 
> to get a bit further in the test suite. A check run is attached.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 53e83d4905945593e174601a0b791d01824dc34b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> dc7c6522b283916b975a77957909f6cdc02944d3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
> 9428717fac4655898d7768957f02937592e1a398 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
> e49783a438157706b1be9745436bf666f45cab8b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 1c776cd2facfb86854c7b2a8fe6be7949b566587 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 
> 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
> 1baf142d53fd06149c80d4b2677c2a976c05ef71 
>   3rdparty/libprocess/3rdparty/stout/

Review Request 39472: Added the helper container InheritanceTree where nodes inherit values from their ancestors.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39472/
---

Review request for mesos, Bernd Mathiske and Till Toenshoff.


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

Introduces the `InheritanceTree` class which allows to create a tree where 
nodes can be tag with some property. This property is then inherited by 
children nodes.

It relates to [r/37996/](https://reviews.apache.org/r/37996/). It moves the 
`InheritanceTree` to the place it will be used in the next review so as to not 
pollute stout. Unit tests cannot be directly performed because now the 
structure has not public visibility so the tests will be execute as integration 
tests in future reviews when the structure is used.


Diffs
-

  3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 

Diff: https://reviews.apache.org/r/39472/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103234
---


Patch looks great!

Reviews applied: [38705, 38883, 39410, 39420]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 7:45 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> ---
> 
> (Updated Oct. 20, 2015, 7:45 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7.
> 
> - with and without '-p'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37999: Implemented http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37999/
---

(Updated Oct. 20, 2015, noon)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Updates to account for changes in previous tests.


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

Introduces the authenticator manager, which is a class which handles the actual 
authentication procedure during the execution of `ProcessManager::handle()` and 
it also takes care of the life cycle of instances of http::Authenticator.

No tests are added at this point since no public API is generated, the goal of 
this patch is to implement the manager and verify nothing breaks afterwards. 
Authenticator manager tests proper come in a latter patch.


Diffs (updated)
-

  3rdparty/libprocess/include/Makefile.am 
fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/event.hpp 
16ddbd77afa6efdf6bad201aa497ee102aa863ae 
  3rdparty/libprocess/include/process/http.hpp 
591c1a959057155e1bf0f5bd73352e78d1c15cb3 
  3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 

Diff: https://reviews.apache.org/r/37999/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38000/
---

(Updated Oct. 20, 2015, 12:09 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Rebasing.


Bugs: MESOS-3233
https://issues.apache.org/jira/browse/MESOS-3233


Repository: mesos


Description
---

Adds functions which allows libprocess users to add handlers which require 
authentication as well as functions to install and remove authenticators.

Includes tests.


Diffs (updated)
-

  3rdparty/libprocess/include/process/process.hpp 
8b086f296c80a43be2edaf496a04dadf0c64251a 
  3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 
  3rdparty/libprocess/src/tests/http_tests.cpp 
d13d3888abbf3db552df4a9f83e54667e598ded9 

Diff: https://reviews.apache.org/r/38000/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/
---

(Updated Oct. 20, 2015, 12:17 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
Toenshoff.


Changes
---

Updating JIRA issue associated.


Bugs: MESOS-3072
https://issues.apache.org/jira/browse/MESOS-3072


Repository: mesos


Description
---

Allows developers to provide their own parameters when loading modules instead 
of using the ones provided by the user when loading Mesos. This helps to deal 
with default modules (those used when the user doesn't provide any), and for 
testing of the modules.


Diffs
-

  src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
  src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 

Diff: https://reviews.apache.org/r/38627/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/
---

(Updated Oct. 20, 2015, 12:18 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
Toenshoff.


Changes
---

Updating dependencies.


Bugs: MESOS-3072
https://issues.apache.org/jira/browse/MESOS-3072


Repository: mesos


Description
---

Allows developers to provide their own parameters when loading modules instead 
of using the ones provided by the user when loading Mesos. This helps to deal 
with default modules (those used when the user doesn't provide any), and for 
testing of the modules.


Diffs
-

  src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
  src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 

Diff: https://reviews.apache.org/r/38627/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38094/#review103235
---



3rdparty/libprocess/src/authenticator.cpp (lines 81 - 84)


Let's stick to non doxygen format style for those.


- Till Toenshoff


On Sept. 30, 2015, 8:21 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38094/
> ---
> 
> (Updated Sept. 30, 2015, 8:21 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3232
> https://issues.apache.org/jira/browse/MESOS-3232
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
>   3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
>   3rdparty/libprocess/src/CMakeLists.txt 
> fb9bd04832779ac43151f2feb3dfbf58cb996434 
>   3rdparty/libprocess/src/authenticator.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> c380f356548cf9f5491044bccabcd9c66ad5f55a 
> 
> Diff: https://reviews.apache.org/r/38094/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
---

(Updated Oct. 20, 2015, 12:25 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.


Changes
---

Updating JIRA ticket and dependencies.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

Adds support for modularization of HTTP Authenticators. 

It includes an example of how to do it with the Basic HTTP Authenticator.


Diffs
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
PRE-CREATION 
  include/mesos/module/http_authenticator.hpp PRE-CREATION 
  src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d 
  src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e 
  src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
  src/examples/test_http_authenticator_module.cpp PRE-CREATION 
  src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
  src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
  src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69 
  src/tests/http_authentication_tests.cpp PRE-CREATION 
  src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
  src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f 

Diff: https://reviews.apache.org/r/38950/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/
---

(Updated Oct. 20, 2015, 12:30 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
Toenshoff.


Changes
---

Rebase. Updated JIRA entry.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

1. Adds a flag to load an HTTP Authenticator module from the flags.
2. If provided, uses the credentials file to initialize the default HTTP 
Authenticator.
3. Updates the existing endpoints which implement their own basic HTTP 
authenticator with the libprocess one.
4. Updates one test which expected the wrong results since now credentials are 
checked before the body of the request.


Diffs (updated)
-

  src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
  src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
  src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
  src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
  src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 

Diff: https://reviews.apache.org/r/39043/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review103238
---


Patch looks great!

Reviews applied: [39472, 39276, 37998, 37999, 38000, 38094, 38627, 38950, 39043]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 10:30 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Oct. 20, 2015, 10:30 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
>   src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
>   src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
>   src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38094/
---

(Updated Oct. 20, 2015, 2:07 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Fixes Till's issue.


Bugs: MESOS-3232
https://issues.apache.org/jira/browse/MESOS-3232


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am 404a7438e7cd53d9295fe6025b5af5fb83df939b 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/src/CMakeLists.txt 
fb9bd04832779ac43151f2feb3dfbf58cb996434 
  3rdparty/libprocess/src/authenticator.cpp PRE-CREATION 
  3rdparty/libprocess/src/tests/http_tests.cpp 
d13d3888abbf3db552df4a9f83e54667e598ded9 

Diff: https://reviews.apache.org/r/38094/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

[Alexander Rojas]

> On Oct. 12, 2015, 2:54 p.m., Marco Massenzio wrote:
> > src/tests/module.hpp, lines 76-77
> > 
> >
> > same comment here - it would be great to have fully-documented, 
> > properly-formatted javadoc here, also explaining what could go into 
> > `parameters` how will this affect creating the module, etc.
> > 
> > while this may all appear obvious to you, it may not be so to external 
> > developers using this code to launch/test modules.
> > 
> > thanks!

Hey Marco. You're wrong saying that external developers will have to use any of 
this functions, they are use only internally. There are also a lot of examples 
on how to write modules, if you look in the 
[src/examples](https://github.com/apache/mesos/tree/bb8409882c1e1b5c7eea2a4528f5d3d33dc639b1/src/examples)
 directory, all the files with suffix `_module.cpp` show how to write modules. 
More documentation on the matter can be found at 
[modules.md](https://github.com/apache/mesos/blob/bb8409882c1e1b5c7eea2a4528f5d3d33dc639b1/docs/modules.md).

I however see your point on the need of documentation for the `ModuleManager` 
and I created the JIRA MESOS-3767 which addresses that. I don't add it in this 
patch, because this patch creates overloads of existing methods and uses the 
same documentation of the previous ones. In order to keep the changes localize 
to what concerns this patch, we agree with my shepherd to add the relevant 
documentation in a future patch.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/#review102245
---


On Oct. 20, 2015, 12:18 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38627/
> ---
> 
> (Updated Oct. 20, 2015, 12:18 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3072
> https://issues.apache.org/jira/browse/MESOS-3072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allows developers to provide their own parameters when loading modules 
> instead of using the ones provided by the user when loading Mesos. This helps 
> to deal with default modules (those used when the user doesn't provide any), 
> and for testing of the modules.
> 
> 
> Diffs
> -
> 
>   src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
> 
> Diff: https://reviews.apache.org/r/38627/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/
---

(Updated Oct. 20, 2015, 3:52 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
Toenshoff.


Changes
---

Adds unit tests of overrided methods.


Bugs: MESOS-3072
https://issues.apache.org/jira/browse/MESOS-3072


Repository: mesos


Description
---

Allows developers to provide their own parameters when loading modules instead 
of using the ones provided by the user when loading Mesos. This helps to deal 
with default modules (those used when the user doesn't provide any), and for 
testing of the modules.


Diffs (updated)
-

  src/examples/example_module_impl.cpp db015cea130701a4e0a6fcb890c79fbb0c02c1ce 
  src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 
  src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
  src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
  src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 

Diff: https://reviews.apache.org/r/38627/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39386/#review103255
---

Ship it!


Ship It!

- Timothy Chen


On Oct. 19, 2015, 2:59 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39386/
> ---
> 
> (Updated Oct. 19, 2015, 2:59 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3738
> https://issues.apache.org/jira/browse/MESOS-3738
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix uncorrect launcher dir in docker executor.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 9443d5fc2de0f46f9e117b08e29b09ff3a4579c6 
>   src/docker/executor.hpp 8ab4e98c41017e8420b98c63a59d8e4bc1a99172 
>   src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
> 
> Diff: https://reviews.apache.org/r/39386/diff/
> 
> 
> Testing
> ---
> 
> * make check
> * make install and then test with marathon to check if launcher_dir passes 
> correctly.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39472: Added the helper container InheritanceTree where nodes inherit values from their ancestors.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39472/
---

(Updated Oct. 20, 2015, 4:24 p.m.)


Review request for mesos, Bernd Mathiske and Till Toenshoff.


Changes
---

Added documentation.


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

Introduces the `InheritanceTree` class which allows to create a tree where 
nodes can be tag with some property. This property is then inherited by 
children nodes.

It relates to [r/37996/](https://reviews.apache.org/r/37996/). It moves the 
`InheritanceTree` to the place it will be used in the next review so as to not 
pollute stout. Unit tests cannot be directly performed because now the 
structure has not public visibility so the tests will be execute as integration 
tests in future reviews when the structure is used.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 

Diff: https://reviews.apache.org/r/39472/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39211: Check for trailing characters in JSON::parse().

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39211/
---

(Updated Oct. 20, 2015, 4:22 p.m.)


Review request for mesos, Adam B and Joseph Wu.


Changes
---

Addressed comments.


Bugs: MESOS-3698
https://issues.apache.org/jira/browse/MESOS-3698


Repository: mesos


Description
---

Check for trailing characters in JSON::parse().


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
0870300c2d372722b4850155cb2a8e848b986ed5 
  3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
b95667f4c1a1c170016da024a5e4af02ccaa064e 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
131d39b87e571f16c774a133eb3148e98d8b9dd4 

Diff: https://reviews.apache.org/r/39211/diff/


Testing
---

Added tests to make sure that JSON::parse() is successfully returning errors 
when passed invalid JSON objects. Ran `make check`.


Thanks,

Greg Mann

Re: Review Request 39211: Check for trailing characters in JSON::parse().

[Greg Mann]

> On Oct. 20, 2015, 7:28 a.m., Adam B wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, lines 744-748
> > 
> >
> > I'm getting confused between `last_char` and `end`, since `end` isn't 
> > really the `end`. Also, we don't use camel_case. How about: 
> > `lastVisibleChar` and `parseEnd`? Maybe `parseBegin` too?

Yea good call, I like your suggested names. Thanks!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39211/#review103223
---


On Oct. 20, 2015, 4:22 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39211/
> ---
> 
> (Updated Oct. 20, 2015, 4:22 p.m.)
> 
> 
> Review request for mesos, Adam B and Joseph Wu.
> 
> 
> Bugs: MESOS-3698
> https://issues.apache.org/jira/browse/MESOS-3698
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check for trailing characters in JSON::parse().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 0870300c2d372722b4850155cb2a8e848b986ed5 
>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
> b95667f4c1a1c170016da024a5e4af02ccaa064e 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> 131d39b87e571f16c774a133eb3148e98d8b9dd4 
> 
> Diff: https://reviews.apache.org/r/39211/diff/
> 
> 
> Testing
> ---
> 
> Added tests to make sure that JSON::parse() is successfully returning errors 
> when passed invalid JSON objects. Ran `make check`.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Marco Massenzio]

> On Oct. 19, 2015, 10:34 p.m., Anand Mazumdar wrote:
> > docs/scheduler-http-api.md, line 44
> > 
> >
> > Nit: Can we just check for `200` here (since the response from 
> > `Subscribe` should be `200` for a good response ?

we removed this code


> On Oct. 19, 2015, 10:34 p.m., Anand Mazumdar wrote:
> > docs/scheduler-http-api.md, line 51
> > 
> >
> > Is `int(...)` in python unsigned and 64 bytes ? That is the 
> > requirements we mention in our docs.

no (signed) and yes (64 bits - not bytes :) - but that's now largely 
irrelevant, as we removed the code.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103172
---


On Oct. 19, 2015, 9:07 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 19, 2015, 9:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39472: Added the helper container InheritanceTree where nodes inherit values from their ancestors.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39472/#review103266
---

Ship it!


This code has already been reviewed in this RR: 
https://reviews.apache.org/r/37996/
The conclusion was that it needs to be moved out of stout to where it is going 
to be used.
So we are going with that.

- Bernd Mathiske


On Oct. 20, 2015, 7:24 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39472/
> ---
> 
> (Updated Oct. 20, 2015, 7:24 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
> 
> 
> Bugs: MESOS-3231
> https://issues.apache.org/jira/browse/MESOS-3231
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduces the `InheritanceTree` class which allows to create a tree where 
> nodes can be tag with some property. This property is then inherited by 
> children nodes.
> 
> It relates to [r/37996/](https://reviews.apache.org/r/37996/). It moves the 
> `InheritanceTree` to the place it will be used in the next review so as to 
> not pollute stout. Unit tests cannot be directly performed because now the 
> structure has not public visibility so the tests will be execute as 
> integration tests in future reviews when the structure is used.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 954d31424bc8f8ecfa78b80513c480f2514ec271 
> 
> Diff: https://reviews.apache.org/r/39472/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

(Updated Oct. 20, 2015, 4:34 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs (updated)
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing
---


Thanks,

Marco Massenzio

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103267
---

Ship it!



docs/scheduler-http-api.md (line 36)


s/In more formal terms/As per ABNF-based grammar



docs/scheduler-http-api.md (line 66)


Do we need this line anymore now ? This can be killed in favor of the 
following lines that we added around why RecordIO was needed.


- Anand Mazumdar


On Oct. 20, 2015, 4:34 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 20, 2015, 4:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39484/
---

Review request for mesos, Michael Park and Timothy Chen.


Bugs: MESOS-3113
https://issues.apache.org/jira/browse/MESOS-3113


Repository: mesos


Description
---

Add resource usage section to MesosContainerizer and DockerContainerizer 
documentation


Diffs
-

  docs/containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
  docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 

Diff: https://reviews.apache.org/r/39484/diff/


Testing
---

Github gist


Thanks,

Gilbert Song

Re: Review Request 39211: Check for trailing characters in JSON::parse().

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39211/
---

(Updated Oct. 20, 2015, 5:13 p.m.)


Review request for mesos, Adam B and Joseph Wu.


Changes
---

Adjusted index.


Bugs: MESOS-3698
https://issues.apache.org/jira/browse/MESOS-3698


Repository: mesos


Description
---

Check for trailing characters in JSON::parse().


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
0870300c2d372722b4850155cb2a8e848b986ed5 
  3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
b95667f4c1a1c170016da024a5e4af02ccaa064e 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
131d39b87e571f16c774a133eb3148e98d8b9dd4 

Diff: https://reviews.apache.org/r/39211/diff/


Testing
---

Added tests to make sure that JSON::parse() is successfully returning errors 
when passed invalid JSON objects. Ran `make check`.


Thanks,

Greg Mann

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103276
---


Patch looks great!

Reviews applied: [39452]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 4:34 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 20, 2015, 4:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39457: Document messages in messages.proto.

[Joseph Wu]

> On Oct. 20, 2015, 1:23 a.m., Guangya Liu wrote:
> >

For now, I'll keep "agent".  I'm fairly certain we refer to agents as agents 
now.


> On Oct. 20, 2015, 1:23 a.m., Guangya Liu wrote:
> > src/messages/messages.proto, lines 132-137
> > 
> >
> > Seems it is OK to remove this as I did not see anyone who is using it.
> > 
> > If this removed, then the master also needs to be updated by removing 
> > such message.

There are quite a few messages in this file that no longer *appear* to be used 
(mentioned in the review description).  I need to check with someone (i.e. 
BenH) to know if it is really not being used.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39457/#review103218
---


On Oct. 19, 2015, 5:42 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39457/
> ---
> 
> (Updated Oct. 19, 2015, 5:42 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3759
> https://issues.apache.org/jira/browse/MESOS-3759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A brief summary of each message was added.  
> 
> For messages with an associated Event/Call API object, a reference to the 
> object was added.
> Additionally, there is a great deal of documentation overlap between these 
> messages and the comments in mesos/scheduler.hpp and 
> v1/scheduler/scheduler.proto.  Where necessary, some notes were added about 
> the backwards compatibility of messages which are not instantiated in the 
> code base.
> 
> 
> Diffs
> -
> 
>   src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 
> 
> Diff: https://reviews.apache.org/r/39457/diff/
> 
> 
> Testing
> ---
> 
> None.  (Comment change only)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39457: Document messages in messages.proto.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39457/
---

(Updated Oct. 20, 2015, 10:26 a.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
---

Standardized to present tense.  Addressed comments, except for s/agent/slave/.


Bugs: MESOS-3759
https://issues.apache.org/jira/browse/MESOS-3759


Repository: mesos


Description
---

A brief summary of each message was added.  

For messages with an associated Event/Call API object, a reference to the 
object was added.
Additionally, there is a great deal of documentation overlap between these 
messages and the comments in mesos/scheduler.hpp and 
v1/scheduler/scheduler.proto.  Where necessary, some notes were added about the 
backwards compatibility of messages which are not instantiated in the code base.


Diffs (updated)
-

  src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 

Diff: https://reviews.apache.org/r/39457/diff/


Testing
---

None.  (Comment change only)


Thanks,

Joseph Wu

Re: Review Request 39331: Support docker local store pull image simultaneously

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39331/
---

(Updated Oct. 20, 2015, 10:48 a.m.)


Review request for Anand Mazumdar, Jojy Varghese and Timothy Chen.


Bugs: MESOS-3736
https://issues.apache.org/jira/browse/MESOS-3736


Repository: mesos


Description
---

Support docker local store pull image simultaneously


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
2b2de5245bccbd01a856b214ac6525278d794537 
  src/slave/containerizer/provisioner/docker/store.cpp 
50340131d10222ac06cf21e87ad46943f171d1f6 
  src/tests/containerizer/provisioner_docker_tests.cpp 
01d3025f59d4a2714a856fe0f3a57192be023990 

Diff: https://reviews.apache.org/r/39331/diff/


Testing (updated)
---

make check (ubuntu14.04 + clang-3.6)

*This is not ready to be merged.
*Still considering two question:
 1. Handling simultaneous failure. If the first request is called and is 
written into the hashmap. All the other requests will be waiting for the future 
of the first request. But because its return type is 'Future>', 
if its future status is 'FAILED/DISCARDED', the other requests will be waiting 
forever. 
 2. The current hashmap uses 'stringify(image::name)' as key, but it may not be 
unique because there is chance that layer_ids can be changed. One solution is 
to have 'stringify(image)' as key.


Thanks,

Gilbert Song

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39484/#review103288
---


Patch looks great!

Reviews applied: [39484]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 4:45 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39484/
> ---
> 
> (Updated Oct. 20, 2015, 4:45 p.m.)
> 
> 
> Review request for mesos, Michael Park and Timothy Chen.
> 
> 
> Bugs: MESOS-3113
> https://issues.apache.org/jira/browse/MESOS-3113
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add resource usage section to MesosContainerizer and DockerContainerizer 
> documentation
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 
> 
> Diff: https://reviews.apache.org/r/39484/diff/
> 
> 
> Testing
> ---
> 
> Github gist
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38094/#review103291
---


Sorry for not finding the below in the first pass ...


3rdparty/libprocess/src/authenticator.cpp (line 30)


Add blank line.



3rdparty/libprocess/src/authenticator.cpp (line 37)


Add blank line.



3rdparty/libprocess/src/authenticator.cpp (line 78)


Add blank line.



3rdparty/libprocess/src/authenticator.cpp (line 87)


Add blank line.



3rdparty/libprocess/src/authenticator.cpp (line 92)


Add blank line.


- Till Toenshoff


On Oct. 20, 2015, 12:07 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38094/
> ---
> 
> (Updated Oct. 20, 2015, 12:07 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3232
> https://issues.apache.org/jira/browse/MESOS-3232
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am 404a7438e7cd53d9295fe6025b5af5fb83df939b 
>   3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
>   3rdparty/libprocess/src/CMakeLists.txt 
> fb9bd04832779ac43151f2feb3dfbf58cb996434 
>   3rdparty/libprocess/src/authenticator.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> d13d3888abbf3db552df4a9f83e54667e598ded9 
> 
> Diff: https://reviews.apache.org/r/38094/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Review Request 39490: Always create non-IP egress filters

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39490/
---

Review request for mesos, Ian Downes and Jie Yu.


Repository: mesos


Description
---

When rolling out the new flag --egress_unique_flow_per_container, I noticed, on 
some slaves, only IP egress filters were created as expected, the reset were 
not. Looking at the code, it looks like we skipped the creation if this is not 
the first container we create, this is wrong for this case, because egress 
filters were not created for previous containers yet. We should always create 
them and ignore error if they exist.


Diffs
-

  src/slave/containerizer/isolators/network/port_mapping.cpp 
e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 

Diff: https://reviews.apache.org/r/39490/diff/


Testing
---

Manual tests


Thanks,

Cong Wang

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39429/#review103292
---

Ship it!



3rdparty/libprocess/include/process/owned.hpp (lines 202 - 203)


In libprocess we use `snake_case`.
You can also consider removing the temporary. I'm fine either way as it 
serves as documentation. If you keep the temporary can you make it `const`? :-D



3rdparty/libprocess/include/process/shared.hpp (lines 171 - 172)


`snake_case` for libprocess.


- Joris Van Remoortere


On Oct. 19, 2015, 4:48 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39429/
> ---
> 
> (Updated Oct. 19, 2015, 4:48 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3326
> https://issues.apache.org/jira/browse/MESOS-3326
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-3326. We adopted std::atomic in most of the code base earlier 
> (commits
> 87de003c6e8a, 4b938052b6af, and 4a01850c5540), but a few places were omitted;
> those locations are fixed by this commit.
> 
> There's one last place to fix: we use the GCC intrinsic __sync_synchronize() 
> in
> 3rdparty/libprocess/include/process/logging.h. Because that is used to protect
> modifications to the FLAGS_v variable defined by glog, we can't easily adapt 
> it
> to use std::atomic.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/owned.hpp 
> 17c42614155fed8fec185f29f9a9babb71ff5f85 
>   3rdparty/libprocess/include/process/shared.hpp 
> 021807b961bb55f11c9e04327135bd83f4d86c21 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> a3c57a261c09f7b76b78225719e64a26f2d66cd3 
> 
> Diff: https://reviews.apache.org/r/39429/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38877/
---

(Updated Oct. 20, 2015, 7:06 p.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
---

Not send back a ShutDown() to the executor upon a retry subscribe request but 
just close the existing connection as per discussion with BenM.


Bugs: MESOS-3515
https://issues.apache.org/jira/browse/MESOS-3515


Repository: mesos


Description
---

This change adds the functionality for executors to `Subscribe` via the 
`api/v1/executor` endpoint. It also stores a marker file as part of the 
`Subscribe` call if framework `checkpointing` is enabled. This can then be used 
by the agent when recovering to wait for reconnecting back with the executor.

Since `Call::Update` is in progress as part of MESOS-3476. I have added a 
`CHECK` if a executor tries to send a list of unacknowledged tasks as part of 
the `Subscribe` call.


Diffs (updated)
-

  src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
  src/slave/slave.hpp d6e417b1ddde44a557e1e7fb3d22b4fd5bd0d526 
  src/slave/slave.cpp cb2d715d100bcfc76d80663ad13504bd278f1200 

Diff: https://reviews.apache.org/r/38877/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39463/#review103293
---


It might be worth splitting out the "logical" changes from the textual.
As in the dispatch and test position variable.
Otherwise we should update the commit message as that is not all that is 
happening in this patch.


src/log/replica.cpp (line 101)


`The update will *be* persisted to` ?


- Joris Van Remoortere


On Oct. 19, 2015, 11:25 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39463/
> ---
> 
> (Updated Oct. 19, 2015, 11:25 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and 
> Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typos in log messages and comments in replicated log code.
> 
> 
> Diffs
> -
> 
>   src/log/consensus.cpp 59f80d02d1d3c11683631f3fc5f6e923b5ebdf96 
>   src/log/coordinator.cpp 5500bca77f3020e0051010c5c178a20a3c7ad44a 
>   src/log/replica.hpp 33d3f1d9e89035936c67739898e73a06b391fcd0 
>   src/log/replica.cpp 75d39ff56822bf00fce9daf5c1e3befb75f2e039 
>   src/state/log.cpp a75a605a4b0edb8863a3378e2133df7d6eb1cc3d 
>   src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e 
>   src/tests/slave_tests.cpp 10a4fa7eaa8e868ccc6d60ac220d66a4f0a523b4 
> 
> Diff: https://reviews.apache.org/r/39463/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39381: CMake: Added protobuf and `slave/flags.cpp` to Windows builds.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39381/#review103296
---


This review is no longer necessary.

- Joris Van Remoortere


On Oct. 19, 2015, 11:27 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39381/
> ---
> 
> (Updated Oct. 19, 2015, 11:27 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3610
> https://issues.apache.org/jira/browse/MESOS-3610
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added protobuf and `slave/flags.cpp` to Windows builds.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41 
> 
> Diff: https://reviews.apache.org/r/39381/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/
---

(Updated Oct. 20, 2015, 7:20 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
e64aa6baeab9d816bb42242e3c9234d4da80f401 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
1c776cd2facfb86854c7b2a8fe6be7949b566587 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
f16ef1998c9b271b35063a2f07cf1c15d6b8bea0 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
eaeed7393b1c44f04737e18cd90a6fc292aa061d 

Diff: https://reviews.apache.org/r/39382/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39381: CMake: Added protobuf and `slave/flags.cpp` to Windows builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39381/
---

(Updated Oct. 20, 2015, 7:21 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3610
https://issues.apache.org/jira/browse/MESOS-3610


Repository: mesos


Description
---

CMake: Added protobuf and `slave/flags.cpp` to Windows builds.


Diffs
-

  src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41 

Diff: https://reviews.apache.org/r/39381/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39457: Document messages in messages.proto.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39457/#review103297
---


Patch looks great!

Reviews applied: [39457]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 5:26 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39457/
> ---
> 
> (Updated Oct. 20, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3759
> https://issues.apache.org/jira/browse/MESOS-3759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A brief summary of each message was added.  
> 
> For messages with an associated Event/Call API object, a reference to the 
> object was added.
> Additionally, there is a great deal of documentation overlap between these 
> messages and the comments in mesos/scheduler.hpp and 
> v1/scheduler/scheduler.proto.  Where necessary, some notes were added about 
> the backwards compatibility of messages which are not instantiated in the 
> code base.
> 
> 
> Diffs
> -
> 
>   src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 
> 
> Diff: https://reviews.apache.org/r/39457/diff/
> 
> 
> Testing
> ---
> 
> None.  (Comment change only)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39378: Windows: Added support for `process/subprocess.hpp`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39378/#review103279
---

Ship it!


- Joris Van Remoortere


On Oct. 19, 2015, 11:31 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39378/
> ---
> 
> (Updated Oct. 19, 2015, 11:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3649 and MESOS-3680
> https://issues.apache.org/jira/browse/MESOS-3649
> https://issues.apache.org/jira/browse/MESOS-3680
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added support for `process/subprocess.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> d2341a53aac7c779668ee80983f73158fd44bff5 
> 
> Diff: https://reviews.apache.org/r/39378/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39377: Windows: Add Windows support to `process/socket.hpp`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39377/#review103273
---

Ship it!



3rdparty/libprocess/include/process/socket.hpp (lines 30 - 32)


I think elsewhere we didn't leave a new line here?



3rdparty/libprocess/src/poll_socket.cpp (lines 17 - 18)


we usually include `stout` after `process` right?


- Joris Van Remoortere


On Oct. 19, 2015, 11:26 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39377/
> ---
> 
> (Updated Oct. 19, 2015, 11:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3628, MESOS-3649 and MESOS-3656
> https://issues.apache.org/jira/browse/MESOS-3628
> https://issues.apache.org/jira/browse/MESOS-3649
> https://issues.apache.org/jira/browse/MESOS-3656
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Add Windows support to `process/socket.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/socket.hpp 
> 4b2597f617fc4072144c9666a378d4ffad53a592 
>   3rdparty/libprocess/src/poll_socket.cpp 
> 28ed102972a9d8f88048aea4046ed837b6a25b35 
> 
> Diff: https://reviews.apache.org/r/39377/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39375: Windows: Introduced socket flag interop.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39375/#review103272
---

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line 83)


Can this be a constexpr?


- Joris Van Remoortere


On Oct. 19, 2015, 11:25 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39375/
> ---
> 
> (Updated Oct. 19, 2015, 11:25 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> POSIX has a bunch of flags like `SHUT_SD` which let you do things like
> specify (e.g.) how a socket shuts down. Windows has equivalents for many
> of these flags as well, but they have different names.
> 
> So that we can avoid changing any of the socket code, we alias the flags
> we know we need with their POSIX names.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 4a0761f4bdd6a881429cb25d0a5f6e445da405cb 
> 
> Diff: https://reviews.apache.org/r/39375/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39376: Windows: Prepared agent for Windows support of `process/socket.hpp`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39376/#review103275
---

Ship it!


- Joris Van Remoortere


On Oct. 19, 2015, 11:25 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39376/
> ---
> 
> (Updated Oct. 19, 2015, 11:25 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In particular, we will remove the inclusion of `stout/os.hpp` from
> `process/socket.hpp`, which will cause  a couple of files to break. Our
> solution to this problem is to include `os.hpp` directly in those files.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a 
>   src/slave/containerizer/composing.cpp 
> 8c3a2353999523ef055332320443931b61843d21 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 6f49e5ac77ab03248127a607664c8f895be72877 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> 471783d88b73b62afacac3d7952ebb5d5f442097 
>   src/zookeeper/zookeeper.cpp e44403ee91904415471382dfa4e0a6e0adfdb74f 
> 
> Diff: https://reviews.apache.org/r/39376/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39379: Windows: Prepared agent for Windows changes to `stout/flags/flags.hpp`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39379/#review103280
---

Ship it!


- Joris Van Remoortere


On Oct. 19, 2015, 11:27 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39379/
> ---
> 
> (Updated Oct. 19, 2015, 11:27 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When we remove the line that includes `stout/os.hpp` from
> `stout/flags/flags.hpp`, it will break `slave/launcher.cpp`. Our
> solution is to directly include the parts of `os.hpp` that are relevant
> to the launcher.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/posix.hpp 
> ee9d275e7fe5fc22c1bab86dd0a558cc8ab9044e 
>   src/slave/containerizer/launcher.cpp 
> 6649d35ec593d264e8508a8195f2470f05888c0a 
> 
> Diff: https://reviews.apache.org/r/39379/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/#review103283
---

Ship it!


I added a patch before this similar to the other "prepare..." patches to make 
sure mesos still compiles.


3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp (line 17)


`string`
`stdio.h`
`stout/error.hpp`


- Joris Van Remoortere


On Oct. 20, 2015, 7:20 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39382/
> ---
> 
> (Updated Oct. 20, 2015, 7:20 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> e64aa6baeab9d816bb42242e3c9234d4da80f401 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 1c776cd2facfb86854c7b2a8fe6be7949b566587 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> f16ef1998c9b271b35063a2f07cf1c15d6b8bea0 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> eaeed7393b1c44f04737e18cd90a6fc292aa061d 
> 
> Diff: https://reviews.apache.org/r/39382/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39380: Windows: Added support for `stout/flags/flags.hpp`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39380/#review103281
---

Ship it!


- Joris Van Remoortere


On Oct. 19, 2015, 11:27 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39380/
> ---
> 
> (Updated Oct. 19, 2015, 11:27 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added support for `stout/flags/flags.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> b91318cfd5748b3387bb6b32b910f327853274dd 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
> e34ed78386130a1e757be1b1f1a2dbf794b7cd37 
> 
> Diff: https://reviews.apache.org/r/39380/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38978: Add post-rewrite hook.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38978/#review103299
---

Ship it!


Thanks so much haosdent!
This will save many people hours of trouble :-)
I'm going to add in the exit behavior similar to the pre-commit hook that vinod 
updated.


support/hooks/post-rewrite (lines 21 - 29)


I just touched up these comments.


- Joris Van Remoortere


On Oct. 14, 2015, 5:10 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38978/
> ---
> 
> (Updated Oct. 14, 2015, 5:10 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2953
> https://issues.apache.org/jira/browse/MESOS-2953
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add post-rewrite hook.
> 
> 
> Diffs
> -
> 
>   bootstrap 779b33cdcb88b2417769bb046a17b47cd6042f2d 
>   support/hooks/post-rewrite PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38978/diff/
> 
> 
> Testing
> ---
> 
> test manually
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39463/
---

(Updated Oct. 20, 2015, 8:10 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Timothy 
Chen.


Repository: mesos


Description (updated)
---

Fixed typos in log messages and comments; minor code/style cleanup.

Mostly in the replicated log code.


Diffs (updated)
-

  src/Makefile.am 0dc911251ade9c652da7db25a2824b76677499dc 
  src/log/consensus.cpp 59f80d02d1d3c11683631f3fc5f6e923b5ebdf96 
  src/log/coordinator.cpp 5500bca77f3020e0051010c5c178a20a3c7ad44a 
  src/log/replica.hpp 33d3f1d9e89035936c67739898e73a06b391fcd0 
  src/log/replica.cpp 75d39ff56822bf00fce9daf5c1e3befb75f2e039 
  src/state/log.cpp a75a605a4b0edb8863a3378e2133df7d6eb1cc3d 
  src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e 
  src/tests/slave_tests.cpp 10a4fa7eaa8e868ccc6d60ac220d66a4f0a523b4 

Diff: https://reviews.apache.org/r/39463/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

[Neil Conway]

> On Oct. 20, 2015, 7:13 p.m., Joris Van Remoortere wrote:
> > It might be worth splitting out the "logical" changes from the textual.
> > As in the dispatch and test position variable.
> > Otherwise we should update the commit message as that is not all that is 
> > happening in this patch.

I revised the commit message. Happy to split into more commits if you'd prefer.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39463/#review103293
---


On Oct. 19, 2015, 11:25 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39463/
> ---
> 
> (Updated Oct. 19, 2015, 11:25 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and 
> Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typos in log messages and comments in replicated log code.
> 
> 
> Diffs
> -
> 
>   src/log/consensus.cpp 59f80d02d1d3c11683631f3fc5f6e923b5ebdf96 
>   src/log/coordinator.cpp 5500bca77f3020e0051010c5c178a20a3c7ad44a 
>   src/log/replica.hpp 33d3f1d9e89035936c67739898e73a06b391fcd0 
>   src/log/replica.cpp 75d39ff56822bf00fce9daf5c1e3befb75f2e039 
>   src/state/log.cpp a75a605a4b0edb8863a3378e2133df7d6eb1cc3d 
>   src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e 
>   src/tests/slave_tests.cpp 10a4fa7eaa8e868ccc6d60ac220d66a4f0a523b4 
> 
> Diff: https://reviews.apache.org/r/39463/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39429/
---

(Updated Oct. 20, 2015, 8:18 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-3326
https://issues.apache.org/jira/browse/MESOS-3326


Repository: mesos


Description
---

See MESOS-3326. We adopted std::atomic in most of the code base earlier (commits
87de003c6e8a, 4b938052b6af, and 4a01850c5540), but a few places were omitted;
those locations are fixed by this commit.

There's one last place to fix: we use the GCC intrinsic __sync_synchronize() in
3rdparty/libprocess/include/process/logging.h. Because that is used to protect
modifications to the FLAGS_v variable defined by glog, we can't easily adapt it
to use std::atomic.


Diffs (updated)
-

  3rdparty/libprocess/include/process/owned.hpp 
17c42614155fed8fec185f29f9a9babb71ff5f85 
  3rdparty/libprocess/include/process/shared.hpp 
021807b961bb55f11c9e04327135bd83f4d86c21 
  3rdparty/libprocess/src/tests/process_tests.cpp 
a3c57a261c09f7b76b78225719e64a26f2d66cd3 

Diff: https://reviews.apache.org/r/39429/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

[Neil Conway]

> On Oct. 20, 2015, 7 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/owned.hpp, lines 202-203
> > 
> >
> > In libprocess we use `snake_case`.
> > You can also consider removing the temporary. I'm fine either way as it 
> > serves as documentation. If you keep the temporary can you make it `const`? 
> > :-D

Woah, I had no idea we use snake_case in libprocess. I think we should add this 
to the style guide. Also I notice a few places (mostly test code, plus 
src/time.cpp) that don't use snake_case. Is it worth fixing these?


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39429/#review103292
---


On Oct. 20, 2015, 8:18 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39429/
> ---
> 
> (Updated Oct. 20, 2015, 8:18 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3326
> https://issues.apache.org/jira/browse/MESOS-3326
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-3326. We adopted std::atomic in most of the code base earlier 
> (commits
> 87de003c6e8a, 4b938052b6af, and 4a01850c5540), but a few places were omitted;
> those locations are fixed by this commit.
> 
> There's one last place to fix: we use the GCC intrinsic __sync_synchronize() 
> in
> 3rdparty/libprocess/include/process/logging.h. Because that is used to protect
> modifications to the FLAGS_v variable defined by glog, we can't easily adapt 
> it
> to use std::atomic.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/owned.hpp 
> 17c42614155fed8fec185f29f9a9babb71ff5f85 
>   3rdparty/libprocess/include/process/shared.hpp 
> 021807b961bb55f11c9e04327135bd83f4d86c21 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> a3c57a261c09f7b76b78225719e64a26f2d66cd3 
> 
> Diff: https://reviews.apache.org/r/39429/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39463/#review103303
---

Ship it!


Ship It!

- Joris Van Remoortere


On Oct. 20, 2015, 8:11 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39463/
> ---
> 
> (Updated Oct. 20, 2015, 8:11 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typos in log messages and comments; minor code/style cleanup.
> 
> Mostly in the replicated log code.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 0dc911251ade9c652da7db25a2824b76677499dc 
>   src/log/consensus.cpp 59f80d02d1d3c11683631f3fc5f6e923b5ebdf96 
>   src/log/coordinator.cpp 5500bca77f3020e0051010c5c178a20a3c7ad44a 
>   src/log/replica.hpp 33d3f1d9e89035936c67739898e73a06b391fcd0 
>   src/log/replica.cpp 75d39ff56822bf00fce9daf5c1e3befb75f2e039 
>   src/state/log.cpp a75a605a4b0edb8863a3378e2133df7d6eb1cc3d 
>   src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e 
>   src/tests/slave_tests.cpp 10a4fa7eaa8e868ccc6d60ac220d66a4f0a523b4 
> 
> Diff: https://reviews.apache.org/r/39463/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39490: Always create non-IP egress filters

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39490/#review103304
---


Patch looks great!

Reviews applied: [39490]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 6:57 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39490/
> ---
> 
> (Updated Oct. 20, 2015, 6:57 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When rolling out the new flag --egress_unique_flow_per_container, I noticed, 
> on some slaves, only IP egress filters were created as expected, the reset 
> were not. Looking at the code, it looks like we skipped the creation if this 
> is not the first container we create, this is wrong for this case, because 
> egress filters were not created for previous containers yet. We should always 
> create them and ignore error if they exist.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
> 
> Diff: https://reviews.apache.org/r/39490/diff/
> 
> 
> Testing
> ---
> 
> Manual tests
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39325/
---

(Updated Oct. 20, 2015, 8:45 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, and Timothy Chen.


Bugs: MESOS-3280
https://issues.apache.org/jira/browse/MESOS-3280


Repository: mesos


Description
---

MESOS-3280. The basic problem is that replicas silently ignore inbound Promise
and Write requests if they have not finished the recovery protocol yet (because
they can't safely vote on such requests). Hence, if we try to do a Paxos round
while a quorum of nodes have not finished recovering, the Paxos round will never
complete. In particular, this might happen during coordinator election:
coordinator election (which is implemented as performing a full Paxos round)
starts as soon as the candidate coordinator replica has finished the recovery
protocol. If several nodes start concurrently, a quorum of those nodes might
still be executing the recovery protocol, and hence the coordinator will never
be elected.

To address this, add "ignored" responses to the Promise and Write sub-protocols:
if a proposer sees a quorum of "ignored" responses to a promise or write request
it has issued, it knows the request will never succeed.  When used for
coordinator election, the current coding will retry immediately (without a
backoff).

Note that replicas will still silently drop promise/write requests if another
kind of problem occurs (e.g., an I/O error prevents reading/writing log
data). We might consider changing this, although it will require some thought:
e.g., if a replica's disk is broken, sending an "ignored" message on every
request might flood the network.

CODE REVIEW TO DISCUSS / FIX:

* Test mock is incredibly ugly: it works, but we clearly need a better approach
  before committing this. I've been chatting with @tnachen to find a better
  approach but haven't got anything that works yet.

* Should we add a backoff when retrying after a failed coordinator election?

* Should we also send back an "ignored" response if an I/O error occurs?


Diffs (updated)
-

  src/log/consensus.cpp 59f80d02d1d3c11683631f3fc5f6e923b5ebdf96 
  src/log/coordinator.cpp 5500bca77f3020e0051010c5c178a20a3c7ad44a 
  src/log/replica.hpp 33d3f1d9e89035936c67739898e73a06b391fcd0 
  src/log/replica.cpp 75d39ff56822bf00fce9daf5c1e3befb75f2e039 
  src/messages/log.proto d73b33f865963292af580945659ad0e800f2a204 
  src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e 

Diff: https://reviews.apache.org/r/39325/diff/


Testing
---

"make check" passes, including a new test that uses a newly constructed mock to 
ensure we're testing the message schedule described above.

I also wrote a script stops and starts mesos-master in a loop, removing the 
replicated log each time. Without the patch, this occasionally fails with a 
"registry fetch" timeout; with the patch, you can observe several scenarios 
where coordinator election is reborted and retried because a quorum of ignored 
responses is seen. Note that in some cases, we need to retry coordinator 
election up to ~70 times (!), because we don't currently use a backoff; that 
should probably be fixed, per comments above. But the important point is that 
election eventually succeeds and we don't hang.


Thanks,

Neil Conway

Review Request 39493: Added yum update to CentOS 6.6 install docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39493/
---

Review request for mesos, Adam B and haosdent huang.


Bugs: MESOS-3506
https://issues.apache.org/jira/browse/MESOS-3506


Repository: mesos


Description
---

Added yum update to CentOS 6.6 install docs.


Diffs
-

  docs/getting-started.md 35c8c566fff83abfcfcce177bfb9a35454f26494 

Diff: https://reviews.apache.org/r/39493/diff/


Testing
---

Viewed in the Mesos Website Container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Review Request 39494: Added libevent and ssl flags to config docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/
---

Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.


Bugs: MESOS-3749
https://issues.apache.org/jira/browse/MESOS-3749


Repository: mesos


Description
---

Added libevent and ssl flags to config docs.


Diffs
-

  docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 

Diff: https://reviews.apache.org/r/39494/diff/


Testing
---

Viewed in the Mesos Website Container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/
---

(Updated Oct. 20, 2015, 1:51 p.m.)


Review request for mesos, Adam B and Dave Lester.


Changes
---

Addressed comments.


Bugs: MESOS-3694
https://issues.apache.org/jira/browse/MESOS-3694


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/site-docker/Dockerfile PRE-CREATION 
  support/site-docker/README.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39194/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 39494: Added libevent and ssl flags to config docs.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103306
---

Ship it!


Ship It!


docs/configuration.md (line 1661)


I'd remove the "recommended" version, unless we really have a version 
dependency: this will require updating and/or become out of date.


- Neil Conway


On Oct. 20, 2015, 8:50 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
> 
> (Updated Oct. 20, 2015, 8:50 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3749
> https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libevent and ssl flags to config docs.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39457: Document messages in messages.proto.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39457/#review103307
---

Ship it!


This looks great Joseph!
Can you stay consistent with the scheduler / framework terminology?
Which one should we use consistently in the code-base?

- Joris Van Remoortere


On Oct. 20, 2015, 5:26 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39457/
> ---
> 
> (Updated Oct. 20, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3759
> https://issues.apache.org/jira/browse/MESOS-3759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A brief summary of each message was added.  
> 
> For messages with an associated Event/Call API object, a reference to the 
> object was added.
> Additionally, there is a great deal of documentation overlap between these 
> messages and the comments in mesos/scheduler.hpp and 
> v1/scheduler/scheduler.proto.  Where necessary, some notes were added about 
> the backwards compatibility of messages which are not instantiated in the 
> code base.
> 
> 
> Diffs
> -
> 
>   src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 
> 
> Diff: https://reviews.apache.org/r/39457/diff/
> 
> 
> Testing
> ---
> 
> None.  (Comment change only)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39331: Support docker local store pull image simultaneously

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39331/
---

(Updated Oct. 20, 2015, 2:22 p.m.)


Review request for mesos, Anand Mazumdar, Jojy Varghese, and Timothy Chen.


Bugs: MESOS-3736
https://issues.apache.org/jira/browse/MESOS-3736


Repository: mesos


Description
---

Support docker local store pull image simultaneously


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
2b2de5245bccbd01a856b214ac6525278d794537 
  src/slave/containerizer/provisioner/docker/store.cpp 
50340131d10222ac06cf21e87ad46943f171d1f6 
  src/tests/containerizer/provisioner_docker_tests.cpp 
01d3025f59d4a2714a856fe0f3a57192be023990 

Diff: https://reviews.apache.org/r/39331/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)

*This is not ready to be merged.
*Still considering two question:
 1. Handling simultaneous failure. If the first request is called and is 
written into the hashmap. All the other requests will be waiting for the future 
of the first request. But because its return type is 'Future>', 
if its future status is 'FAILED/DISCARDED', the other requests will be waiting 
forever. 
 2. The current hashmap uses 'stringify(image::name)' as key, but it may not be 
unique because there is chance that layer_ids can be changed. One solution is 
to have 'stringify(image)' as key.


Thanks,

Gilbert Song

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Marco Massenzio]

> On Oct. 20, 2015, 4:38 p.m., Anand Mazumdar wrote:
> > docs/scheduler-http-api.md, line 66
> > 
> >
> > Do we need this line anymore now ? This can be killed in favor of the 
> > following lines that we added around why RecordIO was needed.

I got a +1 from Ben on this one :)
Let's see what @vinodkone says...


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103267
---


On Oct. 20, 2015, 4:34 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 20, 2015, 4:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

(Updated Oct. 20, 2015, 9:30 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs (updated)
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing
---


Thanks,

Marco Massenzio

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39325/#review103309
---


Patch looks great!

Reviews applied: [39463, 39325]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 8:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39325/
> ---
> 
> (Updated Oct. 20, 2015, 8:45 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Bugs: MESOS-3280
> https://issues.apache.org/jira/browse/MESOS-3280
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3280. The basic problem is that replicas silently ignore inbound Promise
> and Write requests if they have not finished the recovery protocol yet 
> (because
> they can't safely vote on such requests). Hence, if we try to do a Paxos round
> while a quorum of nodes have not finished recovering, the Paxos round will 
> never
> complete. In particular, this might happen during coordinator election:
> coordinator election (which is implemented as performing a full Paxos round)
> starts as soon as the candidate coordinator replica has finished the recovery
> protocol. If several nodes start concurrently, a quorum of those nodes might
> still be executing the recovery protocol, and hence the coordinator will never
> be elected.
> 
> To address this, add "ignored" responses to the Promise and Write 
> sub-protocols:
> if a proposer sees a quorum of "ignored" responses to a promise or write 
> request
> it has issued, it knows the request will never succeed.  When used for
> coordinator election, the current coding will retry immediately (without a
> backoff).
> 
> Note that replicas will still silently drop promise/write requests if another
> kind of problem occurs (e.g., an I/O error prevents reading/writing log
> data). We might consider changing this, although it will require some thought:
> e.g., if a replica's disk is broken, sending an "ignored" message on every
> request might flood the network.
> 
> CODE REVIEW TO DISCUSS / FIX:
> 
> * Test mock is incredibly ugly: it works, but we clearly need a better 
> approach
>   before committing this. I've been chatting with @tnachen to find a better
>   approach but haven't got anything that works yet.
> 
> * Should we add a backoff when retrying after a failed coordinator election?
> 
> * Should we also send back an "ignored" response if an I/O error occurs?
> 
> 
> Diffs
> -
> 
>   src/log/consensus.cpp 59f80d02d1d3c11683631f3fc5f6e923b5ebdf96 
>   src/log/coordinator.cpp 5500bca77f3020e0051010c5c178a20a3c7ad44a 
>   src/log/replica.hpp 33d3f1d9e89035936c67739898e73a06b391fcd0 
>   src/log/replica.cpp 75d39ff56822bf00fce9daf5c1e3befb75f2e039 
>   src/messages/log.proto d73b33f865963292af580945659ad0e800f2a204 
>   src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e 
> 
> Diff: https://reviews.apache.org/r/39325/diff/
> 
> 
> Testing
> ---
> 
> "make check" passes, including a new test that uses a newly constructed mock 
> to ensure we're testing the message schedule described above.
> 
> I also wrote a script stops and starts mesos-master in a loop, removing the 
> replicated log each time. Without the patch, this occasionally fails with a 
> "registry fetch" timeout; with the patch, you can observe several scenarios 
> where coordinator election is reborted and retried because a quorum of 
> ignored responses is seen. Note that in some cases, we need to retry 
> coordinator election up to ~70 times (!), because we don't currently use a 
> backoff; that should probably be fixed, per comments above. But the important 
> point is that election eventually succeeds and we don't hang.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 39495: Fix SSL flag cleanup for tests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39495/
---

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Repository: mesos


Description
---

This moves the initialization of the SSL `Flags` into the `initialize` method.

Prior to this, SSL flags would not be completely cleaned up between tests.  
Test cleanup unsets all environment variables related to SSL.  However, the 
flags object would persist some of these variables between tests.
For example:
1) Test 1 unsets all flags, then sets flag `SSL_CA_FILE`.
2) Test 2 unsets all flags, then sets flag `SSL_CA_DIR`.  `SSL_CA_FILE` will 
still be set.
3) Test 3 unsets all flags.  `SSL_CA_FILE` and `SSL_CA_DIR` are still set.


Diffs
-

  3rdparty/libprocess/src/openssl.cpp 9ae5c1f0849aba3e2f858fb9fd31e6e65cf24b4f 

Diff: https://reviews.apache.org/r/39495/diff/


Testing
---

```
../configure --enable-ssl --enable-libevent
make check
```

Note: Only the tests will call `reinitialize`.


Thanks,

Joseph Wu

Review Request 39496: Clarified libevent config error messages.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39496/
---

Review request for mesos, Joris Van Remoortere and Neil Conway.


Bugs: MESOS-3501
https://issues.apache.org/jira/browse/MESOS-3501


Repository: mesos


Description
---

Clarified libevent config error messages to include required version.


Diffs
-

  configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9 

Diff: https://reviews.apache.org/r/39496/diff/


Testing
---

`../configure --enable-libevent --enable-ssl` with the libevent 
libraries/headers in various states of disrepair.


Thanks,

Greg Mann

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Ben Whitehead]

> On Oct. 19, 2015, 3:34 p.m., Anand Mazumdar wrote:
> > docs/scheduler-http-api.md, line 59
> > 
> >
> > Should we also mention why just encoding one event per chunk won't 
> > suffice and why we needed this ?
> > 
> > How about:
> > 
> > ```Network intermediataries e.g. proxies are free to change the chunk 
> > boundaries and this should not have any effect on the recipient 
> > application(scheduler layer). We wanted a way to delimit/encode two events 
> > for JSON/Protobuf responses consistently and RecordIO format allowed us to 
> > do that.```

+1


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103172
---


On Oct. 20, 2015, 2:30 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 20, 2015, 2:30 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Ben Whitehead]

> On Oct. 20, 2015, 9:38 a.m., Anand Mazumdar wrote:
> > docs/scheduler-http-api.md, line 66
> > 
> >
> > Do we need this line anymore now ? This can be killed in favor of the 
> > following lines that we added around why RecordIO was needed.
> 
> Marco Massenzio wrote:
> I got a +1 from Ben on this one :)
> Let's see what @vinodkone says...

Sorry, new to review board.  I actually meant +1 to Anands comment. I'll remove 
me previous point and add a +1 to Anands comment.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103267
---


On Oct. 20, 2015, 2:30 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 20, 2015, 2:30 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103312
---

Ship it!


I guess you want to retain apply-reviews.sh for backward compatibility; 
however, it can be entirely retired by making apply-reviews.py executable 
(`chmod a+x`) and adding a shebang at the top:
```
#!/usr/bin/env python
```


support/apply-review.sh (line 3)


I really dislike this style of conditional running stuff in bash (it also 
violates Google's style, but that's another story :) )
```
if [[ ! -f "support/apply-reviews.py" ]]; then
echo "..."
exit 1
fi

python ./support/apply-reviews.py "$@"
```



support/apply-reviews.py (lines 267 - 272)


did you introduce leading tabs?
(it may very well be a RB artifact, difficult to tell)


- Marco Massenzio


On Oct. 20, 2015, 7:45 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> ---
> 
> (Updated Oct. 20, 2015, 7:45 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7.
> 
> - with and without '-p'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39494: Added libevent and ssl flags to config docs.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103313
---

Ship it!


Not really related, but do you know if markdown-style tables are supported here?


docs/configuration.md (line 1768)


You should also add a corresponding `--with-ssl` and `--with-libevent` flag.


- Joseph Wu


On Oct. 20, 2015, 1:50 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
> 
> (Updated Oct. 20, 2015, 1:50 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3749
> https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libevent and ssl flags to config docs.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libevent and ssl flags to config docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/
---

(Updated Oct. 20, 2015, 9:55 p.m.)


Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.


Changes
---

Removed recommended version, added --with-libevent=DIR flag.


Bugs: MESOS-3749
https://issues.apache.org/jira/browse/MESOS-3749


Repository: mesos


Description
---

Added libevent and ssl flags to config docs.


Diffs (updated)
-

  docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 

Diff: https://reviews.apache.org/r/39494/diff/


Testing
---

Viewed in the Mesos Website Container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

(Updated Oct. 20, 2015, 9:58 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

removed sentence


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs (updated)
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing
---


Thanks,

Marco Massenzio

Re: Review Request 39494: Added libevent and ssl flags to config docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/
---

(Updated Oct. 20, 2015, 9:58 p.m.)


Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.


Changes
---

Added --with-ssl flag.


Bugs: MESOS-3749
https://issues.apache.org/jira/browse/MESOS-3749


Repository: mesos


Description
---

Added libevent and ssl flags to config docs.


Diffs (updated)
-

  docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 

Diff: https://reviews.apache.org/r/39494/diff/


Testing
---

Viewed in the Mesos Website Container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/
---

(Updated Oct. 20, 2015, 3 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.


Bugs: MESOS-3129
https://issues.apache.org/jira/browse/MESOS-3129


Repository: mesos


Description
---

Relocate MesosContainerizer specific files to the correct location


Diffs (updated)
-

  src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
  src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
  src/examples/test_isolator_module.cpp 
577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
  src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
  src/slave/containerizer/isolators/cgroups/constants.hpp  
  src/slave/containerizer/isolators/cgroups/cpushare.hpp 
54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp 
ba748c6caec7253b42167e8a4f9b4535da858259 
  src/slave/containerizer/isolators/cgroups/mem.hpp  
  src/slave/containerizer/isolators/cgroups/mem.cpp 
55fa6f4019e1521dd816138e82db110d573ae6b8 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp  
  src/slave/containerizer/isolators/cgroups/perf_event.cpp 
03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
  src/slave/containerizer/isolators/filesystem/linux.hpp 
93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
8823b7850a1ac17fc4f4868aadf1b04428d2381b 
  src/slave/containerizer/isolators/filesystem/posix.hpp  
  src/slave/containerizer/isolators/filesystem/posix.cpp 
eec510c4f7655d67b33ad90210eeb57fcc910684 
  src/slave/containerizer/isolators/filesystem/shared.hpp  
  src/slave/containerizer/isolators/filesystem/shared.cpp 
73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
  src/slave/containerizer/isolators/namespaces/pid.hpp  
  src/slave/containerizer/isolators/namespaces/pid.cpp 
a9823e08b195b8df82de2a7b410a4e6ef99f8853 
  src/slave/containerizer/isolators/network/helper.cpp 
e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
  src/slave/containerizer/isolators/network/port_mapping.hpp  
  src/slave/containerizer/isolators/network/port_mapping.cpp 
e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
  src/slave/containerizer/isolators/posix.hpp  
  src/slave/containerizer/isolators/posix/disk.hpp  
  src/slave/containerizer/isolators/posix/disk.cpp 
73e62a225da062733557287afa2273d8183d76fd 
  src/slave/containerizer/linux_launcher.cpp 
c03b89eb0678825b03a052874d6262f377a39e13 
  src/slave/containerizer/mesos/containerizer.cpp 
d1fc5a460e7313828014eea999cf4e63dde01921 
  src/slave/containerizer/provisioner/appc/paths.hpp  
  src/slave/containerizer/provisioner/appc/paths.cpp 
8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
  src/slave/containerizer/provisioner/appc/spec.hpp  
  src/slave/containerizer/provisioner/appc/spec.cpp 
bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
  src/slave/containerizer/provisioner/appc/store.hpp 
e8455197dcc3f4c9856db20605f6862b8755a946 
  src/slave/containerizer/provisioner/appc/store.cpp 
a5ef4ea7cd08423360120430833c5881053637f5 
  src/slave/containerizer/provisioner/backend.hpp  
  src/slave/containerizer/provisioner/backend.cpp 
b5d96701ae6bd49365b169f4e5150b8c4dae1870 
  src/slave/containerizer/provisioner/backends/bind.hpp 
1685938fb4349e790b9595cc4c67584c7f31a392 
  src/slave/containerizer/provisioner/backends/bind.cpp 
1fe1746c0bc1c9c12e1378e6438122a91b58316b 
  src/slave/containerizer/provisioner/backends/copy.hpp 
7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
  src/slave/containerizer/provisioner/backends/copy.cpp 
92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
  src/slave/containerizer/provisioner/docker/local_puller.hpp 
4574e8a04663482625d7b54f765741f221ec13e0 
  src/slave/containerizer/provisioner/docker/local_puller.cpp 
74d0e1ead7d630e65a7e75cb6123139b9197efef 
  src/slave/containerizer/provisioner/docker/message.hpp 
466e6f838d143917fa7eebb13b0a670a6b80117c 
  src/slave/containerizer/provisioner/docker/message.proto  
  src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
885080dbd3603f8c71ac867b88edcfd22276567f 
  src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
2b2de5245bccbd01a856b214ac6525278d794537 
  src/slave/containerizer/provisioner/docker/paths.hpp  
  src/slave/containerizer/provisioner/docker/paths.cpp 
5733fb7137b1ecb8a904cc5354425c60c9e065f5 
  src/slave/containerizer/provisioner/docker/puller.hpp 
105b4e75439c2ad4c08e2fd364f288f1d39b9b59 
  src/slave/containerizer/provisioner/docker/puller.cpp 
cb05324689ffa26ce830b513e2d71b55517da3cb 
  src/slave/containerizer/provisioner/docker/registry_client.hpp  
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
24aa95c5800ff4dfb37465b71421b014b5dd5998 
  src/slave/containerizer/provisioner/docker/spec.hpp 
199db540e44581a411ce63082b917821d29360a8 
  src/slave/containerizer/provisioner/

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review103315
---



support/site-docker/Dockerfile (line 1)


Maybe we should use the official Apache license header?



support/site-docker/Dockerfile (line 3)


Where'd this version number come from? What does it mean? When do we 
increment it?



support/site-docker/Dockerfile (line 6)


Let's change this to `d...@mesos.apache.org` so any of us can help with 
support questions.


- Adam B


On Oct. 20, 2015, 1:51 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> ---
> 
> (Updated Oct. 20, 2015, 1:51 p.m.)
> 
> 
> Review request for mesos, Adam B and Dave Lester.
> 
> 
> Bugs: MESOS-3694
> https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/site-docker/Dockerfile PRE-CREATION 
>   support/site-docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Ben Whitehead]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103314
---



docs/scheduler-http-api.md (lines 29 - 34)


Now that there is a formal grammar this example should be removed.



docs/scheduler-http-api.md (lines 36 - 48)


The proposed grammar I made was based of the ABNF of the HTTP 1.1 spec 
here: http://www.w3.org/Protocols/rfc2616/rfc2616-sec2.html#sec2.1 This spec 
should probably be linked to so the user can follow it.

`LF` is the method used to refer to `\n` character and I think we should be 
consistent with that.

`1*(DIGIT)` was there to denote the repetition of digit. Meaning at least 1 
digit.

`DIGIT` is already defined in the rfc I linked to.

`NL` is non-standard and should be removed in favor of `LF`



docs/scheduler-http-api.md (line 51)


This section of the document is expalaining RecordIO not http clients. 
Please remove this sentence.



docs/scheduler-http-api.md (lines 66 - 68)


These two lines don't flow together very well, a single paragraph should 
contain the motivation and justification.


- Ben Whitehead


On Oct. 20, 2015, 2:58 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 20, 2015, 2:58 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Review Request 39497: Fixed quotation of interpolated variables in log messages.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39497/
---

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-3772
https://issues.apache.org/jira/browse/MESOS-3772


Repository: mesos


Description
---

Specifically, we should always quote executor IDs (because they are
user-supplied and might contain whitespace), but we don't need to quote
framework IDs. There's a bunch more work we could do here (e.g., escaping
punctuation), but this is a start.

Also fix a few style issues with usage of "<<" operators.


Diffs
-

  src/exec/exec.cpp c99dc073f5ed5f635a41393ecb38ec13f21739d4 
  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/slave/containerizer/isolators/network/port_mapping.cpp 
e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
  src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 
  src/slave/state.cpp 81c4b96d879f974f0dfba3fb977184122eab 

Diff: https://reviews.apache.org/r/39497/diff/


Testing
---

make check, visual inspection.


Thanks,

Neil Conway

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

[Gilbert Song]

> On Oct. 19, 2015, 1:05 p.m., Jie Yu wrote:
> > This is great! Thanks! The current patch does not apply, can you do a 
> > rebase?

Thanks. Rebased.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review103150
---


On Oct. 20, 2015, 3 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39360/
> ---
> 
> (Updated Oct. 20, 2015, 3 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Relocate MesosContainerizer specific files to the correct location
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/examples/test_isolator_module.cpp 
> 577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp  
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ba748c6caec7253b42167e8a4f9b4535da858259 
>   src/slave/containerizer/isolators/cgroups/mem.hpp  
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 55fa6f4019e1521dd816138e82db110d573ae6b8 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp  
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.hpp  
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.hpp  
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/isolators/namespaces/pid.hpp  
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> a9823e08b195b8df82de2a7b410a4e6ef99f8853 
>   src/slave/containerizer/isolators/network/helper.cpp 
> e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
>   src/slave/containerizer/isolators/network/port_mapping.hpp  
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/containerizer/isolators/posix.hpp  
>   src/slave/containerizer/isolators/posix/disk.hpp  
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 73e62a225da062733557287afa2273d8183d76fd 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/provisioner/appc/paths.hpp  
>   src/slave/containerizer/provisioner/appc/paths.cpp 
> 8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
>   src/slave/containerizer/provisioner/appc/spec.hpp  
>   src/slave/containerizer/provisioner/appc/spec.cpp 
> bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> e8455197dcc3f4c9856db20605f6862b8755a946 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> a5ef4ea7cd08423360120430833c5881053637f5 
>   src/slave/containerizer/provisioner/backend.hpp  
>   src/slave/containerizer/provisioner/backend.cpp 
> b5d96701ae6bd49365b169f4e5150b8c4dae1870 
>   src/slave/containerizer/provisioner/backends/bind.hpp 
> 1685938fb4349e790b9595cc4c67584c7f31a392 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
>   src/slave/containerizer/provisioner/backends/copy.cpp 
> 92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/message.hpp 
> 466e6f838d143917fa7eebb13b0a670a6b80117c 
>   src/slave/containerizer/provisioner/docker/message.proto  
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> 885080dbd3603f8c71ac867b88edcfd22276567f 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> 2b2de5245bccbd01a856b214ac6525278d794537 
>   src/slave/containerize

Re: Review Request 39494: Added libevent and ssl flags to config docs.

[Greg Mann]

> On Oct. 20, 2015, 9:55 p.m., Joseph Wu wrote:
> > Not really related, but do you know if markdown-style tables are supported 
> > here?

Hmmm... not sure.


> On Oct. 20, 2015, 9:55 p.m., Joseph Wu wrote:
> > docs/configuration.md, line 1768
> > 
> >
> > You should also add a corresponding `--with-ssl` and `--with-libevent` 
> > flag.

Thanks Joseph! Added.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103313
---


On Oct. 20, 2015, 9:58 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
> 
> (Updated Oct. 20, 2015, 9:58 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3749
> https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libevent and ssl flags to config docs.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

[Gilbert Song]

> On Oct. 19, 2015, 2:05 p.m., Cong Wang wrote:
> > You probably want to move src/tests/containerizer too?

Seems too much things under src/tests/, we may want to rearrange all of them 
together.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review103157
---


On Oct. 20, 2015, 3 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39360/
> ---
> 
> (Updated Oct. 20, 2015, 3 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Relocate MesosContainerizer specific files to the correct location
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/examples/test_isolator_module.cpp 
> 577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp  
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ba748c6caec7253b42167e8a4f9b4535da858259 
>   src/slave/containerizer/isolators/cgroups/mem.hpp  
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 55fa6f4019e1521dd816138e82db110d573ae6b8 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp  
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.hpp  
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.hpp  
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/isolators/namespaces/pid.hpp  
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> a9823e08b195b8df82de2a7b410a4e6ef99f8853 
>   src/slave/containerizer/isolators/network/helper.cpp 
> e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
>   src/slave/containerizer/isolators/network/port_mapping.hpp  
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/containerizer/isolators/posix.hpp  
>   src/slave/containerizer/isolators/posix/disk.hpp  
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 73e62a225da062733557287afa2273d8183d76fd 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/provisioner/appc/paths.hpp  
>   src/slave/containerizer/provisioner/appc/paths.cpp 
> 8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
>   src/slave/containerizer/provisioner/appc/spec.hpp  
>   src/slave/containerizer/provisioner/appc/spec.cpp 
> bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> e8455197dcc3f4c9856db20605f6862b8755a946 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> a5ef4ea7cd08423360120430833c5881053637f5 
>   src/slave/containerizer/provisioner/backend.hpp  
>   src/slave/containerizer/provisioner/backend.cpp 
> b5d96701ae6bd49365b169f4e5150b8c4dae1870 
>   src/slave/containerizer/provisioner/backends/bind.hpp 
> 1685938fb4349e790b9595cc4c67584c7f31a392 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
>   src/slave/containerizer/provisioner/backends/copy.cpp 
> 92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/message.hpp 
> 466e6f838d143917fa7eebb13b0a670a6b80117c 
>   src/slave/containerizer/provisioner/docker/message.proto  
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> 885080dbd3603f8c71ac867b88edcfd22276567f 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> 2b2de5245bccbd01a856b2

Re: Review Request 39494: Added libevent and ssl flags to config docs.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103319
---

Ship it!


Ship It!

- Gilbert Song


On Oct. 20, 2015, 2:58 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
> 
> (Updated Oct. 20, 2015, 2:58 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3749
> https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libevent and ssl flags to config docs.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39220: CMake: Added subset of agent target in Windows builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39220/
---

(Updated Oct. 20, 2015, 10:27 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Added `slave/state.cpp` to Windows builds.


Diffs
-

  CMakeLists.txt eb93b9491ed3a133808b237292b70d436779b776 
  src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41 

Diff: https://reviews.apache.org/r/39220/diff/


Testing
---

Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 
15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39493: Added yum update to CentOS 6.6 install docs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39493/#review103321
---


Patch looks great!

Reviews applied: [39493]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 8:45 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39493/
> ---
> 
> (Updated Oct. 20, 2015, 8:45 p.m.)
> 
> 
> Review request for mesos, Adam B and haosdent huang.
> 
> 
> Bugs: MESOS-3506
> https://issues.apache.org/jira/browse/MESOS-3506
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added yum update to CentOS 6.6 install docs.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 35c8c566fff83abfcfcce177bfb9a35454f26494 
> 
> Diff: https://reviews.apache.org/r/39493/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39497/#review103320
---



src/slave/slave.cpp (line 1938)


Should this executor ID be quoted as well?



src/slave/slave.cpp (line 1941)


Should this executor ID be quoted as well?



src/slave/slave.cpp (line 1955)


This one too?



src/slave/slave.cpp (line 1988)


Should this executor ID be quoted as well? Also, could you remove the 
extraneous space at the beginning of this error message?



src/slave/slave.cpp (lines 2121 - 2122)


Two single quotes before `executorId`, none after.



src/slave/slave.cpp (lines 2136 - 2137)


Two single quotes before executorId, none after.



src/slave/slave.cpp (line 3460)


Could you also remove the period at the end of this error message?



src/slave/slave.cpp (line 3506)


Could you also remove the extraneous space at the beginning of this error 
message?


- Greg Mann


On Oct. 20, 2015, 10:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39497/
> ---
> 
> (Updated Oct. 20, 2015, 10:04 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3772
> https://issues.apache.org/jira/browse/MESOS-3772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically, we should always quote executor IDs (because they are
> user-supplied and might contain whitespace), but we don't need to quote
> framework IDs. There's a bunch more work we could do here (e.g., escaping
> punctuation), but this is a start.
> 
> Also fix a few style issues with usage of "<<" operators.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp c99dc073f5ed5f635a41393ecb38ec13f21739d4 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 
>   src/slave/state.cpp 81c4b96d879f974f0dfba3fb977184122eab 
> 
> Diff: https://reviews.apache.org/r/39497/diff/
> 
> 
> Testing
> ---
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39457: Document messages in messages.proto.

[Guangya Liu]

> On Oct. 20, 2015, 8:23 a.m., Guangya Liu wrote:
> >
> 
> Joseph Wu wrote:
> For now, I'll keep "agent".  I'm fairly certain we refer to agents as 
> agents now.

Joseph, do you have any reasons for why not update "slave" to "agent" in the 
comments? When I was fixing https://reviews.apache.org/r/37993/ , I was asked 
to change all "slave" to "agent" to keep consistent.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39457/#review103218
---


On Oct. 20, 2015, 5:26 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39457/
> ---
> 
> (Updated Oct. 20, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3759
> https://issues.apache.org/jira/browse/MESOS-3759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A brief summary of each message was added.  
> 
> For messages with an associated Event/Call API object, a reference to the 
> object was added.
> Additionally, there is a great deal of documentation overlap between these 
> messages and the comments in mesos/scheduler.hpp and 
> v1/scheduler/scheduler.proto.  Where necessary, some notes were added about 
> the backwards compatibility of messages which are not instantiated in the 
> code base.
> 
> 
> Diffs
> -
> 
>   src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 
> 
> Diff: https://reviews.apache.org/r/39457/diff/
> 
> 
> Testing
> ---
> 
> None.  (Comment change only)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39457: Document messages in messages.proto.

[Joseph Wu]

> On Oct. 20, 2015, 1:23 a.m., Guangya Liu wrote:
> >
> 
> Joseph Wu wrote:
> For now, I'll keep "agent".  I'm fairly certain we refer to agents as 
> agents now.
> 
> Guangya Liu wrote:
> Joseph, do you have any reasons for why not update "slave" to "agent" in 
> the comments? When I was fixing https://reviews.apache.org/r/37993/ , I was 
> asked to change all "slave" to "agent" to keep consistent.

This is mostly due to the audience of the code.  People who read this file are 
going to be Mesos contributors.  And interally, we already use "agent".

The allocator comments you made are external facing (to module writers).  We're 
still in the process (I think) of converting external docs from "slave" to 
"agent".  For those, it's more important to stay consistent between docs than 
to be politically correct.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39457/#review103218
---


On Oct. 20, 2015, 10:26 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39457/
> ---
> 
> (Updated Oct. 20, 2015, 10:26 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3759
> https://issues.apache.org/jira/browse/MESOS-3759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A brief summary of each message was added.  
> 
> For messages with an associated Event/Call API object, a reference to the 
> object was added.
> Additionally, there is a great deal of documentation overlap between these 
> messages and the comments in mesos/scheduler.hpp and 
> v1/scheduler/scheduler.proto.  Where necessary, some notes were added about 
> the backwards compatibility of messages which are not instantiated in the 
> code base.
> 
> 
> Diffs
> -
> 
>   src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 
> 
> Diff: https://reviews.apache.org/r/39457/diff/
> 
> 
> Testing
> ---
> 
> None.  (Comment change only)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39331: Support docker local store pull image simultaneously

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39331/#review103327
---


Patch looks great!

Reviews applied: [39331]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 9:22 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39331/
> ---
> 
> (Updated Oct. 20, 2015, 9:22 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3736
> https://issues.apache.org/jira/browse/MESOS-3736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support docker local store pull image simultaneously
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> 2b2de5245bccbd01a856b214ac6525278d794537 
>   src/slave/containerizer/provisioner/docker/store.cpp 
> 50340131d10222ac06cf21e87ad46943f171d1f6 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 01d3025f59d4a2714a856fe0f3a57192be023990 
> 
> Diff: https://reviews.apache.org/r/39331/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> *This is not ready to be merged.
> *Still considering two question:
>  1. Handling simultaneous failure. If the first request is called and is 
> written into the hashmap. All the other requests will be waiting for the 
> future of the first request. But because its return type is 
> 'Future>', if its future status is 'FAILED/DISCARDED', the 
> other requests will be waiting forever. 
>  2. The current hashmap uses 'stringify(image::name)' as key, but it may not 
> be unique because there is chance that layer_ids can be changed. One solution 
> is to have 'stringify(image)' as key.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 39457: Document messages in messages.proto.

[Guangya Liu]

> On Oct. 20, 2015, 8:23 a.m., Guangya Liu wrote:
> >
> 
> Joseph Wu wrote:
> For now, I'll keep "agent".  I'm fairly certain we refer to agents as 
> agents now.
> 
> Guangya Liu wrote:
> Joseph, do you have any reasons for why not update "slave" to "agent" in 
> the comments? When I was fixing https://reviews.apache.org/r/37993/ , I was 
> asked to change all "slave" to "agent" to keep consistent.
> 
> Joseph Wu wrote:
> This is mostly due to the audience of the code.  People who read this 
> file are going to be Mesos contributors.  And interally, we already use 
> "agent".
> 
> The allocator comments you made are external facing (to module writers).  
> We're still in the process (I think) of converting external docs from "slave" 
> to "agent".  For those, it's more important to stay consistent between docs 
> than to be politically correct.

I see, thanks Joe!


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39457/#review103218
---


On Oct. 20, 2015, 5:26 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39457/
> ---
> 
> (Updated Oct. 20, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3759
> https://issues.apache.org/jira/browse/MESOS-3759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A brief summary of each message was added.  
> 
> For messages with an associated Event/Call API object, a reference to the 
> object was added.
> Additionally, there is a great deal of documentation overlap between these 
> messages and the comments in mesos/scheduler.hpp and 
> v1/scheduler/scheduler.proto.  Where necessary, some notes were added about 
> the backwards compatibility of messages which are not instantiated in the 
> code base.
> 
> 
> Diffs
> -
> 
>   src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 
> 
> Diff: https://reviews.apache.org/r/39457/diff/
> 
> 
> Testing
> ---
> 
> None.  (Comment change only)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39496: Clarified libevent config error messages.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39496/#review103332
---


Patch looks great!

Reviews applied: [39496]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 9:49 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39496/
> ---
> 
> (Updated Oct. 20, 2015, 9:49 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Neil Conway.
> 
> 
> Bugs: MESOS-3501
> https://issues.apache.org/jira/browse/MESOS-3501
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified libevent config error messages to include required version.
> 
> 
> Diffs
> -
> 
>   configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9 
> 
> Diff: https://reviews.apache.org/r/39496/diff/
> 
> 
> Testing
> ---
> 
> `../configure --enable-libevent --enable-ssl` with the libevent 
> libraries/headers in various states of disrepair.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39060: Create master detector per url & not per framework

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39060/#review103331
---


Hey Mandeep, Thanks for taking on this important work!
Some high level questions:
- Do we need to do reference counting manually or can we use a construct like 
`Shared` in Libprocess that wraps the `std::shared_ptr`.
- Do we want to surface the singleton pattern in this way? What are the impacts 
of this on the user (i.e. your logic calling the `acquire` / `release` code 
currently? Does the user care about holding a reference to the singleton?

Regardless, I added some style comments as they are valuable for you as a 
contributor.


src/sched/sched.cpp (line 116)


Can we provide some documentation as to the purpose of this class?
You can reference the JIRA number within the comment.



src/sched/sched.cpp (line 120)


We tend to return by pointer rather than reference, assuming we want to 
follow this form of singleton pattern.



src/sched/sched.cpp (line 121)


no need for the space within `{ }`



src/sched/sched.cpp (line 123)


`{` on a new line as per style guide. 
You can also trim the `std::` from the `std::string` as we have a `using 
std::string` declaration above.
Here and below.



src/sched/sched.cpp (lines 125 - 126)


Can we add a comment here about the condition we're testing for, and then 
looking to achieve?



src/sched/sched.cpp (line 133)


`{` on new line.



src/sched/sched.cpp (lines 135 - 144)


Would this logic be easier to follow if we re-arranged it as:
```
if (!masterDetectors.contains(url)) {
  return NULL;
}

rest of logic...
```

This is a pretty common pattern in our code base: early return conditions 
pulled to the top.



src/sched/sched.cpp (lines 136 - 137)


Just some context: we try to avoid using aliases like this. Please see the 
comments in the style guide.
In this particular case I think it is a valid use case, I just wanted to 
use this as a sharing opportunity :-)

Can we rename `thisPair` to something more meaningful? Part of our argument 
for aliases is improved documentation through code.



src/sched/sched.cpp (line 140)


You have an extra whitespace after refCount.



src/sched/sched.cpp (line 141)


If the previous statement did not fit on a single line, we leave a blank 
line between it and the next statement.



src/sched/sched.cpp (line 148)


`{` on new line.



src/sched/sched.cpp (lines 150 - 165)


Similar comments as above.
Let's take a look at this after you refactor the first section.



src/sched/sched.cpp (line 169)


`{` on new line.



src/sched/sched.cpp (line 176)


Comments end with a `.`



src/sched/sched.cpp (lines 182 - 184)


In general, do we need to be doing reference counting manually?
How come we can't use something like `Shared` in libprocess? It is a 
wrapper around `std::shared_ptr`.



src/sched/sched.cpp (lines 187 - 191)


Do we need to provide an accessor to a singleton here?
It makes the code below more terse.

What do you think about having an internal singleton and making the 
functions themselves static, or having static wrappers?

e.g. (using the acquire / release pattern)
```
// Static functions.
DetectorPool::acquire(...)
DetectorPool::release(...)
// Or no alias.
detectors()->acquire(...)
detectors()->release(...)
```

or with `Shared`
```
Shared detector = DetectorPool::acquire(...)
```



src/sched/sched.cpp (line 1806)


indentation is off.


- Joris Van Remoortere


On Oct. 8, 2015, 5:05 p.m., Mandeep Chadha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39060/
> ---
> 
> (Updated Oct. 8, 2015, 5:05 p.m.)
> 
> 
> Review request for mesos and Joris Van Remo