Re: Review Request 39492: Added status endpoint for quota master endpoint.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review103934
---



src/master/quota_handler.cpp (line 246)


indent?


- Guangya Liu


On 十月 23, 2015, 10:34 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> ---
> 
> (Updated 十月 23, 2015, 10:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added status handling for quota master endpoint.
> Tests are in next Review.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> ---
> 
> Test output: 
> {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39614: Quota: Added Status Validation Tests.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review103933
---



src/tests/master_quota_tests.cpp (line 705)


I see that most of the test cases are not using xx_xx to name the test 
function, can we rename Status_EmptyQuota to StatusEmptyQuota? 

Same question for all of the functions in this file.


- Guangya Liu


On 十月 24, 2015, 7:40 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39614/
> ---
> 
> (Updated 十月 24, 2015, 7:40 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Added Status Validation Tests.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39614/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 38580: Added docker registry RemotePuller

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38580/#review103930
---


Please link this RR to ticket.

- Klaus Ma


On Oct. 24, 2015, 12:57 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38580/
> ---
> 
> (Updated Oct. 24, 2015, 12:57 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Timothy Chen, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Integrated remote puller with store. Tests will follow.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 98e76cee81ab206f3ffe7989711abc38f49c4352 
>   src/Makefile.am 96ce73b301c55d23bf4a5292e3d028148426a878 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/puller.hpp 
> 105b4e75439c2ad4c08e2fd364f288f1d39b9b59 
>   src/slave/containerizer/provisioner/docker/puller.cpp 
> cb05324689ffa26ce830b513e2d71b55517da3cb 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 
> 1d3377e7462908246dfac90aa0c56314406529c9 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> 471783d88b73b62afacac3d7952ebb5d5f442097 
>   src/slave/containerizer/provisioner/docker/remote_puller.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/remote_puller.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/store.cpp 
> 637c97c0973bda492826803a962c99635647692d 
>   src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 
>   src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 822aa77d0be0797ab62a5798527618b2cc4f6bf0 
> 
> Diff: https://reviews.apache.org/r/38580/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39492: Added status endpoint for quota master endpoint.

[Joerg Schad]

> On Oct. 25, 2015, 3:28 a.m., Guangya Liu wrote:
> > src/master/quota_handler.cpp, line 237
> > 
> >
> > Can you please add a new test case for this? You can refer to 
> > https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L1623-L1699
> >  as a reference

Check the next patch in the chain (i.e. https://reviews.apache.org/r/39614/) 
:-).


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review103928
---


On Oct. 23, 2015, 10:34 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> ---
> 
> (Updated Oct. 23, 2015, 10:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added status handling for quota master endpoint.
> Tests are in next Review.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> ---
> 
> Test output: 
> {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39492: Added status endpoint for quota master endpoint.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review103928
---


Where did you set this endpoint of quota?


src/master/quota_handler.cpp (line 237)


Can you please add a new test case for this? You can refer to 
https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L1623-L1699
 as a reference


- Guangya Liu


On 十月 23, 2015, 10:34 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> ---
> 
> (Updated 十月 23, 2015, 10:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added status handling for quota master endpoint.
> Tests are in next Review.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> ---
> 
> Test output: 
> {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39285: Added Quota Request Validation.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103918
---



src/master/master.hpp (line 864)


Should we return Bad Request (404) for now, because we did not implement it 
yet.



src/master/master.hpp (line 875)


Same as above.



src/master/quota_handler.cpp (line 105)


It said the role maybe not set in allocator interface's comments 
(`setQuota`); so any case that the role passed validation in master but it's  
still empty to allocator?


- Klaus Ma


On Oct. 25, 2015, 3:42 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Oct. 25, 2015, 3:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 39628: Clear the suppressed flag when deactive a framework

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3802
https://issues.apache.org/jira/browse/MESOS-3802


Repository: mesos


Description
---

Clear the suppressed flag when deactive a framework


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 

Diff: https://reviews.apache.org/r/39628/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 39449: Documented order of includes.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39449/#review103911
---

Ship it!


Ship It!

- Qian Zhang


On Oct. 20, 2015, 5:29 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39449/
> ---
> 
> (Updated Oct. 20, 2015, 5:29 a.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Michael Park.
> 
> 
> Bugs: MESOS-2275
> https://issues.apache.org/jira/browse/MESOS-2275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented order of includes.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
> 
> Diff: https://reviews.apache.org/r/39449/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review103910
---



include/mesos/master/allocator.hpp (line 358)


It said Mesos master will also validate the quota request in design 
document; should we clarify which part is covered by Mesos master and which 
part should be covered by allocator? For example, according to this comments, 
empty role will pass master's checking; it's allocator's resposibility to 
accept or reject it.


- Klaus Ma


On Oct. 24, 2015, 12:38 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> ---
> 
> (Updated Oct. 24, 2015, 12:38 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
>   src/master/allocator/mesos/allocator.hpp 
> c5375aa89b210e46c41ac7d68d119749de15d2f5 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
>   src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 
> 
> Diff: https://reviews.apache.org/r/38218/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/#review103909
---

Ship it!


Ship It!

- Klaus Ma


On Oct. 21, 2015, 8:52 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38627/
> ---
> 
> (Updated Oct. 21, 2015, 8:52 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3072
> https://issues.apache.org/jira/browse/MESOS-3072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allows developers to provide their own parameters when loading modules 
> instead of using the ones provided by the user when loading Mesos. This helps 
> to deal with default modules (those used when the user doesn't provide any), 
> and for testing of the modules.
> 
> 
> Diffs
> -
> 
>   src/examples/example_module_impl.cpp 
> db015cea130701a4e0a6fcb890c79fbb0c02c1ce 
>   src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 
>   src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
>   src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 
> 
> Diff: https://reviews.apache.org/r/38627/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 39614: Quota: Added Status Validation Tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review103907
---


Patch looks great!

Reviews applied: [39317, 38218, 36913, 38059, 39285, 38110, 38956, 39223, 
39492, 39614]

All tests passed.

- Mesos ReviewBot


On Oct. 24, 2015, 7:40 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39614/
> ---
> 
> (Updated Oct. 24, 2015, 7:40 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Added Status Validation Tests.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39614/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38878/#review103906
---


Patch looks great!

Reviews applied: [39569, 38874, 38875, 39297, 38876, 38877, 38878]

All tests passed.

- Mesos ReviewBot


On Oct. 24, 2015, 7 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38878/
> ---
> 
> (Updated Oct. 24, 2015, 7 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
> https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a basic test to validate the implementation for 
> Subscribe->Subscribed workflow on the `api/v1/executor` endpoint on Agent.
> 
> 
> Diffs
> -
> 
>   src/tests/executor_http_api_tests.cpp 
> 31938c295367686d444f8a8aa2c43d2696b481ec 
> 
> Diff: https://reviews.apache.org/r/38878/diff/
> 
> 
> Testing
> ---
> 
> make check. Would add more agent recovery tests/executor reconnect tests in a 
> separate patch.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review103905
---



include/mesos/master/allocator.hpp (line 360)


Agree would be helpful.



include/mesos/master/allocator.hpp (line 377)


Agree, this would be helpful.


- Joerg Schad


On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> ---
> 
> (Updated Oct. 23, 2015, 4:38 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
>   src/master/allocator/mesos/allocator.hpp 
> c5375aa89b210e46c41ac7d68d119749de15d2f5 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
>   src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 
> 
> Diff: https://reviews.apache.org/r/38218/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39614: Quota: Added Status Validation Tests.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/
---

(Updated Oct. 24, 2015, 7:40 p.m.)


Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Quota: Added Status Validation Tests.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39614/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 39285: Added Quota Request Validation.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/
---

(Updated Oct. 24, 2015, 7:42 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Added Quota Request Validation.


Diffs
-

  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39285/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review103904
---


Patch looks great!

Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 
39560, 39583, 39584, 39620, 39621, 39622, 39623, 39019]

All tests passed.

- Mesos ReviewBot


On Oct. 24, 2015, 6:42 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> ---
> 
> (Updated Oct. 24, 2015, 6:42 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -
> 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 7a8819541506f57f70a9b577dc97a76fc26ebaa8 
> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39590: Made license-headers doxygen-compatible.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/#review103903
---


What about `.proto` files?

- Alexander Rukletsov


On Oct. 24, 2015, 2:06 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39590/
> ---
> 
> (Updated Oct. 24, 2015, 2:06 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
> Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit is the result of running
> 
> for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
>   sed -i -E '1 s~^\/\*\*~\/\*~' $f
> done
> 
> and updating the C++ style guide.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
>   include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
>   include/mesos/authentication/authenticatee.hpp 
> 17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
>   include/mesos/authentication/authentication.hpp 
> 699aa886286bc7d9c05592e71232ab1c1084871f 
>   include/mesos/authentication/authenticator.hpp 
> aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   include/mesos/containerizer/containerizer.hpp 
> 9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
>   include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
>   include/mesos/executor/executor.hpp 
> 85f181c72cdb5e80d6c549a4d663d9bad261693a 
>   include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
>   include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
>   include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
>   include/mesos/maintenance/maintenance.hpp 
> f676d01c2c81250b6e4740ab0934f966b50ed76d 
>   include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
>   include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
>   include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
>   include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
>   include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
>   include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
>   include/mesos/module/authenticatee.hpp 
> aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
>   include/mesos/module/authenticator.hpp 
> b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
>   include/mesos/module/authorizer.hpp 
> 7d8fc2123ac4132a7a698c855db03433eb77cea6 
>   include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
>   include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
>   include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
>   include/mesos/module/qos_controller.hpp 
> 462f07608fb2b580cee9548b5506e9896ee7077a 
>   include/mesos/module/resource_estimator.hpp 
> c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
>   include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
>   include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
>   include/mesos/scheduler/scheduler.hpp 
> 30de72b1b535831e074cd132b61e74fec2f4890a 
>   include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
>   include/mesos/slave/oversubscription.hpp 
> ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
>   include/mesos/slave/qos_controller.hpp 
> 7e280ccabd153eb10ae72cc48078d660df9f2011 
>   include/mesos/slave/resource_estimator.hpp 
> 731ec3a470dcc8e90199e774d6fcd1d5635be296 
>   include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
>   include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
>   include/mesos/v1/executor/executor.hpp 
> f50533f8120908cb5b1144bd18a4e097c5336fde 
>   include/mesos/v1/mesos.hpp fe4c4b73d41505eeb977f818aecab3cd037668da 
>   include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
>   include/mesos/v1/scheduler.hpp 9d3355ed1cd32ec2641082358aaf9c589ef698e3 
>   include/mesos/v1/scheduler/scheduler.hpp 
> eaf9f90fc9da4d03871145874599bb6d4b781567 
>   include/mesos/v1/values.hpp 4e53297854a79a820f652e69fea36319a97ecf5e 
>   include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
>   src/authentication/cram_md5/authenticatee.hpp 
> 9d6293c32722272228652d0241c59c7eeb88d0a3 
>   src/authentication/cram_md5/authenticatee.cpp 
> b03b44a924632edf4424cfef1ae4163c4abc7b1a 
>   src/authentication/cram_md5/authenticator.hpp 
> e75469a2e50167582711308b301802c9dfd9fb97 
>   src/authentication/cram_md5/authenticator.cpp 
> f238872476d422856db48bd845d5941911fdf2b0 
>   src/authentication/cram_md5/auxp

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38878/
---

(Updated Oct. 24, 2015, 7 p.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
---

Updated tests to not use `KillTaskMessage` but use the `ExecutorDriver`


Bugs: MESOS-3515
https://issues.apache.org/jira/browse/MESOS-3515


Repository: mesos


Description
---

This change adds a basic test to validate the implementation for 
Subscribe->Subscribed workflow on the `api/v1/executor` endpoint on Agent.


Diffs (updated)
-

  src/tests/executor_http_api_tests.cpp 
31938c295367686d444f8a8aa2c43d2696b481ec 

Diff: https://reviews.apache.org/r/38878/diff/


Testing
---

make check. Would add more agent recovery tests/executor reconnect tests in a 
separate patch.


Thanks,

Anand Mazumdar

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38875/
---

(Updated Oct. 24, 2015, 6:43 p.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
---

Review comments


Bugs: MESOS-3515
https://issues.apache.org/jira/browse/MESOS-3515


Repository: mesos


Description
---

Refactored the `api/v1/executor` endpoint to do executor/framework 
exists(`NULL`) checks before `Subscribe` since the slave explicitly knows the 
`frameworkID/executorID` when it launches it. Also modified tests to first 
spawn a dummy `cat` process and then make a `Subscribe` call to ensure that the 
Agent knows about the Framework/Executor and not reject it via `BadRequest` due 
to the `NULL` checks.


Diffs (updated)
-

  src/slave/http.cpp 80bda34e2b344b96d5d2f9c1fecd36046f67ab49 
  src/tests/executor_http_api_tests.cpp 
31938c295367686d444f8a8aa2c43d2696b481ec 

Diff: https://reviews.apache.org/r/38875/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

[Alex Clemmer]

> On Oct. 6, 2015, 5:12 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp,
> >  lines 41-43
> > 
> >
> > Is this necessary?  (Do the calls to `FindNextFile`, `FindClose`, or 
> > `FindFirstFile` require C or something?)

I wrote this into the comments, but I wanted to make the linker not use C++ 
linkage style that mangles the names. This will give the code the feeling of 
"real C standard library" code.

Yes, I admit it's a super nitpicky thing to do.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review101663
---


On Oct. 24, 2015, 6:42 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> ---
> 
> (Updated Oct. 24, 2015, 6:42 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -
> 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 7a8819541506f57f70a9b577dc97a76fc26ebaa8 
> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
---

(Updated Oct. 24, 2015, 6:42 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441


Repository: mesos


Description
---

Windows: Added dirent compat code for non-Unix systems.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
7a8819541506f57f70a9b577dc97a76fc26ebaa8 

Diff: https://reviews.apache.org/r/39019/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
---

(Updated Oct. 24, 2015, 6:39 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Summary (updated)
-

Windows: Added dirent compat code for non-Unix systems.


Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441


Repository: mesos


Description
---

Windows: Added dirent compat code for non-Unix systems.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
7a8819541506f57f70a9b577dc97a76fc26ebaa8 

Diff: https://reviews.apache.org/r/39019/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38875/
---

(Updated Oct. 24, 2015, 6:37 p.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
---

Modified to use the `SchedulerDriver` instead of manually sending a 
`KillTaskMessage`


Bugs: MESOS-3515
https://issues.apache.org/jira/browse/MESOS-3515


Repository: mesos


Description
---

Refactored the `api/v1/executor` endpoint to do executor/framework 
exists(`NULL`) checks before `Subscribe` since the slave explicitly knows the 
`frameworkID/executorID` when it launches it. Also modified tests to first 
spawn a dummy `cat` process and then make a `Subscribe` call to ensure that the 
Agent knows about the Framework/Executor and not reject it via `BadRequest` due 
to the `NULL` checks.


Diffs (updated)
-

  src/slave/http.cpp 80bda34e2b344b96d5d2f9c1fecd36046f67ab49 
  src/tests/executor_http_api_tests.cpp 
31938c295367686d444f8a8aa2c43d2696b481ec 

Diff: https://reviews.apache.org/r/38875/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 39623: CMake: Added protobuf compilation to Windows builds.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39623/#review103901
---


Patch looks great!

Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 
39560, 39583, 39584, 39620, 39621, 39622, 39623]

All tests passed.

- Mesos ReviewBot


On Oct. 24, 2015, 4:33 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39623/
> ---
> 
> (Updated Oct. 24, 2015, 4:33 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added protobuf compilation to Windows builds.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
> 
> Diff: https://reviews.apache.org/r/39623/diff/
> 
> 
> Testing
> ---
> 
> `make check` from CMake on OS X 10.10.
> `make check` from Autotools on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH 
> into my Ubuntu box to test this from Ubuntu
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39620/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Included headers to make `stout/windows.hpp` standalone.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
7a8819541506f57f70a9b577dc97a76fc26ebaa8 

Diff: https://reviews.apache.org/r/39620/diff/


Testing
---

`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.

PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH 
into my Ubuntu box to test this from Ubuntu


Thanks,

Alex Clemmer

Review Request 39623: CMake: Added protobuf compilation to Windows builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39623/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Added protobuf compilation to Windows builds.


Diffs
-

  src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 

Diff: https://reviews.apache.org/r/39623/diff/


Testing
---

`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.

PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH 
into my Ubuntu box to test this from Ubuntu


Thanks,

Alex Clemmer

Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39621/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Corrected linking path for gmock libraries on Windows builds.


Diffs
-

  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
6eda46b0e08829b269b13a78f22510e6d03940d9 

Diff: https://reviews.apache.org/r/39621/diff/


Testing
---

`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.

PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH 
into my Ubuntu box to test this from Ubuntu


Thanks,

Alex Clemmer

Review Request 39622: CMake: Pointed Stout test linker flags at correct gtest directory.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39622/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Pointed Stout test linker flags at correct gtest directory.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
9893d741cd7c611dc65eba76be03e06dac618132 

Diff: https://reviews.apache.org/r/39622/diff/


Testing
---

`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.

PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH 
into my Ubuntu box to test this from Ubuntu


Thanks,

Alex Clemmer

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

[Alexander Rojas]

> On Oct. 21, 2015, 9:02 a.m., Klaus Ma wrote:
> > src/module/manager.hpp, line 94
> > 
> >
> > Should we merge with `moduleParameters[moduleName]` or replace it? IMO, 
> > prefer to merge them; I'd like to leave it to you and your shepherd.
> 
> Alexander Rojas wrote:
> I don't understand what you mean with this comment? is the same as the 
> following one?
> 
> Klaus Ma wrote:
> for example, if `{a:1, b:2}` in `moduleParameters[moduleName]` and `{b:3, 
> c:4}` in `params`, what's expected result? `{a:1, b:3, c:4}` or `{b:3, c:4}`.

Merge is not a good idea almost ever. In this case, if you have a parameter 
which can appear once, and the user gave `foo=5` and the API gave `foo=10` 
which one to choose?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/#review103365
---


On Oct. 21, 2015, 2:52 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38627/
> ---
> 
> (Updated Oct. 21, 2015, 2:52 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3072
> https://issues.apache.org/jira/browse/MESOS-3072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allows developers to provide their own parameters when loading modules 
> instead of using the ones provided by the user when loading Mesos. This helps 
> to deal with default modules (those used when the user doesn't provide any), 
> and for testing of the modules.
> 
> 
> Diffs
> -
> 
>   src/examples/example_module_impl.cpp 
> db015cea130701a4e0a6fcb890c79fbb0c02c1ce 
>   src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 
>   src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
>   src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 
> 
> Diff: https://reviews.apache.org/r/38627/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>