Re: Review Request 41789: Add put method for http PUT request.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/
---

(Updated Jan. 4, 2016, 1:50 a.m.)


Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil 
Conway, and Qian Zhang.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description (updated)
---

Add put method for http PUT request.

Note: This is a tempory, and only created for #41681 dependency. The same patch 
https://reviews.apache.org/r/39466/ has be posted, I have talked with Joerg 
owner of that RR to speed up that ticket. After that RR commit, then we can 
discard this.


Diffs
-

  3rdparty/libprocess/include/process/http.hpp 
f0666f0fa48c4f3a98332d12066561a02a715236 
  3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 

Diff: https://reviews.apache.org/r/41789/diff/


Testing
---

Make & Make check successfully.


Thanks,

Yongqiao Wang

Re: Review Request 41789: Add put method for http PUT request.

[Yongqiao Wang]

> On Jan. 3, 2016, 10:48 a.m., Joerg Schad wrote:
> > This pretty much duplicates https://reviews.apache.org/r/39466/ (except 
> > also has a test case). Even though the long term approach should be to 
> > replace all the individual http method call with a general one (accepting a 
> > Request object), we should decide which of these reviews we want to 
> > commit/focus on right now.
> 
> Joerg Schad wrote:
> Ah saw just above comment about this being tempory, would be good to add 
> that in the description . Thanks :-).

Thank Joerg for your comments. I think for the short term we should commit 
https://reviews.apache.org/r/39466/ firstly, because current there is an urgent 
test case needs it. After that, we can consider to replace all the individual 
http method call with a general one.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/#review112445
---


On Jan. 4, 2016, 1:50 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41789/
> ---
> 
> (Updated Jan. 4, 2016, 1:50 a.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil 
> Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add put method for http PUT request.
> 
> Note: This is a tempory, and only created for #41681 dependency. The same 
> patch https://reviews.apache.org/r/39466/ has be posted, I have talked with 
> Joerg owner of that RR to speed up that ticket. After that RR commit, then we 
> can discard this.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
> 
> Diff: https://reviews.apache.org/r/41789/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41869: Removed Docker auth server flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41869/#review112489
---


Patch looks great!

Reviews applied: [41868, 41869]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 4, 2016, 2:13 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41869/
> ---
> 
> (Updated Jan. 4, 2016, 2:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently Docker auth server is being configured via docker_auth_server flag, 
> but we should actually get the docker auth server information from docker 
> registry. This allows us to remove one flag and also support both public and 
> private docker registry.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> e73d4d785bccf1d50af9e91d2d20dafb444bec68 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/slave/flags.hpp 2b2679c1ae68d120756eaf81e5728d20791d6746 
>   src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/#review112481
---

Ship it!


I assume you've gotten all of them?

- Benjamin Hindman


On Dec. 28, 2015, 3:42 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41459/
> ---
> 
> (Updated Dec. 28, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4221
> https://issues.apache.org/jira/browse/MESOS-4221
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
> converting `_Deferred` to `std::function` must be done by explicitly calling 
> `_Deferred`'s conversion function.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c 
> 
> Diff: https://reviews.apache.org/r/41459/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41460/#review112480
---



3rdparty/libprocess/include/process/future.hpp (lines 220 - 223)


Now that we're not taking `f` as a universal reference for each of these 
methods it seems that we might make two copies (one when we invoke the function 
and the second when we capture `f` in the lambda)?

Can we add a TODO to move capture `f` once we have C++14? Or alternatively 
should we use `std::bind` here so we can explicitly move it and then convert 
back to lambda syntax once we have C++14?



3rdparty/libprocess/include/process/future.hpp (line 226)


I'd love to see a comment here that says:

This is the less prefered `onReady`, we prefer the `onReady` method which 
has `f` taking a `const T&` parameter. Unfortunately, to complicate matters, if 
`F` is a `std::bind` expression we need to SFINAE out this version of `onReady` 
and force the use of the preferred `onReady` (which thankfully works because 
`std::bind` will just ignore the `const T&` argument). This is necessary 
because Visual Studio 2015 doesn't support using the `std::bind` call operator 
with `std::result_of` as it's technically not a requirement by the C++ standard.

And then let's add a comment over the other `LessPrefer` variants that 
points up to the `onReady(F f, LessPrefer)` that includes this comment.



3rdparty/libprocess/include/process/future.hpp (lines 228 - 230)


Why do we need to capture/alias the type `F` as `G` again and then use it 
in `std::result_of::type`? Why can't we just use `F` there again?



3rdparty/libprocess/include/process/future.hpp (line 291)


This is another spot that looks like we could have a double copy?



3rdparty/libprocess/include/process/future.hpp (line 297)


Do you know which compilers will elide this `std::move`?



3rdparty/libprocess/include/process/future.hpp (line 309)


Double copy?


- Benjamin Hindman


On Dec. 28, 2015, 3:42 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41460/
> ---
> 
> (Updated Dec. 28, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4228
> https://issues.apache.org/jira/browse/MESOS-4228
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Standard (C++11 through 17) does not require `std::bind`'s function call 
> operator to SFINAE, and VS 2015's doesn't. `std::is_bind_expression` can be 
> used to manually reroute bind expressions to the 1-arg overload, where 
> (conveniently) the argument will be ignored if necessary.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c 
> 
> Diff: https://reviews.apache.org/r/41460/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41840: Moved docker spec to the top level.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41840/#review112483
---

Ship it!


Ship It!

- Gilbert Song


On Jan. 3, 2016, 10:30 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41840/
> ---
> 
> (Updated Jan. 3, 2016, 10:30 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved docker spec to the top level.
> 
> This is a part of a series patchs to clean up docker related code.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e 
>   src/docker/v1.hpp PRE-CREATION 
>   src/docker/v2.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/docker/message.hpp 
> 5c071432724f1c583b4dba1ed391e4af22c6ba8f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> e73d4d785bccf1d50af9e91d2d20dafb444bec68 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/slave/containerizer/mesos/provisioner/docker/spec.hpp 
> 1bd4ac10373fd95d2a22658715c6dbf81fbb567f 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
>   src/slave/containerizer/mesos/provisioner/docker/v1.proto 
> 5aec78b51726e4c840ffb47aacca0e1ec13c80d3 
>   src/slave/containerizer/mesos/provisioner/docker/v2.proto 
> fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41840/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41840: Moved docker spec to the top level.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41840/#review112487
---

Ship it!


Ship It!

- Timothy Chen


On Jan. 3, 2016, 6:30 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41840/
> ---
> 
> (Updated Jan. 3, 2016, 6:30 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved docker spec to the top level.
> 
> This is a part of a series patchs to clean up docker related code.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e 
>   src/docker/v1.hpp PRE-CREATION 
>   src/docker/v2.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/docker/message.hpp 
> 5c071432724f1c583b4dba1ed391e4af22c6ba8f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> e73d4d785bccf1d50af9e91d2d20dafb444bec68 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/slave/containerizer/mesos/provisioner/docker/spec.hpp 
> 1bd4ac10373fd95d2a22658715c6dbf81fbb567f 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
>   src/slave/containerizer/mesos/provisioner/docker/v1.proto 
> 5aec78b51726e4c840ffb47aacca0e1ec13c80d3 
>   src/slave/containerizer/mesos/provisioner/docker/v2.proto 
> fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41840/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41839: Renamed FsLayers in docker v2 image manifest to FsLayer.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41839/#review112486
---

Ship it!


Ship It!


src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 90)


s/Varify/Verify/g


- Timothy Chen


On Jan. 1, 2016, 9:21 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41839/
> ---
> 
> (Updated Jan. 1, 2016, 9:21 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed FsLayers in docker v2 image manifest to FsLayer.
> 
> This is a part of a series patchs to clean up docker related code.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
>   src/slave/containerizer/mesos/provisioner/docker/v2.proto 
> fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
> 
> Diff: https://reviews.apache.org/r/41839/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41842: Small style fixes in docker tests.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41842/#review112488
---

Ship it!


Ship It!

- Timothy Chen


On Jan. 1, 2016, 9:22 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41842/
> ---
> 
> (Updated Jan. 1, 2016, 9:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Small style fixes in docker tests.
> 
> This is a part of a series patchs to clean up docker related code.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 83eceacaddc38d0ccfc42e65e700a09406d8df36 
> 
> Diff: https://reviews.apache.org/r/41842/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 41868: Added credential to Docker image protobuf.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41868/
---

Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.


Repository: mesos


Description
---

Added credential to Docker image protobuf.


Diffs
-

  include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 

Diff: https://reviews.apache.org/r/41868/diff/


Testing
---

make


Thanks,

Timothy Chen

Review Request 41869: Removed Docker auth server flag.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41869/
---

Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.


Repository: mesos


Description
---

Currently Docker auth server is being configured via docker_auth_server flag, 
but we should actually get the docker auth server information from docker 
registry. This allows us to remove one flag and also support both public and 
private docker registry.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
e73d4d785bccf1d50af9e91d2d20dafb444bec68 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
049d46cad5cf94a3fb5d74cbfe649850311d35ad 
  src/slave/flags.hpp 2b2679c1ae68d120756eaf81e5728d20791d6746 
  src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 

Diff: https://reviews.apache.org/r/41869/diff/


Testing
---


Thanks,

Timothy Chen

Re: Review Request 40546: Fixed framework CPU counters on slave page.

[Ian Babrou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40546/
---

(Updated Jan. 4, 2016, 3:43 a.m.)


Review request for mesos, Jan Schlicht and Till Toenshoff.


Changes
---

Assinged reviewer and shepherd, fixed summary to adhere to our style.


Summary (updated)
-

Fixed framework CPU counters on slave page.


Bugs: MESOS-3972
https://issues.apache.org/jira/browse/MESOS-3972


Repository: mesos


Description (updated)
---

see summary


Diffs
-

  src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 

Diff: https://reviews.apache.org/r/40546/diff/


Testing
---


Thanks,

Ian Babrou

Re: Review Request 41850: [WIP][MESOS-3892] Add map to trace evictable executors

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41850/#review112508
---


It is suggested to use past tone for the Summary and please also add a period 
to the end of the Summary.


src/slave/slave.hpp (line 576)


s/If there's not enough resources,/If there are not enough resources for 
tasks requesting stateless reserved resources



src/slave/slave.cpp (line 3864)


This should be in another patch?


- Guangya Liu


On Jan. 3, 2016, 2:31 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41850/
> ---
> 
> (Updated Jan. 3, 2016, 2:31 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Before getting evictable executors for evicting, it need to trace which 
> execuotor can be evicted.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
> 
> Diff: https://reviews.apache.org/r/41850/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

[Guangya Liu]

> On Dec. 11, 2015, 7:47 p.m., Joseph Wu wrote:
> > src/common/resources.cpp, lines 1380-1382
> > 
> >
> > I'm not sure if this is necessary.  
> > 
> > To be as backwards compatible as possible, the `USAGE_SLACK` type would 
> > output as `{REV}`.  But is there any parsing of stringified `Resources` 
> > between the master and agent?
> 
> Klaus Ma wrote:
> The communitcation between master and agent should be fine, we passed all 
> UT with the patch.
> Just not sure whether the 3rd part application will pass endpoint's 
> output. If we updated it, we should drop an email to dev@; any comments?

The {REV}, {ALLOCATION_SLACK}, {USAGE_SLACK} are only for tracing some logs in 
master and agent, end user need to use API to set different revocable types. So 
I think that we can keep this as it is for now. Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review109993
---


On Dec. 12, 2015, 3:19 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> ---
> 
> (Updated Dec. 12, 2015, 3:19 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and 
> allocation slack.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 8ca2130 
>   include/mesos/v1/mesos.proto 8f357b0 
>   src/common/resources.cpp 5a79817 
>   src/tests/resources_tests.cpp ce47bac 
>   src/v1/resources.cpp d300842 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 41850: [WIP][MESOS-3892] Add map to trace evictable executors

[Guangya Liu]

> On Jan. 4, 2016, 7:19 a.m., Guangya Liu wrote:
> > It is suggested to use past tone for the Summary and please also add a 
> > period to the end of the Summary.

Please also update other patches for phase 1 to follow the above style.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41850/#review112508
---


On Jan. 3, 2016, 2:31 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41850/
> ---
> 
> (Updated Jan. 3, 2016, 2:31 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Before getting evictable executors for evicting, it need to trace which 
> execuotor can be evicted.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
> 
> Diff: https://reviews.apache.org/r/41850/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 41856: [WIP][MESOS-3892] helper functions to get allocation slack

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/
---

(Updated Jan. 4, 2016, 1:29 p.m.)


Review request for mesos and Guangya Liu.


Changes
---

Add evictingExecutors map


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
---

helper functions to get allocation slack


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 

Diff: https://reviews.apache.org/r/41856/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41869: Removed Docker auth server flag.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41869/#review112496
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 113)


Can we make this ```mutable``` and keep all the methods ```const``` ?



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 254)


Since realm is needed only for tokenmanager creation, this could be moved 
inside the block starting at L260.



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (lines 262 
- 263)


These 2 lines can be combined as: 

``` 
Try realmUrl = http::URL::parse(attributes.at("realm"));
```


- Jojy Varghese


On Jan. 4, 2016, 2:13 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41869/
> ---
> 
> (Updated Jan. 4, 2016, 2:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently Docker auth server is being configured via docker_auth_server flag, 
> but we should actually get the docker auth server information from docker 
> registry. This allows us to remove one flag and also support both public and 
> private docker registry.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> e73d4d785bccf1d50af9e91d2d20dafb444bec68 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/slave/flags.hpp 2b2679c1ae68d120756eaf81e5728d20791d6746 
>   src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41584: Added commit message guidelines to docs.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41584/#review112513
---

Ship it!


Ship It!

- Adam B


On Dec. 19, 2015, 12:18 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41584/
> ---
> 
> (Updated Dec. 19, 2015, 12:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added commit message guidelines to docs.
> 
> 
> Diffs
> -
> 
>   docs/submitting-a-patch.md f0048f51395422645a520b61815c1ae3c7004aa3 
> 
> Diff: https://reviews.apache.org/r/41584/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 41856: [WIP][MESOS-3892] helper functions to get allocation slack

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/#review112512
---



src/slave/slave.hpp (lines 392 - 400)


Can you please explain why not adding some global counters for 
totalAllocationSlack, pendingAllocationSlac, occupiedAllocationSlack etc?



src/slave/slave.hpp (line 399)


It is better add some comments for those helper functions especially for 
eviciting allocation slack which is used to calculate some potential allocation 
slack resources.



src/slave/slave.hpp (line 588)


It is better add more comments to explain this kind of executors.



src/slave/slave.cpp (line 3937)


Why account the queued task here? Does not this handled by 
framework->penging and framework->pendingExecutors?


- Guangya Liu


On Jan. 4, 2016, 5:29 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41856/
> ---
> 
> (Updated Jan. 4, 2016, 5:29 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> helper functions to get allocation slack
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
> 
> Diff: https://reviews.apache.org/r/41856/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

[Adam B]

> On Dec. 24, 2015, 2:27 a.m., Adam B wrote:
> > support/hooks/commit-msg, lines 6-7
> > 
> >
> > # To enable this hook, do this from the root of the repo:
> > #
> > # $ ln -s ../../support/hooks/commit-message .git/hooks/commit-message
> 
> Artem Harutyunyan wrote:
> In our case it's done automatically by the bootstrap script. It's part of 
> this same commit. Added a clarifying comment.

Seems like the other two hooks are enabled by bootstrap as well. Let's keep it 
consistent. I'll update this one to more closely resemble the others, "To 
enable this hook, run `bootstrap` or do this..."


> On Dec. 24, 2015, 2:27 a.m., Adam B wrote:
> > support/hooks/commit-msg, line 4
> > 
> >
> > "should"? Are you unsure if it will?
> 
> Artem Harutyunyan wrote:
> I believe that the `if it wants to stop the commit` part of the sentence 
> makes it pretty explicit, no? Again, this comment is part of the template 
> hook file. If you have a suggestion on how to rewrite it I'll gladly follow 
> it :-).

Edited to "The hook exits with non-zero status after..."


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41586/#review111839
---


On Dec. 30, 2015, 11:28 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41586/
> ---
> 
> (Updated Dec. 30, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Partially enforced commit message guidelines with a hook.
> 
> 
> Diffs
> -
> 
>   bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 
>   support/hooks/commit-msg PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41586/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review112507
---



src/slave/slave.cpp (lines 4631 - 4632)


I think it should be:

// Exclude oversubscription for reservation.
oversubscribed -= oversubscribed.allocationSlack();
oversubscribed += oversubscribable.get();

Seems you lost the new reported oversubscribed resources here.

To be more clear, what about update 4627 as:
oversubscribed += executor->resources.revocable().allocationSlack();


- Guangya Liu


On Jan. 2, 2016, 1 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated Jan. 2, 2016, 1 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/resource_estimator.hpp 27612ca 
>   src/slave/slave.cpp 9d80c96 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

[Alex Clemmer]

> On Nov. 4, 2015, 1:02 a.m., Michael Hopcroft wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp,
> >  line 14
> > 
> >
> > Recommend #pragma once. This is supported by VS. GCC supports it since 
> > version 3.4 (https://en.wikipedia.org/wiki/Pragma_once), but this shouldn't 
> > matter since we're discussing a Windows file. In general #pragma once is 
> > preferred over the #ifndef include guard mechanism, so the main question 
> > would pertain to consistency with the rest of the codebase. My 
> > recommendation is to use #pragma once for all new code and gradually 
> > migrate old code as it is edited.
> > 
> > I notice that the Google Style Guide recommends the #ifndef version. 
> > This may be a factor in deciding.

Per our proposal to the dev@ list, let's defer this until we're in SF with the 
Mesosphere folks, and we can just sweep over the entire codebase and do them 
all at once.


> On Nov. 4, 2015, 1:02 a.m., Michael Hopcroft wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp,
> >  line 64
> > 
> >
> > Google Style Guide isn't really clear on this one. I would recommend 
> > indenting line 66 to align with the open paren on line 65.
> 
> Joseph Wu wrote:
> Generally, we would go for this:
> ```
> return Error(
> "Reparse point attribute is not set for path '" +
> absolutePath.get() + "', and therefore it is not a sybolic link");
> ```
> Note: no period at the end of the message.

I agree with Joseph, as that does seem to be the style we use in Stout.


> On Nov. 4, 2015, 1:02 a.m., Michael Hopcroft wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp,
> >  line 55
> > 
> >
> > Google Style Guide allows auto if it help readability? Is it a good or 
> > bad idea here?
> 
> Joseph Wu wrote:
> In general, we don't use `auto` unless it's completely obvious from the 
> right-side what the type is.  In this case, you might expect `os::realpath` 
> to return a `std::string`, `Try`, `Option`, `Path`, 
> etc.

Joseph is correct. I think we should keep it as is.


> On Nov. 4, 2015, 1:02 a.m., Michael Hopcroft wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp,
> >  line 69
> > 
> >
> > I'd put a shorter comment here, something like "Open `HANDLE` for the 
> > symlink isself." In general I feel it is error prone to include a verbatem 
> > copy of the function's documentation here as it won't get updated, but 
> > could be confused for the function's documentation.

I chose to remove this and instead rename the variable to make it clear what 
the `HANDLE` points at.


> On Nov. 4, 2015, 1:02 a.m., Michael Hopcroft wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp,
> >  line 81
> > 
> >
> > Is it possible to leak a handle in the presence of an error? I guess if 
> > getSymbolicLinkData() can never throw you will always execute line 81.
> > 
> > Still, I would rather see RAII pattern involving any code with handles, 
> > just to be safe. This also future proofs the code against edits that make 
> > the logic more complex.

In this revision, I propose making a `typedef shared_ptr shared_handle` 
as a stand-in for `HANDLE`. Semantically, it's just a reference-counted 
`HANDLE`. It's slow but we don't care for this code path.


> On Nov. 4, 2015, 1:02 a.m., Michael Hopcroft wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line 
> > 64
> > 
> >
> > If you always return symlink.isSome(), then why use Try<>? Is it that 
> > other users of querySymbolicLinkData() actually care about getting an error 
> > back?
> > 
> > Even if you keep Try<> in the API, is it ok to silently ignore an error?

Yep, it's a `Try` because other places we call `querySymbolicLinkData` care 
about the error.

Whether it is ok to silently ignore an error depends on what you're trying to 
do. In this case, if for any reason we are unable to retrieve information about 
the symlink (via the `Symlink` struct), then we report that it is not a 
symlink. So it is reasonable to ignore the error, because we don't care what 
the error was.

Right?


> On Nov. 4, 2015, 1:02 a.m., Michael Hopcroft wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line 
> > 77
> > 
> >
> > When you say the size of 

Review Request 41870: [stout] Added ref-qualifiers to Option::get().

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/
---

Review request for mesos, Joris Van Remoortere and Michael Park.


Repository: mesos


Description
---

This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). 
This is in sync with what boost/folly `optional` already have.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
b58350b312c1969aa86ec679e95af0f97846c141 

Diff: https://reviews.apache.org/r/41870/diff/


Testing
---

make check

Verified this enables operations like the following to incur a move instead of 
a copy:

```
Option create();
T t = create().get();
```


Thanks,

Anand Mazumdar

Re: Review Request 41855: [WIP][MESOS-3982] Trace pending executors

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/#review112509
---



src/slave/slave.hpp (line 795)


Add a blank line before 
hashmap pendingExecutors;



src/slave/slave.cpp (line 5240)


It is better add this comment after `Slave::checkAvailabeResource` was 
added.

s/;/.


- Guangya Liu


On Jan. 3, 2016, 1:56 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41855/
> ---
> 
> (Updated Jan. 3, 2016, 1:56 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3982
> https://issues.apache.org/jira/browse/MESOS-3982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Trace the executor that are not launched; after launching, it's removed from 
> pendingExecutor list.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
> 
> Diff: https://reviews.apache.org/r/41855/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Alex Clemmer]

> On Dec. 15, 2015, 3:55 a.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line 
> > 62
> > 
> >
> > Nit: You're not reusing these, so might as well inline the calls.

You mean, just call `currentFile.compare` inline? I actualyl purposefully 
expanded this to make it "self-documenting" (to the extent anything can be). 
I'd like to keep them unless you're really opposed to this.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review110391
---


On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39584/
> ---
> 
> (Updated Nov. 16, 2015, 9:13 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::rmdir.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> a8c35c086ecae21701f6a720f25231c1b0d4e329 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 5c1df81193b4b888d2ed5c7dbfa0b5e2fae48467 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d 
> 
> Diff: https://reviews.apache.org/r/39584/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 41869: Removed Docker auth server flag.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41869/#review112502
---


Thanks Tim for taking care of this. I have been thinking that we should have 
TokenManager keep a map of  -> . This would help 
us to have any realm being handled by the registry_client + token manager. This 
way, all pull requests will request the TokenManager for a token with 
```getToken(realm, service, scope)```. TokenManager will lookup the cache and 
return the token or create a new item in the cache (after getting the token 
from realm).

What do you think?

- Jojy Varghese


On Jan. 4, 2016, 2:13 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41869/
> ---
> 
> (Updated Jan. 4, 2016, 2:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently Docker auth server is being configured via docker_auth_server flag, 
> but we should actually get the docker auth server information from docker 
> registry. This allows us to remove one flag and also support both public and 
> private docker registry.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> e73d4d785bccf1d50af9e91d2d20dafb444bec68 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/slave/flags.hpp 2b2679c1ae68d120756eaf81e5728d20791d6746 
>   src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

[Adam B]

> On Dec. 21, 2015, 7:46 a.m., Michael Park wrote:
> > src/master/http.cpp, line 1001
> > 
> >
> > We actually don't need this `if` statement. Although the `role` field 
> > is marked `optional`, we "fill it in" with the default value of `"*"` if 
> > unspecified by simply calling `role()`. `roleWhitelist` always has `"*"`.
> > 
> > 
> > https://github.com/apache/mesos/blob/master/src/master/master.cpp#L564-L565

But MPark, isn't it invalid to try to reserve resources for `*`? I thought each 
resource in the reserve operation was supposed to have a non-default role set. 
If so, we should either error here for a missing role, or ignore it here and 
error in operation::validate(), where we'd anyway need to validate for an 
explicit `*` (since it would pass the `has_role && isWhitelistedRole` test). 
Doesn't look like the current operation::validate checks that. Seems like a 
separate issue/patch though.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41472/#review111483
---


On Dec. 16, 2015, 2:48 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41472/
> ---
> 
> (Updated Dec. 16, 2015, 2:48 p.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-4143
> https://issues.apache.org/jira/browse/MESOS-4143
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added a test that dynamic reservations via the "/reserve" endpoint are
> allowed when using implicit roles.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 8dfd67f7d51b8395953d6beb77b2d71bc538eacd 
>   src/tests/reservation_endpoints_tests.cpp 
> b8edd6fafedd4c2221a8d19c1ebc71254071a8c7 
> 
> Diff: https://reviews.apache.org/r/41472/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41584: Added commit message guidelines to docs.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41584/#review112514
---

Ship it!


Ship It!

- Guangya Liu


On 十二月 19, 2015, 8:18 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41584/
> ---
> 
> (Updated 十二月 19, 2015, 8:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added commit message guidelines to docs.
> 
> 
> Diffs
> -
> 
>   docs/submitting-a-patch.md f0048f51395422645a520b61815c1ae3c7004aa3 
> 
> Diff: https://reviews.apache.org/r/41584/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 41850: [WIP][MESOS-3892] Add map to trace evictable executors

[Guangya Liu]

> On 一月 4, 2016, 7:19 a.m., Guangya Liu wrote:
> > It is suggested to use past tone for the Summary and please also add a 
> > period to the end of the Summary.
> 
> Guangya Liu wrote:
> Please also update other patches for phase 1 to follow the above style.

You can refer to https://reviews.apache.org/r/41584/ for more guidance of 
commit message.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41850/#review112508
---


On 一月 3, 2016, 2:31 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41850/
> ---
> 
> (Updated 一月 3, 2016, 2:31 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Before getting evictable executors for evicting, it need to trace which 
> execuotor can be evicted.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
> 
> Diff: https://reviews.apache.org/r/41850/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/
---

(Updated 一月 3, 2016, 9:34 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Bugs: MESOS-3890
https://issues.apache.org/jira/browse/MESOS-3890


Repository: mesos


Description
---

Added notion of evictable task to RunTaskMessage.


Diffs
-

  src/messages/messages.proto b66bac14056407140bb3cf5aa3e67ac94df1a2f8 

Diff: https://reviews.apache.org/r/40532/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 41791: Updated allocation slack when dynamic reservation was updated.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41791/#review112443
---


I think it's too early to update total allocation slack here; my suggestion to 
handle dynamic reservation:

1. Did not reduce total allocation slack in updateAllocation/updateAvailable; 
but if no allocated ALLOCATIONS_SLACK, it's fine to shrink it.
2. In agent, if new checkpointed resources is smaller, evict executors if 
necessary.
3. In allocator, did not send evicting unreserved resources (allocationSlack - 
stateless.reserved)
4. In Allocator::recoverResources, if total allocation slack is smaller than 
stateless.reserved, shrink total allocation slack.

- Klaus Ma


On Jan. 3, 2016, 5:22 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41791/
> ---
> 
> (Updated Jan. 3, 2016, 5:22 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4145
> https://issues.apache.org/jira/browse/MESOS-4145
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated allocation slack when dynamic reservation was updated.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 7f900c4e024485704d79e57ae22407557598fe6c 
>   src/tests/hierarchical_allocator_tests.cpp 
> e044f832c2c16e53e663c6ced5452649bb0dcb59 
> 
> Diff: https://reviews.apache.org/r/41791/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41848: Do not enable task and executor run on different resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/
---

(Updated 一月 3, 2016, 9:26 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Summary (updated)
-

Do not enable task and executor run on different resources.


Bugs: MESOS-3931
https://issues.apache.org/jira/browse/MESOS-3931


Repository: mesos


Description (updated)
---

Do not enable task and its executor run on different resources. They
must run on same kind of resources, either non-revocable resources, usage
slack resources or allocation slack resources.


Diffs
-

  src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 
  src/tests/master_validation_tests.cpp 
fbf8fadbc04a7cbc60ee6091e0224339389b400f 

Diff: https://reviews.apache.org/r/41848/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 41862: Fix containerizer-internals Posix launcher TBD.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41862/
---

Review request for mesos, Jie Yu and Timothy Chen.


Bugs: MESOS-4268
https://issues.apache.org/jira/browse/MESOS-4268


Repository: mesos


Description
---

Fix containerizer-internals Posix launcher TBD.


Diffs
-

  docs/containerizer-internals.md f620c32cdd4dd7cf6f245fad4e50925531cb4a39 

Diff: https://reviews.apache.org/r/41862/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 41789: Add put method for http PUT request.

[Joerg Schad]

> On Jan. 3, 2016, 10:48 a.m., Joerg Schad wrote:
> > This pretty much duplicates https://reviews.apache.org/r/39466/ (except 
> > also has a test case). Even though the long term approach should be to 
> > replace all the individual http method call with a general one (accepting a 
> > Request object), we should decide which of these reviews we want to 
> > commit/focus on right now.

Ah saw just above comment about this being tempory, would be good to add that 
in the description . Thanks :-).


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/#review112445
---


On Jan. 3, 2016, 10:38 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41789/
> ---
> 
> (Updated Jan. 3, 2016, 10:38 a.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil 
> Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add put method for http PUT request.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
> 
> Diff: https://reviews.apache.org/r/41789/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41713: Added HDFS URI fetcher plugin.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41713/#review112444
---


Hardcoded hadoop schemes? Eek! Guess we'll have to reopen MESOS-1711?


src/uri/fetchers/hadoop.cpp (line 54)


Why is this hardcoded again? We moved away from that for 
https://issues.apache.org/jira/browse/MESOS-1711 but now tachyon/maprfs users 
will be broken (again).
Can we make the supported schemes a plugin flag/parameter, so users can 
adjust as needed?


- Adam B


On Dec. 30, 2015, 9:35 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41713/
> ---
> 
> (Updated Dec. 30, 2015, 9:35 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, Ian Downes, Timothy Chen, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-3925
> https://issues.apache.org/jira/browse/MESOS-3925
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HDFS URI fetcher plugin. This patch also adjusted the plugin 
> initialization logic so that flags can be used to initialize each plugin.
> 
> 
> Diffs
> -
> 
>   include/mesos/uri/fetcher.hpp 6cf7b37818ceff64ffe56138ebd4bc7e2abe5a7c 
>   include/mesos/uri/uri.hpp aa3ab5d24bb8c501dd19e93d7563cb0afd889f23 
>   src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
>   src/tests/uri_fetcher_tests.cpp d54a7e7b08a741b1d5d371c11747681ae4ddef98 
>   src/uri/fetcher.hpp PRE-CREATION 
>   src/uri/fetcher.cpp 8bd7cf3d638a737c40183294cb4548a4851e0886 
>   src/uri/fetchers/curl.hpp 401829d1990ec817ea069ce45f902c521cd1a937 
>   src/uri/fetchers/curl.cpp 6c607a6a800374b6e14b37bfdc6b04e7a4e87892 
>   src/uri/fetchers/hadoop.hpp PRE-CREATION 
>   src/uri/fetchers/hadoop.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41713/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41772: Added helper function to flatten resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41772/
---

(Updated 一月 3, 2016, 9:42 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, and Klaus Ma.


Bugs: MESOS-4267
https://issues.apache.org/jira/browse/MESOS-4267


Repository: mesos


Description
---

Added two new helper functions to flatten resources.
1) Flatten reserved resources.
2) Flatten allocation slack revocable resources.


Diffs
-

  include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
  include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
  src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 
  src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
  src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 

Diff: https://reviews.apache.org/r/41772/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review112442
---

Ship it!


Great. I'm fixing the pointer style as I commit.


src/tests/common/http_tests.cpp (line 87)


`s/IPAddress */IPAddress* /`



src/tests/slave_tests.cpp (lines 2206 - 2209)


`s/IPAddress */IPAddress* /`


- Adam B


On Dec. 29, 2015, 10:44 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 29, 2015, 10:44 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/#review112441
---

Ship it!


Looks good. I'm cleaning up the comments before I commit.


include/mesos/mesos.proto (lines 1557 - 1560)


Re-wrap.
I also removed some fluff so this fits on 3 lines: "This field represents", 
"potentially", and s/for instance,/e.g./
```
// The backend port on which the task is running. This could be different 
than
// the `number` field (1), e.g. when an agent achieves network isolation
// between containers using port (layer 4) segregation.
```



include/mesos/mesos.proto (lines 1577 - 1579)


TODOs don't use a space before the `(userid)`.
Let's add the missing field as a comment, so we can easily see what we're 
omitting.
Also reworded to emphasize the skipped tag `1` rather than ip_address using 
tag `2`, and binary compatibility over backwards compatibility:
```
// TODO(asridharan): We skip tag number 1 in case we later want to be binary
// compatible with `NetworkInfo.IPAddress`. See MESOS-4243 for more details.
// optional Protocol protocol = 1;
```


- Adam B


On Dec. 28, 2015, 5:10 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41380/
> ---
> 
> (Updated Dec. 28, 2015, 5:10 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Bugs: MESOS-4114
> https://issues.apache.org/jira/browse/MESOS-4114
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added repeated vip field to DiscoveryInfo and an instance_port field to Port
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
>   include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 
> 
> Diff: https://reviews.apache.org/r/41380/diff/
> 
> 
> Testing
> ---
> 
> make check, and make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41789: Add put method for http PUT request.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/#review112445
---


This pretty much duplicates https://reviews.apache.org/r/39466/ (except also 
has a test case). Even though the long term approach should be to replace all 
the individual http method call with a general one (accepting a Request 
object), we should decide which of these reviews we want to commit/focus on 
right now.

- Joerg Schad


On Jan. 3, 2016, 10:38 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41789/
> ---
> 
> (Updated Jan. 3, 2016, 10:38 a.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil 
> Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add put method for http PUT request.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
> 
> Diff: https://reviews.apache.org/r/41789/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 39466: Added http::put request method.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39466/#review112447
---


Patch looks great!

Reviews applied: [39466]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 2, 2016, 1:47 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39466/
> ---
> 
> (Updated Jan. 2, 2016, 1:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3763
> https://issues.apache.org/jira/browse/MESOS-3763
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added http::put request method.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 19261502be220aaa40add7ce30a9b2b65d1d9fdc 
> 
> Diff: https://reviews.apache.org/r/39466/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 41791: Updated allocation slack when dynamic reservation was updated.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41791/
---

(Updated 一月 3, 2016, 9:22 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Summary (updated)
-

Updated allocation slack when dynamic reservation was updated.


Bugs: MESOS-4145
https://issues.apache.org/jira/browse/MESOS-4145


Repository: mesos


Description (updated)
---

Updated allocation slack when dynamic reservation was updated.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
7f900c4e024485704d79e57ae22407557598fe6c 
  src/tests/hierarchical_allocator_tests.cpp 
e044f832c2c16e53e663c6ced5452649bb0dcb59 

Diff: https://reviews.apache.org/r/41791/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41847: Updated allocation slack when slave was updated.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41847/
---

(Updated 一月 3, 2016, 9:22 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Summary (updated)
-

Updated allocation slack when slave was updated.


Bugs: MESOS-4145
https://issues.apache.org/jira/browse/MESOS-4145


Repository: mesos


Description (updated)
---

Updated allocation slack when slave was updated.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
7f900c4e024485704d79e57ae22407557598fe6c 
  src/tests/hierarchical_allocator_tests.cpp 
e044f832c2c16e53e663c6ced5452649bb0dcb59 

Diff: https://reviews.apache.org/r/41847/diff/


Testing (updated)
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40632/
---

(Updated 一月 3, 2016, 9:21 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Summary (updated)
-

Enabled oversubscribed resources for reservations in allocator.


Bugs: MESOS-4145
https://issues.apache.org/jira/browse/MESOS-4145


Repository: mesos


Description
---

Enabled oversubscribed resources for reservations in allocator.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
7f900c4e024485704d79e57ae22407557598fe6c 
  src/tests/hierarchical_allocator_tests.cpp 
e044f832c2c16e53e663c6ced5452649bb0dcb59 

Diff: https://reviews.apache.org/r/40632/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41346: WIP: Evict some executors if there are not enough reserved resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41346/
---

(Updated 一月 3, 2016, 9:47 a.m.)


Review request for mesos and Jian Qiu.


Repository: mesos


Description
---

Evict some executors if there are not enough reserved resources.


Diffs
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe 

Diff: https://reviews.apache.org/r/41346/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 40456: MESOS-3950: show running task count in web ui

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40456/#review112461
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Nov. 20, 2015, 5:01 p.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40456/
> ---
> 
> (Updated Nov. 20, 2015, 5:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3950: show running task count in web ui
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/home.html 4fc64c0aea558fca18083dc317f8370670d7a4d3 
>   src/webui/master/static/js/controllers.js 
> ccf5c31715e298e96f493cce58921bfe6b16b779 
>   src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 
> 
> Diff: https://reviews.apache.org/r/40456/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 41862: Fix containerizer-internals Posix launcher TBD.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41862/#review112456
---


Patch looks great!

Reviews applied: [41862]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 3, 2016, 10:24 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41862/
> ---
> 
> (Updated Jan. 3, 2016, 10:24 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4268
> https://issues.apache.org/jira/browse/MESOS-4268
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix containerizer-internals Posix launcher TBD.
> 
> 
> Diffs
> -
> 
>   docs/containerizer-internals.md f620c32cdd4dd7cf6f245fad4e50925531cb4a39 
> 
> Diff: https://reviews.apache.org/r/41862/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 41865: Use full width for mesos div.container

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41865/
---

Review request for mesos, Bernd Mathiske and Michael Lunøe.


Bugs: MESOS-2585
https://issues.apache.org/jira/browse/MESOS-2585


Repository: mesos


Description
---

Use full width for mesos div.container


Diffs
-

  src/webui/master/static/css/mesos.css 
5b1227e9d64757f9fc106e497f7fa3ed72112c10 

Diff: https://reviews.apache.org/r/41865/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 41254: Enabled master get ALLOCATION_SLACK metrics.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41254/#review112460
---


Patch looks great!

Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339, 40632, 41847, 
41791, 41848, 41246, 41248, 41250, 41254]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 3, 2016, 1:31 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41254/
> ---
> 
> (Updated Jan. 3, 2016, 1:31 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4124
> https://issues.apache.org/jira/browse/MESOS-4124
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable master get ALLOCATION_SLACK metrics.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/metrics.hpp 551e4eb0f910aa4ce28a2a955019108fcd3d6371 
>   src/master/metrics.cpp 5e4f4d352579dcd391a133600f9d4abc6b2402a7 
>   src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 
> 
> Diff: https://reviews.apache.org/r/41254/diff/
> 
> 
> Testing
> ---
> 
> $ curl "http://192.168.0.107:5050/metrics/snapshot; 2>/dev/null| jq . | grep 
> allocation_slack
>   "master/cpus_allocation_slack_percent": 0,
>   "master/cpus_allocation_slack_total": 3,
>   "master/cpus_allocation_slack_used": 0,
>   "master/disk_allocation_slack_percent": 0,
>   "master/disk_allocation_slack_total": 0,
>   "master/disk_allocation_slack_used": 0,
>   "master/mem_allocation_slack_percent": 0,
>   "master/mem_allocation_slack_total": 1000,
>   "master/mem_allocation_slack_used": 0,
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 41863: Fixed a typo in the log message

[Ryuichi Okumura]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41863/
---

Review request for mesos.


Bugs: MESOS-4269
https://issues.apache.org/jira/browse/MESOS-4269


Repository: mesos


Description
---

Fixed a typo in the log message


Diffs
-

  src/linux/cgroups.cpp bbc1fb3c60e53dffb1e8029942725e7102eb9aee 

Diff: https://reviews.apache.org/r/41863/diff/


Testing
---


Thanks,

Ryuichi Okumura

Re: Review Request 41854: Added module initialization to Master main() method

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41854/#review112448
---


Patch looks great!

Reviews applied: [41760, 41854]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 3, 2016, 1:32 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41854/
> ---
> 
> (Updated Jan. 3, 2016, 1:32 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Kapil Arya.
> 
> 
> Bugs: MESOS-4253
> https://issues.apache.org/jira/browse/MESOS-4253
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added module initialization to Master main() method
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp e00f878770f3e0bddae5a137b50a00822d154e2c 
>   src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 
> 
> Diff: https://reviews.apache.org/r/41854/diff/
> 
> 
> Testing
> ---
> 
> All unit tests pass.
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 41254: Enabled master get ALLOCATION_SLACK metrics.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41254/
---

(Updated 一月 3, 2016, 1:31 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, and Klaus Ma.


Bugs: MESOS-4124
https://issues.apache.org/jira/browse/MESOS-4124


Repository: mesos


Description
---

Enable master get ALLOCATION_SLACK metrics.


Diffs (updated)
-

  src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/metrics.hpp 551e4eb0f910aa4ce28a2a955019108fcd3d6371 
  src/master/metrics.cpp 5e4f4d352579dcd391a133600f9d4abc6b2402a7 
  src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 

Diff: https://reviews.apache.org/r/41254/diff/


Testing (updated)
---

$ curl "http://192.168.0.107:5050/metrics/snapshot; 2>/dev/null| jq . | grep 
allocation_slack
  "master/cpus_allocation_slack_percent": 0,
  "master/cpus_allocation_slack_total": 3,
  "master/cpus_allocation_slack_used": 0,
  "master/disk_allocation_slack_percent": 0,
  "master/disk_allocation_slack_total": 0,
  "master/disk_allocation_slack_used": 0,
  "master/mem_allocation_slack_percent": 0,
  "master/mem_allocation_slack_total": 1000,
  "master/mem_allocation_slack_used": 0,


Thanks,

Guangya Liu

Re: Review Request 41248: Enabled master get USAGE_SLACK metrics.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41248/
---

(Updated 一月 3, 2016, 1:31 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, and Klaus Ma.


Bugs: MESOS-4123
https://issues.apache.org/jira/browse/MESOS-4123


Repository: mesos


Description
---

Enabled master get USAGE_SLACK metrics.


Diffs (updated)
-

  src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/metrics.hpp 551e4eb0f910aa4ce28a2a955019108fcd3d6371 
  src/master/metrics.cpp 5e4f4d352579dcd391a133600f9d4abc6b2402a7 
  src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 

Diff: https://reviews.apache.org/r/41248/diff/


Testing (updated)
---

$ curl "http://192.168.0.107:5050/metrics/snapshot; 2>/dev/null| jq . | grep 
usage_slack
  "master/cpus_usage_slack_percent": 0,
  "master/cpus_usage_slack_total": 0,
  "master/cpus_usage_slack_used": 0,
  "master/disk_usage_slack_percent": 0,
  "master/disk_usage_slack_total": 0,
  "master/disk_usage_slack_used": 0,
  "master/mem_usage_slack_percent": 0,
  "master/mem_usage_slack_total": 0,
  "master/mem_usage_slack_used": 0,


Thanks,

Guangya Liu

Re: Review Request 41246: Enabled slave get USAGE_SLACK metrics.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41246/
---

(Updated 一月 3, 2016, 1:31 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, and Klaus Ma.


Bugs: MESOS-4123
https://issues.apache.org/jira/browse/MESOS-4123


Repository: mesos


Description
---

Enabled slave get USAGE_SLACK metrics.


Diffs (updated)
-

  src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
  src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
  src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 

Diff: https://reviews.apache.org/r/41246/diff/


Testing (updated)
---

$ curl "http://192.168.0.107:5051/metrics/snapshot; 2>/dev/null| jq . | grep 
usage_slack
  "slave/cpus_usage_slack_percent": 0,
  "slave/cpus_usage_slack_total": 0,
  "slave/cpus_usage_slack_used": 0,
  "slave/disk_usage_slack_percent": 0,
  "slave/disk_usage_slack_total": 0,
  "slave/disk_usage_slack_used": 0,
  "slave/mem_usage_slack_percent": 0,
  "slave/mem_usage_slack_total": 0,
  "slave/mem_usage_slack_used": 0,


Thanks,

Guangya Liu

Re: Review Request 40456: MESOS-3950: show running task count in web ui

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40456/#review112455
---

Ship it!


Ship It!

- haosdent huang


On Nov. 20, 2015, 5:01 p.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40456/
> ---
> 
> (Updated Nov. 20, 2015, 5:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3950: show running task count in web ui
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/home.html 4fc64c0aea558fca18083dc317f8370670d7a4d3 
>   src/webui/master/static/js/controllers.js 
> ccf5c31715e298e96f493cce58921bfe6b16b779 
>   src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 
> 
> Diff: https://reviews.apache.org/r/40456/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 40456: MESOS-3950: show running task count in web ui

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40456/#review112454
---

Ship it!


Ship It!

- haosdent huang


On Nov. 20, 2015, 5:01 p.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40456/
> ---
> 
> (Updated Nov. 20, 2015, 5:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3950: show running task count in web ui
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/home.html 4fc64c0aea558fca18083dc317f8370670d7a4d3 
>   src/webui/master/static/js/controllers.js 
> ccf5c31715e298e96f493cce58921bfe6b16b779 
>   src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 
> 
> Diff: https://reviews.apache.org/r/40456/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Review Request 41864: Web UI Display Bug when starting lots of tasks with small cpu value on frameworks tab.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41864/
---

Review request for mesos, Ben Mahler and Jie Yu.


Bugs: MESOS-2635
https://issues.apache.org/jira/browse/MESOS-2635


Repository: mesos


Description
---

Web UI Display Bug when starting lots of tasks with small cpu value on 
frameworks tab.


Diffs
-

  src/webui/master/static/frameworks.html 
44ef2e55c1e37bb74f769842fe1babffe31a8ea9 

Diff: https://reviews.apache.org/r/41864/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

[Guangya Liu]

> On 十二月 17, 2015, 10:43 a.m., Klaus Ma wrote:
> > src/slave/slave.cpp, line 5194
> > 
> >
> > So we are going to only cover `SCALAR` resources? Is that necessary?

metrics/snapshot should expose metrics on allocation slack resources (allocated 
and available), the limitation is that only SCALAR resources will be covered 
for now.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41250/#review110934
---


On 一月 3, 2016, 1:31 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41250/
> ---
> 
> (Updated 一月 3, 2016, 1:31 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4124
> https://issues.apache.org/jira/browse/MESOS-4124
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled slave get ALLOCATION_SLACK metrics.
> 
> 
> Diffs
> -
> 
>   src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
>   src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
>   src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 
> 
> Diff: https://reviews.apache.org/r/41250/diff/
> 
> 
> Testing
> ---
> 
> $ curl "http://192.168.0.107:5051/metrics/snapshot; 2>/dev/null| jq . | grep 
> allocation_slack
>   "slave/cpus_allocation_slack_percent": 0,
>   "slave/cpus_allocation_slack_total": 3,
>   "slave/cpus_allocation_slack_used": 0,
>   "slave/disk_allocation_slack_percent": 0,
>   "slave/disk_allocation_slack_total": 0,
>   "slave/disk_allocation_slack_used": 0,
>   "slave/mem_allocation_slack_percent": 0,
>   "slave/mem_allocation_slack_total": 1000,
>   "slave/mem_allocation_slack_used": 0,
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41864: Web UI Display Bug when starting lots of tasks with small cpu value on frameworks tab.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41864/
---

(Updated Jan. 3, 2016, 2:39 p.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Changes
---

Let filter declare place match exist filters.


Bugs: MESOS-2635
https://issues.apache.org/jira/browse/MESOS-2635


Repository: mesos


Description
---

Web UI Display Bug when starting lots of tasks with small cpu value on 
frameworks tab.


Diffs (updated)
-

  src/webui/master/static/frameworks.html 
44ef2e55c1e37bb74f769842fe1babffe31a8ea9 
  src/webui/master/static/js/app.js 543fe9efb9618b311c7f21b7771a251738b01a91 
  src/webui/master/static/js/controllers.js 
ccf5c31715e298e96f493cce58921bfe6b16b779 

Diff: https://reviews.apache.org/r/41864/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 41713: Added HDFS URI fetcher plugin.

[Jie Yu]

> On Jan. 3, 2016, 10:50 a.m., Adam B wrote:
> > src/uri/fetchers/hadoop.cpp, line 54
> > 
> >
> > Why is this hardcoded again? We moved away from that for 
> > https://issues.apache.org/jira/browse/MESOS-1711 but now tachyon/maprfs 
> > users will be broken (again).
> > Can we make the supported schemes a plugin flag/parameter, so users can 
> > adjust as needed?

Yeah, I'll follow up with a patch to allow users to configure schemes through a 
flag.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41713/#review112444
---


On Dec. 31, 2015, 5:35 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41713/
> ---
> 
> (Updated Dec. 31, 2015, 5:35 a.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, Ian Downes, Timothy Chen, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-3925
> https://issues.apache.org/jira/browse/MESOS-3925
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HDFS URI fetcher plugin. This patch also adjusted the plugin 
> initialization logic so that flags can be used to initialize each plugin.
> 
> 
> Diffs
> -
> 
>   include/mesos/uri/fetcher.hpp 6cf7b37818ceff64ffe56138ebd4bc7e2abe5a7c 
>   include/mesos/uri/uri.hpp aa3ab5d24bb8c501dd19e93d7563cb0afd889f23 
>   src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
>   src/tests/uri_fetcher_tests.cpp d54a7e7b08a741b1d5d371c11747681ae4ddef98 
>   src/uri/fetcher.hpp PRE-CREATION 
>   src/uri/fetcher.cpp 8bd7cf3d638a737c40183294cb4548a4851e0886 
>   src/uri/fetchers/curl.hpp 401829d1990ec817ea069ce45f902c521cd1a937 
>   src/uri/fetchers/curl.cpp 6c607a6a800374b6e14b37bfdc6b04e7a4e87892 
>   src/uri/fetchers/hadoop.hpp PRE-CREATION 
>   src/uri/fetchers/hadoop.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41713/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41840: Moved docker spec to the top level.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41840/
---

(Updated Jan. 3, 2016, 6:30 p.m.)


Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.


Changes
---

Added a missing include.


Repository: mesos


Description
---

Moved docker spec to the top level.

This is a part of a series patchs to clean up docker related code.


Diffs (updated)
-

  src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e 
  src/docker/v1.hpp PRE-CREATION 
  src/docker/v2.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/docker/message.hpp 
5c071432724f1c583b4dba1ed391e4af22c6ba8f 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
e73d4d785bccf1d50af9e91d2d20dafb444bec68 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
049d46cad5cf94a3fb5d74cbfe649850311d35ad 
  src/slave/containerizer/mesos/provisioner/docker/spec.hpp 
1bd4ac10373fd95d2a22658715c6dbf81fbb567f 
  src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
  src/slave/containerizer/mesos/provisioner/docker/v1.proto 
5aec78b51726e4c840ffb47aacca0e1ec13c80d3 
  src/slave/containerizer/mesos/provisioner/docker/v2.proto 
fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 

Diff: https://reviews.apache.org/r/41840/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41861/
---

(Updated Jan. 3, 2016, 6:33 p.m.)


Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.


Changes
---

Rebased.


Repository: mesos


Description
---

Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

According to Docker v2 image manifest spec, v1Compatibility is a string 
containing a raw JSON object. The raw JSON object is v1::ImageManifest. This 
patch fixed the bug in the original code.


Diffs (updated)
-

  src/docker/spec.cpp 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
  src/docker/v2.proto fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
049d46cad5cf94a3fb5d74cbfe649850311d35ad 
  src/tests/containerizer/docker_spec_tests.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 

Diff: https://reviews.apache.org/r/41861/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 41865: Use full width for mesos div.container

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41865/#review112473
---


Patch looks great!

Reviews applied: [41865]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 3, 2016, 3:08 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41865/
> ---
> 
> (Updated Jan. 3, 2016, 3:08 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Michael Lunøe.
> 
> 
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use full width for mesos div.container
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
> 
> Diff: https://reviews.apache.org/r/41865/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39466: Added http::put request method.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39466/#review112474
---


Thanks [~joerg84] for the patch. Can you help me understand why aren't we going 
forward with the following approach as had been already alluded to by 
[~bmahler] on the JIRA:

- Expose the `internal::http::request` function in the header and not add an 
additional method/overload for `put` function at all.
- We might at a latter point of time try to clean the other instances of 
`post/get` to use the `http::request` method.

To me, we don't seem to be gaining much by adding these additional 
method/overloads for the `put` method when we eventually would want to move 
away from them. For one, they are making the eventual cleanup harder. What do 
you think ?

- Anand Mazumdar


On Jan. 2, 2016, 1:47 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39466/
> ---
> 
> (Updated Jan. 2, 2016, 1:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3763
> https://issues.apache.org/jira/browse/MESOS-3763
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added http::put request method.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 19261502be220aaa40add7ce30a9b2b65d1d9fdc 
> 
> Diff: https://reviews.apache.org/r/39466/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 41863: Fixed a typo in the log message

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41863/#review112463
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Jan. 3, 2016, 2:09 p.m., Ryuichi Okumura wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41863/
> ---
> 
> (Updated Jan. 3, 2016, 2:09 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4269
> https://issues.apache.org/jira/browse/MESOS-4269
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a typo in the log message
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp bbc1fb3c60e53dffb1e8029942725e7102eb9aee 
> 
> Diff: https://reviews.apache.org/r/41863/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ryuichi Okumura
> 
>

Re: Review Request 41864: Web UI Display Bug when starting lots of tasks with small cpu value on frameworks tab.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41864/#review112467
---


Patch looks great!

Reviews applied: [41864]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 3, 2016, 2:39 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41864/
> ---
> 
> (Updated Jan. 3, 2016, 2:39 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-2635
> https://issues.apache.org/jira/browse/MESOS-2635
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Web UI Display Bug when starting lots of tasks with small cpu value on 
> frameworks tab.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/frameworks.html 
> 44ef2e55c1e37bb74f769842fe1babffe31a8ea9 
>   src/webui/master/static/js/app.js 543fe9efb9618b311c7f21b7771a251738b01a91 
>   src/webui/master/static/js/controllers.js 
> ccf5c31715e298e96f493cce58921bfe6b16b779 
> 
> Diff: https://reviews.apache.org/r/41864/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41861/#review112475
---


Patch looks great!

Reviews applied: [41839, 41840, 41841, 41842, 41843, 41861]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 3, 2016, 6:33 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41861/
> ---
> 
> (Updated Jan. 3, 2016, 6:33 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.
> 
> According to Docker v2 image manifest spec, v1Compatibility is a string 
> containing a raw JSON object. The raw JSON object is v1::ImageManifest. This 
> patch fixed the bug in the original code.
> 
> 
> Diffs
> -
> 
>   src/docker/spec.cpp 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
>   src/docker/v2.proto fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/tests/containerizer/docker_spec_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41861/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>