Re: Review Request 45097: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

[fan du]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45097/
---

(Updated 三月 22, 2016, 6:42 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Fix coredump reported by test roboot


Bugs: MESOS-4981
https://issues.apache.org/jira/browse/MESOS-4981


Repository: mesos


Description
---

This change will cover three cases:
1. Directly call {re}registerFramework
2. Through HTTP call
3. Through MesosSchedulerDriver

And don't overlap 'master/messages_register_framework' with
'master/messages_reregister_framework'.


Diffs (updated)
-

  src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f 

Diff: https://reviews.apache.org/r/45097/diff/


Testing (updated)
---

1. I can use 'docker-no-executor-framework' to reproduce/verify the issue.

"master/messages_register_framework": 1.0,
"master/messages_reregister_framework": 0.0,

2. Fix make check error by implementing 'minus' operation correctly for Counter.

make check GTEST_FILTER="AuthenticationTest*"
[--] 21 tests from AuthenticationTest (7019 ms total)

[--] Global test environment tear-down
[==] 21 tests from 1 test case ran. (7140 ms total)
[  PASSED  ] 21 tests.


Thanks,

fan du

Re: Review Request 45096: Introduce 'minus' operator for class Counter.

[fan du]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45096/
---

(Updated 三月 22, 2016, 6:42 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Implement 'minus' operation for Counter correctly.


Bugs: MESOS-4981
https://issues.apache.org/jira/browse/MESOS-4981


Repository: mesos


Description
---

Introduce 'minus' operator for class Counter.


Diffs (updated)
-

  3rdparty/libprocess/include/process/metrics/counter.hpp 
a13cc7e18c8b23eae83c326d63874d9d2aaedc0d 

Diff: https://reviews.apache.org/r/45096/diff/


Testing
---


Thanks,

fan du

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44622/
---

(Updated March 22, 2016, 2:40 p.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759


Repository: mesos


Description
---

Introduced a protobuf message "NetworkResult".


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/cni/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/cni/spec.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/cni/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/44622/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45123/
---

(Updated March 22, 2016, 6:24 a.m.)


Review request for mesos, Jie Yu and Joris Van Remoortere.


Changes
---

Tweak docs.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

Updated docs for deletion of persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
  docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
  docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338 

Diff: https://reviews.apache.org/r/45123/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45011/#review124740
---



Patch looks great!

Reviews applied: [45011]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 18, 2016, 10:49 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45011/
> ---
> 
> (Updated March 18, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Neil Conway, and Cong Wang.
> 
> 
> Bugs: MESOS-4070
> https://issues.apache.org/jira/browse/MESOS-4070
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This fix updated the implementation of numify() so that negative numbers
> could be handled conssitently for hex and non-hex numbers.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 
> 26a637bec1193dd51437bd689c34fbe6d1935d89 
>   3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp 
> 444377df00922df12d4b3ed25b4cfe9071cff5c3 
> 
> Diff: https://reviews.apache.org/r/45011/diff/
> 
> 
> Testing
> ---
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44450/
---

(Updated March 22, 2016, 5:50 a.m.)


Review request for mesos, Adam B and Alexander Rukletsov.


Changes
---

Addressed comments of Adam.


Bugs: MESOS-4881
https://issues.apache.org/jira/browse/MESOS-4881


Repository: mesos


Description
---

Rescind all outstanding offers to satisfy weights update.


Diffs (updated)
-

  src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
  src/master/weights_handler.cpp c9a1b0d9adbeb1e165999cdbb4f295b24f10b18f 

Diff: https://reviews.apache.org/r/44450/diff/


Testing
---

Make && Make check.

Manual test steps:

- Start Mesos master:
$ ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/tmp/mesos-master

- Start Mesos slave:
$ ./bin/mesos-slave.sh --master=127.0.0.1:5050

- Register a framwork with `curl`
$ curl -v http://127.0.0.1:5050/api/v1/scheduler -H "Content-type: 
application/json" -X POST -d @subscribe.json
$  cat subscribe.json
{
   "type": "SUBSCRIBE",

   "subscribe" : {
  "framework_info": {
  "user" :  "root",
  "name" :  "comsumer c1 HTTP Framework",
  "role" :  "mesos",
  "principal":"wyq"
  },

  "force" : true
  }
}

And this framework will receive an offer:
{"subscribed":{"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"}},"type":"SUBSCRIBED"}20
{"type":"HEARTBEAT"}680
{"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O0"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20
{"type":"HEARTBEAT"}20

- Update the weight of role `mesos`
$ curl --data "[{\"weight\":1.8,\"role\":\"mesos\"}]" -X PUT 
http://127.0.0.1:5050/weights

Receive an rescind offer, and a new offer received:
{"rescind":{"offer_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680
{"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20
{"type":"HEARTBEAT"}20

- Update the weight of role `mesos1`
$ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT 
http://127.0.0.1:5050/weights

- The outstanding offer will not be rescinded.


(TODO) I will add couple of tests for this patch in another JIRA.


Thanks,

Yongqiao Wang

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45014/#review124735
---



Instead of handling /containers endpoint in Slave, I would suggest we dispatch 
the request to ResourceMonitor. I will rename ResourceMonitor to 
ContainerMonitor, and we will be deprecating the /monitor/statistics endpoints 
in the future.


src/slave/slave.cpp (lines 5001 - 5005)


Can we call monitor.containers() here instead? That means we need to expose 
'containers' in ContainerMonitor (ResourceMonitor).


- Jie Yu


On March 18, 2016, 5:27 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45014/
> ---
> 
> (Updated March 18, 2016, 5:27 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add /containers endpoint to return ResourceUsage.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
>   src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 
> 
> Diff: https://reviews.apache.org/r/45014/diff/
> 
> 
> Testing
> ---
> 
> make check
> `curl agent_ip:port/containers` returns same json content as `curl 
> agent_ip:port/monitor/statistics.json`
> 
> This is a draft patch of adding /containers endpoint to agent 
> [MESOS-4891](https://issues.apache.org/jira/browse/MESOS-4891)
> 
> ContainerStatus will be added to response based on this patch.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support Power LE platform.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/
---

(Updated March 22, 2016, 1:07 p.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Summary (updated)
-

Upgrade zookeeper to 3.4.8 to support Power LE platform.


Bugs: MESOS-4612
https://issues.apache.org/jira/browse/MESOS-4612


Repository: mesos


Description (updated)
---

Upgrade zookeeper to 3.4.8 to support Power LE platform.


Diffs (updated)
-

  3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717 
  3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
  3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3 
  3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
  3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 
  3rdparty/zookeeper-3.4.8.patch PRE-CREATION 
  src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 
  src/python/native_common/ext_modules.py.in 
c335bd83024bc07b6243dd59d775e7f29adc7520 
  src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 

Diff: https://reviews.apache.org/r/44376/diff/


Testing (updated)
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Re: Review Request 44950: Add XFS disk isolator documentation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/#review124730
---



Patch looks great!

Reviews applied: [44945, 44946, 44947, 44948, 44949, 44950]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 22, 2016, 1:20 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44950/
> ---
> 
> (Updated March 22, 2016, 1:20 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOs-4828
> https://issues.apache.org/jira/browse/MESOs-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add XFS disk isolator documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404 
>   docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305 
> 
> Diff: https://reviews.apache.org/r/44950/diff/
> 
> 
> Testing
> ---
> 
> Make check. Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44257/
---

(Updated March 22, 2016, 12:13 p.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Bugs: MESOS-4678
https://issues.apache.org/jira/browse/MESOS-4678


Repository: mesos


Description
---

Upgrade protobuf to 2.6.1 to support PowerPC LE platform.


Diffs (updated)
-

  3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
  3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz 
e600ac57be4c88efb5f146e4b3ec226d8f685033 
  3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/README.md 
c534835db7baca1138791f2c700e95ff73052d85 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 
3d1f13082a65f9b1694ee7c65ba0cec131c18c5a 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 
fb11b1147b3a1872f60e90d0691723f9b2985427 
  3rdparty/libprocess/3rdparty/versions.am 
98195b8eb60b2673d610d8ab7ea31103f137debf 
  LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
  configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 
  src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af 
  src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 
  src/python/native_common/ext_modules.py.in 
c335bd83024bc07b6243dd59d775e7f29adc7520 
  src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b 

Diff: https://reviews.apache.org/r/44257/diff/


Testing (updated)
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Re: Review Request 37168: Add an example framework using dynamic reservation.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/
---

(Updated March 22, 2016, 11:44 a.m.)


Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.


Changes
---

Address Greg's comments.


Bugs: MESOS-3063
https://issues.apache.org/jira/browse/MESOS-3063


Repository: mesos


Description
---

Provide example for dynamic reservation features.


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
  src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
  src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 

Diff: https://reviews.apache.org/r/37168/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45018/
---

(Updated March 22, 2016, 3:34 a.m.)


Review request for mesos, Joris Van Remoortere and Joseph Wu.


Bugs: MESOS-3481
https://issues.apache.org/jira/browse/MESOS-3481


Repository: mesos


Description
---

MESOS-3481 Add const accessor to Master flags.


Diffs (updated)
-

  src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
  src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c 

Diff: https://reviews.apache.org/r/45018/diff/


Testing
---

make check

This getter is used to retrieve the flags from master. Currently, if one wants 
to access master flags in the test, master flag has to be explicitly created 
and then passed to `CreateMasterFlags(flags)`.

story description: https://issues.apache.org/jira/browse/MESOS-3481


Thanks,

Jay Guo

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

[haosdent huang]

> On March 16, 2016, 12:46 a.m., Vinod Kone wrote:
> > Can you explain what testing you have done in the "Testing done" section? 
> > 
> > According to MESOS-4312, we agreed to do the following tests:
> > 
> > -- Verify SSL, perf and docker related test cases work as expected on all 
> > platforms.
> > -- Do the validation on all platforms by "sudo make dist check" and "sudo 
> > make check --benchmark --gtest_filter="*Benchmark*"" and make sure the perf 
> > numbers are OK.
> > -- Run compatibility tests between scheduler <=> master <=> slave <=> 
> > executor where each of the components is running either the 
> > patched/upgraded version or not.
> 
> Zhiwei Chen wrote:
> Thanks Vinod, I need to combine all patches and then test on Power 
> platform, so I planed only to test single patches on ubuntu/rhel/apple one by 
> one, after all patches go into upstream, I will create a patch to fix ppc64le 
> test cases[MESOS-4897]. Mesos code base changed, I need to rebase the patch 
> and then test again. Will update the Testing section when I am done.
> 
> Zhiwei Chen wrote:
> Hi Vinod, when I do make check, I encouter this message many times, could 
> you tell me how to solve this?
> 
> **1. This will cause the CgroupsNoHierarchyTest failed**
> We cannot run any cgroups tests that require mounting
> hierarchies because you have the following hierarchies mounted:
> /sys/fs/cgroup/blkio, /sys/fs/cgroup/cpu, /sys/fs/cgroup/cpuacct, 
> /sys/fs/cgroup/cpuset, /sys/fs/cgroup/devices, /sys/fs/cgroup/freezer, 
> /sys/fs/cgroup/hugetlb, /sys/fs/cgroup/memory, /sys/fs/cgroup/net_cls, 
> /sys/fs/cgroup/net_prio, /sys/fs/cgroup/perf_event, /sys/fs/cgroup/systemd
> We'll disable the CgroupsNoHierarchyTest test fixture for now.
> 
> **2. I have no physical machine, so I can't do perf test**
> The 'cpu-cycles' hardware event of 'perf' is not available on
> this platform so tests using it will not be run.
> One likely reason is that the tests are run in a virtual
> machine that does not provide CPU performance counters
> 
> **3. I use Ubuntu 14.04 as dev environment, so no overlayfs test**
> 
> We cannot run any overlayfs tests because:
> Overlayfs is not supported on your systems
> 
> Vinod Kone wrote:
> Skipping the above tests is fine. 
> 
> Can you make sure to run the benchmarks before and after? Also the 
> upgrade path (support/test_upgrade.py).
> 
> Once you confirm, I will commit this. Then you can tackle the next 
> dependendcy upgrade. I would like us to do the ugprades in the order of least 
> disruption, so we can do glog and http parser next.
> 
> Zhiwei Chen wrote:
> Thanks, I have done all the tests. But there is an issue, the 
> ./support/post-reviews.py can't submit binary file, so there will be no 
> 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz file in the repo, I think you 
> can fix this.

Yes, you need apply this 
https://reviews.reviewboard.org/r/7571/diff/1#index_header to your rbtools, so 
that you could submit patches which contains binary file.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44378/#review123812
---


On March 22, 2016, 1:38 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44378/
> ---
> 
> (Updated March 22, 2016, 1:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4803
> https://issues.apache.org/jira/browse/MESOS-4803
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 6b07aefc58a1daa235b35e83832e47d1878e2e94 
>   3rdparty/libprocess/3rdparty/libev-4.15.patch 
> bbd83e6928e6caba3bc5a9739823d60923cfaa2a 
>   3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 
> 4c282b573aa9331fd16197ef286faf323b6515eb 
>   3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 
>   3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
>   src/python/native_common/ext_modules.py.in 
> c335bd83024bc07b6243dd59d775e7f29adc7520 
> 
> Diff: https://reviews.apache.org/r/44378/diff/
> 
> 
> Testing
> ---
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44252: Update glog-0.3.3.patch to support PowerPC LE platform.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44252/
---

(Updated March 22, 2016, 10:59 a.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Bugs: MESOS-4879
https://issues.apache.org/jira/browse/MESOS-4879


Repository: mesos


Description
---

Update glog-0.3.3.patch to support PowerPC LE platform.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/glog-0.3.3.patch 
76b8c0fe3b4615371e265bab713d62c896b7c3d6 

Diff: https://reviews.apache.org/r/44252/diff/


Testing (updated)
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

[Zhiwei Chen]

> On March 22, 2016, 10:35 a.m., haosdent huang wrote:
> > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain 
> > the binary file correctly after I apply this patch.
> > 
> > ```
> > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz 
> > b/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz
> > new file mode 100644
> > index 
> > ..06528d5a456d6aa8dcee18159392d2ed4e5f3866
> > Binary files /dev/null and 
> > b/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz differ
> > ```

Yes, I told Vinod in another patch, I think he can solve this issue. Thanks.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44372/#review124717
---


On March 22, 2016, 10:22 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44372/
> ---
> 
> (Updated March 22, 2016, 10:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4805
> https://issues.apache.org/jira/browse/MESOS-4805
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade http-parser to 2.6.1 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 6b07aefc58a1daa235b35e83832e47d1878e2e94 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 
>   3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch 
> f9fac12437a6bedc66353fda1ce9c0d7a383225a 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz 
> b811b63ce0ad6d71d9d296fed76656c023c76fc5 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/src/decoder.hpp 
> a20b5ba8fc50d834573d253948645cc863f030dd 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
> 
> Diff: https://reviews.apache.org/r/44372/diff/
> 
> 
> Testing
> ---
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/
---

(Updated 三月 22, 2016, 2:57 a.m.)


Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.


Changes
---

address greg's comment


Bugs: MESOS-4744
https://issues.apache.org/jira/browse/MESOS-4744


Repository: mesos


Description
---

Allow setting role in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 

Diff: https://reviews.apache.org/r/43935/diff/


Testing
---

make & make check

start master.
./bin/mesos-master.sh --work_dir=/tmp/mesos

start slave.
./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
--resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"

running mesos-execute without specifying role succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --resources="cpus:1;mem:512"

running mesos-execute with role test succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test" --resources="cpus:2;mem:512"

running mesos-execute with role test1 fails.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test1" --resources="cpus:2;mem:512"


Thanks,

Jian Qiu

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

[Jay Guo]

> On March 21, 2016, 7:04 p.m., Benjamin Bannier wrote:
> > src/master/master.hpp, line 546
> > 
> >
> > Two things:
> > 
> > (1) I think a more fitting name here might be `flags()` (cf `info()` 
> > just above).
> > 
> > (2) I would have expected a getter to return a const ref; this always 
> > performs a copy.
> > 
> > I would also have expected this function to be `const` itself; was the 
> > only reason you didn't do that for the dispatch in your test below? If yes, 
> > I believe this should rather be fixed in libprocess instead of us adding 
> > more suprising API.

(1) flags() would be a duplicate member of flags
(2) dispatch doesn't like reference. It yields compilation error:
`../../3rdparty/libprocess/include/process/future.hpp:147:10: error: 
'operator->' declared as a pointer to a reference of type 'const 
mesos::internal::master::Flags &'`

And yes, we don't have a dispatch version that handles const function. Should 
we add it to libprocess?


> On March 21, 2016, 7:04 p.m., Benjamin Bannier wrote:
> > src/tests/master_tests.cpp, line 38
> > 
> >
> > Includes should remain sorted.

OK


> On March 21, 2016, 7:04 p.m., Benjamin Bannier wrote:
> > src/tests/master_tests.cpp, line 990
> > 
> >
> > The flag you use isn't fake, but an existing one.

Sure, we should refine the text


> On March 21, 2016, 7:04 p.m., Benjamin Bannier wrote:
> > src/tests/master_tests.cpp, line 997
> > 
> >
> > This directory is never cleaned up (on neither success nor failure 
> > paths).
> > 
> > Even if it was cleaned up, it might fail if the `cwd` is not writable. 
> > Could you pick a less intrusive approach for this test?

OK, we will evaluate other attributes instead of mkdir


> On March 21, 2016, 7:04 p.m., Benjamin Bannier wrote:
> > src/tests/master_tests.cpp, line 1004
> > 
> >
> > You should `await` the `Future` returned by `dispatch` here to ensure 
> > it is ready when you `get` the `Flags`.

OK


On March 21, 2016, 7:04 p.m., Jay Guo wrote:
> > Will you update this patch later with changes making actual use of the 
> > functionality you add?

Thanks for your review! We will update the patch accordingly.


- Jay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45018/#review124620
---


On March 21, 2016, 2:05 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45018/
> ---
> 
> (Updated March 21, 2016, 2:05 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-3481
> https://issues.apache.org/jira/browse/MESOS-3481
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3481 Add const accessor to Master flags.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
>   src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c 
> 
> Diff: https://reviews.apache.org/r/45018/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> This getter is used to retrieve the flags from master. Currently, if one 
> wants to access master flags in the test, master flag has to be explicitly 
> created and then passed to `CreateMasterFlags(flags)`.
> 
> story description: https://issues.apache.org/jira/browse/MESOS-3481
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44372/#review124717
---



Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain the 
binary file correctly after I apply this patch.

```
diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz 
b/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz
new file mode 100644
index 
..06528d5a456d6aa8dcee18159392d2ed4e5f3866
Binary files /dev/null and 
b/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz differ
```

- haosdent huang


On March 22, 2016, 2:22 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44372/
> ---
> 
> (Updated March 22, 2016, 2:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4805
> https://issues.apache.org/jira/browse/MESOS-4805
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade http-parser to 2.6.1 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 6b07aefc58a1daa235b35e83832e47d1878e2e94 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 
>   3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch 
> f9fac12437a6bedc66353fda1ce9c0d7a383225a 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz 
> b811b63ce0ad6d71d9d296fed76656c023c76fc5 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/src/decoder.hpp 
> a20b5ba8fc50d834573d253948645cc863f030dd 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
> 
> Diff: https://reviews.apache.org/r/44372/diff/
> 
> 
> Testing
> ---
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

[haosdent huang]

> On March 4, 2016, 7:37 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/3rdparty/Makefile.am, line 68
> > 
> >
> > ditto.
> 
> Zhiwei Chen wrote:
> In the real file, there is a table bracket and backslash.

I see, but need make sure the lines you added should align.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44372/#review122029
---


On March 22, 2016, 2:22 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44372/
> ---
> 
> (Updated March 22, 2016, 2:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4805
> https://issues.apache.org/jira/browse/MESOS-4805
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade http-parser to 2.6.1 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 6b07aefc58a1daa235b35e83832e47d1878e2e94 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 
>   3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch 
> f9fac12437a6bedc66353fda1ce9c0d7a383225a 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz 
> b811b63ce0ad6d71d9d296fed76656c023c76fc5 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/src/decoder.hpp 
> a20b5ba8fc50d834573d253948645cc863f030dd 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
> 
> Diff: https://reviews.apache.org/r/44372/diff/
> 
> 
> Testing
> ---
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

[Qian Zhang]

> On March 21, 2016, 10:21 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, line 17
> > 
> >
> > Can we put this under cni::spec namespace instead?
> 
> Qian Zhang wrote:
> Jie, did you mean putting it under mesos.internal.slave.cni.spec or under 
> cni.spec? If what you mean is the latter, then I think we may also move this 
> `spec.proto` file to another place, e.g., under `include/mesos/cni`, just 
> like what we did for the spec.proto of Docker and Appc. Agree? :-)
> 
> Jie Yu wrote:
> sorry, i meant the former (under meaos.internal.slave)

Got it, let me update the patch accordingly.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44622/#review124484
---


On March 17, 2016, 6:06 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44622/
> ---
> 
> (Updated March 17, 2016, 6:06 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced a protobuf message "NetworkResult".
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44622/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44372/
---

(Updated March 22, 2016, 10:22 a.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Summary (updated)
-

Upgrade http-parser to 2.6.1 to support PowerPC LE platform.


Bugs: MESOS-4805
https://issues.apache.org/jira/browse/MESOS-4805


Repository: mesos


Description (updated)
---

Upgrade http-parser to 2.6.1 to support PowerPC LE platform.


Diffs (updated)
-

  3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
  3rdparty/libprocess/3rdparty/CMakeLists.txt 
6b07aefc58a1daa235b35e83832e47d1878e2e94 
  3rdparty/libprocess/3rdparty/Makefile.am 
ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 
  3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 
  3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch 
f9fac12437a6bedc66353fda1ce9c0d7a383225a 
  3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz 
b811b63ce0ad6d71d9d296fed76656c023c76fc5 
  3rdparty/libprocess/3rdparty/versions.am 
98195b8eb60b2673d610d8ab7ea31103f137debf 
  3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
  3rdparty/libprocess/src/decoder.hpp a20b5ba8fc50d834573d253948645cc863f030dd 
  LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 

Diff: https://reviews.apache.org/r/44372/diff/


Testing (updated)
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

[Zhiwei Chen]

> On March 22, 2016, 7:21 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/src/decoder.hpp, lines 175-177
> > 
> >
> > Why do we need this now?

In http-parse >= 2.x, the url.fragement is None, the previous code did not 
catch this, so I added it.

Actually, the previous code logic will not run this function because of the 
`#if (HTTP_PARSER_VERSION_MAJOR >= 2)`.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44372/#review124679
---


On March 14, 2016, 10:01 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44372/
> ---
> 
> (Updated March 14, 2016, 10:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4805
> https://issues.apache.org/jira/browse/MESOS-4805
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade http-parser to 2.6.1 to support Power LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b8351ad0181d885a984580ae8de208ea0524b0e7 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 
>   3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch 
> f9fac12437a6bedc66353fda1ce9c0d7a383225a 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz 
> b811b63ce0ad6d71d9d296fed76656c023c76fc5 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/src/decoder.hpp 
> a20b5ba8fc50d834573d253948645cc863f030dd 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
> 
> Diff: https://reviews.apache.org/r/44372/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45134/#review124710
---




src/tests/fetcher_tests.cpp (lines 647 - 651)


Take a look at environment.cpp for our approach to test filtering, the 
"curl" filter is a good example:


https://github.com/apache/mesos/blob/0.28.0/src/tests/environment.cpp#L229-L251


- Ben Mahler


On March 22, 2016, 12:14 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45134/
> ---
> 
> (Updated March 22, 2016, 12:14 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4993
> https://issues.apache.org/jira/browse/MESOS-4993
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Skip FetcherTest zip tests when `unzip` is uninstalled.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 375e690ead4f954a66a6efc2f2daa7fb1f1a024d 
> 
> Diff: https://reviews.apache.org/r/45134/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45011/#review124707
---


Ship it!




Ship It!

- haosdent huang


On March 18, 2016, 10:49 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45011/
> ---
> 
> (Updated March 18, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Neil Conway, and Cong Wang.
> 
> 
> Bugs: MESOS-4070
> https://issues.apache.org/jira/browse/MESOS-4070
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This fix updated the implementation of numify() so that negative numbers
> could be handled conssitently for hex and non-hex numbers.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 
> 26a637bec1193dd51437bd689c34fbe6d1935d89 
>   3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp 
> 444377df00922df12d4b3ed25b4cfe9071cff5c3 
> 
> Diff: https://reviews.apache.org/r/45011/diff/
> 
> 
> Testing
> ---
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

[Zhiwei Chen]

> On March 16, 2016, 8:46 a.m., Vinod Kone wrote:
> > Can you explain what testing you have done in the "Testing done" section? 
> > 
> > According to MESOS-4312, we agreed to do the following tests:
> > 
> > -- Verify SSL, perf and docker related test cases work as expected on all 
> > platforms.
> > -- Do the validation on all platforms by "sudo make dist check" and "sudo 
> > make check --benchmark --gtest_filter="*Benchmark*"" and make sure the perf 
> > numbers are OK.
> > -- Run compatibility tests between scheduler <=> master <=> slave <=> 
> > executor where each of the components is running either the 
> > patched/upgraded version or not.
> 
> Zhiwei Chen wrote:
> Thanks Vinod, I need to combine all patches and then test on Power 
> platform, so I planed only to test single patches on ubuntu/rhel/apple one by 
> one, after all patches go into upstream, I will create a patch to fix ppc64le 
> test cases[MESOS-4897]. Mesos code base changed, I need to rebase the patch 
> and then test again. Will update the Testing section when I am done.
> 
> Zhiwei Chen wrote:
> Hi Vinod, when I do make check, I encouter this message many times, could 
> you tell me how to solve this?
> 
> **1. This will cause the CgroupsNoHierarchyTest failed**
> We cannot run any cgroups tests that require mounting
> hierarchies because you have the following hierarchies mounted:
> /sys/fs/cgroup/blkio, /sys/fs/cgroup/cpu, /sys/fs/cgroup/cpuacct, 
> /sys/fs/cgroup/cpuset, /sys/fs/cgroup/devices, /sys/fs/cgroup/freezer, 
> /sys/fs/cgroup/hugetlb, /sys/fs/cgroup/memory, /sys/fs/cgroup/net_cls, 
> /sys/fs/cgroup/net_prio, /sys/fs/cgroup/perf_event, /sys/fs/cgroup/systemd
> We'll disable the CgroupsNoHierarchyTest test fixture for now.
> 
> **2. I have no physical machine, so I can't do perf test**
> The 'cpu-cycles' hardware event of 'perf' is not available on
> this platform so tests using it will not be run.
> One likely reason is that the tests are run in a virtual
> machine that does not provide CPU performance counters
> 
> **3. I use Ubuntu 14.04 as dev environment, so no overlayfs test**
> 
> We cannot run any overlayfs tests because:
> Overlayfs is not supported on your systems
> 
> Vinod Kone wrote:
> Skipping the above tests is fine. 
> 
> Can you make sure to run the benchmarks before and after? Also the 
> upgrade path (support/test_upgrade.py).
> 
> Once you confirm, I will commit this. Then you can tackle the next 
> dependendcy upgrade. I would like us to do the ugprades in the order of least 
> disruption, so we can do glog and http parser next.

Thanks, I have done all the tests. But there is an issue, the 
./support/post-reviews.py can't submit binary file, so there will be no 
3rdparty/libprocess/3rdparty/libev-4.22.tar.gz file in the repo, I think you 
can fix this.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44378/#review123812
---


On March 22, 2016, 9:38 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44378/
> ---
> 
> (Updated March 22, 2016, 9:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4803
> https://issues.apache.org/jira/browse/MESOS-4803
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 6b07aefc58a1daa235b35e83832e47d1878e2e94 
>   3rdparty/libprocess/3rdparty/libev-4.15.patch 
> bbd83e6928e6caba3bc5a9739823d60923cfaa2a 
>   3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 
> 4c282b573aa9331fd16197ef286faf323b6515eb 
>   3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 
>   3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
>   src/python/native_common/ext_modules.py.in 
> c335bd83024bc07b6243dd59d775e7f29adc7520 
> 
> Diff: https://reviews.apache.org/r/44378/diff/
> 
> 
> Testing
> ---
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44378/
---

(Updated March 22, 2016, 9:38 a.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Bugs: MESOS-4803
https://issues.apache.org/jira/browse/MESOS-4803


Repository: mesos


Description
---

Upgrade libev to 4.22 to support PowerPC LE platform.


Diffs (updated)
-

  3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
  3rdparty/libprocess/3rdparty/CMakeLists.txt 
6b07aefc58a1daa235b35e83832e47d1878e2e94 
  3rdparty/libprocess/3rdparty/libev-4.15.patch 
bbd83e6928e6caba3bc5a9739823d60923cfaa2a 
  3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 
4c282b573aa9331fd16197ef286faf323b6515eb 
  3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 
  3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 
  3rdparty/libprocess/3rdparty/versions.am 
98195b8eb60b2673d610d8ab7ea31103f137debf 
  LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
  src/python/native_common/ext_modules.py.in 
c335bd83024bc07b6243dd59d775e7f29adc7520 

Diff: https://reviews.apache.org/r/44378/diff/


Testing (updated)
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Re: Review Request 44949: Add XFS disk isolator tests.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44949/
---

(Updated March 22, 2016, 1:20 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and fixed review comments.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add basic XFS disk isolator tests by cloning the POSIX disk isolator
tests and making minor changes for the differences in semantics.


Diffs (updated)
-

  src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44949/diff/


Testing
---

Make check. Manual testing.


Thanks,

James Peach

Re: Review Request 44948: Add XFS disk resource isolator.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44948/
---

(Updated March 22, 2016, 1:21 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and fixed review comments.


Bugs: MESOs-4828
https://issues.apache.org/jira/browse/MESOs-4828


Repository: mesos


Description
---

Track sandbox directory usage by dynamically assigning XFS project
quotas. We track a range of XFS project IDs, assigning a project ID
and a project quota to each sandbox as it is created. When the task
reaches the quota, writes will fail with EDQUOT, and the task will have
an opportunity to handle that.

Quotas are not applied to volume resources since the isolator interface
has no insight into the volume lifecycle. Thus it is not currently
possible to accurately assign and reclaim project IDs.

If LOW is the lower bound of the project ID range and HIGH is the upper
bound, you can show the currently allocated project quotas using the
xfs_quota command:

  $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"

To show the project ID assigned to the file PATH, use the xfs_io command:

  $ xfs_io -r -c stat PATH


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/slave/containerizer/mesos/containerizer.cpp 
ee7a265975323ca891114a286357c8e42901560c 
  src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION 
  src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
  src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 

Diff: https://reviews.apache.org/r/44948/diff/


Testing
---

Make check. Manual testing. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44947: Add tests for XFS project quota utilities.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44947/
---

(Updated March 22, 2016, 1:20 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and fixed review comments.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add tests for XFS project quota utilities.


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 
  src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a 

Diff: https://reviews.apache.org/r/44947/diff/


Testing
---

Make check. Manual testing. These tests.


Thanks,

James Peach

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/
---

(Updated March 22, 2016, 1:20 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and fixed review comments.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add utility functions to manipulate XFS project quotas.


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/slave/containerizer/mesos/isolators/disk/xfs/utils.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44946/diff/


Testing
---

Make check. Manual verification. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44950: Add XFS disk isolator documentation.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/
---

(Updated March 22, 2016, 1:20 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and fixed review comments.


Bugs: MESOs-4828
https://issues.apache.org/jira/browse/MESOs-4828


Repository: mesos


Description
---

Add XFS disk isolator documentation.


Diffs (updated)
-

  docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404 
  docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305 

Diff: https://reviews.apache.org/r/44950/diff/


Testing
---

Make check. Source inspection.


Thanks,

James Peach

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44945/
---

(Updated March 22, 2016, 1:20 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and fixed review comments.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add autoconf tests for XFS project quotas.


Diffs (updated)
-

  configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 

Diff: https://reviews.apache.org/r/44945/diff/


Testing
---

Make check. Manual verification.


Thanks,

James Peach

Re: Review Request 44950: Add XFS disk isolator documentation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/#review124701
---



Patch looks great!

Reviews applied: [44945, 44946, 44947, 44948, 44949, 44950]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 21, 2016, 9:46 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44950/
> ---
> 
> (Updated March 21, 2016, 9:46 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOs-4828
> https://issues.apache.org/jira/browse/MESOs-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add XFS disk isolator documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404 
>   docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305 
> 
> Diff: https://reviews.apache.org/r/44950/diff/
> 
> 
> Testing
> ---
> 
> Make check. Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45134/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4993
https://issues.apache.org/jira/browse/MESOS-4993


Repository: mesos


Description
---

Skip FetcherTest zip tests when `unzip` is uninstalled.


Diffs
-

  src/tests/fetcher_tests.cpp 375e690ead4f954a66a6efc2f2daa7fb1f1a024d 

Diff: https://reviews.apache.org/r/45134/diff/


Testing
---


Thanks,

Tomasz Janiszewski

Re: Review Request 45126: Cleaned up nested health checker launch code in command executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45126/#review124683
---



Patch looks great!

Reviews applied: [45126]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 21, 2016, 8:31 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45126/
> ---
> 
> (Updated March 21, 2016, 8:31 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial change adds logic to only invoke the health checker
> if the task has an associated health check set. This also cleans
> up nested `if` block making it more readable. This also cleans
> up the logic to just return if the health check subprocess cannot
> be created.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
> 
> Diff: https://reviews.apache.org/r/45126/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45126: Cleaned up nested health checker launch code in command executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45126/#review124681
---


Ship it!




Ship It!

- Timothy Chen


On March 21, 2016, 8:31 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45126/
> ---
> 
> (Updated March 21, 2016, 8:31 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial change adds logic to only invoke the health checker
> if the task has an associated health check set. This also cleans
> up nested `if` block making it more readable. This also cleans
> up the logic to just return if the health check subprocess cannot
> be created.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
> 
> Diff: https://reviews.apache.org/r/45126/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44372/#review124679
---



Can you also explain the testing you have done?


3rdparty/libprocess/src/decoder.hpp (lines 175 - 177)


Why do we need this now?


- Vinod Kone


On March 14, 2016, 2:01 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44372/
> ---
> 
> (Updated March 14, 2016, 2:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4805
> https://issues.apache.org/jira/browse/MESOS-4805
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade http-parser to 2.6.1 to support Power LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b8351ad0181d885a984580ae8de208ea0524b0e7 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 
>   3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch 
> f9fac12437a6bedc66353fda1ce9c0d7a383225a 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz 
> b811b63ce0ad6d71d9d296fed76656c023c76fc5 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/src/decoder.hpp 
> a20b5ba8fc50d834573d253948645cc863f030dd 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
> 
> Diff: https://reviews.apache.org/r/44372/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

[Vinod Kone]

> On March 16, 2016, 12:46 a.m., Vinod Kone wrote:
> > Can you explain what testing you have done in the "Testing done" section? 
> > 
> > According to MESOS-4312, we agreed to do the following tests:
> > 
> > -- Verify SSL, perf and docker related test cases work as expected on all 
> > platforms.
> > -- Do the validation on all platforms by "sudo make dist check" and "sudo 
> > make check --benchmark --gtest_filter="*Benchmark*"" and make sure the perf 
> > numbers are OK.
> > -- Run compatibility tests between scheduler <=> master <=> slave <=> 
> > executor where each of the components is running either the 
> > patched/upgraded version or not.
> 
> Zhiwei Chen wrote:
> Thanks Vinod, I need to combine all patches and then test on Power 
> platform, so I planed only to test single patches on ubuntu/rhel/apple one by 
> one, after all patches go into upstream, I will create a patch to fix ppc64le 
> test cases[MESOS-4897]. Mesos code base changed, I need to rebase the patch 
> and then test again. Will update the Testing section when I am done.
> 
> Zhiwei Chen wrote:
> Hi Vinod, when I do make check, I encouter this message many times, could 
> you tell me how to solve this?
> 
> **1. This will cause the CgroupsNoHierarchyTest failed**
> We cannot run any cgroups tests that require mounting
> hierarchies because you have the following hierarchies mounted:
> /sys/fs/cgroup/blkio, /sys/fs/cgroup/cpu, /sys/fs/cgroup/cpuacct, 
> /sys/fs/cgroup/cpuset, /sys/fs/cgroup/devices, /sys/fs/cgroup/freezer, 
> /sys/fs/cgroup/hugetlb, /sys/fs/cgroup/memory, /sys/fs/cgroup/net_cls, 
> /sys/fs/cgroup/net_prio, /sys/fs/cgroup/perf_event, /sys/fs/cgroup/systemd
> We'll disable the CgroupsNoHierarchyTest test fixture for now.
> 
> **2. I have no physical machine, so I can't do perf test**
> The 'cpu-cycles' hardware event of 'perf' is not available on
> this platform so tests using it will not be run.
> One likely reason is that the tests are run in a virtual
> machine that does not provide CPU performance counters
> 
> **3. I use Ubuntu 14.04 as dev environment, so no overlayfs test**
> 
> We cannot run any overlayfs tests because:
> Overlayfs is not supported on your systems

Skipping the above tests is fine. 

Can you make sure to run the benchmarks before and after? Also the upgrade path 
(support/test_upgrade.py).

Once you confirm, I will commit this. Then you can tackle the next dependendcy 
upgrade. I would like us to do the ugprades in the order of least disruption, 
so we can do glog and http parser next.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44378/#review123812
---


On March 14, 2016, 2:01 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44378/
> ---
> 
> (Updated March 14, 2016, 2:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4803
> https://issues.apache.org/jira/browse/MESOS-4803
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b8351ad0181d885a984580ae8de208ea0524b0e7 
>   3rdparty/libprocess/3rdparty/libev-4.15.patch 
> bbd83e6928e6caba3bc5a9739823d60923cfaa2a 
>   3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 
> 4c282b573aa9331fd16197ef286faf323b6515eb 
>   3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 
>   3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
>   src/python/native/ext_modules.py.in 
> eb93864733713dddad66141c6b8b6cd895f41484 
> 
> Diff: https://reviews.apache.org/r/44378/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44229: Added upgrade testing script.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44229/#review124677
---


Fix it, then Ship it!





support/test-upgrade.py (line 188)


Can you add a comment on why you need to do this? Also add a TODO for using 
ZK instead.


- Vinod Kone


On March 21, 2016, 9:20 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44229/
> ---
> 
> (Updated March 21, 2016, 9:20 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2372
> https://issues.apache.org/jira/browse/MESOS-2372
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added upgrade testing script.
> 
> 
> Diffs
> -
> 
>   support/test-upgrade.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44229/diff/
> 
> 
> Testing
> ---
> 
> This script is copied from @nnielsen, original patch can be found here: 
> https://reviews.apache.org/r/31645/
> 
> To test, build two different versions of Mesos in two different directories. 
> Then do:
> `support/test-upgrade.py --prev=/path/to/earlier/version 
> --next=/path/to/later/version`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44090/
---

(Updated March 21, 2016, 10:54 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Changed the calling parameters for Windows API.


Diffs (updated)
-

  3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 
  3rdparty/libprocess/src/poll_socket.cpp 
6e6634b4b352e3723096521843546cf56ec6dd8b 

Diff: https://reviews.apache.org/r/44090/diff/


Testing
---

OSX: make check
Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 44760: Windows: Fixed non-blocking connect.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44760/
---

(Updated March 21, 2016, 10:54 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Fixed non-blocking connect.


Diffs (updated)
-

  3rdparty/libprocess/include/process/network.hpp 
7d203f0ff1cdb3145bc2b914f8bd606203878f09 
  3rdparty/libprocess/src/poll_socket.cpp 
6e6634b4b352e3723096521843546cf56ec6dd8b 

Diff: https://reviews.apache.org/r/44760/diff/


Testing
---

OSX: make check
Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44089/
---

(Updated March 21, 2016, 10:54 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Used os::read/write from Stout for proper OS isolation.


Diffs (updated)
-

  3rdparty/libprocess/src/io.cpp 4a58d6dff3787ca262ee2ade2cbea7578ad27e95 

Diff: https://reviews.apache.org/r/44089/diff/


Testing
---

OSX: make check
Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44139/
---

(Updated March 21, 2016, 10:54 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows:[2/2] Lifted socket API into Stout.


Diffs (updated)
-

  3rdparty/libprocess/include/process/network.hpp 
7d203f0ff1cdb3145bc2b914f8bd606203878f09 

Diff: https://reviews.apache.org/r/44139/diff/


Testing
---

OSX: make check
Windows: build/execute


Thanks,

Daniel Pravat

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44138/
---

(Updated March 21, 2016, 10:53 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows:[1/2] Lifted socket API into Stout.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44138/diff/


Testing
---

OSX: make check
Windows: build/execute


Thanks,

Daniel Pravat

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45123/#review124672
---



Patch looks great!

Reviews applied: [42470, 42471, 42472, 42473, 42474, 42503, 42683, 42504, 
42593, 42505, 42506, 42684, 45117, 45118, 45119, 45120, 45121, 45122, 45123]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 21, 2016, 6:44 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45123/
> ---
> 
> (Updated March 21, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2408
> https://issues.apache.org/jira/browse/MESOS-2408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs for deletion of persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
> 
> Diff: https://reviews.apache.org/r/45123/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44948: Add XFS disk resource isolator.

[Jie Yu]

> On March 21, 2016, 3:51 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 320
> > 
> >
> > I am wondering if it's possible to distinguish the Error case from the 
> > case where there's no project ID assigned to the directory.
> > 
> > Can we make xfs::getProjectId(...) return a Result?
> 
> James Peach wrote:
> If there's no project ID assigned, you get a successful ``Try`` with a 
> value of ``0``.

Yes, i understand that part. I think we should make the 0 case more explicit 
(using None() instead of Try<...>(0))


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44948/#review124486
---


On March 21, 2016, 9:47 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44948/
> ---
> 
> (Updated March 21, 2016, 9:47 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOs-4828
> https://issues.apache.org/jira/browse/MESOs-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Track sandbox directory usage by dynamically assigning XFS project
> quotas. We track a range of XFS project IDs, assigning a project ID
> and a project quota to each sandbox as it is created. When the task
> reaches the quota, writes will fail with EDQUOT, and the task will have
> an opportunity to handle that.
> 
> Quotas are not applied to volume resources since the isolator interface
> has no insight into the volume lifecycle. Thus it is not currently
> possible to accurately assign and reclaim project IDs.
> 
> If LOW is the lower bound of the project ID range and HIGH is the upper
> bound, you can show the currently allocated project quotas using the
> xfs_quota command:
> 
>   $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"
> 
> To show the project ID assigned to the file PATH, use the xfs_io command:
> 
>   $ xfs_io -r -c stat PATH
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/slave/containerizer/mesos/containerizer.cpp 
> ee7a265975323ca891114a286357c8e42901560c 
>   src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 
> 
> Diff: https://reviews.apache.org/r/44948/diff/
> 
> 
> Testing
> ---
> 
> Make check. Manual testing. Tests in subsequent patches.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44948: Add XFS disk resource isolator.

[James Peach]

> On March 21, 2016, 3:51 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, lines 172-173
> > 
> >
> > Any reason this is not in xfs.hpp|cpp?

I thought about that. If I make that change, then there's no need to make much 
of the XFS API public, so I'd just as soon leave this here.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44948/#review124486
---


On March 21, 2016, 9:47 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44948/
> ---
> 
> (Updated March 21, 2016, 9:47 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOs-4828
> https://issues.apache.org/jira/browse/MESOs-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Track sandbox directory usage by dynamically assigning XFS project
> quotas. We track a range of XFS project IDs, assigning a project ID
> and a project quota to each sandbox as it is created. When the task
> reaches the quota, writes will fail with EDQUOT, and the task will have
> an opportunity to handle that.
> 
> Quotas are not applied to volume resources since the isolator interface
> has no insight into the volume lifecycle. Thus it is not currently
> possible to accurately assign and reclaim project IDs.
> 
> If LOW is the lower bound of the project ID range and HIGH is the upper
> bound, you can show the currently allocated project quotas using the
> xfs_quota command:
> 
>   $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"
> 
> To show the project ID assigned to the file PATH, use the xfs_io command:
> 
>   $ xfs_io -r -c stat PATH
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/slave/containerizer/mesos/containerizer.cpp 
> ee7a265975323ca891114a286357c8e42901560c 
>   src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 
> 
> Diff: https://reviews.apache.org/r/44948/diff/
> 
> 
> Testing
> ---
> 
> Make check. Manual testing. Tests in subsequent patches.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44948: Add XFS disk resource isolator.

[James Peach]

> On March 21, 2016, 3:51 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, lines 302-303
> > 
> >
> > We typically store the 'flags' directory in case yo u need other 
> > parameters in the future.

Since I don't need all the flags, it seems better to just store the one I want. 
If I needed more than one flag, I agree that storing the whole thing probably 
makes sense.


> On March 21, 2016, 3:51 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 394
> > 
> >
> > Can you have a LOG(ERROR) here?

``cleanupDirectory`` has already logged this error.


> On March 21, 2016, 3:51 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 320
> > 
> >
> > I am wondering if it's possible to distinguish the Error case from the 
> > case where there's no project ID assigned to the directory.
> > 
> > Can we make xfs::getProjectId(...) return a Result?

If there's no project ID assigned, you get a successful ``Try`` with a value of 
``0``.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44948/#review124486
---


On March 21, 2016, 9:47 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44948/
> ---
> 
> (Updated March 21, 2016, 9:47 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOs-4828
> https://issues.apache.org/jira/browse/MESOs-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Track sandbox directory usage by dynamically assigning XFS project
> quotas. We track a range of XFS project IDs, assigning a project ID
> and a project quota to each sandbox as it is created. When the task
> reaches the quota, writes will fail with EDQUOT, and the task will have
> an opportunity to handle that.
> 
> Quotas are not applied to volume resources since the isolator interface
> has no insight into the volume lifecycle. Thus it is not currently
> possible to accurately assign and reclaim project IDs.
> 
> If LOW is the lower bound of the project ID range and HIGH is the upper
> bound, you can show the currently allocated project quotas using the
> xfs_quota command:
> 
>   $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"
> 
> To show the project ID assigned to the file PATH, use the xfs_io command:
> 
>   $ xfs_io -r -c stat PATH
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/slave/containerizer/mesos/containerizer.cpp 
> ee7a265975323ca891114a286357c8e42901560c 
>   src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 
> 
> Diff: https://reviews.apache.org/r/44948/diff/
> 
> 
> Testing
> ---
> 
> Make check. Manual testing. Tests in subsequent patches.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44948: Add XFS disk resource isolator.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44948/
---

(Updated March 21, 2016, 9:47 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and fixed review comments.


Bugs: MESOs-4828
https://issues.apache.org/jira/browse/MESOs-4828


Repository: mesos


Description
---

Track sandbox directory usage by dynamically assigning XFS project
quotas. We track a range of XFS project IDs, assigning a project ID
and a project quota to each sandbox as it is created. When the task
reaches the quota, writes will fail with EDQUOT, and the task will have
an opportunity to handle that.

Quotas are not applied to volume resources since the isolator interface
has no insight into the volume lifecycle. Thus it is not currently
possible to accurately assign and reclaim project IDs.

If LOW is the lower bound of the project ID range and HIGH is the upper
bound, you can show the currently allocated project quotas using the
xfs_quota command:

  $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"

To show the project ID assigned to the file PATH, use the xfs_io command:

  $ xfs_io -r -c stat PATH


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/slave/containerizer/mesos/containerizer.cpp 
ee7a265975323ca891114a286357c8e42901560c 
  src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION 
  src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
  src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 

Diff: https://reviews.apache.org/r/44948/diff/


Testing
---

Make check. Manual testing. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44950: Add XFS disk isolator documentation.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/
---

(Updated March 21, 2016, 9:46 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and fixed review comments.


Bugs: MESOs-4828
https://issues.apache.org/jira/browse/MESOs-4828


Repository: mesos


Description
---

Add XFS disk isolator documentation.


Diffs (updated)
-

  docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404 
  docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305 

Diff: https://reviews.apache.org/r/44950/diff/


Testing
---

Make check. Source inspection.


Thanks,

James Peach

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/
---

(Updated March 21, 2016, 9:46 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and fixed review comments.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add utility functions to manipulate XFS project quotas.


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/linux/xfs.hpp PRE-CREATION 
  src/linux/xfs.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44946/diff/


Testing
---

Make check. Manual verification. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44945/
---

(Updated March 21, 2016, 9:46 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and fixed review comments.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add autoconf tests for XFS project quotas.


Diffs (updated)
-

  configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 

Diff: https://reviews.apache.org/r/44945/diff/


Testing
---

Make check. Manual verification.


Thanks,

James Peach

Re: Review Request 44949: Add XFS disk isolator tests.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44949/
---

(Updated March 21, 2016, 9:46 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and fixed review comments.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add basic XFS disk isolator tests by cloning the POSIX disk isolator
tests and making minor changes for the differences in semantics.


Diffs (updated)
-

  src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44949/diff/


Testing
---

Make check. Manual testing.


Thanks,

James Peach

Re: Review Request 44947: Add tests for XFS project quota utilities.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44947/
---

(Updated March 21, 2016, 9:46 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and fixed review comments.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add tests for XFS project quota utilities.


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 
  src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a 

Diff: https://reviews.apache.org/r/44947/diff/


Testing
---

Make check. Manual testing. These tests.


Thanks,

James Peach

Re: Review Request 44994: Added a test for executor shutdown grace period.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44994/
---

(Updated March 21, 2016, 9:29 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4949
https://issues.apache.org/jira/browse/MESOS-4949


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
  src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 

Diff: https://reviews.apache.org/r/44994/diff/


Testing
---

On Mac OS 10.10.4:
`make check`
`GTEST_FILTER="*ExecutorShutdownGracePeriod*" ./bin/mesos-tests.sh 
--gtest_repeat=100 --gtest_break_on_failure`


Thanks,

Alexander Rukletsov

Re: Review Request 45039: Updated the scheduler `launchTasks()` comment.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/
---

(Updated March 21, 2016, 9:24 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary,


Diffs (updated)
-

  docs/app-framework-development-guide.md 
1d8bebde67f69fd414509b8861571137d3569b46 
  include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
  src/java/src/org/apache/mesos/SchedulerDriver.java 
bf866f5ebece2505eaa27bf39a1382cd1a2a069a 
  src/python/interface/src/mesos/interface/__init__.py 
232890daa6d222ae1c86906bbc484c8e635c4eb7 

Diff: https://reviews.apache.org/r/45039/diff/


Testing
---

None: not a functional change.


Thanks,

Alexander Rukletsov

Re: Review Request 44993: Updated `TestContainerizer` to support default actions.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44993/
---

(Updated March 21, 2016, 9:23 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/containerizer.cpp c6772ce5908edaab6c3189a65e8446217d1c7c27 

Diff: https://reviews.apache.org/r/44993/diff/


Testing
---

On Mac OS 10.10.4:
`make check`
`GTEST_FILTER="SlaveTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 
--gtest_break_on_failure`


Thanks,

Alexander Rukletsov

Re: Review Request 44992: Reordered function declarations in `TestContainerizer`.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44992/
---

(Updated March 21, 2016, 9:22 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

The common pattern is to follow the order in the parent class.


Diffs (updated)
-

  src/tests/containerizer.hpp 67fbe7fedbe170c3f22a2dcbb5aebf4195a5aabc 

Diff: https://reviews.apache.org/r/44992/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44229: Added upgrade testing script.

[Greg Mann]

> On March 16, 2016, 12:43 a.m., Vinod Kone wrote:
> > support/test-upgrade.py, line 42
> > 
> >
> > credfile is unused?

In switching to the `test-framework`, I also enabled authentication, so the 
credential file is now used.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44229/#review123800
---


On March 21, 2016, 9:20 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44229/
> ---
> 
> (Updated March 21, 2016, 9:20 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2372
> https://issues.apache.org/jira/browse/MESOS-2372
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added upgrade testing script.
> 
> 
> Diffs
> -
> 
>   support/test-upgrade.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44229/diff/
> 
> 
> Testing
> ---
> 
> This script is copied from @nnielsen, original patch can be found here: 
> https://reviews.apache.org/r/31645/
> 
> To test, build two different versions of Mesos in two different directories. 
> Then do:
> `support/test-upgrade.py --prev=/path/to/earlier/version 
> --next=/path/to/later/version`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44229: Added upgrade testing script.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44229/
---

(Updated March 21, 2016, 9:20 p.m.)


Review request for mesos, Niklas Nielsen and Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-2372
https://issues.apache.org/jira/browse/MESOS-2372


Repository: mesos


Description
---

Added upgrade testing script.


Diffs (updated)
-

  support/test-upgrade.py PRE-CREATION 

Diff: https://reviews.apache.org/r/44229/diff/


Testing
---

This script is copied from @nnielsen, original patch can be found here: 
https://reviews.apache.org/r/31645/

To test, build two different versions of Mesos in two different directories. 
Then do:
`support/test-upgrade.py --prev=/path/to/earlier/version 
--next=/path/to/later/version`


Thanks,

Greg Mann

Re: Review Request 44991: Enabled mocking on `TestContainerizer::destroy`.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44991/
---

(Updated March 21, 2016, 9:16 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/containerizer.hpp 67fbe7fedbe170c3f22a2dcbb5aebf4195a5aabc 
  src/tests/containerizer.cpp c6772ce5908edaab6c3189a65e8446217d1c7c27 

Diff: https://reviews.apache.org/r/44991/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45015/#review124661
---




3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (lines 146 - 
166)


Which of these are setting up the test and therefore remain `ASSERT_*` and 
which are actually the test cases, which should be converted to `EXPECT_*`?


- Michael Park


On March 18, 2016, 4:53 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45015/
> ---
> 
> (Updated March 18, 2016, 4:53 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently on Windows, `os::exists` will return true if a component of a
> path does not exist. For example if you have `a/fancy/path`, and you ask
> `os::exists("a/fake/path")`, the result currently reports `true`. In
> other words, the Windows code path only checks for the error that a file
> does not exist, and ignores the error that says the path is not valid.
> 
> This commit will fix this, and also add a test that will verify we don't
> regress.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/exists.hpp 
> 9211851e4562e04045276421b359c3c78cdae7f1 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/45015/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44084: Windows: Forked os::rename().

[Michael Park]

> On March 21, 2016, 7:24 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 222
> > 
> >
> > ```
> > ASSERT_EQ(message, file3Contents.get());
> > ```

Actually, these should be `EXPECT_*` please. Here and below.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/#review124623
---


On March 17, 2016, 11:59 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44084/
> ---
> 
> (Updated March 17, 2016, 11:59 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked os::rename().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
> 7b2215208bcaa5613426d8ede9cab21d1a084631 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/44084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45009: Transition `filesystem_tests.cpp` to use `path::join`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45009/#review124655
---


Ship it!




Ship It!

- Michael Park


On March 18, 2016, 12:51 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45009/
> ---
> 
> (Updated March 18, 2016, 12:51 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Transition `filesystem_tests.cpp` to use `path::join`.
> 
> This commit will fix a test that fails due to inconsistent usage of path
> delimiting characters.
> 
> Historically in Mesos, it has been common to join paths by adding
> strings. For example: `somePath + "/yourFile"`. The '/' character in
> particular is contentious, and can cause problems if you're not
> consistent in your usage. For example, if `somePath` already uses '\' as
> a path separator, then joining the string `"/yourFile"` introduces
> inconsistency in the path delimiter usage, resulting in undesirable
> behavior.
> 
> Review: https://reviews.apache.org/r/45009
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/45009/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44084: Windows: Forked os::rename().

[Michael Park]

> On March 21, 2016, 7:24 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 234
> > 
> >
> > ```
> > ASSERT_TRUE(0u, file2Contents.get());
> > ```

oops. `s/ASSERT_TRUE/ASSERT_EQ/`


> On March 21, 2016, 7:24 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 238
> > 
> >
> > ```
> > ASSERT_TRUE(1u, allFiles.get().size());
> > ```

oops. `s/ASSERT_TRUE/ASSERT_EQ/`


> On March 21, 2016, 7:24 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 248
> > 
> >
> > ```
> > ASSERT_TRUE(1u, allFiles.get().size());
> > ```

oops. `s/ASSERT_TRUE/ASSERT_EQ/`


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/#review124623
---


On March 17, 2016, 11:59 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44084/
> ---
> 
> (Updated March 17, 2016, 11:59 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked os::rename().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
> 7b2215208bcaa5613426d8ede9cab21d1a084631 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/44084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44950: Add XFS disk isolator documentation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/#review124652
---



Patch looks great!

Reviews applied: [44945, 44946, 44947, 44948, 44949, 44950]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 21, 2016, 6:20 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44950/
> ---
> 
> (Updated March 21, 2016, 6:20 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOs-4828
> https://issues.apache.org/jira/browse/MESOs-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add XFS disk isolator documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404 
>   docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305 
> 
> Diff: https://reviews.apache.org/r/44950/diff/
> 
> 
> Testing
> ---
> 
> Make check. Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 45126: Cleaned up nested health checker launch code in command executor.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45126/
---

Review request for mesos, Jie Yu and Timothy Chen.


Repository: mesos


Description
---

This trivial change adds logic to only invoke the health checker
if the task has an associated health check set. This also cleans
up nested `if` block making it more readable. This also cleans
up the logic to just return if the health check subprocess cannot
be created.


Diffs
-

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/45126/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 37168: Add an example framework using dynamic reservation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review124635
---



Patch looks great!

Reviews applied: [37168]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 18, 2016, 6:47 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> ---
> 
> (Updated March 18, 2016, 6:47 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review124631
---




src/tests/persistent_volume_tests.cpp (line 153)


This should be `1u` to avoid a compilation error with GCC5+.


- Neil Conway


On March 21, 2016, 1:42 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> ---
> 
> (Updated March 21, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-191
> https://issues.apache.org/jira/browse/MESOS-191
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made volume sizes consistent with disk sizes to conform with `MOUNT`
> requirements.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 26fff19daa8b175fdcc06fd9467224d5920a1967 
>   src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c 
> 
> Diff: https://reviews.apache.org/r/42684/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 44084: Windows: Forked os::rename().

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/#review124623
---




3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp (lines 
45 - 46)


```
return WindowsError(
"`os::rename` failed to move file '" + from + "' to '" + to + "'");
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 192)


Add newline.



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 213)


```
ASSERT_EQ(2u, allFiles.get().size());
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 216)


```
s/that was in `file`/\that was in `file1`/
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 217)


"has gone down"? shouldn't this be: that the count of files in the 
directory has not changed..?



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 222)


```
ASSERT_EQ(message, file3Contents.get());
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 226)


```
ASSERT_EQ(2u, allFiles.get().size());
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 229)


`s/cound/count/`



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 234)


```
ASSERT_TRUE(0u, file2Contents.get());
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 238)


```
ASSERT_TRUE(1u, allFiles.get().size());
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 248)


```
ASSERT_TRUE(1u, allFiles.get().size());
```


- Michael Park


On March 17, 2016, 11:59 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44084/
> ---
> 
> (Updated March 17, 2016, 11:59 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked os::rename().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
> 7b2215208bcaa5613426d8ede9cab21d1a084631 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/44084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44672: Added normalize method to registry puller.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/
---

(Updated March 21, 2016, 12:06 p.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, Shuai Lin, 
and Timothy Chen.


Bugs: MESOS-4877
https://issues.apache.org/jira/browse/MESOS-4877


Repository: mesos


Description
---

Added normalize method to registry puller.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6d637ed14f35feb554c8fcc63a7a7e046aaca574 

Diff: https://reviews.apache.org/r/44672/diff/


Testing
---

make check

sudo ./bin/mesos-test.sh --gtest_filter="*ProvisionerDockerRegistryPullerTest*"


Thanks,

Gilbert Song

Re: Review Request 44673: Added test for registry puller normalize.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44673/
---

(Updated March 21, 2016, 12:06 p.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, Shuai Lin, 
and Timothy Chen.


Bugs: MESOS-4877
https://issues.apache.org/jira/browse/MESOS-4877


Repository: mesos


Description
---

Added test for registry puller normalize.


Diffs (updated)
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
e4b30b9e51cd1191bfa9d9cf68a274814fdc4873 

Diff: https://reviews.apache.org/r/44673/diff/


Testing
---

make check

sudo ./bin/mesos-test.sh --gtest_filter="*ProvisionerDockerRegistryPullerTest*"


Thanks,

Gilbert Song

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45018/#review124620
---




src/master/master.hpp (line 546)


Two things:

(1) I think a more fitting name here might be `flags()` (cf `info()` just 
above).

(2) I would have expected a getter to return a const ref; this always 
performs a copy.

I would also have expected this function to be `const` itself; was the only 
reason you didn't do that for the dispatch in your test below? If yes, I 
believe this should rather be fixed in libprocess instead of us adding more 
suprising API.



src/tests/master_tests.cpp (line 38)


Includes should remain sorted.



src/tests/master_tests.cpp (line 990)


The flag you use isn't fake, but an existing one.



src/tests/master_tests.cpp (line 997)


This directory is never cleaned up (on neither success nor failure paths).

Even if it was cleaned up, it might fail if the `cwd` is not writable. 
Could you pick a less intrusive approach for this test?



src/tests/master_tests.cpp (line 1004)


You should `await` the `Future` returned by `dispatch` here to ensure it is 
ready when you `get` the `Flags`.


Will you update this patch later with changes making actual use of the 
functionality you add?

- Benjamin Bannier


On March 21, 2016, 3:05 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45018/
> ---
> 
> (Updated March 21, 2016, 3:05 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-3481
> https://issues.apache.org/jira/browse/MESOS-3481
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3481 Add const accessor to Master flags.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
>   src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c 
> 
> Diff: https://reviews.apache.org/r/45018/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> This getter is used to retrieve the flags from master. Currently, if one 
> wants to access master flags in the test, master flag has to be explicitly 
> created and then passed to `CreateMasterFlags(flags)`.
> 
> story description: https://issues.apache.org/jira/browse/MESOS-3481
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45122/
---

(Updated March 21, 2016, 6:44 p.m.)


Review request for mesos, Jie Yu and Joris Van Remoortere.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

Updated tests for deletion of persistent volumes.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
26fff19daa8b175fdcc06fd9467224d5920a1967 

Diff: https://reviews.apache.org/r/45122/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 45122: Updated tests for deletion of persistent volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45122/
---

Review request for mesos, Jie Yu and Joris Van Remoortere.


Repository: mesos


Description
---

Updated tests for deletion of persistent volumes.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
26fff19daa8b175fdcc06fd9467224d5920a1967 

Diff: https://reviews.apache.org/r/45122/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 45123: Updated docs for deletion of persistent volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45123/
---

Review request for mesos, Jie Yu and Joris Van Remoortere.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

Updated docs for deletion of persistent volumes.


Diffs
-

  docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
  docs/reservation.md 55924adb94028702e15db7e191915157552981d0 

Diff: https://reviews.apache.org/r/45123/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 45121: Implemented deletion for persistent volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45121/
---

(Updated March 21, 2016, 6:44 p.m.)


Review request for mesos, Jie Yu and Joris Van Remoortere.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

Prior to this commit, destroying a persistent volume would remove
the Mesos-level metadata about the volume, but wouldn't destroy
any of the volume's filesystem content. We now remove the volume
from the slave's filesystem, essentially via "rm -r".


Diffs
-

  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 

Diff: https://reviews.apache.org/r/45121/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 45121: Implemented deletion for persistent volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45121/
---

Review request for mesos, Jie Yu and Joris Van Remoortere.


Repository: mesos


Description
---

Prior to this commit, destroying a persistent volume would remove
the Mesos-level metadata about the volume, but wouldn't destroy
any of the volume's filesystem content. We now remove the volume
from the slave's filesystem, essentially via "rm -r".


Diffs
-

  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 

Diff: https://reviews.apache.org/r/45121/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 45120: Extended `os::rmdir` in stout to support preserving the root directory.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45120/
---

Review request for mesos, Jie Yu and Joris Van Remoortere.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

This allows `os::rmdir("/x")` to optionally remove all the child
files and directories of the root directory "/x", but preserve "/x"
itself.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
cbc97596cd8ed1e6d4261568fd0086c86e063232 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
4e3dd0ff8cbfe470b14c7cacbd861e7dc8384ba1 
  3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp 
daa46e05d113fd62ea9dad042ec41aaab28ad003 

Diff: https://reviews.apache.org/r/45120/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 45118: Fixed various style issues.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45118/
---

Review request for mesos, Jie Yu and Joris Van Remoortere.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

Avoid capturing temporaries by const reference, which is against
the style guide.

Fixup some whitespace.


Diffs
-

  src/slave/state.hpp 9cc9df2f8afb2ae848db467892dfb7f54973a6a3 
  src/tests/persistent_volume_tests.cpp 
26fff19daa8b175fdcc06fd9467224d5920a1967 

Diff: https://reviews.apache.org/r/45118/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 45119: Added TODO.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45119/
---

Review request for mesos, Jie Yu and Joris Van Remoortere.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

Added TODO.


Diffs
-

  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 

Diff: https://reviews.apache.org/r/45119/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 45117: Cleaned up header includes in tests.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45117/
---

Review request for mesos, Jie Yu and Joris Van Remoortere.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

Cleaned up header includes in tests.


Diffs
-

  src/tests/containerizer/ns_tests.cpp 4bf45e970bede713fa4ffce205627b149232fe2b 
  src/tests/http_authentication_tests.cpp 
cf2bb762272fa38e04e5c26aef2858300bbd0459 
  src/tests/persistent_volume_endpoints_tests.cpp 
d04063090e7f45b4c047a4e037eed1de79cd6958 
  src/tests/persistent_volume_tests.cpp 
26fff19daa8b175fdcc06fd9467224d5920a1967 
  src/tests/reservation_endpoints_tests.cpp 
028e28c68e8a438d310df04fea0a7e54a6d642a3 
  src/tests/teardown_tests.cpp a5f40f991e99ec0d452074a9d3c209b05b317f51 

Diff: https://reviews.apache.org/r/45117/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 44854: Added validation for executor's shutdown grace period.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44854/
---

(Updated March 21, 2016, 6:38 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Added a test.


Bugs: MESOS-4949
https://issues.apache.org/jira/browse/MESOS-4949


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
  src/tests/master_validation_tests.cpp 
8d0070a1b8e8dcc7fe6360f8c6c6182ba9edef7d 

Diff: https://reviews.apache.org/r/44854/diff/


Testing
---

On Mac OS 10.10.1:
`make check`
`GTEST_FILTER="TaskValidationTest.ExecutorShutdownGracePeriodIsNonNegative" 
./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure`


Thanks,

Alexander Rukletsov

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44655/
---

(Updated March 21, 2016, 6:37 p.m.)


Review request for mesos, Ben Mahler and Gilbert Song.


Bugs: MESOS-4949
https://issues.apache.org/jira/browse/MESOS-4949


Repository: mesos


Description
---

If `ExecutorInfo.shutdown_grace_period` is set, the executor
driver uses it, otherwise it falls back to the environment
variable `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`.


Diffs (updated)
-

  docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404 
  include/mesos/executor/executor.proto 
ae211194a44e0bf2fadc79e833881e45ea3eb2c2 
  include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b 
  include/mesos/v1/executor/executor.proto 
36a2b3f9bc3aaa524f655b9e686a6d33512e6aaa 
  include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b 
  src/slave/containerizer/containerizer.cpp 
f6fc7863d0c215611f170dc0c89aa229407b5137 
  src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 

Diff: https://reviews.apache.org/r/44655/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44994: Added a test for executor shutdown grace period.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44994/
---

(Updated March 21, 2016, 6:33 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4949
https://issues.apache.org/jira/browse/MESOS-4949


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 

Diff: https://reviews.apache.org/r/44994/diff/


Testing (updated)
---

On Mac OS 10.10.4:
`make check`
`GTEST_FILTER="*ExecutorShutdownGracePeriod*" ./bin/mesos-tests.sh 
--gtest_repeat=100 --gtest_break_on_failure`


Thanks,

Alexander Rukletsov

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

[Ben Whitehead]

> On March 18, 2016, 6:24 p.m., Ben Whitehead wrote:
> > src/master/http.cpp, line 959
> > 
> >
> > According to the rules defined in 
> > https://tools.ietf.org/html/rfc3986#section-5 we should be fine to use a 
> > scheme relative location.
> > 
> > I think keeping the link to the RFC is a good idea here, so that the 
> > next person that reads this code knows explicitly what this code was 
> > written against.
> 
> Vinod Kone wrote:
> So all we no to do is append the request.path at the end right?
> 
> Ashwin Murthy wrote:
> Isnt it fine to also preserve the original scheme? It is not presciptive 
> either way. I will definitely add the original comment pointing to the RFC 
> back

The path should be where mesos wants me (as a client) to go, if it's the same 
path but a different host that's fine. If it's the same host but a different 
path, that's fine too.

When resolving a `Location` header it always has to be against a base URI, so 
what is sent back to the client is always evaluated agains the initial URI sent 
to the server.

Regarding scheme, if you are comfortable that mesos has enough information to 
be able to do the redirect across scheme as well then feel free to include it. 
If mesos doesn't know enough that's fine too.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45000/#review124350
---


On March 20, 2016, 4:03 p.m., Ashwin Murthy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45000/
> ---
> 
> (Updated March 20, 2016, 4:03 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3902: [Updated] Fix location header in redirect from non-leader. 
> Addressed comments from Vinod and Ben. Removed the scheme but added the path 
> from the original request to the location header. Preserved the link to the 
> RFC in the comments.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp bfea8fa811c24d37b2d7a8109728e1f40217e02f 
> 
> Diff: https://reviews.apache.org/r/45000/diff/
> 
> 
> Testing
> ---
> 
> Was trying to write unit test in scheduler http api test but it turns out 
> multi master tests cannot be written at this point. Need to manually verify 
> this by setting up multiple masters with ZK.
> 
> 
> Thanks,
> 
> Ashwin Murthy
> 
>

Re: Review Request 43935: Allow setting role in mesos-execute.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/#review124613
---



Looks great! A couple small comments below.


src/cli/execute.cpp (lines 208 - 209)


Fits on one line.



src/cli/execute.cpp (lines 215 - 216)


Could you add a comment here to explain the behavior that you and Guangya 
discussed previously, i.e. the behavior of `Resources::find` with respect to 
the framework's role?


- Greg Mann


On March 17, 2016, 1:39 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43935/
> ---
> 
> (Updated March 17, 2016, 1:39 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.
> 
> 
> Bugs: MESOS-4744
> https://issues.apache.org/jira/browse/MESOS-4744
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow setting role in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
> 
> Diff: https://reviews.apache.org/r/43935/diff/
> 
> 
> Testing
> ---
> 
> make & make check
> 
> start master.
> ./bin/mesos-master.sh --work_dir=/tmp/mesos
> 
> start slave.
> ./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
> --resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"
> 
> running mesos-execute without specifying role succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --resources="cpus:1;mem:512"
> 
> running mesos-execute with role test succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --role="test" --resources="cpus:2;mem:512"
> 
> running mesos-execute with role test1 fails.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --role="test1" --resources="cpus:2;mem:512"
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/
---

(Updated March 21, 2016, 6:30 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Fixed review issues.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add utility functions to manipulate XFS project quotas.


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/linux/xfs.hpp PRE-CREATION 
  src/linux/xfs.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44946/diff/


Testing
---

Make check. Manual verification. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

[James Peach]

> On March 19, 2016, 10:10 p.m., Jie Yu wrote:
> > src/linux/xfs.cpp, line 53
> > 
> >
> > Instead of relying on parameter, can we use os::stat::isdir here?
> 
> James Peach wrote:
> ``isdir`` always follows symlinks. From the caller of this we always make 
> sure what kind of inode we have so we don't need to ``stat(2)`` again and 
> potentially get it wrong.
> 
> Jie Yu wrote:
> From the API perspective, i just feel it strange that we need to pass 
> around 'isdir' which we can always derive.
> 
> Regarding the symlink semantics, we should clearly document the semantics 
> for those public functions (i.e., do we follow symlink or not).
> 
> I am wondering if we can do a symlink (`os::stat::islink`) check in those 
> public functions. For instance, return Nothing if 'path' passed to 
> clearProjectId is a symlink.

Yeh I can do this. We'll just end up ``stat(2)``ing the path multiple times at 
different layers.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/#review124427
---


On March 21, 2016, 6:30 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44946/
> ---
> 
> (Updated March 21, 2016, 6:30 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
> https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add utility functions to manipulate XFS project quotas.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/linux/xfs.hpp PRE-CREATION 
>   src/linux/xfs.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44946/diff/
> 
> 
> Testing
> ---
> 
> Make check. Manual verification. Tests in subsequent patches.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45046/#review124618
---


Ship it!




Ship It!

- Vinod Kone


On March 21, 2016, 3:14 a.m., Michael Browning wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45046/
> ---
> 
> (Updated March 21, 2016, 3:14 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Zhitao Li.
> 
> 
> Bugs: MESOS-4735
> https://issues.apache.org/jira/browse/MESOS-4735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created URI.filename to name fetched files in sandbox where appropriate.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6 
>   docs/fetcher.md f70939d8410516c9387a8cba86b5b75539a5fe9a 
>   include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b 
>   include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b 
>   src/launcher/fetcher.cpp f85b118fb19cf9d4563f89847a783be35067e815 
>   src/slave/containerizer/fetcher.hpp 
> bbdce88da6e41dbb88681bc9d604b00923033b3d 
>   src/slave/containerizer/fetcher.cpp 
> 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161 
>   src/tests/fetcher_cache_tests.cpp 645dae208cb2b0aa2d2181d96eb1fd8893975430 
>   src/tests/fetcher_tests.cpp fb47706eb90ae5808bafe13c681d609a808b0c8e 
> 
> Diff: https://reviews.apache.org/r/45046/diff/
> 
> 
> Testing
> ---
> 
> There are two paths by which a file gets fetched to the executor sandbox: the 
> without-cache path, where the fetcher downloads the file directly from the 
> specified URI, and the with-cache path, where it copies it from the cache. In 
> both cases, we verify that the file is saved to the sandbox directory with 
> the name specified by the "filename" field in the CommandInfo.URI proto.
> 
> 
> Thanks,
> 
> Michael Browning
> 
>

Re: Review Request 44994: Added a test for executor shutdown grace period.

[Alexander Rukletsov]

> On March 18, 2016, 11:24 p.m., Ben Mahler wrote:
> > src/tests/slave_tests.cpp, lines 3317-3323
> > 
> >
> > It seems fine to expect this but arguably if what we care about in this 
> > test is **how** the agent chooses the shutdown timeout, a FUTURE_DISPATCH 
> > on Slave::shutdownExecutorTimeout seems sufficient and closer reflects what 
> > is being tested? This avoids the need for the previous changes to the 
> > TestContainerizer AFAICT?

I agree it is cleaner and better expresses the intention. But for that, we 
should promote `Slave::shutdownExecutorTimeout()` to public. I was thinking to 
avoid this by updating the test containerizer. I'm with replacing it with a 
`FUTURE_DISPATCH` on `Slave::shutdownExecutorTimeout()`.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44994/#review124308
---


On March 18, 2016, 5:13 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44994/
> ---
> 
> (Updated March 18, 2016, 5:13 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4949
> https://issues.apache.org/jira/browse/MESOS-4949
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 
> 
> Diff: https://reviews.apache.org/r/44994/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4:
> `make check`
> `GLOG_v=2 GTEST_FILTER="*SlaveTest*" ./bin/mesos-tests.sh --gtest_repeat=100 
> --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 44948: Add XFS disk resource isolator.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44948/
---

(Updated March 21, 2016, 6:21 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased. Added --enable-xfs-disk-isolator.


Bugs: MESOs-4828
https://issues.apache.org/jira/browse/MESOs-4828


Repository: mesos


Description
---

Track sandbox directory usage by dynamically assigning XFS project
quotas. We track a range of XFS project IDs, assigning a project ID
and a project quota to each sandbox as it is created. When the task
reaches the quota, writes will fail with EDQUOT, and the task will have
an opportunity to handle that.

Quotas are not applied to volume resources since the isolator interface
has no insight into the volume lifecycle. Thus it is not currently
possible to accurately assign and reclaim project IDs.

If LOW is the lower bound of the project ID range and HIGH is the upper
bound, you can show the currently allocated project quotas using the
xfs_quota command:

  $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"

To show the project ID assigned to the file PATH, use the xfs_io command:

  $ xfs_io -r -c stat PATH


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/slave/containerizer/mesos/containerizer.cpp 
ee7a265975323ca891114a286357c8e42901560c 
  src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION 
  src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
  src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 

Diff: https://reviews.apache.org/r/44948/diff/


Testing
---

Make check. Manual testing. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44949: Add XFS disk isolator tests.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44949/
---

(Updated March 21, 2016, 6:20 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased. Added --enable-xfs-disk-isolator.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add basic XFS disk isolator tests by cloning the POSIX disk isolator
tests and making minor changes for the differences in semantics.


Diffs (updated)
-

  src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44949/diff/


Testing
---

Make check. Manual testing.


Thanks,

James Peach

Re: Review Request 44950: Add XFS disk isolator documentation.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/
---

(Updated March 21, 2016, 6:20 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased. Added --enable-xfs-disk-isolator.


Bugs: MESOs-4828
https://issues.apache.org/jira/browse/MESOs-4828


Repository: mesos


Description
---

Add XFS disk isolator documentation.


Diffs (updated)
-

  docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404 
  docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305 

Diff: https://reviews.apache.org/r/44950/diff/


Testing
---

Make check. Source inspection.


Thanks,

James Peach

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/
---

(Updated March 21, 2016, 6:18 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased. Added --enable-xfs-disk-isolator.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add utility functions to manipulate XFS project quotas.


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/linux/xfs.hpp PRE-CREATION 
  src/linux/xfs.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44946/diff/


Testing
---

Make check. Manual verification. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44947: Add tests for XFS project quota utilities.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44947/
---

(Updated March 21, 2016, 6:18 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased. Added --enable-xfs-disk-isolator.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add tests for XFS project quota utilities.


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 
  src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a 

Diff: https://reviews.apache.org/r/44947/diff/


Testing
---

Make check. Manual testing. These tests.


Thanks,

James Peach

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44945/
---

(Updated March 21, 2016, 6:17 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased. Added --enable-xfs-disk-isolator.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add autoconf tests for XFS project quotas.


Diffs (updated)
-

  configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 

Diff: https://reviews.apache.org/r/44945/diff/


Testing
---

Make check. Manual verification.


Thanks,

James Peach

Re: Review Request 37168: Add an example framework using dynamic reservation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review124611
---


Fix it, then Ship it!





src/examples/dynamic_reservation_framework.cpp (line 118)


s/launch task/launch a task/



src/examples/dynamic_reservation_framework.cpp (line 120)


s/lanuch/launch/


- Greg Mann


On March 18, 2016, 6:47 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> ---
> 
> (Updated March 18, 2016, 6:47 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap`.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44832/#review124608
---


Ship it!




Ship It!

- Kevin Klues


On March 16, 2016, 1:50 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44832/
> ---
> 
> (Updated March 16, 2016, 1:50 a.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Kevin Klues.
> 
> 
> Bugs: MESOS-2023
> https://issues.apache.org/jira/browse/MESOS-2023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Validate string when convert `Flags` to `hashmap`.
> 
> 
> Diffs
> -
> 
>   src/common/parse.hpp 9535fad0d50b469fbb4dc6ac5cf5c89b40d29b47 
> 
> Diff: https://reviews.apache.org/r/44832/diff/
> 
> 
> Testing
> ---
> 
> 1. Without pass `--env=`.
> ```
> $ ./src/mesos-execute  --master=127.0.0.1:5050 --name=test --command='echo $a'
> ```
> 
> Output:
> ```
> Starting task test
> Forked command at 4542
> sh -c 'echo $a'
> I0315 11:45:39.153188  4402 slave.cpp:3002] Handling status update 
> TASK_RUNNING (UUID: 06b8f974-b6ec-4d10-b1d8-f84b5d4f728d) for task test of 
> framework cf1af3e0-dd66-41e8-8c56-7ad80d7dce98-0001 from execu
> tor(1)@127.0.0.1:54698
> I0315 11:45:39.153964  4401 status_update_manager.cpp:320] Received status 
> update TASK_RUNNING (UUID: 06b8f974-b6ec-4d10-b1d8-f84b5d4f728d) for task 
> test of framework cf1af3e0-dd66-41e8-8c56-7ad80d7dce98-
> 0001
> ```
> 
> 2. Pass `--env=`.
> ```
> $ ./src/mesos-execute  --master=127.0.0.1:5050 --name=test --command='echo 
> $a' --env="{\"a\": \"stdin\"}"
> ```
> 
> Output:
> ```
> Registered executor on localhost
> Starting task test
> Forked command at 4675
> sh -c 'echo $a'
> stdin
> I0315 11:46:34.797502  4408 slave.cpp:3002] Handling status update 
> TASK_RUNNING (UUID: 16040c40-f5e4-4bf0-8690-447f2901310b) for task test of 
> framework cf1af3e0-dd66-41e8-8c56-7ad80d7dce98-0003 from execu
> tor(1)@127.0.0.1:57831
> ```
> 
> 3. Pass incorrect json format in `--env=`.
> ```
> ./src/mesos-execute  --master=127.0.0.1:5050 --name=test --command='echo $a' 
> --env="{\"a\": {}}"
> Failed to load flag 'env': Failed to load value '{"a": {}}': The value of key 
> 'a' in '{"a":{}}' is not a valid string.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45018/#review124601
---



Patch looks great!

Reviews applied: [45018]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 21, 2016, 2:05 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45018/
> ---
> 
> (Updated March 21, 2016, 2:05 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-3481
> https://issues.apache.org/jira/browse/MESOS-3481
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3481 Add const accessor to Master flags.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
>   src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c 
> 
> Diff: https://reviews.apache.org/r/45018/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> This getter is used to retrieve the flags from master. Currently, if one 
> wants to access master flags in the test, master flag has to be explicitly 
> created and then passed to `CreateMasterFlags(flags)`.
> 
> story description: https://issues.apache.org/jira/browse/MESOS-3481
> 
> 
> Thanks,
> 
> Jay Guo
> 
>