Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Juan Larriba]

> On Abr. 9, 2016, 1:34 a.m., Vinod Kone wrote:
> > support/docker_build.sh, line 125
> > 
> >
> > See the ASF CI build error on the attached ticket.
> > 
> > I think specifying configuration options this way doesn't work with 
> > cmake.
> > 
> > Not sure what the right way is. cc @hausdorff

export CONFIGURATION='-DVERBOSE="1"'


- Juan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127944
---


On Abr. 8, 2016, 11:26 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated Abr. 8, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 43515: Speed up MasterTest.MasterInfoOnReElection.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43515/
---

(Updated April 9, 2016, 6:19 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update description.


Bugs: MESOS-4165
https://issues.apache.org/jira/browse/MESOS-4165


Repository: mesos


Description (updated)
---

Speed up MasterTest.MasterInfoOnReElection by advance allocation
interval.


Diffs
-

  src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 

Diff: https://reviews.apache.org/r/43515/diff/


Testing
---

Repeat test in CentOS 7.1
```
sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.MasterInfoOnReElection" 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang

Re: Review Request 43516: Speed up MasterTest.LaunchCombinedOfferTest.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43516/
---

(Updated April 9, 2016, 6:19 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update description.


Bugs: MESOS-4166
https://issues.apache.org/jira/browse/MESOS-4166


Repository: mesos


Description (updated)
---

Speed up MasterTest.LaunchCombinedOfferTest by advance allocation
interval.


Diffs
-

  src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 

Diff: https://reviews.apache.org/r/43516/diff/


Testing
---

Repeat test in CentOS 7.1
```
sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.LaunchCombinedOfferTest" 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang

Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/
---

(Updated April 9, 2016, 6:18 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update description.


Bugs: MESOS-4172
https://issues.apache.org/jira/browse/MESOS-4172


Repository: mesos


Description (updated)
---

Speed up GarbageCollectorIntegrationTest.Restart by advance allocation
interval.


Diffs
-

  src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6 

Diff: https://reviews.apache.org/r/43520/diff/


Testing
---

Repeat test in CentOS 7.1

```
$ sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang

Re: Review Request 43522: Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43522/
---

(Updated April 9, 2016, 6:16 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update description.


Bugs: MESOS-4171
https://issues.apache.org/jira/browse/MESOS-4171


Repository: mesos


Description (updated)
---

Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover by
advance allocation interval.


Diffs
-

  src/tests/oversubscription_tests.cpp 23671746da2ac505d75bc2bd59114697d9161d52 

Diff: https://reviews.apache.org/r/43522/diff/


Testing
---

Repeat test on CentOS 7.1

```
sudo ./bin/mesos-tests.sh 
--gtest_filter="OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover" 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang

Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/
---

(Updated April 9, 2016, 6:09 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update according to @alexr's comments.


Bugs: MESOS-4172
https://issues.apache.org/jira/browse/MESOS-4172


Repository: mesos


Description
---

Speed up GarbageCollectorIntegrationTest.Restart.


Diffs (updated)
-

  src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6 

Diff: https://reviews.apache.org/r/43520/diff/


Testing (updated)
---

Repeat test in CentOS 7.1

```
$ sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127955
---



Bad patch!

Reviews applied: [45668]

Failed command: ./support/apply-review.sh -n -r 45668

Error:
2016-04-09 05:11:22 URL:https://reviews.apache.org/r/45668/diff/raw/ 
[2693/2693] -> "45668.patch" [1]
error: patch failed: support/docker_build.sh:59
error: support/docker_build.sh: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12420/console

- Mesos ReviewBot


On April 8, 2016, 11:26 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated April 8, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 43524: Speeded up RecoverTest.AutoInitialization by advacing the clock.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43524/
---

(Updated April 9, 2016, 4:11 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, and haosdent huang.


Bugs: MESOS-4160
https://issues.apache.org/jira/browse/MESOS-4160


Repository: mesos


Description
---

Speeded up RecoverTest.AutoInitialization by advacing the clock.


Diffs (updated)
-

  src/tests/log_tests.cpp 8f208bac13a7276074278213119d8894766e84ea 

Diff: https://reviews.apache.org/r/43524/diff/


Testing
---

`$ sudo make check -j2 GTEST_FILTER='RecoverTest.AutoInitialization'`

```sh
[--] 1 test from RecoverTest
[ RUN  ] RecoverTest.AutoInitialization
[   OK ] RecoverTest.AutoInitialization (630 ms)
[--] 1 test from RecoverTest (631 ms total)
```

Repeatly tested with:

```
./bin/mesos-tests.sh --gtest_filter=RecoverTest.AutoInitialization 
--gtest_repeat=1000 --gtest_break_on_failure'
```


Thanks,

Shuai Lin

Re: Review Request 45905: Added metrics to the balloon framework.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45905/#review127952
---



Bad patch!

Reviews applied: [45905, 45604]

Failed command: ./support/apply-review.sh -n -r 45604

Error:
2016-04-09 04:10:44 URL:https://reviews.apache.org/r/45604/diff/raw/ 
[23317/23317] -> "45604.patch" [1]
Total errors found: 0
Checking 2 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12418/console

- Mesos ReviewBot


On April 9, 2016, 12:32 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45905/
> ---
> 
> (Updated April 9, 2016, 12:32 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds metrics to gauge the health of the framework.  This includes:
> 
> * uptime_secs = How long the framework has been running.
> * registered = If the framework is registered.
> * tasks_finished = Number of tasks finished (successfully).
> * tasks_oomed = Number of tasks that were OOM killed.
> * allowed_terminations = Number of terminal status updates which
>   are acceptable due to infrastructure reasons.
> * abnormal_terminations = Number of terminal status updates which 
>   were not `TASK_FINISHED` or `TASK_FAILED` due to OOM.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
> 
> Diff: https://reviews.apache.org/r/45905/diff/
> 
> 
> Testing
> ---
> 
> ```
> make check
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
> 
> # Also launched two instances on a cluster.
> # This one OOM's:
> ./balloon-framework --master=zk://localhost:2181/mesos --checkpoint 
> --balloon_limit=256MB --task_memory=128MB 
> --executor_uri="https://s3.amazonaws.com/url/to/balloon-executor"; 
> --executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
> 
> # This one does not OOM:
> ./balloon-framework --master=zk://localhost:2181/mesos --checkpoint 
> --balloon_limit=256MB --task_memory=256MB 
> --executor_uri="https://s3.amazonaws.com/url/to/balloon-executor"; 
> --executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43524: Speeded up RecoverTest.AutoInitialization by advacing the clock.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43524/
---

(Updated April 9, 2016, 4:10 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, and haosdent huang.


Bugs: MESOS-4160
https://issues.apache.org/jira/browse/MESOS-4160


Repository: mesos


Description
---

Speeded up RecoverTest.AutoInitialization by advacing the clock.


Diffs (updated)
-

  src/tests/log_tests.cpp 8f208bac13a7276074278213119d8894766e84ea 

Diff: https://reviews.apache.org/r/43524/diff/


Testing (updated)
---

`$ sudo make check -j2 GTEST_FILTER='RecoverTest.AutoInitialization'`

```sh
[--] 1 test from RecoverTest
[ RUN  ] RecoverTest.AutoInitialization
[   OK ] RecoverTest.AutoInitialization (630 ms)
[--] 1 test from RecoverTest (631 ms total)
```

Repeatly tested with:

```
./bin/mesos-tests.sh --gtest_filter=RecoverTest.AutoInitialization 
--gtest_repeat=1000 --gtest_break_on_failure'
```


Thanks,

Shuai Lin

Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/
---

(Updated April 9, 2016, 3:39 a.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Added a comment about why use a small value for 
`executor_shutdown_grace_period` flag.


Bugs: MESOS-3775
https://issues.apache.org/jira/browse/MESOS-3775


Repository: mesos


Description
---

Speeded up MasterAllocatorTest.SlaveLost test.


Diffs (updated)
-

  src/tests/master_allocator_tests.cpp 404ff098baf89bf2a1c6e32424d591a6ea1a093c 

Diff: https://reviews.apache.org/r/43329/diff/


Testing (updated)
---

```
[--] 1 test from MasterAllocatorTest/0, where TypeParam = 
mesos::internal::master::allocator::MesosAllocator >
[ RUN  ] MasterAllocatorTest/0.SlaveLost
[   OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
[--] 1 test from MasterAllocatorTest/0 (369 ms total)

[--] 1 test from MasterAllocatorTest/1, where TypeParam = 
mesos::internal::tests::Module
[ RUN  ] MasterAllocatorTest/1.SlaveLost
[   OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
[--] 1 test from MasterAllocatorTest/1 (120 ms total)
```

Tested repeatedly with:
```
./bin/mesos-tests.sh --gtest_filter=MasterAllocatorTest*.SlaveLost 
--gtest_repeat=1000 --gtest_break_on_failure'
```


Thanks,

Shuai Lin

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

[Guangya Liu]

> On 四月 4, 2016, 6:13 p.m., Gilbert Song wrote:
> > src/cli/execute.cpp, line 287
> > 
> >
> > This is incorrect. We handle this merging operation in runtime isolator.
> 
> Tim Anderegg wrote:
> I was testing out a similar implementation of this feature on my own 
> machine, but using AppC instead of Docker.  Since AppC has no runtime 
> isolator in Mesos (yet), I think it would make sense to support merging the 
> arguments within mesos-execute to enable easy testing of container images 
> that have no runtime isolator, no?  Would the Docker runtime isolator 
> properly handle the arguments if they came pre-merged?

@Gilbert, I think that the command was hanlded here 
https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/docker/runtime.cpp#L282-L285
 in runtime isolator, does it do the merge work? I think the runtime isolator 
only did merge work for runtime configuration from docker image, right?

@Tim, +1, and there is also a jira tracing the AppC run time isolator 
https://issues.apache.org/jira/browse/MESOS-4778


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126880
---


On 四月 3, 2016, 1:42 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated 四月 3, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45731/
---

(Updated April 9, 2016, 10:53 a.m.)


Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5117
https://issues.apache.org/jira/browse/MESOS-5117


Repository: mesos


Description
---

Introduced '--networks' flag to mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87 

Diff: https://reviews.apache.org/r/45731/diff/


Testing
---

Ran the following command:
  `sudo src/mesos-execute --master=192.168.122.171:5050 --name=test 
--docker_image=library/busybox --command="sleep 30" --shell=true 
--networks=net1,net2`

The created container successfully joined the CNI networks `net1` and `net2`.


Thanks,

Qian Zhang

Re: Review Request 45970: Added Nvidia GPU test to verify error when requesting fractional GPUs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45970/#review127948
---



Patch looks great!

Reviews applied: [45969, 45970]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 8, 2016, 11:33 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45970/
> ---
> 
> (Updated April 8, 2016, 11:33 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5159
> https://issues.apache.org/jira/browse/MESOS-5159
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Nvidia GPU test to verify error when requesting fractional GPUs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
> dfffb2cf4d1d9c1f2de4ad90ce3d8acc3e98631c 
> 
> Diff: https://reviews.apache.org/r/45970/diff/
> 
> 
> Testing
> ---
> 
> ```
> [klueska@core-dev build]$ sudo 
> GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources" 
> bin/mesos-tests.sh
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from NvidiaGpuTest
> [ RUN  ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources
> [   OK ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources (10184 
> ms)
> [--] 1 test from NvidiaGpuTest (10191 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (10260 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45927: Introduced kill task delay in mesos-execute.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45927/#review127946
---




src/cli/execute.cpp (line 157)


I can see many people ask the format of `time` in user list, it would be 
great if we can list all supported unit here.


https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp#L53-L68


- Guangya Liu


On 四月 8, 2016, 12:39 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45927/
> ---
> 
> (Updated 四月 8, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Bugs: MESOS-5124
> https://issues.apache.org/jira/browse/MESOS-5124
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a flag that specifies a delay after which the task should be
> killed. If set, a kill task request is scheduled to be sent after
> TASK_RUNNING status update has been received. Also adds support for
> TASK_KILLING capability.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/45927/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4:
> `make check`
> 
> Additionally manually tested `mesos-execute` with both responsive and 
> unresponsive (https://github.com/rukletsov/unresponsive-process) tasks:
> `./src/mesos-execute --master=127.0.0.1:5050 --name=test --command="sleep 10" 
> --env='{"GLOG_v": 2}'`
> `./src/mesos-execute --master=127.0.0.1:5050 --name=test 
> --command="/Users/alex/bin/unresponsive_process" --env='{"GLOG_v": 2}'`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45963/
---

(Updated April 9, 2016, 2:27 a.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4324
https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
---

Allow the task to specify the persistent volume access to be read-only
or read-write. Note that the persistent volume is always created as
read-write.
If the task is the first consumer of the shared persistent volume, then
set the ownership of the persistent volume to match that of the task.
Otherwise, allow the task to be executed only if the ownership of the
persistent volume matches that of the task.
Added an option to run the test in mixed (default) mode or shared-only
mode. In mixed mode, multiple shards alternate between shared and
unshared persistent volumes for the tasks. In shared-only mode, all
shards use shared persistent volumes for the tasks.


Diffs (updated)
-

  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/validation.hpp d1f2323172cbf3bb052942a119b8531f9ccad48d 
  src/master/validation.cpp 504cd9b8bd5d40bb591b7aa5a23bd74cc210c2fc 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
cb181265482c884b02bdfc576f906aa0dd9f00f2 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
9fc7c48f99155750fd3c18c7c102507e2726362b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
c6cea98e16f2bdea2da0220c235468080bbcd17b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
01c0ad6dbb6d509e62e769365586b3d23dcb240d 

Diff: https://reviews.apache.org/r/45963/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/
---

(Updated April 9, 2016, 2:26 a.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Added a persistent volume test framework for shared volumes.


Diffs (updated)
-

  src/Makefile.am 4375b036b7fc7243409d89335c8c1a42dc5fa6a8 
  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/tests/examples_tests.cpp ac513ce9aa3c8f366fe81ba937e3dc0d51a26940 
  src/tests/persistent_shared_volume_framework_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/45962/diff/


Testing
---

New test framework for shared resources added.
Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45926/#review127945
---




src/cli/execute.cpp (line 100)


I think we cannot sepcify the entrypoint for container here, the entrypoint 
was runtime configuration and was get from docker iamge.


- Guangya Liu


On 四月 8, 2016, 12:39 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45926/
> ---
> 
> (Updated 四月 8, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/45926/diff/
> 
> 
> Testing
> ---
> 
> See the last patch in the chain: https://reviews.apache.org/r/45927/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127944
---




support/docker_build.sh (line 124)


See the ASF CI build error on the attached ticket.

I think specifying configuration options this way doesn't work with cmake.

Not sure what the right way is. cc @hausdorff


- Vinod Kone


On April 8, 2016, 11:26 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated April 8, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45967: Added documentation for shareable resources.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45967/#review127943
---



Bad patch!

Reviews applied: [45967, 45966, 45964, 45963, 45962, 45961, 45960, 45959, 45958]

Failed command: ./support/apply-review.sh -n -r 45962

Error:
2016-04-09 01:33:58 URL:https://reviews.apache.org/r/45962/diff/raw/ 
[20685/20685] -> "45962.patch" [1]
src/examples/persistent_shared_volume_framework.cpp:249:  Lines should be <= 80 
characters long  [whitespace/line_length] [2]
Total errors found: 1
Checking 2 files

Full log: https://builds.apache.org/job/mesos-reviewbot/12416/console

- Mesos ReviewBot


On April 8, 2016, 11:17 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45967/
> ---
> 
> (Updated April 8, 2016, 11:17 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4325
> https://issues.apache.org/jira/browse/MESOS-4325
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for shareable resources.
> 
> 
> Diffs
> -
> 
>   docs/home.md dc41fc4479e6c23650cd8ac78dcc4b9161d00721 
>   docs/shareable-resources.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45967/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45489: Replaced reinterpret_cast with static_cast in libprocess.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45489/#review127941
---


Ship it!




Ship It!

- Ben Mahler


On March 30, 2016, 4:16 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45489/
> ---
> 
> (Updated March 30, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Casting from a virtual base class to a child class should not be
> done with reinterpret_cast. We could use dynamic_cast as well, but
> that has a performance cost; in this case, we know exactly which
> child class the pointer points to, so the performance cost and
> additional safety offered by dynamic_cast is not necessary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> feaffa4334422ec3964f8d079f570061eaf390d2 
> 
> Diff: https://reviews.apache.org/r/45489/diff/
> 
> 
> Testing
> ---
> 
> make check with GCC 5.3 and recent apple-clang.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 45590: Made `Delegate` and `Handlers` libprocess tests less fragile.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45590/#review127940
---


Ship it!




Ship It!

- Ben Mahler


On April 1, 2016, 4:22 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45590/
> ---
> 
> (Updated April 1, 2016, 4:22 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As previously written, these tests depended on the fact that `post`
> will synchronously deliver a message to a local PID.  That is an
> implementation detail that seems unwise to rely upon. Instead, it is
> quite easy to arrange for both tests to block until the effect of
> the `post` has occurred.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 6b3aa1bcf20466cdf8f8249988b8b06dec27e5cd 
> 
> Diff: https://reviews.apache.org/r/45590/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Without this patch, the libprocess tests fail if the "local message" 
> short-circuit in `transport` is disabled (circa line 556). With the patch, 
> the tests succeed.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/#review127938
---



Intead of adding a new flag, I think we should just rely on `--isolation` flag. 
For instance, if the operator specify `--isolation=cgroups/cpu,cgroups/memory`, 
we will use the cgroup isolator with cgroups_subsystems: cpu and memory. I 
think this patch should be the last patch in the chain so that we can have more 
thorough testing before flipping the switch to use the unified cgroup isolator.

- Jie Yu


On April 7, 2016, 10:40 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45350/
> ---
> 
> (Updated April 7, 2016, 10:40 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, 
> Kevin Klues, and Neil Conway.
> 
> 
> Bugs: MESOS-5040
> https://issues.apache.org/jira/browse/MESOS-5040
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add `--cgroups_subsystems` in agent flags.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c 
>   src/slave/flags.hpp 4236b7fe40b9aa26d57b651be06a0e36037f65c6 
>   src/slave/flags.cpp 7164afef9c82a9bba0f137d7387c3569912b6599 
> 
> Diff: https://reviews.apache.org/r/45350/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45956: Added the `_isolate` method.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45956/#review127936
---



Patch looks great!

Reviews applied: [45953, 45954, 45955, 45956]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 8, 2016, 10:48 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45956/
> ---
> 
> (Updated April 8, 2016, 10:48 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-4922
> https://issues.apache.org/jira/browse/MESOS-4922
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Once the `isolate` is successful, the `_isolate` method calls out the
> `mesos-cni-helper` to setup the /etc/hosts, /etc/hostname and
> /etc/resolv.conf for the container.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 654137c552a7c416f394365e43ea80770fe1ef8d 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 159152a01b68a667dbd57fa6452c6c2a3422787c 
> 
> Diff: https://reviews.apache.org/r/45956/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> *Ran mesos_execute with single master/slave setup to verify that containers 
> get the right hostname and network files when attached to a CNI network.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 45953: Adding a stout interface for `sethostname` system call in linux.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45953/#review127935
---




3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 275)


why not const string& ?



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (lines 277 - 281)


HOSTNAME max length might be variable. Will the system below checks the 
length as well. Why bother adding this additional check?



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 283)


s/ 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45953/
> ---
> 
> (Updated April 8, 2016, 9:59 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-4922
> https://issues.apache.org/jira/browse/MESOS-4922
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding a stout interface for `sethostname` system call in linux.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
> 3c80910653ad2f3b663f19395f10214029f1a75e 
> 
> Diff: https://reviews.apache.org/r/45953/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 45905: Added metrics to the balloon framework.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45905/
---

(Updated April 8, 2016, 5:32 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod 
Kone.


Changes
---

Removed the /framework/counters endpoint.  Added an extra metric for allowable 
failures (currently just one).


Repository: mesos


Description (updated)
---

Adds metrics to gauge the health of the framework.  This includes:

* uptime_secs = How long the framework has been running.
* registered = If the framework is registered.
* tasks_finished = Number of tasks finished (successfully).
* tasks_oomed = Number of tasks that were OOM killed.
* allowed_terminations = Number of terminal status updates which
  are acceptable due to infrastructure reasons.
* abnormal_terminations = Number of terminal status updates which 
  were not `TASK_FINISHED` or `TASK_FAILED` due to OOM.


Diffs (updated)
-

  src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 

Diff: https://reviews.apache.org/r/45905/diff/


Testing
---

```
make check

sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"

# Also launched two instances on a cluster.
# This one OOM's:
./balloon-framework --master=zk://localhost:2181/mesos --checkpoint 
--balloon_limit=256MB --task_memory=128MB 
--executor_uri="https://s3.amazonaws.com/url/to/balloon-executor"; 
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"

# This one does not OOM:
./balloon-framework --master=zk://localhost:2181/mesos --checkpoint 
--balloon_limit=256MB --task_memory=256MB 
--executor_uri="https://s3.amazonaws.com/url/to/balloon-executor"; 
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
```


Thanks,

Joseph Wu

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44090/
---

(Updated April 9, 2016, 12:32 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Changed the calling parameters for Windows API.


Diffs (updated)
-

  3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 
  3rdparty/libprocess/src/poll_socket.cpp 
cb2878565a112017b190b4ff83dc65a876ea45f9 

Diff: https://reviews.apache.org/r/44090/diff/


Testing
---

OSX: make check
Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 45604: Updated the balloon framework and executor.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45604/
---

(Updated April 8, 2016, 5:32 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod 
Kone.


Repository: mesos


Description
---

This gives the example `balloon-framework` enough options to run
outside of the build environment.

This also updates:

* The style of the framework code.
* Adds an option for restricting the number of resources per task
  (otherwise, it will eat up an entire node).
* Adds an option for persisting the framework and launching one task
  after another.
* Adds filters for declined offers.
* Refines the shutdown logic for the executor.  In particular, ironed 
  out bugs when the balloon executor does not exceed the memory limit.


Diffs
-

  src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
  src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
  src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 

Diff: https://reviews.apache.org/r/45604/diff/


Testing
---

```
make check 

sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
```


Thanks,

Joseph Wu

Re: Review Request 45604: Updated the balloon framework and executor.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45604/
---

(Updated April 8, 2016, 5:32 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod 
Kone.


Changes
---

Test and iron out bugs, especially in the executor.  Change logging to glog.


Repository: mesos


Description (updated)
---

This gives the example `balloon-framework` enough options to run
outside of the build environment.

This also updates:

* The style of the framework code.
* Adds an option for restricting the number of resources per task
  (otherwise, it will eat up an entire node).
* Adds an option for persisting the framework and launching one task
  after another.
* Adds filters for declined offers.
* Refines the shutdown logic for the executor.  In particular, ironed 
  out bugs when the balloon executor does not exceed the memory limit.


Diffs (updated)
-

  src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
  src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
  src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 

Diff: https://reviews.apache.org/r/45604/diff/


Testing
---

```
make check 

sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
```


Thanks,

Joseph Wu

Re: Review Request 45861: Windows: Fixed non-blocking connect.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45861/
---

(Updated April 9, 2016, 12:32 a.m.)


Review request for mesos, Alex Clemmer and switched to 'mcypark'.


Repository: mesos


Description
---

Windows: Fixed non-blocking connect.


Diffs (updated)
-

  3rdparty/libprocess/src/poll_socket.cpp 
cb2878565a112017b190b4ff83dc65a876ea45f9 

Diff: https://reviews.apache.org/r/45861/diff/


Testing
---

OSX: make check -j8


Thanks,

Daniel Pravat

Re: Review Request 45932: Add stripped TaskInfo's to ResourceUsage.Executor message.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45932/#review127933
---



Thanks! Looking pretty good, some minor comments below.


CHANGELOG (line 52)


How about:

```
Add task information to container resource usage information.
```



include/mesos/mesos.proto (lines 1026 - 1027)


We should avoid saying "used" here in favor of "allocated". We can probably 
do without this comment.

How about s/resources/allocated here to match the executor above?



include/mesos/mesos.proto (line 1029)


This comment doesn't seem to add anything?



include/mesos/mesos.proto (line 1032)


Can we omit this? Why did you include it?



include/mesos/mesos.proto (lines 1035 - 1036)


Avoid saying "running" here since there are more non-terminal states than 
just RUNNING:

```
// Non-terminal tasks.
```



src/slave/slave.cpp (line 5169)


let's say "non-terminal" instead of running, ideally slave.hpp doesn't say 
"running" either, but let's leave it for now



src/slave/slave.cpp (lines 5171 - 5176)


How about s/taskEntry/t/ ?



src/tests/oversubscription_tests.cpp (lines 230 - 231)


How about s/task_label/key/ s/task_label_value/value/ ? Will it fit on one 
line then?

We generally avoid "foo" and "bar" in favor of things like "key" and 
"value" to make the test clearer, so please ignore the executor labels here.


- Ben Mahler


On April 8, 2016, 5:19 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45932/
> ---
> 
> (Updated April 8, 2016, 5:19 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5030
> https://issues.apache.org/jira/browse/MESOS-5030
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add stripped TaskInfo's to ResourceUsage.Executor message.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
>   src/tests/oversubscription_tests.cpp 
> 23671746da2ac505d75bc2bd59114697d9161d52 
> 
> Diff: https://reviews.apache.org/r/45932/diff/
> 
> 
> Testing
> ---
> 
> Added new test to verify ResourceUsage sees task labels.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45572/#review127918
---



Looks pretty good, thanks!

Could you also add tests that mirror the task label tests?

```
$ grep -R TEST src/tests | grep TaskLabels
src/tests/master_tests.cpp:TEST_F(MasterTest, TaskLabels)
src/tests/slave_tests.cpp:TEST_F(SlaveTest, TaskLabels)
```


CHANGELOG (lines 49 - 50)


The ExecutorInfo.source deprecation should be mentioned in the 
'Deprecations' section. I would ok duplicating this in both sections, and only 
calling out the labels in the 'Additional API Changes' section.



include/mesos/mesos.proto (line 473)


No need to bother renaming slave to agent in the pre-V1 API.



include/mesos/mesos.proto (line 478)


All comments should end with a period, I guess you may have copied this 
from code that didn't follow that style.



include/mesos/mesos.proto (lines 496 - 498)


Any reason not to re-use the more descriptive comment on TaskInfo.labels? 
Specifically it would be nice to include the warning about the master keeping 
this data in memory.


- Ben Mahler


On April 1, 2016, 1:42 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45572/
> ---
> 
> (Updated April 1, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5029
> https://issues.apache.org/jira/browse/MESOS-5029
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add labels to ExecutorInfo and deprecate source.
> 
> 
> Diffs
> -
> 
>   CHANGELOG b90078d41357c29c9102df00a735bde460e797bb 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
>   src/tests/oversubscription_tests.cpp 
> ba036810758d99a6fb0034c5e2bc7829e2343a44 
> 
> Diff: https://reviews.apache.org/r/45572/diff/
> 
> 
> Testing
> ---
> 
> Added a test in oversubciption_tests to make sure executor labels are visible 
> to ResourceEstimator and QoSController.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 45084: Add `Subsystem` abstraction for cgroups.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45084/#review127895
---



Does this patch compile on its own? I'd like each patch to be 'atomic' so that 
we can commit some of them if they look good.


src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (lines 24 - 25)


Instead of that, can you just include ?



src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 32)


Why do you need this header?



src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 46)


Could you please put `flags` as the first parameter?



src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 48)


Why return a raw pointer, instead of an Owned pointer here?



src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 53)


Could you please put `flags` as the first parameter?



src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 57)


`virtual std::string name() const = 0;`

We typically do not return const string.



src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 28)


Please use explicit using clauses here.



src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (lines 68 - 83)


Since you're just adding stubs in this patch, can you introduce such logics 
later? It's hard to review if you stick in logics like this without any context.


- Jie Yu


On April 7, 2016, 10:36 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45084/
> ---
> 
> (Updated April 7, 2016, 10:36 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
> Kevin Klues.
> 
> 
> Bugs: MESOS-5039
> https://issues.apache.org/jira/browse/MESOS-5039
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add `Subsystem` abstraction for cgroups.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/#review127932
---


Ship it!




Ship It!

- Michael Park


On April 7, 2016, 6:23 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45022/
> ---
> 
> (Updated April 7, 2016, 6:23 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4415
> https://issues.apache.org/jira/browse/MESOS-4415
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
> This API is incompatible with NT paths -- which we will eventually have
> to transition to for the Windows integration -- and has no documented
> behavior interacting with subsystems like the driver subsystem, which is
> required for symlinks.
> 
> This commit will move us to proper core Windows API equivalents for
> `::remove`.
> 
> Review: https://reviews.apache.org/r/45022
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 54dd3f7e1453a756e10652cebf4c2a2b09e3d5a4 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 
> 52568b303c03fd57b81f6cc67782444ce734dd41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/45022/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45015/#review127931
---


Ship it!




Ship It!

- Michael Park


On April 7, 2016, 10:23 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45015/
> ---
> 
> (Updated April 7, 2016, 10:23 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently on Windows, `os::exists` will return true if a component of a
> path does not exist. For example if you have `a/fancy/path`, and you ask
> `os::exists("a/fake/path")`, the result currently reports `true`. In
> other words, the Windows code path only checks for the error that a file
> does not exist, and ignores the error that says the path is not valid.
> 
> This commit will fix this, and also add a test that will verify we don't
> regress.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/exists.hpp 
> 9211851e4562e04045276421b359c3c78cdae7f1 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/45015/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44978: Windows: Fixed `fs::list` to be more compliant with POSIX version.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44978/#review127929
---


Ship it!




Ship It!

- Michael Park


On April 8, 2016, 11:23 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44978/
> ---
> 
> (Updated April 8, 2016, 11:23 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Fixed `fs::list` to be more compliant with POSIX version.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/fs.hpp 
> 7dace7d579c1b18afcf2278f9689b205cf57877f 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 1336972f1f4d8dccdaeb0c9c16b1ba6d255debd8 
> 
> Diff: https://reviews.apache.org/r/44978/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44082/#review127928
---


Ship it!




Ship It!

- Michael Park


On April 8, 2016, 11:17 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44082/
> ---
> 
> (Updated April 8, 2016, 11:17 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Un-commented out functions and marked them as deleted instead.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> c48106e5905e3be0faeba7177ef534766089faff 
> 
> Diff: https://reviews.apache.org/r/44082/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44084: Windows: Forked os::rename().

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/#review127930
---


Ship it!




Ship It!

- Michael Park


On April 7, 2016, 10:15 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44084/
> ---
> 
> (Updated April 7, 2016, 10:15 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked os::rename().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
> 7b2215208bcaa5613426d8ede9cab21d1a084631 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/44084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44090/#review127926
---


Fix it, then Ship it!





3rdparty/libprocess/src/poll_socket.cpp (line 81)


Let's use `reinterpret_cast(...)`.



3rdparty/libprocess/src/poll_socket.cpp (line 118)


Let's use `reinterpret_cast(...)`.



3rdparty/libprocess/src/poll_socket.cpp (lines 160 - 166)


We'll follow-up with patches to add the following functions and use them 
here:

```
Try network::send(...);
Try network::recv(...);
```


- Michael Park


On April 8, 2016, 9:38 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44090/
> ---
> 
> (Updated April 8, 2016, 9:38 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
> Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Changed the calling parameters for Windows API.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/libevent.cpp 
> c4a8da8a70b97dd575b1256179c4f43742131a1e 
>   3rdparty/libprocess/src/poll_socket.cpp 
> cb2878565a112017b190b4ff83dc65a876ea45f9 
> 
> Diff: https://reviews.apache.org/r/44090/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 44949: Add XFS disk isolator tests.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44949/#review127923
---


Ship it!




Only some nits which I'll fix when committing.


src/tests/containerizer/xfs_quota_tests.cpp (line 344)


s/that/than/.



src/tests/containerizer/xfs_quota_tests.cpp (line 345)


s/consumed/consume/.



src/tests/containerizer/xfs_quota_tests.cpp (line 597)


A little explanaion of `2u` would be make it clearer.



src/tests/containerizer/xfs_quota_tests.cpp (line 654)


Let's do `count=1`, same as the previous test.


- Jiang Yan Xu


On April 7, 2016, 2:50 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44949/
> ---
> 
> (Updated April 7, 2016, 2:50 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
> https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add basic XFS disk isolator tests by cloning the POSIX disk isolator
> tests and making minor changes for the differences in semantics.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44949/diff/
> 
> 
> Testing
> ---
> 
> Make check. Manual testing.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 45969: Fixed indent in Nvidia GPU test.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45969/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

Fixed indent in Nvidia GPU test.


Diffs
-

  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
dfffb2cf4d1d9c1f2de4ad90ce3d8acc3e98631c 

Diff: https://reviews.apache.org/r/45969/diff/


Testing
---


Thanks,

Kevin Klues

Review Request 45970: Added Nvidia GPU test to verify error when requesting fractional GPUs.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45970/
---

Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Bugs: MESOS-5159
https://issues.apache.org/jira/browse/MESOS-5159


Repository: mesos


Description
---

Added Nvidia GPU test to verify error when requesting fractional GPUs.


Diffs
-

  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
dfffb2cf4d1d9c1f2de4ad90ce3d8acc3e98631c 

Diff: https://reviews.apache.org/r/45970/diff/


Testing
---

```
[klueska@core-dev build]$ sudo 
GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources" 
bin/mesos-tests.sh
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from NvidiaGpuTest
[ RUN  ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources
[   OK ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources (10184 
ms)
[--] 1 test from NvidiaGpuTest (10191 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (10260 ms total)
[  PASSED  ] 1 test.
```


Thanks,

Kevin Klues

Re: Review Request 44427: Added --http_command_executor flag.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44427/#review127910
---



Looks pretty good. Mostly minor comments around indent.


docs/configuration.md (lines 1251 - 1254)


How about:

```

The underlying executor library to be used for the command executor. If set 
to true, the command executor would use the HTTP based executor 
library to interact with the Mesos agent. If set to false, the 
driver based implementation would be used.
NOTE: This flag is *experimental* and should not be used in 
production yet. (default:false)

```



src/slave/flags.cpp (lines 696 - 698)


This would also need to be updated as per my earlier comment.



src/slave/slave.cpp (line 3691)


Two space indent here.



src/slave/slave.cpp (line 3694)


2 space indent here.



src/slave/slave.cpp (line 5640)


We typically don't spill partial arguments from a function invocation.

How about:

```cpp
executorPath = os::realpath(
  path::join(slave->flags.launcher_dir, ..));
```



src/slave/slave.cpp (line 5643)


Same as above.


- Anand Mazumdar


On March 5, 2016, 4:37 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44427/
> ---
> 
> (Updated March 5, 2016, 4:37 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added --http_command_executor flag.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
> 
> Diff: https://reviews.apache.org/r/44427/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Juan Larriba]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
---

(Updated Abr. 8, 2016, 11:26 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Changes
---

Remove trailing space


Bugs: MESOS-5101
https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description (updated)
---

Enable CMake build for Linux as new CONFIGURATOR option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Diffs (updated)
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
---

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake 
and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only 
gcc.


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Juan Larriba]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
---

(Updated Abr. 8, 2016, 11:24 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Changes
---

Rephrased and rebased


Bugs: MESOS-5101
https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description (updated)
---

Enable CMake build for Linux as new CONFIGURATOR option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Diffs (updated)
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
---

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake 
and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only 
gcc.


Thanks,

Juan Larriba

Re: Review Request 45898: CMake: Place master files that moved into the correct directories.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45898/#review127920
---


Ship it!




Ship It!

- Michael Park


On April 7, 2016, 9:55 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45898/
> ---
> 
> (Updated April 7, 2016, 9:55 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Place master files that moved into the correct directories.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 9a4cffa952a452d5df70ea42949142e534067cd6 
> 
> Diff: https://reviews.apache.org/r/45898/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44978: Windows: Fixed `fs::list` to be more compliant with POSIX version.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44978/
---

(Updated April 8, 2016, 11:23 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Fixed `fs::list` to be more compliant with POSIX version.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/fs.hpp 
7dace7d579c1b18afcf2278f9689b205cf57877f 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
1336972f1f4d8dccdaeb0c9c16b1ba6d255debd8 

Diff: https://reviews.apache.org/r/44978/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 45488: Removed an unnecessary `memset` from libprocess.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45488/#review127911
---


Ship it!




Ship It!

- Ben Mahler


On March 30, 2016, 2:49 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45488/
> ---
> 
> (Updated March 30, 2016, 2:49 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Zero'ing the input buffer before receiving data is unnecessary.
> Moreover, keeping the `memset` around is confusing, because it makes
> the API contract of Socket.recv() less clear.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> feaffa4334422ec3964f8d079f570061eaf390d2 
> 
> Diff: https://reviews.apache.org/r/45488/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Juan Larriba]

> On Abr. 8, 2016, 10:55 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 123
> > 
> >
> > Remove the trailing white space and put a period at the end. Also wrap 
> > at 80 chars.
> > 
> > Also I would rephrase this as follows:
> > 
> > # Building inside the source directory and distcheck are not currently 
> > supported 
> > # by our CMake scripts. See MESOS-3108 for details.
> 
> Vinod Kone wrote:
> Also, can you rebase?

Build inside the source directory is actually supported, it just seemed cleaner 
to me build in a different directory. But I will change it to build on the 
source directory.


- Juan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127912
---


On Abr. 8, 2016, 10:41 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated Abr. 8, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44082/
---

(Updated April 8, 2016, 11:17 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout: Un-commented out functions and marked them as deleted instead.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
c48106e5905e3be0faeba7177ef534766089faff 

Diff: https://reviews.apache.org/r/44082/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 45964: Add unit tests for sharing of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45964/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4324
https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
---

Add unit tests for sharing of resources.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
a5dd57a4e0c244fb099433eb7b5777982698ebfd 
  src/tests/master_validation_tests.cpp 
8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
  src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 
  src/tests/persistent_volume_tests.cpp 
d246f35046fff469b847c908de2b305ae629212f 
  src/tests/resources_tests.cpp dc12bd8f1e2da6972bc8aed598811c55d664036e 

Diff: https://reviews.apache.org/r/45964/diff/


Testing
---

Tests for shared resources added for allocator, resources and sorter.
Tests successful.


Thanks,

Anindya Sinha

Review Request 45966: Offer shareable resources to frameworks only if opted in.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45966/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4325
https://issues.apache.org/jira/browse/MESOS-4325


Repository: mesos


Description
---

Added a new capability SHAREABLE_RESOURCES that frameworks need to opt
in if they are interested in receiving shared resources in their
offers.


Diffs
-

  include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
  include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f 
  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/allocator/mesos/hierarchical.hpp 
3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
  src/master/allocator/mesos/hierarchical.cpp 
0de03c7347e01fde2b42f5ec38a34a62edf642a1 
  src/tests/hierarchical_allocator_tests.cpp 
a5dd57a4e0c244fb099433eb7b5777982698ebfd 

Diff: https://reviews.apache.org/r/45966/diff/


Testing
---

Tests updated with new capability.
Tests successful.


Thanks,

Anindya Sinha

Review Request 45967: Added documentation for shareable resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45967/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4325
https://issues.apache.org/jira/browse/MESOS-4325


Repository: mesos


Description
---

Added documentation for shareable resources.


Diffs
-

  docs/home.md dc41fc4479e6c23650cd8ac78dcc4b9161d00721 
  docs/shareable-resources.md PRE-CREATION 

Diff: https://reviews.apache.org/r/45967/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Review Request 45961: Support sharing of resources through reference counting of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45961/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Number of consumers for each shared resource is tracked. The count is
incremented on task launch, and decremented on task termination whenever
the task uses a shared resource.
Allow DESTROY for shared volumes only if reference count is 0.
Since shared resources are available to multiple frameworks of the
same role simultaneously, we normalize it with a weight equivalent
to the number of frameworks to which this shared resource has been
allocated to in the sorter.


Diffs
-

  include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 
  include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 
  src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
  src/common/resources_utils.hpp 2840f459288bbe8440eda08119d4f86a8be5a291 
  src/common/resources_utils.cpp 70e6f025d89383084ab8b2cda23ab1cd55d959b2 
  src/master/allocator/mesos/hierarchical.cpp 
0de03c7347e01fde2b42f5ec38a34a62edf642a1 
  src/master/allocator/sorter/drf/sorter.hpp 
05d5205d29ad74e01e07c508d88b6f8371541513 
  src/master/allocator/sorter/drf/sorter.cpp 
d0efa4d7e6c6f653f99802d90de11f4f075190d4 
  src/master/master.hpp 4d99a07f2ca5df5d4b3e15885d8d8012a083ca1e 
  src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
  src/master/validation.cpp 504cd9b8bd5d40bb591b7aa5a23bd74cc210c2fc 
  src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 

Diff: https://reviews.apache.org/r/45961/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45888: Stout: Implemented `os::setenv` on Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45888/
---

(Updated April 8, 2016, 11:17 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout: Implemented `os::setenv` on Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
c48106e5905e3be0faeba7177ef534766089faff 

Diff: https://reviews.apache.org/r/45888/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 45962: Added a persistent volume test framework for shared volumes.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Added a persistent volume test framework for shared volumes.


Diffs
-

  src/Makefile.am 4375b036b7fc7243409d89335c8c1a42dc5fa6a8 
  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/tests/examples_tests.cpp ac513ce9aa3c8f366fe81ba937e3dc0d51a26940 
  src/tests/persistent_shared_volume_framework_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/45962/diff/


Testing
---

New test framework for shared resources added.
Tests successful.


Thanks,

Anindya Sinha

Review Request 45960: Added interfaces to handle and track shareable resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45960/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Added interfaces to handle and track shareable resources.


Diffs
-

  include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 
  include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 
  src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
  src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 

Diff: https://reviews.apache.org/r/45960/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4892
https://issues.apache.org/jira/browse/MESOS-4892


Repository: mesos


Description
---

Added ShareInfo in Resource protobuf to allow for sharing of resources.


Diffs
-

  include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
  include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f 

Diff: https://reviews.apache.org/r/45958/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45963/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4324
https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
---

Allow the task to specify the persistent volume access to be read-only
or read-write. Note that the persistent volume is always created as
read-write.
If the task is the first consumer of the shared persistent volume, then
set the ownership of the persistent volume to match that of the task.
Otherwise, allow the task to be executed only if the ownership of the
persistent volume matches that of the task.
Added an option to run the test in mixed (default) mode or shared-only
mode. In mixed mode, multiple shards alternate between shared and
unshared persistent volumes for the tasks. In shared-only mode, all
shards use shared persistent volumes for the tasks.


Diffs
-

  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/validation.hpp d1f2323172cbf3bb052942a119b8531f9ccad48d 
  src/master/validation.cpp 504cd9b8bd5d40bb591b7aa5a23bd74cc210c2fc 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
cb181265482c884b02bdfc576f906aa0dd9f00f2 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
9fc7c48f99155750fd3c18c7c102507e2726362b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
c6cea98e16f2bdea2da0220c235468080bbcd17b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
01c0ad6dbb6d509e62e769365586b3d23dcb240d 

Diff: https://reviews.apache.org/r/45963/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45959/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4892
https://issues.apache.org/jira/browse/MESOS-4892


Repository: mesos


Description
---

A new struct Resoure_ is added to keep track of Resource and its
consumer count. As a result, Resources maintains a single container
for all resources. Private operators for addition and subtraction
to/from Resource_ have been added.

All resources have consumer counts that is tracked within Resources. For
resource addition and subtraction, the consumer counts are adjusted for
shared resources as follows:
a) Addition: If shared resource is absent from original, then the
   resource is added with a consumer count of 0. Otherwise, the
   consumer count for the shared resource is incremented by 1.
b) Subtraction: If shared resource's consumer count is already 0, then
   the shared resource is removed from the original. Otherwise, its
   consumer count is decremented by 1.


Diffs
-

  include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 
  include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 
  src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87 
  src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp cba520e326ff8b0b4ed36a0f4cea6879b57f400c 
  src/hook/manager.cpp 17a42f8362f58f0857acabeb2c3113354589fa1b 
  src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
  src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
  src/master/validation.cpp 504cd9b8bd5d40bb591b7aa5a23bd74cc210c2fc 
  src/slave/containerizer/containerizer.cpp 
d0cae79834e451594d7675f00c5f7d2d2cd3a264 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
  src/slave/state.hpp 0de2a4ee4fabaad612c4526166157b001c380bdb 
  src/tests/containerizer/docker_containerizer_tests.cpp 
7accd32fba5eed196a82b1a171cb16d37b9e0539 
  src/tests/containerizer/isolator_tests.cpp 
7b4d47bd9e99b71269093d7c11559f3b74a3e22b 
  src/tests/containerizer/port_mapping_tests.cpp 
21ad1e1c53316a3bb6d914aa228ccf3658acdfbf 
  src/tests/containerizer/runtime_isolator_tests.cpp 
a11a3ffb1df1c5bb760041125c83b7b66d44300b 
  src/tests/fetcher_cache_tests.cpp 9ffcd2375f1203bd3d7c5d0cc898e955d5cb124e 
  src/tests/hierarchical_allocator_tests.cpp 
a5dd57a4e0c244fb099433eb7b5777982698ebfd 
  src/tests/master_quota_tests.cpp e4a65bf09c8fdd2d6b6161042c3702a8cc4cd454 
  src/tests/master_tests.cpp a5b21d3d60f944fd52ceacb4bbbad2613f384db7 
  src/tests/master_validation_tests.cpp 
8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
  src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 
  src/tests/oversubscription_tests.cpp 23671746da2ac505d75bc2bd59114697d9161d52 
  src/tests/persistent_volume_endpoints_tests.cpp 
9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
  src/tests/persistent_volume_tests.cpp 
d246f35046fff469b847c908de2b305ae629212f 
  src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
  src/tests/reservation_endpoints_tests.cpp 
2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
  src/tests/resources_tests.cpp dc12bd8f1e2da6972bc8aed598811c55d664036e 
  src/tests/role_tests.cpp 24959d6e0f83ef7b62b0586be18661aa3cac91dd 
  src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 
  src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5 
  src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 

Diff: https://reviews.apache.org/r/45959/diff/


Testing
---

New tests added to demonstrate arithmetic operations for shared resources with 
consumer counts.
Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 44081: Stout:[2/2] Moved `os::libraries::` namespace back to `stout/os.hpp`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/#review127917
---


Ship it!




Ship It!

- Michael Park


On April 8, 2016, 7:58 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44081/
> ---
> 
> (Updated April 8, 2016, 7:58 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> edaa76a5322d0bf60b7172405aa754b5aca95458 
> 
> Diff: https://reviews.apache.org/r/44081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45940: Agent:[1/2] Fixed transitive #include problem in `load.cpp`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45940/#review127916
---


Ship it!




Ship It!

- Michael Park


On April 8, 2016, 7:59 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45940/
> ---
> 
> (Updated April 8, 2016, 7:59 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `qos_controllers/load.cpp` currently includes `stout/posix/os.hpp`
> directly, which includes `killtree`, which includes `os.hpp`. When we
> move `os::libraries` back to `os.hpp`, this will cause a problem,
> because it will mean that `os::setenv` (which is defined further down in
> `stout/posix/os.hpp` is not defined before
> `os::libraries::Library::setPaths`, which uses it.
> 
> In general, this problem is usually caused by including something like
> `stout/posix/os.hpp` instead of `os.hpp`. The choice to include such a
> header is somewhat fraught, because many files in `os.hpp` (particularly
> those that are included into `os.hpp` via a derivative, like
> `posix/os.hpp`) have implicit dependencies on functions they `#include`
> being defined before their code is defined. This issue will probably get
> worse in the future. Furthermore, it is worth noting that the plan is
> to, at some point, remove `os.hpp` altogether. Depending on the specific
> implementation, this could make the "transitive #include problem" either
> dramatically worse, or much better. This is a discussion the community
> needs to have more braodly.
> 
> This commit will resovle the compile problem by removing `load.cpp`'s
> explicit dependency on `os/os.hpp` and `posix/os.hpp`, and replacing
> them with plain-old `stout/os.hpp`. As noted, however, this is really an
> immediate solution to a larger problem, which we don't attempt to fully
> address here.
> 
> 
> Diffs
> -
> 
>   src/slave/qos_controllers/load.cpp dd44f9209ad283bfea95f16a8c1017e309757f23 
> 
> Diff: https://reviews.apache.org/r/45940/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45888: Stout: Implemented `os::setenv` on Windows.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45888/#review127915
---


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 56 - 68)


How about:

```
  // Do not set the variable if already set and `overwrite` was not 
specified.
  //
  // Per MSDN[1], `GetEnvironmentVariable` returns 0 on error and sets the
  // error code to `ERROR_ENVVAR_NOT_FOUND` if the variable was not found.
  //
  // [1] 
https://msdn.microsoft.com/en-us/library/windows/desktop/ms683188(v=vs.85).aspx
  if (!overwrite &&
  ::GetEnvironmentVariable(key.c_str(), NULL, 0) != 0 &&
  ::GetLastError() == ERROR_ENVVAR_NOT_FOUND) {
return;
  }
```


- Michael Park


On April 7, 2016, 7:31 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45888/
> ---
> 
> (Updated April 7, 2016, 7:31 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `os::setenv` on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 6a391ff198ab724f689bcef79d4e2e05a786cbc2 
> 
> Diff: https://reviews.apache.org/r/45888/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45941: Add check in agent for incorrect oversubscribed resource.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45941/#review127914
---




src/slave/slave.cpp (lines 4989 - 4991)


Any reason why this CHECK isn't below the VLOG(1) above? Having it above 
seems to make it more clear that we're validating the input from the estimator, 
no?

Also, for the comment here, we should avoid talking about the hierarchical 
allocator since that just happens to be where the failure manifests.

Perhaps something like:

```
// Oversubscrbable resources must be considered revocable.
//
// TODO(bmahler): Consider tagging input as revocable
// rather than rejecting and crashing here.
```


- Ben Mahler


On April 8, 2016, 8:02 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45941/
> ---
> 
> (Updated April 8, 2016, 8:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-5131
> https://issues.apache.org/jira/browse/MESOS-5131
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add check in agent for incorrect oversubscribed resource.
> 
> I've decided to let agent crash explicitly here instead of fail more silently.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
> 
> Diff: https://reviews.apache.org/r/45941/diff/
> 
> 
> Testing
> ---
> 
> Running existing test, and verify manually that offending resource crashes 
> the agent.
> 
> (Any suggestion to test `CHECK` is welcomed).
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Vinod Kone]

> On April 8, 2016, 10:55 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 123
> > 
> >
> > Remove the trailing white space and put a period at the end. Also wrap 
> > at 80 chars.
> > 
> > Also I would rephrase this as follows:
> > 
> > # Building inside the source directory and distcheck are not currently 
> > supported 
> > # by our CMake scripts. See MESOS-3108 for details.

Also, can you rebase?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127912
---


On April 8, 2016, 10:41 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated April 8, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

[Ben Mahler]

> On April 4, 2016, 5:26 p.m., haosdent huang wrote:
> > CHANGELOG, line 49
> > 
> >
> > Usually we don't need change file. It would be changed by release 
> > manager.
> 
> Zhitao Li wrote:
> hmm, right now the top section of CHANGELOG is written by each feature 
> author in git blame, and this was also my impression that we should 
> collectively help on changelog documentation so work load of release manager 
> can be reduced.
> 
> Please let me know if my understanding of the process is incorrect and 
> I'll happily drop this change.

We do want contributors adding to the CHANGELOG deprecations / api changes / 
etc. It is difficult for release managers to do a good job at it given how many 
commits are in a release.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45572/#review126862
---


On April 1, 2016, 1:42 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45572/
> ---
> 
> (Updated April 1, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5029
> https://issues.apache.org/jira/browse/MESOS-5029
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add labels to ExecutorInfo and deprecate source.
> 
> 
> Diffs
> -
> 
>   CHANGELOG b90078d41357c29c9102df00a735bde460e797bb 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
>   src/tests/oversubscription_tests.cpp 
> ba036810758d99a6fb0034c5e2bc7829e2343a44 
> 
> Diff: https://reviews.apache.org/r/45572/diff/
> 
> 
> Testing
> ---
> 
> Added a test in oversubciption_tests to make sure executor labels are visible 
> to ResourceEstimator and QoSController.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127912
---


Fix it, then Ship it!





support/docker_build.sh (line 122)


Remove the trailing white space and put a period at the end. Also wrap at 
80 chars.

Also I would rephrase this as follows:

# Building inside the source directory and distcheck are not currently 
supported 
# by our CMake scripts. See MESOS-3108 for details.


- Vinod Kone


On April 8, 2016, 10:41 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated April 8, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45670: Added tests for HTTP command executor.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/#review127907
---



Looks good. Just some minor comments about handling the parameterization in 
test body.


src/tests/command_executor_tests.cpp (line 62)


How about:

```cpp
// The Command Executor tests are parameterized by the underlying library 
used by the executor (e.g., driver or the HTTP based executor library).
```



src/tests/command_executor_tests.cpp (line 64)


s/HttpBasedExecutor/ExecutorType



src/tests/command_executor_tests.cpp (line 78)


How about:

```cpp
slave::Flags flags = CreateSlaveFlags();
flags.http_command_executor = GetParam();

Try> slave = StartSlave(detector.get(), flags);
ASSERT_SOME(slave);
```



src/tests/command_executor_tests.cpp (lines 80 - 85)


Kill this



src/tests/command_executor_tests.cpp (line 148)


Ditto as above.



src/tests/command_executor_tests.cpp (lines 150 - 155)


Kill this


- Anand Mazumdar


On April 7, 2016, 1:49 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45670/
> ---
> 
> (Updated April 7, 2016, 1:49 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for HTTP command executor.
> 
> 
> Diffs
> -
> 
>   src/tests/command_executor_tests.cpp 
> 970cdc39f4f2b0377d36acf2465d377d2a6e1d05 
> 
> Diff: https://reviews.apache.org/r/45670/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127908
---


Ship it!




Ship It!

- Vinod Kone


On April 8, 2016, 10:41 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated April 8, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Review Request 45956: Added the `_isolate` method.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45956/
---

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-4922
https://issues.apache.org/jira/browse/MESOS-4922


Repository: mesos


Description
---

Once the `isolate` is successful, the `_isolate` method calls out the
`mesos-cni-helper` to setup the /etc/hosts, /etc/hostname and
/etc/resolv.conf for the container.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
654137c552a7c416f394365e43ea80770fe1ef8d 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
159152a01b68a667dbd57fa6452c6c2a3422787c 

Diff: https://reviews.apache.org/r/45956/diff/


Testing
---

make

*Ran mesos_execute with single master/slave setup to verify that containers get 
the right hostname and network files when attached to a CNI network.


Thanks,

Avinash sridharan

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Juan Larriba]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
---

(Updated Abr. 8, 2016, 10:41 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Changes
---

Implemented changes required by Vinod's review


Bugs: MESOS-5101
https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description (updated)
---

Enable CMake build for Linux as new CONFIGURATOR option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Diffs (updated)
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
---

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake 
and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only 
gcc.


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Juan Larriba]

> On Abr. 7, 2016, 10:13 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 16
> > 
> >
> > the previous version was working fine on ubuntu and centos. why the 
> > change?
> 
> Juan Larriba wrote:
> It is not working for me on Ubuntu:14.04 and Ubuntu:15.10:
> 
> [root@jlarriba ~]# dirname "$0"
> dirname: invalid option -- 'b'
> Try 'dirname --help' for more information.
> 
> [root@jlarriba ~]# dirname -- "$0"
> .
> 
> Vinod Kone wrote:
> $0 is a bash variable that corresponds to the path of the bash script 
> itself. When `dirname $0` is executed in the script, $0 is the path of the 
> docker_build.sh script.
> 
> ```
> vagrant@vagrant-ubuntu-trusty-64:~$ dirname /foo/bar
> /foo
> vagrant@vagrant-ubuntu-trusty-64:~$ dirname abc
> .
> ```

OK, I remove this change.


> On Abr. 7, 2016, 10:13 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 115
> > 
> >
> > How about
> > 
> > # NOTE: Enviornment is currently ignored by CMake build because tests 
> > are not run.

That line should not be there


- Juan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127677
---


On Abr. 8, 2016, 10:41 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated Abr. 8, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 43522: Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43522/#review127905
---



Bad patch!

Reviews applied: [43522, 43521]

Failed command: ./support/apply-review.sh -n -r 43521

Error:
2016-04-08 22:35:04 URL:https://reviews.apache.org/r/43521/diff/raw/ 
[1556/1556] -> "43521.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12414/console

- Mesos ReviewBot


On April 8, 2016, 6:38 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43522/
> ---
> 
> (Updated April 8, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4171
> https://issues.apache.org/jira/browse/MESOS-4171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover by 
> advance allocation interval.
> 
> 
> Diffs
> -
> 
>   src/tests/oversubscription_tests.cpp 
> 23671746da2ac505d75bc2bd59114697d9161d52 
> 
> Diff: https://reviews.apache.org/r/43522/diff/
> 
> 
> Testing
> ---
> 
> Repeat test on CentOS 7.1
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover" 
> --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 45955: Added CNI helper binary `mesos-cni-helper`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45955/
---

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-4922
https://issues.apache.org/jira/browse/MESOS-4922


Repository: mesos


Description
---

This will be used by the `network/cni` isolator to setup hostname and
various network files within the container UTS and mnt namespace.


Diffs
-

  src/Makefile.am 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 
  src/slave/containerizer/mesos/isolators/network/cni/helper.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45955/diff/


Testing
---

make

* Ran mesos-execute with the a single master/slave setup that the container 
attaches to the CNI network correctly and that its network files and hostname 
are setup correctly.


Thanks,

Avinash sridharan

Review Request 45954: Added `subcommand` to `network/cni` isolator.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45954/
---

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-4922
https://issues.apache.org/jira/browse/MESOS-4922


Repository: mesos


Description
---

The `subcommand` allow configuring the container hostname and setting
up network files in the container such as /etc/hosts, /etc/hostname,
/etc/resolv.conf. This will allow for correct name to IP resolution
within the container network namespace.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
654137c552a7c416f394365e43ea80770fe1ef8d 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
159152a01b68a667dbd57fa6452c6c2a3422787c 

Diff: https://reviews.apache.org/r/45954/diff/


Testing
---

make

* Ran mesos_execute along with a single master/slave setup to verify that the 
container joins the CNI network and the hostname and /etc/hosts, 
/etc/resolv.conf are setup correctly.


Thanks,

Avinash sridharan

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Juan Larriba]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
---

(Updated Abr. 8, 2016, 10:31 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Changes
---

Added Jira issue in "bugs"


Bugs: MESOS-5101
https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description
---

Enable CMake build for Linux as new CONFIGURATOR option.


Diffs
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
---

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake 
and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only 
gcc.


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Vinod Kone]

> On April 7, 2016, 10:13 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 16
> > 
> >
> > the previous version was working fine on ubuntu and centos. why the 
> > change?
> 
> Juan Larriba wrote:
> It is not working for me on Ubuntu:14.04 and Ubuntu:15.10:
> 
> [root@jlarriba ~]# dirname "$0"
> dirname: invalid option -- 'b'
> Try 'dirname --help' for more information.
> 
> [root@jlarriba ~]# dirname -- "$0"
> .

$0 is a bash variable that corresponds to the path of the bash script itself. 
When `dirname $0` is executed in the script, $0 is the path of the 
docker_build.sh script.

```
vagrant@vagrant-ubuntu-trusty-64:~$ dirname /foo/bar
/foo
vagrant@vagrant-ubuntu-trusty-64:~$ dirname abc
.
```


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127677
---


On April 6, 2016, 3:49 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated April 6, 2016, 3:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Juan Larriba]

> On Abr. 7, 2016, 10:13 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 16
> > 
> >
> > the previous version was working fine on ubuntu and centos. why the 
> > change?

It is not working for me on Ubuntu:14.04 and Ubuntu:15.10:

[root@jlarriba ~]# dirname "$0"
dirname: invalid option -- 'b'
Try 'dirname --help' for more information.

[root@jlarriba ~]# dirname -- "$0"
.


- Juan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127677
---


On Abr. 6, 2016, 3:49 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated Abr. 6, 2016, 3:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 44142: Windows: Implemented os::close for Windows.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44142/
---

(Updated April 8, 2016, 10:05 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Summary (updated)
-

Windows: Implemented os::close for Windows.


Repository: mesos


Description (updated)
---

Windows: Implemented os::close for Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 
1c912c3edc815e7e0b1a562286279897d773a516 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
a7f855dc9d0a87fe3b6d1611e7ae22e4d7cd7b6d 

Diff: https://reviews.apache.org/r/44142/diff/


Testing
---


Thanks,

Daniel Pravat

Review Request 45953: Adding a stout interface for `sethostname` system call in linux.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45953/
---

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-4922
https://issues.apache.org/jira/browse/MESOS-4922


Repository: mesos


Description
---

Adding a stout interface for `sethostname` system call in linux.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
3c80910653ad2f3b663f19395f10214029f1a75e 

Diff: https://reviews.apache.org/r/45953/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 45861: Windows: Fixed non-blocking connect.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45861/#review127899
---


Ship it!




Ship It!

- Michael Park


On April 8, 2016, 9:47 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45861/
> ---
> 
> (Updated April 8, 2016, 9:47 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and switched to 'mcypark'.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Fixed non-blocking connect.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp 
> cb2878565a112017b190b4ff83dc65a876ea45f9 
> 
> Diff: https://reviews.apache.org/r/45861/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check -j8
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Review Request 45951: Implemented http basic auth to get docker auth token.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45951/
---

Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
Chen.


Bugs: MESOS-4938
https://issues.apache.org/jira/browse/MESOS-4938


Repository: mesos


Description
---

Implemented http basic auth to get docker auth token.


Diffs
-

  src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 

Diff: https://reviews.apache.org/r/45951/diff/


Testing
---

make check

Tested with mesos-execute, using a private repo from docker hub.


Thanks,

Gilbert Song

Review Request 45952: Implemented support for passing agent default docker config.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45952/
---

Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
Chen.


Bugs: MESOS-4938
https://issues.apache.org/jira/browse/MESOS-4938


Repository: mesos


Description
---

Implemented support for passing agent default docker config.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
eeec94326a4fd67675df10e0b6a32267e555fa96 
  src/uri/fetchers/docker.hpp c855a2b55a07bb398f7547b44a85b8ba2d2b2ec3 
  src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 

Diff: https://reviews.apache.org/r/45952/diff/


Testing
---

make check

Tested with mesos-execute, using a private repo from docker hub. Both cases are 
tested:
1. --docker_registry=private_registry
2. private_registry/repo


Thanks,

Gilbert Song

Review Request 45950: Added test for docker spec get credential helper.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45950/
---

Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
Chen.


Bugs: MESOS-4938
https://issues.apache.org/jira/browse/MESOS-4938


Repository: mesos


Description
---

Added test for docker spec get credential helper.


Diffs
-

  src/tests/containerizer/docker_spec_tests.cpp 
796b020f58f8451362bc1357ab6d7ceb4e946b3c 

Diff: https://reviews.apache.org/r/45950/diff/


Testing
---

make check


Thanks,

Gilbert Song

Review Request 45949: Implemented docker config get credential helper.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45949/
---

Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
Chen.


Bugs: MESOS-4938
https://issues.apache.org/jira/browse/MESOS-4938


Repository: mesos


Description
---

Implemented docker config get credential helper.


Diffs
-

  include/mesos/docker/spec.hpp 2ebacc70d92a593c8dd006b34519c3a2a5225481 
  src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d 

Diff: https://reviews.apache.org/r/45949/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 45861: Windows: Fixed non-blocking connect.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45861/
---

(Updated April 8, 2016, 9:47 p.m.)


Review request for mesos, Alex Clemmer and switched to 'mcypark'.


Repository: mesos


Description
---

Windows: Fixed non-blocking connect.


Diffs (updated)
-

  3rdparty/libprocess/src/poll_socket.cpp 
cb2878565a112017b190b4ff83dc65a876ea45f9 

Diff: https://reviews.apache.org/r/45861/diff/


Testing
---

OSX: make check -j8


Thanks,

Daniel Pravat

Re: Review Request 45932: Add stripped TaskInfo's to ResourceUsage.Executor message.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45932/#review127898
---



Bad patch!

Reviews applied: [45932, 45572]

Failed command: ./support/apply-review.sh -n -r 45572

Error:
2016-04-08 21:47:10 URL:https://reviews.apache.org/r/45572/diff/raw/ 
[5204/5204] -> "45572.patch" [1]
error: patch failed: CHANGELOG:46
error: CHANGELOG: patch does not apply
error: patch failed: src/tests/oversubscription_tests.cpp:54
error: src/tests/oversubscription_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12413/console

- Mesos ReviewBot


On April 8, 2016, 5:19 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45932/
> ---
> 
> (Updated April 8, 2016, 5:19 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5030
> https://issues.apache.org/jira/browse/MESOS-5030
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add stripped TaskInfo's to ResourceUsage.Executor message.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
>   src/tests/oversubscription_tests.cpp 
> 23671746da2ac505d75bc2bd59114697d9161d52 
> 
> Diff: https://reviews.apache.org/r/45932/diff/
> 
> 
> Testing
> ---
> 
> Added new test to verify ResourceUsage sees task labels.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 44142: Windows:[2/2] Implemented os::close for Windows.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44142/
---

(Updated April 8, 2016, 9:40 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Summary (updated)
-

Windows:[2/2] Implemented os::close for Windows.


Repository: mesos


Description (updated)
---

Windows:[2/2] Implemented os::close for Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 
1c912c3edc815e7e0b1a562286279897d773a516 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
a7f855dc9d0a87fe3b6d1611e7ae22e4d7cd7b6d 

Diff: https://reviews.apache.org/r/44142/diff/


Testing
---


Thanks,

Daniel Pravat

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45440/#review127897
---


Ship it!




Ship It!

- Vinod Kone


On April 6, 2016, 11:19 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45440/
> ---
> 
> (Updated April 6, 2016, 11:19 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5062
> https://issues.apache.org/jira/browse/MESOS-5062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds metrics to gauge the health of the framework.  This includes:
> 
> * uptime_secs = How long the framework has been running.
> * registered = If the framework is registered.
> * offers_received = A counter used to determine if the framework is 
>   starved or not.
> * tasks_launched = Number of tasks launched.
> * abnormal_terminations = Number of terminal status updates which 
>   were not `TASK_FINISHED`.
> 
> Also adds an endpoint `/framework/counters` which returns the list of 
> metrics which are "counters".
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45440/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also deployed this version on a test cluster.  See the previous review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44090/
---

(Updated April 8, 2016, 9:38 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Changed the calling parameters for Windows API.


Diffs (updated)
-

  3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 
  3rdparty/libprocess/src/poll_socket.cpp 
cb2878565a112017b190b4ff83dc65a876ea45f9 

Diff: https://reviews.apache.org/r/44090/diff/


Testing
---

OSX: make check
Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 45910: Move metrics code into the scheduler body.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45910/#review127896
---


Ship it!




Ship It!

- Vinod Kone


On April 8, 2016, 8:29 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45910/
> ---
> 
> (Updated April 8, 2016, 8:29 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the HTTP scheduler is a libprocess process, the sub-class 
> `Metrics` does not need to be a process anymore.  This moves the
> process-specific code into the appropriate place in the scheduler.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45910/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Deployed on a test cluster (see the first review in the chain.)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 44893: Remove fetcher header file in containerizer.hpp.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44893/#review127894
---



Does mesos compile after applying this patch? If not, I would rather not split 
the patch. Yes, we prefer smaller patches, but each of them should be an atomic 
change, instead of just splitting a large patch into smaller pieces. There's no 
point of doing that.

Could you please merge those non-atomic changes into one patch? Otherwise, it's 
hard to reason what have you done.

- Jie Yu


On April 3, 2016, 2:12 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44893/
> ---
> 
> (Updated April 3, 2016, 2:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till 
> Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-5086
> https://issues.apache.org/jira/browse/MESOS-5086
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove fetcher header file in containerizer.hpp.
> 
> 
> Diffs
> -
> 
>   src/local/local.cpp 06f6118a5038149f87e970b5cdf7987a270d3fae 
>   src/slave/containerizer/containerizer.hpp 
> ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
>   src/slave/containerizer/docker.hpp 89d450e10a84f24ddd46d517e2b4b46ab02c4fda 
>   src/slave/containerizer/mesos/containerizer.hpp 
> a6e3a8b43fb7591ff6f23b019a062696c8bfb719 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
> 
> Diff: https://reviews.apache.org/r/44893/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45910: Move metrics code into the scheduler body.

[Vinod Kone]

> On April 8, 2016, 7:11 p.m., Vinod Kone wrote:
> > src/examples/long_lived_framework.cpp, lines 136-149
> > 
> >
> > I'm still not convinced that duplicating this information in 
> > /metrics/snashot and /counters is a great idea. We haven't done this for 
> > other metrics in the code base.
> > 
> > Is it a limitation of the monitoring system you are using that 
> > disallows it to slurp both counters and gauges from the same endpoint?
> 
> Joseph Wu wrote:
> There is no duplication here.  (The `/counters` endpoint doesn't give 
> metrics, only the name of metrics.)
> 
> As for the monitoring system, there are a couple types of queries which 
> assume a monotonically increasing value (counters).  So the data is less 
> useful if we cannot differentiate between counters/gauges.  For now, this 
> code isn't super-critical, so I'll remove it here.
> 
> Do you want me to remove it from the earlier review too?

just removing here is fine.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45910/#review127845
---


On April 8, 2016, 8:29 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45910/
> ---
> 
> (Updated April 8, 2016, 8:29 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the HTTP scheduler is a libprocess process, the sub-class 
> `Metrics` does not need to be a process anymore.  This moves the
> process-specific code into the appropriate place in the scheduler.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45910/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Deployed on a test cluster (see the first review in the chain.)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 45942: Updated the webui to include GPU metrics.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45942/#review127891
---


Ship it!




Ship It!

- Ben Mahler


On April 8, 2016, 8:36 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45942/
> ---
> 
> (Updated April 8, 2016, 8:36 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5157
> https://issues.apache.org/jira/browse/MESOS-5157
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the webui to include GPU metrics.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/framework.html 
> ee42d1ab841a4c42d95512ee60d577b1bbb66bc8 
>   src/webui/master/static/frameworks.html 
> 15ff1e9cb6c70df8df47a1b939681abde591e010 
>   src/webui/master/static/home.html a691084f4992cda65734f5fee3b2f38349737b83 
>   src/webui/master/static/js/controllers.js 
> f92affab41f8418cd7e5ea25561a182a1761fd79 
>   src/webui/master/static/offers.html 
> 01213e9582f50072a9c729782271269f72972d28 
>   src/webui/master/static/slave.html 4419f7c166e8768040dab7dbc6fb64e1382ad272 
>   src/webui/master/static/slave_executor.html 
> 5acb676390fe4ed17369143c5a13202c0981 
>   src/webui/master/static/slave_framework.html 
> 4b2b1562f38f002b4659b4a883249f0469307323 
>   src/webui/master/static/slaves.html 
> 0cb125a7d95ccc7770916cbffa052f43e8ea3d2c 
> 
> Diff: https://reviews.apache.org/r/45942/diff/
> 
> 
> Testing
> ---
> 
> Manually opened the web UI, clicked around to make sure all the GPU metrics 
> now showed up.
> Also looked at "Inspect Element" to verify that there were no javascript 
> errors when loading.
> 
> Specifically:
> ```
> * The Resources section in the left sidebar of the main page
> * The Resources section of the table in the Frameworks tab
> * The Resources section of the table in the Slaves tab
> * The Resources section of the table in the Offers tab
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

[Ben Mahler]

- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45855/#review127534
---


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45855/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5135
> https://issues.apache.org/jira/browse/MESOS-5135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to include references to GPUs as a first class resource.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 26468d962440560a6b4b35f51ca248ab059ec31f 
>   docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc 
> 
> Diff: https://reviews.apache.org/r/45855/diff/
> 
> 
> Testing
> ---
> 
> Looked at regenerated website and it seems to include the new documentation 
> properly.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

[Ben Mahler]

> On April 7, 2016, 2:13 a.m., haosdent huang wrote:
> > docs/attributes-resources.md, line 99
> > 
> >
> > How about sort it by alphabetically?
> 
> Kevin Klues wrote:
> The only reason I didn't sort alphabetically was because these resources 
> don't seem to be ordered alphabetically anywhere else (`disk` always seems to 
> come *after* `mem`).  Since `gpus` are pretty similar to `cpus` in their 
> semantics, I decided to place them next to them in the order here.  We can 
> wait to see what Ben thinks.

After "cpus" sounds good to me since it's already not alphabetical.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45855/#review127534
---


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45855/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5135
> https://issues.apache.org/jira/browse/MESOS-5135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to include references to GPUs as a first class resource.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 26468d962440560a6b4b35f51ca248ab059ec31f 
>   docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc 
> 
> Diff: https://reviews.apache.org/r/45855/diff/
> 
> 
> Testing
> ---
> 
> Looked at regenerated website and it seems to include the new documentation 
> properly.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45855/#review127889
---


Ship it!




Ship It!

- Ben Mahler


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45855/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5135
> https://issues.apache.org/jira/browse/MESOS-5135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to include references to GPUs as a first class resource.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 26468d962440560a6b4b35f51ca248ab059ec31f 
>   docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc 
> 
> Diff: https://reviews.apache.org/r/45855/diff/
> 
> 
> Testing
> ---
> 
> Looked at regenerated website and it seems to include the new documentation 
> properly.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45854: Updated the default JSON representation of a Resource to include GPUs.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45854/#review127887
---


Ship it!





src/tests/common/http_tests.cpp (lines 162 - 163)


I'm a little hesitant about using revocable gpus here given that it's not 
clear how it would work, but I suppose there is no harm in it for this test.


- Ben Mahler


On April 8, 2016, 5:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45854/
> ---
> 
> (Updated April 8, 2016, 5:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5136
> https://issues.apache.org/jira/browse/MESOS-5136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This includes updating some tests that parse this JSON and look for
> specific values for all of its fields.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp 3748c71686c696c47f93a81e3434bbb55448e334 
>   src/tests/common/http_tests.cpp ac6322d7fb58adf7a615c517496d08dee3bf0081 
>   src/tests/dynamic_weights_tests.cpp 
> e36a45fa18d163430df1c9dc72d2372aee9b44e6 
>   src/tests/role_tests.cpp 056359bbe6a02bb129bfa2ce371e82cd3aa4c984 
> 
> Diff: https://reviews.apache.org/r/45854/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45852: Added standard metrics for GPU resources.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45852/#review127886
---


Ship it!




Ship It!

- Ben Mahler


On April 8, 2016, 8:34 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45852/
> ---
> 
> (Updated April 8, 2016, 8:34 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-4624
> https://issues.apache.org/jira/browse/MESOS-4624
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added standard metrics for GPU resources.
> 
> 
> Diffs
> -
> 
>   src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 
>   src/slave/metrics.cpp 42c66d7d7176232ccc71f1e040bcae99900f49f8 
>   src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 
>   src/tests/slave_tests.cpp 03bb6da687a1bf11d81619839e6730835e5c4d82 
> 
> Diff: https://reviews.apache.org/r/45852/diff/
> 
> 
> Testing
> ---
> 
> Ran:
> ```
> GTEST_FILTER="SlaveTest.MetricsInMetricsEndpoint:SlaveTest.MetricsInMetricsEndpoint"
>  make -j check
> SUCCESS
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45856: Fixed Nvidia GPU test build for namespace change of MasterDetector.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45856/#review127885
---


Ship it!




Ship It!

- Ben Mahler


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45856/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5138
> https://issues.apache.org/jira/browse/MESOS-5138
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed Nvidia GPU test build for namespace change of MasterDetector.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
> 5565227bc0b18f1891265e6eff0c5a22a0c4ab86 
> 
> Diff: https://reviews.apache.org/r/45856/diff/
> 
> 
> Testing
> ---
> 
> make check -j
> 
> ```
> sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" 
> bin/mesos-tests.sh
> SUCCESS
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>