Re: Review Request 45203: Add authentication test for /weights GET request.

2016-04-10 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45203/#review128021
---



This test looks fine, but what about testing the positive case? In a previous 
version of another patch, you replaced `checkWithRolesEndpoint` with a version 
that used GET on /weights. Can you revive that so we can make sure we're 
testing that a successful request returns the expected response?


src/tests/dynamic_weights_tests.cpp (line 520)


s/response1/response/


- Adam B


On March 23, 2016, 1:53 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45203/
> ---
> 
> (Updated March 23, 2016, 1:53 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4316
> https://issues.apache.org/jira/browse/MESOS-4316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add authentication  test for /weights GET request.
> 
> 
> Diffs
> -
> 
>   src/tests/dynamic_weights_tests.cpp 
> ee0c4b1cc20e76a35a8e4e445f6827a1fc33e6c6 
> 
> Diff: https://reviews.apache.org/r/45203/diff/
> 
> 
> Testing
> ---
> 
> make && make check.
> 
> $ ./src/mesos-tests 
> --gtest_filter=DynamicWeightsTest.UnauthenticatedQueryWeightRequest
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from DynamicWeightsTest
> [ RUN  ] DynamicWeightsTest.UnauthenticatedQueryWeightRequest
> [   OK ] DynamicWeightsTest.UnauthenticatedQueryWeightRequest (81 ms)
> [--] 1 test from DynamicWeightsTest (81 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (91 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 44512: Support to get weights info by /weights.

2016-04-10 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44512/#review128020
---


Fix it, then Ship it!




Looks great! I'm testing a build now with the below suggestions, and will 
commit the patch if that succeeds.


docs/weights.md (line 25)


Maybe name the anchor `#putRequest` to match the `#getRequest`



src/master/master.hpp (lines 1035 - 1041)


I would switch the order here to alphabetize `get` before `put`, like you 
have in the cpp.



src/master/weights_handler.cpp (line 71)


I wonder if `jsonify(weightInfos)` would work here


- Adam B


On March 22, 2016, 3:02 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44512/
> ---
> 
> (Updated March 22, 2016, 3:02 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4316
> https://issues.apache.org/jira/browse/MESOS-4316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support to get weights info by /weights.
> 
> 
> Diffs
> -
> 
>   docs/weights.md a94251340d5193c9474b2e5e85328d62fe4edd8f 
>   src/master/http.cpp bfea8fa811c24d37b2d7a8109728e1f40217e02f 
>   src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
>   src/master/weights_handler.cpp c9a1b0d9adbeb1e165999cdbb4f295b24f10b18f 
> 
> Diff: https://reviews.apache.org/r/44512/diff/
> 
> 
> Testing
> ---
> 
> make && make check.
> 
> $ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/tmp/mesos-master  
> --authenticate_http --credentials=/opt/credentials.json  >> 
> /tmp/mesos-master.log 2>&1 &)
> 
> $ curl --user framework1:secret_string1 http://localhost:5050/weights | 
> python -mjson.tool
> []
> 
> $ curl --user framework1:secret_string1 --data 
> "[{\"weight\":1.8,\"role\":\"role1\"},{\"weight\":1.0,\"role\":\"role2\"},{\"weight\":3.4,\"role\":\"role3\"}]"
>  -X PUT http://127.0.0.1:5050/weights
> 
> $ curl --user framework1:secret_string1 http://localhost:5050/weights | 
> python -mjson.tool
> [
> {
> "role": "role3",
> "weight": 3.4
> },
> {
> "role": "role2",
> "weight": 1.0
> },
> {
> "role": "role1",
> "weight": 1.8
> }
> ]
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 45944: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

2016-04-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45944/#review128022
---



Patch looks great!

Reviews applied: [45898, 44090, 45888, 45940, 44081, 44082, 44978, 44084, 
45943, 45944]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 8, 2016, 8:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45944/
> ---
> 
> (Updated April 8, 2016, 8:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4465
> https://issues.apache.org/jira/browse/MESOS-4465
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/tests/containerizer/cgroups_tests.cpp 
> ecd83c7427353790d93e98ab3d62c46a8da43c96 
>   src/tests/containerizer/memory_test_helper.cpp 
> 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6 
> 
> Diff: https://reviews.apache.org/r/45944/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-10 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/
---

(Updated April 10, 2016, 8:09 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.


Changes
---

Moved scratch related code to overlay.cpp file.


Bugs: MESOS-4944
https://issues.apache.org/jira/browse/MESOS-4944


Repository: mesos


Description
---

Improved overlay backend to make the rootfs writable.


Diffs (updated)
-

  docs/container-image.md db4b291498309d5c0bdbf38552b985c33f28e9a0 
  src/slave/containerizer/mesos/provisioner/backend.hpp 
c6cca81e287bb9a62e0390f96e1773841887a206 
  src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
9eda944e14f2b05f28620c2e40594ed4e7bab69e 
  src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
  src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
b62507f9fc757349d39f39a6654ddd69053bf0e7 
  src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
85cc737438c88b355f37611bfde50dc80efab017 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
93892a75fe3ddd5c7b2a023b63f6d0fa83eeb97d 
  src/slave/containerizer/mesos/provisioner/paths.hpp 
2ea38ac3342e1ebb712a7bea8ebef1bdcf96e809 
  src/slave/containerizer/mesos/provisioner/paths.cpp 
07581f6ac714485e9c743984a553bb6fb26756b7 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
8a4938ebe4e00779e88e7c538445e9ffd51202e2 
  src/tests/containerizer/provisioner_backend_tests.cpp 
d49204f220c6212f83c2adf5544d04b3386c8eb7 

Diff: https://reviews.apache.org/r/45358/diff/


Testing
---

- make check
- tested manually, with slave using overlay backend. Create a task with mesos 
containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
/abc/def.txt`.
- also tested manually with alpine image to verify overlay backend could 
support 1-layer images.


Thanks,

Shuai Lin

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-10 Thread Shuai Lin 


> On April 7, 2016, 11:54 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 296
> > 
> >
> > since scatch space is specific to overlay backend. I would simply pass 
> > /containers//backends/ as backendDir here 
> > and pass it to provision.
> > 
> > We can construct the sratch dir in overlay backend code.

Updated.  A uuid is generated as the parent dir of "upperdir" and "workdir", 
under "backends/overlay/scratch/". This uuid is not the same as the rootfs id 
(otherwise we need to pass the rootfs id as an extra argument to the backend), 
but it won't cause any problem for the cleanup since the whole container 
provision dir is removed with `os::rmdir`.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/#review127696
---


On April 10, 2016, 8:09 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45358/
> ---
> 
> (Updated April 10, 2016, 8:09 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4944
> https://issues.apache.org/jira/browse/MESOS-4944
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved overlay backend to make the rootfs writable.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md db4b291498309d5c0bdbf38552b985c33f28e9a0 
>   src/slave/containerizer/mesos/provisioner/backend.hpp 
> c6cca81e287bb9a62e0390f96e1773841887a206 
>   src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
> 9eda944e14f2b05f28620c2e40594ed4e7bab69e 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> 9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
>   src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
> b62507f9fc757349d39f39a6654ddd69053bf0e7 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
> 85cc737438c88b355f37611bfde50dc80efab017 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 93892a75fe3ddd5c7b2a023b63f6d0fa83eeb97d 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 2ea38ac3342e1ebb712a7bea8ebef1bdcf96e809 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 07581f6ac714485e9c743984a553bb6fb26756b7 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 8a4938ebe4e00779e88e7c538445e9ffd51202e2 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> d49204f220c6212f83c2adf5544d04b3386c8eb7 
> 
> Diff: https://reviews.apache.org/r/45358/diff/
> 
> 
> Testing
> ---
> 
> - make check
> - tested manually, with slave using overlay backend. Create a task with mesos 
> containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
> /abc/def.txt`.
> - also tested manually with alpine image to verify overlay backend could 
> support 1-layer images.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 44512: Support to get weights info by /weights.

2016-04-10 Thread Adam B 


> On April 10, 2016, 12:53 a.m., Adam B wrote:
> > src/master/weights_handler.cpp, line 71
> > 
> >
> > I wonder if `jsonify(weightInfos)` would work here

Nope. Nevermind.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44512/#review128020
---


On March 22, 2016, 3:02 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44512/
> ---
> 
> (Updated March 22, 2016, 3:02 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4316
> https://issues.apache.org/jira/browse/MESOS-4316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support to get weights info by /weights.
> 
> 
> Diffs
> -
> 
>   docs/weights.md a94251340d5193c9474b2e5e85328d62fe4edd8f 
>   src/master/http.cpp bfea8fa811c24d37b2d7a8109728e1f40217e02f 
>   src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
>   src/master/weights_handler.cpp c9a1b0d9adbeb1e165999cdbb4f295b24f10b18f 
> 
> Diff: https://reviews.apache.org/r/44512/diff/
> 
> 
> Testing
> ---
> 
> make && make check.
> 
> $ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/tmp/mesos-master  
> --authenticate_http --credentials=/opt/credentials.json  >> 
> /tmp/mesos-master.log 2>&1 &)
> 
> $ curl --user framework1:secret_string1 http://localhost:5050/weights | 
> python -mjson.tool
> []
> 
> $ curl --user framework1:secret_string1 --data 
> "[{\"weight\":1.8,\"role\":\"role1\"},{\"weight\":1.0,\"role\":\"role2\"},{\"weight\":3.4,\"role\":\"role3\"}]"
>  -X PUT http://127.0.0.1:5050/weights
> 
> $ curl --user framework1:secret_string1 http://localhost:5050/weights | 
> python -mjson.tool
> [
> {
> "role": "role3",
> "weight": 3.4
> },
> {
> "role": "role2",
> "weight": 1.0
> },
> {
> "role": "role1",
> "weight": 1.8
> }
> ]
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 45983: Enabled the `network/cni` isolator in `MesosContainerizer`.

2016-04-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45983/#review128026
---



Patch looks great!

Reviews applied: [45953, 45954, 45955, 45956, 45983]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 10, 2016, 4:32 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45983/
> ---
> 
> (Updated April 10, 2016, 4:32 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5160
> https://issues.apache.org/jira/browse/MESOS-5160
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled the `network/cni` isolator in `MesosContainerizer`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5dd22380066aa85de04d485052084e2629681c0 
> 
> Diff: https://reviews.apache.org/r/45983/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> * Ran the Agent without the `network/cni` enabled in the `--isolation` flags. 
> Without the `--network_cni_plugins_dir` and the `--network_cni_config_dir`, 
> container using a docker image was launched on the host-network. With the 
> `--network_cni_plugins_dir` and the `--network_cni_config_dir` specified the 
> CNI network isolator correctly invoked the specified plugin to given the 
> container its own network namespace.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-10 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review128027
---




src/cli/execute.cpp (line 94)


You lost a period : )


- Alexander Rukletsov


On April 3, 2016, 1:42 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 3, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43472: Speed up ZooKeeperTest.LeaderContender by advance Clock.

2016-04-10 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43472/
---

(Updated April 10, 2016, 10:16 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update according to @alexr's comments.


Bugs: MESOS-4649
https://issues.apache.org/jira/browse/MESOS-4649


Repository: mesos


Description
---

Speed up ZooKeeperTest.LeaderContender by advance Clock.


Diffs (updated)
-

  src/tests/zookeeper_tests.cpp 6bde10b9ae9a644d3506abb285786200dc2fbe94 

Diff: https://reviews.apache.org/r/43472/diff/


Testing (updated)
---

Test repeatly in CentOS 7.1

```
 sudo ./bin/mesos-tests.sh --gtest_filter="ZooKeeperTest.LeaderContender" 
--verbose --gtest_repeat=200 --gtest_break_on_failure
```

Before

```
[   OK ] ZooKeeperTest.LeaderContender (3385 ms)
```

After

```
[   OK ] ZooKeeperTest.LeaderContender (694 ms)
```


Thanks,

haosdent huang

Re: Review Request 43473: Speed up ContenderDetectorShutdownNetwork by advance Clock.

2016-04-10 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43473/
---

(Updated April 10, 2016, 10:18 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update according to @alexr's comments.


Bugs: MESOS-4650
https://issues.apache.org/jira/browse/MESOS-4650


Repository: mesos


Description
---

Speed up ContenderDetectorShutdownNetwork by advance Clock.


Diffs (updated)
-

  src/tests/master_contender_detector_tests.cpp 
1426a173b1f458d67b748016aee311ac008b054a 

Diff: https://reviews.apache.org/r/43473/diff/


Testing (updated)
---

Test repeatly in CentOS 7.1

```
 sudo ./bin/mesos-tests.sh 
--gtest_filter="ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork
 " --verbose --gtest_repeat=200 --gtest_break_on_failure
```

Before

```
[   OK ] 
ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork (3390 ms)
```

After

```
[   OK ] 
ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork (546 ms)
```


Thanks,

haosdent huang

Re: Review Request 43474: Speed up MasterDetectorExpireSlaveZKSession by advance Clock.

2016-04-10 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43474/
---

(Updated April 10, 2016, 10:18 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update according to @alexr's comments.


Bugs: MESOS-4651
https://issues.apache.org/jira/browse/MESOS-4651


Repository: mesos


Description
---

Speed up MasterDetectorExpireSlaveZKSession by advance Clock.


Diffs (updated)
-

  src/tests/master_contender_detector_tests.cpp 
1426a173b1f458d67b748016aee311ac008b054a 

Diff: https://reviews.apache.org/r/43474/diff/


Testing (updated)
---

Test repeatly in CentOS 7.1

```
 sudo ./bin/mesos-tests.sh 
--gtest_filter="ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSession"
 --verbose --gtest_repeat=200 --gtest_break_on_failure
```

Before

```
[   OK ] 
ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSession (3358 
ms)
```

After 

```
[   OK ] 
ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSession (448 ms)
```


Thanks,

haosdent huang

Re: Review Request 43477: Speed up GroupTest.* test cases by advance clock.

2016-04-10 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43477/
---

(Updated April 10, 2016, 10:19 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update according to @alexr's comments.


Bugs: MESOS-4648
https://issues.apache.org/jira/browse/MESOS-4648


Repository: mesos


Description
---

Speed up GroupTest.* test cases by advance clock.


Diffs (updated)
-

  src/tests/group_tests.cpp ebf6963cd4d4dcf053a61495a33a74f22d95e7ec 

Diff: https://reviews.apache.org/r/43477/diff/


Testing (updated)
---

Test repeatly in CentOS 7.1

```
 sudo ./bin/mesos-tests.sh --gtest_filter="GroupTest.*" --verbose 
--gtest_repeat=200 --gtest_break_on_failure
```

Before

```
[   OK ] GroupTest.GroupJoinWithDisconnect (3352 ms)
[   OK ] GroupTest.GroupDataWithDisconnect (3350 ms)
[   OK ] GroupTest.GroupCancelWithDisconnect (2013 ms)
[   OK ] GroupTest.GroupPathWithRestrictivePerms (13368 ms)
[   OK ] GroupTest.RetryableErrors (26720 ms)
```

After 

```
[   OK ] GroupTest.GroupJoinWithDisconnect (405 ms)
[   OK ] GroupTest.GroupDataWithDisconnect (192 ms)
[   OK ] GroupTest.GroupCancelWithDisconnect (250 ms)
[   OK ] GroupTest.GroupPathWithRestrictivePerms (334 ms)
[   OK ] GroupTest.RetryableErrors (341 ms)
```


Thanks,

haosdent huang

Re: Review Request 43475: Speed up MasterDetectorExpireSlaveZKSessionNewMaster by advance Clock.

2016-04-10 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43475/
---

(Updated April 10, 2016, 10:18 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update according to @alexr's comments.


Bugs: MESOS-4652
https://issues.apache.org/jira/browse/MESOS-4652


Repository: mesos


Description
---

Speed up MasterDetectorExpireSlaveZKSessionNewMaster by advance Clock.


Diffs (updated)
-

  src/tests/master_contender_detector_tests.cpp 
1426a173b1f458d67b748016aee311ac008b054a 

Diff: https://reviews.apache.org/r/43475/diff/


Testing (updated)
---

Test repeatly in CentOS 7.1

```
 sudo ./bin/mesos-tests.sh 
--gtest_filter="ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster"
 --verbose --gtest_repeat=200 --gtest_break_on_failure
```

Before
```
[   OK ] 
ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster
 (3359 ms)
```

After

```
[   OK ] 
ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster
 (613 ms)
```


Thanks,

haosdent huang

Re: Review Request 43471: Add the zookeeper patch for the allow add_auth calls.

2016-04-10 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43471/
---

(Updated April 10, 2016, 10:24 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update description.


Bugs: MESOS-4648
https://issues.apache.org/jira/browse/MESOS-4648


Repository: mesos


Description (updated)
---

Currently zookeeper multi-threaded c client doesn't wake up the IO
thread after enqueue auth info message. So the auth info message isn't
flushed util poll timeout. We back port this patch from ZOOKEEPER-770
to wake up the IO thread in send_info_packet() just as send_ping()
does.


Diffs (updated)
-

  3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 
  3rdparty/zookeeper-3.4.8.patch 486df1ae96af3426835c9d47ff2e36dd47ccde3f 

Diff: https://reviews.apache.org/r/43471/diff/


Testing
---

Before

```
[   OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (10053 ms)
[   OK ] MasterZooKeeperTest.MasterInfoAddress (11282 ms)
[   OK ] ZooKeeperTest.Auth (6688 ms)
[   OK ] ZooKeeperTest.Create (6690 ms)
```

After

```
[   OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (321 ms)
[   OK ] MasterZooKeeperTest.MasterInfoAddress (447 ms)
[   OK ] ZooKeeperTest.Auth (233 ms)
[   OK ] ZooKeeperTest.Create (275 ms)
```


Thanks,

haosdent huang

Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

2016-04-10 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Fixed `rmdir.hpp` Windows build breaks.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
dd5cc6923ecc503d58e56128cf4ae736d8145fd7 
  3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp 
cc92953ccc53f37c54b87e738b16ea1fb521b987 

Diff: https://reviews.apache.org/r/45987/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 45985: Fixed the commit message hook to use `echo -n` instead.

2016-04-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45985/#review128028
---



Patch looks great!

Reviews applied: [45984, 45985]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 10, 2016, 6:43 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45985/
> ---
> 
> (Updated April 10, 2016, 6:43 a.m.)
> 
> 
> Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/hooks/commit-msg d3f10c886a654aa8d8364faddf2e50dc7fe82058 
> 
> Diff: https://reviews.apache.org/r/45985/diff/
> 
> 
> Testing
> ---
> 
> Manually tested to confirm that messages of 73 chars are rejected and 72 are 
> accepted.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 43471: Add the zookeeper patch for the allow add_auth calls.

2016-04-10 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43471/
---

(Updated April 10, 2016, 10:52 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update patches for zookeeper-06d3f3f.tar.gz


Bugs: MESOS-4648
https://issues.apache.org/jira/browse/MESOS-4648


Repository: mesos


Description (updated)
---

Add the zookeeper patch for the allow add_auth calls.


Diffs (updated)
-

  3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 
  3rdparty/zookeeper-3.4.8.patch 486df1ae96af3426835c9d47ff2e36dd47ccde3f 

Diff: https://reviews.apache.org/r/43471/diff/


Testing
---

Before

```
[   OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (10053 ms)
[   OK ] MasterZooKeeperTest.MasterInfoAddress (11282 ms)
[   OK ] ZooKeeperTest.Auth (6688 ms)
[   OK ] ZooKeeperTest.Create (6690 ms)
```

After

```
[   OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (321 ms)
[   OK ] MasterZooKeeperTest.MasterInfoAddress (447 ms)
[   OK ] ZooKeeperTest.Auth (233 ms)
[   OK ] ZooKeeperTest.Create (275 ms)
```


Thanks,

haosdent huang

Re: Review Request 43471: Add the zookeeper patch for the allow add_auth calls.

2016-04-10 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43471/
---

(Updated April 10, 2016, 10:53 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update description.


Bugs: MESOS-4648
https://issues.apache.org/jira/browse/MESOS-4648


Repository: mesos


Description (updated)
---

Currently zookeeper multi-threaded c client doesn't wake up the IO
thread after enqueue auth info message. So the auth info message isn't
flushed util poll timeout. We back port this patch from ZOOKEEPER-770
to wake up the IO thread in send_info_packet() just as send_ping()
does.


Diffs
-

  3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 
  3rdparty/zookeeper-3.4.8.patch 486df1ae96af3426835c9d47ff2e36dd47ccde3f 

Diff: https://reviews.apache.org/r/43471/diff/


Testing
---

Before

```
[   OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (10053 ms)
[   OK ] MasterZooKeeperTest.MasterInfoAddress (11282 ms)
[   OK ] ZooKeeperTest.Auth (6688 ms)
[   OK ] ZooKeeperTest.Create (6690 ms)
```

After

```
[   OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (321 ms)
[   OK ] MasterZooKeeperTest.MasterInfoAddress (447 ms)
[   OK ] ZooKeeperTest.Auth (233 ms)
[   OK ] ZooKeeperTest.Create (275 ms)
```


Thanks,

haosdent huang

Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

2016-04-10 Thread haosdent huang 


> On April 7, 2016, 2:13 a.m., haosdent huang wrote:
> > docs/attributes-resources.md, line 40
> > 
> >
> > `whole number values` means `natural number` here?
> 
> Kevin Klues wrote:
> Whole numbers are *almost* the same as natural numbers, with one 
> exception -- they include the number 0. We include 0, so whole nhmbers is the 
> right term here.

Thank you very much for your explanation. I always think natural number 
contains 0 before, did't realize there are two versions of natual number. 
https://en.wikipedia.org/wiki/Natural_number
>Some authors begin the natural numbers with 0, corresponding to the 
>non-negative integers 0, 1, 2, 3, …, 

Whole number is more exactly.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45855/#review127534
---


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45855/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5135
> https://issues.apache.org/jira/browse/MESOS-5135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to include references to GPUs as a first class resource.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 26468d962440560a6b4b35f51ca248ab059ec31f 
>   docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc 
> 
> Diff: https://reviews.apache.org/r/45855/diff/
> 
> 
> Testing
> ---
> 
> Looked at regenerated website and it seems to include the new documentation 
> properly.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/#review128031
---



Patch looks great!

Reviews applied: [45358]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 10, 2016, 8:09 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45358/
> ---
> 
> (Updated April 10, 2016, 8:09 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4944
> https://issues.apache.org/jira/browse/MESOS-4944
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved overlay backend to make the rootfs writable.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md db4b291498309d5c0bdbf38552b985c33f28e9a0 
>   src/slave/containerizer/mesos/provisioner/backend.hpp 
> c6cca81e287bb9a62e0390f96e1773841887a206 
>   src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
> 9eda944e14f2b05f28620c2e40594ed4e7bab69e 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> 9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
>   src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
> b62507f9fc757349d39f39a6654ddd69053bf0e7 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
> 85cc737438c88b355f37611bfde50dc80efab017 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 93892a75fe3ddd5c7b2a023b63f6d0fa83eeb97d 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 2ea38ac3342e1ebb712a7bea8ebef1bdcf96e809 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 07581f6ac714485e9c743984a553bb6fb26756b7 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 8a4938ebe4e00779e88e7c538445e9ffd51202e2 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> d49204f220c6212f83c2adf5544d04b3386c8eb7 
> 
> Diff: https://reviews.apache.org/r/45358/diff/
> 
> 
> Testing
> ---
> 
> - make check
> - tested manually, with slave using overlay backend. Create a task with mesos 
> containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
> /abc/def.txt`.
> - also tested manually with alpine image to verify overlay backend could 
> support 1-layer images.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43477: Speed up GroupTest.* test cases by advance clock.

2016-04-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43477/#review128032
---



Bad patch!

Reviews applied: [43477, 43475, 43474, 43473, 43472, 43471]

Failed command: ./support/apply-review.sh -n -r 43471

Error:
2016-04-10 12:31:44 URL:https://reviews.apache.org/r/43471/diff/raw/ 
[3615/3615] -> "43471.patch" [1]
43471.patch:23: trailing whitespace.
 
43471.patch:27: trailing whitespace.
 
43471.patch:62: trailing whitespace.
 
43471.patch:66: trailing whitespace.
 
43471.patch:76: trailing whitespace.
 /* We queued the buffer, so don't free it */   
warning: 5 lines add whitespace errors.
3rdparty/zookeeper-06d3f3f.patch:212: trailing whitespace.
+ 
3rdparty/zookeeper-06d3f3f.patch:216: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.8.patch:34: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.8.patch:38: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.8.patch:48: trailing whitespace.
+ /* We queued the buffer, so don't free it */   

Full log: https://builds.apache.org/job/mesos-reviewbot/12442/console

- Mesos ReviewBot


On April 10, 2016, 10:19 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43477/
> ---
> 
> (Updated April 10, 2016, 10:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4648
> https://issues.apache.org/jira/browse/MESOS-4648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up GroupTest.* test cases by advance clock.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp ebf6963cd4d4dcf053a61495a33a74f22d95e7ec 
> 
> Diff: https://reviews.apache.org/r/43477/diff/
> 
> 
> Testing
> ---
> 
> Test repeatly in CentOS 7.1
> 
> ```
>  sudo ./bin/mesos-tests.sh --gtest_filter="GroupTest.*" --verbose 
> --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> Before
> 
> ```
> [   OK ] GroupTest.GroupJoinWithDisconnect (3352 ms)
> [   OK ] GroupTest.GroupDataWithDisconnect (3350 ms)
> [   OK ] GroupTest.GroupCancelWithDisconnect (2013 ms)
> [   OK ] GroupTest.GroupPathWithRestrictivePerms (13368 ms)
> [   OK ] GroupTest.RetryableErrors (26720 ms)
> ```
> 
> After 
> 
> ```
> [   OK ] GroupTest.GroupJoinWithDisconnect (405 ms)
> [   OK ] GroupTest.GroupDataWithDisconnect (192 ms)
> [   OK ] GroupTest.GroupCancelWithDisconnect (250 ms)
> [   OK ] GroupTest.GroupPathWithRestrictivePerms (334 ms)
> [   OK ] GroupTest.RetryableErrors (341 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 45988: Fixed a typo in container-image.md.

2016-04-10 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45988/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Fixed a typo in container-image.md.


Diffs
-

  docs/container-image.md db4b291498309d5c0bdbf38552b985c33f28e9a0 

Diff: https://reviews.apache.org/r/45988/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-10 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/
---

(Updated 四月 10, 2016, 1:12 p.m.)


Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
and Jie Yu.


Bugs: MESOS-4882
https://issues.apache.org/jira/browse/MESOS-4882


Repository: mesos


Description
---

Treated command as executable value and arguments in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp 763dd26c359d1dd92c6e0365e4808b673efb1f40 

Diff: https://reviews.apache.org/r/1/diff/


Testing (updated)
---

1) with docker entry point
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell
I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos

2) With command 1
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="ls,/etc/passwd"
I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

3) With command 2
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

4) With command 3
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

5) 
root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="echo, hello,world"
I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0007
task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

>From sandbox stdout:
[echo, echo,  hello, world]
 hello world
 
6) root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="echo, hello world"
I0410 21:09:53.783275 10581 scheduler.cpp:175] Version: 0.29.0
Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0006
task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

>From sandbox stdout:
[echo, echo,  hello world]
 hello world


Thanks,

Guangya Liu

Re: Review Request 42342: Added a new test cases for revive offer.

2016-04-10 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/
---

(Updated 四月 10, 2016, 1:18 p.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.


Changes
---

Alex and Vinod, can you please help review? Thanks.


Bugs: MESOS-4387
https://issues.apache.org/jira/browse/MESOS-4387


Repository: mesos


Description
---

Added a new test cases for revive offer.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
a5dd57a4e0c244fb099433eb7b5777982698ebfd 

Diff: https://reviews.apache.org/r/42342/diff/


Testing
---

make
make check
GLOG_v=2 ./bin/mesos-tests.sh  
--gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose


Thanks,

Guangya Liu

Re: Review Request 43477: Speed up GroupTest.* test cases by advance clock.

2016-04-10 Thread haosdent huang 


> On April 10, 2016, 12:31 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [43477, 43475, 43474, 43473, 43472, 43471]
> > 
> > Failed command: ./support/apply-review.sh -n -r 43471
> > 
> > Error:
> > 2016-04-10 12:31:44 URL:https://reviews.apache.org/r/43471/diff/raw/ 
> > [3615/3615] -> "43471.patch" [1]
> > 43471.patch:23: trailing whitespace.
> >  
> > 43471.patch:27: trailing whitespace.
> >  
> > 43471.patch:62: trailing whitespace.
> >  
> > 43471.patch:66: trailing whitespace.
> >  
> > 43471.patch:76: trailing whitespace.
> >  /* We queued the buffer, so don't free it */   
> > warning: 5 lines add whitespace errors.
> > 3rdparty/zookeeper-06d3f3f.patch:212: trailing whitespace.
> > + 
> > 3rdparty/zookeeper-06d3f3f.patch:216: trailing whitespace.
> > + 
> > 3rdparty/zookeeper-3.4.8.patch:34: trailing whitespace.
> > + 
> > 3rdparty/zookeeper-3.4.8.patch:38: trailing whitespace.
> > + 
> > 3rdparty/zookeeper-3.4.8.patch:48: trailing whitespace.
> > + /* We queued the buffer, so don't free it */   
> > 
> > Full log: https://builds.apache.org/job/mesos-reviewbot/12442/console

Hmm, if remove these whitespace, the `zookeeper-3.4.8.patch` could not apply 
successfully.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43477/#review128032
---


On April 10, 2016, 10:19 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43477/
> ---
> 
> (Updated April 10, 2016, 10:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4648
> https://issues.apache.org/jira/browse/MESOS-4648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up GroupTest.* test cases by advance clock.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp ebf6963cd4d4dcf053a61495a33a74f22d95e7ec 
> 
> Diff: https://reviews.apache.org/r/43477/diff/
> 
> 
> Testing
> ---
> 
> Test repeatly in CentOS 7.1
> 
> ```
>  sudo ./bin/mesos-tests.sh --gtest_filter="GroupTest.*" --verbose 
> --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> Before
> 
> ```
> [   OK ] GroupTest.GroupJoinWithDisconnect (3352 ms)
> [   OK ] GroupTest.GroupDataWithDisconnect (3350 ms)
> [   OK ] GroupTest.GroupCancelWithDisconnect (2013 ms)
> [   OK ] GroupTest.GroupPathWithRestrictivePerms (13368 ms)
> [   OK ] GroupTest.RetryableErrors (26720 ms)
> ```
> 
> After 
> 
> ```
> [   OK ] GroupTest.GroupJoinWithDisconnect (405 ms)
> [   OK ] GroupTest.GroupDataWithDisconnect (192 ms)
> [   OK ] GroupTest.GroupCancelWithDisconnect (250 ms)
> [   OK ] GroupTest.GroupPathWithRestrictivePerms (334 ms)
> [   OK ] GroupTest.RetryableErrors (341 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-10 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/#review128033
---




docs/container-image.md (lines 290 - 291)


It is better update the document here to highlight that the overlay backend 
also support one layer image now.

The overlay backend allows containizer to utilize the filesystem to merge 
multiple filesystems into one efficiently. NOTE: The overlay backend support 
both one layer and multiple layer image.



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (lines 50 - 52)


4 spaces



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 297)


4 spaces



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 300)


4 spaces


- Guangya Liu


On 四月 10, 2016, 8:09 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45358/
> ---
> 
> (Updated 四月 10, 2016, 8:09 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4944
> https://issues.apache.org/jira/browse/MESOS-4944
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved overlay backend to make the rootfs writable.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md db4b291498309d5c0bdbf38552b985c33f28e9a0 
>   src/slave/containerizer/mesos/provisioner/backend.hpp 
> c6cca81e287bb9a62e0390f96e1773841887a206 
>   src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
> 9eda944e14f2b05f28620c2e40594ed4e7bab69e 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> 9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
>   src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
> b62507f9fc757349d39f39a6654ddd69053bf0e7 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
> 85cc737438c88b355f37611bfde50dc80efab017 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 93892a75fe3ddd5c7b2a023b63f6d0fa83eeb97d 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 2ea38ac3342e1ebb712a7bea8ebef1bdcf96e809 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 07581f6ac714485e9c743984a553bb6fb26756b7 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 8a4938ebe4e00779e88e7c538445e9ffd51202e2 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> d49204f220c6212f83c2adf5544d04b3386c8eb7 
> 
> Diff: https://reviews.apache.org/r/45358/diff/
> 
> 
> Testing
> ---
> 
> - make check
> - tested manually, with slave using overlay backend. Create a task with mesos 
> containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
> /abc/def.txt`.
> - also tested manually with alpine image to verify overlay backend could 
> support 1-layer images.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

2016-04-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/#review128036
---



Patch looks great!

Reviews applied: [45898, 44090, 45888, 45940, 44081, 44082, 44978, 44084, 
45009, 45015, 45022, 44142, 45987]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 10, 2016, 10:34 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45987/
> ---
> 
> (Updated April 10, 2016, 10:34 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed `rmdir.hpp` Windows build breaks.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> dd5cc6923ecc503d58e56128cf4ae736d8145fd7 
>   3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp 
> cc92953ccc53f37c54b87e738b16ea1fb521b987 
> 
> Diff: https://reviews.apache.org/r/45987/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45084: Add `Subsystem` abstraction for cgroups.

2016-04-10 Thread haosdent huang 


> On April 9, 2016, 12:11 a.m., Jie Yu wrote:
> > Does this patch compile on its own? I'd like each patch to be 'atomic' so 
> > that we can commit some of them if they look good.

Thanks for your review! Current patch chain are not atomic, let me change the 
dependencies.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45084/#review127895
---


On April 7, 2016, 10:36 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45084/
> ---
> 
> (Updated April 7, 2016, 10:36 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
> Kevin Klues.
> 
> 
> Bugs: MESOS-5039
> https://issues.apache.org/jira/browse/MESOS-5039
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add `Subsystem` abstraction for cgroups.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

2016-04-10 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/
---

(Updated April 10, 2016, 2:42 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Fix @lins05's comment.


Bugs: MESOS-5038
https://issues.apache.org/jira/browse/MESOS-5038


Repository: mesos


Description
---

Added ANY mode to futures collect mechanism.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
5a92b72eb7668494dc832ec446a41b3d673a20cc 
  3rdparty/libprocess/src/tests/collect_tests.cpp 
155e0bb75cf723a0a6c29020f9f767e3ba3d7401 

Diff: https://reviews.apache.org/r/45083/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

2016-04-10 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
---

(Updated April 10, 2016, 2:43 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, 
Jie Yu, and Kevin Klues.


Changes
---

Fix compile error in OS X and windows.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Enable cgroups unified isolator in isolation.


Diffs (updated)
-

  src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
  src/Makefile.am dc8f8e31c5ea229e20c4f7e4d15db1ae756938aa 
  src/slave/containerizer/mesos/containerizer.cpp 
c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 44893: Remove fetcher header file in containerizer.hpp.

2016-04-10 Thread haosdent huang 


> On April 8, 2016, 9:26 p.m., Jie Yu wrote:
> > Does mesos compile after applying this patch? If not, I would rather not 
> > split the patch. Yes, we prefer smaller patches, but each of them should be 
> > an atomic change, instead of just splitting a large patch into smaller 
> > pieces. There's no point of doing that.
> > 
> > Could you please merge those non-atomic changes into one patch? Otherwise, 
> > it's hard to reason what have you done.

Got it, let me make them atomic.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44893/#review127894
---


On April 3, 2016, 2:12 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44893/
> ---
> 
> (Updated April 3, 2016, 2:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till 
> Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-5086
> https://issues.apache.org/jira/browse/MESOS-5086
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove fetcher header file in containerizer.hpp.
> 
> 
> Diffs
> -
> 
>   src/local/local.cpp 06f6118a5038149f87e970b5cdf7987a270d3fae 
>   src/slave/containerizer/containerizer.hpp 
> ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
>   src/slave/containerizer/docker.hpp 89d450e10a84f24ddd46d517e2b4b46ab02c4fda 
>   src/slave/containerizer/mesos/containerizer.hpp 
> a6e3a8b43fb7591ff6f23b019a062696c8bfb719 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
> 
> Diff: https://reviews.apache.org/r/44893/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review128041
---



Patch looks great!

Reviews applied: [1]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 10, 2016, 1:12 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 10, 2016, 1:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 763dd26c359d1dd92c6e0365e4808b673efb1f40 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello,world"
> I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0007
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello, world]
>  hello world
>  
> 6) root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello world"
> I0410 21:09:53.783275 10581 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0006
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello world]
>  hello world
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-10 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/#review128043
---


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 135)


Instead of generating a uuid here, can you use 'basename(rootfs)' to infer 
the rootfsid?



src/slave/containerizer/mesos/provisioner/paths.hpp (lines 48 - 51)


Can you put this below all existing functions in this method?



src/slave/containerizer/mesos/provisioner/paths.cpp (lines 97 - 99)


Please use the indentation similar to the above function.

Also, ditto on the ordering.


- Jie Yu


On April 10, 2016, 8:09 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45358/
> ---
> 
> (Updated April 10, 2016, 8:09 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4944
> https://issues.apache.org/jira/browse/MESOS-4944
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved overlay backend to make the rootfs writable.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md db4b291498309d5c0bdbf38552b985c33f28e9a0 
>   src/slave/containerizer/mesos/provisioner/backend.hpp 
> c6cca81e287bb9a62e0390f96e1773841887a206 
>   src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
> 9eda944e14f2b05f28620c2e40594ed4e7bab69e 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> 9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
>   src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
> b62507f9fc757349d39f39a6654ddd69053bf0e7 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
> 85cc737438c88b355f37611bfde50dc80efab017 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 93892a75fe3ddd5c7b2a023b63f6d0fa83eeb97d 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 2ea38ac3342e1ebb712a7bea8ebef1bdcf96e809 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 07581f6ac714485e9c743984a553bb6fb26756b7 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 8a4938ebe4e00779e88e7c538445e9ffd51202e2 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> d49204f220c6212f83c2adf5544d04b3386c8eb7 
> 
> Diff: https://reviews.apache.org/r/45358/diff/
> 
> 
> Testing
> ---
> 
> - make check
> - tested manually, with slave using overlay backend. Create a task with mesos 
> containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
> /abc/def.txt`.
> - also tested manually with alpine image to verify overlay backend could 
> support 1-layer images.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42342: Added a new test cases for revive offer.

2016-04-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review128044
---



Patch looks great!

Reviews applied: [39628, 42342]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 10, 2016, 1:18 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> ---
> 
> (Updated April 10, 2016, 1:18 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new test cases for revive offer.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> a5dd57a4e0c244fb099433eb7b5777982698ebfd 
> 
> Diff: https://reviews.apache.org/r/42342/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh  
> --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 45991: Fixed a memory leak in Route::Route() in libprocess.

2016-04-10 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45991/
---

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-5144
https://issues.apache.org/jira/browse/MESOS-5144


Repository: mesos


Description
---

Fixed a memory leak in Route::Route() in libprocess.


Diffs
-

  3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 

Diff: https://reviews.apache.org/r/45991/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 45991: Fixed a memory leak in Route::Route() in libprocess.

2016-04-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45991/#review128050
---



Patch looks great!

Reviews applied: [45991]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 10, 2016, 8:49 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45991/
> ---
> 
> (Updated April 10, 2016, 8:49 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5144
> https://issues.apache.org/jira/browse/MESOS-5144
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a memory leak in Route::Route() in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
> 
> Diff: https://reviews.apache.org/r/45991/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 45900: Removed stale contender/detector files.

2016-04-10 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45900/
---

(Updated April 10, 2016, 8:50 p.m.)


Review request for mesos, Anurag Singh and James Peach.


Changes
---

rebased


Repository: mesos


Description
---

Also updated Makefile.am to move contender/detector module library
declarations into the existing list.


Diffs (updated)
-

  src/Makefile.am dc8f8e31c5ea229e20c4f7e4d15db1ae756938aa 
  src/master/contender/contender.hpp ba05551340f9ca1763f2f460121dc008f0262686 
  src/master/detector/detector.hpp 840026577d81d1b8cd3b079ff1e5b6809d139250 

Diff: https://reviews.apache.org/r/45900/diff/


Testing
---

make check.


Thanks,

Kapil Arya

Re: Review Request 45901: Removed unsed headers from master contender/detector files.

2016-04-10 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45901/
---

(Updated April 10, 2016, 8:50 p.m.)


Review request for mesos and Anurag Singh.


Changes
---

Fixed compilation error with java.


Repository: mesos


Description (updated)
---

Removed unsed headers from master contender/detector files.


Diffs (updated)
-

  src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 
  src/master/contender/standalone.hpp 511165c8b355ac9732c2e8921e12545c7c6217ed 
  src/master/contender/standalone.cpp 18959510338c0f2c5b2df254845c119902ff538f 
  src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 
  src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba 
  src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 
  src/master/detector/standalone.hpp a4007a4f342f177afd09939aac81f4caefadbbd5 
  src/master/detector/standalone.cpp 0b5de9e5bd575255dac6b18ad63a3eccea589fee 
  src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 
  src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 
  src/tests/master_contender_detector_tests.cpp 
1426a173b1f458d67b748016aee311ac008b054a 

Diff: https://reviews.apache.org/r/45901/diff/


Testing
---

make check.


Thanks,

Kapil Arya

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

2016-04-10 Thread Jian Qiu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 四月 11, 2016, 1:33 a.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description (updated)
---

Some tests are sped up by using clock,
while some relies on the fix of MESOS-4111 and a comment is put.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 45991: Fixed memory leak in Route::Route() in libprocess.

2016-04-10 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45991/
---

(Updated April 11, 2016, 1:38 a.m.)


Review request for mesos and Joris Van Remoortere.


Summary (updated)
-

Fixed memory leak in Route::Route() in libprocess.


Bugs: MESOS-5144
https://issues.apache.org/jira/browse/MESOS-5144


Repository: mesos


Description (updated)
---

Fixed memory leak in Route::Route() in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 

Diff: https://reviews.apache.org/r/45991/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

2016-04-10 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45995/
---

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-5144
https://issues.apache.org/jira/browse/MESOS-5144


Repository: mesos


Description
---

Fixed memory leak of `Route` in `finalize()` in libprocess.


Diffs
-

  3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 

Diff: https://reviews.apache.org/r/45995/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

2016-04-10 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45996/
---

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-5144
https://issues.apache.org/jira/browse/MESOS-5144


Repository: mesos


Description
---

Fixed memory leak of `gc` in `finalize()` in libprocess.


Diffs
-

  3rdparty/libprocess/include/process/gc.hpp 
799468ebe49f2a49d325f40ffd8acea727abf74c 
  3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 

Diff: https://reviews.apache.org/r/45996/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-10 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45863/#review128057
---


Fix it, then Ship it!





src/master/weights_handler.cpp (line 104)


Mesos operator can update weight for mutilple roles at one time, so it is 
better to show which role's weight is not positive to make this error message 
more clearly.


- Yongqiao Wang


On April 7, 2016, 10:50 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45863/
> ---
> 
> (Updated April 7, 2016, 10:50 a.m.)
> 
> 
> Review request for mesos, Yongqiao Wang and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While writing log or error messages we adhere the following style:
>   * No period at the end (there are exceptions though, e.g., one is
> when constructing request responses.
>   * When splitting a string over multiple lines, put a space at the
> beginning of the following line in contrast to the end of the
> previous line.
> 
> 
> Diffs
> -
> 
>   src/master/weights_handler.cpp e88bf2ab67ccadf35879b92f3280298a43d7cd0e 
> 
> Diff: https://reviews.apache.org/r/45863/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4: 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 45901: Removed unsed headers from master contender/detector files.

2016-04-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45901/#review128058
---



Patch looks great!

Reviews applied: [45900, 45901]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 11, 2016, 12:50 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45901/
> ---
> 
> (Updated April 11, 2016, 12:50 a.m.)
> 
> 
> Review request for mesos and Anurag Singh.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unsed headers from master contender/detector files.
> 
> 
> Diffs
> -
> 
>   src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 
>   src/master/contender/standalone.hpp 
> 511165c8b355ac9732c2e8921e12545c7c6217ed 
>   src/master/contender/standalone.cpp 
> 18959510338c0f2c5b2df254845c119902ff538f 
>   src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 
>   src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba 
>   src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 
>   src/master/detector/standalone.hpp a4007a4f342f177afd09939aac81f4caefadbbd5 
>   src/master/detector/standalone.cpp 0b5de9e5bd575255dac6b18ad63a3eccea589fee 
>   src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 
>   src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 
>   src/tests/master_contender_detector_tests.cpp 
> 1426a173b1f458d67b748016aee311ac008b054a 
> 
> Diff: https://reviews.apache.org/r/45901/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 45014: Add /containers endpoint.

2016-04-10 Thread Jay Guo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45014/
---

(Updated April 11, 2016, 2:27 a.m.)


Review request for mesos and Jie Yu.


Summary (updated)
-

Add /containers endpoint.


Repository: mesos


Description (updated)
---

It returns both resource statistics and container status.


Diffs (updated)
-

  docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 
  docs/endpoints/monitor/statistics.json.md 
1830493d9b936279abcfc03fc5023b7e8b54888b 
  docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
  docs/endpoints/slave/containers.md PRE-CREATION 
  src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059 
  src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e 
  src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
  src/tests/containerizer.hpp efc1ca87c00b04d70efd1e3f6acf4e763132d6b0 
  src/tests/containerizer.cpp 4c7f5a26d38222daf013bd3ca9a133e12d7bf338 
  src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5 

Diff: https://reviews.apache.org/r/45014/diff/


Testing
---

make check
`curl agent_ip:port/containers` returns same json content as `curl 
agent_ip:port/monitor/statistics.json`

This is a draft patch of adding /containers endpoint to agent 
[MESOS-4891](https://issues.apache.org/jira/browse/MESOS-4891)

ContainerStatus will be added to response based on this patch.


Thanks,

Jay Guo

Re: Review Request 45014: Add /containers endpoint.

2016-04-10 Thread Jay Guo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45014/
---

(Updated April 11, 2016, 2:32 a.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

It returns both resource statistics and container status.


Diffs
-

  docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 
  docs/endpoints/monitor/statistics.json.md 
1830493d9b936279abcfc03fc5023b7e8b54888b 
  docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
  docs/endpoints/slave/containers.md PRE-CREATION 
  src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059 
  src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e 
  src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
  src/tests/containerizer.hpp efc1ca87c00b04d70efd1e3f6acf4e763132d6b0 
  src/tests/containerizer.cpp 4c7f5a26d38222daf013bd3ca9a133e12d7bf338 
  src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5 

Diff: https://reviews.apache.org/r/45014/diff/


Testing (updated)
---

make check


Thanks,

Jay Guo

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

2016-04-10 Thread haosdent huang 


> On April 9, 2016, 1:02 a.m., Jie Yu wrote:
> > Intead of adding a new flag, I think we should just rely on `--isolation` 
> > flag. For instance, if the operator specify 
> > `--isolation=cgroups/cpu,cgroups/memory`, we will use the cgroup isolator 
> > with cgroups_subsystems: cpu and memory. I think this patch should be the 
> > last patch in the chain so that we can have more thorough testing before 
> > flipping the switch to use the unified cgroup isolator.

@jieyu. I have a question here. If we continue use `--isolation`, does this 
mean we drop supports to exist cgroups isolators(e.g. 
`CgroupsMemIsolatorProcess` and `CgroupsCpushareIsolatorProcess`).


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/#review127938
---


On April 7, 2016, 10:40 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45350/
> ---
> 
> (Updated April 7, 2016, 10:40 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, 
> Kevin Klues, and Neil Conway.
> 
> 
> Bugs: MESOS-5040
> https://issues.apache.org/jira/browse/MESOS-5040
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add `--cgroups_subsystems` in agent flags.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c 
>   src/slave/flags.hpp 4236b7fe40b9aa26d57b651be06a0e36037f65c6 
>   src/slave/flags.cpp 7164afef9c82a9bba0f137d7387c3569912b6599 
> 
> Diff: https://reviews.apache.org/r/45350/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45917: Disable http-parser strict mode to allow flexible http header fields.

2016-04-10 Thread Zhiwei Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45917/
---

(Updated April 11, 2016, 10:49 a.m.)


Review request for mesos, Greg Mann and Vinod Kone.


Bugs: MESOS-5063
https://issues.apache.org/jira/browse/MESOS-5063


Repository: mesos


Description
---

Disable http-parser strict mode to allow flexible http header fields.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
21fc067c0da03c60471953342d863c9ecd6e72c7 
  3rdparty/libprocess/3rdparty/Makefile.am 
217283cd3ce6df699b63dc5b8fb3aab0c6debd04 
  3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template 
056a1c1e9b3e31f2958be7779e87294cc5b43710 
  3rdparty/libprocess/src/decoder.hpp 51ef6bcf264de3af8b80003d249d55bdc6953b98 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
aa6021cadd4a1934afaf7f258ab8bcb83cafd6cb 

Diff: https://reviews.apache.org/r/45917/diff/


Testing
---

./configure --enable-ssl --enable-libevent
make distcheck


Thanks,

Zhiwei Chen

Re: Review Request 45917: Disable http-parser strict mode to allow flexible http header fields.

2016-04-10 Thread Zhiwei Chen 


> On April 9, 2016, 1:59 a.m., Vinod Kone wrote:
> > I think to test this you need to revert the changes made to SSL tests?
> > 
> > Also for CMake, you can add the -D flag by adding a "add_definitions(-D 
> > HTTP_PARSER_STRICT=0)" to 
> > 3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template. 
> > @AlexClemner is this the right way to add -D flag to http parser 
> > compilation?
> > 
> > Additionaly, while looking through the CMAKE files I realized that there 
> > are still references to the old http parser library:
> > 
> > ```
> > ?  mesos git:(vinod/release_support_doc) ack RY_UPDATE 3rdparty
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt
> > 117:set(RY_UPDATE_CMD ${CMAKE_COMMAND} -E copy 
> > ${PROCESS_3RD_SRC}/http-parser/CMakeLists.txt.template 
> > ${HTTP_PARSER_ROOT}/CMakeLists.txt)
> > 174:  UPDATE_COMMAND${RY_UPDATE_CMD}
> > 
> > 
> > ?  mesos git:(vinod/release_support_doc) ack Ryan 3rdparty
> > 3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template
> > 17:# Builds Ryan Dahl's http-parser project.
> > 
> > 3rdparty/libprocess/3rdparty/Makefile.am
> > 86:  # Convenience library for Ryan Dahl's HTTP parser.
> > 
> > ```
> > 
> > Can you make sure to clean these up as well?

Thanks, I updated these stuff, but do not sure it's ok for cmake, since I can't 
build Mesos with cmake even on master branch.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45917/#review127819
---


On April 11, 2016, 10:49 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45917/
> ---
> 
> (Updated April 11, 2016, 10:49 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Bugs: MESOS-5063
> https://issues.apache.org/jira/browse/MESOS-5063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disable http-parser strict mode to allow flexible http header fields.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 21fc067c0da03c60471953342d863c9ecd6e72c7 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 217283cd3ce6df699b63dc5b8fb3aab0c6debd04 
>   3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template 
> 056a1c1e9b3e31f2958be7779e87294cc5b43710 
>   3rdparty/libprocess/src/decoder.hpp 
> 51ef6bcf264de3af8b80003d249d55bdc6953b98 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> aa6021cadd4a1934afaf7f258ab8bcb83cafd6cb 
> 
> Diff: https://reviews.apache.org/r/45917/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent
> make distcheck
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

2016-04-10 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45999/
---

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-5144
https://issues.apache.org/jira/browse/MESOS-5144


Repository: mesos


Description
---

Without this change, `finalize()` terminates processes in the order
that they happen to be found when iterating over the `processes`
map. That means that if the GarbageCollector process is terminated
while any GC-managed processes are still running, those processes
will not be GC'd (i.e., they will be leaked).

Fix this by skipping the garbage collector process when iterating
over `processes` in `finalize()`, and then only terminating it after
all other processes have been terminated.


Diffs
-

  3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 

Diff: https://reviews.apache.org/r/45999/diff/


Testing
---

make check

Confirmed reduction of leaked memory via ASAN on Linux/amd64.


Thanks,

Neil Conway

Re: Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

2016-04-10 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45999/#review128061
---




3rdparty/libprocess/src/process.cpp (lines 2167 - 2188)


Is there a reason, we can't just remove the gc process from the list as a 
preliminary step, and then leave the rest of the logic as is? Followed by the 
explicit gc terminate/delete?


- Kevin Klues


On April 11, 2016, 3:48 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45999/
> ---
> 
> (Updated April 11, 2016, 3:48 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5144
> https://issues.apache.org/jira/browse/MESOS-5144
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Without this change, `finalize()` terminates processes in the order
> that they happen to be found when iterating over the `processes`
> map. That means that if the GarbageCollector process is terminated
> while any GC-managed processes are still running, those processes
> will not be GC'd (i.e., they will be leaked).
> 
> Fix this by skipping the garbage collector process when iterating
> over `processes` in `finalize()`, and then only terminating it after
> all other processes have been terminated.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
> 
> Diff: https://reviews.apache.org/r/45999/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Confirmed reduction of leaked memory via ASAN on Linux/amd64.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

2016-04-10 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44123/
---

(Updated April 11, 2016, 4:20 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout: [1/2] Implemented assorted `os::` functions on Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
edaa76a5322d0bf60b7172405aa754b5aca95458 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
c48106e5905e3be0faeba7177ef534766089faff 

Diff: https://reviews.apache.org/r/44123/diff/


Testing (updated)
---

OSX: make check


Thanks,

Daniel Pravat

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

2016-04-10 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/
---

(Updated April 11, 2016, 4:21 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Libprocess: [2/2] Implemented assorted `os::` functions on Windows.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97 

Diff: https://reviews.apache.org/r/44131/diff/


Testing (updated)
---

OSX: make check


Thanks,

Daniel Pravat

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

2016-04-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/#review128065
---



Patch looks great!

Reviews applied: [41787]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 11, 2016, 1:33 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41787/
> ---
> 
> (Updated April 11, 2016, 1:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4158
> https://issues.apache.org/jira/browse/MESOS-4158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some tests are sped up by using clock,
> while some relies on the fix of MESOS-4111 and a comment is put.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 
> 
> Diff: https://reviews.apache.org/r/41787/diff/
> 
> 
> Testing
> ---
> 
> SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
> SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
> SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
> SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
> SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 45949: Implemented docker config get credential helper.

2016-04-10 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45949/#review128039
---




include/mesos/docker/spec.hpp (lines 77 - 79)


Result getCredential(
const JSON::Object& config,
const std::string& registry);



src/docker/spec.cpp (line 153)


const JSON::Object& config



src/docker/spec.cpp (lines 163 - 164)


one line?



src/docker/spec.cpp (lines 172 - 175)


I did not found any link which telling me that "many registry domain 
recorded in docker config file does not start with 'https://' or 'http://'", 
can you please put a link here as reference?


- Guangya Liu


On 四月 8, 2016, 9:49 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45949/
> ---
> 
> (Updated 四月 8, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4938
> https://issues.apache.org/jira/browse/MESOS-4938
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented docker config get credential helper.
> 
> 
> Diffs
> -
> 
>   include/mesos/docker/spec.hpp 2ebacc70d92a593c8dd006b34519c3a2a5225481 
>   src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d 
> 
> Diff: https://reviews.apache.org/r/45949/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45950: Added test for docker spec get credential helper.

2016-04-10 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45950/#review128042
---




src/tests/containerizer/docker_spec_tests.cpp (lines 196 - 197)


Merge those two lines to the following?

EXPECT_SOME_EQ("bWVzb3M6dGVzdA==", auth);

Ditto for the following



src/tests/containerizer/docker_spec_tests.cpp (lines 196 - 197)


EXPECT_SOME_EQ("bWVzb3M6dGVzdA==", auth);

Ditto for the following


- Guangya Liu


On 四月 8, 2016, 9:49 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45950/
> ---
> 
> (Updated 四月 8, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4938
> https://issues.apache.org/jira/browse/MESOS-4938
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for docker spec get credential helper.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_spec_tests.cpp 
> 796b020f58f8451362bc1357ab6d7ceb4e946b3c 
> 
> Diff: https://reviews.apache.org/r/45950/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45014: Add /containers endpoint.

2016-04-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45014/#review128070
---



Patch looks great!

Reviews applied: [45014]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 11, 2016, 2:32 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45014/
> ---
> 
> (Updated April 11, 2016, 2:32 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It returns both resource statistics and container status.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 
>   docs/endpoints/monitor/statistics.json.md 
> 1830493d9b936279abcfc03fc5023b7e8b54888b 
>   docs/endpoints/monitor/statistics.md 
> 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
>   docs/endpoints/slave/containers.md PRE-CREATION 
>   src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059 
>   src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
>   src/tests/containerizer.hpp efc1ca87c00b04d70efd1e3f6acf4e763132d6b0 
>   src/tests/containerizer.cpp 4c7f5a26d38222daf013bd3ca9a133e12d7bf338 
>   src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5 
> 
> Diff: https://reviews.apache.org/r/45014/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 45200: Duplicate flags with keyword 'slave'.

2016-04-10 Thread Jay Guo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/
---

(Updated April 11, 2016, 6:45 a.m.)


Review request for mesos and Vinod Kone.


Summary (updated)
-

Duplicate flags with keyword 'slave'.


Repository: mesos


Description (updated)
---

It duplicates master/slave flags that contain 'slave'. This is
part of the epic replacing all keyword 'slave' with 'agent' in
current codebase.


Diffs (updated)
-

  CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3 
  src/Makefile.am dc8f8e31c5ea229e20c4f7e4d15db1ae756938aa 
  src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842 
  src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c 
  src/slave/flags.hpp 300db49100d989d6c0409766b1341cb956ea1631 
  src/slave/flags.cpp dd7bc9a48dfd8481336a2d2ec0beecd19a342644 
  src/tests/flags_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45200/diff/


Testing (updated)
---

./configure --with-network-isolator
make check (on OSX and Ubuntu)


Thanks,

Jay Guo

Re: Review Request 45200: Duplicate flags with keyword 'slave'.

2016-04-10 Thread Jay Guo 


> On April 1, 2016, 10:49 p.m., Vinod Kone wrote:
> > Can you call this out in the CHANGELOG too please?
> > 
> > Also, all of the old flags should print a deprecation warning (when a user 
> > does --help on the binary or starts the binary with a deprecated flag) and 
> > direct users to the new flags. Can you make that change?
> 
> Jay Guo wrote:
> Sure, will do.
> 
> Vinod Kone wrote:
> Any update on this?
> 
> Also the description should be more meaningful than the bug id. Move the 
> bug id to "bugs" field.

CHANGELOG is updated. Deprecation warning is placed in --help, under those 
flags with 'slave'. Also when user starts the binary with deprecated flags, 
LOG(WARNING) reflects the deprecation as well. Please take a look! Thanks!


- Jay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/#review126661
---


On April 11, 2016, 6:45 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45200/
> ---
> 
> (Updated April 11, 2016, 6:45 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It duplicates master/slave flags that contain 'slave'. This is
> part of the epic replacing all keyword 'slave' with 'agent' in
> current codebase.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3 
>   src/Makefile.am dc8f8e31c5ea229e20c4f7e4d15db1ae756938aa 
>   src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842 
>   src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c 
>   src/slave/flags.hpp 300db49100d989d6c0409766b1341cb956ea1631 
>   src/slave/flags.cpp dd7bc9a48dfd8481336a2d2ec0beecd19a342644 
>   src/tests/flags_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45200/diff/
> 
> 
> Testing
> ---
> 
> ./configure --with-network-isolator
> make check (on OSX and Ubuntu)
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 44379: Use tokens size to parse perf stat format.

2016-04-10 Thread fan du 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44379/
---

(Updated 四月 11, 2016, 6:57 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Use tokens size to parse perf stat format.


Summary (updated)
-

Use tokens size to parse perf stat format.


Bugs: MESOS-4705
https://issues.apache.org/jira/browse/MESOS-4705


Repository: mesos


Description (updated)
---

Use tokens size to parse perf stat format.


Diffs (updated)
-

  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 

Diff: https://reviews.apache.org/r/44379/diff/


Testing
---

1. {Found and Test} with Serenity, ema filter could get perf event statistics 
correctly as expected.
2. ./bin/mesos-tests.sh --gtest_filter=PerfEventIsolatorTest* 
--log_dir=/tmp/mesos/


Thanks,

fan du