Re: Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57106/#review167655
---


Ship it!




Ship It!

- Jay Guo


On Feb. 28, 2017, 6:11 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57106/
> ---
> 
> (Updated Feb. 28, 2017, 6:11 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6627
> https://issues.apache.org/jira/browse/MESOS-6627
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Taken verbatim from the [design 
> doc](https://docs.google.com/document/d/1n0ZtRL49m3qpAeB4beEEhjTXQS-nYAbgRG9g44fn4WY).
> 
> 
> Diffs
> -
> 
>   src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698 
> 
> 
> Diff: https://reviews.apache.org/r/57106/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 57193: Updated WebUI to display role information under tab 'Agents'.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57193/
---

(Updated March 2, 2017, 11:34 a.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-6657
https://issues.apache.org/jira/browse/MESOS-6657


Repository: mesos


Description
---

Updated WebUI to display role information under tab 'Agents'.


Diffs (updated)
-

  src/webui/master/static/agent.html 416e6c2c7e52937e02f8a4237852b84116f2526a 
  src/webui/master/static/agent_executor.html 
95e921d1c3ca0f005e3eb3f79eb0d9a70a3b3f91 
  src/webui/master/static/agent_framework.html 
806ab06063dcf62cd6d1d7913840ed83141bd1eb 
  src/webui/master/static/js/controllers.js 
2ea8275cb5fffa2344474ebfcf9277fe92165a92 


Diff: https://reviews.apache.org/r/57193/diff/2/

Changes: https://reviews.apache.org/r/57193/diff/1-2/


Testing
---


File Attachments


Page Agents/Frameworks
  
https://reviews.apache.org/media/uploaded/files/2017/03/01/8e943f7b-bcc0-43ac-9539-eeefd6f49359__Screen_Shot_2017-03-01_at_18.26.07.png
Page Agents/Frameworks/Executors
  
https://reviews.apache.org/media/uploaded/files/2017/03/01/8eac0e06-6663-4662-85ef-f4755dc1b1cb__Screen_Shot_2017-03-01_at_18.26.48.png
Page Agents/Frameworks/Executors/Tasks
  
https://reviews.apache.org/media/uploaded/files/2017/03/01/c66210d4-1826-49c5-93d8-4bd224112ff8__Screen_Shot_2017-03-01_at_18.27.20.png


Thanks,

Jay Guo

Re: Review Request 57192: Updated WebUI to display role information under tab 'Frameworks'.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57192/
---

(Updated March 2, 2017, 11:34 a.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-6657
https://issues.apache.org/jira/browse/MESOS-6657


Repository: mesos


Description
---

Updated WebUI to display role information under tab 'Frameworks'.


Diffs (updated)
-

  src/webui/master/static/framework.html 
37e0b31ac90e877b70f315143b7411fadec6 
  src/webui/master/static/frameworks.html 
0c6fc1c37e0ab49fed64aaa861dfcbaab7f38e0e 
  src/webui/master/static/js/controllers.js 
2ea8275cb5fffa2344474ebfcf9277fe92165a92 


Diff: https://reviews.apache.org/r/57192/diff/2/

Changes: https://reviews.apache.org/r/57192/diff/1-2/


Testing
---


File Attachments


Tab Framework
  
https://reviews.apache.org/media/uploaded/files/2017/03/01/d8b4d962-7e0e-41d0-976c-2fbffb0dc3ad__Screen_Shot_2017-03-01_at_18.24.03.png
Page Frameworks/Tasks
  
https://reviews.apache.org/media/uploaded/files/2017/03/01/e1a2340d-2817-4451-b70d-29b6e125c5a3__Screen_Shot_2017-03-01_at_18.28.17.png


Thanks,

Jay Guo

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53369/#review167640
---



Patch looks great!

Reviews applied: [53369]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 2, 2017, 1:57 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53369/
> ---
> 
> (Updated March 2, 2017, 1:57 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6523
> https://issues.apache.org/jira/browse/MESOS-6523
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is to ensure that we do not accept traffic on the agent by opening
> up libprocess port only after cgroup assigment for the agent is done.
> 
> 
> Diffs
> -
> 
>   src/slave/main.cpp a124d2e0cfa3e39e2400183f9523486196b9816d 
>   src/slave/slave.cpp 892ce1938ac695e7913aa9139536d0787f3f5ea7 
> 
> 
> Diff: https://reviews.apache.org/r/53369/diff/3/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 57195: Updated WebUI to display role information of tasks in homepage.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57195/#review167637
---


Ship it!




Ship It!

- Benjamin Mahler


On March 1, 2017, 10:24 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57195/
> ---
> 
> (Updated March 1, 2017, 10:24 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6657
> https://issues.apache.org/jira/browse/MESOS-6657
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated WebUI to display role information of tasks in homepage.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/home.html 07bc84877a600629cc1818849783cc4b0ea912d8 
> 
> 
> Diff: https://reviews.apache.org/r/57195/diff/1/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> homepage
>   
> https://reviews.apache.org/media/uploaded/files/2017/03/01/b3c5e352-6581-4950-93a3-9a6f6769b035__Screen_Shot_2017-03-01_at_18.22.13.png
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 57166: Updated role validation for hierarchical roles.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57166/#review167623
---




src/common/roles.cpp
Line 71 (original), 71 (patched)


Why can't role start with a slash? According to the design doc, it seems 
the role like `/eng/frontend` is valid.



src/common/roles.cpp
Lines 83 (patched)


Kill this blank line.



src/common/roles.cpp
Line 82 (original), 95 (patched)


s/Roles/Role/


- Qian Zhang


On March 1, 2017, 4:23 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57166/
> ---
> 
> (Updated March 1, 2017, 4:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Role names can now contain forward slashes. Each component in a role
> name must now be validated separately.
> 
> 
> Diffs
> -
> 
>   src/common/roles.cpp 31774a9b8f99f5efeed35b1c3e3486e05ca00f6a 
>   src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 
> 
> 
> Diff: https://reviews.apache.org/r/57166/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 55790: Support the full CNI DNS specification.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55790/#review167620
---



Patch looks great!

Reviews applied: [55790]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 1, 2017, 4:51 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55790/
> ---
> 
> (Updated March 1, 2017, 4:51 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6858
> https://issues.apache.org/jira/browse/MESOS-6858
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add support for the full set of DNS resolver configuration items that
> a CNI IPAM plugin can specify. This implements updating the container's
> resolv.conf with the 'domain', 'search', and 'options' keywords.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 84dc157e7d9e332a6da0f1fc33303e9ef9bdc147 
>   src/slave/containerizer/mesos/isolators/network/cni/spec.hpp 
> ccd511ec14810dcc1020dec5e1641141f3a319b4 
>   src/slave/containerizer/mesos/isolators/network/cni/spec.cpp 
> ac48159dadcea422f605e723db94a7f3bb573fa2 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> cb893d3ef005a9cc60c40768fa669b27c4863020 
> 
> 
> Diff: https://reviews.apache.org/r/55790/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`.

[Michael Park]

> On Feb. 27, 2017, 6:42 p.m., Benjamin Mahler wrote:
> > src/messages/messages.proto
> > Lines 574-575 (patched)
> > 
> >
> > Just one thing, looking at the subsequent patch, it appears that the 
> > agent updates the entire framework info, not just capabilities. So let's 
> > remove this TODO? Is there anything you want to call out here that won't be 
> > updated correctly by the agent if it were to change?

Oh, you're right. No, I don't think I have anything to call out here.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57106/#review166992
---


On Feb. 27, 2017, 2:11 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57106/
> ---
> 
> (Updated Feb. 27, 2017, 2:11 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6627
> https://issues.apache.org/jira/browse/MESOS-6627
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Taken verbatim from the [design 
> doc](https://docs.google.com/document/d/1n0ZtRL49m3qpAeB4beEEhjTXQS-nYAbgRG9g44fn4WY).
> 
> 
> Diffs
> -
> 
>   src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698 
> 
> 
> Diff: https://reviews.apache.org/r/57106/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review167592
---



Patch looks great!

Reviews applied: [55887, 55888]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 1, 2017, 4:15 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> ---
> 
> (Updated March 1, 2017, 4:15 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Test to ensure non-authorized users cannot launch tasks on agents.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_authorization_tests.cpp 
> 61c44460eb79931dd77c5100eb33a31a182c1710 
> 
> 
> Diff: https://reviews.apache.org/r/55888/diff/6/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 57052: CMake: Add `build_config.hpp.in` for `BUILD_TIME` variables.

[Andrew Schwartzmeyer]

> On March 1, 2017, 2:13 a.m., Joseph Wu wrote:
> > cmake/CompilationConfigure.cmake
> > Line 291 (original), 291 (patched)
> > 
> >
> > Not yours, but looks like this one actually doesn't work on Posix.
> > 
> > It ends up as:
> > ```
> > #define BUILD_TIME "%s"
> > ```
> > 
> > I'll fix it while I'm modifying this part of the build system:
> > ```
> >   execute_process(
> > COMMAND date +%s
> > OUTPUT_VARIABLE BUILD_TIME
> > OUTPUT_STRIP_TRAILING_WHITESPACE
> >   )
> > ```
> 
> Andrew Schwartzmeyer wrote:
> I believe this is a CMake versioning issue. I had to explicitly call 
> `cmake3` for this to work (but AFAIK we don't "officially" support 2.x, I say 
> that because we already make use of a lot of 3.x features).

Yup 2.8.10's `string` command [does not support `TIMESTAMP`] 
(https://cmake.org/cmake/help/v2.8.10/cmake.html#command:string). I'll get an 
issue filed; but we need to move the non-Windows minimum required version up to 
CMake 3.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57052/#review167198
---


On March 1, 2017, 10:18 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57052/
> ---
> 
> (Updated March 1, 2017, 10:18 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7172
> https://issues.apache.org/jira/browse/MESOS-7172
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Commit c7fc1377b introduced a bug that prevented any incremental
> recompilation. By defining the `BUILD_TIME` in `MESOS_CPPFLAGS`,
> every build was seen as having a root dependency (the flags)
> changed, causing a rebuild of every single source in Mesos.
> 
> This patch introduces a CMake `configure_file` directive which
> takes in `build_config.hpp.in` and emits `build_config.hpp` with the
> `BUILD_TIME`, `BUILD_DATE`, and `BUILD_USER` variables defined.
> It also sets `USE_CMAKE_BUILD_CONFIG` which `build.cpp` uses to `#include`
> the configuration file. The result is that the date, time, and user
> are set at the point of configuration (invocation of CMake) instead
> of at build, thus allowing for incremental rebuilds.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 7808d1a0086a791af8dcb2dd796b9424c7d5 
>   src/common/build.cpp 090b59fb22bfc00516d65f501f8f18cd85a5b4cd 
>   src/common/build_config.hpp.in PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57052/diff/3/
> 
> 
> Testing
> ---
> 
> cmake; make && make check on Linux
> cmake; VS build stout-tests and mesos-tests, then repeat and see no 
> compilation take place a second time. Also support\windows-build.bat twice.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 57052: CMake: Add `build_config.hpp.in` for `BUILD_TIME` variables.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57052/
---

(Updated March 1, 2017, 10:18 p.m.)


Review request for mesos, Alex Clemmer, Joseph Wu, and Michael Park.


Changes
---

Update per Joe's comments; also add license and header guard to 
`build_config.hpp`.


Bugs: MESOS-7172
https://issues.apache.org/jira/browse/MESOS-7172


Repository: mesos


Description (updated)
---

Commit c7fc1377b introduced a bug that prevented any incremental
recompilation. By defining the `BUILD_TIME` in `MESOS_CPPFLAGS`,
every build was seen as having a root dependency (the flags)
changed, causing a rebuild of every single source in Mesos.

This patch introduces a CMake `configure_file` directive which
takes in `build_config.hpp.in` and emits `build_config.hpp` with the
`BUILD_TIME`, `BUILD_DATE`, and `BUILD_USER` variables defined.
It also sets `USE_CMAKE_BUILD_CONFIG` which `build.cpp` uses to `#include`
the configuration file. The result is that the date, time, and user
are set at the point of configuration (invocation of CMake) instead
of at build, thus allowing for incremental rebuilds.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake 7808d1a0086a791af8dcb2dd796b9424c7d5 
  src/common/build.cpp 090b59fb22bfc00516d65f501f8f18cd85a5b4cd 
  src/common/build_config.hpp.in PRE-CREATION 


Diff: https://reviews.apache.org/r/57052/diff/3/

Changes: https://reviews.apache.org/r/57052/diff/2-3/


Testing
---

cmake; make && make check on Linux
cmake; VS build stout-tests and mesos-tests, then repeat and see no compilation 
take place a second time. Also support\windows-build.bat twice.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 57194: Updated WebUI to display role information under tab 'Offers'.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57194/#review167583
---


Fix it, then Ship it!





src/webui/master/static/offers.html
Lines 17 (patched)


I would suggest moving this up to be in front of the framework ID since 
allocations are made primarily to roles.

Also, I think you need a s/role/allocation_info.role/ here for the sorting 
to work correctly, did you test the sorting?


- Benjamin Mahler


On March 1, 2017, 10:33 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57194/
> ---
> 
> (Updated March 1, 2017, 10:33 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6657
> https://issues.apache.org/jira/browse/MESOS-6657
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated WebUI to display role information under tab 'Offers'.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/offers.html 
> 181fc2deabef3faec36785e7fcdbc37465668bec 
> 
> 
> Diff: https://reviews.apache.org/r/57194/diff/1/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Page Offers
>   
> https://reviews.apache.org/media/uploaded/files/2017/03/01/4ffb17d5-12f0-4b5b-abab-f5b8133f53ca__Screen_Shot_2017-03-01_at_18.32.20.png
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 57013: Expose offer allocation info within the master /state endpoint.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57013/#review167578
---


Ship it!




Ship It!

- Michael Park


On Feb. 23, 2017, 5:27 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57013/
> ---
> 
> (Updated Feb. 23, 2017, 5:27 p.m.)
> 
> 
> Review request for mesos, Jay Guo and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Expose offer allocation info within the master /state endpoint.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 6e5178eeea6cc6b90ae253840da22be13444b088 
>   src/tests/master_tests.cpp 357a9a47ef87be6cbc4256d8afabe63cd41b1ea1 
> 
> 
> Diff: https://reviews.apache.org/r/57013/diff/1/
> 
> 
> Testing
> ---
> 
> Updated an existing test.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 57191: Fixed flakiness in three MULTI_ROLE related tests.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57191/#review167576
---


Ship it!




Ship It!

- Benjamin Mahler


On March 1, 2017, 5:22 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57191/
> ---
> 
> (Updated March 1, 2017, 5:22 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Neil Conway.
> 
> 
> Bugs: MESOS-7182
> https://issues.apache.org/jira/browse/MESOS-7182
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed flakiness in following tests:
> 
> MasterTest.MultiRoleSchedulerUpgrade
> UpgradeTest.ReregisterOldAgentWithMultiRoleMaster
> MasterTest.MultiRoleFrameworkReceivesOffers
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 357a9a47ef87be6cbc4256d8afabe63cd41b1ea1 
>   src/tests/upgrade_tests.cpp 99f56a0f94a762f54383723162bb29e7baa03be8 
> 
> 
> Diff: https://reviews.apache.org/r/57191/diff/2/
> 
> 
> Testing
> ---
> 
> repeatedly run these three tests for faily long time and see no failure.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 57052: CMake: Add `build_config.hpp.in` for `BUILD_TIME` variables.

[Andrew Schwartzmeyer]

> On March 1, 2017, 2:13 a.m., Joseph Wu wrote:
> > cmake/CompilationConfigure.cmake
> > Line 291 (original), 291 (patched)
> > 
> >
> > Not yours, but looks like this one actually doesn't work on Posix.
> > 
> > It ends up as:
> > ```
> > #define BUILD_TIME "%s"
> > ```
> > 
> > I'll fix it while I'm modifying this part of the build system:
> > ```
> >   execute_process(
> > COMMAND date +%s
> > OUTPUT_VARIABLE BUILD_TIME
> > OUTPUT_STRIP_TRAILING_WHITESPACE
> >   )
> > ```

I believe this is a CMake versioning issue. I had to explicitly call `cmake3` 
for this to work (but AFAIK we don't "officially" support 2.x, I say that 
because we already make use of a lot of 3.x features).


> On March 1, 2017, 2:13 a.m., Joseph Wu wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 297 (patched)
> > 
> >
> > Would be better with a comment :D
> > ```
> > # Emit the BUILD_DATE, BUILD_TIME, and BUILD_USER variables into a file.
> > # This will be updated each time `cmake` is run.
> > ```

Oh, yes it would :D


> On March 1, 2017, 2:13 a.m., Joseph Wu wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 299 (patched)
> > 
> >
> > Just for symmetry, let's put this in
> > 
> > "${CMAKE_BINARY_DIR}/src/common/build_config.hpp"

I'm fine with that if you were. I went with include/mesos as that's the only 
currently generated folder inside build/include. Definitely prefer 
include/common.


> On March 1, 2017, 2:13 a.m., Joseph Wu wrote:
> > cmake/CompilationConfigure.cmake
> > Line 308 (original), 312 (patched)
> > 
> >
> > What do you feel about "USE_CMAKE_BUILD_CONFIG" instead?  
> > "HAVE_BUILD_CONFIG_H" seems too much like a header guard.

No preference. `HAVE_CONFIG_H` is very common (the `HAVE_FEATURE` is itself a 
common pattern), but I don't care one way or another.


> On March 1, 2017, 2:13 a.m., Joseph Wu wrote:
> > src/common/build.cpp
> > Lines 26 (patched)
> > 
> >
> > Would help to have a nice beefy comment :)
> > ```
> > // NOTE: On CMake, instead of defining `BUILD_DATE|TIME|USER` as
> > // compiler flags, we instead emit a header file with the definitions.
> > // This facilitates incremental builds as the compiler flags will
> > // no longer change with every invocation of the build.
> > // TODO(josephw): After deprecating autotools, remove this guard.
> > ```

I knew there was something I was forgetting.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57052/#review167198
---


On March 1, 2017, 12:42 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57052/
> ---
> 
> (Updated March 1, 2017, 12:42 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7172
> https://issues.apache.org/jira/browse/MESOS-7172
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Commit c7fc1377b introduced a bug that prevented any incremental
> recompilation. By defining the `BUILD_TIME` in `MESOS_CPPFLAGS`,
> every build was seen as having a root dependency (the flags)
> changed, causing a rebuild of every single source in Mesos.
> 
> This patch introduces a CMake `configure_file` directive which
> takes in `build_config.hpp.in` and emits `build_config.hpp` with the
> `BUILD_TIME`, `BUILD_DATE`, and `BUILD_USER` variables defined.
> It also sets `HAVE_BUILD_CONFIG_H` which `build.cpp` uses to `#include`
> the configuration file. The result is that the date, time, and user
> are set at the point of configuration (invocation of CMake) instead
> of at build, thus allowing for incremental rebuilds.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 7808d1a0086a791af8dcb2dd796b9424c7d5 
>   src/common/build.cpp 090b59fb22bfc00516d65f501f8f18cd85a5b4cd 
>   src/common/build_config.hpp.in PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57052/diff/2/
> 
> 
> Testing
> ---
> 
> cmake; make && make check on Linux
> cmake; VS build stout-tests and mesos-tests, then repeat and see no 
> compilation take place a second time. Also support\windows-build.bat twice.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 57108: Handled the `FrameworkInfo` field added to the `UpdateFrameworkMessage`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57108/
---

(Updated March 1, 2017, 12:51 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Updated dependency


Bugs: MESOS-6627
https://issues.apache.org/jira/browse/MESOS-6627


Repository: mesos


Description
---

Populates the `FrameworkInfo` field added to `UpdateFrameworkMessage`,
and propagated necessary changes to message handlers.


Diffs
-

  src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942 
  src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2 
  src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a 
  src/tests/slave_recovery_tests.cpp 0e295915fea0a7314e173857249bd8726eeccd76 
  src/tests/slave_tests.cpp 3731c7607d5e49f3000c4863b1999851fac45705 


Diff: https://reviews.apache.org/r/57108/diff/1/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

[Ilya Pronin]

> On Dec. 6, 2016, 10:42 p.m., Benjamin Mahler wrote:
> > Thanks Ilya!
> > 
> > Have you looked at other pidfile related libraries? Looks like BSD provides 
> > some functions for this (they're also available on Linux):
> > https://www.freebsd.org/cgi/man.cgi?query=pidfile&sektion=3&manpath=FreeBSD+6.1-RELEASE
> > https://linux.die.net/man/3/pidfile
> > 
> > It would be great to provide an os-agnostic library within stout for this, 
> > e.g.:
> > 
> > ```
> > pidfile::open()
> > pidfile::close()
> > pidfile::remove()
> > ```
> > 
> > I haven't looked too deeply at what we should have these take and return, 
> > but I noticed the use of RAII seemed unnecessary in your patch (only the 
> > .cpp implementation uses the exposed RAII class? If so, perhaps we can just 
> > leave RAII out for now since the callers do not use it). Also it would be 
> > great to which process is already running (which is provided by the 
> > BSD/Linux functions). Also, another suggestion as a first step here is to 
> > avoid Windows support entirely for now if we don't implement the locking 
> > aspect of this (as that seems necessary for this to be safely usable?)
> > 
> > We could structure the patches like this:
> > 
> > (1) Addition of pidfile utilities to stout.
> > (2) Tests of the pidfile utilities in stout (should be possible?)
> > (3) Integration of the pidfile utilities into mesos (manually test since 
> > the logic will reside in the mains?)
> 
> Ilya Pronin wrote:
> Thanks for the feedback!
> 
> > Looks like BSD provides some functions for this (they're also available 
> on Linux)
> 
> Yes, I saw `libbsd` but since it's not part of POSIX I decided to make 
> things portable.
> 
> > Also it would be great to which process is already running
> 
> Good idea! I will add it.
> 
> > I noticed the use of RAII seemed unnecessary in your patch (only the 
> .cpp implementation uses the exposed RAII class? If so, perhaps we can just 
> leave RAII out for now since the callers do not use it).
> 
> My intention was to try to be nice and clean up the PID file when daemon 
> exits through `std::exit()` or terminates on `SIGTERM`. For handling the 
> first case I created a static RAII object so its destructor will be called 
> during `std::exit()` cleanup. We could place this object in `main()`. But 
> here comes the second case. Our daemons perform default `SIGTERM` action 
> which is `term`. There's a signal handler in `logging/logging.cpp` where we 
> can unlink the file. For that I introduced a helper function and placed the 
> RAII object inside `common/pid_file.cpp`.
> 
> So I think a RAII class is a good thing for implementing such thing. I'm 
> OK with moving it to stout and restructuring patches.
> 
> Also I just thought that I should check if the destructor is executing 
> inside the process that created the PID file to protect from unlinking by 
> forked processes.
> 
> What do you think?
> 
> Alexander Rukletsov wrote:
> A problem with the RAII class here is that we sometimes manually have to 
> release the lock (in case of a signal). When I look at this patch I read 
> something like "Hey, you don't have to close & remove the pidfile explicitly, 
> we'll do that for you... well, unless your process is signaled". I'm inclined 
> to require users call `removePidFile()` explicitly to avoid creaing a false 
> feeling of safety.
> 
> Another question: Why do you want to expose `PIDFile` class in the `.hpp`?
> 
> Ilya Pronin wrote:
> Well, I wrote it more like "you can remove it manually if you want but if 
> you just forget about it nothing bad will happen" :) The lock will be 
> released automatically when the fd is closed (e.g. on process termination).
> 
> I think current `SIGTERM` handling is an exceptional case here (even 
> though I assume it is the most frequent way the daemon terminates). Another 
> such case could be calling `std::_Exit()`. These are situations when usual 
> cleanup is not performed and some manual actions may be required.
> 
> Do we want to always do cleanup manually and explicitly? If this is the 
> accepted way in Mesos then of course RAII is not appliable here.
> 
> > Why do you want to expose PIDFile class in the .hpp?
> 
> For testing. Although there's only 1 simple test.
> 
> Benjamin Mahler wrote:
> Ah ok, I see all of the cases you were looking to cover now!
> 
> While we figure out if we can leverage RAII and a static global smart 
> pointer, we can start with a simple set of function utilities in stout (such 
> that one could build the RAII wrapper on top of them, if needed).
> 
> For the static smart pointer, we currently follow Google's style guide 
> rule to ban "static non-POD variables" in order to avoid destructor ordering 
> issues and access during/after destruction issues:
> 
> https://google.github.io/styleguide/cppguide.html#Static_a

Re: Review Request 57190: Updated agent for hierarchical roles.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57190/#review167564
---



Bad review!

Reviews applied: [57190, 57166, 56805, 57165, 57164]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On March 1, 2017, 2:47 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57190/
> ---
> 
> (Updated March 1, 2017, 2:47 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-7047
> https://issues.apache.org/jira/browse/MESOS-7047
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adjusts the way persistent volumes are stored on the
> agent. Instead of interpreting the role of the volume as a literal
> path, we replace `/` with ` ` when creating the path. This prevents
> that subdirectories are created for volumes with hierarchical roles.
> Directly interpreting the role as a path is undesirable as it can lead
> to volumes overlapping (e.g., a volume with role `a/b/c/d` and id `id`
> would be visible as `id` in a volume with role `a/b/c` and id `d`).
> 
> 
> Diffs
> -
> 
>   src/slave/paths.cpp 38ad1993aa36a627ec97a7865488677495ee4c5a 
>   src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 
> 
> 
> Diff: https://reviews.apache.org/r/57190/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 56208: Updated checks library with general check support.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56208/#review167557
---




src/checks/checker.cpp
Line 297 (original), 309 (patched)


Just do EXIT or LOG(FATAL), doing a CHECK that obviously fails is weird.

```
LOG(FATAL) << "Received UNKNOWN check type";
```



src/checks/checker.cpp
Line 315 (original), 328 (patched)


we should probably have a "<<" operator overload for check type.



src/checks/checker.cpp
Lines 398 (patched)


can you add a comment on why you need to do a copy here?



src/checks/checker.cpp
Line 424 (original), 440 (patched)


why are we sending WEXITSTATUS and not exit code?



src/checks/checker.cpp
Lines 499 (patched)


ditto. comment here.


- Vinod Kone


On March 1, 2017, 12:50 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56208/
> ---
> 
> (Updated March 1, 2017, 12:50 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
> https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add support for general checks, i.e. defined by CheckInfo, in
> checking library. A general check can be either an command or
> an HTTP request. The library performs the requested check at
> the specified interval and sends the result to the framework
> via a task status update. If the current result is the same as
> the previous result, no status update is sent.
> 
> 
> Diffs
> -
> 
>   src/checks/checker.hpp dc293f3d3613dec716510d269829f8a6f406c277 
>   src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6 
>   src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 
>   src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1 
> 
> 
> Diff: https://reviews.apache.org/r/56208/diff/7/
> 
> 
> Testing
> ---
> 
> https://reviews.apache.org/r/56213/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 56017: Added a helper for building a task status from an existing one.

[Vinod Kone]

> On March 1, 2017, 7:46 p.m., Vinod Kone wrote:
> > src/common/protobuf_utils.hpp
> > Lines 96-98 (original), 98-100 (patched)
> > 
> >
> > The last sentence seems un-necssary because the it's clear from the 
> > arguments what fields can be overwritten?
> 
> Alexander Rukletsov wrote:
> I'd rather keep the comment (which should be updated by the way to 
> include `uuid`) in order to make our intent explicit and for example catch 
> situations when this helper and `TaskStatus` go out of sync.

Up to you. I just find such comments on generic helpers being leaky 
abstractions (what the default executor's intention is).


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56017/#review167556
---


On Feb. 28, 2017, 3:48 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56017/
> ---
> 
> (Updated Feb. 28, 2017, 3:48 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 09e468c77f0cdd931302d1bdcc192370b6ce3340 
>   src/common/protobuf_utils.cpp 944263bbaa87a65005fd924bccfadb7293312fa0 
> 
> 
> Diff: https://reviews.apache.org/r/56017/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 56017: Added a helper for building a task status from an existing one.

[Alexander Rukletsov]

> On March 1, 2017, 7:46 p.m., Vinod Kone wrote:
> > src/common/protobuf_utils.hpp
> > Lines 96-98 (original), 98-100 (patched)
> > 
> >
> > The last sentence seems un-necssary because the it's clear from the 
> > arguments what fields can be overwritten?

I'd rather keep the comment (which should be updated by the way to include 
`uuid`) in order to make our intent explicit and for example catch situations 
when this helper and `TaskStatus` go out of sync.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56017/#review167556
---


On Feb. 28, 2017, 3:48 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56017/
> ---
> 
> (Updated Feb. 28, 2017, 3:48 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 09e468c77f0cdd931302d1bdcc192370b6ce3340 
>   src/common/protobuf_utils.cpp 944263bbaa87a65005fd924bccfadb7293312fa0 
> 
> 
> Diff: https://reviews.apache.org/r/56017/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 56017: Added a helper for building a task status from an existing one.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56017/#review167556
---


Fix it, then Ship it!





src/common/protobuf_utils.hpp
Lines 96-98 (original), 98-100 (patched)


The last sentence seems un-necssary because the it's clear from the 
arguments what fields can be overwritten?


- Vinod Kone


On Feb. 28, 2017, 3:48 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56017/
> ---
> 
> (Updated Feb. 28, 2017, 3:48 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 09e468c77f0cdd931302d1bdcc192370b6ce3340 
>   src/common/protobuf_utils.cpp 944263bbaa87a65005fd924bccfadb7293312fa0 
> 
> 
> Diff: https://reviews.apache.org/r/56017/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 56016: Added a note about task status updates in scheduler and internal API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56016/#review167555
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 28, 2017, 3:46 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56016/
> ---
> 
> (Updated Feb. 28, 2017, 3:46 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> d04924a49d0bf28952af6cb72d972cac61e6f781 
>   include/mesos/v1/scheduler/scheduler.proto 
> 6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce 
>   src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698 
> 
> 
> Diff: https://reviews.apache.org/r/56016/diff/2/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 57195: Updated WebUI to display role information of tasks in homepage.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57195/#review167553
---



Patch looks great!

Reviews applied: [57013, 57132, 57192, 57193, 57194, 57195]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 1, 2017, 10:24 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57195/
> ---
> 
> (Updated March 1, 2017, 10:24 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6657
> https://issues.apache.org/jira/browse/MESOS-6657
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated WebUI to display role information of tasks in homepage.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/home.html 07bc84877a600629cc1818849783cc4b0ea912d8 
> 
> 
> Diff: https://reviews.apache.org/r/57195/diff/1/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> homepage
>   
> https://reviews.apache.org/media/uploaded/files/2017/03/01/b3c5e352-6581-4950-93a3-9a6f6769b035__Screen_Shot_2017-03-01_at_18.22.13.png
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 57132: Fixed WebUI data-key.

[Benjamin Mahler]

> On March 1, 2017, 6:55 p.m., Benjamin Mahler wrote:
> > There are probably other `data-key`s that are broken too, I didn't do a 
> > sweep when I had suggested fixing these :)

By the way, you can test if the data-key is correct by clicking the table 
headers and seeing if it sorts in ascending vs descending order.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57132/#review167541
---


On March 1, 2017, 10:23 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57132/
> ---
> 
> (Updated March 1, 2017, 10:23 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6657
> https://issues.apache.org/jira/browse/MESOS-6657
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some of the data-key are incorrect, which causes sorting problem.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 7a4599367ea8ff802591adfd86d4058cdc51f297 
> 
> 
> Diff: https://reviews.apache.org/r/57132/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 57132: Fixed WebUI data-key.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57132/#review167541
---


Ship it!




There are probably other `data-key`s that are broken too, I didn't do a sweep 
when I had suggested fixing these :)

- Benjamin Mahler


On March 1, 2017, 10:23 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57132/
> ---
> 
> (Updated March 1, 2017, 10:23 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6657
> https://issues.apache.org/jira/browse/MESOS-6657
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some of the data-key are incorrect, which causes sorting problem.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 7a4599367ea8ff802591adfd86d4058cdc51f297 
> 
> 
> Diff: https://reviews.apache.org/r/57132/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54449/
---

(Updated March 1, 2017, 6:50 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Bugs: MESOS-6732
https://issues.apache.org/jira/browse/MESOS-6732


Repository: mesos


Description
---

The XFS disk isolator checks that the filesystem is XFS, but doesn't
check whether project quotas are actually enabled. This means that
an invalid configuration will start but will always fail when tasks
are launched.

Add a check to test whether project quotas are enabled on the work
directory and fail hard if they are not.


Diffs
-

  configure.ac 7a18c89854c1f42bec09f067579b72114fb8ec1d 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
dd4df86bf90bfa9cbf4664d89274cf3c64c2e374 
  src/slave/containerizer/mesos/isolators/xfs/utils.hpp 
7602fe3b6ab069db643397418732e773d0417f8a 
  src/slave/containerizer/mesos/isolators/xfs/utils.cpp 
b9d8e7dc999ba3064bee7105eff0f9553d825df8 


Diff: https://reviews.apache.org/r/54449/diff/3/


Testing
---

Make check on Fedora 25. Manual test on F25 with mesos-execute.


Thanks,

James Peach

Re: Review Request 50463: Added code to build libmesosjava shared library.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50463/#review167519
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 10, 2016, 7:19 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50463/
> ---
> 
> (Updated Dec. 10, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Builds mesosjava library from the mesos source files and the generated
> JNI header files.
> 'make mesosjava' genetated the library.
> 
> 
> Diffs
> -
> 
>   cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc 
>   src/CMakeLists.txt 0cc0451ae3ca0183da3d575cc4bd3c5b3ea30ecc 
> 
> 
> Diff: https://reviews.apache.org/r/50463/diff/5/
> 
> 
> Testing
> ---
> 
> cmake && make mesosjava
> 
> Build /src/libmesosjava.* shared libraries.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54693/#review167535
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 21, 2016, 8:06 p.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54693/
> ---
> 
> (Updated Dec. 21, 2016, 8:06 p.m.)
> 
> 
> Review request for mesos, Xiaojian Huang, Gilbert Song, haosdent huang, Jie 
> Yu, Kunal Thakar, and Zhitao Li.
> 
> 
> Bugs: MESOS-6162
> https://issues.apache.org/jira/browse/MESOS-6162
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add ProtoBuf schema for Blkio cgroups per the kernel Blkio controller doc.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0017d3d9d46433b391703025f611ce437bbc7ebe 
> 
> 
> Diff: https://reviews.apache.org/r/54693/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 50523: Updated docker recovery to account for GPU resources.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50523/#review167532
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 20, 2016, 7:53 a.m., Rajat Phull wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50523/
> ---
> 
> (Updated Dec. 20, 2016, 7:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, Yubo Li, and Vikrama 
> Ditya.
> 
> 
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker recovery to account for GPU resources.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 006f929eca0e0a6b1de941821ac72869ba393d2d 
>   src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16 
> 
> 
> Diff: https://reviews.apache.org/r/50523/diff/6/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_LaunchWithGpuRecovery"
>  make -j check
> 
> 
> Thanks,
> 
> Rajat Phull
> 
>

Re: Review Request 52071: Updated docs to handle resources with no size in agent flags.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52071/#review167533
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 20, 2016, 2:05 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52071/
> ---
> 
> (Updated Dec. 20, 2016, 2:05 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6062
> https://issues.apache.org/jira/browse/MESOS-6062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a resource with no size is specified in `--resources` startup
> flag of mesos agent, the size is auto detected by the agent. This
> is enabled for all known resource types (except gpus) only when
> the resources are specified in JSON format.
> For disk resources, this is done for both root disks as well as
> MOUNT and PATH disks.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 2caa44927d45c0ab13f8160794b50f4fde3711aa 
> 
> 
> Diff: https://reviews.apache.org/r/52071/diff/11/
> 
> 
> Testing
> ---
> 
> Documentation change only. All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT or PATH disks.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51880/#review167531
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 20, 2016, 2:04 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51880/
> ---
> 
> (Updated Dec. 20, 2016, 2:04 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6062
> https://issues.apache.org/jira/browse/MESOS-6062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit tests to determine disk size for MOUNT or PATH disks.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b 
>   src/tests/containerizer/resources_containerizer_tests.cpp PRE-CREATION 
>   src/tests/resources_tests.cpp 8dfb1be35d9f9c6ff69139d055c6b3d3ec475e68 
> 
> 
> Diff: https://reviews.apache.org/r/51880/diff/15/
> 
> 
> Testing
> ---
> 
> All tests including the additional tests in this RR passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 50415: Added build step to build Java Protobuf.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50415/#review167521
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 10, 2016, 7:18 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50415/
> ---
> 
> (Updated Dec. 10, 2016, 7:18 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added config, build and install steps for the External project
> protobuf_java.
> 'make probuf_java' produces the
> ${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt a340b29fc1cc8b68bf74bfc0c9c2274f0af84eee 
> 
> 
> Diff: https://reviews.apache.org/r/50415/diff/8/
> 
> 
> Testing
> ---
> 
> cmake && make protobuf-2.6.1-java 
> check if 
> 3rdparty/protobuf-2.6.1/src/protobuf-2.6.1-java/java/target/protobuf-java-2.6.1.jar
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 52002: Added helper methods to determine types of disk resources.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52002/#review167527
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 18, 2016, 8:38 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52002/
> ---
> 
> (Updated Dec. 18, 2016, 8:38 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6062
> https://issues.apache.org/jira/browse/MESOS-6062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper methods to determine types of disk resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp c2e6d6680d9687f0bbfb73e84ffb1457072c4412 
>   include/mesos/v1/resources.hpp 98f025b68c818c384a1174ef9b969f5c0776a7f1 
>   src/common/resources.cpp 7dbeefc8fc159f28dc1542ad6a761213c65ff226 
>   src/tests/resources_tests.cpp 8dfb1be35d9f9c6ff69139d055c6b3d3ec475e68 
>   src/v1/resources.cpp 859f7388035b855bf0cb60d5cbe746e6871bf833 
> 
> 
> Diff: https://reviews.apache.org/r/52002/diff/12/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 53713: Reversed recoursive path creation.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53713/#review167529
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 5:44 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53713/
> ---
> 
> (Updated Nov. 14, 2016, 5:44 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, 
> Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change allows the user to use different
> path formats. Specialy on Windows will allow to
> specify `X:\PATH`, '\\foo\bar\PATH`, `\\?\X:\PATH`
> and other valid path.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/mkdir.hpp 
> fe86864c8b480993c8f052f39b2fd3ece23798da 
> 
> 
> Diff: https://reviews.apache.org/r/53713/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 54769: Fixed a cleanup related bug in the IO switchboard.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54769/#review167526
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 15, 2016, 2:03 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54769/
> ---
> 
> (Updated Dec. 15, 2016, 2:03 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6784
> https://issues.apache.org/jira/browse/MESOS-6784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, we never used to wait for `reaped()` to be executed
> completely before invoking `cleanup()`. This happened due to the
> fact that `reaped()` returned a `void` making the overload of
> `defer()` that just does `dispatch()` to the actor without
> waiting for `reaped()` to be complete.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.hpp 
> 7a7ad2da047ef316f4382e45526d503c87a903a0 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> c80627986f729255e3b3ad1fc9cfa6213e19c521 
> 
> 
> Diff: https://reviews.apache.org/r/54769/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fixed Test added later in the chain)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 54655: Renamed LocalNestedContainerObjectApprover for a more generic name.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54655/#review167523
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 12, 2016, 9:51 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54655/
> ---
> 
> (Updated Dec. 12, 2016, 9:51 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renames `LocalNestedContainerObjectApprover` to
> `CombinedACLObjectApprover` in order to allow uses beyond nested
> containers.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> 3b983d0c0dea3ad761e7c684a9f943809dc541e9 
> 
> 
> Diff: https://reviews.apache.org/r/54655/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 50459: Added code to generate JNI Header files.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50459/#review167517
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 10, 2016, 7:19 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50459/
> ---
> 
> (Updated Dec. 10, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created a custom command to run javah on the generated java classes
> to create the JNI headers for Java bindings.
> 'make mesos-jni-headers' creates the jni header under the directory
> /include/java/jni/*.h
> 
> 
> Diffs
> -
> 
>   cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc 
>   src/java/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/50459/diff/4/
> 
> 
> Testing
> ---
> 
> cmake && make mesos-jni-header
> check to see if all the headers are generated.
> /include/java/jni/org_apache_mesos_Log.h
> /include/java/jni/org_apache_mesos_Log_Entry.h
> /include/java/jni/org_apache_mesos_Log_OperationFailedException.h
> /include/java/jni/org_apache_mesos_Log_Position.h
> /include/java/jni/org_apache_mesos_Log_Reader.h
> /include/java/jni/org_apache_mesos_Log_Writer.h
> /include/java/jni/org_apache_mesos_Log_WriterFailedException.h
> /include/java/jni/org_apache_mesos_MesosExecutorDriver.h
> /include/java/jni/org_apache_mesos_MesosSchedulerDriver.h
> /include/java/jni/org_apache_mesos_state_AbstractState.h
> /include/java/jni/org_apache_mesos_state_AbstractState_ExpungeFuture.h
> /include/java/jni/org_apache_mesos_state_AbstractState_FetchFuture.h
> /include/java/jni/org_apache_mesos_state_AbstractState_NamesFuture.h
> /include/java/jni/org_apache_mesos_state_AbstractState_StoreFuture.h
> /include/java/jni/org_apache_mesos_state_LevelDBState.h
> /include/java/jni/org_apache_mesos_state_LogState.h
> /include/java/jni/org_apache_mesos_state_Variable.h
> /include/java/jni/org_apache_mesos_state_ZooKeeperState.h
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 54636: Added LOCAL_IP to disk_full_framework_test.sh.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54636/#review167520
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 11, 2016, 4 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54636/
> ---
> 
> (Updated Dec. 11, 2016, 4 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: 6614
> https://issues.apache.org/jira/browse/6614
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added LOCAL_IP to disk_full_framework_test.sh.
> 
> 
> Diffs
> -
> 
>   src/tests/disk_full_framework_test.sh 
> 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e 
> 
> 
> Diff: https://reviews.apache.org/r/54636/diff/1/
> 
> 
> Testing
> ---
> 
> gmake check. Test still fails, but it no longer hangs when given the correct 
> addr.
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review167537
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 12, 2016, 10:03 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Dec. 12, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/2/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 46425: Add helper function to simplify tokenize handling.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46425/#review167525
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On June 29, 2016, 4:56 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46425/
> ---
> 
> (Updated June 29, 2016, 4:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5234
> https://issues.apache.org/jira/browse/MESOS-5234
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add helper function to simplify tokenize handling.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/strings.hpp 
> 162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 
>   3rdparty/stout/tests/strings_tests.cpp 
> b54a9dbf162403310b8bba687442e184a473f5a6 
> 
> 
> Diff: https://reviews.apache.org/r/46425/diff/3/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51879/#review167528
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 18, 2016, 8:38 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51879/
> ---
> 
> (Updated Dec. 18, 2016, 8:38 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6062
> https://issues.apache.org/jira/browse/MESOS-6062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When static resources indicate resources with a positive size, we use
> that for the resources on the agent. However, --resources can include
> resources with no size, which indicates that mesos agent determine the
> size of those resources from the agent and uses that information. Note
> that auto-detection of resources is allowed for all known resource
> types represented in JSON format only. Auto-detection is not done when
> the resources are represented in text format.
> 
> With this change, JSON representation for disk resources that do not
> specify any value would not result in an error, but those resources
> will not be accounted for until a valid size is determined for such
> resources. A scalar value of -1 still results in an invalid resource.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp c2e6d6680d9687f0bbfb73e84ffb1457072c4412 
>   include/mesos/v1/resources.hpp 98f025b68c818c384a1174ef9b969f5c0776a7f1 
>   src/common/resources.cpp 7dbeefc8fc159f28dc1542ad6a761213c65ff226 
>   src/slave/containerizer/containerizer.cpp 
> d46882baa904fd439bffb23c324828b777228f1c 
>   src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 
> 2e722691475c84afae14009014ea70cc0fdd0e65 
>   src/v1/resources.cpp 859f7388035b855bf0cb60d5cbe746e6871bf833 
> 
> 
> Diff: https://reviews.apache.org/r/51879/diff/12/
> 
> 
> Testing
> ---
> 
> Tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54449/#review167522
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 13, 2016, 12:15 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54449/
> ---
> 
> (Updated Dec. 13, 2016, 12:15 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6732
> https://issues.apache.org/jira/browse/MESOS-6732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The XFS disk isolator checks that the filesystem is XFS, but doesn't
> check whether project quotas are actually enabled. This means that
> an invalid configuration will start but will always fail when tasks
> are launched.
> 
> Add a check to test whether project quotas are enabled on the work
> directory and fail hard if they are not.
> 
> 
> Diffs
> -
> 
>   configure.ac 7a18c89854c1f42bec09f067579b72114fb8ec1d 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> dd4df86bf90bfa9cbf4664d89274cf3c64c2e374 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp 
> 7602fe3b6ab069db643397418732e773d0417f8a 
>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp 
> b9d8e7dc999ba3064bee7105eff0f9553d825df8 
> 
> 
> Diff: https://reviews.apache.org/r/54449/diff/3/
> 
> 
> Testing
> ---
> 
> Make check on Fedora 25. Manual test on F25 with mesos-execute.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 54085: Made internal Mesos headers more standalone.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54085/#review167524
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 14, 2016, 9:03 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54085/
> ---
> 
> (Updated Dec. 14, 2016, 9:03 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Missing includes were found by attempting to parse the header files
> standalone with
> 
> $ clang++ -fsyntax-only -I  HEADER_FILE.hpp
> 
> By fixing failures we can make sure that all required symbols are
> defined.
> 
> Note this change does not address the issue of transitive includes.
> 
> 
> Diffs
> -
> 
>   src/common/build.hpp 80e071fea7e2ca98772ccd85930a538a8dbca0a6 
>   src/credentials/credentials.hpp c790793c7ea5ed384bdb397bfc1592b8fd1ff327 
>   src/master/allocator/mesos/metrics.hpp 
> 753f90acc52ada84883cbbe3350e61d1e1eaff48 
>   src/master/machine.hpp 22b87770f0811bcef25bb79d678e0a3e78d3f7ac 
>   src/slave/container_loggers/logrotate.hpp 
> 96dbd2db9495925cb618bd7fe6271023c74fd9fe 
>   src/slave/containerizer/composing.hpp 
> 292374aefbc70e4b9d8c81740656864dbada8e32 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp 
> 8d225878ddbd04e4297b84c9ff782a994986aa4e 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp 
> 642dd53a8028d26b0a8c7429a502d33db26838b7 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> 2cc8e764ff18c95c29598df75cdb370ccf120662 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> b8fc755a8dd4757d904f7e97a71d3cf7f29d2033 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 
> 7678a7c81c3cdb27410c1f066021eb34bd02a83f 
>   src/slave/containerizer/mesos/provisioner/appc/cache.hpp 
> 1e10dc604b29e418beacad6475910dcf7f8899c0 
>   src/slave/posix_signalhandler.hpp 49692b140662280b9e150654c5f336f1b920586f 
>   src/slave/qos_controllers/load.hpp 098a6d0b2dfc54b5b95a261a780eea70a838c12d 
>   src/tests/containerizer/mock_containerizer.hpp 
> ca0ae053b1eed01d6c04f581cd08485beec0c5fb 
>   src/usage/usage.hpp 6576b9001f93cb33c8c4ae83b32ee22ea0354fc7 
> 
> 
> Diff: https://reviews.apache.org/r/54085/diff/2/
> 
> 
> Testing
> ---
> 
> make check (OS X, clang trunk w/o optimizations, SSL)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 50460: Added code to build libstate shared library.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50460/#review167518
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 10, 2016, 7:19 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50460/
> ---
> 
> (Updated Dec. 10, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Build libstate required by the mesos java bindings to communicate
> state information with java based components.
> 
> 
> Diffs
> -
> 
>   cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc 
>   src/CMakeLists.txt 0cc0451ae3ca0183da3d575cc4bd3c5b3ea30ecc 
>   src/state/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/50460/diff/4/
> 
> 
> Testing
> ---
> 
> cmake .. && make state 
> 
> build libstate dynamic library.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 54986: Added metric for slave message queue.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54986/#review167536
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 22, 2016, 5:12 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54986/
> ---
> 
> (Updated Dec. 22, 2016, 5:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai.
> 
> 
> Bugs: MESOS-6831
> https://issues.apache.org/jira/browse/MESOS-6831
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added metric for slave message queue.
> 
> 
> Diffs
> -
> 
>   src/slave/metrics.hpp 3fc933ca65690d6fad63156398ad9c2c53789296 
>   src/slave/metrics.cpp 0eb2b59ed67e14e73b29d7592c239441df0008d5 
>   src/slave/slave.hpp be72ba93d4c6ca3e69e3f76f87aa7ddebdbf9cad 
>   src/tests/slave_tests.cpp fc6b56c074c71b827a9ee522cd715c0d15ecc7e3 
> 
> 
> Diff: https://reviews.apache.org/r/54986/diff/1/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 54828: Fixed flags::fetch() to support Windows file paths.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54828/#review167534
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 16, 2016, 11:27 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54828/
> ---
> 
> (Updated Dec. 16, 2016, 11:27 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5937
> https://issues.apache.org/jira/browse/MESOS-5937
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed flags::fetch() to support Windows file paths.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/fetch.hpp 
> 788d09e0a2083ead7d6ccb0c233cfdfd5d1ddb81 
>   3rdparty/stout/tests/flags_tests.cpp 
> e2681f8f68f6478d4c8a20c1e75ddb050d16b56d 
> 
> 
> Diff: https://reviews.apache.org/r/54828/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 53707: Added a Windows isolator. Removed `#ifdef`-ed block from Posix.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53707/#review167530
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 5:45 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53707/
> ---
> 
> (Updated Nov. 14, 2016, 5:45 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, 
> Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a  Windows isolator. Removed `#ifdef`-ed block from Posix.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> 270d2aa6e06f323bfb6eee3b703a24a600a55871 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
> 2bf011d3e7b014a17f759851d755b161c897b131 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
> f169c380f803a2111b1612cee60250ee9a30ef2e 
> 
> 
> Diff: https://reviews.apache.org/r/53707/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 50458: Added code to build mesos-java.jar.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50458/#review167516
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 10, 2016, 7:19 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50458/
> ---
> 
> (Updated Dec. 10, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The patch defines Java sources from the mesos repo along with
> generated protobug definitions in Java. Compiles these sources to
> create /src/java/mesos-java.jar.
> make mesos-java
> 
> 
> Diffs
> -
> 
>   cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc 
>   src/java/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/50458/diff/4/
> 
> 
> Testing
> ---
> 
> cmake && make mesos-java 
> Check to see if /src/java/mesos-java.jar
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50457: Added code to generate MesosNativeLibrary.java.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50457/#review167515
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 10, 2016, 7:19 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50457/
> ---
> 
> (Updated Dec. 10, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a cmake library that makes use of configure_file to transform
> a source file at a relative location to the Source directory in to a
> target file at a realtive location into the Build Directory.
> The transformation replaces any CMake Variables in the source with
> assigned values.
> 
> 
> Diffs
> -
> 
>   cmake/Common.cmake 76b2a67419cb6836b598a0070f26632d4ca048ff 
>   src/java/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/50457/diff/5/
> 
> 
> Testing
> ---
> 
> cmake .. 
> Check to see if 
> /src/java/generated/org/apache/mesos/MesosNativeLibrary.java is 
> generated.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 57177: Clarified naming rules in C++ style guide.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57177/#review167510
---


Ship it!




Ship It!

- Vinod Kone


On March 1, 2017, 6:34 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57177/
> ---
> 
> (Updated March 1, 2017, 6:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch clarifies the differences in naming rules between
> Mesos application code and the libprocess/stout libraries. It
> also updates Wikipedia links to point to more instructive
> portions of the relevant entries.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 176562d61340492383359a3697a8543806f47f2b 
> 
> 
> Diff: https://reviews.apache.org/r/57177/diff/1/
> 
> 
> Testing
> ---
> 
> Viewed using the site-building Docker container, verified links.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50455: Enabled Java builds if Java is found.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50455/#review167507
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 10, 2016, 7:18 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50455/
> ---
> 
> (Updated Dec. 10, 2016, 7:18 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using FindJava and FindJNI cmake packages to detect java on the host,
> set JNI include paths and
> set HAS_JAVA global variable to conditionally build Java support.
> 
> 
> Diffs
> -
> 
>   cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc 
> 
> 
> Diff: https://reviews.apache.org/r/50455/diff/5/
> 
> 
> Testing
> ---
> 
> cmake -DENABLE_JAVA=ON 
> check build variables set for Java.
> cmake should output
> -- 
> -- Java Found and will be enabled
> -- 
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50456: Added custom command to generate Java protobufs.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50456/#review167509
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 10, 2016, 7:18 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50456/
> ---
> 
> (Updated Dec. 10, 2016, 7:18 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Patch creates required directories mentioned below
> ${MESOS_BIN_INCLUDE_DIR}/java
> ${MESOS_BIN_SRC_DIR}/java/generated
> 
> Creates Java protobuf definitions under
> ${MESOS_BIN_SRC_DIR}/java/generated.
> 
> 
> Diffs
> -
> 
>   cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc 
>   src/CMakeLists.txt 0cc0451ae3ca0183da3d575cc4bd3c5b3ea30ecc 
>   src/java/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/50456/diff/5/
> 
> 
> Testing
> ---
> 
> cmake .. && make mesos-java-protos.
> check to see if java/generated folder has all the new java files created.
> /src/java/generated/org/apache/mesos/containerizer/Protos.java
> /src/java/generated/org/apache/mesos/fetcher/Protos.java
> /src/java/generated/org/apache/mesos/Protos.java
> /src/java/generated/org/apache/mesos/scheduler/Protos.java
> /src/java/generated/org/apache/mesos/v1/executor/Protos.java
> /src/java/generated/org/apache/mesos/v1/Protos.java
> /src/java/generated/org/apache/mesos/v1/scheduler/Protos.java
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 53912: Fix xattr for FreeBSD.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53912/#review167500
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 19, 2016, 12:10 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53912/
> ---
> 
> (Updated Nov. 19, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-6609
> https://issues.apache.org/jira/browse/MESOS-6609
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix xattr for FreeBSD.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/xattr.hpp 
> 518940fdffab38ad97cf229078c4494fa944e1d8 
> 
> 
> Diff: https://reviews.apache.org/r/53912/diff/1/
> 
> 
> Testing
> ---
> 
> gmake on FreeBSD, no check run.
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 53608: Added --enable-seccomp flag to configure options.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53608/#review167481
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 25, 2016, 2:47 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53608/
> ---
> 
> (Updated Nov. 25, 2016, 2:47 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6581
> https://issues.apache.org/jira/browse/MESOS-6581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> User would be able to enable seccomp figures via --enable-seccomp.
> It requires libseccomp to be pre-installed.
> 
> 
> Diffs
> -
> 
>   configure.ac 5380cbc6a7951ede2f883f7045952a3f3434479e 
> 
> 
> Diff: https://reviews.apache.org/r/53608/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 53605: Added --seccomp_profile flag to Mesos agent.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53605/#review167492
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 25, 2016, 2:46 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53605/
> ---
> 
> (Updated Nov. 25, 2016, 2:46 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6581
> https://issues.apache.org/jira/browse/MESOS-6581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Operator uses this flag to pass in JSON file that specifies a set of
> Seccomp rules that will be enforced on all container processes launched
> on this agent.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 7824407a6bbfc06edeec69479ed82cabae34a440 
>   src/common/parse.hpp 1dca9ba4ed4ff2163193ab6432b5b017d2be787e 
>   src/common/type_utils.cpp 8270f808277d84a73823992c639d6536a99353b8 
>   src/slave/flags.hpp c6c3197bbf30ec617751f4a1a34914c0f0e29eb5 
>   src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44 
> 
> 
> Diff: https://reviews.apache.org/r/53605/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 53607: Added Seccomp imeplementation.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53607/#review167480
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 25, 2016, 2:47 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53607/
> ---
> 
> (Updated Nov. 25, 2016, 2:47 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6581
> https://issues.apache.org/jira/browse/MESOS-6581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It leverages libseccomp to initialize a seccomp filter context,
> add architectures and rules, and loads it into kernel.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am dd1626d177b38a6613f18f32bb0668abbb5100e0 
>   src/linux/seccomp.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/launch.cpp 
> 320e42748adbabf09f77cb4f5951e2a7ea58fe64 
> 
> 
> Diff: https://reviews.apache.org/r/53607/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 54104: Adjusted code style in docker executor.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54104/#review167484
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 27, 2016, 10:40 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54104/
> ---
> 
> (Updated Nov. 27, 2016, 10:40 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, and 
> Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted code style in docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 94e116f06c0c729a90e5424c37edc39c7ba4cbe6 
> 
> 
> Diff: https://reviews.apache.org/r/54104/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 53121: Added a child hook for entering the target pid's namespaces.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53121/#review167488
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 27, 2016, 4:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53121/
> ---
> 
> (Updated Nov. 27, 2016, 4:01 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, Joerg 
> Schad, and Qian Zhang.
> 
> 
> Bugs: MESOS-6236
> https://issues.apache.org/jira/browse/MESOS-6236
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a child hook for entering the target pid's namespaces.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess_base.hpp 
> 1d02454d5541f96cb4928bf027fcae3764989d67 
>   3rdparty/libprocess/src/subprocess.cpp 
> 284e22e28ae8d2c1486e4a6bea743b8663ce2023 
> 
> 
> Diff: https://reviews.apache.org/r/53121/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 53122: Used child hooks to enter namespaces in health check.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53122/#review167489
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 27, 2016, 4:09 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53122/
> ---
> 
> (Updated Nov. 27, 2016, 4:09 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, Joerg 
> Schad, and Qian Zhang.
> 
> 
> Bugs: MESOS-6184
> https://issues.apache.org/jira/browse/MESOS-6184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used child hooks to enter namespaces in health check.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> 1230f963a98cd9a373d98cb6f67eb1b7e89c823d 
>   src/health-check/health_checker.cpp 
> c0d150a014b7debf23b58982efe335a189d32c7b 
> 
> 
> Diff: https://reviews.apache.org/r/53122/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46230/#review167478
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 20, 2016, 4:51 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46230/
> ---
> 
> (Updated Nov. 20, 2016, 4:51 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to reflect user in persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 410993fb69eb73db6ad17ef361f9b72cba5dc84d 
>   docs/shared-resources.md 1b490e253447a9e263cb5a6bda10f360ea7138ce 
> 
> 
> Diff: https://reviews.apache.org/r/46230/diff/3/
> 
> 
> Testing
> ---
> 
> Documentation change only. All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 54587: Introduced a ScaleTestContainerizer suitable for scale testing.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54587/#review167506
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 9, 2016, 9:29 p.m., Ilya Pronin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54587/
> ---
> 
> (Updated Dec. 9, 2016, 9:29 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6768
> https://issues.apache.org/jira/browse/MESOS-6768
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `ScaleTestContainerizer` and `ScaleTestExecutor` implement the basic
> behaviors of a containerizer and executor while consuming no resources.
> They are intended for use in scale testing a large number of agents
> interacting with a master.
> 
> The containerizer does no actual containerization nor does it actually
> even run the taks. It simply runs a `ScaleTestExecutor` which sends
> `TASK_RUNNING` on `Executor::launchTask()` and `TASK_KILLED` on
> `Executor::killTask()`.
> 
> Because no resources are actually consumed (but are accounted for by
> the agent) any amount of resources can be offered by the agent through
> `--resources` so that any desired number of tasks can be run.
> 
> Enable it with `--containerizers=scale-test`.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0cc0451ae3ca0183da3d575cc4bd3c5b3ea30ecc 
>   src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 
>   src/slave/containerizer/containerizer.cpp 
> d46882baa904fd439bffb23c324828b777228f1c 
>   src/slave/containerizer/scale_test/containerizer.hpp PRE-CREATION 
>   src/slave/containerizer/scale_test/containerizer.cpp PRE-CREATION 
>   src/slave/containerizer/scale_test/executor.hpp PRE-CREATION 
>   src/slave/containerizer/scale_test/executor.cpp PRE-CREATION 
>   src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c 
>   src/tests/containerizer/scale_test_containerizer_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/54587/diff/2/
> 
> 
> Testing
> ---
> 
> Added a test to verify that `TASK_RUNNING` and `TASK_KILLED` statuses are 
> reported upon task "launching" and "killing". Ran `make check`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>

Re: Review Request 53604: Added SeccompInfo protobuf message.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53604/#review167491
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 25, 2016, 2:46 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53604/
> ---
> 
> (Updated Nov. 25, 2016, 2:46 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6581
> https://issues.apache.org/jira/browse/MESOS-6581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added SeccompInfo protobuf message.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05 
>   include/mesos/slave/containerizer.proto 
> 2621522ae59cf9275f607679b4678ac54508993d 
> 
> 
> Diff: https://reviews.apache.org/r/53604/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 53479: Perform agent GC asynchronously.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53479/#review167497
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 2, 2016, 3:01 a.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53479/
> ---
> 
> (Updated Dec. 2, 2016, 3:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6549
> https://issues.apache.org/jira/browse/MESOS-6549
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Previously, rmdir operations were serialized
>   through the garbage collector. Expensive removal
>   events had the potential to delay task launch.
> - MESOS-6549
> 
> 
> Diffs
> -
> 
>   src/slave/gc.hpp 5ea82456cffa374203371f227b6f0ee00296553e 
>   src/slave/gc.cpp 961f547793984449ea113d9664b12b5033638c58 
> 
> 
> Diff: https://reviews.apache.org/r/53479/diff/2/
> 
> 
> Testing
> ---
> 
> `./bin/mesos-tests.sh --gtest_filter="GarbageCollector*" --gtest_repeat=100 
> --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 46228: Create persistent volume with a supplied user.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46228/#review167496
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 20, 2016, 4:50 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46228/
> ---
> 
> (Updated Nov. 20, 2016, 4:50 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If user is specified in Resource::DiskInfo::Persistence, set the
> ownership of the volume to that user. Tasks should have to comply to
> ownership of the volume before they can use the volume.
> If user is not specified in Resource::DiskInfo::Persistence, it is
> created with the user mesos-slave process runs as. When the first
> task is launched, it updates the ownership of the persistent volume
> with its user so as to be able to write into that volume.
> Note that tasks can fail to use the volume when they actually try
> to access the volume is that task's ownership is not compatible
> with that of the volume.
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp 4bb9beffcb3509f4226b4985e05eccec01412d0f 
>   src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 8f024d084189b59bb229c63d20108e7bfe42065f 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> 270d2aa6e06f323bfb6eee3b703a24a600a55871 
>   src/slave/slave.cpp 521f08d59cd78f9089d58cd3294f0ee4a099cd7f 
>   src/v1/resources.cpp 46cc00f2f453f5eb4ddc4b0b9b89be2bd89f05d9 
> 
> 
> Diff: https://reviews.apache.org/r/46228/diff/3/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review167475
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 16, 2016, 3:30 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50127/
> ---
> 
> (Updated Nov. 16, 2016, 3:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This added a testing case for end-to-end GPU support for docker
> containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16 
> 
> 
> Diff: https://reviews.apache.org/r/50127/diff/23/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j 
> check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 53146: Added a child hook for switching the user.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53146/#review167485
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 27, 2016, 2:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53146/
> ---
> 
> (Updated Nov. 27, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, Joerg 
> Schad, and Qian Zhang.
> 
> 
> Bugs: MESOS-5786
> https://issues.apache.org/jira/browse/MESOS-5786
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a child hook for switching the user.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess_base.hpp 
> 1d02454d5541f96cb4928bf027fcae3764989d67 
>   3rdparty/libprocess/src/subprocess.cpp 
> 284e22e28ae8d2c1486e4a6bea743b8663ce2023 
> 
> 
> Diff: https://reviews.apache.org/r/53146/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50414: Added variables for building Java Protobuf.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50414/#review167508
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 10, 2016, 7:18 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50414/
> ---
> 
> (Updated Dec. 10, 2016, 7:18 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added protobuf_java external project to 3rdparty.
> This will setup PROTOBUF_JAVA_ROOT at location
> /3rdparty/protobuf_java-2.6.1/src/protobuf_java-2.6.1
> and also define the PROTOBUF_JAR at the location
> ${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> e9eabd08d327f4c714199f7bde91b9adf644a678 
> 
> 
> Diff: https://reviews.apache.org/r/50414/diff/7/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 53926: Move isJailed for FreeBSD into utils.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53926/#review167503
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 20, 2016, 12:42 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53926/
> ---
> 
> (Updated Nov. 20, 2016, 12:42 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-5644
> https://issues.apache.org/jira/browse/MESOS-5644
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Move isJailed for FreeBSD into utils.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/tests/utils.hpp 
> 4e5359c82da4a39d4a7093bbfe95afa14e61f69d 
>   3rdparty/stout/tests/os_tests.cpp f4b9ad71b22b5cc70a412c9a6a3e21da67121e17 
> 
> 
> Diff: https://reviews.apache.org/r/53926/diff/2/
> 
> 
> Testing
> ---
> 
> gmake check on FreeBSD
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 53925: Fix wait macros on FreeBSD.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53925/#review167502
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 19, 2016, 6:17 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53925/
> ---
> 
> (Updated Nov. 19, 2016, 6:17 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-6611
> https://issues.apache.org/jira/browse/MESOS-6611
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix wait macros on FreeBSD.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/gtest.hpp 
> b2f75b6c706df9de68edbac86a1e2dec32a574ed 
> 
> 
> Diff: https://reviews.apache.org/r/53925/diff/1/
> 
> 
> Testing
> ---
> 
> gmake check gets closer to build completion.
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 53606: Added `linux/seccomp` isolator.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53606/#review167493
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 25, 2016, 2:47 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53606/
> ---
> 
> (Updated Nov. 25, 2016, 2:47 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6581
> https://issues.apache.org/jira/browse/MESOS-6581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `linux/seccomp` isolator.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am dd1626d177b38a6613f18f32bb0668abbb5100e0 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 9b33495d9babc3ee489a8712fe1977746c41043f 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/launch.hpp 
> 155e3c5a27b8c710971ee4b508600d3b5589a2e0 
>   src/slave/containerizer/mesos/launch.cpp 
> 320e42748adbabf09f77cb4f5951e2a7ea58fe64 
> 
> 
> Diff: https://reviews.apache.org/r/53606/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 53882: Fix configure on FreeBSD.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53882/#review167499
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 19, 2016, 12:11 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53882/
> ---
> 
> (Updated Nov. 19, 2016, 12:11 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-6607
> https://issues.apache.org/jira/browse/MESOS-6607
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix configure on FreeBSD.
> 
> 
> Diffs
> -
> 
>   configure.ac 5380cbc6a7951ede2f883f7045952a3f3434479e 
> 
> 
> Diff: https://reviews.apache.org/r/53882/diff/2/
> 
> 
> Testing
> ---
> 
> ../configure
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 46229: Add unit tests for adding a user for persistent volumes.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46229/#review167495
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 20, 2016, 4:51 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46229/
> ---
> 
> (Updated Nov. 20, 2016, 4:51 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit tests for adding a user for persistent volumes.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
> 24d1a6971d412aaf7bdc20efcc1197b120de51ce 
>   src/tests/hierarchical_allocator_tests.cpp 
> edd5cea8996d7c616cf9428f0f1c05d70c37c307 
>   src/tests/master_validation_tests.cpp 
> f893067859425967654401f3226149268b51cf57 
>   src/tests/mesos.hpp f94882f44e7fd35f6e9aaa381656af5c5a58ff9e 
>   src/tests/persistent_volume_tests.cpp 
> 8651b2c5455089041f16d091c90a7e0d948191b8 
>   src/tests/resources_tests.cpp d6eb7787bac58c1133a4bab0fc17df49117fed87 
>   src/tests/sorter_tests.cpp 9f48abe65c011acfaf79f3d0d79f1d032fd6a4af 
> 
> 
> Diff: https://reviews.apache.org/r/46229/diff/3/
> 
> 
> Testing
> ---
> 
> All tests passed (including the newly added tests).
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 53931: Don't expect an init process in a FreeBSD jail.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53931/#review167505
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 19, 2016, 7:13 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53931/
> ---
> 
> (Updated Nov. 19, 2016, 7:13 p.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-5645
> https://issues.apache.org/jira/browse/MESOS-5645
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Don't expect an init process in a FreeBSD jail.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os/process_tests.cpp 
> 4cb3b5fab389492bdc1258a27e821e60aef19dc8 
> 
> 
> Diff: https://reviews.apache.org/r/53931/diff/1/
> 
> 
> Testing
> ---
> 
> gmake check
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 53913: Disable sentinel checks for clang on FreeBSD.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53913/#review167501
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 19, 2016, 12:11 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53913/
> ---
> 
> (Updated Nov. 19, 2016, 12:11 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-6610
> https://issues.apache.org/jira/browse/MESOS-6610
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disable sentinel checks for clang on FreeBSD.
> 
> 
> Diffs
> -
> 
>   configure.ac 5380cbc6a7951ede2f883f7045952a3f3434479e 
> 
> 
> Diff: https://reviews.apache.org/r/53913/diff/1/
> 
> 
> Testing
> ---
> 
> gmake on FreeBSD.
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 53927: Check isJailed in tests that call mknod.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53927/#review167504
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 19, 2016, 6:45 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53927/
> ---
> 
> (Updated Nov. 19, 2016, 6:45 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-6612 and MESOS-6613
> https://issues.apache.org/jira/browse/MESOS-6612
> https://issues.apache.org/jira/browse/MESOS-6613
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check isJailed in tests that call mknod.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os/rmdir_tests.cpp 
> 9aa4059d589e84f3c377163b1d6d2a278d4130b6 
>   3rdparty/stout/tests/os_tests.cpp f4b9ad71b22b5cc70a412c9a6a3e21da67121e17 
> 
> 
> Diff: https://reviews.apache.org/r/53927/diff/1/
> 
> 
> Testing
> ---
> 
> gmake check
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 53695: Allows caching extractable files when outputFile is set.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53695/#review167494
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 28, 2016, 7:14 p.m., Stephen Hankinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53695/
> ---
> 
> (Updated Nov. 28, 2016, 7:14 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6587
> https://issues.apache.org/jira/browse/MESOS-6587
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allows caching extractable files when outputFile is set.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f 
>   src/tests/fetcher_cache_tests.cpp 03e817d46194d451eceb70f4cebb54dfdcb4c2e7 
> 
> 
> Diff: https://reviews.apache.org/r/53695/diff/2/
> 
> 
> Testing
> ---
> 
> A new test, FetcherCacheTest.LocalCachedExtractCustomOutputFile, was created 
> to confirm that when a URI is created with cached: true, extract: true, a 
> custom outputFile with a proper compression suffix set, and an original URI 
> that doesn't end with a proper compression suffix fails to extract properly 
> from the cache.
> 
> The test makes a copy of the test archive in the cache but appends "misc" to 
> the end, forming an invalid compression suffix, causing 
> mesos-fetcher-test-archive.tgz to become mesos-fetcher-test-archive.tgzmisc. 
> The URI path is set to this modified location. The outputFile of the URI is 
> set ARCHIVE_NAME which ends with a valid compression suffix, so therefore 
> should extract properly.
> 
> At the end of the test the temporary cached archive file 
> (mesos-fetcher-test-archive.tgzmisc) is deleted.
> 
> Before the patch was written this test was failing as expected. After 
> implementing the patch, this and all other tests were passing.
> 
> 
> Thanks,
> 
> Stephen Hankinson
> 
>

Re: Review Request 54084: Made public Mesos header standalone.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54084/#review167482
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 25, 2016, 4:53 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54084/
> ---
> 
> (Updated Nov. 25, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Missing includes were found by attempting to parse the header files
> standalone with
> 
> $ clang++ -fsyntax-only -I  HEADER_FILE.hpp
> 
> By fixing failures we can make sure that all required symbols are
> defined.
> 
> Note this change does not address the issue of transitive includes.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.hpp e9430df03b49f49d367e19b18991ead77fe5b830 
>   include/mesos/executor/executor.hpp 
> 598d0106fe6c166507bde2bddfd7bed8d544da5a 
> 
> 
> Diff: https://reviews.apache.org/r/54084/diff/1/
> 
> 
> Testing
> ---
> 
> make check (OS X, clang trunk w/o optimizations, SSL)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 53119: Moved `ns.hpp` to stout [1/2].

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53119/#review167483
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 27, 2016, 10:45 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53119/
> ---
> 
> (Updated Nov. 27, 2016, 10:45 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, and 
> Qian Zhang.
> 
> 
> Bugs: MESOS-6236
> https://issues.apache.org/jira/browse/MESOS-6236
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved `ns.hpp` to stout [1/2].
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am d5bc728ce378586e84173b98499b0d52047a83e1 
>   3rdparty/stout/include/stout/ns.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/53119/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50010: Added example framework for handling inverse offers.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50010/#review167479
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Sept. 16, 2016, 9:35 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50010/
> ---
> 
> (Updated Sept. 16, 2016, 9:35 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Kevin Klues.
> 
> 
> Bugs: MESOS-5827
> https://issues.apache.org/jira/browse/MESOS-5827
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This framework shows how one might handle inverse offers by launching
> persistent sleep tasks and migrating them ahead of planned maintenance.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 44fd8a216eb70d806f74b6f6acff69a2e55b7ede 
>   src/examples/inverse_offer_framework.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/50010/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> TODO: Add a helper binary for generating random maintenance schedules.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 53147: Made health check run under the same user with tasks.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53147/#review167486
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 27, 2016, 2:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53147/
> ---
> 
> (Updated Nov. 27, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, Joerg 
> Schad, and Qian Zhang.
> 
> 
> Bugs: MESOS-5786
> https://issues.apache.org/jira/browse/MESOS-5786
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made health check run under the same user with tasks.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 94e116f06c0c729a90e5424c37edc39c7ba4cbe6 
>   src/health-check/health_checker.hpp 
> 1230f963a98cd9a373d98cb6f67eb1b7e89c823d 
>   src/health-check/health_checker.cpp 
> c0d150a014b7debf23b58982efe335a189d32c7b 
>   src/launcher/default_executor.cpp 6e377d41065a03d5c9ca794c0b998a233c52428b 
>   src/launcher/executor.cpp cd5aa46df49b8cc352bf679a5cf2aac3d043f87d 
> 
> 
> Diff: https://reviews.apache.org/r/53147/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 53120: Moved `ns.hpp` to stout [2/2].

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53120/#review167487
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 27, 2016, 4 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53120/
> ---
> 
> (Updated Nov. 27, 2016, 4 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, and 
> Qian Zhang.
> 
> 
> Bugs: MESOS-6236
> https://issues.apache.org/jira/browse/MESOS-6236
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved `ns.hpp` to stout [2/2].
> 
> 
> Diffs
> -
> 
>   src/Makefile.am dd1626d177b38a6613f18f32bb0668abbb5100e0 
>   src/health-check/health_checker.cpp 
> c0d150a014b7debf23b58982efe335a189d32c7b 
>   src/linux/ns.hpp 77789717eb0f6feab72c39febdd1fc432c633841 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 8f024d084189b59bb229c63d20108e7bfe42065f 
>   src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 
> d16b42f2231ba2e7779e798efe05e2bbd20dfac9 
>   src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 
> 5bf5ffbceed1229fad35ca94f42b93c097152fe5 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 3b2d4db325b23a13fa0c1a4035f309816de181fd 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> a994adf78898b0e55ced8a2214287a97edc16d38 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
> 6f7304d4aa40eb1b4815ffc1fec61f7e98291cba 
>   src/slave/containerizer/mesos/launch.cpp 
> 320e42748adbabf09f77cb4f5951e2a7ea58fe64 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> a3409dc64435e002072b9b458a5fda0564214f28 
>   src/slave/containerizer/mesos/utils.cpp 
> 4e2a01495909c07f320af416ff4dc59f7328c710 
>   src/tests/containerizer/isolator_tests.cpp 
> 9766aaf144722b18d88f694ff37ffd53974cb60d 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> 6c341e14cc383410baa76ea8eea294c627d1c028 
>   src/tests/containerizer/ns_tests.cpp 
> d6be1076a393f7959cd6ac225591c8b3aa66721d 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 79b0a60c48a81c2f868d361ca07373bf3c2a8477 
>   src/tests/containerizer/setns_test_helper.cpp 
> 045caf684baf6e724fa5f99b6cc3feeb87817ba3 
> 
> 
> Diff: https://reviews.apache.org/r/53120/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 53123: Made `process::defaultClone` private.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53123/#review167490
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 27, 2016, 4:10 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53123/
> ---
> 
> (Updated Nov. 27, 2016, 4:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, and 
> Qian Zhang.
> 
> 
> Bugs: MESOS-6184
> https://issues.apache.org/jira/browse/MESOS-6184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made `process::defaultClone` private.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp 
> aa4609d9e4c63f824c8cd631f39bbbe71e4f67b4 
> 
> 
> Diff: https://reviews.apache.org/r/53123/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50599/#review167472
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 16, 2016, 3:29 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50599/
> ---
> 
> (Updated Nov. 16, 2016, 3:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Assigned Nvidia GPU devices to docker container based on
> GPUs allocated by Nvidia GPU allocator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 006f929eca0e0a6b1de941821ac72869ba393d2d 
>   src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
> 
> 
> Diff: https://reviews.apache.org/r/50599/diff/22/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 46227: Added an user to indicate owner of persistent volume.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46227/#review167476
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 20, 2016, 4:50 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46227/
> ---
> 
> (Updated Nov. 20, 2016, 4:50 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a persistent volume is created, it is created with the user
> indicated in Resource::DiskInfo::Persistence. If missing, it would
> fall back to make the user of the mesos-slave process as the owner
> of the persistent volume.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 380575904a5a29ee53bdc87ae8791ed14e3cafca 
>   include/mesos/v1/mesos.proto 5b542ff9cd0b5f301c088d3f4b2fe17ae760d368 
> 
> 
> Diff: https://reviews.apache.org/r/46227/diff/4/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 52980: Updated os::mkdir() to take the mode as an input.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52980/#review167477
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 20, 2016, 4:50 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52980/
> ---
> 
> (Updated Nov. 20, 2016, 4:50 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mode still defaults to 755, but we now enable the caller to specify
> a different mode for creation of directories.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/mkdir.hpp 
> fe86864c8b480993c8f052f39b2fd3ece23798da 
> 
> 
> Diff: https://reviews.apache.org/r/52980/diff/2/
> 
> 
> Testing
> ---
> 
> Tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 50125: Added `--devices` flag to mesos-docker-executor.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50125/#review167473
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 16, 2016, 3:29 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50125/
> ---
> 
> (Updated Nov. 16, 2016, 3:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new flag `--devices` to mesos-docker-executor which is
> used to control the feature of devices exposition, isolation
> and access permission for docker container.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 
>   src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 
> 
> 
> Diff: https://reviews.apache.org/r/50125/diff/22/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 50496: Added pid group module to `createPIDGroup` method.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50496/#review167460
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 3:40 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50496/
> ---
> 
> (Updated Nov. 14, 2016, 3:40 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
> https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added logic to create a pid group module from module manager to
> the `createPIDGroup` method.
> 
> 
> Diffs
> -
> 
>   src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 
>   src/log/log.cpp 2301eef564f2a42958c6c2c8eef0cc4b2fd76353 
> 
> 
> Diff: https://reviews.apache.org/r/50496/diff/6/
> 
> 
> Testing
> ---
> 
> see end of review chain.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 53702: Added a factory method to produce PIDGroup.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53702/#review167462
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 4:01 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53702/
> ---
> 
> (Updated Nov. 14, 2016, 4:01 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
> https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In the case of PIDGroup module, base pid may not be available at
> construction time, so base pid needs to be initialized after PIDGroup
> construction, but before PIDGroup being passed to LogProcess
> constructor, since PIDGroup is a const member in the form of Shared<>.
> Therefore, a factory method `createPIDGroup` is added to LogProcess.
> 
> To unify the implementation, we refactor ZooKeeperPIDGroup to be
> created by factory method as well. This is step toward modularizing
> PIDGroup interfaces.
> 
> 
> Diffs
> -
> 
>   src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 
>   src/log/log.cpp 2301eef564f2a42958c6c2c8eef0cc4b2fd76353 
>   src/log/pid_group/zookeeper.hpp PRE-CREATION 
>   src/log/pid_group/zookeeper.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/53702/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 50498: Added --master_pid_group flag in master.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50498/#review167463
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 4:03 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50498/
> ---
> 
> (Updated Nov. 14, 2016, 4:03 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5829
> https://issues.apache.org/jira/browse/MESOS-5829
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added --master_pid_group flag to pass in pid_group module name.
> Necessary validation logic is added to master/main.cpp.
> 
> 
> Diffs
> -
> 
>   src/master/flags.hpp 6a17b763dc76daa10073394f416b049e97a44238 
>   src/master/flags.cpp 9bfb40e22820c3ced40b128280ec63288fea8b41 
>   src/master/main.cpp 2d2dfb7d632f3c7be1796efd8f0a1f4d18760261 
> 
> 
> Diff: https://reviews.apache.org/r/50498/diff/6/
> 
> 
> Testing
> ---
> 
> see end of review chain.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 50128: Overloaded the << operator for `Docker::Device`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50128/#review167469
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 16, 2016, 3:25 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50128/
> ---
> 
> (Updated Nov. 16, 2016, 3:25 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch overloaded the `<<` operator for `Docker::Device`.
> With such overload, we can just run the global `stringify()`
> function to turn `Docker::Device` into a string.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
>   src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e 
> 
> 
> Diff: https://reviews.apache.org/r/50128/diff/24/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 53532: Added `parse` helper function for `Docker::Device`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53532/#review167471
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 16, 2016, 3:28 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53532/
> ---
> 
> (Updated Nov. 16, 2016, 3:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new helper function to parse a string to `Docker::Device`
> structure. The string should be in the format of
> `PathInHost:PathInContainer:Permission`.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
> 
> 
> Diff: https://reviews.apache.org/r/53532/diff/3/
> 
> 
> Testing
> ---
> 
> make -j4 check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 50838: Updated modules documentation to reflect PIDGroup module.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50838/#review167467
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 4:06 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50838/
> ---
> 
> (Updated Nov. 14, 2016, 4:06 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
> https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated modules documentation to reflect PIDGroup module.
> 
> 
> Diffs
> -
> 
>   docs/modules.md 701b01fb08d85a1f65adaade2162f8ee787916ae 
> 
> 
> Diff: https://reviews.apache.org/r/50838/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 50947: Only check `gpu/nvidia` isolator for mesos containerizer.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50947/#review167470
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 16, 2016, 3:28 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50947/
> ---
> 
> (Updated Nov. 16, 2016, 3:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Bugs: MESOS-5975
> https://issues.apache.org/jira/browse/MESOS-5975
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos containerizer uses isolator `gpu/nvidia` for GPU isolation while
> docker containerizers do not need it. This patch is making the isolator
> `gpu/nvidia` check only available for mesos containerizer but not docker
> containerizer in GPU allocator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 
> 2e722691475c84afae14009014ea70cc0fdd0e65 
> 
> 
> Diff: https://reviews.apache.org/r/50947/diff/19/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 53533: Extended `dockerFlags()` to pass `devices` to mesos-docker-executor.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53533/#review167474
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 16, 2016, 3:29 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53533/
> ---
> 
> (Updated Nov. 16, 2016, 3:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch extended `dockerFlags()` to pass `devices` to
> mesos-docker-executor, and then the `devices` can be used
> by the docker container when mesos-docker-executor starts
> the docker container.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
> 
> 
> Diff: https://reviews.apache.org/r/53533/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 53701: Renamed `group` in ZooKeeperPIDGroup to `observer`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53701/#review167465
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 4:07 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53701/
> ---
> 
> (Updated Nov. 14, 2016, 4:07 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
> https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since ZooKeeperPIDGroup now holds two `group` objects, more
> expressive names are assigned. Also some methods are refactored
> to leverage error handlers in case of onFailed/onDiscarded.
> 
> 
> Diffs
> -
> 
>   src/log/pid_group/zookeeper.hpp PRE-CREATION 
>   src/log/pid_group/zookeeper.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/53701/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 52735: Updated comments for killing some garbage containers.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52735/#review167468
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 16, 2016, 3:25 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52735/
> ---
> 
> (Updated Nov. 16, 2016, 3:25 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We have already enabled `Garbage collector` for some garbage
> containers (failed to be killed when destroy), so the related
> comments should be updated to reflect this.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
> 
> 
> Diff: https://reviews.apache.org/r/52735/diff/11/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 50493: Added `base` to PIDGroup.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50493/#review167466
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 3:33 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50493/
> ---
> 
> (Updated Nov. 14, 2016, 3:33 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
> https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> All subclasses derived from PIDGroup are required to have `base`
> as a set of PIDs that always exist from the beginning. Therefore
> `base` is refactored into PIDGroup base class. This is a step
> towards modularizing replicated_log's PIDGroup abstraction.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/pid_group.hpp PRE-CREATION 
>   3rdparty/libprocess/src/pid_group.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/50493/diff/5/
> 
> 
> Testing
> ---
> 
> see end of review chain
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 50497: Added new constructors in Log and LogProcess.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50497/#review167461
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 3:40 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50497/
> ---
> 
> (Updated Nov. 14, 2016, 3:40 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
> https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These constructors take moduleNames as parameter and create
> corresponding PIDGroup module while constructing LogProcess.
> 
> 
> Diffs
> -
> 
>   include/mesos/log/log.hpp d92d7a0b982c1c4bc0fdedde19fe012a6523a224 
>   src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 
>   src/log/log.cpp 2301eef564f2a42958c6c2c8eef0cc4b2fd76353 
> 
> 
> Diff: https://reviews.apache.org/r/50497/diff/5/
> 
> 
> Testing
> ---
> 
> see end of review chain.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 50499: Added logic in master/main.cpp to use pid_group module.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50499/#review167464
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 4:04 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50499/
> ---
> 
> (Updated Nov. 14, 2016, 4:04 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5829
> https://issues.apache.org/jira/browse/MESOS-5829
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added logic in master/main.cpp to use pid_group module.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp 2d2dfb7d632f3c7be1796efd8f0a1f4d18760261 
> 
> 
> Diff: https://reviews.apache.org/r/50499/diff/6/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Jay Guo
> 
>