Re: Review Request 67596: Fixed the flakiness in the `NVIDIA_GPU_NvidiaDockerImage` test.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67596/#review204759
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67596']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67596

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67596/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (116 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1071 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (35 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (40 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (77 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (948 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (972 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (947 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (980 ms total)

[--] Global test environment tear-down
[==] 988 tests from 97 test cases ran. (499224 ms total)
[  PASSED  ] 987 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SlaveTest.RestartSlaveRequireExecutorAuthentication

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67596/logs/mesos-tests-stderr.log):

```
I0614 05:15:00.428949  7368 slave.cpp:3939] Shutting down framework 
f9a51d4a-3627-4a63-88a1-3dabd4550477-
I0614 05:15:00.428949  7368 slave.cpp:6660] Shutting down executor 
'e7c13234-6d2f-4a58-959b-25de9b872617' of framework 
f9a51d4a-3627-4a63-88a1-3dabd4550477- at executor(1)@192.10.1.5:65477
I0614 05:15:00.430958  7368 slave.cpp:931] Agent terminating
W0614 05:15:00.430958  7368 slave.cpp:3935] Ignoring shutdown framework 
f9a51d4a-3627-4a63-88a1-3dabd4550477- because it is terminating
I0614 05:15:00.431969  9044 master.cpp:10962] Removing task 
e7c13234-6d2f-4a58-959b-25de9b872617 with resources cpus(allocated: *):4; 
mem(allocated: *):204I0614 05:15:00.155944  6992 exec.cpp:162] Version: 1.7.0
I0614 05:15:00.181944  9176 exec.cpp:236] Executor registered on agent 
f9a51d4a-3627-4a63-88a1-3dabd4550477-S0
I0614 05:15:00.186944  8916 executor.cpp:178] Received SUBSCRIBED event
I0614 05:15:00.191944  8916 executor.cpp:182] Subscribed executor on 
windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0614 05:15:00.191944  8916 executor.cpp:178] Received LAUNCH event
I0614 05:15:00.196947  8916 executor.cpp:665] Starting task 
e7c13234-6d2f-4a58-959b-25de9b872617
I0614 05:15:00.280943  8916 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0614 05:15:00.393949  8916 executor.cpp:678] Forked command at 872
I0614 05:15:00.431969  7660 exec.cpp:445] Executor asked to shutdown
I0614 05:15:00.433944  8916 executor.cpp:178] Received SHUTDOWN event
I0614 05:15:00.433944  8916 executor.cpp:781] Shutting down
I0614 05:15:00.433944  8916 executor.cpp:894] Sending SIGTERM to process tree 
at pid 872
8; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 
f9a51d4a-3627-4a63-88a1-3dabd4550477- on agent 
f9a51d4a-3627-4a63-88a1-3dabd4550477-S0 at slave(449)@192.10.1.5:65456 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0614 05:15:00.437954  9044 master.cpp:1293] Agent 
f9a51d4a-3627-4a63-88a1-3dabd4550477-S0 at slave(449)@192.10.1.5:65456 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0614 05:15:00.437954  9044 master.cpp:3303] Disconnecting agent 
f9a51d4a-3627-4a63-88a1-3dabd4550477-S0 at slave(449)@192.10.1.5:65456 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0614 05:15:00.437954  9044 master.cpp:3322] Deactivating agent 
f9a51d4a-3627-4a63-88a1-3dabd4550477-S0 at slave(449)@192.10.1.5:65456 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0614 05:15:00.438943  4204 containerizer.cpp:2405] Destroying container 
a485ff4d-78d0-4d1a-ac6d-0921e2270d50 in RUNNING state
I0614 05:15:00.438943  5712 hierarchical.cpp:344] Removed framework 
f9a51d4a-3627-4a63-88a1-3dabd4550477-
I0614 05:15:00.438943  4204 

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/#review204756
---



FAIL: Failed to apply the dependent review: 67335.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67335`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67381

Relevant logs:

- 
[apply-review-67335-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67381/logs/apply-review-67335-stdout.log):

```
error: patch failed: docs/configuration/agent.md:967
error: docs/configuration/agent.md: patch does not apply
```

- Mesos Reviewbot Windows


On June 14, 2018, 1:41 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67381/
> ---
> 
> (Updated June 14, 2018, 1:41 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `cgroups/all` into CHANGELOG and upgrades.md.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0c45af66cbe1c6feede328143d30dad4eaf1a4b3 
>   docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f 
> 
> 
> Diff: https://reviews.apache.org/r/67381/diff/4/
> 
> 
> Testing
> ---
> 
> Not a code change.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67561: Refactored `struct Slave` in the allocator for better performance.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67561/#review204755
---



PASS: Mesos patch 67561 was successfully built and tested.

Reviews applied: `['67561']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67561

- Mesos Reviewbot Windows


On June 13, 2018, 11:36 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67561/
> ---
> 
> (Updated June 13, 2018, 11:36 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, Kapil Arya, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-8986
> https://issues.apache.org/jira/browse/MESOS-8986
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch refactors the `struct Slave` in the allocator.
> In particular, it addresses the slowness of computing
> agent's available resources. Instead of calculating it
> every time on the fly, this patch "denormalizes" the agent
> available resources by updating and persisting the field
> each time when agent's allocated or total resources change.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> e9d1742bb35004735e3cb357286b4e5b17436a5c 
>   src/master/allocator/mesos/hierarchical.cpp 
> b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c 
> 
> 
> Diff: https://reviews.apache.org/r/67561/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> In our simulation environment, we observed 16% allocator performance 
> improvment without quota, and 32% improvment when quota is used.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 67596: Fixed the flakiness in the `NVIDIA_GPU_NvidiaDockerImage` test.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67596/
---

Review request for mesos, Jie Yu, Joseph Wu, and Kevin Klues.


Bugs: MESOS-6622
https://issues.apache.org/jira/browse/MESOS-6622


Repository: mesos


Description
---

This test is flaky because it tries to download the 1GB 'nvidia/cuda'
image from Docker Hub, which might take more than 1 minute and cause
the command executor unable to register in time.

This patch fixes this problem by using the default executor, which does
not wait for fetching task images before registration. If the image
fetch stalls (i.e. makes no progress) more than 1 minute, the container
will fail because of the `--fetcher_stall_timeout` agent flag.

The time we wait for `TASK_FINISHED` is also extended to 180 seconds.


Diffs
-

  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
d8c3e6d08a70bd129d8ac9c336be7a2bf7a4b0b2 


Diff: https://reviews.apache.org/r/67596/diff/1/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 67591: Improving the accuracy of this failure message.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67591/#review204753
---



PASS: Mesos patch 67591 was successfully built and tested.

Reviews applied: `['67591']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67591

- Mesos Reviewbot Windows


On June 13, 2018, 11:31 p.m., he yi hua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67591/
> ---
> 
> (Updated June 13, 2018, 11:31 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improving the accuracy of this failure message.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp a04f71db019ae15f278c158fd0f499fb4b360e91 
> 
> 
> Diff: https://reviews.apache.org/r/67591/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> he yi hua
> 
>

Re: Review Request 67587: Updated ZooKeeper retry logic to retry on `ENOENT` too.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67587/#review204749
---



PASS: Mesos patch 67587 was successfully built and tested.

Reviews applied: `['67587']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67587

- Mesos Reviewbot Windows


On June 13, 2018, 10:30 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67587/
> ---
> 
> (Updated June 13, 2018, 10:30 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Neil Conway.
> 
> 
> Bugs: MESOS-3790
> https://issues.apache.org/jira/browse/MESOS-3790
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per MESOS-3790, the call to `zookeeper_init` maps `EAI_NONAME` and
> `EAI_NODATA` to an `errno` value of `ENOENT`, and all others except
> `EAI_MEMORY` to `EINVAL`. Mesos's ZooKeeper logic is written to retry
> this initialization for ten minutes if the error is `EINVAL`, and
> should be updated to also retry if the error is `ENOENT`.
> 
> This is necessary because if the initialization is not retried, the
> process crashes due to the `PLOG(FATAL)` call, and if it crashes, it
> will interrupt other Mesos threads and potentially leave the
> environment in an unknown state. For instance, we have seen
> intermittent failures where the systemd unit file
> `mesos_executors.slice` is created but empty because Mesos crashed
> between creating the file and flushing the write to the file. This
> then leads to errors when the agent is restarted (and succeeds to
> connect to ZooKeeper), because the agent explicitly does not attempt
> to write to the unit file if it already exists.
> 
> 
> Diffs
> -
> 
>   src/zookeeper/zookeeper.cpp 52c4af192ccd1361afc4f7a0041889238c01e674 
> 
> 
> Diff: https://reviews.apache.org/r/67587/diff/1/
> 
> 
> Testing
> ---
> 
> Testing against our repro right now, but it's flaky, so it'll take a while.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67594: Improve the debug logging in mesos container

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67594/#review204751
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67594']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67594

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67594/logs/mesos-tests-stdout.log):

```
[ RUN  ] SlaveTest.ResourceVersions
[   OK ] SlaveTest.ResourceVersions (191 ms)
[ RUN  ] SlaveTest.ReconfigurationPolicy
[   OK ] SlaveTest.ReconfigurationPolicy (287 ms)
[ RUN  ] SlaveTest.ResourceProviderReconciliation
[   OK ] SlaveTest.ResourceProviderReconciliation (339 ms)
[ RUN  ] SlaveTest.RunTaskResourceVersions
[   OK ] SlaveTest.RunTaskResourceVersions (277 ms)
[--] 83 tests from SlaveTest (64528 ms total)

[--] 3 tests from SlaveStateTest
[ RUN  ] SlaveStateTest.CheckpointString
[   OK ] SlaveStateTest.CheckpointString (3 ms)
[ RUN  ] SlaveStateTest.CheckpointProtobufMessage
[   OK ] SlaveStateTest.CheckpointProtobufMessage (8 ms)
[ RUN  ] SlaveStateTest.CheckpointRepeatedProtobufMessages
[   OK ] SlaveStateTest.CheckpointRepeatedProtobufMessages (9 ms)
[--] 3 tests from SlaveStateTest (23 ms total)

[--] 30 tests from SlaveRecoveryTest/0, where TypeParam = class 
mesos::internal::slave::MesosContainerizer
[ RUN  ] SlaveRecoveryTest/0.RecoverSlaveState
[   OK ] SlaveRecoveryTest/0.RecoverSlaveState (838 ms)
[ RUN  ] SlaveRecoveryTest/0.RecoverTaskStatusUpdateManager
[   OK ] SlaveRecoveryTest/0.RecoverTaskStatusUpdateManager (3103 ms)
[ RUN  ] SlaveRecoveryTest/0.ReconnectExecutor
[   OK ] SlaveRecoveryTest/0.ReconnectExecutor (3545 ms)
[ RUN  ] SlaveRecoveryTest/0.ReconnectExecutorRetry
[   OK ] SlaveRecoveryTest/0.ReconnectExecutorRetry (843 ms)
[ RUN  ] SlaveRecoveryTest/0.PingTimeoutDuringRecovery
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67594/logs/mesos-tests-stderr.log):

```
@   7FF7EA2EB317  google::LogMessage::Flush
@   7FF7EA2ECE51  google::LogMessageFatal::~LogMessageFatal
@   7FF7E81A3183  mesos::internal::slave::Slave::detected
@   7FF7E83AB4E7   ?? 
@   7FF7E8269958  
std::_Invoker_functor::_Call<,process::Future
 >,process::ProcessBase *>
@   7FF7E82FD3C8  
std::invoke<,process::Future
 >,process::ProcessBase *>
@   7FF7E83120BB  
lambda::internal::Partial<,process::Future
 >,std::_Ph<1> 
>::invoke_expand<,std::tuple
 >,std::_Ph<1> >,st
@   7FF7E82403FA  ),process::Future
 >,std::_Ph<1> >,process::ProcessBase *>
@   7FF7E83039FC  
std::invoke,process::Future
 >,std::_Ph<1> >,process::ProcessBase *>
@   7FF7E8249A61  
),process::Future
 >,std::_Ph<1> >,process::ProcessBase *
@   7FF7E83B5F56  process::ProcessBase 
*)>::CallableFn,process::Future
 >,std::_Ph<1> > >::operator(
@   7FF7E9D9EAED  process::ProcessBase *)>::operator(
@   7FF7E9C4FB89  process::ProcessBase::consume
@   7FF7E9DF815A  process::DispatchEvent::consume
@   7FF7E5E679A7  process::ProcessBase::serve
@   7FF7E9C5DC40  process::ProcessManager::resume
@   7FF7E9D8BC01   ?? 
@   7FF7E9CAF9C0  
std::_Invoker_functor::_Call< >
@   7FF7E9D10170  std::invoke< 
>
@   7FF7E9CC4FFC  
std::_LaunchPad
 >,std::default_delete > > 
> >::_Execute<0>
@   7FF7E9DDEE9A  
std::_LaunchPad
 >,std::default_delete > > 
> >::_Run
@   7FF7E9DCA708  
std::_LaunchPad
 >,std::default_delete > > 
> >::_Go
@   7FF7E9DB0C5D  std::_Pad::_Call_func
@   7FFC6B813428  _register_onexit_function
@   7FFC6B813071  _register_onexit_function
@   7FFC803A1FE4  BaseThreadInitThunk
@   7FFC821BF061  RtlUserThreadStart
80 slave.cpp:1249] Check failed: state == DISCONNECTED || state == RUNNING || 
state == TERMINATING RECOVERING
```

- Mesos Reviewbot Windows


On June 14, 2018, 12:35 a.m., CHEN RUNCONG wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67594/
> ---
> 
> (Updated June 14, 2018, 12:35 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8423
> https://issues.apache.org/jira/browse/MESOS-8423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improve the debug logging in mesos container
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 17a1a3762b2012ff875e4da9c9d4622514e48051 
> 
> 
> Diff: 

Re: Review Request 65875: Improved logging for offers and inverse offers.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/#review204750
---



PASS: Mesos patch 65875 was successfully built and tested.

Reviews applied: `['65995', '65975', '65976', '65640', '65875']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65875

- Mesos Reviewbot Windows


On June 14, 2018, 12:22 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65875/
> ---
> 
> (Updated June 14, 2018, 12:22 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Printed offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 
> 
> 
> Diff: https://reviews.apache.org/r/65875/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

[Chun-Hung Hsiao]

> On April 20, 2018, 1:39 p.m., Benjamin Bannier wrote:
> > LGTM, but I wonder whether it would make sense to keep the assertions and 
> > reject outdated resources more generally based on e.g., resource versions.
> 
> Chun-Hung Hsiao wrote:
> Hmm good point. I thought about it a bit.
> I changed these assertions for accepted pending operations, which we have 
> already verified the resource versions.
> The current update logic is the following.
> 
> When SLRP receives changes in the set of known profiles:
> 1. Query the disk profile adaptor to update the ProfileInfo for each 
> profile.
> 2. Wait for all related pending operations to finish. Some of them may 
> want to use outdated profiles.
> 3. Reconcile the storage pool.
> 
> If we want to keep the assertion, the logic would look like the following.
> 
> When SLRP receives changes in the set of known profiles:
> 1. Wait for all related operations to finish. They are allowed to use the 
> outdated profiles, so new volumes with those profiles might be created 
> successfully.
> 2. Query the disk profile adaptor to update the ProfileInfo for each 
> profile.
> 3. Reconcile the storage pool.
> 
> Personally I prefer the former, since it doesn't make sense to create new 
> volumes for old profiles.

Hmm I took anotther look at the code and you're probably right that we don't 
need to remove the assertions since these checks are done synchronously when 
SLRP accepts the operations. Let me work on a unit test to to ensure that.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65976/#review201631
---


On June 14, 2018, 12:07 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65976/
> ---
> 
> (Updated June 14, 2018, 12:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8825
> https://issues.apache.org/jira/browse/MESOS-8825
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed profiles to be missing from `DiskProfileAdaptor`.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> b90a4b81838fec410a97a10ce44a811bb81c87eb 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp 
> 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7 
> 
> 
> Diff: https://reviews.apache.org/r/65976/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/
---

(Updated June 14, 2018, 9:41 a.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description
---

Added `cgroups/all` into CHANGELOG and upgrades.md.


Diffs (updated)
-

  CHANGELOG 0c45af66cbe1c6feede328143d30dad4eaf1a4b3 
  docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f 


Diff: https://reviews.apache.org/r/67381/diff/4/

Changes: https://reviews.apache.org/r/67381/diff/3-4/


Testing
---

Not a code change.


Thanks,

Qian Zhang

Re: Review Request 67590: Added a dedicated benchmark for range resources.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67590/#review204747
---



PASS: Mesos patch 67590 was successfully built and tested.

Reviews applied: `['67590']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67590

- Mesos Reviewbot Windows


On June 13, 2018, 4:28 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67590/
> ---
> 
> (Updated June 13, 2018, 4:28 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8989
> https://issues.apache.org/jira/browse/MESOS-8989
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> Also removed the current range benchmark which could produce
> misleading results for subtraction (See MESOS-8989).
> 
> 
> Diffs
> -
> 
>   src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1 
> 
> 
> Diff: https://reviews.apache.org/r/67590/diff/1/
> 
> 
> Testing
> ---
> 
> Ran on a multicore machine with peak frequency at 2.2GHz:
> 
> Took 25.435531ms to perform 1000 'a += b' operations on ports:[1-6, 11-16, 
> 21-26... and ports:[3-8, 13-18, 23-28... with size 10
> Took 76.104895ms to perform 1000 'a -= b' operations on ports:[1-6, 11-16, 
> 21-26... and ports:[3-8, 13-18, 23-28... with size 10
> Took 28.66989ms to perform 1000 'a + b' operations on ports:[1-6, 11-16, 
> 21-26... and ports:[3-8, 13-18, 23-28... with size 10
> Took 79.937531ms to perform 1000 'a - b' operations on ports:[1-6, 11-16, 
> 21-26... and ports:[3-8, 13-18, 23-28... with size 10
> 
> Took 360.16389ms to perform 1000 'a += b' operations on ports:[1-6, 11-16, 
> 21-26... and ports:[3-8, 13-18, 23-28... with size 100
> Took 812.057397ms to perform 1000 'a -= b' operations on ports:[1-6, 11-16, 
> 21-26... and ports:[3-8, 13-18, 23-28... with size 100
> Took 298.568732ms to perform 1000 'a + b' operations on ports:[1-6, 11-16, 
> 21-26... and ports:[3-8, 13-18, 23-28... with size 100
> Took 799.168596ms to perform 1000 'a - b' operations on ports:[1-6, 11-16, 
> 21-26... and ports:[3-8, 13-18, 23-28... with size 100
> 
> Took 5.499557097secs to perform 1000 'a += b' operations on ports:[1-6, 
> 11-16, 21-26... and ports:[3-8, 13-18, 23-28... with size 1000
> Took 10.80984876secs to perform 1000 'a -= b' operations on ports:[1-6, 
> 11-16, 21-26... and ports:[3-8, 13-18, 23-28... with size 1000
> Took 5.105380254secs to perform 1000 'a + b' operations on ports:[1-6, 11-16, 
> 21-26... and ports:[3-8, 13-18, 23-28... with size 1000
> Took 11.025490666secs to perform 1000 'a - b' operations on ports:[1-6, 
> 11-16, 21-26... and ports:[3-8, 13-18, 23-28... with size 1000
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 67594: Improve the debug logging in mesos container

[CHEN RUNCONG]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67594/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-8423
https://issues.apache.org/jira/browse/MESOS-8423


Repository: mesos


Description
---

Improve the debug logging in mesos container


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
17a1a3762b2012ff875e4da9c9d4622514e48051 


Diff: https://reviews.apache.org/r/67594/diff/1/


Testing
---


Thanks,

CHEN RUNCONG

Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

[CHEN RUNCONG]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67585/
---

(Updated 六月 14, 2018, 12:34 a.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-6092
https://issues.apache.org/jira/browse/MESOS-6092


Repository: mesos


Description
---

Fixed the issue:if the container is destroyed in the mean time, then we will 
potentially segfault here.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be 


Diff: https://reviews.apache.org/r/67585/diff/2/

Changes: https://reviews.apache.org/r/67585/diff/1-2/


Testing
---


Thanks,

CHEN RUNCONG

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

[Chun-Hung Hsiao]

> On April 20, 2018, 1:39 p.m., Benjamin Bannier wrote:
> > LGTM, but I wonder whether it would make sense to keep the assertions and 
> > reject outdated resources more generally based on e.g., resource versions.

Hmm good point. I thought about it a bit.
I changed these assertions for accepted pending operations, which we have 
already verified the resource versions.
The current update logic is the following.

When SLRP receives changes in the set of known profiles:
1. Query the disk profile adaptor to update the ProfileInfo for each profile.
2. Wait for all related pending operations to finish. Some of them may want to 
use outdated profiles.
3. Reconcile the storage pool.

If we want to keep the assertion, the logic would look like the following.

When SLRP receives changes in the set of known profiles:
1. Wait for all related operations to finish. They are allowed to use the 
outdated profiles, so new volumes with those profiles might be created 
successfully.
2. Query the disk profile adaptor to update the ProfileInfo for each profile.
3. Reconcile the storage pool.

Personally I prefer the former, since it doesn't make sense to create new 
volumes for old profiles.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65976/#review201631
---


On June 14, 2018, 12:07 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65976/
> ---
> 
> (Updated June 14, 2018, 12:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8825
> https://issues.apache.org/jira/browse/MESOS-8825
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed profiles to be missing from `DiskProfileAdaptor`.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> b90a4b81838fec410a97a10ce44a811bb81c87eb 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp 
> 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7 
> 
> 
> Diff: https://reviews.apache.org/r/65976/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 67575: Changed operator API to notify subscribers on every status change.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67575/#review204745
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On June 13, 2018, 4:37 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67575/
> ---
> 
> (Updated June 13, 2018, 4:37 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this change, the master would only send TaskUpdated messages
> to subscribers when the latest known task state on the agent changed.
> 
> This implied that schedulers could not reliably wait for the status
> information corresponding to specific state updates (i.e. TASK_RUNNING),
> since there is no guarantee that subscribers get notified during
> the time when this status update will be included in the status field.
> 
> After this change, TaskUpdate messages are sent whenever the latest
> acknowledged state of the task changes.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 54f84120728eea7995422b9c356ed67e5b054623 
>   src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 
> 
> 
> Diff: https://reviews.apache.org/r/67575/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65875: Improved logging for offers and inverse offers.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/
---

(Updated June 14, 2018, 12:22 a.m.)


Review request for mesos, Gastón Kleiman and Greg Mann.


Changes
---

Rebased.


Repository: mesos


Description
---

Printed offer IDs and inverse offer IDs when sending out offers and
inverse offers so it is easier to match them to their ACCEPT or DECLINE
calls and removals.


Diffs (updated)
-

  src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 


Diff: https://reviews.apache.org/r/65875/diff/3/

Changes: https://reviews.apache.org/r/65875/diff/2-3/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65640: Fixed a race condition in `UriDiskProfileAdaptorTests`.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65640/
---

(Updated June 14, 2018, 12:20 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Jie Yu, and 
Joseph Wu.


Changes
---

Rebased.


Summary (updated)
-

Fixed a race condition in `UriDiskProfileAdaptorTests`.


Bugs: MESOS-8567
https://issues.apache.org/jira/browse/MESOS-8567


Repository: mesos


Description (updated)
---

There was a race between `Clock::advance()` in the `FetchFromHTTP` test
and `delay()` in `UriDiskProfileAdaptorProcess::_poll`. This patch
avoids the race by enforcing an order between the dispatch of the
`__poll` function (previously `_poll`) and the clock manipulation
in the test.


Diffs (updated)
-

  src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
  src/resource_provider/storage/uri_disk_profile_adaptor.hpp 
0484933b42d0bd66c689b06cb48f492eef7bc606 
  src/resource_provider/storage/uri_disk_profile_adaptor.cpp 
614590ef7d1c0cc1df99b8e57c7fbd496793b5a7 
  src/tests/disk_profile_adaptor_tests.cpp 
4485f1635f484ce6e1c7c532eedb277f5eee118b 


Diff: https://reviews.apache.org/r/65640/diff/5/

Changes: https://reviews.apache.org/r/65640/diff/4-5/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65976/
---

(Updated June 14, 2018, 12:07 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.


Changes
---

Rebased.


Bugs: MESOS-8825
https://issues.apache.org/jira/browse/MESOS-8825


Repository: mesos


Description
---

Allowed profiles to be missing from `DiskProfileAdaptor`.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
b90a4b81838fec410a97a10ce44a811bb81c87eb 
  src/resource_provider/storage/uri_disk_profile_adaptor.cpp 
614590ef7d1c0cc1df99b8e57c7fbd496793b5a7 


Diff: https://reviews.apache.org/r/65976/diff/4/

Changes: https://reviews.apache.org/r/65976/diff/3-4/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65975/
---

(Updated June 14, 2018, 12:06 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Simplified the reconciliation logic and replaced the `reconciliationCount` with 
a `reconciled` future for the latest reconciliation.


Bugs: MESOS-8825
https://issues.apache.org/jira/browse/MESOS-8825


Repository: mesos


Description
---

The storage pools needs to be reconciled in the following two scenarios:

1. When there is a change in the set of known profiles.
2. When a volume/block of an unknown profile is destroyed, because the
   disk space being freed up may belong to a known profile.

This patch adds a sequence to coordinate the reconciliations for the
above two cases.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
b90a4b81838fec410a97a10ce44a811bb81c87eb 


Diff: https://reviews.apache.org/r/65975/diff/5/

Changes: https://reviews.apache.org/r/65975/diff/4-5/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65995/
---

(Updated June 14, 2018, 12:02 a.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, and Jie 
Yu.


Changes
---

Reverted the previous change since it doesn't work.


Bugs: MESOS-8825
https://issues.apache.org/jira/browse/MESOS-8825


Repository: mesos


Description
---

The two SLRP tests assume that SLRP will send out a RAW resource in its
first `UPDATE_STATE` message, and expect that the test framework would
receive an offer containing the RAW resource in its first offer. However
this behavior is not guaranteed and should not be relied on. This patch
makes the tests decline unwanted offers by default so they no longer
rely on SLRP's internal behavior.


Diffs (updated)
-

  src/tests/storage_local_resource_provider_tests.cpp 
1afe8a8e0413ef225e952cd9cd6376e5d82774e5 


Diff: https://reviews.apache.org/r/65995/diff/7/

Changes: https://reviews.apache.org/r/65995/diff/6-7/


Testing
---

sudo make check
Ran the two tests in repitition.


Thanks,

Chun-Hung Hsiao

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

[Chun-Hung Hsiao]

> On April 20, 2018, 1:27 p.m., Benjamin Bannier wrote:
> > First round of reviews.
> > 
> > I am not a big fan on how reconcilations are modelled here. The counting 
> > seems to lead to an incomplete encapsulation of correct behavior. I'd much 
> > rather see standard `libprocess` actor semantics and better use of data 
> > structures instead. Right now the code appears too complicated and 
> > potentially brittle to the touch to me.
> 
> Benjamin Bannier wrote:
> I am nto sure what a good example of a solution would, but have a look at 
> e.g., the master registrar in how it pushes updates (operations) into a 
> simple `deque` which it then works on sequentially. While it triggers work on 
> the updates manually the control flow is easier to see (still not easy enough 
> though). Maybe we have other examples as well.

A few notes here:

There are two concurrent sources that will trigger the reconciliation:
A. Changes in the set of known profiles.
B. Deletion of a volume/block with a gone profile (this is not supported before 
this patch).
The reconciliation triggered by B could be combined with that triggered by A, 
but not vice versa.

Also, I'd like to point out that the reconciliation must wait for all pending 
deletion to complete,
and during the wait, the resource provider should not accept new related 
operations.

So let's consider that such a deletion arrives: (i) before, (ii) during, or 
(iii) after a
reconciliation (either A or B):

For (i), if B is triggered for the deletion first, then A needs to wait for B;
if B is not tiggered yet, then B will wait for the deletion to be completed,
and B will be combined with the reconciliation (A/B).

For (ii), the deletion will be dropped. Note that we need to drop all operations
when a reconciliation is *enqueued*, not when it is executed.

For (iii), the deletion will be accepted, and B will be triggered after the 
reconciliation.

In other words, all A-type reconciliations need to be executed after the 
previous reconciliation,
and a B-type reconcilation can be combined with another A-type or B-type 
reconciliation that is in progress.

Meanwhile, whenever a reconciliation is enqueued to the actor, we need to 
*synchronously* mark the actor
in some "reconciliation" mode to drop related incoming operations.
The primary reason we want to do that is because the current code synchronously 
apply all speculative operations.
This decision is made to simplify the overall logic and maintain the invariant 
that
once an operation is accepted (and checkpointed), it must be able to be applied 
on the current total resources.
So, the only way to support both A and B and maintaining this invariant is to 
have ensure that
whenever a reconciliation is enqueued, no more related operation will be 
enqueued.

Hope this summary could help reviewing this patch.

I'll update this patch later with a simpler logic.


> On April 20, 2018, 1:27 p.m., Benjamin Bannier wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 1092 (patched)
> > 
> >
> > Could you add a comment why this and the assertion in the continuation 
> > below are valid? The guaranteed execution paths of this `loop` with below 
> > `defer`s are not obvious to me.
> > 
> > Ideally we would not need this variable at all to ensure correct 
> > push-pop semantics, but defer to actor behavior and queues. This is hidden 
> > under very thick continuation layers at the moment.

As described above, whenever a reconciliation is enqueued, it is not allowed to 
enqueue more operations,
so the main purpose of this variable is to *synchronously* mark this actor in a 
special mode to drop all incoming operations.

But yes, this counter is hard to understand and kinda error prone. I'll update 
the patch with a different (and hopefully easier) logic.


> On April 20, 2018, 1:27 p.m., Benjamin Bannier wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 1284 (patched)
> > 
> >
> > It would be great if this function would either return a value, or 
> > trigger `fatal()` to make sure we do our part to keep the agent up-to-date.

Will do.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65975/#review201629
---


On April 12, 2018, 3:36 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65975/
> ---
> 
> (Updated April 12, 2018, 3:36 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8825
> 

Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67585/#review204741
---



PASS: Mesos patch 67585 was successfully built and tested.

Reviews applied: `['67585']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67585

- Mesos Reviewbot Windows


On June 13, 2018, 9:22 p.m., CHEN RUNCONG wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67585/
> ---
> 
> (Updated June 13, 2018, 9:22 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-6092
> https://issues.apache.org/jira/browse/MESOS-6092
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the issue:if the container is destroyed in the mean time, then we will 
> potentially segfault here.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be 
> 
> 
> Diff: https://reviews.apache.org/r/67585/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> CHEN RUNCONG
> 
>

Review Request 67591: Improving the accuracy of this failure message.

[he yi hua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67591/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Improving the accuracy of this failure message.


Diffs
-

  src/uri/fetchers/docker.cpp a04f71db019ae15f278c158fd0f499fb4b360e91 


Diff: https://reviews.apache.org/r/67591/diff/1/


Testing
---


Thanks,

he yi hua

Review Request 67590: Added a dedicated benchmark for range resources.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67590/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-8989
https://issues.apache.org/jira/browse/MESOS-8989


Repository: mesos


Description
---

See summary.

Also removed the current range benchmark which could produce
misleading results for subtraction (See MESOS-8989).


Diffs
-

  src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1 


Diff: https://reviews.apache.org/r/67590/diff/1/


Testing
---

Ran on a multicore machine with peak frequency at 2.2GHz:

Took 25.435531ms to perform 1000 'a += b' operations on ports:[1-6, 11-16, 
21-26... and ports:[3-8, 13-18, 23-28... with size 10
Took 76.104895ms to perform 1000 'a -= b' operations on ports:[1-6, 11-16, 
21-26... and ports:[3-8, 13-18, 23-28... with size 10
Took 28.66989ms to perform 1000 'a + b' operations on ports:[1-6, 11-16, 
21-26... and ports:[3-8, 13-18, 23-28... with size 10
Took 79.937531ms to perform 1000 'a - b' operations on ports:[1-6, 11-16, 
21-26... and ports:[3-8, 13-18, 23-28... with size 10

Took 360.16389ms to perform 1000 'a += b' operations on ports:[1-6, 11-16, 
21-26... and ports:[3-8, 13-18, 23-28... with size 100
Took 812.057397ms to perform 1000 'a -= b' operations on ports:[1-6, 11-16, 
21-26... and ports:[3-8, 13-18, 23-28... with size 100
Took 298.568732ms to perform 1000 'a + b' operations on ports:[1-6, 11-16, 
21-26... and ports:[3-8, 13-18, 23-28... with size 100
Took 799.168596ms to perform 1000 'a - b' operations on ports:[1-6, 11-16, 
21-26... and ports:[3-8, 13-18, 23-28... with size 100

Took 5.499557097secs to perform 1000 'a += b' operations on ports:[1-6, 11-16, 
21-26... and ports:[3-8, 13-18, 23-28... with size 1000
Took 10.80984876secs to perform 1000 'a -= b' operations on ports:[1-6, 11-16, 
21-26... and ports:[3-8, 13-18, 23-28... with size 1000
Took 5.105380254secs to perform 1000 'a + b' operations on ports:[1-6, 11-16, 
21-26... and ports:[3-8, 13-18, 23-28... with size 1000
Took 11.025490666secs to perform 1000 'a - b' operations on ports:[1-6, 11-16, 
21-26... and ports:[3-8, 13-18, 23-28... with size 1000


Thanks,

Meng Zhu

Re: Review Request 67561: Refactored `struct Slave` in the allocator for better performance.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67561/
---

(Updated June 13, 2018, 4:36 p.m.)


Review request for mesos, Gastón Kleiman, Greg Mann, Kapil Arya, and Till 
Toenshoff.


Changes
---

Updated summary. Added benchmark result.


Summary (updated)
-

Refactored `struct Slave` in the allocator for better performance.


Bugs: MESOS-8986
https://issues.apache.org/jira/browse/MESOS-8986


Repository: mesos


Description
---

This patch refactors the `struct Slave` in the allocator.
In particular, it addresses the slowness of computing
agent's available resources. Instead of calculating it
every time on the fly, this patch "denormalizes" the agent
available resources by updating and persisting the field
each time when agent's allocated or total resources change.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
e9d1742bb35004735e3cb357286b4e5b17436a5c 
  src/master/allocator/mesos/hierarchical.cpp 
b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c 


Diff: https://reviews.apache.org/r/67561/diff/2/

Changes: https://reviews.apache.org/r/67561/diff/1-2/


Testing (updated)
---

make check

In our simulation environment, we observed 16% allocator performance improvment 
without quota, and 32% improvment when quota is used.


Thanks,

Meng Zhu

Re: Review Request 67488: Updated CLI to Python 3.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review204742
---



Patch looks great!

Reviews applied: [67411, 67412, 67413, 67487, 67488]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/2/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Review Request 67587: Updated ZooKeeper retry logic to retry on `ENOENT` too.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67587/
---

Review request for mesos, Joseph Wu and Neil Conway.


Bugs: MESOS-3790
https://issues.apache.org/jira/browse/MESOS-3790


Repository: mesos


Description
---

Per MESOS-3790, the call to `zookeeper_init` maps `EAI_NONAME` and
`EAI_NODATA` to an `errno` value of `ENOENT`, and all others except
`EAI_MEMORY` to `EINVAL`. Mesos's ZooKeeper logic is written to retry
this initialization for ten minutes if the error is `EINVAL`, and
should be updated to also retry if the error is `ENOENT`.

This is necessary because if the initialization is not retried, the
process crashes due to the `PLOG(FATAL)` call, and if it crashes, it
will interrupt other Mesos threads and potentially leave the
environment in an unknown state. For instance, we have seen
intermittent failures where the systemd unit file
`mesos_executors.slice` is created but empty because Mesos crashed
between creating the file and flushing the write to the file. This
then leads to errors when the agent is restarted (and succeeds to
connect to ZooKeeper), because the agent explicitly does not attempt
to write to the unit file if it already exists.


Diffs
-

  src/zookeeper/zookeeper.cpp 52c4af192ccd1361afc4f7a0041889238c01e674 


Diff: https://reviews.apache.org/r/67587/diff/1/


Testing
---

Testing against our repro right now, but it's flaky, so it'll take a while.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204736
---



PASS: Mesos patch 67394 was successfully built and tested.

Reviews applied: `['67286', '67287', '67394']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394

- Mesos Reviewbot Windows


On June 13, 2018, 6:36 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> ---
> 
> (Updated June 13, 2018, 6:36 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> White list fds that child processes can inherit in mesos containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 17a1a3762b2012ff875e4da9c9d4622514e48051 
>   src/slave/containerizer/mesos/launcher.hpp 
> 4b5ae730026fbb6054b390d79bb79a9cbad64485 
>   src/slave/containerizer/mesos/launcher.cpp 
> 9df05f3f8b3c989989e9421e90d4ca6571fc819f 
>   src/slave/containerizer/mesos/linux_launcher.hpp 
> 4c5cdd126e6916130f40d12ccc7a4c51ad6b56ab 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 9ce5fbf9cbf961eece12c5d336d356727b251290 
>   src/tests/containerizer/launcher.hpp 
> 776cb35a2eb05a0b65bdded44cd071038d30f882 
>   src/tests/containerizer/launcher.cpp 
> a92d9890f0931425d69ef8ce0896d081b8722079 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 362d9fb522817332da1fdf5ea4afd6bc2402005c 
> 
> 
> Diff: https://reviews.apache.org/r/67394/diff/4/
> 
> 
> Testing
> ---
> 
> All mesos tests on windows
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67567: Renamed variable names in slave.hpp to be more explicit.

[bin zheng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67567/
---

(Updated 六月 13, 2018, 9:47 p.m.)


Review request for mesos, Chun-Hung Hsiao and Gilbert Song.


Changes
---

Fixed code format error


Summary (updated)
-

Renamed variable names in slave.hpp to be more explicit.


Bugs: MESOS-8680
https://issues.apache.org/jira/browse/MESOS-8680


Repository: mesos


Description (updated)
---

Changed the variable name of the Class "Slave", "Executor" and "Framework" in 
Slave.hpp, eg: change "info" to "slaveInfo", "executorInfo" or "frameworkInfo". 
also change others in related files: http.cpp and slave.cpp.


Diffs (updated)
-

  src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
  src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 
  src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a 


Diff: https://reviews.apache.org/r/67567/diff/2/

Changes: https://reviews.apache.org/r/67567/diff/1-2/


Testing
---


Thanks,

bin zheng

Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

[CHEN RUNCONG]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67585/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-6092
https://issues.apache.org/jira/browse/MESOS-6092


Repository: mesos


Description
---

Fixed the issue:if the container is destroyed in the mean time, then we will 
potentially segfault here.


Diffs
-

  src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be 


Diff: https://reviews.apache.org/r/67585/diff/1/


Testing
---


Thanks,

CHEN RUNCONG

Re: Review Request 67581: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67581/#review204734
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67581']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67581

Relevant logs:

- 
[mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67581/logs/mesos-tests-cmake-stdout.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]


   "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
   "D:\DCOS\mesos\src\mesos.vcxproj" (default target) (15) ->
   (ClCompile target) -> 
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1384): error 
C2001: newline in constant [D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1385): error 
C2001: newline in constant [D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1385): error 
C2146: syntax error: missing ')' before identifier 'container' 
[D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1385): error 
C2146: syntax error: missing ';' before identifier 'container' 
[D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1385): error 
C2065: 'container': undeclared identifier [D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1385): error 
C2143: syntax error: missing ';' before 'string' 
[D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1386): error 
C2143: syntax error: missing ';' before '}' [D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1478): error 
C2001: newline in constant [D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1479): error 
C2001: newline in constant [D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1479): error 
C2146: syntax error: missing ')' before identifier 'process' 
[D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1479): error 
C2146: syntax error: missing ';' before identifier 'process' 
[D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1479): error 
C2882: 'process': illegal use of namespace identifier in expression 
[D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1479): error 
C2143: syntax error: missing ';' before 'string' 
[D:\DCOS\mesos\src\mesos.vcxproj]
 d:\dcos\mesos\mesos\src\slave\containerizer\docker.cpp(1480): error 
C2143: syntax error: missing ';' before '}' [D:\DCOS\mesos\src\mesos.vcxproj]

172 Warning(s)
14 Error(s)

Time Elapsed 00:10:30.84
```

- Mesos Reviewbot Windows


On June 13, 2018, 8:17 p.m., CHEN 

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204733
---



Patch looks great!

Reviews applied: [67546, 67547]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 13, 2018, 11:02 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> ---
> 
> (Updated June 13, 2018, 11:02 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67547/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67567: Rename variable names in slave.hpp to be more explicit.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67567/#review204729
---



Just did a partial review. Thanks for the work for these tedious renaming!

But I do same a similar concern with Benjamin that not all of these renamings 
will improve readability, and they introduce inconsistencies in the codebase.


src/slave/http.cpp
Lines 221 (patched)


When breaking an expression into two lines, we only indent by 2 spaces:
```
exectuor_->executorInfo.resoures()
  .begin()->allocation_info().role());
```



src/slave/http.cpp
Lines 236 (patched)


The way we break function calls into multiple lines in `if` statements is 
not well laid out, but generally we do the following indentation style:
```
if (!approvers_->approved(
*task, framework_->frameworkInfo)){
```
In other words, we indent the parameters by 4 spaces after aligning with 
the parenthesis of the `if` statement. This would make the following code more 
readable:
```
if (!approvers_->approved(
*task, framework_->frameworkInfo) &&
...) {
```



src/slave/http.cpp
Lines 247 (patched)


Similarly, let's indent by two more spaces.

Same below.



src/slave/http.cpp
Lines 1435 (patched)


1 more space here.



src/slave/http.cpp
Lines 1694 (patched)


One mero space here. Same below.



src/slave/slave.hpp
Line 724 (original), 724 (patched)


To many spaces. We usually leave only one space between the type and the 
variable name:
```
Salevinfo slaveInfo;
```


- Chun-Hung Hsiao


On June 13, 2018, 5:14 p.m., bin zheng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67567/
> ---
> 
> (Updated June 13, 2018, 5:14 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
> 
> 
> Bugs: MESOS-8680
> https://issues.apache.org/jira/browse/MESOS-8680
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the variable name of the Class "Slave", "Executor" and "Framework" in 
> Slave.hpp, eg: change "info" to "slaveInfo", "executorInfo" or 
> "frameworkInfo".  also change others in related files: http.cpp and slave.cpp.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
>   src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 
>   src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a 
> 
> 
> Diff: https://reviews.apache.org/r/67567/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bin zheng
> 
>

Re: Review Request 67579: Added chenrc to the contributors list

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67579/#review204730
---



PASS: Mesos patch 67579 was successfully built and tested.

Reviews applied: `['67579']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67579

- Mesos Reviewbot Windows


On June 13, 2018, 5:24 p.m., CHEN RUNCONG wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67579/
> ---
> 
> (Updated June 13, 2018, 5:24 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added chenrc to the contributors list
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67579/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> CHEN RUNCONG
> 
>

Re: Review Request 67577: Change contributor name by full name.

[cui dt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67577/
---

(Updated 六月 13, 2018, 8:03 p.m.)


Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Change contributor name by full name.


Diffs (updated)
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67577/diff/2/

Changes: https://reviews.apache.org/r/67577/diff/1-2/


Testing
---


Thanks,

cui dt

Re: Review Request 67557: Add contributor info at the file contributors.yaml.

[cui dt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/
---

(Updated 六月 13, 2018, 8:05 p.m.)


Review request for mesos and Gilbert Song.


Repository: mesos


Description (updated)
---

Added DaoTan Cui to the contributor list.


Diffs
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67557/diff/1/


Testing
---


Thanks,

cui dt

Re: Review Request 67580: Fixed use of rbt command in `push-commits.py` for Windows.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67580/#review204728
---



PASS: Mesos patch 67580 was successfully built and tested.

Reviews applied: `['67580']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67580

- Mesos Reviewbot Windows


On June 13, 2018, 5:31 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67580/
> ---
> 
> (Updated June 13, 2018, 5:31 p.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Same logic as `post-reviews.py`.
> 
> 
> Diffs
> -
> 
>   support/python3/push-commits.py b346dcf98900902f906925799051f287be298efa 
> 
> 
> Diff: https://reviews.apache.org/r/67580/diff/1/
> 
> 
> Testing
> ---
> 
> Can't test this without actually submitting... but it should work! Mostly 
> posting the review so we can test it in the first place.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67356/#review204727
---



PASS: Mesos patch 67356 was successfully built and tested.

Reviews applied: `['67354', '67355', '67356']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67356

- Mesos Reviewbot Windows


On May 29, 2018, 2:21 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67356/
> ---
> 
> (Updated May 29, 2018, 2:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent 
> huang, Ilya Pronin, and James Peach.
> 
> 
> Bugs: MESOS-3475
> https://issues.apache.org/jira/browse/MESOS-3475
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes `os::setenv()`, `os::unsetenv()` calls that are
> currently used to implicitly configure both `MesosExecutorDriver` and
> v1 Executor via global environment variables. This change prepares a
> map containing modified environment and passes it to a constructor of
> an executor.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer.cpp c4e18b7c5d6937f53f806e94a40c969cdcac79eb 
>   src/tests/mesos.hpp 8f529fad7041cb375dc6b0e07273a8412d5519b4 
> 
> 
> Diff: https://reviews.apache.org/r/67356/diff/3/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 67577: Change contributor name by full name.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67577/#review204726
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67577']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67577

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67577/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (105 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (924 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (28 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (33 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (63 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (763 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (786 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (835 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (857 ms total)

[--] Global test environment tear-down
[==] 988 tests from 97 test cases ran. (471048 ms total)
[  PASSED  ] 987 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67577/logs/mesos-tests-stderr.log):

```
I0613 19:55:53.224596  2832 executor.cpp:178] Received SUBSCRIBED event
I0613 19:55:53.228638  2832 executor.cpp:182] Subscribed executor on 
windows-04.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0613 19:55:53.229655  2832 executor.cpp:178] Received LAUNCH event
I0613 19:55:53.234593  2832 executor.cpp:665] Starting task 
74e4cdce-85d5-4816-a6cc-ebf9af8b4695
I0613 19:55:53.305637  2832 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0613 19:55:53.321609  2832 executor.cpp:678] Forked command at 6040
I0613 19:55:53.349596  6036 exec.cpp:445] Executor asked to shutdown
I0613 19:55:53.350601  2832 executor.cpp:178] Received SHUTDOWN event
I0613 19:55:53.350601  2832 executor.cpp:781] Shutting down
I0613 19:55:53.350601  2832 executor.cpp:894] Sending SIGTERM to process tree 
at pid 604 d241732a-7d99-4f46-a93d-703e4a4c5a10- (default) at 
scheduler-eb8e1bdc-a0d4-4f57-9ea9-0c4a2a8fbaad@192.10.1.10:57746
I0613 19:55:53.347596  6868 hierarchical.cpp:405] Deactivated framework 
d241732a-7d99-4f46-a93d-703e4a4c5a10-
I0613 19:55:53.347596  1724 slave.cpp:3939] Shutting down framework 
d241732a-7d99-4f46-a93d-703e4a4c5a10-
I0613 19:55:53.347596  7344 master.cpp:10863] Updating the state of task 
74e4cdce-85d5-4816-a6cc-ebf9af8b4695 of framework 
d241732a-7d99-4f46-a93d-703e4a4c5a10- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0613 19:55:53.348592  1724 slave.cpp:6660] Shutting down executor 
'74e4cdce-85d5-4816-a6cc-ebf9af8b4695' of framework 
d241732a-7d99-4f46-a93d-703e4a4c5a10- at executor(1)@192.10.1.10:57767
I0613 19:55:53.349596  1724 slave.cpp:931] Agent terminating
W0613 19:55:53.349596  1724 slave.cpp:3935] Ignoring shutdown framework 
d241732a-7d99-4f46-a93d-703e4a4c5a10- because it is terminating
I0613 19:55:53.350601  7344 master.cpp:10962] Removing task 
74e4cdce-85d5-4816-a6cc-ebf9af8b4695 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework d241732a-7d99-4f46-a93d-703e4a4c5a10- on 
agent d241732a-7d99-4f46-a93d-703e4a4c5a10-S0 at slave(449)@192.10.1.10:57746 
(windows-04.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0613 19:55:53.354626  7344 master.cpp:1293] Agent 
d241732a-7d99-4f46-a93d-703e4a4c5a10-S0 at slave(449)@192.10.1.10:57746 
(windows-04.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0613 19:55:53.354626  7344 master.cpp:3303] Disconnecting agent 
d241732a-7d99-4f46-a93d-703e4a4c5a10-S0 at slave(449)@192.10.1.10:57746 
(windows-04.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0613 19:55:53.354626  7344 master.cpp:3322] Deactivating agent 
d241732a-7d99-4f46-a93d-703e4a4c5a10-S0 at slave(449)@192.10.1.10:57746 

Re: Review Request 67286: White list fds that child processes can inherit in stout.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67286/
---

(Updated June 13, 2018, 6:37 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
Yu, Li Li, and Radhika Jandhyala.


Changes
---

Rebase


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

White list fds that child processes can inherit in stout.


Diffs (updated)
-

  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8afcaa6dee8a4216e0ae54c6d94209c001046b10 


Diff: https://reviews.apache.org/r/67286/diff/5/

Changes: https://reviews.apache.org/r/67286/diff/4-5/


Testing
---

All Mesos-tests


Thanks,

Radhika Jandhyala

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/
---

(Updated June 13, 2018, 6:36 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
Yu, Li Li, and Radhika Jandhyala.


Changes
---

Rebase


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

White list fds that child processes can inherit in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 


Diff: https://reviews.apache.org/r/67287/diff/5/

Changes: https://reviews.apache.org/r/67287/diff/4-5/


Testing
---

All Mesos-tests


Thanks,

Radhika Jandhyala

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/
---

(Updated June 13, 2018, 6:36 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.


Changes
---

Rebase


Repository: mesos


Description
---

White list fds that child processes can inherit in mesos containerizer.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
17a1a3762b2012ff875e4da9c9d4622514e48051 
  src/slave/containerizer/mesos/launcher.hpp 
4b5ae730026fbb6054b390d79bb79a9cbad64485 
  src/slave/containerizer/mesos/launcher.cpp 
9df05f3f8b3c989989e9421e90d4ca6571fc819f 
  src/slave/containerizer/mesos/linux_launcher.hpp 
4c5cdd126e6916130f40d12ccc7a4c51ad6b56ab 
  src/slave/containerizer/mesos/linux_launcher.cpp 
9ce5fbf9cbf961eece12c5d336d356727b251290 
  src/tests/containerizer/launcher.hpp 776cb35a2eb05a0b65bdded44cd071038d30f882 
  src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
362d9fb522817332da1fdf5ea4afd6bc2402005c 


Diff: https://reviews.apache.org/r/67394/diff/4/

Changes: https://reviews.apache.org/r/67394/diff/3-4/


Testing
---

All mesos tests on windows


Thanks,

Radhika Jandhyala

Re: Review Request 67525: Removed static variable with non-constant initialization.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67525/#review204722
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On June 13, 2018, 9:23 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67525/
> ---
> 
> (Updated June 13, 2018, 9:23 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The static variable was initialized using a dynamic memory
> allocation. This is against our coding style, and makes it
> as easy as writing
> 
> static process::http::NotFound DEFAULT_RESPONSE;
> 
> for a user to introduce a potential segfault into his code.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> 055447e13117c0a3ba79d0fc326ece657e8f064f 
>   3rdparty/libprocess/src/decoder.hpp 
> a0784358d63279022473fdf82a72b7ecc9056658 
>   3rdparty/libprocess/src/http.cpp 9fd5ea02ee57b4ad2d30c4b9ac4cbd299942d501 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> ca1ea116866b5ccd3d42e93dd5bd7fed2234df0d 
> 
> 
> Diff: https://reviews.apache.org/r/67525/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 67581: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

[CHEN RUNCONG]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67581/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-6092
https://issues.apache.org/jira/browse/MESOS-6092


Repository: mesos


Description
---

Fixed the issue:if the container is destroyed in the mean time, then we will 
potentially segfault here.


Diffs
-

  src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be 


Diff: https://reviews.apache.org/r/67581/diff/1/


Testing
---


Thanks,

CHEN RUNCONG

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

[Andrew Schwartzmeyer]

> On June 12, 2018, 5:23 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Failed to apply the current review.
> > 
> > Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67394`
> > 
> > All the build artifacts available at: 
> > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394
> > 
> > Relevant logs:
> > 
> > - 
> > [apply-review-67394-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394/logs/apply-review-67394-stdout.log):
> > 
> > ```
> > error: patch failed: src/tests/containerizer/launcher.hpp:56
> > error: src/tests/containerizer/launcher.hpp: patch does not apply
> > ```

Wait this still failed?


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204648
---


On June 12, 2018, 3:56 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> ---
> 
> (Updated June 12, 2018, 3:56 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> White list fds that child processes can inherit in mesos containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
>   src/slave/containerizer/mesos/launcher.hpp 
> f69d934d2e1a129e10df8c7f5c78723e832adc7d 
>   src/slave/containerizer/mesos/launcher.cpp 
> 2fe47d368cb82a46328e1f636baa836272db244c 
>   src/slave/containerizer/mesos/linux_launcher.hpp 
> 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 80e444501e429c1e1ae354abcd51f86430316ada 
>   src/tests/containerizer/launcher.hpp 
> a8e436f164b67d937ebcff35e084d3ca755c003c 
>   src/tests/containerizer/launcher.cpp 
> a92d9890f0931425d69ef8ce0896d081b8722079 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 01f2b38cfa67b144298c361e92170322864ac201 
> 
> 
> Diff: https://reviews.apache.org/r/67394/diff/3/
> 
> 
> Testing
> ---
> 
> All mesos tests on windows
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204718
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On June 12, 2018, 3:56 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> ---
> 
> (Updated June 12, 2018, 3:56 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> White list fds that child processes can inherit in mesos containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
>   src/slave/containerizer/mesos/launcher.hpp 
> f69d934d2e1a129e10df8c7f5c78723e832adc7d 
>   src/slave/containerizer/mesos/launcher.cpp 
> 2fe47d368cb82a46328e1f636baa836272db244c 
>   src/slave/containerizer/mesos/linux_launcher.hpp 
> 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 80e444501e429c1e1ae354abcd51f86430316ada 
>   src/tests/containerizer/launcher.hpp 
> a8e436f164b67d937ebcff35e084d3ca755c003c 
>   src/tests/containerizer/launcher.cpp 
> a92d9890f0931425d69ef8ce0896d081b8722079 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 01f2b38cfa67b144298c361e92170322864ac201 
> 
> 
> Diff: https://reviews.apache.org/r/67394/diff/3/
> 
> 
> Testing
> ---
> 
> All mesos tests on windows
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67575: Changed operator API to notify subscribers on every status change.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67575/#review204716
---



PASS: Mesos patch 67575 was successfully built and tested.

Reviews applied: `['67575']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67575

- Mesos Reviewbot Windows


On June 13, 2018, 9:37 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67575/
> ---
> 
> (Updated June 13, 2018, 9:37 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this change, the master would only send TaskUpdated messages
> to subscribers when the latest known task state on the agent changed.
> 
> This implied that schedulers could not reliably wait for the status
> information corresponding to specific state updates (i.e. TASK_RUNNING),
> since there is no guarantee that subscribers get notified during
> the time when this status update will be included in the status field.
> 
> After this change, TaskUpdate messages are sent whenever the latest
> acknowledged state of the task changes.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 54f84120728eea7995422b9c356ed67e5b054623 
>   src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 
> 
> 
> Diff: https://reviews.apache.org/r/67575/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/#review204717
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On June 12, 2018, 3:56 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67287/
> ---
> 
> (Updated June 12, 2018, 3:56 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
> Yu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> White list fds that child processes can inherit in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6a1262340c333b617402637e648c12769827ffc4 
>   3rdparty/libprocess/src/subprocess.cpp 
> d7a725363251f9c54072cd7551f5598696938308 
>   3rdparty/libprocess/src/subprocess_windows.hpp 
> c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 
> 
> 
> Diff: https://reviews.apache.org/r/67287/diff/4/
> 
> 
> Testing
> ---
> 
> All Mesos-tests
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Review Request 67580: Fixed use of rbt command in `push-commits.py` for Windows.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67580/
---

Review request for mesos and Armand Grillet.


Repository: mesos


Description
---

Same logic as `post-reviews.py`.


Diffs
-

  support/python3/push-commits.py b346dcf98900902f906925799051f287be298efa 


Diff: https://reviews.apache.org/r/67580/diff/1/


Testing
---

Can't test this without actually submitting... but it should work! Mostly 
posting the review so we can test it in the first place.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`.

[Andrei Budnik]

> On June 13, 2018, 11:31 a.m., Alexander Rukletsov wrote:
> > include/mesos/executor.hpp
> > Lines 220-223 (patched)
> > 
> >
> > Maybe add this comment to the previous constructor saying that the 
> > other one is preferable? I think that way it will be easier for users to 
> > figure out they use a not favoured c-tor : )

Updated this and the following patches.


> On June 13, 2018, 11:31 a.m., Alexander Rukletsov wrote:
> > src/exec/exec.cpp
> > Line 646 (original), 654 (patched)
> > 
> >
> > I doubt this does what you want it to do. At the end, `FlagsBase` calls 
> > `extract()` on the prefix, which in turn calls `os::environment()`. Please 
> > either mention here that env is loaded under the hood (as Ilya suggested 
> > before), or fix the flags to not load the environment at all.
> > 
> > Maybe doing the latter should be part of a bigger change where we make 
> > `FlagsBase` instances never load from the environment (but provide a static 
> > function to do so). I will be happy to shepherd this work and chain it 
> > immediately after this change so it does not fall through the cracks.

We can filter environment vars ourselves and then call `FlagBase::load()` 
without specifying `prefix` argument to prevent it from reading global 
environment.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67354/#review204681
---


On May 29, 2018, 2:20 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67354/
> ---
> 
> (Updated May 29, 2018, 2:20 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent 
> huang, Ilya Pronin, and James Peach.
> 
> 
> Bugs: MESOS-3475
> https://issues.apache.org/jira/browse/MESOS-3475
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds overloaded constructor for `MesosExecutorDriver` that
> accepts `environment` parameter and stores it in the class variable.
> This new constructor is needed to get rid of `os::getenv()` calls,
> so that `MesosExecutorDriver` can be used in tests that require
> thread safety.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor.hpp d14c0369f6731100d27092142b56f108f8881003 
>   src/exec/exec.cpp 65a671d7ce83a51087d290ba039d18deba6313c2 
> 
> 
> Diff: https://reviews.apache.org/r/67354/diff/3/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 67579: Added chenrc to the contributors list

[CHEN RUNCONG]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67579/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Added chenrc to the contributors list


Diffs
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67579/diff/1/


Testing
---


Thanks,

CHEN RUNCONG

Re: Review Request 67567: Rename variable names in slave.hpp to be more explicit.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67567/#review204712
---



I wonder if this is really more explicit? Right now it seems very likely to me 
that e.g., `Slave::info` would refer to a `SlaveInfo`; calling it 
`Slave::slaveInfo` doesn't seem to add much. There also seems to be no need to 
disambiguate here as the datstructures touched here do not contain more that a 
single `*Info` value.

Note that we use a similar pattern in e.g., `master.hpp` and `hierarchical.hpp`.

- Benjamin Bannier


On June 13, 2018, 7:14 p.m., bin zheng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67567/
> ---
> 
> (Updated June 13, 2018, 7:14 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
> 
> 
> Bugs: MESOS-8680
> https://issues.apache.org/jira/browse/MESOS-8680
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the variable name of the Class "Slave", "Executor" and "Framework" in 
> Slave.hpp, eg: change "info" to "slaveInfo", "executorInfo" or 
> "frameworkInfo".  also change others in related files: http.cpp and slave.cpp.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
>   src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 
>   src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a 
> 
> 
> Diff: https://reviews.apache.org/r/67567/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bin zheng
> 
>

Review Request 67578: add user information

[CHEN RUNCONG]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67578/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

add user information


Diffs
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67578/diff/1/


Testing
---


Thanks,

CHEN RUNCONG

Review Request 67577: Change contributor name by full name.

[cui dt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67577/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Change contributor name by full name.


Diffs
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67577/diff/1/


Testing
---


Thanks,

cui dt

Re: Review Request 67567: Rename variable names in slave.hpp to be more explicit.

[bin zheng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67567/
---

(Updated 六月 13, 2018, 5:14 p.m.)


Review request for mesos, Chun-Hung Hsiao and Gilbert Song.


Bugs: MESOS-8680
https://issues.apache.org/jira/browse/MESOS-8680


Repository: mesos


Description
---

Changed the variable name of the Class "Slave", "Executor" and "Framework" in 
Slave.hpp, eg: change "info" to "slaveInfo", "executorInfo" or "frameworkInfo". 
 also change others in related files: http.cpp and slave.cpp.


Diffs
-

  src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
  src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 
  src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a 


Diff: https://reviews.apache.org/r/67567/diff/1/


Testing
---


Thanks,

bin zheng

Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/#review204708
---



Patch looks great!

Reviews applied: [67563, 67526, 67564, 67565]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 13, 2018, 2:44 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67565/
> ---
> 
> (Updated June 13, 2018, 2:44 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> 231e9588c0d831c05a1d84f35f0f68105900789c 
> 
> 
> Diff: https://reviews.apache.org/r/67565/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67567: Rename variable names in slave.hpp to be more explicit.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67567/#review204707
---



Could you add the `bug`# to this patch, eg., `MESOS-`

and add the shepherd of this JIRA to the reviewer list.

- Gilbert Song


On June 12, 2018, 11:17 p.m., bin zheng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67567/
> ---
> 
> (Updated June 12, 2018, 11:17 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the variable name of the Class "Slave", "Executor" and "Framework" in 
> Slave.hpp, eg: change "info" to "slaveInfo", "executorInfo" or 
> "frameworkInfo".  also change others in related files: http.cpp and slave.cpp.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
>   src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 
>   src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a 
> 
> 
> Diff: https://reviews.apache.org/r/67567/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bin zheng
> 
>

Re: Review Request 67562: The container should not be access when the container is destroyed in the mean time.

[CHEN RUNCONG]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67562/
---

(Updated June 13, 2018, 9:54 a.m.)


Review request for mesos, Gilbert Song and Greg Mann.


Bugs: MESOS-6092
https://issues.apache.org/jira/browse/MESOS-6092


Repository: mesos


Description
---

The container should not be access when the container is destroyed in the mean 
time.


Diffs
-

  src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be 


Diff: https://reviews.apache.org/r/67562/diff/1/


Testing
---


Thanks,

CHEN RUNCONG

Re: Review Request 67558: Cai change.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67558/#review204706
---



The patch looks good to me! 

Would you mind changing the commit message as: "Added  to the 
contributor list."

- Gilbert Song


On June 12, 2018, 1:12 p.m., cai shuhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67558/
> ---
> 
> (Updated June 12, 2018, 1:12 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cai change.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67558/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> cai shuhua
> 
>

Re: Review Request 67552: Added LongFei Niu to contributors list.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67552/#review204705
---


Ship it!




Ship It!

- Gilbert Song


On June 12, 2018, 10:37 a.m., longfei niu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67552/
> ---
> 
> (Updated June 12, 2018, 10:37 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added LongFei Niu to contributors list.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67552/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> longfei niu
> 
>

Re: Review Request 67559: Added Yihua He to the contributor list.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67559/#review204704
---


Ship it!




Ship It!

- Gilbert Song


On June 12, 2018, 1:04 p.m., he yi hua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67559/
> ---
> 
> (Updated June 12, 2018, 1:04 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Yihua He to the contributor list.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67559/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> he yi hua
> 
>

Re: Review Request 67553: Added Xiang Chaosheng to the contributors list.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67553/#review204703
---


Fix it, then Ship it!





docs/contributors.yaml
Lines 782-789 (patched)


could you sort it alphabetically, e.g., move it above `Xiao Deshi`.


- Gilbert Song


On June 12, 2018, 10:57 a.m., xiang chaosheng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67553/
> ---
> 
> (Updated June 12, 2018, 10:57 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Xiang Chaosheng to the contributors list.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67553/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> xiang chaosheng
> 
>

Re: Review Request 67557: Add contributor info at the file contributors.yaml.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/#review204702
---



also, please use this commit message: "Added  to the contributor 
list."

- Gilbert Song


On June 12, 2018, 1:24 p.m., cui dt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67557/
> ---
> 
> (Updated June 12, 2018, 1:24 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add contributor info at the contributors.yaml.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67557/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> cui dt
> 
>

Re: Review Request 67557: Add contributor info at the file contributors.yaml.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/#review204701
---




docs/contributors.yaml
Lines 758 (patched)


Would you mind putting your full name here (just like all the others)?


- Gilbert Song


On June 12, 2018, 1:24 p.m., cui dt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67557/
> ---
> 
> (Updated June 12, 2018, 1:24 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add contributor info at the contributors.yaml.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67557/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> cui dt
> 
>

Re: Review Request 67549: modify my user information

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67549/#review204699
---



Could you squash two commits into one?

- Gilbert Song


On June 12, 2018, 3:48 p.m., CHEN RUNCONG wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67549/
> ---
> 
> (Updated June 12, 2018, 3:48 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> modify my user information
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67549/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> CHEN RUNCONG
> 
>

Review Request 67575: Changed operator API to notify subscribers on every status change.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67575/
---

Review request for mesos.


Repository: mesos


Description
---

Prior to this change, the master would only send TaskUpdated messages
to subscribers when the latest known task state on the agent changed.

This implied that schedulers could not reliably wait for the status
information corresponding to specific state updates (i.e. TASK_RUNNING),
since there is no guarantee that subscribers get notified during
the time when this status update will be included in the status field.

After this change, TaskUpdate messages are sent whenever the latest
acknowledged state of the task changes.


Diffs
-

  include/mesos/master/master.proto 54f84120728eea7995422b9c356ed67e5b054623 
  src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 


Diff: https://reviews.apache.org/r/67575/diff/1/


Testing
---


Thanks,

Benno Evers

Re: Review Request 67538: Added Bin Zheng to the contributors list.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67538/#review204698
---


Ship it!




Ship It!

- Gilbert Song


On June 11, 2018, 11:36 p.m., bin zheng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67538/
> ---
> 
> (Updated June 11, 2018, 11:36 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Bin Zheng to the contributors list.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67538/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bin zheng
> 
>

Re: Review Request 67558: Cai change.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67558/#review204691
---



Patch looks great!

Reviews applied: [67558]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 12, 2018, 8:12 p.m., cai shuhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67558/
> ---
> 
> (Updated June 12, 2018, 8:12 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cai change.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67558/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> cai shuhua
> 
>

Re: Review Request 67487: Used `$PYTHON` in configure.ac and Makefile.am.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67487/#review204690
---




src/Makefile.am
Lines 1804-1816 (original), 1804-1816 (patched)


Can you set PYTHON here so we know which python version we are building the 
virtualenv with?


- Kevin Klues


On June 12, 2018, 2:51 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67487/
> ---
> 
> (Updated June 12, 2018, 2:51 p.m.)
> 
> 
> Review request for mesos, Eric Chung and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This ensures that we use Python 2 even if the Python
> intepreter under the command `python` is Python 3.
> 
> 
> Diffs
> -
> 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
> 
> 
> Diff: https://reviews.apache.org/r/67487/diff/3/
> 
> 
> Testing
> ---
> 
> In `build`:
> ```
> $ ../configure --disable-java --enable-new-cli
> $ GTEST_FILTER="" nice make -j16 check
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67358/
---

(Updated June 13, 2018, 10:25 p.m.)


Review request for mesos and Gilbert Song.


Summary (updated)
-

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description (updated)
---

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67358/diff/3/

Changes: https://reviews.apache.org/r/67358/diff/2-3/


Testing
---

Ran this test repeatedly


Thanks,

Qian Zhang

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/
---

(Updated June 13, 2018, 10:24 p.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description (updated)
---

When `cgroups/all` is specified in the agent flag `--isolation`, we
will automatically load all the local enabled cgroups subsystems in
the cgroups isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
17a1a3762b2012ff875e4da9c9d4622514e48051 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
215e32461e851668247f9fae62aa656f5dd5e245 


Diff: https://reviews.apache.org/r/67343/diff/5/

Changes: https://reviews.apache.org/r/67343/diff/4-5/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/
---

(Updated June 13, 2018, 10:26 p.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description
---

Added `cgroups/all` into CHANGELOG and upgrades.md.


Diffs (updated)
-

  CHANGELOG 0c45af66cbe1c6feede328143d30dad4eaf1a4b3 
  docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f 


Diff: https://reviews.apache.org/r/67381/diff/3/

Changes: https://reviews.apache.org/r/67381/diff/2-3/


Testing
---

Not a code change.


Thanks,

Qian Zhang

Review Request 67574: Made `PerfEventSubsystemProcess` can be created without `--perf_events`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67574/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description
---

If the agent flag `--perf_events` is not specified, the `perf_event`
subsystem (i.e., `PerfEventSubsystemProcess`) can still be created, but
it will not do sampling at all. The reason that we want to do this is,
in some cases, even it is not required to sample any events, we still
want each container to have its own `perf_event` cgroup instead under
the root cgroup.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.cpp 
06eca0c008ca7ddb45e4d10e63fdc2c601de430b 


Diff: https://reviews.apache.org/r/67574/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/#review204693
---



FAIL: Failed to apply the dependent review: 67335.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67335`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67381

Relevant logs:

- 
[apply-review-67335-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67381/logs/apply-review-67335-stdout.log):

```
error: patch failed: docs/configuration/agent.md:967
error: docs/configuration/agent.md: patch does not apply
```

- Mesos Reviewbot Windows


On June 13, 2018, 2:26 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67381/
> ---
> 
> (Updated June 13, 2018, 2:26 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `cgroups/all` into CHANGELOG and upgrades.md.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0c45af66cbe1c6feede328143d30dad4eaf1a4b3 
>   docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f 
> 
> 
> Diff: https://reviews.apache.org/r/67381/diff/3/
> 
> 
> Testing
> ---
> 
> Not a code change.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67412/#review204688
---




configure.ac
Lines 2278 (patched)


Instead of this long complicated line, can we just set PYTHON_VERSION 
directrly from:
```
PYTHON_VERSION=`$PYTHON -c "import sys; 
sys.stdout.write(sys.version[[:3]])"`
```


- Kevin Klues


On June 1, 2018, 3:14 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67412/
> ---
> 
> (Updated June 1, 2018, 3:14 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We set `PYTHON` and `PYTHON_VERSION` when configuring the build.
> We now cover all possible cases (both variables set, only one, none).
> This ensures that both variables are set after being checked.
> 
> 
> Diffs
> -
> 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
> 
> 
> Diff: https://reviews.apache.org/r/67412/diff/2/
> 
> 
> Testing
> ---
> 
> I added two lines after the new code:
> ```
>   AC_MSG_NOTICE([$PYTHON])
>   AC_MSG_NOTICE([$PYTHON_VERSION])
> ```
> 
> Then, when using `configure`, I've checked the output.
> ```
> $ ../configure 
> ...
> configure: /usr/bin/python
> configure: 2.7
> $ PYTHON_VERSION=4 ../configure
> ...
> configure: python4
> configure: 4
> $ PYTHON=yolo ../configure
> ...
> configure: yolo
> configure:
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204687
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67546', '67547']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67547

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67547/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (104 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1032 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (70 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (755 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (778 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (733 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (757 ms total)

[--] Global test environment tear-down
[==] 988 tests from 97 test cases ran. (463113 ms total)
[  PASSED  ] 987 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] 
ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.SigkillExecutor/0, 
where GetParam() = "docker,mesos"

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67547/logs/mesos-tests-stderr.log):

```
I0613 13:49:25.561110  6468 master.cpp:10863] Updating the state of task 
cb673298-e8d5-453b-bcb9-435b10452873 of framework 
55f6394e-b156-402c-b793-d3efd6ae6d72- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0613 13:49:25.561110  6660 slave.cpp:3939] Shutting down framework 
55f6394e-b156-402c-b793-d3efd6ae6d72-
I061I0613 13:49:25.405112  6428 exec.cpp:162] Version: 1.7.0
I0613 13:49:25.430110  6668 exec.cpp:236] Executor registered on agent 
55f6394e-b156-402c-b793-d3efd6ae6d72-S0
I0613 13:49:25.434110  5808 executor.cpp:178] Received SUBSCRIBED event
I0613 13:49:25.439121  5808 executor.cpp:182] Subscribed executor on 
windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0613 13:49:25.439121  5808 executor.cpp:178] Received LAUNCH event
I0613 13:49:25.444113  5808 executor.cpp:665] Starting task 
cb673298-e8d5-453b-bcb9-435b10452873
I0613 13:49:25.522122  5808 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0613 13:49:25.534116  5808 executor.cpp:678] Forked command at 6252
I0613 13:49:25.563112  3720 exec.cpp:445] Executor asked to shutdown
I0613 13:49:25.565114  5808 executor.cpp:178] Received SHUTDOWN event
I0613 13:49:25.565114  5808 executor.cpp:781] Shutting down
I0613 13:49:25.565114  5808 executor.cpp:894] Sending SIGTERM to process tree 
at pid 6253 13:49:25.561110  6660 slave.cpp:6660] Shutting down executor 
'cb673298-e8d5-453b-bcb9-435b10452873' of framework 
55f6394e-b156-402c-b793-d3efd6ae6d72- at executor(1)@192.10.1.6:52494
I0613 13:49:25.563112  6468 master.cpp:10962] Removing task 
cb673298-e8d5-453b-bcb9-435b10452873 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 55f6394e-b156-402c-b793-d3efd6ae6d72- on 
agent 55f6394e-b156-402c-b793-d3efd6ae6d72-S0 at slave(449)@192.10.1.6:52473 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0613 13:49:25.564115  6660 slave.cpp:931] Agent terminating
W0613 13:49:25.564115  6660 slave.cpp:3935] Ignoring shutdown framework 
55f6394e-b156-402c-b793-d3efd6ae6d72- because it is terminating
I0613 13:49:25.567112  7092 master.cpp:1293] Agent 
55f6394e-b156-402c-b793-d3efd6ae6d72-S0 at slave(449)@192.10.1.6:52473 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0613 13:49:25.567112  7092 master.cpp:3303] Disconnecting agent 
55f6394e-b156-402c-b793-d3efd6ae6d72-S0 at slave(449)@192.10.1.6:52473 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0613 13:49:25.568107  5528 hierarchical.cpp:344] Removed framework 
55f6394e-b156-402c-b793-d3efd6ae6d72-
I0613 13:49:25.568107  7092 master.cpp:3322] Deactivating agent 

Re: Review Request 67411: Broadened check for Autotools Python environment variables.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67411/#review204686
---


Ship it!




Ship It!

- Kevin Klues


On June 1, 2018, 3:06 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67411/
> ---
> 
> (Updated June 1, 2018, 3:06 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The checks now also apply if we run configure with disabled Python
> bindings but enabled new CLI.
> 
> 
> Diffs
> -
> 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
> 
> 
> Diff: https://reviews.apache.org/r/67411/diff/2/
> 
> 
> Testing
> ---
> 
> ```
> $ PYTHON=yolo PYTHON_VERSION=3 ../configure --disable-java --disable-python 
> --enable-new-cli
> ...
> configure: error: only specify one of PYTHON or PYTHON_VERSION
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review204685
---




src/python/cli_new/bootstrap
Lines 48-62 (original), 46-72 (patched)


Three is a better method of creating a virtualenv with python 3. Please see 
https://github.com/dcos/dcos-cli/blob/992d516cec5b7e21154190ae121c3c85b73baa17/python/bin/env.sh#L36
 for reference.



src/python/cli_new/lib/cli/tests/base.py
Lines 184-188 (original), 187-190 (patched)


Reverse the order of these.



src/python/cli_new/lib/cli/tests/base.py
Line 275 (original), 268-274 (patched)


Reverse this.



src/python/cli_new/lib/cli/tests/base.py
Lines 268-273 (patched)


Format similar to for Master with just 4 lines.



src/python/cli_new/lib/cli/tests/base.py
Lines 277-278 (original), 276-278 (patched)


Can you move this inside the try and have a finally that subtracts the 
Agent count? This may not work, because we return from the try, but it's worth 
a (sic) try.



src/python/cli_new/lib/cli/util.py
Lines 164-166 (original), 164-166 (patched)


Remove this comment


- Kevin Klues


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/2/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204684
---


Ship it!




Ship It!

- Jan Schlicht


On June 13, 2018, 1:02 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> ---
> 
> (Updated June 13, 2018, 1:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67547/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67525: Removed static variable with non-constant initialization.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67525/#review204683
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67525']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67525

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67525/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (127 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1131 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (36 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (40 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (80 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (851 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (875 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (843 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (867 ms total)

[--] Global test environment tear-down
[==] 988 tests from 97 test cases ran. (496495 ms total)
[  PASSED  ] 987 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.SigkillExecutor/0, where 
GetParam() = "mesos"

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67525/logs/mesos-tests-stderr.log):

```
I0613 11:51:07.106554   716 slave.cpp:3939] Shutting down framework 
91665eeb-576a-4d3e-94f9-647cc079b9d8-
I0613 11:51:07.106554  1328 master.cpp:10863] Updating the state of task 
9114be25-ec5c-4382-825a-06f69637a116 of framework 
91665eeb-576a-4d3e-94f9-647cc079b9d8- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0613 11:51:07.106554   716 slave.cpp:6660] Shutting down executor 
'9114be25-ec5c-4382-825a-06f69637a116' of framework 
91665eeb-576a-4d3e-94f9-647cc079b9d8- at executor(1)@192.10.1.5:52339
I0613 11:51:07.108556   716 slave.cpp:931] Agent terminating
W0613 11:51:07.109555   716 slave.cppI0613 11:51:06.933574   604 exec.cpp:162] 
Version: 1.7.0
I0613 11:51:06.961549  2352 exec.cpp:236] Executor registered on agent 
91665eeb-576a-4d3e-94f9-647cc079b9d8-S0
I0613 11:51:06.965580  2124 executor.cpp:178] Received SUBSCRIBED event
I0613 11:51:06.970556  2124 executor.cpp:182] Subscribed executor on 
windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0613 11:51:06.971556  2124 executor.cpp:178] Received LAUNCH event
I0613 11:51:06.976554  2124 executor.cpp:665] Starting task 
9114be25-ec5c-4382-825a-06f69637a116
I0613 11:51:07.062561  2124 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0613 11:51:07.076561  2124 executor.cpp:678] Forked command at 7056
I0613 11:51:07.109555  7648 exec.cpp:445] Executor asked to shutdown
I0613 11:51:07.110556  2124 executor.cpp:178] Received SHUTDOWN event
I0613 11:51:07.110556  2124 executor.cpp:781] Shutting down
I0613 11:51:07.110556  2124 executor.cpp:894] Sending SIGTERM to process tree 
at pid 705:3935] Ignoring shutdown framework 
91665eeb-576a-4d3e-94f9-647cc079b9d8- because it is terminating
I0613 11:51:07.110556  1328 master.cpp:10962] Removing task 
9114be25-ec5c-4382-825a-06f69637a116 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 91665eeb-576a-4d3e-94f9-647cc079b9d8- on 
agent 91665eeb-576a-4d3e-94f9-647cc079b9d8-S0 at slave(449)@192.10.1.5:52318 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0613 11:51:07.113554  5536 master.cpp:1293] Agent 
91665eeb-576a-4d3e-94f9-647cc079b9d8-S0 at slave(449)@192.10.1.5:52318 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0613 11:51:07.113554  5536 master.cpp:3303] Disconnecting agent 
91665eeb-576a-4d3e-94f9-647cc079b9d8-S0 at slave(449)@192.10.1.5:52318 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0613 11:51:07.114547  5536 master.cpp:3322] Deactivating agent 
91665eeb-576a-4d3e-94f9-647cc079b9d8-S0 at slave(449)@192.10.1.5:52318 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0613 

Re: Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67554/#review204682
---



Patch looks great!

Reviews applied: [67554]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 12, 2018, 9:09 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67554/
> ---
> 
> (Updated June 12, 2018, 9:09 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Header files are not necessary (and so are redundant) in CMake.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/CMakeLists.txt 
> eb88afb8bef1205d0c14a6a6cf414d99f20eb1a7 
> 
> 
> Diff: https://reviews.apache.org/r/67554/diff/1/
> 
> 
> Testing
> ---
> 
> libprocess-tests built and ran on Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67354/#review204681
---




include/mesos/executor.hpp
Lines 220-223 (patched)


Maybe add this comment to the previous constructor saying that the other 
one is preferable? I think that way it will be easier for users to figure out 
they use a not favoured c-tor : )



src/exec/exec.cpp
Line 646 (original), 654 (patched)


I doubt this does what you want it to do. At the end, `FlagsBase` calls 
`extract()` on the prefix, which in turn calls `os::environment()`. Please 
either mention here that env is loaded under the hood (as Ilya suggested 
before), or fix the flags to not load the environment at all.

Maybe doing the latter should be part of a bigger change where we make 
`FlagsBase` instances never load from the environment (but provide a static 
function to do so). I will be happy to shepherd this work and chain it 
immediately after this change so it does not fall through the cracks.


- Alexander Rukletsov


On May 29, 2018, 2:20 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67354/
> ---
> 
> (Updated May 29, 2018, 2:20 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent 
> huang, Ilya Pronin, and James Peach.
> 
> 
> Bugs: MESOS-3475
> https://issues.apache.org/jira/browse/MESOS-3475
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds overloaded constructor for `MesosExecutorDriver` that
> accepts `environment` parameter and stores it in the class variable.
> This new constructor is needed to get rid of `os::getenv()` calls,
> so that `MesosExecutorDriver` can be used in tests that require
> thread safety.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor.hpp d14c0369f6731100d27092142b56f108f8881003 
>   src/exec/exec.cpp 65a671d7ce83a51087d290ba039d18deba6313c2 
> 
> 
> Diff: https://reviews.apache.org/r/67354/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/
---

(Updated June 13, 2018, 11:02 a.m.)


Review request for mesos, Alexander Rukletsov and Jan Schlicht.


Bugs: MESOS-8985
https://issues.apache.org/jira/browse/MESOS-8985


Repository: mesos


Description
---

A client can request any endpoint to stream its response using
the RecordIO format. However, we never checked whether the selected
endpoint actually supports streaming, leading to an agent crash
when it was used for endpoints that did not expect such a request.


Diffs (updated)
-

  src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c 
  src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 


Diff: https://reviews.apache.org/r/67547/diff/3/

Changes: https://reviews.apache.org/r/67547/diff/2-3/


Testing
---

`make check`


Thanks,

Benno Evers

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204676
---



PASS: Mesos patch 67547 was successfully built and tested.

Reviews applied: `['67546', '67547']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67547

- Mesos Reviewbot Windows


On June 12, 2018, 4:08 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> ---
> 
> (Updated June 12, 2018, 4:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67547/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204674
---




src/tests/api_tests.cpp
Lines 7283 (patched)


Does it make sense to add this case to `AgentAPITest.HeaderValidation`?



src/tests/api_tests.cpp
Lines 7285-7287 (patched)


Fits in one line.



src/tests/api_tests.cpp
Lines 7292 (patched)


We don't have to start a master to test this response of the agent API.


- Jan Schlicht


On June 12, 2018, 6:08 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> ---
> 
> (Updated June 12, 2018, 6:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67547/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review204673
---



Regarding the commit: the Testing Done part should be filled.


support/python3/verify-reviews.py
Line 36 (original), 36 (patched)


Unused to the comment marker added before `@atexit.register` line 138.



support/python3/verify-reviews.py
Lines 56 (patched)


Missing docstring.



support/python3/verify-reviews.py
Lines 75 (patched)


Wrong indentation.



support/python3/verify-reviews.py
Line 138 (original), 122 (patched)


Line too long.



support/python3/verify-reviews.py
Line 255 (original), 240 (patched)


Missing docstring.



support/python3/verify-reviews.py
Lines 259 (patched)


Line too long.


- Armand Grillet


On June 8, 2018, 12:07 p.m., Dragos Schebesch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> ---
> 
> (Updated June 8, 2018, 12:07 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored verify-reviews.py to use commons.py and argparse
> 
> 
> Diffs
> -
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67504: Added helper for posting the result of a build

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/#review204672
---



Regarding the commit: its message should be more descriptive regarding the 
reasons behind this new support script and the Testing Done part should be 
filled with at least some tests or the fact that tests can be read later in the 
chain.


support/python3/post-build-result.py
Lines 18 (patched)


Missing docstring.



support/python3/post-build-result.py
Lines 29 (patched)


Missing docstring.



support/python3/post-build-result.py
Lines 43 (patched)


Wrong continued indentation.



support/python3/post-build-result.py
Lines 53 (patched)


Having [] as argument is dangerous. The problem with a mutable default 
argument is that it will be shared between all invocations of the function. 
This should be replaced by:
```
def get_build_message(message, outputs_url, logs_urls=None, 
applied_reviews=None,
  failed_command=None):
if logs_urls is None:
logs_urls = []
if applied_reviews is None:
applied_reviews = []
```



support/python3/post-build-result.py
Lines 55 (patched)


Missing docstring.



support/python3/post-build-result.py
Lines 81 (patched)


Missing docstring.


- Armand Grillet


On June 8, 2018, 12:07 p.m., Dragos Schebesch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67504/
> ---
> 
> (Updated June 8, 2018, 12:07 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper for posting the result of a build
> 
> 
> Diffs
> -
> 
>   support/python3/post-build-result.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67504/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67503: Added helper for fetching review id

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/#review204669
---



I would rename the script `get-dependent-reviews.py` to be more explicit. 
Regarding the commit: its message should be more descriptive regarding the 
reasons behind this new support script and the Testing Done part should be 
filled with at least some tests or the fact that tests can be read later in the 
chain.


support/python3/get-review-ids.py
Lines 18 (patched)


Missing docstring.



support/python3/get-review-ids.py
Lines 21 (patched)


`# noqa`?
Also, we generally make each import its own line (at least in the Python 
CLI codebase).



support/python3/get-review-ids.py
Lines 25 (patched)


Missing docstring.



support/python3/get-review-ids.py
Lines 29 (patched)


Why is it required? Not having an output file should result in having the 
dependent review IDs printed which is done in the last for loop of 
`support/python3/common.py`.



support/python3/get-review-ids.py
Lines 35 (patched)


Missing docstring.


- Armand Grillet


On June 8, 2018, 12:07 p.m., Dragos Schebesch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67503/
> ---
> 
> (Updated June 8, 2018, 12:07 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper for fetching review id
> 
> 
> Diffs
> -
> 
>   support/python3/get-review-ids.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67503/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67502: Refactored API functionality into separate module

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/#review204667
---



Regarding the commit: its message should be more descriptive regarding the 
reasons behind this new file and the `Testing Done` part should be filled with 
at least some tests or the fact that tests can be read later in the chain.


support/python3/common.py
Lines 1 (patched)


`#!/usr/bin/env python3`?



support/python3/common.py
Lines 18 (patched)


Missing docstring. Could be:

```
# limitations under the License.

"""
These common helper classes help to manage the connection between the 
machine and ReviewBoard.
"""

from datetime import datetime
```



support/python3/common.py
Lines 34 (patched)


Missing class docstring.



support/python3/common.py
Lines 40 (patched)


Having [] as argument is dangerous. The problem with a mutable default 
argument is that it will be shared between all invocations of the function. 
This should be replaced by:

```
_review_ids(self, review_request, review_ids=None):
if review_ids is None:
review_ids = []
```



support/python3/common.py
Lines 58 (patched)


s/`Call`/`Calls`



support/python3/common.py
Lines 79 (patched)


s/`get_review_ids`/`get_dependent_review_ids`



support/python3/common.py
Lines 90 (patched)


s/`Post`/`Posts`



support/python3/common.py
Lines 107 (patched)


s/`Post`/`Posts`



support/python3/common.py
Lines 108 (patched)


s.`review:`/`review`



support/python3/common.py
Lines 114 (patched)


r/`already already`/`already`



support/python3/common.py
Lines 147 (patched)


This could be more descriptive, e.g. `This patch has been updated since its 
last review, needs verification`. Also, sometimes devs rebase the review 
request but the diff is empty and in that case the diff should not need a new 
verification.


- Armand Grillet


On June 8, 2018, 12:07 p.m., Dragos Schebesch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67502/
> ---
> 
> (Updated June 8, 2018, 12:07 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored API functionality into separate module
> 
> 
> Diffs
> -
> 
>   support/python3/common.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67502/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review204670
---



PASS: Mesos patch 67488 was successfully built and tested.

Reviews applied: `['67411', '67412', '67413', '67487', '67488']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

- Mesos Reviewbot Windows


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/2/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67525: Removed static variable with non-constant initialization.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67525/
---

(Updated June 13, 2018, 9:23 a.m.)


Review request for mesos.


Changes
---

Added tests.


Repository: mesos


Description (updated)
---

The static variable was initialized using a dynamic memory
allocation. This is against our coding style, and makes it
as easy as writing

static process::http::NotFound DEFAULT_RESPONSE;

for a user to introduce a potential segfault into his code.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
055447e13117c0a3ba79d0fc326ece657e8f064f 
  3rdparty/libprocess/src/decoder.hpp a0784358d63279022473fdf82a72b7ecc9056658 
  3rdparty/libprocess/src/http.cpp 9fd5ea02ee57b4ad2d30c4b9ac4cbd299942d501 
  3rdparty/libprocess/src/tests/http_tests.cpp 
ca1ea116866b5ccd3d42e93dd5bd7fed2234df0d 


Diff: https://reviews.apache.org/r/67525/diff/2/

Changes: https://reviews.apache.org/r/67525/diff/1-2/


Testing
---

`make check`


Thanks,

Benno Evers

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

[Qian Zhang]

> On June 7, 2018, 7:50 a.m., Gilbert Song wrote:
> > docs/upgrades.md
> > Lines 451 (patched)
> > 
> >
> > s/causes/allows/g?
> > 
> > Could you also emphasize that the default behavior does not change?

Did you mean the default behavior of the agent flag `--isolaton` does not 
change if the option `cgroups/all` is not specified?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/#review204439
---


On June 1, 2018, 11:28 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67381/
> ---
> 
> (Updated June 1, 2018, 11:28 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `cgroups/all` into CHANGELOG and upgrades.md.
> 
> 
> Diffs
> -
> 
>   CHANGELOG bdcf8e33b95f4bea04b64417aa73df44dd456afe 
>   docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f 
> 
> 
> Diff: https://reviews.apache.org/r/67381/diff/2/
> 
> 
> Testing
> ---
> 
> Not a code change.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67551: Fixed `push-commits.py` for Windows.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67551/#review204666
---


Ship it!




Ship It!

- Armand Grillet


On June 12, 2018, 5:41 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67551/
> ---
> 
> (Updated June 12, 2018, 5:41 p.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script didn't work even before the port to Python 3, as
> `os.path.join` cannot be used for joining URL components, as the
> filesystem path separator on Windows is a backslash.
> 
> 
> Diffs
> -
> 
>   support/python3/push-commits.py ef63d1a7c05605cebcce9cdcb6d38365570a1b59 
> 
> 
> Diff: https://reviews.apache.org/r/67551/diff/1/
> 
> 
> Testing
> ---
> 
> > python .\support\python3\push-commits.py --dry-run
> Pushing commits to apache
> To https://git-wip-us.apache.org/repos/asf/mesos.git
>f1c0377a9..8ffe29363  master -> master
> Closing review 67551
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67567: Rename variable names in slave.hpp to be more explicit.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67567/#review204665
---



PASS: Mesos patch 67567 was successfully built and tested.

Reviews applied: `['67538', '67567']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67567

- Mesos Reviewbot Windows


On June 13, 2018, 6:17 a.m., bin zheng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67567/
> ---
> 
> (Updated June 13, 2018, 6:17 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the variable name of the Class "Slave", "Executor" and "Framework" in 
> Slave.hpp, eg: change "info" to "slaveInfo", "executorInfo" or 
> "frameworkInfo".  also change others in related files: http.cpp and slave.cpp.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
>   src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 
>   src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a 
> 
> 
> Diff: https://reviews.apache.org/r/67567/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bin zheng
> 
>

Re: Review Request 67551: Fixed `push-commits.py` for Windows.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67551/#review204664
---



Patch looks great!

Reviews applied: [67551]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 13, 2018, 1:41 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67551/
> ---
> 
> (Updated June 13, 2018, 1:41 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script didn't work even before the port to Python 3, as
> `os.path.join` cannot be used for joining URL components, as the
> filesystem path separator on Windows is a backslash.
> 
> 
> Diffs
> -
> 
>   support/python3/push-commits.py ef63d1a7c05605cebcce9cdcb6d38365570a1b59 
> 
> 
> Diff: https://reviews.apache.org/r/67551/diff/1/
> 
> 
> Testing
> ---
> 
> > python .\support\python3\push-commits.py --dry-run
> Pushing commits to apache
> To https://git-wip-us.apache.org/repos/asf/mesos.git
>f1c0377a9..8ffe29363  master -> master
> Closing review 67551
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 67567: Rename variable names in slave.hpp to be more explicit.

[bin zheng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67567/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Changed the variable name of the Class "Slave", "Executor" and "Framework" in 
Slave.hpp, eg: change "info" to "slaveInfo", "executorInfo" or "frameworkInfo". 
 also change others in related files: http.cpp and slave.cpp.


Diffs
-

  src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
  src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 
  src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a 


Diff: https://reviews.apache.org/r/67567/diff/1/


Testing
---


Thanks,

bin zheng