Review Request 68924: Updated the Docker library to avoid 'os::killtree()'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68924/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-9283
https://issues.apache.org/jira/browse/MESOS-9283


Repository: mesos


Description
---

This patch updates the Docker library to consistently use the
overload of `subprocess()` which runs its binary via `exec()`
rather than through a shell. This makes it safe to use
`os::kill()` rather than `os::killtree()` when discarding
these commands, which this patch also accomplishes.


Diffs
-

  src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5 


Diff: https://reviews.apache.org/r/68924/diff/1/


Testing
---

`sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"`


Thanks,

Greg Mann

Review Request 68923: Updated 'Docker::inspect()' to avoid 'os::killtree()'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68923/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-9283
https://issues.apache.org/jira/browse/MESOS-9283


Repository: mesos


Description
---

When futures returned by `Docker::inspect()` are discarded
frequently, agent node performance can be negatively
impacted due to the `os::killtree()` call in the discard
handler.

This patch avoids running `docker inspect` commands through
a shell so that it's safe to use `os::kill()` when
discarding the returned futures.

This change is being made independently from similar
changes to the rest of the Docker library so that it can be
more easily backported to previous versions, since issues
related to `Docker::inspect()` in particular have been
observed.


Diffs
-

  src/docker/docker.hpp 25d9ca662fa5d99b32c668a5fdfc75584132cc38 
  src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5 


Diff: https://reviews.apache.org/r/68923/diff/1/


Testing
---

`sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"`


Thanks,

Greg Mann

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68921/#review209204
---



PASS: Mesos patch 68921 was successfully built and tested.

Reviews applied: `['68921']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2417/mesos-review-68921

- Mesos Reviewbot Windows


On Oct. 3, 2018, 10:36 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68921/
> ---
> 
> (Updated Oct. 3, 2018, 10:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-9270
> https://issues.apache.org/jira/browse/MESOS-9270
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The last release of `net-tools` was released in 2001. The tools were
> deprecated years ago (see [1], [2], and [3]) and no longer installed
> by default in many linux-based operating systems.
> 
> Bring up the loopback interface using `ip` from `iproute2` and if it
> fails to start fall back on `ifconfig` from `net-tools`.
> 
> [1] https://lists.debian.org/debian-devel/2009/03/msg00780.html
> [2] https://bugzilla.redhat.com/show_bug.cgi?id=687920
> [3] https://lwn.net/Articles/710533/
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> ba465522b0de663cf17ff8ca035f6eb32cbd73f1 
> 
> 
> Diff: https://reviews.apache.org/r/68921/diff/1/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.*" 
> --gtest_break_on_failure --gtest_repeat=10
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

[Gilbert Song]

> On Oct. 3, 2018, 3:43 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
> > Lines 2268-2270 (patched)
> > 
> >
> > Do we still need this fallback if we are confident enough? or consider 
> > a TODO to remove the fallback logic?
> 
> Sergey Urbanovich wrote:
> I would prefer to keep this fallback in case if someone has a custom 
> linux-based system with `ifconfig`, but without `ip`. There is a TODO commend 
> above, ideally we shouldn't use both of the commands.

SGTM!


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68921/#review209201
---


On Oct. 3, 2018, 3:36 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68921/
> ---
> 
> (Updated Oct. 3, 2018, 3:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-9270
> https://issues.apache.org/jira/browse/MESOS-9270
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The last release of `net-tools` was released in 2001. The tools were
> deprecated years ago (see [1], [2], and [3]) and no longer installed
> by default in many linux-based operating systems.
> 
> Bring up the loopback interface using `ip` from `iproute2` and if it
> fails to start fall back on `ifconfig` from `net-tools`.
> 
> [1] https://lists.debian.org/debian-devel/2009/03/msg00780.html
> [2] https://bugzilla.redhat.com/show_bug.cgi?id=687920
> [3] https://lwn.net/Articles/710533/
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> ba465522b0de663cf17ff8ca035f6eb32cbd73f1 
> 
> 
> Diff: https://reviews.apache.org/r/68921/diff/1/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.*" 
> --gtest_break_on_failure --gtest_repeat=10
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68906: Fixed ssl build specific incompatiblity with libevent later than 2.1.5.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68906/
---

(Updated Oct. 3, 2018, 11:06 p.m.)


Review request for mesos, Benjamin Mahler and James Peach.


Changes
---

Addressed comment - thanks Ben!


Bugs: MESOS-9265
https://issues.apache.org/jira/browse/MESOS-9265


Repository: mesos


Description
---

Up until and including libevent 2.1.5 (beta) the buffer events EV_READ
and EV_WRITE were enabled by default in the openssl related socket
setup.

That got changed by f4b6284b8393dbabf389ddce734a30f4cdeffa17 within
libevent; the default expectancy of read and write buffer events got
removed.

The changes in libevent in turn caused our implementation on top of it
to fail, typically directly after accept and connect calls.

The libevent maintainer Azat Khuzhin has generously been helping us out
by debugging and fixing the incomplete setup within libprocess.

This patch is based on Azat's suggestions from https://goo.gl/4CK3PD.
It has been validated against libevent 2.0.22, 2.1.8 and 2.2 (alpha)
on macOS 10.14.1 and Ubuntu 16.04.


Diffs (updated)
-

  3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp 
436b38913e43233e352cf9783da8fafefa42226f 


Diff: https://reviews.apache.org/r/68906/diff/2/

Changes: https://reviews.apache.org/r/68906/diff/1-2/


Testing
---

make check with and without bundled libevent.

Tested combinations were:
macOS 10.14.1 - libevent 2.2
macOS 10.14.1 - libevent 2.1.8
macOS 10.14.1 - libevent 2.0.22 
Ubuntu 16.04  - libevent 2.1.8


Thanks,

Till Toenshoff

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

[Sergey Urbanovich]

> On Oct. 3, 2018, 10:43 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
> > Lines 2268-2270 (patched)
> > 
> >
> > Do we still need this fallback if we are confident enough? or consider 
> > a TODO to remove the fallback logic?

I would prefer to keep this fallback in case if someone has a custom 
linux-based system with `ifconfig`, but without `ip`. There is a TODO commend 
above, ideally we shouldn't use both of the commands.


- Sergey


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68921/#review209201
---


On Oct. 3, 2018, 10:36 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68921/
> ---
> 
> (Updated Oct. 3, 2018, 10:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-9270
> https://issues.apache.org/jira/browse/MESOS-9270
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The last release of `net-tools` was released in 2001. The tools were
> deprecated years ago (see [1], [2], and [3]) and no longer installed
> by default in many linux-based operating systems.
> 
> Bring up the loopback interface using `ip` from `iproute2` and if it
> fails to start fall back on `ifconfig` from `net-tools`.
> 
> [1] https://lists.debian.org/debian-devel/2009/03/msg00780.html
> [2] https://bugzilla.redhat.com/show_bug.cgi?id=687920
> [3] https://lwn.net/Articles/710533/
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> ba465522b0de663cf17ff8ca035f6eb32cbd73f1 
> 
> 
> Diff: https://reviews.apache.org/r/68921/diff/1/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.*" 
> --gtest_break_on_failure --gtest_repeat=10
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68921/#review209201
---




src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
Lines 2268-2270 (patched)


Do we still need this fallback if we are confident enough? or consider a 
TODO to remove the fallback logic?


- Gilbert Song


On Oct. 3, 2018, 3:36 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68921/
> ---
> 
> (Updated Oct. 3, 2018, 3:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-9270
> https://issues.apache.org/jira/browse/MESOS-9270
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The last release of `net-tools` was released in 2001. The tools were
> deprecated years ago (see [1], [2], and [3]) and no longer installed
> by default in many linux-based operating systems.
> 
> Bring up the loopback interface using `ip` from `iproute2` and if it
> fails to start fall back on `ifconfig` from `net-tools`.
> 
> [1] https://lists.debian.org/debian-devel/2009/03/msg00780.html
> [2] https://bugzilla.redhat.com/show_bug.cgi?id=687920
> [3] https://lwn.net/Articles/710533/
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> ba465522b0de663cf17ff8ca035f6eb32cbd73f1 
> 
> 
> Diff: https://reviews.apache.org/r/68921/diff/1/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.*" 
> --gtest_break_on_failure --gtest_repeat=10
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68921/#review209200
---


Ship it!




Ship It!

- Gilbert Song


On Oct. 3, 2018, 3:36 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68921/
> ---
> 
> (Updated Oct. 3, 2018, 3:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-9270
> https://issues.apache.org/jira/browse/MESOS-9270
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The last release of `net-tools` was released in 2001. The tools were
> deprecated years ago (see [1], [2], and [3]) and no longer installed
> by default in many linux-based operating systems.
> 
> Bring up the loopback interface using `ip` from `iproute2` and if it
> fails to start fall back on `ifconfig` from `net-tools`.
> 
> [1] https://lists.debian.org/debian-devel/2009/03/msg00780.html
> [2] https://bugzilla.redhat.com/show_bug.cgi?id=687920
> [3] https://lwn.net/Articles/710533/
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> ba465522b0de663cf17ff8ca035f6eb32cbd73f1 
> 
> 
> Diff: https://reviews.apache.org/r/68921/diff/1/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.*" 
> --gtest_break_on_failure --gtest_repeat=10
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Review Request 68921: Bring up the loopback interface using `iproute2`.

[Sergey Urbanovich]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68921/
---

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-9270
https://issues.apache.org/jira/browse/MESOS-9270


Repository: mesos


Description
---

The last release of `net-tools` was released in 2001. The tools were
deprecated years ago (see [1], [2], and [3]) and no longer installed
by default in many linux-based operating systems.

Bring up the loopback interface using `ip` from `iproute2` and if it
fails to start fall back on `ifconfig` from `net-tools`.

[1] https://lists.debian.org/debian-devel/2009/03/msg00780.html
[2] https://bugzilla.redhat.com/show_bug.cgi?id=687920
[3] https://lwn.net/Articles/710533/


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
ba465522b0de663cf17ff8ca035f6eb32cbd73f1 


Diff: https://reviews.apache.org/r/68921/diff/1/


Testing
---

bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.*" 
--gtest_break_on_failure --gtest_repeat=10


Thanks,

Sergey Urbanovich

Re: Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68919/#review209199
---



PASS: Mesos patch 68919 was successfully built and tested.

Reviews applied: `['68919']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2416/mesos-review-68919

- Mesos Reviewbot Windows


On Oct. 3, 2018, 8:55 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68919/
> ---
> 
> (Updated Oct. 3, 2018, 8:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unbundling by default for libevent on macOS when using CMake.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake a820c867b41d2120525c5a32128812ae527ffeba 
> 
> 
> Diff: https://reviews.apache.org/r/68919/diff/1/
> 
> 
> Testing
> ---
> 
> macos: cmake .. -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON  
> -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 
> -G Ninja && ninja check -j12
> macos: cmake .. -DUNBUNDLED_LIBEVENT=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON 
> -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 
> -G Ninja && ninja check -j12
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 68507: Pulled out nested `Framework` and `Slave` classes in the allocator.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68507/#review209198
---


Ship it!




Ship It!

- Benjamin Mahler


On Sept. 25, 2018, 8:49 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68507/
> ---
> 
> (Updated Sept. 25, 2018, 8:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This makes clearer logic division with the allocator.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> e09a615979014909e7b88d44e6617fd1476415c5 
>   src/master/allocator/mesos/hierarchical.cpp 
> 906fddc48c52ec222b93d15d53edf9680d2cd861 
> 
> 
> Diff: https://reviews.apache.org/r/68507/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 68508: Added tracking of framework allocations in the allocator Slave class.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68508/#review209197
---


Ship it!




Can you do a quick benchmark comparison to see if this has a significant impact?


src/master/allocator/mesos/hierarchical.hpp
Lines 157 (patched)


If you CHECK this, should you also do a containment check before the 
subtraction below?


- Benjamin Mahler


On Sept. 25, 2018, 8:49 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68508/
> ---
> 
> (Updated Sept. 25, 2018, 8:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9182
> https://issues.apache.org/jira/browse/MESOS-9182
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This would simplify the tracking logic regarding
> resource allocations in the allocator. See MESOS-9182.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> e09a615979014909e7b88d44e6617fd1476415c5 
>   src/master/allocator/mesos/hierarchical.cpp 
> 906fddc48c52ec222b93d15d53edf9680d2cd861 
> 
> 
> Diff: https://reviews.apache.org/r/68508/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 68906: Fixed ssl build specific incompatiblity with libevent later than 2.1.5.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68906/#review209196
---


Fix it, then Ship it!




Thanks for tracking this down!


3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp
Lines 1214-1216 (patched)


Can you include a pointer to a ticket or something here and above for 
posterity?


- Benjamin Mahler


On Oct. 3, 2018, 1:31 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68906/
> ---
> 
> (Updated Oct. 3, 2018, 1:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and James Peach.
> 
> 
> Bugs: MESOS-9265
> https://issues.apache.org/jira/browse/MESOS-9265
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Up until and including libevent 2.1.5 (beta) the buffer events EV_READ
> and EV_WRITE were enabled by default in the openssl related socket
> setup.
> 
> That got changed by f4b6284b8393dbabf389ddce734a30f4cdeffa17 within
> libevent; the default expectancy of read and write buffer events got
> removed.
> 
> The changes in libevent in turn caused our implementation on top of it
> to fail, typically directly after accept and connect calls.
> 
> The libevent maintainer Azat Khuzhin has generously been helping us out
> by debugging and fixing the incomplete setup within libprocess.
> 
> This patch is based on Azat's suggestions from https://goo.gl/4CK3PD.
> It has been validated against libevent 2.0.22, 2.1.8 and 2.2 (alpha)
> on macOS 10.14.1 and Ubuntu 16.04.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp 
> 436b38913e43233e352cf9783da8fafefa42226f 
> 
> 
> Diff: https://reviews.apache.org/r/68906/diff/1/
> 
> 
> Testing
> ---
> 
> make check with and without bundled libevent.
> 
> Tested combinations were:
> macOS 10.14.1 - libevent 2.2
> macOS 10.14.1 - libevent 2.1.8
> macOS 10.14.1 - libevent 2.0.22 
> Ubuntu 16.04  - libevent 2.1.8
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68919/
---

Review request for mesos, Benjamin Bannier and James Peach.


Repository: mesos


Description
---

Removed unbundling by default for libevent on macOS when using CMake.


Diffs
-

  cmake/CompilationConfigure.cmake a820c867b41d2120525c5a32128812ae527ffeba 


Diff: https://reviews.apache.org/r/68919/diff/1/


Testing
---

macos: cmake .. -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON  
-DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G 
Ninja && ninja check -j12
macos: cmake .. -DUNBUNDLED_LIBEVENT=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON 
-DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G 
Ninja && ninja check -j12


Thanks,

Till Toenshoff

Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68916/#review209194
---



PASS: Mesos patch 68916 was successfully built and tested.

Reviews applied: `['68904', '68905', '68906', '68913', '68914', '68915', 
'68916']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2415/mesos-review-68916

- Mesos Reviewbot Windows


On Oct. 3, 2018, 7:32 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68916/
> ---
> 
> (Updated Oct. 3, 2018, 7:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Combines all libevent related header and library checks into
> libevent.m4.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac c3e39643924dd4581d46e3d4e1b89b409d823e88 
>   3rdparty/libprocess/m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b 
> 
> 
> Diff: https://reviews.apache.org/r/68916/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68916/
---

(Updated Oct. 3, 2018, 7:32 p.m.)


Review request for mesos, Benjamin Bannier and James Peach.


Repository: mesos


Description (updated)
---

Combines all libevent related header and library checks into
libevent.m4.


Diffs
-

  3rdparty/libprocess/configure.ac c3e39643924dd4581d46e3d4e1b89b409d823e88 
  3rdparty/libprocess/m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b 


Diff: https://reviews.apache.org/r/68916/diff/1/


Testing
---

make check


Thanks,

Till Toenshoff

Re: Review Request 68915: Moved libevent_openssl validation into libevent.m4.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68915/
---

(Updated Oct. 3, 2018, 7:32 p.m.)


Review request for mesos, Benjamin Bannier and James Peach.


Repository: mesos


Description (updated)
---

Combines all libevent related header and library checks into
libevent.m4.


Diffs
-

  configure.ac 505201a1ce84834b574067650993ce51cf1e1d5d 
  m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b 


Diff: https://reviews.apache.org/r/68915/diff/1/


Testing
---

make check


Thanks,

Till Toenshoff

Re: Review Request 68913: Updated libevent linkage to adhere to best practices.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68913/#review209193
---



PASS: Mesos patch 68913 was successfully built and tested.

Reviews applied: `['68904', '68905', '68906', '68913']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2414/mesos-review-68913

- Mesos Reviewbot Windows


On Oct. 3, 2018, 4:50 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68913/
> ---
> 
> (Updated Oct. 3, 2018, 4:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9222
> https://issues.apache.org/jira/browse/MESOS-9222
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> libevent is a combination of libevent_core and libevent_extra. Mesos
> and libprocess do not make use of any libevent_extra functionality.
> 
> Additionally, linking against libevent is against best practices.
> 
> Replaces use of libevent with libevent_core in both libevent.m4 as
> well as the native Python egg linkage.
> 
> 
> Diffs
> -
> 
>   m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b 
>   src/python/native_common/ext_modules.py.in 
> df10b5c9131011b0a6b6cb83bceb6d7444aa35eb 
> 
> 
> Diff: https://reviews.apache.org/r/68913/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 68912: Added a log line to `MesosContainerizer::kill()`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68912/#review209192
---


Ship it!




Ship It!

- Gilbert Song


On Oct. 3, 2018, 8:05 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68912/
> ---
> 
> (Updated Oct. 3, 2018, 8:05 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a log line to `MesosContainerizer::kill()`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 82d64e9928abd5e22493fa697d7b0910211533f3 
> 
> 
> Diff: https://reviews.apache.org/r/68912/diff/1/
> 
> 
> Testing
> ---
> 
> make -j3 check
> 
> Ran it through internal CI.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Review Request 68915: Moved libevent_openssl validation into libevent.m4.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68915/
---

Review request for mesos, Benjamin Bannier and James Peach.


Repository: mesos


Description
---

Combines all libevent related head and library checks into
libevent.m4.


Diffs
-

  configure.ac 505201a1ce84834b574067650993ce51cf1e1d5d 
  m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b 


Diff: https://reviews.apache.org/r/68915/diff/1/


Testing
---

make check


Thanks,

Till Toenshoff

Review Request 68916: Moved libevent_openssl validation into libevent.m4.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68916/
---

Review request for mesos, Benjamin Bannier and James Peach.


Repository: mesos


Description
---

Combines all libevent related head and library checks into
libevent.m4.


Diffs
-

  3rdparty/libprocess/configure.ac c3e39643924dd4581d46e3d4e1b89b409d823e88 
  3rdparty/libprocess/m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b 


Diff: https://reviews.apache.org/r/68916/diff/1/


Testing
---

make check


Thanks,

Till Toenshoff

Review Request 68914: Updated libevent linkage to adhere to best practices.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68914/
---

Review request for mesos, Benjamin Bannier and James Peach.


Bugs: MESOS-9222
https://issues.apache.org/jira/browse/MESOS-9222


Repository: mesos


Description
---

libevent is a combination of libevent_core and libevent_extra. Mesos
and libprocess do not make use of any libevent_extra functionality.

Additionally, linking against libevent is against best practices.

Replaces use of libevent with libevent_core in both libevent.m4 as
well as the libprocess linkage.


Diffs
-

  3rdparty/libprocess/Makefile.am 22b1395ce69f4ac630367427542fa1ad4c88b50b 
  3rdparty/libprocess/m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b 


Diff: https://reviews.apache.org/r/68914/diff/1/


Testing
---

make check


Thanks,

Till Toenshoff

Review Request 68913: Updated libevent linkage to adhere to best practices.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68913/
---

Review request for mesos, Benjamin Bannier and James Peach.


Bugs: MESOS-9222
https://issues.apache.org/jira/browse/MESOS-9222


Repository: mesos


Description
---

libevent is a combination of libevent_core and libevent_extra. Mesos
and libprocess do not make use of any libevent_extra functionality.

Additionally, linking against libevent is against best practices.

Replaces use of libevent with libevent_core in both libevent.m4 as
well as the native Python egg linkage.


Diffs
-

  m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b 
  src/python/native_common/ext_modules.py.in 
df10b5c9131011b0a6b6cb83bceb6d7444aa35eb 


Diff: https://reviews.apache.org/r/68913/diff/1/


Testing
---

make check


Thanks,

Till Toenshoff

Re: Review Request 68912: Added a log line to `MesosContainerizer::kill()`.

[Vinod Kone]

> On Oct. 3, 2018, 4:05 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> > 
> > Reviews applied: `['68912']`
> > 
> > Failed command: `Start-MesosCITesting`
> > 
> > All the build artifacts available at: 
> > http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2413/mesos-review-68912
> > 
> > Relevant logs:
> > 
> > - 
> > [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2413/mesos-review-68912/logs/mesos-tests.log):
> > 
> > ```
> > W1003 16:05:33.435480 12912 slave.cpp:3917] Ignoring shutdown framework 
> > d7d1a6b8-7f3b-439c-a27a-847a8acd066c- because it is terminating
> > I1003 16:05:33.436484 15652 master.cpp:1251] Agent 
> > d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 at slave(461)@192.10.1.5:54865 
> > (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) 
> > disconnected
> > I1003 16:05:33.437479 15652 master.cpp:3267] Disconnecting agent 
> > d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 at slave(461)@192.10.1.5:54865 
> > (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
> > I1003 16:05:33.437479 15652 master.cpp:3286] Deactivating agent 
> > d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 at slave(461)@192.10.1.5:54865 
> > (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
> > I1003 16:05:33.437479  7924 hierarchical.cpp:359] Removed framework 
> > d7d1a6b8-7f3b-439c-a27a-847a8acd066c-
> > I1003 16:05:33.437479  7924 hierarchical.cpp:803] Agent 
> > d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 deactivated
> > I1003 16:05:33.439498  8116 containerizer.cpp:2455] Destroying container 
> > 0da637c0-98a8-4ad4-ac65-6cf607cbba39 in RUNNING state
> > I1003 16:05:33.439498  8116 containerizer.cpp:3122] Transitioning the state 
> > of container 0da637c0-98a8-4ad4-ac65-6cf607cbba39 from RUNNING to DESTROYING
> > I1003 16:05:33.439498  8116 launcher.cpp:166] Asked to destroy containe[
> >OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (584 ms)
> > [--] 1 test from IsolationFlag/MemoryIsolatorTest (603 ms total)
> > 
> > [--] Global test environment tear-down
> > d:\dcos\mesos\mesos\src\tests\environment.cpp(1126): error: Failed
> > Tests completed with child processes remaining:
> > -+- 1244 0024FFD8E6DC
> >  --- 15936 0024FFD8E6DC
> > [==] 1051 tests from 103 test cases ran. (489504 ms total)
> > [  PASSED  ] 1051 tests.
> > [  FAILED  ] 0 tests, listed below:
> > 
> >  0 FAILED TESTS
> > 
> >   YOU HAVE 232 DISABLED TESTS
> > 
> > r 0da637c0-98a8-4ad4-ac65-6cf607cbba39
> > I1003 16:05:33.471307  7924 containerizer.cpp:2961] Container 
> > 0da637c0-98a8-4ad4-ac65-6cf607cbba39 has exited
> > I1003 16:05:33.500296 14928 master.cpp:1093] Master terminating
> > I1003 16:05:33.502277 15652 hierarchical.cpp:645] Removed agent 
> > d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0
> > I1003 16:05:33.824251 17340 process.cpp:926] Stopped the socket accept loop
> > ```

@andy Is this a known issue with windows reviewbot?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68912/#review209187
---


On Oct. 3, 2018, 3:05 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68912/
> ---
> 
> (Updated Oct. 3, 2018, 3:05 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a log line to `MesosContainerizer::kill()`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 82d64e9928abd5e22493fa697d7b0910211533f3 
> 
> 
> Diff: https://reviews.apache.org/r/68912/diff/1/
> 
> 
> Testing
> ---
> 
> make -j3 check
> 
> Ran it through internal CI.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 67748: Added monitoring paragraph to high-availability.md.

[Till Toenshoff via Review Board]

> On June 26, 2018, 9:12 p.m., Joerg Schad wrote:
> > docs/high-availability.md
> > Lines 58 (patched)
> > 
> >
> > Can we check what the exact defintion of this metric is? (connected to 
> > each other, connected to the leader, how much does it depend on the queried 
> > master). I unfortunately do not have the correct/best formulation here at 
> > hand, but I feel that this is a bit ambigious: 
> > 
> > @xujyan should know more here.

Let's have that as another improvement once we get a definite, correct answer 
on what exactly the "ensemble size" means. ok?


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67748/#review205395
---


On June 26, 2018, 7:12 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67748/
> ---
> 
> (Updated June 26, 2018, 7:12 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added monitoring paragraph to high-availability.md.
> 
> 
> Diffs
> -
> 
>   docs/high-availability.md f5d25e910763a85ddbb8c43d3dd5019c9a3b00af 
> 
> 
> Diff: https://reviews.apache.org/r/67748/diff/1/
> 
> 
> Testing
> ---
> 
> Rendered by github markdown renderer.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 68912: Added a log line to `MesosContainerizer::kill()`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68912/#review209187
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68912']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2413/mesos-review-68912

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2413/mesos-review-68912/logs/mesos-tests.log):

```
W1003 16:05:33.435480 12912 slave.cpp:3917] Ignoring shutdown framework 
d7d1a6b8-7f3b-439c-a27a-847a8acd066c- because it is terminating
I1003 16:05:33.436484 15652 master.cpp:1251] Agent 
d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 at slave(461)@192.10.1.5:54865 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1003 16:05:33.437479 15652 master.cpp:3267] Disconnecting agent 
d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 at slave(461)@192.10.1.5:54865 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1003 16:05:33.437479 15652 master.cpp:3286] Deactivating agent 
d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 at slave(461)@192.10.1.5:54865 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1003 16:05:33.437479  7924 hierarchical.cpp:359] Removed framework 
d7d1a6b8-7f3b-439c-a27a-847a8acd066c-
I1003 16:05:33.437479  7924 hierarchical.cpp:803] Agent 
d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 deactivated
I1003 16:05:33.439498  8116 containerizer.cpp:2455] Destroying container 
0da637c0-98a8-4ad4-ac65-6cf607cbba39 in RUNNING state
I1003 16:05:33.439498  8116 containerizer.cpp:3122] Transitioning the state of 
container 0da637c0-98a8-4ad4-ac65-6cf607cbba39 from RUNNING to DESTROYING
I1003 16:05:33.439498  8116 launcher.cpp:166] Asked to destroy containe[   
OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (584 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (603 ms total)

[--] Global test environment tear-down
d:\dcos\mesos\mesos\src\tests\environment.cpp(1126): error: Failed
Tests completed with child processes remaining:
-+- 1244 0024FFD8E6DC
 --- 15936 0024FFD8E6DC
[==] 1051 tests from 103 test cases ran. (489504 ms total)
[  PASSED  ] 1051 tests.
[  FAILED  ] 0 tests, listed below:

 0 FAILED TESTS

  YOU HAVE 232 DISABLED TESTS

r 0da637c0-98a8-4ad4-ac65-6cf607cbba39
I1003 16:05:33.471307  7924 containerizer.cpp:2961] Container 
0da637c0-98a8-4ad4-ac65-6cf607cbba39 has exited
I1003 16:05:33.500296 14928 master.cpp:1093] Master terminating
I1003 16:05:33.502277 15652 hierarchical.cpp:645] Removed agent 
d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0
I1003 16:05:33.824251 17340 process.cpp:926] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Oct. 3, 2018, 3:05 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68912/
> ---
> 
> (Updated Oct. 3, 2018, 3:05 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a log line to `MesosContainerizer::kill()`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 82d64e9928abd5e22493fa697d7b0910211533f3 
> 
> 
> Diff: https://reviews.apache.org/r/68912/diff/1/
> 
> 
> Testing
> ---
> 
> make -j3 check
> 
> Ran it through internal CI.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68866/#review209186
---


Ship it!




Ship It!

- Vinod Kone


On Sept. 27, 2018, 5:41 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68866/
> ---
> 
> (Updated Sept. 27, 2018, 5:41 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Nicholas Parker.
> 
> 
> Bugs: MESOS-9274
> https://issues.apache.org/jira/browse/MESOS-9274
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_v1_scheduler_V1Mesos.cpp 
> 2a5fbd79ac7bad933067cd96e38186849af8edc4 
> 
> 
> Diff: https://reviews.apache.org/r/68866/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`on various Linux distro
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

[Vinod Kone]

> On Sept. 27, 2018, 6:23 p.m., Vinod Kone wrote:
> > src/java/jni/org_apache_mesos_v1_scheduler_V1Mesos.cpp
> > Lines 294 (patched)
> > 
> >
> > Looks like you are doing `call` here instead of `send` so that you have 
> > a future to wait on? Skipping `send` which does validation and 
> > authentication seems wrong. Let's not do that.
> > 
> > I would recommend putting a sleep in the client code instead of here 
> > for now.
> 
> Alexander Rukletsov wrote:
> But `call` does 
> [validation](https://github.com/apache/mesos/blob/6e21e94ddca5b776d44636fe3eba8500bf88dc25/src/scheduler/scheduler.cpp#L269-L270)
>  and 
> [authentication](https://github.com/apache/mesos/blob/6e21e94ddca5b776d44636fe3eba8500bf88dc25/src/scheduler/scheduler.cpp#L301)
>  too. Not sure I follow, Vinod.
> 
> Greg Mann wrote:
> Yea I think we have the necessary validation/authentication in the 
> `call()` path as well. This solution is nice because it will wait for as 
> little time as possible, up to 5 seconds, rather than always waiting for 5 
> seconds.
> 
> In fact, since this code will return early if a response is actually 
> received, I would feel comfortable with a slightly longer await - maybe 10 or 
> 20 seconds?

I didn't realize `call` was a newish interface method added to the library. At 
a quick glance I thought it was the continuation of `send` and an internal 
method. My bad.

So I'm ok with doing a `call` here.

Suggestion: The comment above doesn't have enough context for a future to 
understand why the library could be destructured. I would recommend expanding 
the comment a bit more explaining. For example "The JVM could potentially call 
JNI `finalize` if the Java scheduler nullified its reference to `V1Mesos` 
library immediately after sending TEARDOWN." Also, maybe link to MESOS-9274 for 
posterity.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68866/#review209074
---


On Sept. 27, 2018, 5:41 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68866/
> ---
> 
> (Updated Sept. 27, 2018, 5:41 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Nicholas Parker.
> 
> 
> Bugs: MESOS-9274
> https://issues.apache.org/jira/browse/MESOS-9274
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_v1_scheduler_V1Mesos.cpp 
> 2a5fbd79ac7bad933067cd96e38186849af8edc4 
> 
> 
> Diff: https://reviews.apache.org/r/68866/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`on various Linux distro
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 68865: Put `TerminateEvent` at the end of the queue in the Mesos library.

[Greg Mann]

> On Sept. 27, 2018, 6:24 p.m., Vinod Kone wrote:
> > src/scheduler/scheduler.cpp
> > Line 1041 (original), 1041 (patched)
> > 
> >
> > Can you add a comment on why you are doing this for posterity?

+1

Could you also provide an explanation in the commit message?


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68865/#review209075
---


On Sept. 27, 2018, 5:41 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68865/
> ---
> 
> (Updated Sept. 27, 2018, 5:41 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Nicholas Parker.
> 
> 
> Bugs: MESOS-9274
> https://issues.apache.org/jira/browse/MESOS-9274
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/scheduler/scheduler.cpp 471152945d6af660c8983324b38702d872657f89 
> 
> 
> Diff: https://reviews.apache.org/r/68865/diff/1/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/68866/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 68912: Added a log line to `MesosContainerizer::kill()`.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68912/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Added a log line to `MesosContainerizer::kill()`.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
82d64e9928abd5e22493fa697d7b0910211533f3 


Diff: https://reviews.apache.org/r/68912/diff/1/


Testing
---

make -j3 check

Ran it through internal CI.


Thanks,

Vinod Kone