Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70492/#review214717
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70492']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3190/mesos-review-70492

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3190/mesos-review-70492/logs/mesos-tests.log):

```
I0417 04:56:14.028235 64360 master.cpp:] Disconnecting agent 
9da5b5de-272d-40f9-9b41-2f95ec052867-S0 at slave(501)@192.10.1.4:60109 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0417 04:56:14.029237 64360 master.cpp:3352] Deactivating agent 
9da5b5de-272d-40f9-9b41-2f95ec052867-S0 at slave(501)@192.10.1.4:60109 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0417 04:56:14.029237 59068 hierarchical.cpp:392] Removed framework 
9da5b5de-272d-40f9-9b41-2f95ec052867-
I0417 04:56:14.030264 59068 hierarchical.cpp:829] Agent 
9da5b5de-272d-40f9-9b41-2f95ec052867-S0 deactivated
I0417 04:56:14.030264 66484 containerizer.cpp:2576] Destroying container 
f8533bd4-0ecb-4157-9e50-f1f1f44f63e3 in RUNNING state
I0417 04:56:14.031244 66484 containerizer.cpp:3278] Transitioning the state of 
container f8533bd4-0ecb-4157-9e50-f1f1f44f63e3 from RUNNING to DESTROYING
I0417 04:56:14.031244 66484 launcher.cpp:161] Asked to destroy container 
f8533bd4-0ecb-4157-9e50-f1f1f44f63e3
W0417 04:56:14.032260 66344 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=5420 to peer '192.10.1.4:62508': IO failed with error 
code: The specified network name is no longer available.

W0417 04:56:14.033593 66344 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=5568 to peer '192.10.1.4:62509': IO failed with error 
code: The specified network name is no longer available.

I0417 04:56:14.080252 66308 containerizer.cpp:3117] [   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (865 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (883 ms total)

[--] Global test environment tear-down
[==] 1161 tests from 109 test cases ran. (587899 ms total)
[  PASSED  ] 1158 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 3 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

Container f8533bd4-0ecb-4157-9e50-f1f1f44f63e3 has exited
I0417 04:56:14.110242 66104 master.cpp:1135] Master terminating
I0417 04:56:14.112241 59068 hierarchical.cpp:680] Removed agent 
9da5b5de-272d-40f9-9b41-2f95ec052867-S0
I0417 04:56:14.947244 66344 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 17, 2019, 3:38 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70492/
> ---
> 
> (Updated April 17, 2019, 3:38 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 1.8.0 allocator performance improvements to the CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c4941b256aee146fb06e1ace2551547435b179dc 
> 
> 
> Diff: https://reviews.apache.org/r/70492/diff/2/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70492/#review214716
---



Patch looks great!

Reviews applied: [70492]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 17, 2019, 3:38 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70492/
> ---
> 
> (Updated April 17, 2019, 3:38 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 1.8.0 allocator performance improvements to the CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c4941b256aee146fb06e1ace2551547435b179dc 
> 
> 
> Diff: https://reviews.apache.org/r/70492/diff/2/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

[Meng Zhu]

> On April 16, 2019, 8:22 p.m., Benjamin Mahler wrote:
> > Do we have a range of percentages we see from benchmarks that we can make 
> > to give users a better sense of how much?

Added some numbers.


- Meng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70492/#review214713
---


On April 16, 2019, 8:38 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70492/
> ---
> 
> (Updated April 16, 2019, 8:38 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 1.8.0 allocator performance improvements to the CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c4941b256aee146fb06e1ace2551547435b179dc 
> 
> 
> Diff: https://reviews.apache.org/r/70492/diff/2/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70492/
---

(Updated April 16, 2019, 8:38 p.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Added 1.8.0 allocator performance improvements to the CHANGELOG.


Diffs (updated)
-

  CHANGELOG c4941b256aee146fb06e1ace2551547435b179dc 


Diff: https://reviews.apache.org/r/70492/diff/2/

Changes: https://reviews.apache.org/r/70492/diff/1-2/


Testing
---

N/A


Thanks,

Meng Zhu

Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70492/#review214713
---



Do we have a range of percentages we see from benchmarks that we can make to 
give users a better sense of how much?

- Benjamin Mahler


On April 17, 2019, 3:13 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70492/
> ---
> 
> (Updated April 17, 2019, 3:13 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 1.8.0 allocator performance improvements to the CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c4941b256aee146fb06e1ace2551547435b179dc 
> 
> 
> Diff: https://reviews.apache.org/r/70492/diff/1/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70492/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Added 1.8.0 allocator performance improvements to the CHANGELOG.


Diffs
-

  CHANGELOG c4941b256aee146fb06e1ace2551547435b179dc 


Diff: https://reviews.apache.org/r/70492/diff/1/


Testing
---

N/A


Thanks,

Meng Zhu

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/#review214711
---



Patch looks great!

Reviews applied: [70489]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 17, 2019, 12:11 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70489/
> ---
> 
> (Updated April 17, 2019, 12:11 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented docker manifest v2 schema2 support.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 
> 
> 
> Diff: https://reviews.apache.org/r/70489/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/#review214709
---


Ship it!




Ship It!

- Joseph Wu


On April 16, 2019, 5:11 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70489/
> ---
> 
> (Updated April 16, 2019, 5:11 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented docker manifest v2 schema2 support.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 
> 
> 
> Diff: https://reviews.apache.org/r/70489/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

[Gilbert Song]

> On April 16, 2019, 4:56 p.m., Joseph Wu wrote:
> > docs/container-image.md
> > Line 184 (original), 184 (patched)
> > 
> >
> > Should the link text be `v2 schema1` (not `v1`)?

ah, typo!


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/#review214706
---


On April 16, 2019, 5:11 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70489/
> ---
> 
> (Updated April 16, 2019, 5:11 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented docker manifest v2 schema2 support.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 
> 
> 
> Diff: https://reviews.apache.org/r/70489/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/
---

(Updated April 16, 2019, 5:11 p.m.)


Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang.


Repository: mesos


Description
---

Documented docker manifest v2 schema2 support.


Diffs (updated)
-

  docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 


Diff: https://reviews.apache.org/r/70489/diff/2/

Changes: https://reviews.apache.org/r/70489/diff/1-2/


Testing
---


Thanks,

Gilbert Song

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/#review214707
---




docs/container-image.md
Lines 188-190 (patched)


maybe a bit more like this?

```
For privacte registries, the operator needs to configure `curl` with the 
location of required CA certificates.
```


- Till Toenshoff


On April 16, 2019, 11:39 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70489/
> ---
> 
> (Updated April 16, 2019, 11:39 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented docker manifest v2 schema2 support.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 
> 
> 
> Diff: https://reviews.apache.org/r/70489/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/#review214706
---




docs/container-image.md
Line 184 (original), 184 (patched)


Should the link text be `v2 schema1` (not `v1`)?


- Joseph Wu


On April 16, 2019, 4:39 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70489/
> ---
> 
> (Updated April 16, 2019, 4:39 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented docker manifest v2 schema2 support.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 
> 
> 
> Diff: https://reviews.apache.org/r/70489/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 70489: Documented docker manifest v2 schema2 support.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/
---

Review request for mesos, Jie Yu and Qian Zhang.


Repository: mesos


Description
---

Documented docker manifest v2 schema2 support.


Diffs
-

  docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 


Diff: https://reviews.apache.org/r/70489/diff/1/


Testing
---


Thanks,

Gilbert Song

Re: Review Request 65085: WIP: Added a unit test for fd leakage with blocking HTTP calls.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65085/
---

(Updated April 16, 2019, 10 p.m.)


Review request for Benjamin Bannier.


Bugs: MESOS-8428
https://issues.apache.org/jira/browse/MESOS-8428


Repository: mesos


Description
---

When running `ContainerDaemonTest.FileDescriptorLeakage` in repetition,
the test will use up all fds.


Diffs (updated)
-

  src/tests/container_daemon_tests.cpp 1396f25bf7aa9fbc62af9111ad412238faff432e 


Diff: https://reviews.apache.org/r/65085/diff/2/

Changes: https://reviews.apache.org/r/65085/diff/1-2/


Testing
---


Thanks,

Chun-Hung Hsiao

Re: Review Request 70483: Added docker manifest v2s2 config to 'ImageInfo'.

[Gilbert Song]

> On April 16, 2019, 7:23 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/provisioner/store.hpp
> > Line 49 (original), 49 (patched)
> > 
> >
> > This comment seems not accurate, this field should be either Docker v1 
> > image manifest or Docker v2 s2 image configuration.

I think both v2s2 and v2s1 is compatible with the old docker v1 spec 
https://github.com/docker/docker/blob/master/image/spec/v1.md

the protobuf naming `v1::ImageManifest` was confusing though.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70483/#review214683
---


On April 15, 2019, 11:07 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70483/
> ---
> 
> (Updated April 15, 2019, 11:07 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li.
> 
> 
> Bugs: MESOS-9704
> https://issues.apache.org/jira/browse/MESOS-9704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docker manifest v2s2 config to 'ImageInfo'.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> a4ae00e1d95f738f1489afbb0fbde9e1d9dafff6 
> 
> 
> Diff: https://reviews.apache.org/r/70483/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation.

[Chun-Hung Hsiao]

> On April 16, 2019, 1:06 p.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 3128 (patched)
> > 
> >
> > Are we checking that the resources get returned to the offer pool? In 
> > that case let's confirm that `offers` looks like what we would expect.
> > 
> > Alternatively we might not want to test this here and could just remove 
> > this and add a matching ignore when setting up the mock expectation above. 
> > That seems to make more sense to me.

It's more about making it deterministic, and also as part of the end-to-end 
scenario. The contents of the offer has already been checked by the matcher.

I could instead ignore the offer by doing a `Times(AtMost(1))`. Do you think 
this would make the test simpler?


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69954/#review214689
---


On April 12, 2019, 3:15 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69954/
> ---
> 
> (Updated April 12, 2019, 3:15 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9565
> https://issues.apache.org/jira/browse/MESOS-9565
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Test `CreateDestroyPersistentBlockVolume` verifies that SLRP would fail
> a `CREATE` operation on a BLOCK disk resource, and a followup `DESTROY`
> will be dropped (instead of failing the SLRP).
> 
> 
> Diffs
> -
> 
>   src/tests/mock_csi_plugin.cpp cbcb59f720642c2801f5b86c438793e24437b414 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 8bf4d2331b59770a7b7f3768499047bec2d67677 
> 
> 
> Diff: https://reviews.apache.org/r/69954/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

[Chun-Hung Hsiao]

> On April 16, 2019, 1:18 p.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 3328 (patched)
> > 
> >
> > If we need to await offers, lets also check their contents. It seems 
> > checking the operation status would already be enough.

This would eliminate the nondeterminism of the times of `resourceOffers` being 
called.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69955/#review214690
---


On April 12, 2019, 10:02 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69955/
> ---
> 
> (Updated April 12, 2019, 10:02 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9565
> https://issues.apache.org/jira/browse/MESOS-9565
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds 3 unit tests: `DestroyUnpublishedPersistentVolume`,
> `DestroyUnpublishedPersistentVolumeWithRecovery`, and
> `DestroyUnpublishedPersistentVolumeWithReboot` to test that the SLRP is
> resilient to misbehaved CSI plugins that fail to publish volumes.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 8bf4d2331b59770a7b7f3768499047bec2d67677 
> 
> 
> Diff: https://reviews.apache.org/r/69955/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> All tests passed 400 iterations (200 per parameter value) under stress.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70469: Optimized weighted shuffling in the random sorter.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70469/
---

(Updated April 16, 2019, 9:39 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Updated benchmark result.


Bugs: MESOS-9723
https://issues.apache.org/jira/browse/MESOS-9723


Repository: mesos


Description
---

This patch optimizes the permutation step of the weighted
shuffling function used by the random sorter.
The permutation step now has constant memory cost and
O(n) time complexity.

This is based on the algorithm described in:
https://s.apache.org/o7K0

Also added a unit test.


Diffs
-

  src/master/allocator/sorter/random/utils.hpp 
1329359040082ed128d8dbc45381aa3e529224e4 
  src/tests/sorter_tests.cpp 9d52a80eafb6f955386a6575875daacf5d4b4e9e 


Diff: https://reviews.apache.org/r/70469/diff/1/


Testing (updated)
---

make check

Ran a modified sorter benchmark:

Before: 10 runs of sort of 2000 clients took 9.113634ms
After: 10 runs of sort of 2000 clients took 8.802126ms

It appears to have minimal performance improvement.


Thanks,

Meng Zhu

Re: Review Request 70484: Supported docker manifest v2s2 config with image GC.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70484/#review214694
---


Ship it!




Ship It!

- Qian Zhang


On April 16, 2019, 2:08 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70484/
> ---
> 
> (Updated April 16, 2019, 2:08 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li.
> 
> 
> Bugs: MESOS-9704
> https://issues.apache.org/jira/browse/MESOS-9704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After the docker manifest v2 schema2 support, the manifest config
> is saved as a layer in image store. However, the config file
> cannot survive if the image GC is triggered.
> 
> This patch supports checkpointing the config path in provisioner,
> so that the provisioner has the information of configs so that
> they will not be deleted during GC.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> 53de6253257b37173ccc8b7f90f8aa422ed0430a 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 36b2c7de87bcdfd3e2af6477499572b235ea1933 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> ac402fbead81e4b356cb35cea08a00049002e870 
> 
> 
> Diff: https://reviews.apache.org/r/70484/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70483: Added docker manifest v2s2 config to 'ImageInfo'.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70483/#review214683
---


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/store.hpp
Line 49 (original), 49 (patched)


This comment seems not accurate, this field should be either Docker v1 
image manifest or Docker v2 s2 image configuration.


- Qian Zhang


On April 16, 2019, 2:07 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70483/
> ---
> 
> (Updated April 16, 2019, 2:07 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li.
> 
> 
> Bugs: MESOS-9704
> https://issues.apache.org/jira/browse/MESOS-9704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docker manifest v2s2 config to 'ImageInfo'.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> a4ae00e1d95f738f1489afbb0fbde9e1d9dafff6 
> 
> 
> Diff: https://reviews.apache.org/r/70483/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70484: Supported docker manifest v2s2 config with image GC.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70484/#review214692
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70482', '70483', '70484']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3186/mesos-review-70484

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3186/mesos-review-70484/logs/mesos-tests.log):

```
I0416 13:50:46.111204 62932 master.cpp:11729] Removing task 
6ac7caed-a1f4-4ed0-8788-76a907421165 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 07d15959-f0cd-409c-89ac-be8254e97e06- on 
agent 07d15959-f0cd-409c-89ac-be8254e97e06-S0 at slave(501)@192.10.1.4:62945 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0416 13:50:46.115206 62932 master.cpp:1295] Agent 
07d15959-f0cd-409c-89ac-be8254e97e06-S0 at slave(501)@192.10.1.4:62945 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0416 13:50:46.115206 62932 master.cpp:] Disconnecting agent 
07d15959-f0cd-409c-89ac-be8254e97e06-S0 at slave(501)@192.10.1.4:62945 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0416 13:50:46.116211 62932 master.cpp:3352] Deactivating agent 
07d15959-f0cd-409c-89ac-be8254e97e06-S0 at slave(501)@192.10.1.4:62945 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0416 13:50:46.116211 64356 hierarchical.cpp:392] Removed framework 
07d15959-f0cd-409c-89ac-be8254e97e06-
I0416 13:50:46.117193 64356 hierarchical.cpp:829] Agent 
07d15959-f0cd-409c-89ac-be8254e97e06-S0 deactivated
I0416 13:50:46.118198 63680 containerizer.cpp:2576] Destroying container 
922cf2e2-99a8-44c5-b17d-2c9412a25434 in RUNNING state
I0416 13:50:46.118198 63680 containerizer.cpp:3278] Transitioning the state of 
container 922cf2e2-99a8-44c5-b17d-2c9412a25434 from RUNNING to DESTROYING
I0416 13:50:46.119233 63680 launcher.cpp:161] Asked to destroy container 
922cf2e2-99a8-44c5-b17d-2c9412a25434
W0416 13:50:46.120198 62724 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=3312 to peer '192.10.1.4:65401': IO failed with error 
code: The specified network name is no longer available.

W0416 13:50:46.120198 62724 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=4384 to peer '192.10.1.4:65402': IO failed with error 
code: The specified network name is no long[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (770 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (798 ms total)

[--] Global test environment tear-down
[==] 1160 tests from 108 test cases ran. (655626 ms total)
[  PASSED  ] 1159 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 233 DISABLED TESTS

er available.

I0416 13:50:46.128202 50556 containerizer.cpp:3117] Container 
922cf2e2-99a8-44c5-b17d-2c9412a25434 has exited
I0416 13:50:46.158262 58052 master.cpp:1135] Master terminating
I0416 13:50:46.160190 64356 hierarchical.cpp:680] Removed agent 
07d15959-f0cd-409c-89ac-be8254e97e06-S0
I0416 13:50:47.010226 62724 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 16, 2019, 6:08 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70484/
> ---
> 
> (Updated April 16, 2019, 6:08 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li.
> 
> 
> Bugs: MESOS-9704
> https://issues.apache.org/jira/browse/MESOS-9704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After the docker manifest v2 schema2 support, the manifest config
> is saved as a layer in image store. However, the config file
> cannot survive if the image GC is triggered.
> 
> This patch supports checkpointing the config path in provisioner,
> so that the provisioner has the information of configs so that
> they will not be deleted during GC.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> 53de6253257b37173ccc8b7f90f8aa422ed0430a 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 36b2c7de87bcdfd3e2af6477499572b235ea1933 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> ac402fbead81e4b356cb35cea08a00049002e870 
> 
> 
> Diff: https://reviews.apache.org/r/70484/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70482: Added docker manifest v2s2 config to protobuf 'ContainerLayers'.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70482/#review214691
---


Ship it!




Ship It!

- Qian Zhang


On April 16, 2019, 2:07 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70482/
> ---
> 
> (Updated April 16, 2019, 2:07 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li.
> 
> 
> Bugs: MESOS-9704
> https://issues.apache.org/jira/browse/MESOS-9704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docker manifest v2s2 config to protobuf 'ContainerLayers'.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 8de897ed70e59a4d3244e61c4fb97aecc5ba77b9 
> 
> 
> Diff: https://reviews.apache.org/r/70482/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69955/#review214690
---


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Lines 454 (patched)


Let's add a log message here.



src/tests/storage_local_resource_provider_tests.cpp
Lines 3328 (patched)


If we need to await offers, lets also check their contents. It seems 
checking the operation status would already be enough.



src/tests/storage_local_resource_provider_tests.cpp
Lines 3542 (patched)


Ditto.



src/tests/storage_local_resource_provider_tests.cpp
Lines 3792 (patched)


Ditto.


- Benjamin Bannier


On April 13, 2019, 12:02 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69955/
> ---
> 
> (Updated April 13, 2019, 12:02 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9565
> https://issues.apache.org/jira/browse/MESOS-9565
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds 3 unit tests: `DestroyUnpublishedPersistentVolume`,
> `DestroyUnpublishedPersistentVolumeWithRecovery`, and
> `DestroyUnpublishedPersistentVolumeWithReboot` to test that the SLRP is
> resilient to misbehaved CSI plugins that fail to publish volumes.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 8bf4d2331b59770a7b7f3768499047bec2d67677 
> 
> 
> Diff: https://reviews.apache.org/r/69955/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> All tests passed 400 iterations (200 per parameter value) under stress.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69954/#review214689
---


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Lines 3128 (patched)


Are we checking that the resources get returned to the offer pool? In that 
case let's confirm that `offers` looks like what we would expect.

Alternatively we might not want to test this here and could just remove 
this and add a matching ignore when setting up the mock expectation above. That 
seems to make more sense to me.


- Benjamin Bannier


On April 12, 2019, 5:15 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69954/
> ---
> 
> (Updated April 12, 2019, 5:15 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9565
> https://issues.apache.org/jira/browse/MESOS-9565
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Test `CreateDestroyPersistentBlockVolume` verifies that SLRP would fail
> a `CREATE` operation on a BLOCK disk resource, and a followup `DESTROY`
> will be dropped (instead of failing the SLRP).
> 
> 
> Diffs
> -
> 
>   src/tests/mock_csi_plugin.cpp cbcb59f720642c2801f5b86c438793e24437b414 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 8bf4d2331b59770a7b7f3768499047bec2d67677 
> 
> 
> Diff: https://reviews.apache.org/r/69954/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70431: Made the `RetryRpcWithExponentialBackoff` SLRP test work with CSI v1.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70431/#review214688
---


Fix it, then Ship it!





src/examples/test_csi_plugin.cpp
Lines 1855-1857 (patched)


Let's add documenting the expected method names here.



src/tests/storage_local_resource_provider_tests.cpp
Lines 374 (patched)


Let's add some log output here, e.g.,
```
FAIL() << "Unsupported CSI API version " << GetParam();
```



src/tests/storage_local_resource_provider_tests.cpp
Lines 414 (patched)


Ditto.


- Benjamin Bannier


On April 9, 2019, 8:09 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70431/
> ---
> 
> (Updated April 9, 2019, 8:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9627
> https://issues.apache.org/jira/browse/MESOS-9627
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the unit test to test against CSI v1 through the
> following changes:
> 
>   * The forwarding mode of the test CSI plugin now respects the
> `--api_version` option. When specified, only requests of the proper
> CSI version will be forwarded.
> 
>   * The expectations of `CreateVolume` and `DeleteVolume` calls in the
> unit tests are parameterized against the CSI version string.
> 
>   * The mock CSI plugin now provides a default implementation for the
> `GetCapacity` call so the unit test can be simplified.
> 
> 
> Diffs
> -
> 
>   src/examples/test_csi_plugin.cpp 4321f8f16cb12018f008002cdc5c9002a055e2b7 
>   src/tests/mock_csi_plugin.cpp 10245705ab39872da0fef1afd02213e2c7f345cb 
>   src/tests/storage_local_resource_provider_tests.cpp 
> da8db41b867d04b4236ad3515811fc00318c619c 
> 
> 
> Diff: https://reviews.apache.org/r/70431/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70379/#review214686
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70408', '70377', '70379']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3183/mesos-review-70379

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3183/mesos-review-70379/logs/mesos-tests.log):

```
I0416 08:47:55.246440 61944 master.cpp:1295] Agent 
4cbe623d-f6dc-4ad2-b5c8-bf225b82dccc-S0 at slave(502)@192.10.1.4:57419 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0416 08:47:55.246440 61944 master.cpp:3312] Disconnecting agent 
4cbe623d-f6dc-4ad2-b5c8-bf225b82dccc-S0 at slave(502)@192.10.1.4:57419 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0416 08:47:55.246440 61944 master.cpp:3331] Deactivating agent 
4cbe623d-f6dc-4ad2-b5c8-bf225b82dccc-S0 at slave(502)@192.10.1.4:57419 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0416 08:47:55.247483 62808 hierarchical.cpp:392] Removed framework 
4cbe623d-f6dc-4ad2-b5c8-bf225b82dccc-
I0416 08:47:55.247483 62808 hierarchical.cpp:829] Agent 
4cbe623d-f6dc-4ad2-b5c8-bf225b82dccc-S0 deactivated
I0416 08:47:55.248437 61944 containerizer.cpp:2576] Destroying container 
f3074bf2-f283-4456-8856-06304272ee1d in RUNNING state
I0416 08:47:55.248437 61944 containerizer.cpp:3278] Transitioning the state of 
container f3074bf2-f283-4456-8856-06304272ee1d from RUNNING to DESTROYING
I0416 08:47:55.249483 61944 launcher.cpp:161] Asked to destroy container 
f3074bf2-f283-4456-8856-06304272ee1d
W0416 08:47:55.250437 56356 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=2[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (791 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (807 ms total)

[--] Global test environment tear-down
[==] 1162 tests from 108 test cases ran. (637981 ms total)
[  PASSED  ] 1160 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 2 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

600 to peer '192.10.1.4:59859': IO failed with error code: The specified 
network name is no longer available.

W0416 08:47:55.250437 56356 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=3796 to peer '192.10.1.4:59860': IO failed with error 
code: The specified network name is no longer available.

I0416 08:47:55.347033 55440 containerizer.cpp:3117] Container 
f3074bf2-f283-4456-8856-06304272ee1d has exited
I0416 08:47:55.376034 63180 master.cpp:1135] Master terminating
I0416 08:47:55.377029 58804 hierarchical.cpp:680] Removed agent 
4cbe623d-f6dc-4ad2-b5c8-bf225b82dccc-S0
I0416 08:47:56.164043 56356 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 15, 2019, 12:20 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70379/
> ---
> 
> (Updated April 15, 2019, 12:20 p.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Bugs: MESOS-2842
> https://issues.apache.org/jira/browse/MESOS-2842
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added validation that the principal stays the same on resubscription.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084 
> 
> 
> Diff: https://reviews.apache.org/r/70379/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> Now the two failing tests from https://reviews.apache.org/r/70377/ pass.
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Review Request 70484: Supported docker manifest v2s2 config with image GC.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70484/
---

Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li.


Bugs: MESOS-9704
https://issues.apache.org/jira/browse/MESOS-9704


Repository: mesos


Description
---

After the docker manifest v2 schema2 support, the manifest config
is saved as a layer in image store. However, the config file
cannot survive if the image GC is triggered.

This patch supports checkpointing the config path in provisioner,
so that the provisioner has the information of configs so that
they will not be deleted during GC.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
53de6253257b37173ccc8b7f90f8aa422ed0430a 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
36b2c7de87bcdfd3e2af6477499572b235ea1933 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
ac402fbead81e4b356cb35cea08a00049002e870 


Diff: https://reviews.apache.org/r/70484/diff/1/


Testing
---


Thanks,

Gilbert Song

Review Request 70482: Added docker manifest v2s2 config to protobuf 'ContainerLayers'.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70482/
---

Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li.


Bugs: MESOS-9704
https://issues.apache.org/jira/browse/MESOS-9704


Repository: mesos


Description
---

Added docker manifest v2s2 config to protobuf 'ContainerLayers'.


Diffs
-

  include/mesos/slave/containerizer.proto 
8de897ed70e59a4d3244e61c4fb97aecc5ba77b9 


Diff: https://reviews.apache.org/r/70482/diff/1/


Testing
---


Thanks,

Gilbert Song

Review Request 70483: Added docker manifest v2s2 config to 'ImageInfo'.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70483/
---

Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li.


Bugs: MESOS-9704
https://issues.apache.org/jira/browse/MESOS-9704


Repository: mesos


Description
---

Added docker manifest v2s2 config to 'ImageInfo'.


Diffs
-

  src/slave/containerizer/mesos/provisioner/store.hpp 
a4ae00e1d95f738f1489afbb0fbde9e1d9dafff6 


Diff: https://reviews.apache.org/r/70483/diff/1/


Testing
---


Thanks,

Gilbert Song