Re: Review Request 70991: Added ability to pass custom SSL context to `Socket::connect()`.

[Till Toenshoff via Review Board]

> On July 4, 2019, 11:53 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/src/openssl.cpp
> > Line 806 (original), 807 (patched)
> > 
> >
> > s/libprocess/legacy/

Actually, please make sure you dont end up with 
```
// i.e. the lagacy 'legacy' scheme
```
:D


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70991/#review216396
---


On July 4, 2019, 7 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70991/
> ---
> 
> (Updated July 4, 2019, 7 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9878
> https://issues.apache.org/jira/browse/MESOS-9878
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Users of libprocess can now pass a custom SSL context when
> connecting a generic socket via the `Socket::connect()`
> function.
> 
> Additionally the API of `Socket::connect()` was also reworked
> according to the following boundary conditions requested by
> libprocess maintainers:
> 
>  * When libprocess is compiled without SSL support, neither the
>declaration of the TLS configuration object nor the `connnect()`
>overload that accepts the TLS configuration should be available.
>  * Passing just the servername is not an acceptable short-hand for
>using the default TLS configuration together with that servername.
>  * When the incorrect overload is selected (i.e. passing TLS config
>to a poll socket or omitting TLS configuration for a TLS socket),
>the program should abort.
> 
> This following changes are introduced according to the requirements
> above:
> 
>  * A new class `openssl::TLSClientConfig` is introduced when libprocess
>is compiled with ssl support.
>  * A new overload
>`Socket::connect(const Address&, const TLSClientConfig&)` is
>introduced when libprocess is compiled with ssl support.
>  * All call sites are adjusted to check the socket kind before calling
>`connect()`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> 1ddcc2d5a30f7bf3914138e497a9b228b515cd29 
>   3rdparty/libprocess/include/process/socket.hpp 
> 4f0f6e9aa6e95e826e3de96e518a7200ad7a8f83 
>   3rdparty/libprocess/include/process/ssl/tls_config.hpp PRE-CREATION 
>   3rdparty/libprocess/src/http.cpp 3e73ee936f5c6329f41704a179f3d88ab65dfb6d 
>   3rdparty/libprocess/src/openssl.hpp 
> 17bec246e516261f8d772f1647c17f092fae82d1 
>   3rdparty/libprocess/src/openssl.cpp 
> 19d25a89f7dda1f6c66dd1ffc5051e35457d26b0 
>   3rdparty/libprocess/src/poll_socket.hpp 
> 15b7902ba2b10fad63e2ba7b8d5081d4b9e2d1c7 
>   3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.hpp 
> 6ef5a86566af3439cfe0b06ab3576076623f7be0 
>   3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp 
> 7e2229a9ed815727500bd457356e5531607fa6cf 
>   3rdparty/libprocess/src/posix/poll_socket.cpp 
> 74acb6942682a9d9626df81b303eba0a1c24ecf7 
>   3rdparty/libprocess/src/process.cpp 
> 799666f03d6a78708aa9336c2dd04bc9b5023aa0 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 4d372943a2d417d24d06444ec2e72909fb348017 
>   3rdparty/libprocess/src/tests/socket_tests.cpp 
> b09ae23a551c6587656b2d5f6f58c5267e8e0088 
>   3rdparty/libprocess/src/tests/ssl_client.cpp 
> de87b3b89c84d17f2ebba1f09e9ec682f139aace 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 5d360221937e68da185754f0633fa41a217c7107 
> 
> 
> Diff: https://reviews.apache.org/r/70991/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70991: Added ability to pass custom SSL context to `Socket::connect()`.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70991/#review216396
---


Fix it, then Ship it!




Awesome work Benno - thanks!

Can't wait to see these great additions landing.


3rdparty/libprocess/include/process/ssl/tls_config.hpp
Lines 59 (patched)


```
 (See also the comments on the typedefs above.)
```

Looking at the callback type comments is somewhat implicit, i feel - we can 
do without that part.



3rdparty/libprocess/include/process/ssl/tls_config.hpp
Lines 65-69 (patched)


I would suggest to split this up into smaller digestable sentences - native 
speaker please?!

Otherwise maybe like this?

```
// Returns `TLSClientConfig` object configured with provided `servername` as
// well as the global libprocess SSL context. The callbacks for `verify` and
// `configure_socket` get setup following the SSL behaviour configured via
// the `LIBPROCESS_SSL_*` environment variables.

```



3rdparty/libprocess/include/process/ssl/tls_config.hpp
Lines 80 (patched)


s/libprocess/legacy/



3rdparty/libprocess/src/openssl.cpp
Line 806 (original), 807 (patched)


s/libprocess/legacy/


- Till Toenshoff


On July 4, 2019, 7 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70991/
> ---
> 
> (Updated July 4, 2019, 7 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9878
> https://issues.apache.org/jira/browse/MESOS-9878
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Users of libprocess can now pass a custom SSL context when
> connecting a generic socket via the `Socket::connect()`
> function.
> 
> Additionally the API of `Socket::connect()` was also reworked
> according to the following boundary conditions requested by
> libprocess maintainers:
> 
>  * When libprocess is compiled without SSL support, neither the
>declaration of the TLS configuration object nor the `connnect()`
>overload that accepts the TLS configuration should be available.
>  * Passing just the servername is not an acceptable short-hand for
>using the default TLS configuration together with that servername.
>  * When the incorrect overload is selected (i.e. passing TLS config
>to a poll socket or omitting TLS configuration for a TLS socket),
>the program should abort.
> 
> This following changes are introduced according to the requirements
> above:
> 
>  * A new class `openssl::TLSClientConfig` is introduced when libprocess
>is compiled with ssl support.
>  * A new overload
>`Socket::connect(const Address&, const TLSClientConfig&)` is
>introduced when libprocess is compiled with ssl support.
>  * All call sites are adjusted to check the socket kind before calling
>`connect()`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> 1ddcc2d5a30f7bf3914138e497a9b228b515cd29 
>   3rdparty/libprocess/include/process/socket.hpp 
> 4f0f6e9aa6e95e826e3de96e518a7200ad7a8f83 
>   3rdparty/libprocess/include/process/ssl/tls_config.hpp PRE-CREATION 
>   3rdparty/libprocess/src/http.cpp 3e73ee936f5c6329f41704a179f3d88ab65dfb6d 
>   3rdparty/libprocess/src/openssl.hpp 
> 17bec246e516261f8d772f1647c17f092fae82d1 
>   3rdparty/libprocess/src/openssl.cpp 
> 19d25a89f7dda1f6c66dd1ffc5051e35457d26b0 
>   3rdparty/libprocess/src/poll_socket.hpp 
> 15b7902ba2b10fad63e2ba7b8d5081d4b9e2d1c7 
>   3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.hpp 
> 6ef5a86566af3439cfe0b06ab3576076623f7be0 
>   3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp 
> 7e2229a9ed815727500bd457356e5531607fa6cf 
>   3rdparty/libprocess/src/posix/poll_socket.cpp 
> 74acb6942682a9d9626df81b303eba0a1c24ecf7 
>   3rdparty/libprocess/src/process.cpp 
> 799666f03d6a78708aa9336c2dd04bc9b5023aa0 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 4d372943a2d417d24d06444ec2e72909fb348017 
>   3rdparty/libprocess/src/tests/socket_tests.cpp 
> b09ae23a551c6587656b2d5f6f58c5267e8e0088 
>   3rdparty/libprocess/src/tests/ssl_client.cpp 
> de87b3b89c84d17f2ebba1f09e9ec682f139aace 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 5d360221937e68da185754f0633fa41a217c7107 
> 
> 
> Diff: https://reviews.apache.org/r/70991/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70947: Added `reviveOffers(roles)` to V0 Java bindings.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70947/#review216391
---


Ship it!





src/java/src/org/apache/mesos/SchedulerDriver.java
Lines 272-275 (patched)


Some extra spaces here?


- Benjamin Mahler


On July 4, 2019, 3:23 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70947/
> ---
> 
> (Updated July 4, 2019, 3:23 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `reviveOffers(roles)` to V0 Java bindings.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> f81a69a7f13f976a09f11409a0ea3f40fccea1b8 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
> 772a7383328519e63f0bf31908cb4c2129a77315 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> 155e4ac7b0e507c549a2d2de07ab95e215bf39e0 
> 
> 
> Diff: https://reviews.apache.org/r/70947/diff/4/
> 
> 
> Testing
> ---
> 
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" 
> --gtest_break_on_failure --gtest_repeat=10` with a patch from 
> https://reviews.apache.org/r/70946/
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java bindings.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/#review216392
---


Ship it!




Ship It!

- Benjamin Mahler


On July 4, 2019, 3:19 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70985/
> ---
> 
> (Updated July 4, 2019, 3:19 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `suppressOffers(roles)` to V0 Java bindings.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> f81a69a7f13f976a09f11409a0ea3f40fccea1b8 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
> 772a7383328519e63f0bf31908cb4c2129a77315 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> 155e4ac7b0e507c549a2d2de07ab95e215bf39e0 
> 
> 
> Diff: https://reviews.apache.org/r/70985/diff/3/
> 
> 
> Testing
> ---
> 
> Called this method from a modified example framework (WIP).
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 70886: Override source address for executors.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70886/#review216390
---



Bad review!

Reviews applied: [70886, 70993, 70933, 70797, 70992, 70991, 70921, 70795, 
70749, 70883, 70884, 70810, 70748]

Error:
2019-07-04 20:33:43 URL:https://reviews.apache.org/r/70992/diff/raw/ [812/812] 
-> "70992.patch" [1]
error: patch failed: CHANGELOG:27
error: CHANGELOG: patch does not apply

- Mesos Reviewbot


On June 19, 2019, 2:48 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70886/
> ---
> 
> (Updated June 19, 2019, 2:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jan-Philip Gehrcke, Joseph Wu, and 
> Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignore an executor's reported IP address and enforce the hostname
> "localhost" instead.
> 
> This is intended to enable TLS connections to executors running
> in bridge-mode or virtual-mode docker containers, which can not
> present a valid certificate containing their source IP which is
> dynamically generated and not known until the executor connects.
> 
> NOTE: This change is for illustration purposes only, and is not
> intended to be upstreamed.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
> 
> 
> Diff: https://reviews.apache.org/r/70886/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java bindings.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/#review216389
---



Patch looks great!

Reviews applied: [70894, 70897, 70895, 70982, 70941, 70942, 70947, 70985]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On July 4, 2019, 3:19 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70985/
> ---
> 
> (Updated July 4, 2019, 3:19 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `suppressOffers(roles)` to V0 Java bindings.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> f81a69a7f13f976a09f11409a0ea3f40fccea1b8 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
> 772a7383328519e63f0bf31908cb4c2129a77315 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> 155e4ac7b0e507c549a2d2de07ab95e215bf39e0 
> 
> 
> Diff: https://reviews.apache.org/r/70985/diff/3/
> 
> 
> Testing
> ---
> 
> Called this method from a modified example framework (WIP).
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 70797: Added unit tests for hostname validation.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70797/
---

(Updated July 4, 2019, 7 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Joseph Wu, and 
Till Toenshoff.


Changes
---

Renamed `libprocess` -> `legacy`.


Repository: mesos


Description (updated)
---

While going through the existing tests to look for candidates
that would benefit from being tested for both hostname validation
schemes, I noticed a number of existing tests where test setup
did not quite match the comment or test name. I fixed these up
in the same review.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
6cdd7815f4389cd398defe56260a73eb710a4d8f 
  3rdparty/libprocess/src/tests/ssl_client.cpp 
de87b3b89c84d17f2ebba1f09e9ec682f139aace 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
5d360221937e68da185754f0633fa41a217c7107 


Diff: https://reviews.apache.org/r/70797/diff/6/

Changes: https://reviews.apache.org/r/70797/diff/5-6/


Testing
---


Thanks,

Benno Evers

Re: Review Request 70991: Added ability to pass custom SSL context to `Socket::connect()`.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70991/
---

(Updated July 4, 2019, 7 p.m.)


Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.


Changes
---

Addressed review comments.


Summary (updated)
-

Added ability to pass custom SSL context to `Socket::connect()`.


Bugs: MESOS-9878
https://issues.apache.org/jira/browse/MESOS-9878


Repository: mesos


Description (updated)
---

Users of libprocess can now pass a custom SSL context when
connecting a generic socket via the `Socket::connect()`
function.

Additionally the API of `Socket::connect()` was also reworked
according to the following boundary conditions requested by
libprocess maintainers:

 * When libprocess is compiled without SSL support, neither the
   declaration of the TLS configuration object nor the `connnect()`
   overload that accepts the TLS configuration should be available.
 * Passing just the servername is not an acceptable short-hand for
   using the default TLS configuration together with that servername.
 * When the incorrect overload is selected (i.e. passing TLS config
   to a poll socket or omitting TLS configuration for a TLS socket),
   the program should abort.

This following changes are introduced according to the requirements
above:

 * A new class `openssl::TLSClientConfig` is introduced when libprocess
   is compiled with ssl support.
 * A new overload
   `Socket::connect(const Address&, const TLSClientConfig&)` is
   introduced when libprocess is compiled with ssl support.
 * All call sites are adjusted to check the socket kind before calling
   `connect()`.


Diffs (updated)
-

  3rdparty/libprocess/include/Makefile.am 
1ddcc2d5a30f7bf3914138e497a9b228b515cd29 
  3rdparty/libprocess/include/process/socket.hpp 
4f0f6e9aa6e95e826e3de96e518a7200ad7a8f83 
  3rdparty/libprocess/include/process/ssl/tls_config.hpp PRE-CREATION 
  3rdparty/libprocess/src/http.cpp 3e73ee936f5c6329f41704a179f3d88ab65dfb6d 
  3rdparty/libprocess/src/openssl.hpp 17bec246e516261f8d772f1647c17f092fae82d1 
  3rdparty/libprocess/src/openssl.cpp 19d25a89f7dda1f6c66dd1ffc5051e35457d26b0 
  3rdparty/libprocess/src/poll_socket.hpp 
15b7902ba2b10fad63e2ba7b8d5081d4b9e2d1c7 
  3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.hpp 
6ef5a86566af3439cfe0b06ab3576076623f7be0 
  3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp 
7e2229a9ed815727500bd457356e5531607fa6cf 
  3rdparty/libprocess/src/posix/poll_socket.cpp 
74acb6942682a9d9626df81b303eba0a1c24ecf7 
  3rdparty/libprocess/src/process.cpp 799666f03d6a78708aa9336c2dd04bc9b5023aa0 
  3rdparty/libprocess/src/tests/http_tests.cpp 
4d372943a2d417d24d06444ec2e72909fb348017 
  3rdparty/libprocess/src/tests/socket_tests.cpp 
b09ae23a551c6587656b2d5f6f58c5267e8e0088 
  3rdparty/libprocess/src/tests/ssl_client.cpp 
de87b3b89c84d17f2ebba1f09e9ec682f139aace 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
5d360221937e68da185754f0633fa41a217c7107 


Diff: https://reviews.apache.org/r/70991/diff/2/

Changes: https://reviews.apache.org/r/70991/diff/1-2/


Testing
---


Thanks,

Benno Evers

Re: Review Request 70795: Updated SSL docs to include new libprocess flag.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70795/
---

(Updated July 4, 2019, 6:58 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Jan-Philip 
Gehrcke, Joseph Wu, and Till Toenshoff.


Changes
---

Renamed `libprocess` -> `legacy`.


Repository: mesos


Description
---

Added a description of the new `--hostname_validation_scheme` flag
and corresponding `LIBPROCESS_SSL_HOSTNAME_VALIDATION_SCHEME`
environment variable.


Diffs (updated)
-

  docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c 


Diff: https://reviews.apache.org/r/70795/diff/5/

Changes: https://reviews.apache.org/r/70795/diff/4-5/


Testing
---


Thanks,

Benno Evers

Re: Review Request 70749: Introduced RFC6125-compliant hostname validation scheme.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70749/
---

(Updated July 4, 2019, 6:52 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Joseph Wu, and 
Till Toenshoff.


Changes
---

Renamed 'libprocess' -> 'legacy'


Bugs: MESOS-9809
https://issues.apache.org/jira/browse/MESOS-9809


Repository: mesos


Description (updated)
---

This commit introduces a new libprocess SSL flag
`hostname_validation_scheme`, which can be set to 'legacy'
to select the previous hostname validation behaviour or to
'openssl' to use standardized OpenSSL algorithms to handle
hostname validation as part of the TLS handshake.

As a nice side-effect, the new scheme gets rid of reverse DNS
lookups during TLS connection establishment, which used to be
a common source of hard-to-debug unresponsiveness in Mesos
components.

See `docs/ssl.md` in the follow-up commit for details of and
differences between the schemes.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/flags.hpp 
f3483f97f93bb29117b2c78f0f2ed9735d9c4b3a 
  3rdparty/libprocess/src/openssl.hpp 17bec246e516261f8d772f1647c17f092fae82d1 
  3rdparty/libprocess/src/openssl.cpp 19d25a89f7dda1f6c66dd1ffc5051e35457d26b0 
  3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.hpp 
6ef5a86566af3439cfe0b06ab3576076623f7be0 
  3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp 
7e2229a9ed815727500bd457356e5531607fa6cf 


Diff: https://reviews.apache.org/r/70749/diff/9/

Changes: https://reviews.apache.org/r/70749/diff/8-9/


Testing
---

See added unit tests later in this chain.


Thanks,

Benno Evers

Re: Review Request 70921: Added OpenSSL-related changes to CHANGELOG.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70921/
---

(Updated July 4, 2019, 5:34 p.m.)


Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.


Repository: mesos


Description
---

Added OpenSSL-related changes to CHANGELOG.


Diffs (updated)
-

  CHANGELOG ecd01d6f415859eb6b9cfa3468db02d1810a3998 
  docs/upgrades.md 4a818df4993093770b49efb675b8078c42144241 


Diff: https://reviews.apache.org/r/70921/diff/3/

Changes: https://reviews.apache.org/r/70921/diff/2-3/


Testing
---


Thanks,

Benno Evers

Re: Review Request 70946: WIP: Added reviveOffers() and the new constructor to Java TestFramework.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70946/#review216388
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On June 25, 2019, 4:30 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70946/
> ---
> 
> (Updated June 25, 2019, 4:30 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-9793 and MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9793
> https://issues.apache.org/jira/browse/MESOS-9849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP: Added reviveOffers() and the new constructor to Java TestFramework.
> 
> 
> Diffs
> -
> 
>   src/examples/java/TestFramework.java 
> c8b0ceacd1305f7ff67f2ef490e14513d2757f5a 
> 
> 
> Diff: https://reviews.apache.org/r/70946/diff/1/
> 
> 
> Testing
> ---
> 
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" 
> --gtest_break_on_failure --gtest_repeat=10`
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 71013: Fixed flaky test `UpdateFrameworkV0Test.SuppressedRoles`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71013/#review216385
---



Patch looks great!

Reviews applied: [71013]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On July 4, 2019, 1:56 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71013/
> ---
> 
> (Updated July 4, 2019, 1:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9882
> https://issues.apache.org/jira/browse/MESOS-9882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, the test has been failing in cases when the first
> AGENT_ADDED message arrived after setting an expectation for the
> "second" one. After this patch, expectations for both messages are set,
> and this is performed before any of them can arrive.
> 
> 
> Diffs
> -
> 
>   src/tests/master/update_framework_tests.cpp 
> dda09fcd8f6e3cc268bf6897cd58a6444510bd16 
> 
> 
> Diff: https://reviews.apache.org/r/71013/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 70947: Added `reviveOffers(roles)` to V0 Java bindings.

[Andrei Sekretenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70947/
---

(Updated July 4, 2019, 3:23 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849


Repository: mesos


Description
---

Added `reviveOffers(roles)` to V0 Java bindings.


Diffs (updated)
-

  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
f81a69a7f13f976a09f11409a0ea3f40fccea1b8 
  src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
772a7383328519e63f0bf31908cb4c2129a77315 
  src/java/src/org/apache/mesos/SchedulerDriver.java 
155e4ac7b0e507c549a2d2de07ab95e215bf39e0 


Diff: https://reviews.apache.org/r/70947/diff/4/

Changes: https://reviews.apache.org/r/70947/diff/3-4/


Testing
---

`./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" 
--gtest_break_on_failure --gtest_repeat=10` with a patch from 
https://reviews.apache.org/r/70946/


Thanks,

Andrei Sekretenko

Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java bindings.

[Andrei Sekretenko]

> On July 3, 2019, 10:32 p.m., Benjamin Mahler wrote:
> > src/java/src/org/apache/mesos/MesosSchedulerDriver.java
> > Lines 402-404 (patched)
> > 
> >
> > Why the extra level of indirection? Why not just make this native like 
> > the others?

Somehow I was mislead into thinking that native methods do not support 
overloading.

Figured out how to do that and got rid of this indirection.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/#review216364
---


On July 4, 2019, 3:19 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70985/
> ---
> 
> (Updated July 4, 2019, 3:19 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `suppressOffers(roles)` to V0 Java bindings.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> f81a69a7f13f976a09f11409a0ea3f40fccea1b8 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
> 772a7383328519e63f0bf31908cb4c2129a77315 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> 155e4ac7b0e507c549a2d2de07ab95e215bf39e0 
> 
> 
> Diff: https://reviews.apache.org/r/70985/diff/3/
> 
> 
> Testing
> ---
> 
> Called this method from a modified example framework (WIP).
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 70991: Updated `Socket::connect()` API according to maintainer feedback.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70991/#review216383
---




3rdparty/libprocess/src/poll_socket.hpp
Lines 16-18 (patched)


No need for #ifdef.



3rdparty/libprocess/src/poll_socket.hpp
Lines 16-18 (patched)


No need for #ifdef.


- Till Toenshoff


On July 2, 2019, 5:50 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70991/
> ---
> 
> (Updated July 2, 2019, 5:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9878
> https://issues.apache.org/jira/browse/MESOS-9878
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reworked the API of `Socket::connect()` according to the following
> boundary conditions requested by libprocess maintainers:
> 
>  * It shall be possible to use custom connection options when
>connecting with a SSL socket.
>  * When libprocess is compiled without SSL support, neither the
>declaration of the TLS configuration object nor the `connnect()`
>overload that accepts the TLS configuration should be available.
>  * Passing just the servername is not an acceptable short-hand for
>using the default TLS configuration together with that servername.
>  * When the incorrect overload is selected (i.e. passing TLS config
>to a poll socket or omitting TLS configuration for a TLS socket),
>the program should abort.
> 
> This commit changes the API of `Socket::connect()` according to the
> requirements above. In particular:
> 
>  * A new class `openssl::TLSClientConfig` is introduced when libprocess
>is compiled with ssl support.
>  * A new overload
>`Socket::connect(const Address&, const TLSClientConfig&)` is
>introduced when libprocess is compiled with ssl support.
>  * All call sites are adjusted to check the socket kind before calling
>`connect()`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> 1ddcc2d5a30f7bf3914138e497a9b228b515cd29 
>   3rdparty/libprocess/include/process/socket.hpp 
> 4f0f6e9aa6e95e826e3de96e518a7200ad7a8f83 
>   3rdparty/libprocess/include/process/ssl/tls_config.hpp PRE-CREATION 
>   3rdparty/libprocess/src/http.cpp 3e73ee936f5c6329f41704a179f3d88ab65dfb6d 
>   3rdparty/libprocess/src/openssl.hpp 
> 17bec246e516261f8d772f1647c17f092fae82d1 
>   3rdparty/libprocess/src/openssl.cpp 
> 19d25a89f7dda1f6c66dd1ffc5051e35457d26b0 
>   3rdparty/libprocess/src/poll_socket.hpp 
> 15b7902ba2b10fad63e2ba7b8d5081d4b9e2d1c7 
>   3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.hpp 
> 6ef5a86566af3439cfe0b06ab3576076623f7be0 
>   3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp 
> 7e2229a9ed815727500bd457356e5531607fa6cf 
>   3rdparty/libprocess/src/posix/poll_socket.cpp 
> 74acb6942682a9d9626df81b303eba0a1c24ecf7 
>   3rdparty/libprocess/src/process.cpp 
> 799666f03d6a78708aa9336c2dd04bc9b5023aa0 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 4d372943a2d417d24d06444ec2e72909fb348017 
>   3rdparty/libprocess/src/tests/socket_tests.cpp 
> b09ae23a551c6587656b2d5f6f58c5267e8e0088 
>   3rdparty/libprocess/src/tests/ssl_client.cpp 
> de87b3b89c84d17f2ebba1f09e9ec682f139aace 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 5d360221937e68da185754f0633fa41a217c7107 
> 
> 
> Diff: https://reviews.apache.org/r/70991/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java bindings.

[Andrei Sekretenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/
---

(Updated July 4, 2019, 3:19 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849


Repository: mesos


Description
---

Added `suppressOffers(roles)` to V0 Java bindings.


Diffs (updated)
-

  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
f81a69a7f13f976a09f11409a0ea3f40fccea1b8 
  src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
772a7383328519e63f0bf31908cb4c2129a77315 
  src/java/src/org/apache/mesos/SchedulerDriver.java 
155e4ac7b0e507c549a2d2de07ab95e215bf39e0 


Diff: https://reviews.apache.org/r/70985/diff/3/

Changes: https://reviews.apache.org/r/70985/diff/2-3/


Testing
---

Called this method from a modified example framework (WIP).


Thanks,

Andrei Sekretenko

Re: Review Request 70994: Moved to sepearte methods the (un)suppressing logic common with update.

[Andrei Sekretenko]

> On July 3, 2019, 8:47 p.m., Benjamin Mahler wrote:
> > How about:
> > 
> > ```
> > Extracted suppression logic in allocator for use in update framework.
> > 
> > This patch moves the logic of suppressing/unsuppressing a role set from
> > the inside of 'suppressOffers()'/'reviveOffers()' into separate methods.
> > Specifically, 'reviveOffers()' includes filter clearing logic that we
> > don't want when unsuppressing roles during framework update. For
> > 'supppressOffers()', we need the empty set == all roles semantics, but
> > we don't want that in the suppression logic during framework update.
> > 
> > Longer term, the empty set == all roles semantics could be done in
> > the master and we won't need the extra function to provide empty set
> > == all roles logic in the allocator.
> > 
> > This is a prerequisite for using thes methods to fix
> > 'updateFramework()' in a subsequent patch.
> > ```
> > 
> > Note that I think we don't need the extra suppression function in the 
> > allocator, however we need to update the master to provide the empty set == 
> > all roles semantics (which is more of a protobuf API concern than something 
> > the allocator should know about).

Thanks! Looks much better.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70994/#review216358
---


On July 2, 2019, 7:10 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70994/
> ---
> 
> (Updated July 2, 2019, 7:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9870
> https://issues.apache.org/jira/browse/MESOS-9870
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch moves the logic of suppressing/unsuppressing a role set from
> the inside of 'suppressOffers()'/'reviveOffers()' into separate methods.
> 
> This is a prerequisite for using this methods to fix updateFramework()
> in the dependent patch.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 7e9765263f969a4499358579f1ee5bb1afb053da 
>   src/master/allocator/mesos/hierarchical.cpp 
> 26aad6778f12b99bb87c846788d6b6d60f743d8a 
> 
> 
> Diff: https://reviews.apache.org/r/70994/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 70921: Added OpenSSL-related changes to CHANGELOG.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70921/#review216382
---


Fix it, then Ship it!




Ship It!


CHANGELOG
Lines 9 (patched)


s/should/will/



CHANGELOG
Lines 27 (patched)


How about:

... will now forego TLS certificate verification ...



CHANGELOG
Lines 27 (patched)


How about:

... will now forego TLS certificate verification ...



docs/upgrades.md
Lines 516 (patched)


s/change/configure/



docs/upgrades.md
Lines 526 (patched)


How about?
```  * For incoming connections, certificates are not verified unless 
`LIBPROCESS_SSL_REQUIRE_CERT` is set to true.
```



docs/upgrades.md
Lines 527 (patched)


This is really hard to parse but right now I am unable to come up with 
something easier for the eye -- lets try to improve this with some native 
speaker help.


- Till Toenshoff


On June 21, 2019, 3:02 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70921/
> ---
> 
> (Updated June 21, 2019, 3:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added OpenSSL-related changes to CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG ecd01d6f415859eb6b9cfa3468db02d1810a3998 
>   docs/upgrades.md 4a818df4993093770b49efb675b8078c42144241 
> 
> 
> Diff: https://reviews.apache.org/r/70921/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70993: Added warnings about known problems with libevent epoll backend.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70993/#review216381
---


Ship it!




Ship It!

- Till Toenshoff


On July 2, 2019, 5:53 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70993/
> ---
> 
> (Updated July 2, 2019, 5:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-9867
> https://issues.apache.org/jira/browse/MESOS-9867
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some SSL options are known to cause issues in combination with
> older versions of libevent. Detect and warn about this situation.
> 
> See MESOS-9867 for details.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am 851a842114bb19abb00a318c85824067d68d71f6 
>   3rdparty/libprocess/src/openssl.cpp 
> 19d25a89f7dda1f6c66dd1ffc5051e35457d26b0 
> 
> 
> Diff: https://reviews.apache.org/r/70993/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70933: Moved an inline duration for slow DNS logging into a const variable.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70933/#review216380
---


Ship it!




Ship It!

- Till Toenshoff


On June 24, 2019, 12:22 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70933/
> ---
> 
> (Updated June 24, 2019, 12:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the 100ms threshold that was used for printing warning
> messages about slow reverse DNS lookups into a named variable.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> 19d25a89f7dda1f6c66dd1ffc5051e35457d26b0 
> 
> 
> Diff: https://reviews.apache.org/r/70933/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70797: Added unit tests for hostname validation.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70797/#review216379
---


Ship it!




Ship It!

- Till Toenshoff


On July 2, 2019, 5:53 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70797/
> ---
> 
> (Updated July 2, 2019, 5:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Joseph Wu, 
> and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds some unit tests to verify the newly added 
> `hostname_validation_scheme` flag is working as intended.
> 
> While going through the existing tests to look for candidates
> that would benefit from being tested for both hostname validation
> schemes, I noticed a number of existing tests where test setup
> did not quite match the comment or test name. I fixed these up
> in this review as well.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> 6cdd7815f4389cd398defe56260a73eb710a4d8f 
>   3rdparty/libprocess/src/tests/ssl_client.cpp 
> de87b3b89c84d17f2ebba1f09e9ec682f139aace 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 5d360221937e68da185754f0633fa41a217c7107 
> 
> 
> Diff: https://reviews.apache.org/r/70797/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70797: Added unit tests for hostname validation.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70797/#review216378
---




3rdparty/libprocess/src/tests/ssl_tests.cpp
Line 318 (original), 368 (patched)


s/incorrect/not matching/


- Till Toenshoff


On July 2, 2019, 5:53 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70797/
> ---
> 
> (Updated July 2, 2019, 5:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Joseph Wu, 
> and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds some unit tests to verify the newly added 
> `hostname_validation_scheme` flag is working as intended.
> 
> While going through the existing tests to look for candidates
> that would benefit from being tested for both hostname validation
> schemes, I noticed a number of existing tests where test setup
> did not quite match the comment or test name. I fixed these up
> in this review as well.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> 6cdd7815f4389cd398defe56260a73eb710a4d8f 
>   3rdparty/libprocess/src/tests/ssl_client.cpp 
> de87b3b89c84d17f2ebba1f09e9ec682f139aace 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 5d360221937e68da185754f0633fa41a217c7107 
> 
> 
> Diff: https://reviews.apache.org/r/70797/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70992: Recorded Socket API change in CHANGELOG.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70992/#review216377
---


Ship it!




Ship It!

- Till Toenshoff


On July 4, 2019, 2:28 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70992/
> ---
> 
> (Updated July 4, 2019, 2:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Recorded Socket API change in CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG ecd01d6f415859eb6b9cfa3468db02d1810a3998 
> 
> 
> Diff: https://reviews.apache.org/r/70992/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70992: Recorded Socket API change in CHANGELOG.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70992/
---

(Updated July 4, 2019, 2:28 p.m.)


Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.


Summary (updated)
-

Recorded Socket API change in CHANGELOG.


Repository: mesos


Description (updated)
---

Recorded Socket API change in CHANGELOG.


Diffs (updated)
-

  CHANGELOG ecd01d6f415859eb6b9cfa3468db02d1810a3998 


Diff: https://reviews.apache.org/r/70992/diff/2/

Changes: https://reviews.apache.org/r/70992/diff/1-2/


Testing
---


Thanks,

Benno Evers

Review Request 71013: Fixed flaky test `UpdateFrameworkV0Test.SuppressedRoles`.

[Andrei Sekretenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71013/
---

Review request for mesos, Benjamin Mahler and Meng Zhu.


Bugs: MESOS-9882
https://issues.apache.org/jira/browse/MESOS-9882


Repository: mesos


Description
---

Previously, the test has been failing in cases when the first
AGENT_ADDED message arrived after setting an expectation for the
"second" one. After this patch, expectations for both messages are set,
and this is performed before any of them can arrive.


Diffs
-

  src/tests/master/update_framework_tests.cpp 
dda09fcd8f6e3cc268bf6897cd58a6444510bd16 


Diff: https://reviews.apache.org/r/71013/diff/1/


Testing
---


Thanks,

Andrei Sekretenko