Re: Review Request 71139: Removed `quota_info` in the `GET_QUOTA` authorization object.

2019-07-22 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71139/#review216797
---



Patch looks great!

Reviews applied: [71139]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On July 23, 2019, 1:46 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71139/
> ---
> 
> (Updated July 23, 2019, 1:46 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9668
> https://issues.apache.org/jira/browse/MESOS-9668
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, the `GET_QUOTA` authorizable action set both  `value`
> and `quota_info` fields. The `value` field is set due to
> backward compatibility for the `GET_QUOTA_WITH_ROLE` action.
> 
> This patch makes the `GET_QUOTA` action only set the `value`
> field with the role name. Since the `quota.QuotaInfo` field
> is being deprecated, it is no longer set (the local authorizer
> only looks at the `value` field, it is also probably the case
> for any external authorizer modules).
> 
> Also refactored `QuotaHandler::status`.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.proto 
> d09c2341154a39dc74e304742920e01183f0cab1 
>   src/authorizer/local/authorizer.cpp 
> 85821c6b4877e319a2879b26492338b2cd903a6f 
>   src/master/master.hpp 5c229c53f96dda6b30731017b8adbf57c9fc9f95 
>   src/master/quota_handler.cpp 2a3ca5640c850ec8a8aca7abed45386b5b5e1125 
> 
> 
> Diff: https://reviews.apache.org/r/71139/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 71140: Fixed devolution of 'max_grace_period' field in DRAIN_AGENT call.

2019-07-22 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71140/#review216795
---


Ship it!




Ship It!

- Joseph Wu


On July 22, 2019, 6:51 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71140/
> ---
> 
> (Updated July 22, 2019, 6:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed devolution of 'max_grace_period' field in DRAIN_AGENT call.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.cpp 2809c25fcf972e8a22528e55cd439dd64bd04dbb 
>   src/tests/api_tests.cpp 3479ed31e9cbbe4b61a4fe092b684677f488c621 
> 
> 
> Diff: https://reviews.apache.org/r/71140/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 71140: Fixed devolution of 'max_grace_period' field in DRAIN_AGENT call.

2019-07-22 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71140/
---

Review request for mesos, Benjamin Bannier, Joseph Wu, and Vinod Kone.


Repository: mesos


Description
---

Fixed devolution of 'max_grace_period' field in DRAIN_AGENT call.


Diffs
-

  src/internal/devolve.cpp 2809c25fcf972e8a22528e55cd439dd64bd04dbb 
  src/tests/api_tests.cpp 3479ed31e9cbbe4b61a4fe092b684677f488c621 


Diff: https://reviews.apache.org/r/71140/diff/1/


Testing
---

`make check`


Thanks,

Greg Mann

Review Request 71139: Removed `quota_info` in the `GET_QUOTA` authorization object.

2019-07-22 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71139/
---

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Bugs: MESOS-9668
https://issues.apache.org/jira/browse/MESOS-9668


Repository: mesos


Description
---

Currently, the `GET_QUOTA` authorizable action set both  `value`
and `quota_info` fields. The `value` field is set due to
backward compatibility for the `GET_QUOTA_WITH_ROLE` action.

This patch makes the `GET_QUOTA` action only set the `value`
field with the role name. Since the `quota.QuotaInfo` field
is being deprecated, it is no longer set (the local authorizer
only looks at the `value` field, it is also probably the case
for any external authorizer modules).

Also refactored `QuotaHandler::status`.


Diffs
-

  include/mesos/authorizer/authorizer.proto 
d09c2341154a39dc74e304742920e01183f0cab1 
  src/authorizer/local/authorizer.cpp 85821c6b4877e319a2879b26492338b2cd903a6f 
  src/master/master.hpp 5c229c53f96dda6b30731017b8adbf57c9fc9f95 
  src/master/quota_handler.cpp 2a3ca5640c850ec8a8aca7abed45386b5b5e1125 


Diff: https://reviews.apache.org/r/71139/diff/1/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 71138: Updated configure.ac to correct openssl/libevent setup.

2019-07-22 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71138/#review216794
---



Bad patch!

Reviews applied: [71138]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71138"]

Error:
..
00:00:58.097410 18539 http.cpp:1115] HTTP POST for /master/api/v1 from 
172.17.0.2:33926
I0723 00:00:58.097684 18539 http.cpp:263] Processing call UNRESERVE_RESOURCES
I0723 00:00:58.098284 18539 master.cpp:3915] Authorizing principal 
'test-principal' to unreserve resources 
'[{"disk":{"source":{"id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v0_zdehvR/2GB-77f7341c-7c5d-46e4-bd9d-ed12756d9c8f","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"profile":"test","type":"MOUNT","vendor":"org.apache.mesos.csi.test.local"}},"name":"disk","provider_id":{"value":"ce98c095-ffea-46cc-a0b4-a5e943390ca3"},"reservations":[{"role":"storage","type":"DYNAMIC"},{"principal":"test-principal","role":"storage/default-role","type":"DYNAMIC"}],"scalar":{"value":2048.0},"type":"SCALAR"}]'
I0723 00:00:58.100175 18549 master.cpp:12712] Removing offer 
ccd659fb-75a9-4391-99f0-b3115b392669-O5
I0723 00:00:58.100266 18546 sched.cpp:960] Rescinded offer 
ccd659fb-75a9-4391-99f0-b3115b392669-O5
I0723 00:00:58.100337 18546 sched.cpp:971] Scheduler::offerRescinded took 
23171ns
I0723 00:00:58.100958 18540 hierarchical.cpp:1218] Recovered disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v0_zdehvR/2GB-77f7341c-7c5d-46e4-bd9d-ed12756d9c8f,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024; 
ports(allocated: storage/default-role):[31000-32000] (total: cpus:2; mem:1024; 
disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v0_zdehvR/2GB-77f7341c-7c5d-46e4-bd9d-ed12756d9c8f,test)]:2048,
 allocated: {}) on agent ccd659fb-75a9-4391-99f0-b3115b392669-S0 from framework 
ccd659fb-75a9-43
 91-99f0-b3115b392669-
I0723 00:00:58.101083 18540 hierarchical.cpp:1264] Framework 
ccd659fb-75a9-4391-99f0-b3115b392669- filtered agent 
ccd659fb-75a9-4391-99f0-b3115b392669-S0 for 5secs
I0723 00:00:58.103662 18560 master.cpp:12603] Sending operation '' (uuid: 
9acb0d2a-f403-41fa-bf6d-35950f8dbf70) to agent 
ccd659fb-75a9-4391-99f0-b3115b392669-S0 at slave(1212)@172.17.0.2:45395 
(13e7e56a1dc8)
I0723 00:00:58.104190 18541 slave.cpp:4345] Ignoring new checkpointed resources 
and operations identical to the current version
I0723 00:00:58.106492 18556 hierarchical.cpp:1508] Performed allocation for 1 
agents in 1.11498ms
I0723 00:00:58.106875 18550 provider.cpp:481] Received APPLY_OPERATION event
I0723 00:00:58.106918 18550 provider.cpp:1295] Received UNRESERVE operation '' 
(uuid: 9acb0d2a-f403-41fa-bf6d-35950f8dbf70)
I0723 00:00:58.107141 18555 master.cpp:10420] Sending offers [ 
ccd659fb-75a9-4391-99f0-b3115b392669-O6 ] to framework 
ccd659fb-75a9-4391-99f0-b3115b392669- (default) at 
scheduler-8bb3f5c1-a7d1-4716-bc53-0717bfe00ba6@172.17.0.2:45395
I0723 00:00:58.107719 18539 sched.cpp:934] Scheduler::resourceOffers took 
72665ns
I0723 00:00:58.132086 18548 http.cpp:1115] HTTP POST for 
/slave(1212)/api/v1/resource_provider from 172.17.0.2:33916
I0723 00:00:58.132982 18560 slave.cpp:8416] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 07388c9a-2fdf-4926-b3d7-c91d7324f953) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I0723 00:00:58.133174 18560 slave.cpp:8869] Updating the state of operation 
with no ID (uuid: 07388c9a-2fdf-4926-b3d7-c91d7324f953) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I0723 00:00:58.133230 18560 slave.cpp:8623] Forwarding status update of 
operation with no ID (operation_uuid: 07388c9a-2fdf-4926-b3d7-c91d7324f953) for 
an operator API call
I0723 00:00:58.133565 18544 master.cpp:12259] Updating the state of operation 
'' (uuid: 07388c9a-2fdf-4926-b3d7-c91d7324f953) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I0723 00:00:58.134079 18547 slave.cpp:4345] Ignoring new checkpointed resources 
and operations identical to the

Re: Review Request 71138: Updated configure.ac to correct openssl/libevent setup.

2019-07-22 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71138/#review216793
---


Ship it!




Ship It!

- Vinod Kone


On July 22, 2019, 10:17 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71138/
> ---
> 
> (Updated July 22, 2019, 10:17 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixes a problem introduced by configure.ac reordering in commit 4df2b62.
> 
> 
> Diffs
> -
> 
>   configure.ac 0e3058c2bcd730a0992ca497809ab09c58ed6fa1 
> 
> 
> Diff: https://reviews.apache.org/r/71138/diff/1/
> 
> 
> Testing
> ---
> 
> Tested within DC/OS build CI which failed without this fix.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Review Request 71138: Updated configure.ac to correct openssl/libevent setup.

2019-07-22 Thread Till Toenshoff via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71138/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Fixes a problem introduced by configure.ac reordering in commit 4df2b62.


Diffs
-

  configure.ac 0e3058c2bcd730a0992ca497809ab09c58ed6fa1 


Diff: https://reviews.apache.org/r/71138/diff/1/


Testing
---

Tested within DC/OS build CI which failed without this fix.


Thanks,

Till Toenshoff

Re: Review Request 71136: Fixed use-after-free bug in `PendingFutureTrackerProcess`.

2019-07-22 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71136/#review216792
---


Ship it!




Ship It!

- Gilbert Song


On July 22, 2019, 8:51 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71136/
> ---
> 
> (Updated July 22, 2019, 8:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gilbert Song, Meng Zhu, and Qian 
> Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, the future tracker subscribed on `onAny`, `onAbandoned`,
> `onDiscard` events for the future using callbacks, which accept
> the same iterator to the `pending` list. Since `onAny` and `onDiscard`
> events can overlap, the same callback can be called more than once,
> which leads to accessing invalidated iterator. This patch fixes the
> problem by removing `onDiscard` handler because it does not transition
> a future to the terminal state.
> 
> 
> Diffs
> -
> 
>   src/common/future_tracker.hpp a3f191a58b7ada58153ca33a8d0409b846faedae 
> 
> 
> Diff: https://reviews.apache.org/r/71136/diff/2/
> 
> 
> Testing
> ---
> 
> I was able to reproduce a segfault observed in our CI by launching 
> `ROOT_LaunchGroupFailure` test in the loop with `stress` running in parallel:
> ```
> sudo src/mesos-tests --verbose --gtest_repeat=100 --break_on_failure 
> --gtest_filter=ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.ROOT_LaunchGroupFailure/0
> 
> stress -c 16
> ```
> After applying the patch, the test passed successfully.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 71136: Fixed use-after-free bug in `PendingFutureTrackerProcess`.

2019-07-22 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71136/#review216791
---




src/common/future_tracker.hpp
Lines 67-68 (original), 73-74 (patched)


could we consider to remove .onDiscard()?

I believe the registered future or other futures chained in the 
containerizer already have onDiscard handler, which means that the future will 
somehow transit to terminated state or a terminated state will be propagated 
back to this future if someone calls .discard() or from a discard is called by 
a HTTP disconnection.

If that is the case, .onAny + .onAbandoned should be sufficient. wdyt?


- Gilbert Song


On July 22, 2019, 8:51 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71136/
> ---
> 
> (Updated July 22, 2019, 8:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gilbert Song, Meng Zhu, and Qian 
> Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, the future tracker subscribed on `onAny`, `onAbandoned`,
> `onDiscard` events for the future using callbacks, which accept
> the same iterator to the `pending` list. Since above mentioned events
> can overlap, the same callback can be called more than once, which
> leads to accessing invalidated iterator. This patch fixes the problem
> by introducing `erased` flag.
> 
> 
> Diffs
> -
> 
>   src/common/future_tracker.hpp a3f191a58b7ada58153ca33a8d0409b846faedae 
> 
> 
> Diff: https://reviews.apache.org/r/71136/diff/1/
> 
> 
> Testing
> ---
> 
> I was able to reproduce a segfault observed in our CI by launching 
> `ROOT_LaunchGroupFailure` test in the loop with `stress` running in parallel:
> ```
> sudo src/mesos-tests --verbose --gtest_repeat=100 --break_on_failure 
> --gtest_filter=ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.ROOT_LaunchGroupFailure/0
> 
> stress -c 16
> ```
> After applying the patch, the test passed successfully.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 71136: Fixed use-after-free bug in `PendingFutureTrackerProcess`.

2019-07-22 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71136/#review216790
---



Bad patch!

Reviews applied: [71136]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71136"]

Error:
..
_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 
-DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.9.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 
-I../glog-0.4.0/src -I../grpc-1.10.0/include -I../http-parser-2.6.2 
-I../libev-4.22 -D__STDC_FORMAT_MACROS -I../picojson-1.3.0 
-I../protobuf-3.5.0/src -I../rapidjson-1.1.0/include 
-I../../../3rdparty/libprocess/../stout/include -DLIBPROCESS_ALLOW_JEMALLOC 
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -Wall 
-Wsign-compare -Wformat-security -fstack-protector -fPIC -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c 
../../../3rdparty/libprocess/src/firewall.cpp  -fPIC -DPIC -o 
src/.libs/libprocess_la-firewall.o
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.9.0\" "-DPACKAGE_STRING=\"mesos 1.9.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.9.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.0 -I
 ../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src 
-I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include -I../../../3rdparty/libprocess/../stout/include 
-DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0 -Wall -Wsign-compare -Wformat-security -fstack-protector 
-fPIC -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c 
../../../3rdparty/libprocess/src/clock.cpp  -fPIC -DPIC -o 
src/.libs/libprocess_la-clock.o
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.9.0\" "-DPACKAGE_STRING=\"mesos 1.9.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.9.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.0 -I
 ../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src 
-I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include -I../../../3rdparty/libprocess/../stout/include 
-DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0 -Wall -Wsign-compare -Wformat-security -fstack-protector 
-fPIC -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c 
../../../3rdparty/libprocess/src/grpc.cpp  -fPIC -DPIC -o 
src/.libs/libprocess_la-grpc.o
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.9.0\" "-DPACKAGE_STRING=\"mesos 1.9.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1

Review Request 71136: Fixed use-after-free bug in `PendingFutureTrackerProcess`.

2019-07-22 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71136/
---

Review request for mesos, Benjamin Mahler, Gilbert Song, Meng Zhu, and Qian 
Zhang.


Repository: mesos


Description
---

Previously, the future tracker subscribed on `onAny`, `onAbandoned`,
`onDiscard` events for the future using callbacks, which accept
the same iterator to the `pending` list. Since above mentioned events
can overlap, the same callback can be called more than once, which
leads to accessing invalidated iterator. This patch fixes the problem
by introducing `erased` flag.


Diffs
-

  src/common/future_tracker.hpp a3f191a58b7ada58153ca33a8d0409b846faedae 


Diff: https://reviews.apache.org/r/71136/diff/1/


Testing
---

I was able to reproduce a segfault observed in our CI by launching 
`ROOT_LaunchGroupFailure` test in the loop with `stress` running in parallel:
```
sudo src/mesos-tests --verbose --gtest_repeat=100 --break_on_failure 
--gtest_filter=ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.ROOT_LaunchGroupFailure/0

stress -c 16
```
After applying the patch, the test passed successfully.


Thanks,

Andrei Budnik

[GitHub] [mesos] vinodkone merged pull request #340: Documented EOF in ATTACH_CONTAINER_INPUT

2019-07-22 Thread GitBox 
vinodkone merged pull request #340: Documented EOF in ATTACH_CONTAINER_INPUT
URL: https://github.com/apache/mesos/pull/340
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mesos] bamarni commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT

2019-07-22 Thread GitBox 
bamarni commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT
URL: https://github.com/apache/mesos/pull/340#issuecomment-513828218
 
 
   Thanks for the clarification @abudnik @vinodkone , I've updated the PR


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services