Re: Review Request 50217: Added disk full framework to example frameworks unit test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50217/ --- (Updated July 25, 2016, 12:22 p.m.) Review request for mesos and Joseph Wu. Changes --- Added `mesos` group -- Joseph. Bugs: MESOS-5855 https://issues.apache.org/jira/browse/MESOS-5855 Repository: mesos Description --- Added disk full framework to example frameworks unit test. Diffs - src/tests/disk_full_framework_test.sh PRE-CREATION src/tests/examples_tests.cpp ac513ce9aa3c8f366fe81ba937e3dc0d51a26940 Diff: https://reviews.apache.org/r/50217/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 46626: Added example framework for testing disk quota enforcement.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/ --- (Updated July 25, 2016, 12:22 p.m.) Review request for mesos and Joseph Wu. Changes --- Added `mesos` group -- Joseph. Bugs: MESOS-5855 https://issues.apache.org/jira/browse/MESOS-5855 Repository: mesos Description --- Added example framework for testing disk quota enforcement. Diffs - src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d src/examples/disk_full_framework.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46626/diff/ Testing --- Thanks, Artem Harutyunyan
Review Request 50313: Added Developer Community Status blog post.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50313/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --- Added Developer Community Status blog post. Diffs - site/source/assets/js/dev-community.js PRE-CREATION site/source/blog/2016-07-21-dev-community-status.md PRE-CREATION site/source/layouts/basic.erb 950c5a381c6832a197968ebfb36f4cb54ab2aa1d site/source/layouts/dev-community.erb PRE-CREATION Diff: https://reviews.apache.org/r/50313/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 46626: Added example framework for testing disk quota enforcement.
> On July 19, 2016, 1:40 p.m., Joseph Wu wrote: > > LGTM, modulo the examples tests patch, which is presumably coming up next :) https://reviews.apache.org/r/50217/ - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/#review142825 --- On July 19, 2016, 6:23 p.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46626/ > --- > > (Updated July 19, 2016, 6:23 p.m.) > > > Review request for Joseph Wu. > > > Bugs: MESOS-5855 > https://issues.apache.org/jira/browse/MESOS-5855 > > > Repository: mesos > > > Description > --- > > Added example framework for testing disk quota enforcement. > > > Diffs > - > > src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d > src/examples/disk_full_framework.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46626/diff/ > > > Testing > --- > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 46626: Added example framework for testing disk quota enforcement.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/ --- (Updated July 19, 2016, 6:23 p.m.) Review request for Joseph Wu. Bugs: MESOS-5855 https://issues.apache.org/jira/browse/MESOS-5855 Repository: mesos Description --- Added example framework for testing disk quota enforcement. Diffs (updated) - src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d src/examples/disk_full_framework.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46626/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 46626: Added example framework for testing disk quota enforcement.
> On July 18, 2016, 2:28 p.m., Joseph Wu wrote: > > src/Makefile.am, line 1898 > > <https://reviews.apache.org/r/46626/diff/4/?file=1445381#file1445381line1898> > > > > Can you also add this to `examples_tests.cpp`? Will do in a followup review. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/#review142631 --- On July 19, 2016, 12:15 p.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46626/ > --- > > (Updated July 19, 2016, 12:15 p.m.) > > > Review request for Joseph Wu. > > > Bugs: MESOS-5855 > https://issues.apache.org/jira/browse/MESOS-5855 > > > Repository: mesos > > > Description > --- > > Added example framework for testing disk quota enforcement. > > > Diffs > - > > src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d > src/examples/disk_full_framework.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46626/diff/ > > > Testing > --- > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 46626: Added example framework for testing disk quota enforcement.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/ --- (Updated July 19, 2016, 12:15 p.m.) Review request for Joseph Wu. Bugs: MESOS-5855 https://issues.apache.org/jira/browse/MESOS-5855 Repository: mesos Description --- Added example framework for testing disk quota enforcement. Diffs (updated) - src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d src/examples/disk_full_framework.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46626/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 46626: Added example framework for testing disk quota enforcement.
> On June 7, 2016, 2:10 p.m., Joseph Wu wrote: > > src/examples/disk_full_framework.cpp, lines 89-96 > > <https://reviews.apache.org/r/46626/diff/3/?file=1408932#file1408932line89> > > > > Looks like there are currently two scenarios: > > > > 1) Disk quota is enforced -> task fails. > > 2) Disk quota is not enforced -> task finishes. > > > > Can you add an option so that we can perform a sanity (null hypothesis) > > check? i.e. The task uses less disk than it requested. Will follow up and add a 'Disk not full' example framework. https://issues.apache.org/jira/browse/MESOS-5855 - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/#review136528 ------- On July 16, 2016, 8:30 p.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46626/ > --- > > (Updated July 16, 2016, 8:30 p.m.) > > > Review request for Joseph Wu. > > > Bugs: MESOS-5855 > https://issues.apache.org/jira/browse/MESOS-5855 > > > Repository: mesos > > > Description > --- > > Added example framework for testing disk quota enforcement. > > > Diffs > - > > src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d > src/examples/disk_full_framework.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46626/diff/ > > > Testing > --- > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 46626: Added example framework for testing disk quota enforcement.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/ --- (Updated July 16, 2016, 8:30 p.m.) Review request for Joseph Wu. Bugs: MESOS-5855 https://issues.apache.org/jira/browse/MESOS-5855 Repository: mesos Description --- Added example framework for testing disk quota enforcement. Diffs (updated) - src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d src/examples/disk_full_framework.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46626/diff/ Testing --- Thanks, Artem Harutyunyan
Review Request 49211: Renamed and moved AFFILIATIONS.yml to docs/contributors.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49211/ --- Review request for mesos. Summary (updated) - Renamed and moved AFFILIATIONS.yml to docs/contributors.yaml. Repository: mesos Description (updated) --- Renamed and moved AFFILIATIONS.yml to docs/contributors.yaml. Diffs (updated) - AFFILIATIONS.yml 9ce51eb317b2d99b4a1bf134ad0f69ef15799bcf docs/submitting-a-patch.md 338241827f3e6a46cc54eb6416b2b9aae4f99b18 Diff: https://reviews.apache.org/r/49211/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 49170: Added a bullet point on JIRA and a snippet on AFFILIATIONS.yml.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49170/ --- (Updated June 23, 2016, 9:49 p.m.) Review request for mesos, Joris Van Remoortere and Vinod Kone. Repository: mesos Description --- Added a bullet point on JIRA and a snippet on AFFILIATIONS.yml. Diffs (updated) - docs/submitting-a-patch.md 92330f99a6bab1547806e239d33c2e6e788fd4f4 Diff: https://reviews.apache.org/r/49170/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 49170: Added a bullet point on JIRA and a snippet on AFFILIATIONS.yml.
> On June 23, 2016, 5:12 p.m., Vinod Kone wrote: > > docs/submitting-a-patch.md, line 29 > > <https://reviews.apache.org/r/49170/diff/1/?file=1428871#file1428871line29> > > > > Lets ask them to include the PR# created above in the email. We should get a notification from merginng the PR, so the email should be redundant at that point. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49170/#review139311 --- On June 23, 2016, 9:49 p.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49170/ > --- > > (Updated June 23, 2016, 9:49 p.m.) > > > Review request for mesos, Joris Van Remoortere and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Added a bullet point on JIRA and a snippet on AFFILIATIONS.yml. > > > Diffs > - > > docs/submitting-a-patch.md 92330f99a6bab1547806e239d33c2e6e788fd4f4 > > Diff: https://reviews.apache.org/r/49170/diff/ > > > Testing > --- > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 49067: Added AFFILIATIONS.yml file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49067/ --- (Updated June 23, 2016, 9:47 p.m.) Review request for mesos, Joris Van Remoortere and Vinod Kone. Repository: mesos Description --- Added AFFILIATIONS.yml file. Diffs (updated) - AFFILIATIONS.yml PRE-CREATION Diff: https://reviews.apache.org/r/49067/diff/ Testing --- Parsed the file with a test script to validate the syntax and generate the list of contributors currently missing from the file. Thanks, Artem Harutyunyan
Re: Review Request 49067: Added AFFILIATIONS.yml file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49067/ --- (Updated June 23, 2016, 2:27 p.m.) Review request for Joris Van Remoortere and Vinod Kone. Repository: mesos Description --- Added AFFILIATIONS.yml file. Diffs (updated) - AFFILIATIONS.yml PRE-CREATION Diff: https://reviews.apache.org/r/49067/diff/ Testing --- Parsed the file with a test script to validate the syntax and generate the list of contributors currently missing from the file. Thanks, Artem Harutyunyan
Re: Review Request 49067: Added AFFILIATIONS.yml file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49067/ --- (Updated June 23, 2016, 2:23 p.m.) Review request for Joris Van Remoortere and Vinod Kone. Repository: mesos Description --- Added AFFILIATIONS.yml file. Diffs (updated) - AFFILIATIONS.yml PRE-CREATION Diff: https://reviews.apache.org/r/49067/diff/ Testing --- Parsed the file with a test script to validate the syntax and generate the list of contributors currently missing from the file. Thanks, Artem Harutyunyan
Re: Review Request 49067: Added AFFILIATIONS.yml file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49067/ --- (Updated June 22, 2016, 12:05 a.m.) Review request for mesos, Joris Van Remoortere and Vinod Kone. Repository: mesos Description --- Added AFFILIATIONS.yml file. Diffs (updated) - AFFILIATIONS.yml PRE-CREATION Diff: https://reviews.apache.org/r/49067/diff/ Testing (updated) --- Parsed the file with a test script to validate the syntax and generate the list of contributors currently missing from the file. Thanks, Artem Harutyunyan
Review Request 49067: Added AFFILIATIONS.yml file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49067/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Repository: mesos Description --- Added AFFILIATIONS.yml file. Diffs - AFFILIATIONS.yml PRE-CREATION Diff: https://reviews.apache.org/r/49067/diff/ Testing --- Parsed the file with a test script to validate the syntax. Thanks, Artem Harutyunyan
Re: Review Request 46626: Added example framework for testing disk quota enforcement.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/ --- (Updated June 7, 2016, 9:56 a.m.) Review request for mesos and Joseph Wu. Repository: mesos Description --- Added example framework for testing disk quota enforcement. Diffs (updated) - src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 src/examples/disk_full_framework.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46626/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 46626: Added example framework for testing disk quota enforcement.
> On May 27, 2016, 6 p.m., Joseph Wu wrote: > > src/examples/disk_full_framework.cpp, line 171 > > <https://reviews.apache.org/r/46626/diff/1/?file=1359466#file1359466line171> > > > > What's the importance of this sleep after the disk ramp-up? And would > > it make sense for this sleep to be configurable too? Done. Thanks. > On May 27, 2016, 6 p.m., Joseph Wu wrote: > > src/examples/disk_full_framework.cpp, lines 237-238 > > <https://reviews.apache.org/r/46626/diff/1/?file=1359466#file1359466line237> > > > > Consider omitting the `default:`, or aborting in this case. I either need to have the default, or explicitly list the missing task states. If we list states explicitly the code won't compile without modifications in case we introduce a new state. Maybe it's a good thing. What do you think? I am open to suggestsions. And what do you mean by abort? Exiting the framework? - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/#review134863 ------- On June 7, 2016, 9:10 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46626/ > --- > > (Updated June 7, 2016, 9:10 a.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Added example framework for testing disk quota enforcement. > > > Diffs > - > > src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 > src/examples/disk_full_framework.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46626/diff/ > > > Testing > --- > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 46626: Added example framework for testing disk quota enforcement.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/ --- (Updated June 7, 2016, 9:10 a.m.) Review request for mesos and Joseph Wu. Changes --- Addressed comments and squashed some metrics bugs. Repository: mesos Description --- Added example framework for testing disk quota enforcement. Diffs (updated) - src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 src/examples/disk_full_framework.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46626/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.
> On Feb. 6, 2016, 7:39 p.m., Guangya Liu wrote: > > @Maged, I think that you can now find a shephard for this. You can post an > > email to d...@mesos.apache.org to ask for a shephard for MESOS-4353 Folks, generally the expectation is that the shepherd is found *before* the code gets written and not after the patch has gone through a number of interations on the reviewboard. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review118168 --- On Feb. 6, 2016, 7:34 p.m., Maged Michael wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43144/ > --- > > (Updated Feb. 6, 2016, 7:34 p.m.) > > > Review request for mesos, Guangya Liu, Klaus Ma, and Qian Zhang. > > > Bugs: MESOS-4353 > https://issues.apache.org/jira/browse/MESOS-4353 > > > Repository: mesos > > > Description > --- > > Added env var to set upper bound on number of libprocess worker threads. > > > Diffs > - > > 3rdparty/libprocess/src/process.cpp d8a74d7 > docs/configuration.md 4b5a394 > > Diff: https://reviews.apache.org/r/43144/diff/ > > > Testing > --- > > Passed make check on x86_64 Ubuntu 14.04. > > Invocations of mesos-master, mesos-slave, and mesos-tests with the > LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", > "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system. The results were as > expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created, respectively. > The last 3 tests generated warnings. > > > Thanks, > > Maged Michael > >
Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.
> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote: > > src/tests/disk_quota_tests.cpp, lines 132-133 > > <https://reviews.apache.org/r/41818/diff/4/?file=1195105#file1195105line132> > > > > Can you add a simple DiskUsageCollectorTest here to test the exclude > > path? `du` excludes symlinks anyway, so what exactly do we want to test here? - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/#review116224 --- On Jan. 26, 2016, 12:13 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41818/ > --- > > (Updated Jan. 26, 2016, 12:13 a.m.) > > > Review request for Artem Harutyunyan and Jie Yu. > > > Bugs: MESOS-4281 > https://issues.apache.org/jira/browse/MESOS-4281 > > > Repository: mesos > > > Description > --- > > Handled quota when volumes are bind mounted into the sandbox. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/posix/disk.hpp > 31808c1e8199fbf2cea36c273860fdbf0a2388f8 > src/slave/containerizer/mesos/isolators/posix/disk.cpp > 248c34adb63907911d89bed5b1519682a852bb2d > src/tests/containerizer/filesystem_isolator_tests.cpp > 5bb85034c22caef64054c1629f6fd55d227e48b1 > src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 > > Diff: https://reviews.apache.org/r/41818/diff/ > > > Testing > --- > > sudo mesos-tests.sh > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 26, 2016, 12:13 a.m.) Review request for Artem Harutyunyan and Jie Yu. Bugs: MESOS-4281 https://issues.apache.org/jira/browse/MESOS-4281 Repository: mesos Description --- Handled quota when volumes are bind mounted into the sandbox. Diffs (updated) - src/slave/containerizer/mesos/isolators/posix/disk.hpp 31808c1e8199fbf2cea36c273860fdbf0a2388f8 src/slave/containerizer/mesos/isolators/posix/disk.cpp 248c34adb63907911d89bed5b1519682a852bb2d src/tests/containerizer/filesystem_isolator_tests.cpp 5bb85034c22caef64054c1629f6fd55d227e48b1 src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 Diff: https://reviews.apache.org/r/41818/diff/ Testing --- sudo mesos-tests.sh Thanks, Artem Harutyunyan
Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.
> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 205
> > <https://reviews.apache.org/r/41818/diff/4/?file=1195103#file1195103line205>
> >
> > can you do the following?
> >
> > ```
> > info->paths[path].usage = collector.usage(
> > path,
> > (path == info->directory) ? excludes : {}));
> > ```
`{}` causes a compilation error, but I did re-introduce the ternary operator
back.
> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 388
> > <https://reviews.apache.org/r/41818/diff/4/?file=1195103#file1195103line388>
> >
> > Please put `{` in a new line.
The body of the constructor is empty again so `{}` will remain on the same line.
> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/posix/disk.cpp, lines 393-400
> > <https://reviews.apache.org/r/41818/diff/4/?file=1195103#file1195103line393>
> >
> > You can just do
> > ```
> > foreach (const string& exclude, excludes) {
> > argv.push_back("--exclude");
> > argv.push_back(exclude);
> > }
> > ```
Thanks! This looks much nicer.
> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 461
> > <https://reviews.apache.org/r/41818/diff/4/?file=1195103#file1195103line461>
> >
> > You can create the argv first based on 'path' and 'excludes' in Entry.
I am not sure I understand this one.
- Artem
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41818/#review116224
---
On Jan. 26, 2016, 12:13 a.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41818/
> ---
>
> (Updated Jan. 26, 2016, 12:13 a.m.)
>
>
> Review request for Artem Harutyunyan and Jie Yu.
>
>
> Bugs: MESOS-4281
> https://issues.apache.org/jira/browse/MESOS-4281
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Handled quota when volumes are bind mounted into the sandbox.
>
>
> Diffs
> -
>
> src/slave/containerizer/mesos/isolators/posix/disk.hpp
> 31808c1e8199fbf2cea36c273860fdbf0a2388f8
> src/slave/containerizer/mesos/isolators/posix/disk.cpp
> 248c34adb63907911d89bed5b1519682a852bb2d
> src/tests/containerizer/filesystem_isolator_tests.cpp
> 5bb85034c22caef64054c1629f6fd55d227e48b1
> src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97
>
> Diff: https://reviews.apache.org/r/41818/diff/
>
>
> Testing
> ---
>
> sudo mesos-tests.sh
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 26, 2016, 10:48 a.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Bugs: MESOS-4281 https://issues.apache.org/jira/browse/MESOS-4281 Repository: mesos Description --- Handled quota when volumes are bind mounted into the sandbox. Diffs (updated) - src/slave/containerizer/mesos/isolators/posix/disk.hpp 31808c1e8199fbf2cea36c273860fdbf0a2388f8 src/slave/containerizer/mesos/isolators/posix/disk.cpp 248c34adb63907911d89bed5b1519682a852bb2d src/tests/containerizer/filesystem_isolator_tests.cpp 5bb85034c22caef64054c1629f6fd55d227e48b1 src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 Diff: https://reviews.apache.org/r/41818/diff/ Testing --- sudo mesos-tests.sh Thanks, Artem Harutyunyan
Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.
> On Jan. 26, 2016, 12:26 p.m., Jie Yu wrote: > > src/tests/disk_quota_tests.cpp, lines 144-147 > > <https://reviews.apache.org/r/41818/diff/6/?file=1221677#file1221677line144> > > > > This should be wrapped with ifdef linux. I fixed it for you. Thanks Jie, there is a ticket to make sure we handle excludes correctly on Mac OS https://issues.apache.org/jira/browse/MESOS-4516. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/#review116424 --- On Jan. 26, 2016, 10:48 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41818/ > --- > > (Updated Jan. 26, 2016, 10:48 a.m.) > > > Review request for mesos, Artem Harutyunyan and Jie Yu. > > > Bugs: MESOS-4281 > https://issues.apache.org/jira/browse/MESOS-4281 > > > Repository: mesos > > > Description > --- > > Handled quota when volumes are bind mounted into the sandbox. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/posix/disk.hpp > 31808c1e8199fbf2cea36c273860fdbf0a2388f8 > src/slave/containerizer/mesos/isolators/posix/disk.cpp > 248c34adb63907911d89bed5b1519682a852bb2d > src/tests/containerizer/filesystem_isolator_tests.cpp > 5bb85034c22caef64054c1629f6fd55d227e48b1 > src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 > > Diff: https://reviews.apache.org/r/41818/diff/ > > > Testing > --- > > sudo mesos-tests.sh > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 42068: Porting Mesos on ppc64le.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42068/#review114910 --- We avoid making changes in 3rdparty and the Mesos code within the same patch. Could you please break this patch into 2? - Artem Harutyunyan On Jan. 8, 2016, 3:02 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42068/ > --- > > (Updated Jan. 8, 2016, 3:02 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-4312 > https://issues.apache.org/jira/browse/MESOS-4312 > > > Repository: mesos > > > Description > --- > > Porting Mesos on ppc64le. > > > Diffs > - > > 3rdparty/leveldb.patch ad8c19b9caa856ff85978ba832d48df11b3a83f0 > 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da > src/linux/fs.cpp bfcf97186cd1b0696a9537c4a332083def6b462e > > Diff: https://reviews.apache.org/r/42068/diff/ > > > Testing > --- > > make check (OSX 10.10.5, Ubuntu 14.04.3 LTS ppc64le) > > > Thanks, > > Qian Zhang > >
Re: Review Request 42274: Added common command utils file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42274/#review114510 --- src/common/command_utils.cpp (lines 136 - 149) <https://reviews.apache.org/r/42274/#comment175365> AFAIK tar should be able to detect compression format automatically http://linux.livejournal.com/1872012.html src/common/command_utils.cpp (lines 138 - 150) <https://reviews.apache.org/r/42274/#comment175364> AFAIK tar can autodetect compression format. http://linux.livejournal.com/1872012.html - Artem Harutyunyan On Jan. 13, 2016, 3:13 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42274/ > --- > > (Updated Jan. 13, 2016, 3:13 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > --- > > This common file is a good place to add common command line utilities like > tar, > digests(sha256, sha512, etc). Currently this functionality is spread in the > code > base and this change would enable all those call sites to be replaced with a > common code. > > > Diffs > - > > src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 > src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 > src/common/command_utils.hpp PRE-CREATION > src/common/command_utils.cpp PRE-CREATION > src/tests/common/command_utils_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/42274/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Jojy Varghese > >
Review Request 42312: Updated commiter affiliations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42312/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --- Updated commiter affiliations. Diffs - docs/committers.md 0302b5e0578bbf3c530deac0e0ccdcdaed073026 Diff: https://reviews.apache.org/r/42312/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41818: WIP: Handled quota when volumes are bind mounted into the sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 12, 2016, 1:48 p.m.) Review request for mesos and Artem Harutyunyan. Bugs: MESOS-4281 https://issues.apache.org/jira/browse/MESOS-4281 Repository: mesos Description (updated) --- Handled quota when volumes are bind mounted into the sandbox. Diffs (updated) - src/slave/containerizer/mesos/isolators/posix/disk.hpp 31808c1e8199fbf2cea36c273860fdbf0a2388f8 src/slave/containerizer/mesos/isolators/posix/disk.cpp 248c34adb63907911d89bed5b1519682a852bb2d src/tests/containerizer/filesystem_isolator_tests.cpp 5bb85034c22caef64054c1629f6fd55d227e48b1 src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 Diff: https://reviews.apache.org/r/41818/diff/ Testing --- The test for this is in the works. Thanks, Artem Harutyunyan
Re: Review Request 41818: WIP: Handled quota when volumes are bind mounted into the sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 12, 2016, 1:50 p.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Bugs: MESOS-4281 https://issues.apache.org/jira/browse/MESOS-4281 Repository: mesos Description --- Handled quota when volumes are bind mounted into the sandbox. Diffs - src/slave/containerizer/mesos/isolators/posix/disk.hpp 31808c1e8199fbf2cea36c273860fdbf0a2388f8 src/slave/containerizer/mesos/isolators/posix/disk.cpp 248c34adb63907911d89bed5b1519682a852bb2d src/tests/containerizer/filesystem_isolator_tests.cpp 5bb85034c22caef64054c1629f6fd55d227e48b1 src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 Diff: https://reviews.apache.org/r/41818/diff/ Testing (updated) --- sudo mesos-tests.sh Thanks, Artem Harutyunyan
Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 12, 2016, 3:48 p.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Summary (updated) - Handled quota when volumes are bind mounted into the sandbox. Bugs: MESOS-4281 https://issues.apache.org/jira/browse/MESOS-4281 Repository: mesos Description --- Handled quota when volumes are bind mounted into the sandbox. Diffs (updated) - src/slave/containerizer/mesos/isolators/posix/disk.hpp 31808c1e8199fbf2cea36c273860fdbf0a2388f8 src/slave/containerizer/mesos/isolators/posix/disk.cpp 248c34adb63907911d89bed5b1519682a852bb2d src/tests/containerizer/filesystem_isolator_tests.cpp 5bb85034c22caef64054c1629f6fd55d227e48b1 src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 Diff: https://reviews.apache.org/r/41818/diff/ Testing --- sudo mesos-tests.sh Thanks, Artem Harutyunyan
Re: Review Request 41818: WIP: Handled quota when volumes are bind mounted into the sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 7, 2016, 4 p.m.) Review request for mesos and Artem Harutyunyan. Bugs: MESOS-4281 https://issues.apache.org/jira/browse/MESOS-4281 Repository: mesos Description --- WIP: Handled quota when volumes are bind mounted into the sandbox. Diffs (updated) - src/slave/containerizer/mesos/isolators/posix/disk.hpp 31808c1e8199fbf2cea36c273860fdbf0a2388f8 src/slave/containerizer/mesos/isolators/posix/disk.cpp 248c34adb63907911d89bed5b1519682a852bb2d src/tests/containerizer/filesystem_isolator_tests.cpp 5bb85034c22caef64054c1629f6fd55d227e48b1 src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 Diff: https://reviews.apache.org/r/41818/diff/ Testing --- The test for this is in the works. Thanks, Artem Harutyunyan
Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/ --- (Updated Jan. 4, 2016, 8:57 a.m.) Review request for mesos and Jie Yu. Bugs: MESOS-4198 https://issues.apache.org/jira/browse/MESOS-4198 Repository: mesos Description --- Added support for enforcing quota on (persistent) volumes (MESOS-4198). Diffs (updated) - src/slave/containerizer/mesos/isolators/posix/disk.cpp d971db09083faad08f3cf18c25a79245321d1d9a src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d Diff: https://reviews.apache.org/r/41705/diff/ Testing --- GTEST_FILTER='DiskQuotaTest*' make check -j8 Thanks, Artem Harutyunyan
Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).
> On Dec. 25, 2015, 9:37 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 171 > > <https://reviews.apache.org/r/41705/diff/1/?file=1176049#file1176049line171> > > > > Should we simply use `!Resources::isPersistentVolume()` here? A disk volume resource does not necessarily have to be a persistent volume. So there might be cases when a task just requires a non-persistent disk volume. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/#review111902 --- On Dec. 28, 2015, 11:36 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41705/ > --- > > (Updated Dec. 28, 2015, 11:36 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4198 > https://issues.apache.org/jira/browse/MESOS-4198 > > > Repository: mesos > > > Description > --- > > Added support for enforcing quota on (persistent) volumes (MESOS-4198). > > > Diffs > - > > src/slave/containerizer/mesos/isolators/posix/disk.cpp > d971db09083faad08f3cf18c25a79245321d1d9a > src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d > > Diff: https://reviews.apache.org/r/41705/diff/ > > > Testing > --- > > GTEST_FILTER='DiskQuotaTest*' make check -j8 > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 41586: Partially enforced commit message guidelines with a hook.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/ --- (Updated Dec. 30, 2015, 11:28 a.m.) Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway. Repository: mesos Description --- Partially enforced commit message guidelines with a hook. Diffs (updated) - bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 support/hooks/commit-msg PRE-CREATION Diff: https://reviews.apache.org/r/41586/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).
> On Dec. 30, 2015, 11:55 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 301 > > <https://reviews.apache.org/r/41705/diff/1/?file=1176049#file1176049line301> > > > > We may want to report volume usage through ResourceStatistics. This can > > be a separate ticket. https://issues.apache.org/jira/browse/MESOS-4263 - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/#review112343 --- On Dec. 30, 2015, 4:01 p.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41705/ > --- > > (Updated Dec. 30, 2015, 4:01 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4198 > https://issues.apache.org/jira/browse/MESOS-4198 > > > Repository: mesos > > > Description > --- > > Added support for enforcing quota on (persistent) volumes (MESOS-4198). > > > Diffs > - > > src/slave/containerizer/mesos/isolators/posix/disk.cpp > d971db09083faad08f3cf18c25a79245321d1d9a > src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d > > Diff: https://reviews.apache.org/r/41705/diff/ > > > Testing > --- > > GTEST_FILTER='DiskQuotaTest*' make check -j8 > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/ --- (Updated Dec. 30, 2015, 4:01 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-4198 https://issues.apache.org/jira/browse/MESOS-4198 Repository: mesos Description --- Added support for enforcing quota on (persistent) volumes (MESOS-4198). Diffs (updated) - src/slave/containerizer/mesos/isolators/posix/disk.cpp d971db09083faad08f3cf18c25a79245321d1d9a src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d Diff: https://reviews.apache.org/r/41705/diff/ Testing --- GTEST_FILTER='DiskQuotaTest*' make check -j8 Thanks, Artem Harutyunyan
Re: Review Request 41704: Added support for checking whether a given path is absolute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41704/ --- (Updated Dec. 30, 2015, 3:46 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-4198 https://issues.apache.org/jira/browse/MESOS-4198 Repository: mesos Description --- Added support for checking whether a given path is absolute. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 386188b26dd157a72aefdbff57da7d479f6637b4 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 4374e64b499db3e47f62f562cb51b0640144ec6a Diff: https://reviews.apache.org/r/41704/diff/ Testing --- Ran stout tests. Thanks, Artem Harutyunyan
Re: Review Request 41704: Added support for checking whether a given path is absolute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41704/ --- (Updated Dec. 30, 2015, 9:46 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-4198 https://issues.apache.org/jira/browse/MESOS-4198 Repository: mesos Description --- Added support for checking whether a given path is absolute. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 386188b26dd157a72aefdbff57da7d479f6637b4 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 4374e64b499db3e47f62f562cb51b0640144ec6a Diff: https://reviews.apache.org/r/41704/diff/ Testing --- Ran stout tests. Thanks, Artem Harutyunyan
Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/ --- (Updated Dec. 28, 2015, 11:36 a.m.) Review request for mesos and Jie Yu. Summary (updated) - Added support for enforcing quota on (persistent) volumes (MESOS-4198). Bugs: MESOS-4198 https://issues.apache.org/jira/browse/MESOS-4198 Repository: mesos Description --- Added support for enforcing quota on (persistent) volumes (MESOS-4198). Diffs - src/slave/containerizer/mesos/isolators/posix/disk.cpp d971db09083faad08f3cf18c25a79245321d1d9a src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d Diff: https://reviews.apache.org/r/41705/diff/ Testing --- GTEST_FILTER='DiskQuotaTest*' make check -j8 Thanks, Artem Harutyunyan
Re: Review Request 41704: Added support for checking whether a given path is absolute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41704/ --- (Updated Dec. 28, 2015, 11:35 a.m.) Review request for mesos and Jie Yu. Summary (updated) - Added support for checking whether a given path is absolute. Bugs: MESOS-4198 https://issues.apache.org/jira/browse/MESOS-4198 Repository: mesos Description --- Added support for checking whether a given path is absolute. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 0b986f0898da95c4cffd8bde1adfd9994d567096 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 821dbb185f09e2f279d95fd354ce2168cddf1bac Diff: https://reviews.apache.org/r/41704/diff/ Testing --- Ran stout tests. Thanks, Artem Harutyunyan
Re: Review Request 41704: WIP: Added support for checking whether a given path is absolute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41704/ --- (Updated Dec. 25, 2015, 6:13 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-4198 https://issues.apache.org/jira/browse/MESOS-4198 Repository: mesos Description (updated) --- Added support for checking whether a given path is absolute. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 0b986f0898da95c4cffd8bde1adfd9994d567096 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 821dbb185f09e2f279d95fd354ce2168cddf1bac Diff: https://reviews.apache.org/r/41704/diff/ Testing --- Ran stout tests. Thanks, Artem Harutyunyan
Re: Review Request 41705: WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/ --- (Updated Dec. 25, 2015, 6:15 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-4198 https://issues.apache.org/jira/browse/MESOS-4198 Repository: mesos Description (updated) --- Added support for enforcing quota on (persistent) volumes (MESOS-4198). Diffs - src/slave/containerizer/mesos/isolators/posix/disk.cpp d971db09083faad08f3cf18c25a79245321d1d9a src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d Diff: https://reviews.apache.org/r/41705/diff/ Testing --- GTEST_FILTER='DiskQuotaTest*' make check -j8 Thanks, Artem Harutyunyan
Re: Review Request 41586: Partially enforced commit message guidelines with a hook.
> On Dec. 24, 2015, 2:27 a.m., Adam B wrote: > > bootstrap, lines 22-23 > > <https://reviews.apache.org/r/41586/diff/1/?file=1172700#file1172700line22> > > > > Our general policy in C++ variable names is to avoid abbreviations, and > > I imagine that could apply to shell scripts too. > > Please s/msg/message/ That's a standard git hook file name. https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks > On Dec. 24, 2015, 2:27 a.m., Adam B wrote: > > support/hooks/commit-msg, line 3 > > <https://reviews.apache.org/r/41586/diff/1/?file=1172701#file1172701line3> > > > > "A hook script to verify commit message format. Called by..." so that > > the first sentence explains what the script does, rather than how it's > > called. Actually that comment came with the template hook file (.git/hooks/commit-msg.sample). > On Dec. 24, 2015, 2:27 a.m., Adam B wrote: > > support/hooks/commit-msg, line 4 > > <https://reviews.apache.org/r/41586/diff/1/?file=1172701#file1172701line4> > > > > "should"? Are you unsure if it will? I believe that the `if it wants to stop the commit` part of the sentence makes it pretty explicit, no? Again, this comment is part of the template hook file. If you have a suggestion on how to rewrite it I'll gladly follow it :-). > On Dec. 24, 2015, 2:27 a.m., Adam B wrote: > > support/hooks/commit-msg, lines 6-7 > > <https://reviews.apache.org/r/41586/diff/1/?file=1172701#file1172701line6> > > > > # To enable this hook, do this from the root of the repo: > > # > > # $ ln -s ../../support/hooks/commit-message .git/hooks/commit-message In our case it's done automatically by the bootstrap script. It's part of this same commit. Added a clarifying comment. > On Dec. 24, 2015, 2:27 a.m., Adam B wrote: > > support/hooks/commit-msg, line 19 > > <https://reviews.apache.org/r/41586/diff/1/?file=1172701#file1172701line19> > > > > None of the lines should exceed 72 chars, and the first line should > > ideally be even less (~50). Ideally this hook would error for a too-long > > summary line, and wrap the description. Makes sense. Added a JIRA https://issues.apache.org/jira/browse/MESOS-4250 to follow up. - Artem ----------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/#review111839 --- On Dec. 25, 2015, 6:05 p.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41586/ > --- > > (Updated Dec. 25, 2015, 6:05 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway. > > > Repository: mesos > > > Description > --- > > Partially enforced commit message guidelines with a hook. > > > Diffs > - > > bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 > support/hooks/commit-msg PRE-CREATION > > Diff: https://reviews.apache.org/r/41586/diff/ > > > Testing > --- > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 41584: Added commit message guidelines to docs.
> On Dec. 19, 2015, 6:34 a.m., Till Toenshoff wrote: > > docs/submitting-a-patch.md, line 52 > > <https://reviews.apache.org/r/41584/diff/1/?file=1172697#file1172697line52> > > > > We actually do it a bit more differentiated. > > > > The `Summary` should be past tense, start with a capital letter and end > > in a period. > > > > The `Description` should be present or continouus. It describes the > > changes and may also contain a short reasoning for them. > > > > The `Testing done` should state all steps you did for validating your > > RR. > > Adam B wrote: > I would further venture to say that the first sentence should ideally be > 50chars or less, but we will allow up to 72 if needed to get the point across. > The rest of the Description should be wrapped at 72chars, but I usually > do that manually when committing. > I've never really payed attention to the tense in the Description, mostly > just making sure the summary is past tense. > I'd also like to point out that the Testing Done section is not included > in the commit message, so contributors are welcome to put additional notes to > reviewers there (or in a self-review). Created a JIRA (https://issues.apache.org/jira/browse/MESOS-4250) to follow up with enforcing the description line lengths at 72 chars. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41584/#review111372 --- On Dec. 19, 2015, 12:18 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41584/ > --- > > (Updated Dec. 19, 2015, 12:18 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway. > > > Repository: mesos > > > Description > --- > > Added commit message guidelines to docs. > > > Diffs > - > > docs/submitting-a-patch.md f0048f51395422645a520b61815c1ae3c7004aa3 > > Diff: https://reviews.apache.org/r/41584/diff/ > > > Testing > --- > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 41586: Partially enforced commit message guidelines with a hook.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/ --- (Updated Dec. 25, 2015, 6:05 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway. Repository: mesos Description --- Partially enforced commit message guidelines with a hook. Diffs (updated) - bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 support/hooks/commit-msg PRE-CREATION Diff: https://reviews.apache.org/r/41586/diff/ Testing --- Thanks, Artem Harutyunyan
Review Request 41706: Added Qunar to Powered by Mesos page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41706/ --- Review request for mesos, Adam B and Joris Van Remoortere. Repository: mesos Description --- https://github.com/apache/mesos/pull/83 Diffs - docs/powered-by-mesos.md bbcac44570506b7e2bdd06ac0ab2204b0417314e Diff: https://reviews.apache.org/r/41706/diff/ Testing --- Thanks, Artem Harutyunyan
Review Request 41704: WIP: Added support for checking whether a given path is absolute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41704/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4198 https://issues.apache.org/jira/browse/MESOS-4198 Repository: mesos Description --- WIP: Added support for checking whether a given path is absolute. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 0b986f0898da95c4cffd8bde1adfd9994d567096 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 821dbb185f09e2f279d95fd354ce2168cddf1bac Diff: https://reviews.apache.org/r/41704/diff/ Testing --- Ran stout tests. Thanks, Artem Harutyunyan
Review Request 41705: WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4198 https://issues.apache.org/jira/browse/MESOS-4198 Repository: mesos Description --- WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198). Diffs - src/slave/containerizer/mesos/isolators/posix/disk.cpp d971db09083faad08f3cf18c25a79245321d1d9a src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d Diff: https://reviews.apache.org/r/41705/diff/ Testing --- GTEST_FILTER='DiskQuotaTest*' make check -j8 Thanks, Artem Harutyunyan
Review Request 41584: Added commit message guidelines to docs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41584/ --- Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway. Repository: mesos Description --- Added commit message guidelines to docs. Diffs - docs/submitting-a-patch.md f0048f51395422645a520b61815c1ae3c7004aa3 Diff: https://reviews.apache.org/r/41584/diff/ Testing --- Thanks, Artem Harutyunyan
Review Request 41586: Partially enforced commit message guidelines with a hook.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/ --- Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway. Repository: mesos Description --- Partially enforced commit message guidelines with a hook. Diffs - bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 support/hooks/commit-msg PRE-CREATION Diff: https://reviews.apache.org/r/41586/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41420/ --- (Updated Dec. 18, 2015, 11:29 a.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Bugs: MESOS-4064 https://issues.apache.org/jira/browse/MESOS-4064 Repository: mesos Description --- Added ContainerInfo to internal Task protobuf. Diffs (updated) - src/messages/messages.proto b66bac14056407140bb3cf5aa3e67ac94df1a2f8 Diff: https://reviews.apache.org/r/41420/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41426: Changed MergeFrom() to CopyFrom() in protobuf::createTask().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41426/ --- (Updated Dec. 18, 2015, 3:12 p.m.) Review request for mesos and Artem Harutyunyan. Bugs: MESOS-4064 https://issues.apache.org/jira/browse/MESOS-4064 Repository: mesos Description --- Changed MergeFrom() to CopyFrom() in protobuf::createTask(). Diffs (updated) - src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 Diff: https://reviews.apache.org/r/41426/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 3:12 p.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Bugs: MESOS-4064 https://issues.apache.org/jira/browse/MESOS-4064 Repository: mesos Description --- Exposed partial contents of ContainerInfo through the state endpoint. Diffs (updated) - src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41423/diff/ Testing --- make check Thanks, Artem Harutyunyan
Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41420/ --- (Updated Dec. 18, 2015, 3:48 p.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Bugs: MESOS-4064 https://issues.apache.org/jira/browse/MESOS-4064 Repository: mesos Description --- Added ContainerInfo to internal Task protobuf. Diffs (updated) - src/messages/messages.proto b66bac14056407140bb3cf5aa3e67ac94df1a2f8 Diff: https://reviews.apache.org/r/41420/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41422: Removed manual construction of Task in master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41422/ --- (Updated Dec. 18, 2015, 3:49 p.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Bugs: MESOS-4064 https://issues.apache.org/jira/browse/MESOS-4064 Repository: mesos Description --- Removed manual construction of Task in master. Diffs (updated) - src/master/master.cpp 470b542729b01f41fc6a2e601a7a6c3d0c5353d5 Diff: https://reviews.apache.org/r/41422/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41571: Removed deprecated code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41571/ --- (Updated Dec. 18, 2015, 3:58 p.m.) Review request for mesos and Jie Yu. Repository: mesos Description --- Removed deprecated code. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41571/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41426: Changed MergeFrom() to CopyFrom() in protobuf::createTask().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41426/ --- (Updated Dec. 18, 2015, 3:58 p.m.) Review request for mesos and Artem Harutyunyan. Bugs: MESOS-4064 https://issues.apache.org/jira/browse/MESOS-4064 Repository: mesos Description --- Changed MergeFrom() to CopyFrom() in protobuf::createTask(). Diffs (updated) - src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 Diff: https://reviews.apache.org/r/41426/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 3:58 p.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Bugs: MESOS-4064 https://issues.apache.org/jira/browse/MESOS-4064 Repository: mesos Description --- Exposed partial contents of ContainerInfo through the state endpoint. Diffs (updated) - src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41423/diff/ Testing --- make check Thanks, Artem Harutyunyan
Re: Review Request 41571: Removed deprecated code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41571/ --- (Updated Dec. 18, 2015, 3:13 p.m.) Review request for mesos and Jie Yu. Repository: mesos Description --- Removed deprecated code. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41571/diff/ Testing --- Thanks, Artem Harutyunyan
Review Request 41571: Removed deprecated code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41571/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- Removed deprecated code. Diffs - src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41571/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.
> On Dec. 18, 2015, 10:35 a.m., Jie Yu wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, lines 506-510 > > <https://reviews.apache.org/r/41423/diff/3/?file=1170220#file1170220line506> > > > > Maybe remove this in a followup patch? Thanks for spotting it, Jie! https://reviews.apache.org/r/41571/ - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/#review111221 --- On Dec. 18, 2015, 2:45 p.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41423/ > --- > > (Updated Dec. 18, 2015, 2:45 p.m.) > > > Review request for mesos, Artem Harutyunyan and Jie Yu. > > > Bugs: MESOS-4064 > https://issues.apache.org/jira/browse/MESOS-4064 > > > Repository: mesos > > > Description > --- > > Exposed partial contents of ContainerInfo through the state endpoint. > > > Diffs > - > > src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 > src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 > src/tests/containerizer/docker_containerizer_tests.cpp > 3f199e622dd337cdbf32d4368f4ead424c39823c > > Diff: https://reviews.apache.org/r/41423/diff/ > > > Testing > --- > > make check > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 2:45 p.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Bugs: MESOS-4064 https://issues.apache.org/jira/browse/MESOS-4064 Repository: mesos Description --- Exposed partial contents of ContainerInfo through the state endpoint. Diffs (updated) - src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41423/diff/ Testing --- make check Thanks, Artem Harutyunyan
Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/#review111362 --- src/tests/common/http_tests.cpp (line 101) <https://reviews.apache.org/r/41381/#comment171524> Since Task instances are exported through state endpoints on both the slave and the master you might as well query those to actually verify that DiscoverInfo is always available to consumers. See, please https://github.com/apache/mesos/blob/master/src/tests/health_check_tests.cpp#L254-L278 for an example. src/tests/slave_tests.cpp (lines 2242 - 2246) <https://reviews.apache.org/r/41381/#comment171522> How about using EXPECT_SOME_EQ here? src/tests/slave_tests.cpp (lines 2253 - 2257) <https://reviews.apache.org/r/41381/#comment171523> Ditto as above. But please submit a follow up patch if you decide to switch these (and possible other) occurences as well. - Artem Harutyunyan On Dec. 17, 2015, 3:15 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41381/ > --- > > (Updated Dec. 17, 2015, 3:15 p.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Repository: mesos > > > Description > --- > > Added unit test cases to test the new vip and instance_port fields > > > Diffs > - > > src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 > src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 > > Diff: https://reviews.apache.org/r/41381/diff/ > > > Testing > --- > > make check > > > Thanks, > > Avinash sridharan > >
Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port
> On Dec. 17, 2015, 5:40 p.m., Adam B wrote: > > Let's get rid of the Vips message per MPark's recommendation, since we're > > unlikely to ever add any more fields to that message. Could you please also clean the `Depends On` field for this review? - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review02 --- On Dec. 17, 2015, 2:41 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41380/ > --- > > (Updated Dec. 17, 2015, 2:41 p.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Bugs: MESOS-4114 > https://issues.apache.org/jira/browse/MESOS-4114 > > > Repository: mesos > > > Description > --- > > Added repeated vip field to DiscoveryInfo and an instance_port field to Port > > > Diffs > - > > include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 > include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 > > Diff: https://reviews.apache.org/r/41380/diff/ > > > Testing > --- > > make check, and make > > > Thanks, > > Avinash sridharan > >
Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41420/ --- (Updated Dec. 17, 2015, 9:39 a.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Repository: mesos Description --- Added ContainerInfo to internal Task protobuf. Diffs - src/messages/messages.proto b66bac14056407140bb3cf5aa3e67ac94df1a2f8 Diff: https://reviews.apache.org/r/41420/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41421/ --- (Updated Dec. 17, 2015, 9:39 a.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Repository: mesos Description --- Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf. Diffs - src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 Diff: https://reviews.apache.org/r/41421/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41422: Removed manual construction of Task in master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41422/ --- (Updated Dec. 17, 2015, 9:40 a.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Repository: mesos Description --- Removed manual construction of Task in master. Diffs - src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4 Diff: https://reviews.apache.org/r/41422/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41421/ --- (Updated Dec. 17, 2015, 10:26 a.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Repository: mesos Description --- Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf. Diffs (updated) - src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 Diff: https://reviews.apache.org/r/41421/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 17, 2015, 11:57 a.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Repository: mesos Description --- Exposed partial contents of ContainerInfo through the state endpoint. Diffs (updated) - src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41423/diff/ Testing --- make check Thanks, Artem Harutyunyan
Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41421/ --- (Updated Dec. 17, 2015, 11:59 a.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Bugs: MESOS-4064 https://issues.apache.org/jira/browse/MESOS-4064 Repository: mesos Description --- Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf. Diffs - src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 Diff: https://reviews.apache.org/r/41421/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41422: Removed manual construction of Task in master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41422/ --- (Updated Dec. 17, 2015, 11:58 a.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Bugs: MESOS-4064 https://issues.apache.org/jira/browse/MESOS-4064 Repository: mesos Description --- Removed manual construction of Task in master. Diffs - src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4 Diff: https://reviews.apache.org/r/41422/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 17, 2015, 11:58 a.m.) Review request for mesos, Artem Harutyunyan and Jie Yu. Bugs: MESOS-4064 https://issues.apache.org/jira/browse/MESOS-4064 Repository: mesos Description --- Exposed partial contents of ContainerInfo through the state endpoint. Diffs - src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41423/diff/ Testing --- make check Thanks, Artem Harutyunyan
Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 16, 2015, 6:03 p.m.) Review request for mesos and Artem Harutyunyan. Changes --- Added tests. Repository: mesos Description --- Exposed partial contents of ContainerInfo through the state endpoint. Diffs (updated) - src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41423/diff/ Testing (updated) --- make check Thanks, Artem Harutyunyan
Re: Review Request 39410: Added support for github to apply-reviews.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Dec. 10, 2015, 1:35 p.m.) Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone. Changes --- Renamed variables to be more consistent. Bugs: MESOS-3859 https://issues.apache.org/jira/browse/MESOS-3859 Repository: mesos Description --- Added support for github to apply-reviews.py. Diffs (updated) - support/apply-reviews.py 6ea229facebf6ee071c0d0186fd1f702e0c48a39 Diff: https://reviews.apache.org/r/39410/diff/ Testing --- Tested with python 2.7 Thanks, Artem Harutyunyan
Re: Review Request 39410: Added support for github to apply-reviews.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Dec. 10, 2015, 1:42 p.m.) Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone. Changes --- Fixed a typo. Bugs: MESOS-3859 https://issues.apache.org/jira/browse/MESOS-3859 Repository: mesos Description --- Added support for github to apply-reviews.py. Diffs (updated) - support/apply-reviews.py 6ea229facebf6ee071c0d0186fd1f702e0c48a39 Diff: https://reviews.apache.org/r/39410/diff/ Testing --- Tested with python 2.7 Thanks, Artem Harutyunyan
Re: Review Request 41178: Fixed a message dropping bug in the health checker.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41178/#review109668 --- Ship it! Ship It! - Artem Harutyunyan On Dec. 9, 2015, 6:01 p.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41178/ > --- > > (Updated Dec. 9, 2015, 6:01 p.m.) > > > Review request for mesos, Artem Harutyunyan and Timothy Chen. > > > Bugs: MESOS-1613 and MESOS-4106 > https://issues.apache.org/jira/browse/MESOS-1613 > https://issues.apache.org/jira/browse/MESOS-4106 > > > Repository: mesos > > > Description > --- > > Much like in the command executor, we need to sleep after we send > the final message in the health checker. Otherwise, we may exit > before libprocess is able to finish sending the message over the > local network. > > This led to the following issues: > https://issues.apache.org/jira/browse/MESOS-1613 > https://issues.apache.org/jira/browse/MESOS-4106 > > > Diffs > - > > src/health-check/main.cpp 83ee38cd853325b3adc7cb6bc2d1d67b343037f5 > src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02 > > Diff: https://reviews.apache.org/r/41178/diff/ > > > Testing > --- > > Running the `HealthCheckTest.DISABLED_ConsecutiveFailures` test in repetition > on a machine loaded with many `openssl speed` commands in the background > reproduces the flakiness. After this patch it is no longer flaky in this > setup. > > > Thanks, > > Ben Mahler > >
Review Request 41182: Exposed task health flag through the state endpoint on master and slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41182/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4015 https://issues.apache.org/jira/browse/MESOS-4015 Repository: mesos Description --- Exposed task health flag through the state endpoint on master and slave. Diffs - src/common/http.cpp 586d1c833513836ae0d4041c9f94c6332b25fdd5 src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02 Diff: https://reviews.apache.org/r/41182/diff/ Testing --- make check Thanks, Artem Harutyunyan
Re: Review Request 40241: Fixed a bug with hanging editor reported by Ben Mahler.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40241/ --- (Updated Nov. 14, 2015, 8:55 a.m.) Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone. Changes --- Addressed comments and fixed errors. Repository: mesos Description (updated) --- `subprocess.check_output()` used pipes to capture STDOUT and STDERR. Because of this certain editors (such as vi) would hang when invoked during git commit. To mitigate that I switched to `subprocess.call()` and did some code refactoring to accomodate that change. Diffs (updated) - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/40241/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 39410: Added support for github to apply-reviews.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 14, 2015, 9:02 a.m.) Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone. Changes --- Addressed comments, fixed commit options. Bugs: MESOS-3859 https://issues.apache.org/jira/browse/MESOS-3859 Repository: mesos Description --- Added support for github to apply-reviews.py. Diffs (updated) - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/39410/diff/ Testing --- Tested with python 2.7 Thanks, Artem Harutyunyan
Re: Review Request 39410: Added support for github to apply-reviews.py.
> On Nov. 10, 2015, 12:18 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 192 > > <https://reviews.apache.org/r/39410/diff/13-14/?file=1119828#file1119828line192> > > > > s/-e/--amend/ ? Turns out `--amend` is very different from `-e`. `--amend` causes all commits in the branch to be squashed together into one. Excerpt from the man page (https://git-scm.com/docs/git-commit): ``` ... It is a rough equivalent for: $ git reset --soft HEAD^ $ ... do something else to come up with the right tree ... $ git commit -c ORIG_HEAD ``` - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review105939 --- On Nov. 12, 2015, 10:03 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39410/ > --- > > (Updated Nov. 12, 2015, 10:03 a.m.) > > > Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco > Massenzio, and Vinod Kone. > > > Bugs: MESOS-3859 > https://issues.apache.org/jira/browse/MESOS-3859 > > > Repository: mesos > > > Description > --- > > Added support for github to apply-reviews.py. > > > Diffs > - > > support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 > > Diff: https://reviews.apache.org/r/39410/diff/ > > > Testing > --- > > Tested with python 2.7 > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 40225: Fixed the Review Board URL in the commit message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40225/ --- (Updated Nov. 14, 2015, 9:08 a.m.) Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone. Summary (updated) - Fixed the Review Board URL in the commit message. Repository: mesos Description --- Adjusted Review Board URL in comment. Diffs - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/40225/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 39420: Added '--chain' option to apply-reviews.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 14, 2015, 9:04 a.m.) Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone. Bugs: MESOS-3859 https://issues.apache.org/jira/browse/MESOS-3859 Repository: mesos Description --- Added '--chain' option to apply-reviews.py. Diffs (updated) - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/39420/diff/ Testing --- Tested with python 2.7. - With and without '-c'. - Tested reviews with and without parents. Thanks, Artem Harutyunyan
Re: Review Request 40241: Fixed apply-reviews.py to prevent git commit editors from hanging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40241/ --- (Updated Nov. 14, 2015, 9:07 a.m.) Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone. Summary (updated) - Fixed apply-reviews.py to prevent git commit editors from hanging. Repository: mesos Description --- `subprocess.check_output()` used pipes to capture STDOUT and STDERR. Because of this certain editors (such as vi) would hang when invoked during git commit. To mitigate that I switched to `subprocess.call()` and did some code refactoring to accomodate that change. Diffs - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/40241/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40225/ --- (Updated Nov. 12, 2015, 2:57 a.m.) Review request for mesos, Ben Mahler, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- Fixed a bug with hanging editor reported by Ben Mahler and adjusted Review Board URL in comment. Diffs - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/40225/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 39410: Added support for github to apply-reviews.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 12, 2015, 2:51 a.m.) Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone. Changes --- Rebased. Bugs: MESOS-3859 https://issues.apache.org/jira/browse/MESOS-3859 Repository: mesos Description --- Added support for github to apply-reviews.py. Diffs (updated) - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/39410/diff/ Testing --- Tested with python 2.7 Thanks, Artem Harutyunyan
Re: Review Request 39420: Added '--chain' option to apply-reviews.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 12, 2015, 2:52 a.m.) Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone. Changes --- Rebased. Bugs: MESOS-3859 https://issues.apache.org/jira/browse/MESOS-3859 Repository: mesos Description --- Added '--chain' option to apply-reviews.py. Diffs (updated) - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/39420/diff/ Testing --- Tested with python 2.7. - With and without '-c'. - Tested reviews with and without parents. Thanks, Artem Harutyunyan
Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40129/ --- (Updated Nov. 12, 2015, 2:54 a.m.) Review request for mesos, Joris Van Remoortere and Vinod Kone. Changes --- Rebased. Bugs: MESOS-3868 https://issues.apache.org/jira/browse/MESOS-3868 Repository: mesos Description --- Updated apply-review.sh to use apply-reviews.py. Diffs (updated) - support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 Diff: https://reviews.apache.org/r/40129/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.
> On Nov. 11, 2015, 5:56 a.m., Ben Mahler wrote: > > support/apply-reviews.py, lines 158-164 > > <https://reviews.apache.org/r/38883/diff/16/?file=1119827#file1119827line158> > > > > The url added to the message here doesn't match the existing format > > used by apply-review.sh: > > > > ``` > > Review: https://reviews.apache.org/api/review-requests/38876/ > > ``` > > > > vs the expected: > > > > ``` > > Review: https://reviews.apache.org/r/38876 > > ``` Fixed in https://reviews.apache.org/r/40225/. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review106053 --- On Nov. 9, 2015, 6:18 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38883/ > --- > > (Updated Nov. 9, 2015, 6:18 a.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, > and Vinod Kone. > > > Bugs: MESOS-3468 > https://issues.apache.org/jira/browse/MESOS-3468 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > support/apply-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/38883/diff/ > > > Testing > --- > > Tested the script with python 2.7. > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40225/ --- (Updated Nov. 12, 2015, 11:12 a.m.) Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone. Changes --- Addressed comment. Repository: mesos Description --- Adjusted Review Board URL in comment. Diffs (updated) - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/40225/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 39410: Added support for github to apply-reviews.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 12, 2015, 10:03 a.m.) Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone. Bugs: MESOS-3859 https://issues.apache.org/jira/browse/MESOS-3859 Repository: mesos Description --- Added support for github to apply-reviews.py. Diffs (updated) - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/39410/diff/ Testing --- Tested with python 2.7 Thanks, Artem Harutyunyan
Re: Review Request 39420: Added '--chain' option to apply-reviews.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 12, 2015, 10:04 a.m.) Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone. Bugs: MESOS-3859 https://issues.apache.org/jira/browse/MESOS-3859 Repository: mesos Description --- Added '--chain' option to apply-reviews.py. Diffs (updated) - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/39420/diff/ Testing --- Tested with python 2.7. - With and without '-c'. - Tested reviews with and without parents. Thanks, Artem Harutyunyan
Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().
> On Nov. 12, 2015, 10 a.m., Vinod Kone wrote: > > support/apply-reviews.py, line 23 > > <https://reviews.apache.org/r/40225/diff/2/?file=1124332#file1124332line23> > > > > s/ui_// > > > > What's a UI URL? BenM noticed that instead of putting the Review Board UI URL in the commit message (as in https://reviews.apache.org/r/40225/) we had a Review Board API URL there (as in https://reviews.apache.org/api/review-requests/40225/). - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40225/#review106276 ------- On Nov. 12, 2015, 9:56 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40225/ > --- > > (Updated Nov. 12, 2015, 9:56 a.m.) > > > Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and > Vinod Kone. > > > Repository: mesos > > > Description > --- > > Adjusted Review Board URL in comment. > > > Diffs > - > > support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 > > Diff: https://reviews.apache.org/r/40225/diff/ > > > Testing > --- > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().
> On Nov. 12, 2015, 10 a.m., Vinod Kone wrote: > > support/apply-reviews.py, line 23 > > <https://reviews.apache.org/r/40225/diff/2/?file=1124332#file1124332line23> > > > > s/ui_// > > > > What's a UI URL? > > Artem Harutyunyan wrote: > BenM noticed that instead of putting the Review Board UI URL in the > commit message (as in https://reviews.apache.org/r/40225/) we had a Review > Board API URL there (as in > https://reviews.apache.org/api/review-requests/40225/). RB mangled the second link, it should be https://reviews.apache.org/api/review-requests/40225/ Do you have a suggestion for a better name? - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40225/#review106276 ------- On Nov. 12, 2015, 9:56 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40225/ > --- > > (Updated Nov. 12, 2015, 9:56 a.m.) > > > Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and > Vinod Kone. > > > Repository: mesos > > > Description > --- > > Adjusted Review Board URL in comment. > > > Diffs > - > > support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 > > Diff: https://reviews.apache.org/r/40225/diff/ > > > Testing > --- > > > Thanks, > > Artem Harutyunyan > >
Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40129/ --- (Updated Nov. 12, 2015, 10:04 a.m.) Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs: MESOS-3868 https://issues.apache.org/jira/browse/MESOS-3868 Repository: mesos Description --- Updated apply-review.sh to use apply-reviews.py. Diffs (updated) - support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 Diff: https://reviews.apache.org/r/40129/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40225/ --- (Updated Nov. 12, 2015, 9:56 a.m.) Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone. Changes --- Splitting the commit into two following Ben Mahler's suggestion. Repository: mesos Description (updated) --- Adjusted Review Board URL in comment. Diffs (updated) - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/40225/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 40241: Fixed a bug with hanging editor reported by Ben Mahler.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40241/ --- (Updated Nov. 12, 2015, 10:10 a.m.) Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone. Repository: mesos Description --- Fixed a bug with hanging editor reported by Ben Mahler. Diffs - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/40241/diff/ Testing --- Thanks, Artem Harutyunyan
Re: Review Request 39410: Added support for github to apply-reviews.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 11, 2015, 2:10 a.m.) Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone. Bugs: MESOS-3859 https://issues.apache.org/jira/browse/MESOS-3859 Repository: mesos Description --- Added support for github to apply-reviews.py. Diffs (updated) - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/39410/diff/ Testing --- Tested with python 2.7 Thanks, Artem Harutyunyan
Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.
> On Nov. 10, 2015, 12:23 p.m., Vinod Kone wrote: > > support/apply-review.sh, line 5 > > <https://reviews.apache.org/r/40129/diff/1/?file=1121350#file1121350line5> > > > > do we even need this script anymore? is this for backwards compatiblity > > with existing tooling? is that plan to kill this eventually? worth adding > > some comments/TODO/JIRA for this. Here is the JIRA https://issues.apache.org/jira/browse/MESOS-3885. `verify_reviews.py` still references apply-review.sh. We should probably give a notice on dev@ list before removing the script. What do you think? - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40129/#review105943 ------- On Nov. 10, 2015, 12:02 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40129/ > --- > > (Updated Nov. 10, 2015, 12:02 a.m.) > > > Review request for mesos, Joris Van Remoortere and Vinod Kone. > > > Bugs: MESOS-3868 > https://issues.apache.org/jira/browse/MESOS-3868 > > > Repository: mesos > > > Description > --- > > Updated apply-review.sh to use apply-reviews.py. > > > Diffs > - > > support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 > > Diff: https://reviews.apache.org/r/40129/diff/ > > > Testing > --- > > > Thanks, > > Artem Harutyunyan > >
