Review Request 55388: Added `system` environment variables in `mesos-docker-executor`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55388/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Added `system` environment variables in `mesos-docker-executor`. Diffs - src/slave/containerizer/docker.cpp 7a8a7271b54af0b4dcdae7a2aa8a90a8a7d05fd6 Diff: https://reviews.apache.org/r/55388/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 53712: Added `system` environment variables in ` execvpe.cpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53712/ --- (Updated Jan. 10, 2017, 7:01 p.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Summary (updated) - Added `system` environment variables in ` execvpe.cpp`. Repository: mesos Description (updated) --- Added `system` environment variables in ` execvpe.cpp`. Diffs (updated) - src/slave/containerizer/mesos/launch.cpp e482ab8bdfc358f695b87cda72ca59fb64cd8c4d Diff: https://reviews.apache.org/r/53712/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55023/#review160410 --- src/slave/containerizer/mesos/containerizer.cpp (line 1604) <https://reviews.apache.org/r/55023/#comment231548> This change is sufficient to fix the problem. Otherwise the user must add flags.launcher_dir to the path. src/slave/containerizer/mesos/containerizer.cpp (line 1614) <https://reviews.apache.org/r/55023/#comment231549> Not necessary to run cmd.exe (arg0) just to start mesos_containerizer. - Daniel Pravat On Dec. 24, 2016, 10:02 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55023/ > --- > > (Updated Dec. 24, 2016, 10:02 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, > and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Currently in `MesosContainerizerProcess::_launch`, we are passing a > malformatted shell command to the launcher. This causes the > containerizer process to crash immediately upon invocation in all > executor tests. > > This commit will fix this command. > > > Diffs > - > > src/slave/containerizer/mesos/containerizer.cpp > d9d5619e45ae1199fc91878f17a33b5647f48305 > > Diff: https://reviews.apache.org/r/55023/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55023/#review160115 --- src/slave/containerizer/mesos/containerizer.cpp (line 1611) <https://reviews.apache.org/r/55023/#comment231120> This code was working before. you should not change it to make the taest work and add overhead in production. - Daniel Pravat On Dec. 24, 2016, 10:02 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55023/ > --- > > (Updated Dec. 24, 2016, 10:02 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, > and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Currently in `MesosContainerizerProcess::_launch`, we are passing a > malformatted shell command to the launcher. This causes the > containerizer process to crash immediately upon invocation in all > executor tests. > > This commit will fix this command. > > > Diffs > - > > src/slave/containerizer/mesos/containerizer.cpp > d9d5619e45ae1199fc91878f17a33b5647f48305 > > Diff: https://reviews.apache.org/r/55023/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54877/#review159672 --- 3rdparty/stout/include/stout/windows/os.hpp (line 743) <https://reviews.apache.org/r/54877/#comment230691> I don't think the conversion to UTF-8 is appropiate here. - Daniel Pravat On Dec. 19, 2016, 11:20 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54877/ > --- > > (Updated Dec. 19, 2016, 11:20 p.m.) > > > Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > The API `SHGetKnownFolderPath` requires `Shell32.dll`, > which is not available on Nano server. > The equivalent API `GetAllUsersProfileDirectory` > only requires `Userenv.dll`, which is available on Nano. > > This API is also friendlier, as we own the allocation. > > The Unicode version `GetAllUsersProfileDirectoryW` is > explicitly used so that we are guaranteed a Unicode path, > which we then convert from UTF-16 to UTF-8, > instead of using the ASCII version which depends on a > varying Windows code-page, and is not recommended. > > A `vector` is used over a `wstring` to avoid dealing > with the placement of the null-terminating character. > > > Diffs > - > > 3rdparty/stout/include/stout/windows.hpp > e641c46d033372e1b6c9f9c066b1ad4957d55088 > 3rdparty/stout/include/stout/windows/os.hpp > 5cd92545a49648e39e8eb7cf131895e9cfc97902 > > Diff: https://reviews.apache.org/r/54877/diff/ > > > Testing > --- > > cmake && msbuild, attach agent to master and check default `runtime_dir` > value. > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 53712: Added `system` environement variables in ` execvpe.cpp`.
> On Dec. 19, 2016, 7:07 p.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 689 > > <https://reviews.apache.org/r/53712/diff/2/?file=1565265#file1565265line689> > > > > We should allow system environment variables to be overwritten if they > > are specified by the framework. This might cause applications to *not* > > work, but upon overriding system defaults, it becomes the overidder's > > problem. > > > > For the MVP for Windows support, I'd argue that overriding system > > environment variables (with no way to prevent the override) is acceptable. > > But we should leave a TODO in the code and a JIRA to consider otherwise. MESOS-6816 has been opened to track the overwrite. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53712/#review159636 ------- On Nov. 16, 2016, 6:37 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53712/ > --- > > (Updated Nov. 16, 2016, 6:37 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > --- > > Added `system` environement variables in ` execvpe.cpp`. > > > Diffs > - > > src/slave/containerizer/mesos/launch.cpp > 320e42748adbabf09f77cb4f5951e2a7ea58fe64 > > Diff: https://reviews.apache.org/r/53712/diff/ > > > Testing > --- > > > Thanks, > > Daniel Pravat > >
Re: Review Request 52190: Removed deprecated compiler warnings.
> On Nov. 23, 2016, 9:27 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake, lines 97-98 > > <https://reviews.apache.org/r/52190/diff/2/?file=1569355#file1569355line97> > > > > Can you add some comments above these? > > > > I presume that the first definition silences some MSVC or CRT warnings. > > But what does the second definition do? These defines are used to suppress the warnings from Winsock APIs used in int_fd. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/#review156785 ------- On Nov. 23, 2016, 5:12 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52190/ > --- > > (Updated Nov. 23, 2016, 5:12 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > --- > > Removed deprecated compiler warnings. > > > Diffs > - > > cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 > > Diff: https://reviews.apache.org/r/52190/diff/ > > > Testing > --- > > > Thanks, > > Daniel Pravat > >
Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/#review159213 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 8:45 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54591/ > --- > > (Updated Dec. 13, 2016, 8:45 p.m.) > > > Review request for mesos and Daniel Pravat. > > > Repository: mesos > > > Description > --- > > In POSIX the socket, pipe and a file are represented by the `int` type. > In Windows: > - A socket is kept in a `SOCKET` type (64 bit wide) > - A pipe or a WinAPI file descriptor in a `HANDLE` (64 bit wide) > - A CRT file descriptor in an `int` > > The `WindowsFD` class is a type that brings all of these things > together and behaves analogously to an `int` in POSIX. > > > Diffs > - > > 3rdparty/stout/include/stout/os.hpp > cdcbbf488d110e33e796fb0b7414793391761abf > 3rdparty/stout/include/stout/os/int_fd.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/fd.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54591/diff/ > > > Testing > --- > > > Thanks, > > Michael Park > >
Re: Review Request 54593: Replaced `::lseek` with `os::lseek` in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54593/#review159211 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:01 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54593/ > --- > > (Updated Dec. 13, 2016, 9:01 p.m.) > > > Review request for mesos and Daniel Pravat. > > > Repository: mesos > > > Description > --- > > Replaced `::lseek` with `os::lseek` in stout. > > > Diffs > - > > 3rdparty/stout/include/stout/protobuf.hpp > 80cb20f40a7ddd4309d27973eef9fca9e4052b64 > > Diff: https://reviews.apache.org/r/54593/diff/ > > > Testing > --- > > > Thanks, > > Michael Park > >
Re: Review Request 54594: Replaced `::lseek` with `os::lseek` in mesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54594/#review159210 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:01 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54594/ > --- > > (Updated Dec. 13, 2016, 9:01 p.m.) > > > Review request for mesos and Daniel Pravat. > > > Repository: mesos > > > Description > --- > > Replaced `::lseek` with `os::lseek` in mesos. > > > Diffs > - > > src/files/files.cpp 9c634ac928887b3f1a111f67ebb3fc5229c6fa16 > src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 > > Diff: https://reviews.apache.org/r/54594/diff/ > > > Testing > --- > > > Thanks, > > Michael Park > >
Re: Review Request 54595: Introduced an `os::dup` abstraction in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54595/#review159209 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:02 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54595/ > --- > > (Updated Dec. 13, 2016, 9:02 p.m.) > > > Review request for mesos and Daniel Pravat. > > > Repository: mesos > > > Description > --- > > Introduced an `os::dup` abstraction in stout. > > > Diffs > - > > 3rdparty/stout/include/Makefile.am fc020bbf65030eb69a42d5c402e38ecb145f4c0f > 3rdparty/stout/include/stout/os.hpp > cdcbbf488d110e33e796fb0b7414793391761abf > 3rdparty/stout/include/stout/os/dup.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/posix/dup.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/dup.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54595/diff/ > > > Testing > --- > > > Thanks, > > Michael Park > >
Re: Review Request 54590: Removed unused peek function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54590/#review159208 --- 3rdparty/libprocess/src/io.cpp <https://reviews.apache.org/r/54590/#comment230152> Can you also remove the declaration from the io.hpp ? - Daniel Pravat On Dec. 13, 2016, 8:44 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54590/ > --- > > (Updated Dec. 13, 2016, 8:44 p.m.) > > > Review request for mesos and Daniel Pravat. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > 3rdparty/libprocess/src/io.cpp e81f279ed4bf92f75ad2427550ca822a9b03cca5 > 3rdparty/libprocess/src/tests/io_tests.cpp > b9825e8633f64c23e4b1ea904537cdc8da64ed5b > > Diff: https://reviews.apache.org/r/54590/diff/ > > > Testing > --- > > > Thanks, > > Michael Park > >
Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/#review159206 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:01 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54592/ > --- > > (Updated Dec. 13, 2016, 9:01 p.m.) > > > Review request for mesos and Daniel Pravat. > > > Repository: mesos > > > Description > --- > > Introduced an `os::lseek` abstraction in stout. > > > Diffs > - > > 3rdparty/stout/include/Makefile.am fc020bbf65030eb69a42d5c402e38ecb145f4c0f > 3rdparty/stout/include/stout/os.hpp > cdcbbf488d110e33e796fb0b7414793391761abf > 3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54592/diff/ > > > Testing > --- > > > Thanks, > > Michael Park > >
Re: Review Request 52544: Introduced `int_fd` class.
> On Nov. 19, 2016, 3:28 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 381-384 > > <https://reviews.apache.org/r/52544/diff/7/?file=1565875#file1565875line381> > > > > Do we actually need this? I think the `int` on the rhs should implicit > > convert to `WindowsFD` in which case this would be handled by: > > > > ``` > > bool operator==( > > const os::WindowsFileDescriptor& left, > > const os::WindowsFileDescriptor& right); > > ``` > > Daniel Pravat wrote: > There are many conversion options and the compiler is not selecting bool > operator==( > const os::WindowsFileDescriptor& left, > const os::WindowsFileDescriptor& right); The are other candidates for this conversion. The compilation fails. > On Nov. 19, 2016, 3:28 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 318-334 > > <https://reviews.apache.org/r/52544/diff/7/?file=1565875#file1565875line318> > > > > I feel like we should be able to answer this question (`is_socket`) for > > `WindowsFD` since we answer it for `int` in POSIX. (Beyond the fact that it > > seems bizzare for `SOCKET` to somehow __not__ be a socket...) This is a temporary function. I will remove it asap. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/#review156376 --- On Nov. 30, 2016, 7:54 a.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52544/ > --- > > (Updated Nov. 30, 2016, 7:54 a.m.) > > > Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael > Park. > > > Repository: mesos > > > Description > --- > > In POSIX the `socket`,`pipe` and the `filedescriptor` are > represented by an int type. In Windows a socket is kept in a > `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and > a file descriptor in an int. This class unifies all Windows types. > In POSIX this class is an int. > > > Diffs > - > > 3rdparty/stout/include/stout/os.hpp > bd085e4e29bbdb2d2baaaeff1d10c0bd95ca65ba > 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/52544/diff/ > > > Testing > --- > > > Thanks, > > Daniel Pravat > >
Re: Review Request 52972: Replaced POSIX `int` with `int_fd` abstraction in `stout` folder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52972/ --- (Updated Nov. 30, 2016, 7:55 a.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Replaced POSIX `int` with `int_fd` abstraction in `stout` folder. Diffs (updated) - 3rdparty/stout/include/stout/net.hpp 083b8d1959dcd305d0aa8892082b39cb03786ebf 3rdparty/stout/include/stout/os/mktemp.hpp 2dfd35605eb4202a5475fe0e0d2f1fd27690a2de 3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 3rdparty/stout/include/stout/os/read.hpp d0b657db5b7dc0c1e11edc13fd6830a9f6273867 3rdparty/stout/include/stout/os/socket.hpp e9d9306e63aff2be083b4254fbf6f31c37edc424 3rdparty/stout/include/stout/os/touch.hpp 84d49bb8adc2612e380f037fd42c47166d55f593 3rdparty/stout/include/stout/os/windows/close.hpp 9f1566bff19ee872418bce8a43a119c4f0a70a7c 3rdparty/stout/include/stout/os/windows/fcntl.hpp 2bc794a405e59d80c1e8308c0049d2306347adfa 3rdparty/stout/include/stout/os/windows/ftruncate.hpp a7f53ad2e8735b515590af84c0efce3edcc1bebf 3rdparty/stout/include/stout/os/windows/read.hpp 09190f97f33db5dfa023f937f8f2a4a62ed1ec15 3rdparty/stout/include/stout/os/windows/sendfile.hpp d6358cc02c1eea9298907da1f74eb7eeaeec7d21 3rdparty/stout/include/stout/os/windows/shell.hpp 17e3d564564abebf1d558b7a7a277aef3c87e5ae 3rdparty/stout/include/stout/os/windows/socket.hpp 1f6551bc30cf31842513df0fed43ee134c620ebd 3rdparty/stout/include/stout/os/windows/write.hpp 23488708ae366b8571bb8b4805f67d2054223fff 3rdparty/stout/include/stout/os/write.hpp 24a69d8f60efd3c2888d464d75164c758b3701a2 3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038 3rdparty/stout/include/stout/protobuf.hpp 80cb20f40a7ddd4309d27973eef9fca9e4052b64 3rdparty/stout/include/stout/windows/os.hpp de9b04ad82443038a0f4408bc72cae1540a1beaf 3rdparty/stout/tests/os/filesystem_tests.cpp 22460842c0db5dc5b6effbc2bdfce043ed47db6d 3rdparty/stout/tests/os_tests.cpp ad23ec00de7770a5024c084627b0ff1e4cc2a439 Diff: https://reviews.apache.org/r/52972/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52544: Introduced `int_fd` class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 30, 2016, 7:54 a.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- In POSIX the `socket`,`pipe` and the `filedescriptor` are represented by an int type. In Windows a socket is kept in a `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and a file descriptor in an int. This class unifies all Windows types. In POSIX this class is an int. Diffs (updated) - 3rdparty/stout/include/stout/os.hpp bd085e4e29bbdb2d2baaaeff1d10c0bd95ca65ba 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 53706: Implemented `os::user' on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53706/ --- (Updated Nov. 30, 2016, 7:54 a.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Implemented `os::user' on Windows. Diffs (updated) - 3rdparty/stout/include/stout/os/windows/su.hpp 1bb70964adbb80aa6502fbfe69de2c34dc74e655 Diff: https://reviews.apache.org/r/53706/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52544: Introduced `int_fd` class.
> On Nov. 19, 2016, 3:28 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 381-384 > > <https://reviews.apache.org/r/52544/diff/7/?file=1565875#file1565875line381> > > > > Do we actually need this? I think the `int` on the rhs should implicit > > convert to `WindowsFD` in which case this would be handled by: > > > > ``` > > bool operator==( > > const os::WindowsFileDescriptor& left, > > const os::WindowsFileDescriptor& right); > > ``` There are many conversion options and the compiler is not selecting bool operator==( const os::WindowsFileDescriptor& left, const os::WindowsFileDescriptor& right); - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/#review156376 ------- On Nov. 30, 2016, 7:54 a.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52544/ > --- > > (Updated Nov. 30, 2016, 7:54 a.m.) > > > Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael > Park. > > > Repository: mesos > > > Description > --- > > In POSIX the `socket`,`pipe` and the `filedescriptor` are > represented by an int type. In Windows a socket is kept in a > `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and > a file descriptor in an int. This class unifies all Windows types. > In POSIX this class is an int. > > > Diffs > - > > 3rdparty/stout/include/stout/os.hpp > bd085e4e29bbdb2d2baaaeff1d10c0bd95ca65ba > 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/52544/diff/ > > > Testing > --- > > > Thanks, > > Daniel Pravat > >
Re: Review Request 52364: Added basic support to invoke `docker.exe`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52364/ --- (Updated Nov. 23, 2016, 5:19 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Used platform specific null device string. Alled use of `npipe` as `Docker` socket. Diffs - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c src/slave/slave.cpp 2d91e1ca6895d19a282a380a8ea6415ad7ca8c6a Diff: https://reviews.apache.org/r/52364/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52544: Introduced `int_fd` class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 23, 2016, 5:20 p.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- In POSIX the `socket`,`pipe` and the `filedescriptor` are represented by an int type. In Windows a socket is kept in a `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and a file descriptor in an int. This class unifies all Windows types. In POSIX this class is an int. Diffs - 3rdparty/stout/include/stout/os.hpp bd085e4e29bbdb2d2baaaeff1d10c0bd95ca65ba 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52192: Fixed VC warnings in bytes.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/ --- (Updated Nov. 23, 2016, 5:13 p.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Fixed VC warnings in bytes.hpp. Diffs - 3rdparty/stout/include/stout/bytes.hpp 9debe2f5579b9b2d67933ecc2bfcc40c2730f7f1 Diff: https://reviews.apache.org/r/52192/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52190: Removed deprecated compiler warnings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/ --- (Updated Nov. 23, 2016, 5:12 p.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Removed deprecated compiler warnings. Diffs - cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 Diff: https://reviews.apache.org/r/52190/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52190: Removed deprecated compiler warnings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/ --- (Updated Nov. 23, 2016, 4:12 p.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Removed deprecated compiler warnings. Diffs (updated) - cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 Diff: https://reviews.apache.org/r/52190/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 53715: Define docker `--entrypoint` for `Windows`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53715/ --- (Updated Nov. 23, 2016, 6:59 a.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Define docker `--entrypoint` for `Windows`. Diffs - 3rdparty/stout/include/stout/os/posix/shell.hpp 70a9184e85ba322f1cd4ce5d12b963cd4b3ad500 3rdparty/stout/include/stout/os/windows/shell.hpp 17e3d564564abebf1d558b7a7a277aef3c87e5ae Diff: https://reviews.apache.org/r/53715/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52190: Removed deprecated compiler warnings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/ --- (Updated Nov. 23, 2016, 6:56 a.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Removed deprecated compiler warnings. Diffs - cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 Diff: https://reviews.apache.org/r/52190/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52972: Replaced POSIX `int` with `int_fd` abstraction in `stout` folder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52972/ --- (Updated Nov. 23, 2016, 6:31 a.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Replaced POSIX `int` with `int_fd` abstraction in `stout` folder. Diffs (updated) - 3rdparty/stout/include/stout/net.hpp 083b8d1959dcd305d0aa8892082b39cb03786ebf 3rdparty/stout/include/stout/os/mktemp.hpp 2dfd35605eb4202a5475fe0e0d2f1fd27690a2de 3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 3rdparty/stout/include/stout/os/read.hpp d0b657db5b7dc0c1e11edc13fd6830a9f6273867 3rdparty/stout/include/stout/os/socket.hpp e9d9306e63aff2be083b4254fbf6f31c37edc424 3rdparty/stout/include/stout/os/touch.hpp 84d49bb8adc2612e380f037fd42c47166d55f593 3rdparty/stout/include/stout/os/windows/close.hpp 9f1566bff19ee872418bce8a43a119c4f0a70a7c 3rdparty/stout/include/stout/os/windows/fcntl.hpp 2bc794a405e59d80c1e8308c0049d2306347adfa 3rdparty/stout/include/stout/os/windows/ftruncate.hpp a7f53ad2e8735b515590af84c0efce3edcc1bebf 3rdparty/stout/include/stout/os/windows/read.hpp 09190f97f33db5dfa023f937f8f2a4a62ed1ec15 3rdparty/stout/include/stout/os/windows/sendfile.hpp d6358cc02c1eea9298907da1f74eb7eeaeec7d21 3rdparty/stout/include/stout/os/windows/shell.hpp 17e3d564564abebf1d558b7a7a277aef3c87e5ae 3rdparty/stout/include/stout/os/windows/socket.hpp 1f6551bc30cf31842513df0fed43ee134c620ebd 3rdparty/stout/include/stout/os/windows/write.hpp 23488708ae366b8571bb8b4805f67d2054223fff 3rdparty/stout/include/stout/os/write.hpp 24a69d8f60efd3c2888d464d75164c758b3701a2 3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038 3rdparty/stout/include/stout/protobuf.hpp 80cb20f40a7ddd4309d27973eef9fca9e4052b64 3rdparty/stout/include/stout/windows/os.hpp de9b04ad82443038a0f4408bc72cae1540a1beaf 3rdparty/stout/tests/os/filesystem_tests.cpp 22460842c0db5dc5b6effbc2bdfce043ed47db6d 3rdparty/stout/tests/os_tests.cpp ad23ec00de7770a5024c084627b0ff1e4cc2a439 Diff: https://reviews.apache.org/r/52972/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52625: Replaced POSIX `int` with `int_fd` abstraction in `libprocess` folder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52625/ --- (Updated Nov. 23, 2016, 6:31 a.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- On POSIX this should have no effect. Diffs (updated) - 3rdparty/libprocess/include/process/io.hpp eec5efd7e6b71a783f2bb40826054d0488cee71f 3rdparty/libprocess/include/process/network.hpp 52110667185370a4c92e2fa524819ab1f34bdec9 3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f 3rdparty/libprocess/include/process/subprocess_base.hpp 1d02454d5541f96cb4928bf027fcae3764989d67 3rdparty/libprocess/include/process/windows/subprocess.hpp f452f6743d01f0b99010fa5e5bcbaae1358c8241 3rdparty/libprocess/src/io.cpp d930ceebc90468e082b984e41385549f906dc6ae 3rdparty/libprocess/src/libevent_poll.cpp 0803ba33622c86df38b3efd4f1e3197edf93a0af 3rdparty/libprocess/src/poll_socket.hpp d04f3f2d1bcf70464ac659b29f96574bbd233414 3rdparty/libprocess/src/poll_socket.cpp eb7b48713edd30b545d7be95b5d51b0f71bd422a 3rdparty/libprocess/src/process.cpp b5ee0b3861cbb035198796c9a7a68d43922652c1 3rdparty/libprocess/src/socket.cpp 7f93168e1572f8669f67a4c5e6e5467259b7a407 3rdparty/libprocess/src/subprocess_windows.cpp 20cad52d4a4d7fc51487e150a849972eb19ed08e 3rdparty/libprocess/src/tests/subprocess_tests.cpp 59c17692012ddfb540ecdd48560c73c42a15f061 Diff: https://reviews.apache.org/r/52625/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 53706: Implemented `os::user' on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53706/ --- (Updated Nov. 23, 2016, 6:30 a.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Implemented `os::user' on Windows. Diffs (updated) - 3rdparty/stout/include/stout/os/windows/su.hpp 1bb70964adbb80aa6502fbfe69de2c34dc74e655 Diff: https://reviews.apache.org/r/53706/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52544: Introduced `int_fd` class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 17, 2016, 7:09 a.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- In POSIX the `socket`,`pipe` and the `filedescriptor` are represented by an int type. In Windows a socket is kept in a `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and a file descriptor in an int. This class unifies all Windows types. In POSIX this class is an int. Diffs (updated) - 3rdparty/stout/include/stout/os.hpp bd085e4e29bbdb2d2baaaeff1d10c0bd95ca65ba 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52544: Introduced `int_fd` class.
> On Nov. 17, 2016, 12:57 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 416-440 > > <https://reviews.apache.org/r/52544/diff/6/?file=1565250#file1565250line416> > > > > What is this used for? This is called from the function below. It is used when we create two pipes int_fd(s) holding anonimous pipes as the Posix pipe API. I think it can be avoided and default to a socket<->pipe model. > On Nov. 17, 2016, 12:57 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 356-379 > > <https://reviews.apache.org/r/52544/diff/6/?file=1565250#file1565250line356> > > > > Do we actually need this for something..? There are several places where the int_fd is used in the logs. Hence '<<'. Furthermore the handles are serialized for the containerizer command line and are deserialized in the containerizer. > On Nov. 17, 2016, 12:57 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, line 148 > > <https://reviews.apache.org/r/52544/diff/6/?file=1565250#file1565250line148> > > > > What is `NONE` for? it doesn't seem like we use it? None is used when pipe are used on both legs of the adapter. > On Nov. 17, 2016, 12:57 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 36-38 > > <https://reviews.apache.org/r/52544/diff/6/?file=1565250#file1565250line36> > > > > What are these for? closed is used to detect on Mesos code a leaked. Also the IO from os:: namespace may use this flag to reject the operation on a closed handle. Otherwise we see strange error deep in CRT. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/#review156151 --- On Nov. 16, 2016, 6:37 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52544/ > --- > > (Updated Nov. 16, 2016, 6:37 p.m.) > > > Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael > Park. > > > Repository: mesos > > > Description > --- > > In POSIX the `socket`,`pipe` and the `filedescriptor` are > represented by an int type. In Windows a socket is kept in a > `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and > a file descriptor in an int. This class unifies all Windows types. > In POSIX this class is an int. > > > Diffs > - > > 3rdparty/stout/include/stout/os.hpp > bd085e4e29bbdb2d2baaaeff1d10c0bd95ca65ba > 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/52544/diff/ > > > Testing > --- > > > Thanks, > > Daniel Pravat > >
Re: Review Request 52544: Introduced `int_fd` class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 16, 2016, 6:37 p.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- In POSIX the `socket`,`pipe` and the `filedescriptor` are represented by an int type. In Windows a socket is kept in a `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and a file descriptor in an int. This class unifies all Windows types. In POSIX this class is an int. Diffs (updated) - 3rdparty/stout/include/stout/os.hpp bd085e4e29bbdb2d2baaaeff1d10c0bd95ca65ba 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 53712: Added `system` environement variables in ` execvpe.cpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53712/ --- (Updated Nov. 16, 2016, 6:37 p.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Added `system` environement variables in ` execvpe.cpp`. Diffs (updated) - src/slave/containerizer/mesos/launch.cpp 320e42748adbabf09f77cb4f5951e2a7ea58fe64 Diff: https://reviews.apache.org/r/53712/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52625: Replaced POSIX `int` with `int_fd` abstraction in `libprocess` folder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52625/ --- (Updated Nov. 16, 2016, 6:37 p.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- On POSIX this should have no effect. Diffs (updated) - 3rdparty/libprocess/include/process/io.hpp eec5efd7e6b71a783f2bb40826054d0488cee71f 3rdparty/libprocess/include/process/network.hpp 52110667185370a4c92e2fa524819ab1f34bdec9 3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f 3rdparty/libprocess/include/process/subprocess_base.hpp 1d02454d5541f96cb4928bf027fcae3764989d67 3rdparty/libprocess/include/process/windows/subprocess.hpp f452f6743d01f0b99010fa5e5bcbaae1358c8241 3rdparty/libprocess/src/io.cpp d930ceebc90468e082b984e41385549f906dc6ae 3rdparty/libprocess/src/libevent_poll.cpp 0803ba33622c86df38b3efd4f1e3197edf93a0af 3rdparty/libprocess/src/poll_socket.hpp d04f3f2d1bcf70464ac659b29f96574bbd233414 3rdparty/libprocess/src/poll_socket.cpp f0ee1490e6fccb038f64a27b2c71458ad5b5e5a1 3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d 3rdparty/libprocess/src/socket.cpp 7f93168e1572f8669f67a4c5e6e5467259b7a407 3rdparty/libprocess/src/subprocess_windows.cpp 20cad52d4a4d7fc51487e150a849972eb19ed08e 3rdparty/libprocess/src/tests/subprocess_tests.cpp 0dc1c62b0e708125392ffa798a52b59ea6e55abe 3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 Diff: https://reviews.apache.org/r/52625/diff/ Testing --- Thanks, Daniel Pravat
Review Request 52190: Removed deprecated compiler warnings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Summary (updated) - Removed deprecated compiler warnings. Repository: mesos Description (updated) --- Removed deprecated compiler warnings. Diffs (updated) - cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 Diff: https://reviews.apache.org/r/52190/diff/ Testing --- Thanks, Daniel Pravat
Review Request 52189: Compiler warnings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52189/ --- Review request for mesos. Repository: mesos Description --- Compiler warnings. Diffs - cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 Diff: https://reviews.apache.org/r/52189/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52210: Fixed warnings in `getcwd.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52210/ --- (Updated Nov. 14, 2016, 5:47 a.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Fixed warnings in `getcwd.hpp`. Diffs (updated) - 3rdparty/stout/include/stout/windows.hpp 3782aa0f5c8636fef3cd47e78be0b9860b735a02 Diff: https://reviews.apache.org/r/52210/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52364: Added basic support to invoke `docker.exe`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52364/ --- (Updated Nov. 14, 2016, 5:47 a.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Used platform specific null device string. Alled use of `npipe` as `Docker` socket. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c src/slave/slave.cpp 2d91e1ca6895d19a282a380a8ea6415ad7ca8c6a Diff: https://reviews.apache.org/r/52364/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52192: Fixed VC warnings in bytes.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/ --- (Updated Nov. 14, 2016, 5:47 a.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Fixed VC warnings in bytes.hpp. Diffs (updated) - 3rdparty/stout/include/stout/bytes.hpp 9debe2f5579b9b2d67933ecc2bfcc40c2730f7f1 Diff: https://reviews.apache.org/r/52192/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52544: Introduced `int_fd` class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 14, 2016, 5:47 a.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Summary (updated) - Introduced `int_fd` class. Repository: mesos Description (updated) --- In POSIX the `socket`,`pipe` and the `filedescriptor` are represented by an int type. In Windows a socket is kept in a `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and a file descriptor in an int. This class unifies all Windows types. In POSIX this class is an int. Diffs (updated) - 3rdparty/stout/include/stout/os.hpp bd085e4e29bbdb2d2baaaeff1d10c0bd95ca65ba 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52625: Replaced POSIX `int` with `int_fd` abstraction in `libprocess` folder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52625/ --- (Updated Nov. 14, 2016, 5:46 a.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Summary (updated) - Replaced POSIX `int` with `int_fd` abstraction in `libprocess` folder. Repository: mesos Description --- On POSIX this should have no effect. Diffs (updated) - 3rdparty/libprocess/include/process/io.hpp eec5efd7e6b71a783f2bb40826054d0488cee71f 3rdparty/libprocess/include/process/network.hpp 52110667185370a4c92e2fa524819ab1f34bdec9 3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f 3rdparty/libprocess/include/process/subprocess_base.hpp 1d02454d5541f96cb4928bf027fcae3764989d67 3rdparty/libprocess/include/process/windows/subprocess.hpp f452f6743d01f0b99010fa5e5bcbaae1358c8241 3rdparty/libprocess/src/io.cpp d930ceebc90468e082b984e41385549f906dc6ae 3rdparty/libprocess/src/libevent_poll.cpp 0803ba33622c86df38b3efd4f1e3197edf93a0af 3rdparty/libprocess/src/poll_socket.hpp d04f3f2d1bcf70464ac659b29f96574bbd233414 3rdparty/libprocess/src/poll_socket.cpp f0ee1490e6fccb038f64a27b2c71458ad5b5e5a1 3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d 3rdparty/libprocess/src/socket.cpp 7f93168e1572f8669f67a4c5e6e5467259b7a407 3rdparty/libprocess/src/subprocess_windows.cpp 20cad52d4a4d7fc51487e150a849972eb19ed08e 3rdparty/libprocess/src/tests/subprocess_tests.cpp 0dc1c62b0e708125392ffa798a52b59ea6e55abe 3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 Diff: https://reviews.apache.org/r/52625/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53706: Implemented `os::user' on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53706/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Implemented `os::user' on Windows. Diffs - 3rdparty/stout/include/stout/os/windows/su.hpp 777140e1139d6eeab20780e8c0d0a273ce6a8125 Diff: https://reviews.apache.org/r/53706/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52624: Replaced POSIX `int` with `int_fd` abstraction in `src` folder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52624/ --- (Updated Nov. 14, 2016, 5:46 a.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Summary (updated) - Replaced POSIX `int` with `int_fd` abstraction in `src` folder. Repository: mesos Description --- On POSIX this should have no effect. Diffs (updated) - cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 src/files/files.cpp 9c634ac928887b3f1a111f67ebb3fc5229c6fa16 src/slave/containerizer/fetcher.cpp d200c117579bc1c2d9d24f14bf4da8f650d3f562 src/slave/containerizer/mesos/containerizer.hpp 272052ddf85b50f817a110a9a83566b011598985 src/slave/containerizer/mesos/containerizer.cpp ec4ae32485a7ab6c9f73c512004d1220482a188e src/slave/containerizer/mesos/launch.hpp 155e3c5a27b8c710971ee4b508600d3b5589a2e0 src/slave/containerizer/mesos/launch.cpp 320e42748adbabf09f77cb4f5951e2a7ea58fe64 src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 src/slave/status_update_manager.cpp 056a684b52756d5c6309e7e2167a1532c4e60957 Diff: https://reviews.apache.org/r/52624/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53707: Added a Windows isolator. Removed `#ifdef`-ed block from Posix.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53707/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Added a Windows isolator. Removed `#ifdef`-ed block from Posix. Diffs - src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 270d2aa6e06f323bfb6eee3b703a24a600a55871 src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 2bf011d3e7b014a17f759851d755b161c897b131 src/slave/containerizer/mesos/isolators/filesystem/windows.cpp f169c380f803a2111b1612cee60250ee9a30ef2e Diff: https://reviews.apache.org/r/53707/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53709: Remuved warnings from gzip.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53709/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Remuved warnings from gzip.hpp. Diffs - 3rdparty/stout/include/stout/gzip.hpp 97891860dbdd7095d5498695ad0e97ad02e35d73 Diff: https://reviews.apache.org/r/53709/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53708: Remove warnings from `duration.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53708/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Remove warnings from `duration.hpp`. Diffs - 3rdparty/stout/include/stout/duration.hpp 0a30a09678c20937caa6f094c3c63a326e357932 Diff: https://reviews.apache.org/r/53708/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53712: Added `system` environement variables in ` execvpe.cpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53712/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Added `system` environement variables in ` execvpe.cpp`. Diffs - src/slave/containerizer/mesos/launch.cpp 320e42748adbabf09f77cb4f5951e2a7ea58fe64 Diff: https://reviews.apache.org/r/53712/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53710: Removed warnings from `dirent.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53710/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Removed warnings from `dirent.hpp`. Diffs - 3rdparty/stout/include/stout/internal/windows/dirent.hpp fe3321060646089d3f0d8c5a3ebc0b207161740f Diff: https://reviews.apache.org/r/53710/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53714: Fixed leak in `fetcher.cpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53714/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Fixed leak in `fetcher.cpp`. Diffs - src/slave/containerizer/fetcher.cpp d200c117579bc1c2d9d24f14bf4da8f650d3f562 Diff: https://reviews.apache.org/r/53714/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53713: Reversed recoursive path creation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53713/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- This change allows the user to use different path formats. Specialy on Windows will allow to specify `X:\PATH`, '\\foo\bar\PATH`, `\\?\X:\PATH` and other valid path. Diffs - 3rdparty/stout/include/stout/os/mkdir.hpp fe86864c8b480993c8f052f39b2fd3ece23798da Diff: https://reviews.apache.org/r/53713/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53715: Define docker `--entrypoint` for `Windows`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53715/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Define docker `--entrypoint` for `Windows`. Diffs - 3rdparty/stout/include/stout/os/posix/shell.hpp 70a9184e85ba322f1cd4ce5d12b963cd4b3ad500 3rdparty/stout/include/stout/os/windows/shell.hpp 17e3d564564abebf1d558b7a7a277aef3c87e5ae Diff: https://reviews.apache.org/r/53715/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53718: Defined and used Windows string `docker-mesos-executor.exe`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53718/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Defined and used Windows string `docker-mesos-executor.exe`. Diffs - src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c Diff: https://reviews.apache.org/r/53718/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53716: Used `Shell::entrypoint`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53716/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Used `Shell::entrypoint`. Diffs - src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/53716/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53717: Added `Winsock` initialization in `docker-mesos-executor`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53717/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Added `Winsock` initialization in `docker-mesos-executor`. Diffs - src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 Diff: https://reviews.apache.org/r/53717/diff/ Testing --- Thanks, Daniel Pravat
Review Request 53719: Created default mount point on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53719/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- Created default mount point on Windows. Diffs - src/slave/flags.cpp 76609f94482a792f4c8db480e604d98d172abb04 Diff: https://reviews.apache.org/r/53719/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52972: Replaced POSIX `int` with `int_fd` abstraction in `stout` folder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52972/ --- (Updated Nov. 14, 2016, 5:40 a.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Summary (updated) - Replaced POSIX `int` with `int_fd` abstraction in `stout` folder. Repository: mesos Description (updated) --- Replaced POSIX `int` with `int_fd` abstraction in `stout` folder. Diffs (updated) - 3rdparty/stout/include/stout/net.hpp 083b8d1959dcd305d0aa8892082b39cb03786ebf 3rdparty/stout/include/stout/os/mktemp.hpp 2dfd35605eb4202a5475fe0e0d2f1fd27690a2de 3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 3rdparty/stout/include/stout/os/read.hpp d0b657db5b7dc0c1e11edc13fd6830a9f6273867 3rdparty/stout/include/stout/os/socket.hpp e9d9306e63aff2be083b4254fbf6f31c37edc424 3rdparty/stout/include/stout/os/touch.hpp 84d49bb8adc2612e380f037fd42c47166d55f593 3rdparty/stout/include/stout/os/windows/close.hpp 9f1566bff19ee872418bce8a43a119c4f0a70a7c 3rdparty/stout/include/stout/os/windows/fcntl.hpp 2bc794a405e59d80c1e8308c0049d2306347adfa 3rdparty/stout/include/stout/os/windows/ftruncate.hpp a7f53ad2e8735b515590af84c0efce3edcc1bebf 3rdparty/stout/include/stout/os/windows/read.hpp 09190f97f33db5dfa023f937f8f2a4a62ed1ec15 3rdparty/stout/include/stout/os/windows/sendfile.hpp d6358cc02c1eea9298907da1f74eb7eeaeec7d21 3rdparty/stout/include/stout/os/windows/shell.hpp 17e3d564564abebf1d558b7a7a277aef3c87e5ae 3rdparty/stout/include/stout/os/windows/socket.hpp 1f6551bc30cf31842513df0fed43ee134c620ebd 3rdparty/stout/include/stout/os/windows/write.hpp 23488708ae366b8571bb8b4805f67d2054223fff 3rdparty/stout/include/stout/os/write.hpp 24a69d8f60efd3c2888d464d75164c758b3701a2 3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038 3rdparty/stout/include/stout/protobuf.hpp 80cb20f40a7ddd4309d27973eef9fca9e4052b64 3rdparty/stout/include/stout/windows/os.hpp 7ca0b5dc9793369ea142684e3614e8f33cac64b6 3rdparty/stout/tests/os/filesystem_tests.cpp 22460842c0db5dc5b6effbc2bdfce043ed47db6d 3rdparty/stout/tests/os_tests.cpp 0b7ee0723b6a608d6f110fa8ac16e0fd7b75ddea Diff: https://reviews.apache.org/r/52972/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52625: Replaced POSIX `int` with `FileDesc` abstraction in `libprocess` folder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52625/ --- (Updated Oct. 18, 2016, 2:47 a.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- On POSIX this should have no effect. Diffs (updated) - 3rdparty/libprocess/include/process/io.hpp eec5efd7e6b71a783f2bb40826054d0488cee71f 3rdparty/libprocess/include/process/network.hpp 52110667185370a4c92e2fa524819ab1f34bdec9 3rdparty/libprocess/include/process/socket.hpp 67551a904ebc4c2f97d65ad7ab5d4ab8c07f16db 3rdparty/libprocess/include/process/subprocess_base.hpp 1d02454d5541f96cb4928bf027fcae3764989d67 3rdparty/libprocess/include/process/windows/subprocess.hpp f452f6743d01f0b99010fa5e5bcbaae1358c8241 3rdparty/libprocess/src/io.cpp d930ceebc90468e082b984e41385549f906dc6ae 3rdparty/libprocess/src/poll_socket.hpp d04f3f2d1bcf70464ac659b29f96574bbd233414 3rdparty/libprocess/src/poll_socket.cpp d9ab3fbbf385c39c0e43ee92ff06609ae8d47e2d 3rdparty/libprocess/src/process.cpp 18a8e206f6f297157d246a94f374311be67cd782 3rdparty/libprocess/src/socket.cpp 6089248639793603226210421a2c2193d14ea049 3rdparty/libprocess/src/subprocess_windows.cpp 20cad52d4a4d7fc51487e150a849972eb19ed08e 3rdparty/libprocess/src/tests/subprocess_tests.cpp 630a7147c327de41f3166f5802f7ef6e12532aa3 3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 Diff: https://reviews.apache.org/r/52625/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52624: Replaced POSIX `int` with `FileDesc` abstraction in `src` folder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52624/ --- (Updated Oct. 18, 2016, 2:46 a.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- On POSIX this should have no effect. Diffs (updated) - cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 src/files/files.cpp 9c634ac928887b3f1a111f67ebb3fc5229c6fa16 src/health-check/health_checker.cpp 96ae1a733ff3d211b84d0893b4603873af1c89f0 src/slave/containerizer/fetcher.cpp 11104d66e6dd05d8eb1d37a2e3250aca19278110 src/slave/containerizer/mesos/containerizer.cpp eac70d955e08142a2d054039d610a3d516b1b57e src/slave/containerizer/mesos/launch.hpp f8bac0650965a49562b9910bf6140ded8dbb69ac src/slave/containerizer/mesos/launch.cpp 8a30ff8bd6f9263d68a4344b79f2374a2ae53c04 src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 src/slave/status_update_manager.cpp 056a684b52756d5c6309e7e2167a1532c4e60957 Diff: https://reviews.apache.org/r/52624/diff/ Testing --- Thanks, Daniel Pravat
Review Request 52972: Replaced POSIX `int` with `FileDesc` abstraction in `stout` folder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52972/ --- Review request for mesos. Repository: mesos Description --- Replaced POSIX `int` with `FileDesc` abstraction in `stout` folder. Diffs - 3rdparty/stout/include/stout/net.hpp 083b8d1959dcd305d0aa8892082b39cb03786ebf 3rdparty/stout/include/stout/os/mktemp.hpp 2dfd35605eb4202a5475fe0e0d2f1fd27690a2de 3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 3rdparty/stout/include/stout/os/read.hpp d0b657db5b7dc0c1e11edc13fd6830a9f6273867 3rdparty/stout/include/stout/os/socket.hpp e9d9306e63aff2be083b4254fbf6f31c37edc424 3rdparty/stout/include/stout/os/touch.hpp 84d49bb8adc2612e380f037fd42c47166d55f593 3rdparty/stout/include/stout/os/windows/close.hpp 9f1566bff19ee872418bce8a43a119c4f0a70a7c 3rdparty/stout/include/stout/os/windows/fcntl.hpp 2bc794a405e59d80c1e8308c0049d2306347adfa 3rdparty/stout/include/stout/os/windows/read.hpp 09190f97f33db5dfa023f937f8f2a4a62ed1ec15 3rdparty/stout/include/stout/os/windows/shell.hpp 17e3d564564abebf1d558b7a7a277aef3c87e5ae 3rdparty/stout/include/stout/os/windows/socket.hpp 1f6551bc30cf31842513df0fed43ee134c620ebd 3rdparty/stout/include/stout/os/windows/write.hpp 23488708ae366b8571bb8b4805f67d2054223fff 3rdparty/stout/include/stout/os/write.hpp 24a69d8f60efd3c2888d464d75164c758b3701a2 3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038 3rdparty/stout/include/stout/protobuf.hpp 80cb20f40a7ddd4309d27973eef9fca9e4052b64 3rdparty/stout/include/stout/windows/os.hpp 7ca0b5dc9793369ea142684e3614e8f33cac64b6 3rdparty/stout/tests/os/filesystem_tests.cpp e3894ef6f21c15845085400a0d3426520411788e Diff: https://reviews.apache.org/r/52972/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52544: Introduced `FileDesc` class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Oct. 18, 2016, 2:45 a.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description (updated) --- In POSIX the `socket`,`pipe` and the `filedescriptor` are represented by an int type. In Windows a socket is kept in a `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and a file descriptor in an int. Ths class unifies all Windows types. In POSIX this class defaults to int (can be easily extended). Diffs (updated) - 3rdparty/stout/include/stout/os.hpp 96e8621b198a3ec4cce78e0a6ff5f271eda05ff1 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52544: Introduced `FileDesc` class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Oct. 8, 2016, 4:13 a.m.) Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- On POSIX the `socket`,`pipe` and the `filedescriptor` are represented by an int type. In Windows a socket is kept in a `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and a file descriptor in an int. Ths class unifies all Windows types. In POSIX this class defaults to int (can be easily extended). Diffs (updated) - 3rdparty/libprocess/src/io.cpp d930ceebc90468e082b984e41385549f906dc6ae 3rdparty/stout/include/stout/net.hpp 083b8d1959dcd305d0aa8892082b39cb03786ebf 3rdparty/stout/include/stout/os.hpp c38e434d90c8c25570118c255f2eec72f96b348d 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION 3rdparty/stout/include/stout/os/mktemp.hpp 2dfd35605eb4202a5475fe0e0d2f1fd27690a2de 3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 3rdparty/stout/include/stout/os/read.hpp d0b657db5b7dc0c1e11edc13fd6830a9f6273867 3rdparty/stout/include/stout/os/socket.hpp e9d9306e63aff2be083b4254fbf6f31c37edc424 3rdparty/stout/include/stout/os/touch.hpp 84d49bb8adc2612e380f037fd42c47166d55f593 3rdparty/stout/include/stout/os/windows/close.hpp 9f1566bff19ee872418bce8a43a119c4f0a70a7c 3rdparty/stout/include/stout/os/windows/fcntl.hpp 2bc794a405e59d80c1e8308c0049d2306347adfa 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/read.hpp 09190f97f33db5dfa023f937f8f2a4a62ed1ec15 3rdparty/stout/include/stout/os/windows/shell.hpp 0ababb4ff76d55d82b8d528f54c99bd4b231b21b 3rdparty/stout/include/stout/os/windows/socket.hpp 1f6551bc30cf31842513df0fed43ee134c620ebd 3rdparty/stout/include/stout/os/windows/write.hpp 23488708ae366b8571bb8b4805f67d2054223fff 3rdparty/stout/include/stout/os/write.hpp 24a69d8f60efd3c2888d464d75164c758b3701a2 3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038 3rdparty/stout/include/stout/protobuf.hpp 80cb20f40a7ddd4309d27973eef9fca9e4052b64 3rdparty/stout/include/stout/windows/os.hpp 7d6530e37e389a314185e5aaa85d8096a28b9c41 3rdparty/stout/tests/os/filesystem_tests.cpp e3894ef6f21c15845085400a0d3426520411788e Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat
Review Request 52623: Replaced POSIX `int` with `FileDesc` abstraction in `src` folder. On POSIX this should have no effect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52623/ --- Review request for mesos, Joseph Wu and Michael Park. Repository: mesos Description --- Replaced POSIX `int` with `FileDesc` abstraction in `src` folder. On POSIX this should have no effect. Diffs - cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 src/files/files.cpp 9c634ac928887b3f1a111f67ebb3fc5229c6fa16 src/health-check/health_checker.cpp 96ae1a733ff3d211b84d0893b4603873af1c89f0 src/slave/containerizer/fetcher.cpp 11104d66e6dd05d8eb1d37a2e3250aca19278110 src/slave/containerizer/mesos/containerizer.cpp e6bd9f7a8284d220be157a3db2da094e6b1b6d33 src/slave/containerizer/mesos/launch.hpp a9b6ee2f0da2c1c84c6a0642adbce20a9f0218dc src/slave/containerizer/mesos/launch.cpp 7dd10d5030260fbfdf7396a7c05a52b7c3d983e8 src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 src/slave/status_update_manager.cpp 056a684b52756d5c6309e7e2167a1532c4e60957 Diff: https://reviews.apache.org/r/52623/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52545: Replaced POSIX `int` with `FileDesc` abstraction.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52545/ --- (Updated Oct. 7, 2016, 5:45 a.m.) Review request for mesos, Joseph Wu and Michael Park. Repository: mesos Description --- On POSIX this should have no effect. Diffs (updated) - 3rdparty/libprocess/include/process/io.hpp eec5efd7e6b71a783f2bb40826054d0488cee71f 3rdparty/libprocess/include/process/network.hpp 52110667185370a4c92e2fa524819ab1f34bdec9 3rdparty/libprocess/include/process/socket.hpp 67551a904ebc4c2f97d65ad7ab5d4ab8c07f16db 3rdparty/libprocess/include/process/subprocess_base.hpp 1d02454d5541f96cb4928bf027fcae3764989d67 3rdparty/libprocess/include/process/windows/subprocess.hpp f452f6743d01f0b99010fa5e5bcbaae1358c8241 3rdparty/libprocess/src/io.cpp d930ceebc90468e082b984e41385549f906dc6ae 3rdparty/libprocess/src/poll_socket.hpp d04f3f2d1bcf70464ac659b29f96574bbd233414 3rdparty/libprocess/src/poll_socket.cpp d9ab3fbbf385c39c0e43ee92ff06609ae8d47e2d 3rdparty/libprocess/src/process.cpp f1d746c52cfe659f5cd7da4b7a6424ff585619a3 3rdparty/libprocess/src/socket.cpp 6089248639793603226210421a2c2193d14ea049 3rdparty/libprocess/src/tests/subprocess_tests.cpp c8350cf8e512dca23933725e6edb3e3d94380211 Diff: https://reviews.apache.org/r/52545/diff/ Testing --- Thanks, Daniel Pravat
Review Request 52624: Replaced POSIX `int` with `FileDesc` abstraction in `src` folder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52624/ --- Review request for mesos, Joseph Wu and Michael Park. Repository: mesos Description --- On POSIX this should have no effect. Diffs - cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 src/files/files.cpp 9c634ac928887b3f1a111f67ebb3fc5229c6fa16 src/health-check/health_checker.cpp 96ae1a733ff3d211b84d0893b4603873af1c89f0 src/slave/containerizer/fetcher.cpp 11104d66e6dd05d8eb1d37a2e3250aca19278110 src/slave/containerizer/mesos/containerizer.cpp e6bd9f7a8284d220be157a3db2da094e6b1b6d33 src/slave/containerizer/mesos/launch.hpp a9b6ee2f0da2c1c84c6a0642adbce20a9f0218dc src/slave/containerizer/mesos/launch.cpp 7dd10d5030260fbfdf7396a7c05a52b7c3d983e8 src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 src/slave/status_update_manager.cpp 056a684b52756d5c6309e7e2167a1532c4e60957 Diff: https://reviews.apache.org/r/52624/diff/ Testing --- Thanks, Daniel Pravat
Review Request 52625: Replaced POSIX `int` with `FileDesc` abstraction in `libprocess` folder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52625/ --- Review request for mesos, Joseph Wu and Michael Park. Repository: mesos Description --- On POSIX this should have no effect. Diffs - 3rdparty/libprocess/src/subprocess_windows.cpp 20cad52d4a4d7fc51487e150a849972eb19ed08e 3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 Diff: https://reviews.apache.org/r/52625/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52544: Introduced `FileDesc` class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Oct. 7, 2016, 5:44 a.m.) Review request for mesos, Joseph Wu and Michael Park. Repository: mesos Description --- On POSIX the `socket`,`pipe` and the `filedescriptor` are represented by an int type. In Windows a socket is kept in a `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and a file descriptor in an int. Ths class unifies all Windows types. In POSIX this class defaults to int (can be easily extended). Diffs (updated) - 3rdparty/libprocess/src/io.cpp d930ceebc90468e082b984e41385549f906dc6ae 3rdparty/stout/include/stout/net.hpp 083b8d1959dcd305d0aa8892082b39cb03786ebf 3rdparty/stout/include/stout/os.hpp c38e434d90c8c25570118c255f2eec72f96b348d 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION 3rdparty/stout/include/stout/os/mktemp.hpp 2dfd35605eb4202a5475fe0e0d2f1fd27690a2de 3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 3rdparty/stout/include/stout/os/read.hpp d0b657db5b7dc0c1e11edc13fd6830a9f6273867 3rdparty/stout/include/stout/os/socket.hpp e9d9306e63aff2be083b4254fbf6f31c37edc424 3rdparty/stout/include/stout/os/touch.hpp 84d49bb8adc2612e380f037fd42c47166d55f593 3rdparty/stout/include/stout/os/windows/close.hpp 9f1566bff19ee872418bce8a43a119c4f0a70a7c 3rdparty/stout/include/stout/os/windows/fcntl.hpp 2bc794a405e59d80c1e8308c0049d2306347adfa 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/read.hpp 09190f97f33db5dfa023f937f8f2a4a62ed1ec15 3rdparty/stout/include/stout/os/windows/shell.hpp 0ababb4ff76d55d82b8d528f54c99bd4b231b21b 3rdparty/stout/include/stout/os/windows/socket.hpp 1f6551bc30cf31842513df0fed43ee134c620ebd 3rdparty/stout/include/stout/os/windows/write.hpp 23488708ae366b8571bb8b4805f67d2054223fff 3rdparty/stout/include/stout/os/write.hpp 24a69d8f60efd3c2888d464d75164c758b3701a2 3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038 3rdparty/stout/include/stout/protobuf.hpp 80cb20f40a7ddd4309d27973eef9fca9e4052b64 3rdparty/stout/include/stout/windows/os.hpp 7d6530e37e389a314185e5aaa85d8096a28b9c41 3rdparty/stout/tests/os/filesystem_tests.cpp e3894ef6f21c15845085400a0d3426520411788e Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat
Review Request 52545: Replaced POSIX `int` with `FileDesc` abstraction.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52545/ --- Review request for mesos, Joseph Wu and Michael Park. Repository: mesos Description --- On POSIX this should have no effect. Diffs - 3rdparty/libprocess/include/process/io.hpp eec5efd7e6b71a783f2bb40826054d0488cee71f 3rdparty/libprocess/include/process/network.hpp 52110667185370a4c92e2fa524819ab1f34bdec9 3rdparty/libprocess/include/process/socket.hpp 67551a904ebc4c2f97d65ad7ab5d4ab8c07f16db 3rdparty/libprocess/include/process/subprocess_base.hpp 1d02454d5541f96cb4928bf027fcae3764989d67 3rdparty/libprocess/include/process/windows/subprocess.hpp f452f6743d01f0b99010fa5e5bcbaae1358c8241 3rdparty/libprocess/src/io.cpp d930ceebc90468e082b984e41385549f906dc6ae 3rdparty/libprocess/src/poll_socket.hpp d04f3f2d1bcf70464ac659b29f96574bbd233414 3rdparty/libprocess/src/poll_socket.cpp d9ab3fbbf385c39c0e43ee92ff06609ae8d47e2d 3rdparty/libprocess/src/process.cpp f1d746c52cfe659f5cd7da4b7a6424ff585619a3 3rdparty/libprocess/src/socket.cpp 6089248639793603226210421a2c2193d14ea049 3rdparty/libprocess/src/tests/subprocess_tests.cpp c8350cf8e512dca23933725e6edb3e3d94380211 Diff: https://reviews.apache.org/r/52545/diff/ Testing --- Thanks, Daniel Pravat
Review Request 52544: Introduced `FileDesc` class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- Review request for mesos, Joseph Wu and Michael Park. Repository: mesos Description --- On POSIX the `socket`,`pipe` and the `filedescriptor` are represented by an int type. In Windows a socket is kept in a `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and a file descriptor in an int. Ths class unifies all Windows types. In POSIX this class defaults to int (can be easily extended). Diffs - 3rdparty/stout/include/stout/os.hpp c38e434d90c8c25570118c255f2eec72f96b348d 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION 3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038 3rdparty/stout/include/stout/windows/os.hpp 7d6530e37e389a314185e5aaa85d8096a28b9c41 Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52192: Fixed VC warnings in bytes.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/ --- (Updated Sept. 29, 2016, 4:33 a.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Changes --- removed discarded review dependency -- @vinodkone Repository: mesos Description --- Fixed VC warnings in bytes.hpp. Diffs - 3rdparty/stout/include/stout/bytes.hpp 9debe2f5579b9b2d67933ecc2bfcc40c2730f7f1 Diff: https://reviews.apache.org/r/52192/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52210: Fixed warnings in getcwd.hpp.
> On Sept. 29, 2016, 12:32 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/getcwd.hpp, line 27 > > <https://reviews.apache.org/r/52210/diff/1/?file=1509031#file1509031line27> > > > > This doesn't seem correct. > > > > `getcwd()` on Posix is: > > ``` > > char *getcwd(char *buf, size_t size); > > ``` > > > > On Windows: > > ``` > > char *_getcwd(char *buffer, int maxlen); > > ``` > > > > So we should be changing the `getcwd()` wrapper in `stout/windows.hpp`. Missed our re-definition. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52210/#review150791 --- On Sept. 23, 2016, 4:48 a.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52210/ > --- > > (Updated Sept. 23, 2016, 4:48 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Fixed warnings in getcwd.hpp. > > > Diffs > - > > 3rdparty/stout/include/stout/os/getcwd.hpp > 63ecc98326a4ba9d78eb0bcec18407c3f4a76de3 > > Diff: https://reviews.apache.org/r/52210/diff/ > > > Testing > --- > > > Thanks, > > Daniel Pravat > >
Re: Review Request 52210: Fixed warnings in `getcwd.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52210/ --- (Updated Sept. 29, 2016, 3:32 a.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Summary (updated) - Fixed warnings in `getcwd.hpp`. Repository: mesos Description (updated) --- Fixed warnings in `getcwd.hpp`. Diffs (updated) - 3rdparty/stout/include/stout/windows.hpp 3782aa0f5c8636fef3cd47e78be0b9860b735a02 Diff: https://reviews.apache.org/r/52210/diff/ Testing --- Thanks, Daniel Pravat
Review Request 52364: Added basic support to invoke `docker.exe`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52364/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Used platform specific null device string. Alled use of `npipe` as `Docker` socket. Diffs - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 7c38123f1bedc7cda9c30ce9dd9877b7c41988fb src/slave/containerizer/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982 src/slave/slave.cpp 7073be44eab6187390922a74cf72facc29bf2ad4 Diff: https://reviews.apache.org/r/52364/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52062: Fixed warnings in `numify.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52062/ --- (Updated Sept. 26, 2016, 9:37 p.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- When the template is instatiated for unsigned scalars the unary negation generates warnings. Diffs (updated) - 3rdparty/stout/include/stout/numify.hpp c174fcb8cb9d809f443e44058f07b58751bed9dd Diff: https://reviews.apache.org/r/52062/diff/ Testing --- Windows: build Thanks, Daniel Pravat
Re: Review Request 52195: Used functions from `net::` namespace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52195/ --- (Updated Sept. 26, 2016, 9:37 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Summary (updated) - Used functions from `net::` namespace. Repository: mesos Description (updated) --- Used functions from `net::` namespace. Diffs (updated) - 3rdparty/libprocess/include/process/network.hpp 0dd1b6d14e66a74172d1b077353dcc3391950b08 3rdparty/libprocess/src/poll_socket.cpp 1cc5e8831dbcb096c135b4cb35d1df5efcf4f622 Diff: https://reviews.apache.org/r/52195/diff/ Testing --- OSX: make check Windows: build Thanks, Daniel Pravat
Re: Review Request 52194: Added functions to translate parameters.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52194/ --- (Updated Sept. 26, 2016, 9:21 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Summary (updated) - Added functions to translate parameters. Repository: mesos Description (updated) --- Added functions to translate parameters. Diffs (updated) - 3rdparty/stout/include/stout/os/posix/socket.hpp ab5f62a67c3adfe4d0c4c3532f9c2b4d43336c48 3rdparty/stout/include/stout/os/windows/socket.hpp d564a2bcc78570beb76a71cf35f3902333cd99ea Diff: https://reviews.apache.org/r/52194/diff/ Testing --- Windows: build OSX: make check Thanks, Daniel Pravat
Re: Review Request 52196: Fixed warnings in `read/write` functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/ --- (Updated Sept. 26, 2016, 9:15 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in `read/write` functions. Diffs (updated) - 3rdparty/stout/include/stout/os/windows/read.hpp cb0abf70307f0dbba0b8f68e884df199b0359186 3rdparty/stout/include/stout/os/windows/sendfile.hpp 4c5178e1f3696906aa1cf93b8ca450f61ba79355 3rdparty/stout/include/stout/os/windows/write.hpp 705ad03ee58f9cc822ec1ed25fd10f39059717d4 Diff: https://reviews.apache.org/r/52196/diff/ Testing --- OSX: make check Windows: build Thanks, Daniel Pravat
Re: Review Request 52196: Fixed warnings in `read/write` functions.
> On Sept. 26, 2016, 8:43 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/read.hpp, line 35 > > <https://reviews.apache.org/r/52196/diff/1/?file=1509013#file1509013line35> > > > > You wrapped the `::recv` in an earlier patch. Want to use it here? > > (`net::recv`) Good catch (bad merge?). recv() takes the lengths as `int` while _read() takes it as `unsigned int`. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/#review150447 --- On Sept. 23, 2016, 5:05 a.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52196/ > --- > > (Updated Sept. 23, 2016, 5:05 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Fixed warnings in `read/write` functions. > > > Diffs > - > > 3rdparty/stout/include/stout/os/windows/read.hpp > cb0abf70307f0dbba0b8f68e884df199b0359186 > 3rdparty/stout/include/stout/os/windows/sendfile.hpp > 4c5178e1f3696906aa1cf93b8ca450f61ba79355 > 3rdparty/stout/include/stout/os/windows/write.hpp > 705ad03ee58f9cc822ec1ed25fd10f39059717d4 > > Diff: https://reviews.apache.org/r/52196/diff/ > > > Testing > --- > > OSX: make check > Windows: build > > > Thanks, > > Daniel Pravat > >
Re: Review Request 52196: Fixed warnings in `read/write` functions.
> On Sept. 26, 2016, 8:38 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/sendfile.hpp, line 31 > > <https://reviews.apache.org/r/52196/diff/1/?file=1509014#file1509014line31> > > > > What's this used for? Is MSVC warning because of the bit shifting > > (`offset >> 32`) below? Yes. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/#review150439 ------- On Sept. 23, 2016, 5:05 a.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52196/ > --- > > (Updated Sept. 23, 2016, 5:05 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Fixed warnings in `read/write` functions. > > > Diffs > - > > 3rdparty/stout/include/stout/os/windows/read.hpp > cb0abf70307f0dbba0b8f68e884df199b0359186 > 3rdparty/stout/include/stout/os/windows/sendfile.hpp > 4c5178e1f3696906aa1cf93b8ca450f61ba79355 > 3rdparty/stout/include/stout/os/windows/write.hpp > 705ad03ee58f9cc822ec1ed25fd10f39059717d4 > > Diff: https://reviews.apache.org/r/52196/diff/ > > > Testing > --- > > OSX: make check > Windows: build > > > Thanks, > > Daniel Pravat > >
Re: Review Request 52198: Fixed warning in `statistics_tests`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52198/ --- (Updated Sept. 23, 2016, 5:09 a.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warning in `statistics_tests`. Diffs - 3rdparty/libprocess/src/tests/statistics_tests.cpp 54849a0a95be334a7203d7725185a402947755e5 Diff: https://reviews.apache.org/r/52198/diff/ Testing (updated) --- Windows: build OSX: make check Thanks, Daniel Pravat
Review Request 52198: Fixed warning in `statistics_tests`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52198/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warning in `statistics_tests`. Diffs - 3rdparty/libprocess/src/tests/statistics_tests.cpp 54849a0a95be334a7203d7725185a402947755e5 Diff: https://reviews.apache.org/r/52198/diff/ Testing --- Thanks, Daniel Pravat
Review Request 52199: Fixed warning in `stout_tests`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52199/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warning in `stout_tests`. Diffs - 3rdparty/stout/tests/os/filesystem_tests.cpp b747c168687af48427af167941a11a45aa0cd352 3rdparty/stout/tests/os/process_tests.cpp 1e26877c7aee67d629789205639ad7c35df1d9c7 Diff: https://reviews.apache.org/r/52199/diff/ Testing --- Windows: build OSX: make check Thanks, Daniel Pravat
Review Request 52195: Used functions from net:: namespace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52195/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Used functions from net:: namespace. Diffs - 3rdparty/libprocess/include/process/network.hpp 0dd1b6d14e66a74172d1b077353dcc3391950b08 3rdparty/libprocess/src/poll_socket.cpp 1cc5e8831dbcb096c135b4cb35d1df5efcf4f622 Diff: https://reviews.apache.org/r/52195/diff/ Testing --- OSX: make check Windows: build Thanks, Daniel Pravat
Review Request 52196: Fixed warnings in `read/write` functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in `read/write` functions. Diffs - 3rdparty/stout/include/stout/os/windows/read.hpp cb0abf70307f0dbba0b8f68e884df199b0359186 3rdparty/stout/include/stout/os/windows/sendfile.hpp 4c5178e1f3696906aa1cf93b8ca450f61ba79355 3rdparty/stout/include/stout/os/windows/write.hpp 705ad03ee58f9cc822ec1ed25fd10f39059717d4 Diff: https://reviews.apache.org/r/52196/diff/ Testing --- OSX: make check Windows: build Thanks, Daniel Pravat
Review Request 52194: Added `socket` functions to translate parameters.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52194/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Added `socket` functions to translate parameters. Diffs - 3rdparty/stout/include/stout/os/posix/socket.hpp ab5f62a67c3adfe4d0c4c3532f9c2b4d43336c48 3rdparty/stout/include/stout/os/windows/socket.hpp d564a2bcc78570beb76a71cf35f3902333cd99ea Diff: https://reviews.apache.org/r/52194/diff/ Testing --- Windows: build OSX: make check Thanks, Daniel Pravat
Review Request 52193: Fixed VC warnings in windows.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52193/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed VC warnings in windows.hpp. Diffs - 3rdparty/stout/include/stout/windows.hpp 5cca853c4b090c4516ad4ec04c6e5830a4e7ccfa Diff: https://reviews.apache.org/r/52193/diff/ Testing --- Windows: build OSX: make check Thanks, Daniel Pravat
Review Request 52200: Fixed warnings in system.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52200/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in system.hpp. Diffs - 3rdparty/libprocess/include/process/system.hpp 2a61b8e7fcd797a22ada6322932baefc485b7d56 Diff: https://reviews.apache.org/r/52200/diff/ Testing --- Windows: build OSX: make build Thanks, Daniel Pravat
Review Request 52197: Used intermediate functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52197/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Used `socket` intermediate functions. Diffs - 3rdparty/libprocess/src/io.cpp d9c60754b1eaf83b1f5626a220f431cadeca541a Diff: https://reviews.apache.org/r/52197/diff/ Testing --- Windows: build OSX: make check Thanks, Daniel Pravat
Review Request 52201: Fixed warnings in timer.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52201/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in timer.hpp. Diffs - 3rdparty/libprocess/include/process/timer.hpp d60b9aec78210e30cce4c053939f6fecf36ba938 Diff: https://reviews.apache.org/r/52201/diff/ Testing --- Windows: build OSX: make check Thanks, Daniel Pravat
reviews@mesos.apache.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52202/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in encoder&decoder.hpp. Diffs - 3rdparty/libprocess/src/decoder.hpp ccf12ac8ae05141b4324ef2b4599a6bd7461c4ec 3rdparty/libprocess/src/encoder.hpp af083d196aa67d08f1b3299b0a15fbc7d1fd7cd5 Diff: https://reviews.apache.org/r/52202/diff/ Testing --- Windows: build OSX: make check Thanks, Daniel Pravat
Review Request 52203: Fixed warnings in metrics.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52203/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in metrics.hpp. Diffs - 3rdparty/libprocess/src/metrics/metrics.cpp ac1544e70f5884f946ce3c31c5430c6a2c1f9dd1 Diff: https://reviews.apache.org/r/52203/diff/ Testing --- Windows: build OSX: make check Thanks, Daniel Pravat
Review Request 52204: Fixed warnings in socket.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52204/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in socket.hpp. Diffs - 3rdparty/libprocess/src/socket.cpp 1e495181f3e43d4a2d6cdf8aa8c9605dfd52c81b Diff: https://reviews.apache.org/r/52204/diff/ Testing --- OSX: make check Windows: build Thanks, Daniel Pravat
Review Request 52205: Fixed warnings in flags.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52205/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in flags.hpp. Diffs - 3rdparty/stout/include/stout/flags/flags.hpp 4ca6c69aeb1e3343e9b0ae2562c450c4c645890c Diff: https://reviews.apache.org/r/52205/diff/ Testing --- Windows: build OSX: make check Thanks, Daniel Pravat
Review Request 52206: Fixed warnings in os.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52206/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in os.hpp. Diffs - 3rdparty/stout/include/stout/windows/os.hpp fb341348d842513f7479a9f00880c8b63dd49fb6 Diff: https://reviews.apache.org/r/52206/diff/ Testing --- Windows: build OSX: make check Thanks, Daniel Pravat
Review Request 52207: Fixed warnings in fs.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52207/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in fs.hpp. Diffs - 3rdparty/stout/include/stout/windows/fs.hpp 99887b1047aedf1d814690cbf826469cb0e4fefa Diff: https://reviews.apache.org/r/52207/diff/ Testing --- Windows: build OSX: make check Thanks, Daniel Pravat
Review Request 52208: Fixed warnings in health_checker.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52208/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in health_checker.cpp. Diffs - src/health-check/health_checker.cpp 758cbb382b08743f518022ba66eaafbea7615592 Diff: https://reviews.apache.org/r/52208/diff/ Testing --- Windows: buils OSX: make check Thanks, Daniel Pravat
Re: Review Request 52209: Fixed warnings in slave.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52209/ --- (Updated Sept. 23, 2016, 4:49 a.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in slave.cpp. Diffs - src/slave/slave.hpp 3e7832c18acf876e8139fd0758204d8af1d91a04 Diff: https://reviews.apache.org/r/52209/diff/ Testing (updated) --- Windows: build OSX: make check Thanks, Daniel Pravat
Review Request 52209: Fixed warnings in slave.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52209/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in slave.cpp. Diffs - src/slave/slave.hpp 3e7832c18acf876e8139fd0758204d8af1d91a04 Diff: https://reviews.apache.org/r/52209/diff/ Testing --- Thanks, Daniel Pravat
Review Request 52210: Fixed warnings in getcwd.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52210/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed warnings in getcwd.hpp. Diffs - 3rdparty/stout/include/stout/os/getcwd.hpp 63ecc98326a4ba9d78eb0bcec18407c3f4a76de3 Diff: https://reviews.apache.org/r/52210/diff/ Testing --- Thanks, Daniel Pravat
Review Request 52192: Fixed VC warnings in bytes.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Description --- Fixed VC warnings in bytes.hpp. Diffs - 3rdparty/stout/include/stout/bytes.hpp 9debe2f5579b9b2d67933ecc2bfcc40c2730f7f1 Diff: https://reviews.apache.org/r/52192/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 52062: Fixed warnings in `numify.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52062/ --- (Updated Sept. 23, 2016, 4:46 a.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- When the template is instatiated for unsigned scalars the unary negation generates warnings. Diffs (updated) - 3rdparty/stout/include/stout/numify.hpp c174fcb8cb9d809f443e44058f07b58751bed9dd Diff: https://reviews.apache.org/r/52062/diff/ Testing --- Windows: build Thanks, Daniel Pravat
Review Request 52062: Fixed warnings in `numify.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52062/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. Repository: mesos Description --- When the template is instatiated for unsigned scalars the unary negation generates warnings. Diffs - 3rdparty/stout/include/stout/numify.hpp c174fcb8cb9d809f443e44058f07b58751bed9dd Diff: https://reviews.apache.org/r/52062/diff/ Testing --- Windows: build Thanks, Daniel Pravat
