Re: Review Request 56895: Allow agents to recover slave state post a reboot.
> On 六月 13, 2017, 12:12 a.m., Vinod Kone wrote: > > Can you split this review into multiple logical reviews? It is really hard > > to review otherwise. > > > > Below are a few splits I could think of > > > > 1) Renames of variables (e.g., in tests). > > 2) Changes of resources value in tests (not sure of the reason for this > > change). > > 3) Addition of a new helper `recoverSlaveState` > > 4) Changes to containerizers to short circuit recovery if state is none > > (not sure of the reason for this change) > > 5) Adding `rebooted` field to recovery info and state (you can combine this > > with 6th if you want but might be easier to review separately) > > 6) Keeping the agent id on reboot > > > > In addition to making it easy to review it will help us to ship parts of > > this chain sooner than later. +1 - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/#review177687 --- On 六月 9, 2017, 4:27 a.m., Megha Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56895/ > --- > > (Updated 六月 9, 2017, 4:27 a.m.) > > > Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-6223 > https://issues.apache.org/jira/browse/MESOS-6223 > > > Repository: mesos > > > Description > --- > > With partition awareness, the agents are now allowed to re-register > after they have been marked Unreachable. The executors are anyway > terminated on the agent when it reboots so there is no harm in > letting the agent keep its SlaveID, re-register with the master > and reconcile the lost executors. This is a pre-requisite for > supporting persistent/restartable tasks in mesos. > > > Diffs > - > > src/slave/containerizer/composing.cpp > a003e1b80dc9b4dec5b3fbbadb2daecf855c90c7 > src/slave/containerizer/docker.cpp 9f84109d7de22a39ace6e44e0c7d8d501bcb24de > src/slave/containerizer/mesos/containerizer.cpp > f3e6210eccd4a6b445ffd4447e69526d424ea36d > src/slave/slave.hpp 7ffaed14035a05259ec72c70532ee4f0affa1f5d > src/slave/slave.cpp 7d147ac6609933ac884bfc29032dba572a0952c6 > src/slave/state.hpp a497ce1f58fb8dc7718ee5bb10bc62dd7479efa5 > src/slave/state.cpp 18b790d2cc4f537cc9b0c3cca59b9cbaac0eda10 > src/tests/reservation_tests.cpp 6e9c215382ef41700921a673669ac1a7975e9b7f > src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c > > > Diff: https://reviews.apache.org/r/56895/diff/7/ > > > Testing > --- > > make check > > > Thanks, > > Megha Sharma > >
Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).
> On 四月 8, 2017, 11:38 a.m., haosdent huang wrote: > > src/slave/containerizer/docker.cpp > > Lines 366 (patched) > > <https://reviews.apache.org/r/58200/diff/3/?file=1686784#file1686784line366> > > > > I think it is fine to use priviliged to lauch mesos-executor. But after > > discussed with @xiaods, let me find if we could avoid to use privileged via > > --cap-add. add new pr to fix it, it works in my side workround. - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58200/#review171402 ------- On 四月 16, 2017, 9:26 a.m., Deshi Xiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58200/ > --- > > (Updated 四月 16, 2017, 9:26 a.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Bugs: MESOS-7210 > https://issues.apache.org/jira/browse/MESOS-7210 > > > Repository: mesos > > > Description > --- > > Becuase MESOS HTTP checks doesn't work when mesos runs with > --docker_mesos_image ( pid namespace mismatch ).So let docker > executor run with container add host pid mapping(--pid=host) > > > Diffs > - > > src/slave/containerizer/docker.cpp be1a298b12374bced44e2467cb7e90a1599abb8f > > > Diff: https://reviews.apache.org/r/58200/diff/4/ > > > Testing > --- > > 1. Build the image with latest code. Let's name the image with `mesos-build` > here. > > 2. Launch mesos master. > > ``` > $ docker run \ > -it \ > --pid host \ > --net host \ > --privileged \ > -v /var/run/docker.sock:/var/run/docker.sock \ > -v /sys/fs/cgroup:/sys/fs/cgroup \ > mesos-build \ > mesos-master \ > --hostname=127.0.0.1 \ > --ip=127.0.0.1 \ > --port=5050 \ > --work_dir=/tmp/mesos > ``` > > 3. Launch mesos agent. > > ``` > $ docker run \ > -it \ > --pid host \ > --net host \ > --privileged \ > -v /var/run/docker.sock:/var/run/docker.sock \ > -v /sys/fs/cgroup:/sys/fs/cgroup \ > mesos-build \ > mesos-agent \ > --hostname=127.0.0.1 \ > --ip=127.0.0.1 \ > --master=127.0.0.1:5050 \ > --systemd_enable_support=false \ > --work_dir=/tmp/mesos \ > --containerizers=docker,mesos \ > --docker_mesos_image=mesos-build > ``` > > 4. Launch task with health check. > > Define the task with health check. > > ``` > $ cat /tmp/task.json > { > "name": "test-health-check", > "task_id": {"value" : "test-health-check"}, > "agent_id": {"value" : ""}, > "resources": [ > { > "name": "cpus", > "type": "SCALAR", > "scalar": { > "value": 0.1 > }, > "role": "*" > }, > { > "name": "mem", > "type": "SCALAR", > "scalar": { > "value": 32 > }, > "role": "*" > } > ], > "command": { > "value": "sleep 1000" > }, > "container": { > "type": "DOCKER", > "volumes": [], > "docker": { > "image": "mesos-build", > "network": "HOST" > } > }, > "health_check": { > "type": "HTTP", > "http": { > "scheme": "http", > "port": 5050 > }, > "gracePeriodSeconds": 300, > "intervalSeconds": 60, > "timeoutSeconds": 20, > "maxConsecutiveFailures": 3 > } > } > ``` > > Lauch task > > ``` > $ mesos-execute --master=127.0.0.1:5050 --task=/tmp/task.json > ``` > > And verified the healthy status of task is correct. > > ``` > I0407 16:29:57.258509 88767 health_checker.cpp:123] Entered the net namespace > of task (pid: '88727') successfully > I0407 16:29:57.334801 88643 health_checker.cpp:395] Performed HTTP health > check for task 'test-health-check' in 86.311186ms > I0407 16:29:57.334872 88643 health_checker.cpp:319] HTTP health check for > task 'test-health-check' passed > ``` > > > Thanks, > > Deshi Xiao > >
Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58200/ --- (Updated 四月 16, 2017, 9:26 a.m.) Review request for mesos, Alexander Rukletsov and haosdent huang. Changes --- use alternative cap-add SYS_ADMIN Bugs: MESOS-7210 https://issues.apache.org/jira/browse/MESOS-7210 Repository: mesos Description --- Becuase MESOS HTTP checks doesn't work when mesos runs with --docker_mesos_image ( pid namespace mismatch ).So let docker executor run with container add host pid mapping(--pid=host) Diffs (updated) - src/slave/containerizer/docker.cpp be1a298b12374bced44e2467cb7e90a1599abb8f Diff: https://reviews.apache.org/r/58200/diff/4/ Changes: https://reviews.apache.org/r/58200/diff/3-4/ Testing --- 1. Build the image with latest code. Let's name the image with `mesos-build` here. 2. Launch mesos master. ``` $ docker run \ -it \ --pid host \ --net host \ --privileged \ -v /var/run/docker.sock:/var/run/docker.sock \ -v /sys/fs/cgroup:/sys/fs/cgroup \ mesos-build \ mesos-master \ --hostname=127.0.0.1 \ --ip=127.0.0.1 \ --port=5050 \ --work_dir=/tmp/mesos ``` 3. Launch mesos agent. ``` $ docker run \ -it \ --pid host \ --net host \ --privileged \ -v /var/run/docker.sock:/var/run/docker.sock \ -v /sys/fs/cgroup:/sys/fs/cgroup \ mesos-build \ mesos-agent \ --hostname=127.0.0.1 \ --ip=127.0.0.1 \ --master=127.0.0.1:5050 \ --systemd_enable_support=false \ --work_dir=/tmp/mesos \ --containerizers=docker,mesos \ --docker_mesos_image=mesos-build ``` 4. Launch task with health check. Define the task with health check. ``` $ cat /tmp/task.json { "name": "test-health-check", "task_id": {"value" : "test-health-check"}, "agent_id": {"value" : ""}, "resources": [ { "name": "cpus", "type": "SCALAR", "scalar": { "value": 0.1 }, "role": "*" }, { "name": "mem", "type": "SCALAR", "scalar": { "value": 32 }, "role": "*" } ], "command": { "value": "sleep 1000" }, "container": { "type": "DOCKER", "volumes": [], "docker": { "image": "mesos-build", "network": "HOST" } }, "health_check": { "type": "HTTP", "http": { "scheme": "http", "port": 5050 }, "gracePeriodSeconds": 300, "intervalSeconds": 60, "timeoutSeconds": 20, "maxConsecutiveFailures": 3 } } ``` Lauch task ``` $ mesos-execute --master=127.0.0.1:5050 --task=/tmp/task.json ``` And verified the healthy status of task is correct. ``` I0407 16:29:57.258509 88767 health_checker.cpp:123] Entered the net namespace of task (pid: '88727') successfully I0407 16:29:57.334801 88643 health_checker.cpp:395] Performed HTTP health check for task 'test-health-check' in 86.311186ms I0407 16:29:57.334872 88643 health_checker.cpp:319] HTTP health check for task 'test-health-check' passed ``` Thanks, Deshi Xiao
Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58200/ --- (Updated 四月 8, 2017, 11:12 a.m.) Review request for mesos, Alexander Rukletsov and haosdent huang. Changes --- Thanks haosdent. Summary (updated) - Fix mesos runs with docker(pid namespace mismatch). Bugs: MESOS-7210 https://issues.apache.org/jira/browse/MESOS-7210 Repository: mesos Description (updated) --- Becuase MESOS HTTP checks doesn't work when mesos runs with --docker_mesos_image ( pid namespace mismatch ).So let docker executor run with container add host pid mapping(--pid=host) Diffs (updated) - src/slave/containerizer/docker.cpp be1a298b12374bced44e2467cb7e90a1599abb8f Diff: https://reviews.apache.org/r/58200/diff/3/ Changes: https://reviews.apache.org/r/58200/diff/2-3/ Testing --- 1. Build the image with latest code. Let's name the image with `mesos-build` here. 2. Launch mesos master. ``` $ docker run \ -it \ --pid host \ --net host \ --privileged \ -v /var/run/docker.sock:/var/run/docker.sock \ -v /sys/fs/cgroup:/sys/fs/cgroup \ mesos-build \ mesos-master \ --hostname=127.0.0.1 \ --ip=127.0.0.1 \ --port=5050 \ --work_dir=/tmp/mesos ``` 3. Launch mesos agent. ``` $ docker run \ -it \ --pid host \ --net host \ --privileged \ -v /var/run/docker.sock:/var/run/docker.sock \ -v /sys/fs/cgroup:/sys/fs/cgroup \ mesos-build \ mesos-agent \ --hostname=127.0.0.1 \ --ip=127.0.0.1 \ --master=127.0.0.1:5050 \ --systemd_enable_support=false \ --work_dir=/tmp/mesos \ --containerizers=docker,mesos \ --docker_mesos_image=mesos-build ``` 4. Launch task with health check. Define the task with health check. ``` $ cat /tmp/task.json { "name": "test-health-check", "task_id": {"value" : "test-health-check"}, "agent_id": {"value" : ""}, "resources": [ { "name": "cpus", "type": "SCALAR", "scalar": { "value": 0.1 }, "role": "*" }, { "name": "mem", "type": "SCALAR", "scalar": { "value": 32 }, "role": "*" } ], "command": { "value": "sleep 1000" }, "container": { "type": "DOCKER", "volumes": [], "docker": { "image": "mesos-build", "network": "HOST" } }, "health_check": { "type": "HTTP", "http": { "scheme": "http", "port": 5050 }, "gracePeriodSeconds": 300, "intervalSeconds": 60, "timeoutSeconds": 20, "maxConsecutiveFailures": 3 } } ``` Lauch task ``` $ mesos-execute --master=127.0.0.1:5050 --task=/tmp/task.json ``` And verified the healthy status of task is correct. ``` I0407 16:29:57.258509 88767 health_checker.cpp:123] Entered the net namespace of task (pid: '88727') successfully I0407 16:29:57.334801 88643 health_checker.cpp:395] Performed HTTP health check for task 'test-health-check' in 86.311186ms I0407 16:29:57.334872 88643 health_checker.cpp:319] HTTP health check for task 'test-health-check' passed ``` Thanks, Deshi Xiao
Re: Review Request 58200: Augmented release guide with GPG goodies and a formatting reminder.
7637be863e734102ca431e1488d6397e4 src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp 39da15a512de9138aa01e319def906ad9348811d src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp d419a9ffc2d2724f876cb05b3eca492b72e2f003 src/slave/containerizer/mesos/isolators/posix.hpp 627004663cbd7223a252b875c51454a20e645be6 src/slave/containerizer/mesos/launch.cpp 395394f04982a7df58e32e9aeebb63756e85b89b src/slave/containerizer/mesos/launcher.hpp 79f6eea0ee8e564e90b36208672df150dbc5d540 src/slave/containerizer/mesos/launcher.cpp 5114c130efbfb252dde1e85c081f5174e66f57af src/slave/containerizer/mesos/linux_launcher.cpp 80c9ab2e297c88f1e75e6715b88ef9fa7e38b046 src/slave/flags.hpp 224fac1d06d5a3914d4d1408e880458ac5be010e src/slave/flags.cpp a7b23b570bb1eba0e4d3f4a10bced8582d87adff src/slave/main.cpp 81d61b14accca7611d84db92663a63d5777edd83 src/slave/slave.cpp 1c164c9d2e22868ddec80d26a31504333f483633 src/tests/cluster.cpp 7f09a0c8b93e8fa945e7b2c809624b12e61b4198 src/tests/container_logger_tests.cpp 4ccb2e4abf5623f5918526bf39ad99fb87869eaa src/tests/containerizer/composing_containerizer_tests.cpp 934824c61a857bdc4d2d8ef790b64a33d14eab9f src/tests/containerizer/mesos_containerizer_tests.cpp 9a5cfe49540fcb3364b4c57cb92fcd264e63cf36 src/tests/default_executor_tests.cpp 6dadd8937eb6809bcb0aca55fab1cb7f17c3262f src/tests/fetcher_cache_tests.cpp 49173af9fa1537b28784ae7543458e5b57e5180f src/tests/health_check_tests.cpp 211f8b8578e811d3f2a229387cc0ce8327ae8cb6 src/tests/http_authentication_tests.cpp 36d2b73fa3d0f65aed5e37fe661c93dd46132f82 src/tests/http_fault_tolerance_tests.cpp 4040d24e4b910ebda9337f760633e64ede06acf8 src/tests/partition_tests.cpp 3de37d272389f4e33cc246ac2654728ddf59016d src/tests/sorter_tests.cpp ec0636beb936d46a253d19322f2157abe95156b6 src/v1/mesos.cpp 5605ff22da77724a7947637bc17e12143ee34802 Diff: https://reviews.apache.org/r/58200/diff/2/ Changes: https://reviews.apache.org/r/58200/diff/1-2/ Testing --- 1. Build the image with latest code. Let's name the image with `mesos-build` here. 2. Launch mesos master. ``` $ docker run \ -it \ --pid host \ --net host \ --privileged \ -v /var/run/docker.sock:/var/run/docker.sock \ -v /sys/fs/cgroup:/sys/fs/cgroup \ mesos-build \ mesos-master \ --hostname=127.0.0.1 \ --ip=127.0.0.1 \ --port=5050 \ --work_dir=/tmp/mesos ``` 3. Launch mesos agent. ``` $ docker run \ -it \ --pid host \ --net host \ --privileged \ -v /var/run/docker.sock:/var/run/docker.sock \ -v /sys/fs/cgroup:/sys/fs/cgroup \ mesos-build \ mesos-agent \ --hostname=127.0.0.1 \ --ip=127.0.0.1 \ --master=127.0.0.1:5050 \ --systemd_enable_support=false \ --work_dir=/tmp/mesos \ --containerizers=docker,mesos \ --docker_mesos_image=mesos-build ``` 4. Launch task with health check. Define the task with health check. ``` $ cat /tmp/task.json { "name": "test-health-check", "task_id": {"value" : "test-health-check"}, "agent_id": {"value" : ""}, "resources": [ { "name": "cpus", "type": "SCALAR", "scalar": { "value": 0.1 }, "role": "*" }, { "name": "mem", "type": "SCALAR", "scalar": { "value": 32 }, "role": "*" } ], "command": { "value": "sleep 1000" }, "container": { "type": "DOCKER", "volumes": [], "docker": { "image": "mesos-build", "network": "HOST" } }, "health_check": { "type": "HTTP", "http": { "scheme": "http", "port": 5050 }, "gracePeriodSeconds": 300, "intervalSeconds": 60, "timeoutSeconds": 20, "maxConsecutiveFailures": 3 } } ``` Lauch task ``` $ mesos-execute --master=127.0.0.1:5050 --task=/tmp/task.json ``` And verified the healthy status of task is correct. ``` I0407 16:29:57.258509 88767 health_checker.cpp:123] Entered the net namespace of task (pid: '88727') successfully I0407 16:29:57.334801 88643 health_checker.cpp:395] Performed HTTP health check for task 'test-health-check' in 86.311186ms I0407 16:29:57.334872 88643 health_checker.cpp:319] HTTP health check for task 'test-health-check' passed ``` Thanks, Deshi Xiao
Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58200/ --- (Updated April 7, 2017, 4:40 p.m.) Review request for mesos, Alexander Rukletsov and haosdent huang. Bugs: MESOS-7210 https://issues.apache.org/jira/browse/MESOS-7210 Repository: mesos Description --- Becuase MESOS HTTP checks doesn't work when mesos runs with --docker_mesos_image ( pid namespace mismatch ).So let docker executor run with container add host pid mapping(--pid=host) Diffs - src/slave/containerizer/docker.cpp ad9ab847cb3093724ef374d036c896b4e7f18b5e Diff: https://reviews.apache.org/r/58200/diff/1/ Testing (updated) --- 1. Build the image with latest code. Let's name the image with `mesos-build` here. 2. Launch mesos master. ``` $ docker run \ -it \ --pid host \ --net host \ --privileged \ -v /var/run/docker.sock:/var/run/docker.sock \ -v /sys/fs/cgroup:/sys/fs/cgroup \ mesos-build \ mesos-master \ --hostname=127.0.0.1 \ --ip=127.0.0.1 \ --port=5050 \ --work_dir=/tmp/mesos ``` 3. Launch mesos agent. ``` $ docker run \ -it \ --pid host \ --net host \ --privileged \ -v /var/run/docker.sock:/var/run/docker.sock \ -v /sys/fs/cgroup:/sys/fs/cgroup \ mesos-build \ mesos-agent \ --hostname=127.0.0.1 \ --ip=127.0.0.1 \ --master=127.0.0.1:5050 \ --systemd_enable_support=false \ --work_dir=/tmp/mesos \ --containerizers=docker,mesos \ --docker_mesos_image=mesos-build ``` 4. Launch task with health check. Define the task with health check. ``` $ cat /tmp/task.json { "name": "test-health-check", "task_id": {"value" : "test-health-check"}, "agent_id": {"value" : ""}, "resources": [ { "name": "cpus", "type": "SCALAR", "scalar": { "value": 0.1 }, "role": "*" }, { "name": "mem", "type": "SCALAR", "scalar": { "value": 32 }, "role": "*" } ], "command": { "value": "sleep 1000" }, "container": { "type": "DOCKER", "volumes": [], "docker": { "image": "mesos-build", "network": "HOST" } }, "health_check": { "type": "HTTP", "http": { "scheme": "http", "port": 5050 }, "gracePeriodSeconds": 300, "intervalSeconds": 60, "timeoutSeconds": 20, "maxConsecutiveFailures": 3 } } ``` Lauch task ``` $ mesos-execute --master=127.0.0.1:5050 --task=/tmp/task.json ``` And verified the healthy status of task is correct. ``` I0407 16:29:57.258509 88767 health_checker.cpp:123] Entered the net namespace of task (pid: '88727') successfully I0407 16:29:57.334801 88643 health_checker.cpp:395] Performed HTTP health check for task 'test-health-check' in 86.311186ms I0407 16:29:57.334872 88643 health_checker.cpp:319] HTTP health check for task 'test-health-check' passed ``` Thanks, Deshi Xiao
Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58200/ --- (Updated 四月 5, 2017, 11:35 p.m.) Review request for mesos, Alexander Rukletsov and haosdent huang. Bugs: MESOS-7210 https://issues.apache.org/jira/browse/MESOS-7210 Repository: mesos Description --- Becuase MESOS HTTP checks doesn't work when mesos runs with --docker_mesos_image ( pid namespace mismatch ).So let docker executor run with container add host pid mapping(--pid=host) Diffs - src/slave/containerizer/docker.cpp ad9ab847cb3093724ef374d036c896b4e7f18b5e Diff: https://reviews.apache.org/r/58200/diff/1/ Testing (updated) --- first testing : https://gist.github.com/xiaods/c5a11e3ab51e89a9609edc2c477f7ea8 Thanks, Deshi Xiao
Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58200/ --- Review request for mesos, Alexander Rukletsov and haosdent huang. Bugs: mesos-7210 https://issues.apache.org/jira/browse/mesos-7210 Repository: mesos Description --- Becuase MESOS HTTP checks doesn't work when mesos runs with --docker_mesos_image ( pid namespace mismatch ).So let docker executor run with container add host pid mapping(--pid=host) Diffs - src/slave/containerizer/docker.cpp ad9ab847cb3093724ef374d036c896b4e7f18b5e Diff: https://reviews.apache.org/r/58200/diff/1/ Testing --- Thanks, Deshi Xiao
Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50629/#review160272 --- good for me. - Deshi Xiao On 七月 30, 2016, 6 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50629/ > --- > > (Updated 七月 30, 2016, 6 p.m.) > > > Review request for mesos, haosdent huang and Deshi Xiao. > > > Bugs: MESOS-5186 > https://issues.apache.org/jira/browse/MESOS-5186 > > > Repository: mesos > > > Description > --- > > This fix updated the requirement in `python/interface/setup.py.in` > so that protobuf 3.0 is allowed. > > > Diffs > - > > src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa > > Diff: https://reviews.apache.org/r/50629/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.
> On 三月 30, 2016, 9:08 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 3541-3545 > > <https://reviews.apache.org/r/45474/diff/3/?file=1318849#file1318849line3541> > > > > Here you shutdown the slave and wait (you'll probably want to advance > > the clock rather than wait for 90s) for the slave to be declared > > SLAVE_LOST. Once this occurs, the master will no longer allow the slave to > > reregister with the same slaveId, and the slave will be told to kill all > > running tasks. The slave will do so and then restart and register as a new > > slaveId. > > This is what is meant by the quote from the design doc: "Currently this > > can only be handled by stopping / draining a mesos slave entirely (Killing > > all of its running jobs), removing it from the cluster, then bringing it > > back up as a brand new slave." > > > > To truly observe this behavior, you should start a task on the slave > > before you shut it down. Then you will see a TASK_LOST and the task will be > > killed. > > Deshi Xiao wrote: > Thanks Adam, i will udpate the test case. @Adam B Here i have a confuse,need your guide. use test case to track the TASK_LOST in restart slave. do we expect keep the slave_id is not outdate? - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126066 --- On 三月 30, 2016, 8:13 a.m., Deshi Xiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45474/ > --- > > (Updated 三月 30, 2016, 8:13 a.m.) > > > Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu. > > > Bugs: MESOS-1739 > https://issues.apache.org/jira/browse/MESOS-1739 > > > Repository: mesos > > > Description > --- > > Phase 1 > Make SlaveInfo mutable throughout the stack, and allow for expansion of > resources and attributes only (Which allows testing to make sure it > propagates to the allocator, shows up in offers, etc). Ensure there is > unified checking for incompatibilities in both the slave and master (the > slave should validate the config, the master should validate that all > operations the slave takes are legal). > > it derived from another PR(https://reviews.apache.org/r/25525/) > > > Diffs > - > > src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a > > Diff: https://reviews.apache.org/r/45474/diff/ > > > Testing > --- > > make check on localhost > > > Thanks, > > Deshi Xiao > >
Re: Review Request 45500: Keep fs::mount information should be consolidated.
> On 四月 21, 2016, 5:45 p.m., haosdent huang wrote: > > src/tests/containerizer/fs_tests.cpp, line 37 > > <https://reviews.apache.org/r/45500/diff/7/?file=1341124#file1341124line37> > > > > I think need remove this blank line. are u sure? 36 using fs::FileSystemTable; 37 38 namespace mesos { - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review129929 --- On 四月 12, 2016, 11:49 a.m., Deshi Xiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45500/ > --- > > (Updated 四月 12, 2016, 11:49 a.m.) > > > Review request for mesos, haosdent huang and Cong Wang. > > > Bugs: MESOS-1104 > https://issues.apache.org/jira/browse/MESOS-1104 > > > Repository: mesos > > > Description > --- > > keep fs::mount information should be consolidated and moved to stout, > along with mount and umount. > > Refers to Benjamin Hindman's TODO: > https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64 > > > Diffs > - > > src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 > src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 > src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f > src/slave/containerizer/mesos/mount.cpp > bf17b015e45579882fd31248e8609eec6d58a9da > src/tests/containerizer/fs_tests.cpp > 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 > src/tests/containerizer/port_mapping_tests.cpp > 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf > > Diff: https://reviews.apache.org/r/45500/diff/ > > > Testing > --- > > make test on localhost(ubuntu) > > > Thanks, > > Deshi Xiao > >
Re: Review Request 45500: Keep fs::mount information should be consolidated.
> On 四月 6, 2016, 9:04 p.m., Neil Conway wrote: > > src/tests/containerizer/fs_tests.cpp, line 35 > > <https://reviews.apache.org/r/45500/diff/3/?file=1321860#file1321860line35> > > > > Not yours, but we should sort these alphabetically. @Neil Conway how aobut your feedback. - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review127447 --- On 四月 12, 2016, 11:49 a.m., Deshi Xiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45500/ > --- > > (Updated 四月 12, 2016, 11:49 a.m.) > > > Review request for mesos, haosdent huang and Cong Wang. > > > Bugs: MESOS-1104 > https://issues.apache.org/jira/browse/MESOS-1104 > > > Repository: mesos > > > Description > --- > > keep fs::mount information should be consolidated and moved to stout, > along with mount and umount. > > Refers to Benjamin Hindman's TODO: > https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64 > > > Diffs > - > > src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 > src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 > src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f > src/slave/containerizer/mesos/mount.cpp > bf17b015e45579882fd31248e8609eec6d58a9da > src/tests/containerizer/fs_tests.cpp > 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 > src/tests/containerizer/port_mapping_tests.cpp > 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf > > Diff: https://reviews.apache.org/r/45500/diff/ > > > Testing > --- > > make test on localhost(ubuntu) > > > Thanks, > > Deshi Xiao > >
Re: Review Request 45500: Keep fs::mount information should be consolidated.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 12, 2016, 11:49 a.m.) Review request for mesos, haosdent huang and Cong Wang. Bugs: MESOS-1104 https://issues.apache.org/jira/browse/MESOS-1104 Repository: mesos Description (updated) --- keep fs::mount information should be consolidated and moved to stout, along with mount and umount. Refers to Benjamin Hindman's TODO: https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64 Diffs (updated) - src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 src/tests/containerizer/port_mapping_tests.cpp 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf Diff: https://reviews.apache.org/r/45500/diff/ Testing --- make test on localhost(ubuntu) Thanks, Deshi Xiao
Re: Review Request 45500: Keep fs::mount information should be consolidated.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 12, 2016, 9:33 a.m.) Review request for mesos, haosdent huang and Cong Wang. Bugs: MESOS-1104 https://issues.apache.org/jira/browse/MESOS-1104 Repository: mesos Description --- keep fs::mount information should be consolidated and moved to stout, along with mount and umount. This JIRA refers to this TODO from Benjamin Hindman: https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64 Diffs (updated) - src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 src/tests/containerizer/port_mapping_tests.cpp e062daa9fcfc776144b48325daa1f1284c5e59a4 Diff: https://reviews.apache.org/r/45500/diff/ Testing --- make test on localhost(ubuntu) Thanks, Deshi Xiao
Re: Review Request 45500: Keep fs::mount information should be consolidated.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 11, 2016, 7:23 a.m.) Review request for mesos, haosdent huang and Cong Wang. Summary (updated) - Keep fs::mount information should be consolidated. Bugs: MESOS-1104 https://issues.apache.org/jira/browse/MESOS-1104 Repository: mesos Description (updated) --- keep fs::mount information should be consolidated and moved to stout, along with mount and umount. This JIRA refers to this TODO from Benjamin Hindman: https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64 Diffs (updated) - src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 src/tests/containerizer/port_mapping_tests.cpp e062daa9fcfc776144b48325daa1f1284c5e59a4 Diff: https://reviews.apache.org/r/45500/diff/ Testing --- make test on localhost(ubuntu) Thanks, Deshi Xiao
Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 11, 2016, 7:15 a.m.) Review request for mesos, haosdent huang and Cong Wang. Bugs: MESOS-1104 https://issues.apache.org/jira/browse/MESOS-1104 Repository: mesos Description (updated) --- Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough. Diffs (updated) - src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 src/tests/containerizer/port_mapping_tests.cpp e062daa9fcfc776144b48325daa1f1284c5e59a4 Diff: https://reviews.apache.org/r/45500/diff/ Testing --- make test on localhost(ubuntu) Thanks, Deshi Xiao
Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 1, 2016, 5:19 a.m.) Review request for mesos, haosdent huang and Cong Wang. Bugs: MESOS-1104 https://issues.apache.org/jira/browse/MESOS-1104 Repository: mesos Description --- follow haosdent's suggest, remove mesos::internal:: should be enough. Diffs - src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 src/tests/containerizer/port_mapping_tests.cpp e062daa9fcfc776144b48325daa1f1284c5e59a4 Diff: https://reviews.apache.org/r/45500/diff/ Testing (updated) --- make test on localhost(ubuntu) Thanks, Deshi Xiao
Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 1, 2016, 5:17 a.m.) Review request for mesos, haosdent huang and Cong Wang. Bugs: MESOS-1104 https://issues.apache.org/jira/browse/MESOS-1104 Repository: mesos Description (updated) --- follow haosdent's suggest, remove mesos::internal:: should be enough. Diffs (updated) - src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 src/tests/containerizer/port_mapping_tests.cpp e062daa9fcfc776144b48325daa1f1284c5e59a4 Diff: https://reviews.apache.org/r/45500/diff/ Testing --- will testing on Linux(ubuntu,centos) Thanks, Deshi Xiao
Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 1, 2016, 5:08 a.m.) Review request for mesos, haosdent huang and Cong Wang. Bugs: MESOS-1104 https://issues.apache.org/jira/browse/MESOS-1104 Repository: mesos Description --- other exists code under src/linux/, e.g. perf.hpp, ns.hpp I think remove mesos::internal:: should be enough. Diffs - src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 src/tests/containerizer/port_mapping_tests.cpp e062daa9fcfc776144b48325daa1f1284c5e59a4 Diff: https://reviews.apache.org/r/45500/diff/ Testing --- will testing on Linux(ubuntu,centos) Thanks, Deshi Xiao
Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 1, 2016, 5:07 a.m.) Review request for mesos, haosdent huang and Cong Wang. Bugs: MESOS-1104 https://issues.apache.org/jira/browse/MESOS-1104 Repository: mesos Description --- other exists code under src/linux/, e.g. perf.hpp, ns.hpp I think remove mesos::internal:: should be enough. Diffs - src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 src/tests/containerizer/port_mapping_tests.cpp e062daa9fcfc776144b48325daa1f1284c5e59a4 Diff: https://reviews.apache.org/r/45500/diff/ Testing --- will testing on Linux(ubuntu,centos) File Attachments (updated) cgroups.cpp https://reviews.apache.org/media/uploaded/files/2016/04/01/c782c054-1e37-4f92-ae03-55841eca9c05__cgroups.cpp Thanks, Deshi Xiao
Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 三月 31, 2016, 10:50 a.m.) Review request for mesos, haosdent huang and Cong Wang. Bugs: MESOS-1104 https://issues.apache.org/jira/browse/MESOS-1104 Repository: mesos Description --- other exists code under src/linux/, e.g. perf.hpp, ns.hpp I think remove mesos::internal:: should be enough. Diffs - src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 src/tests/containerizer/port_mapping_tests.cpp e062daa9fcfc776144b48325daa1f1284c5e59a4 Diff: https://reviews.apache.org/r/45500/diff/ Testing (updated) --- will testing on Linux(ubuntu,centos) Thanks, Deshi Xiao
Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.
> On 三月 31, 2016, 2:03 a.m., Jie Yu wrote: > > This is a high level question: I am now sure if adding attributes is safe > > or not. For instance, my framework has the following rule: only schedule > > tasks to agents that do not have attribute "not_safe". Now, say agent A is > > initially without that attribute. My framework lands several tasks on that > > agent. Later, when agent restarts, the operator adds the new attribute > > "not_safe". Suddently, i have tasks running on unsafe boxes. oops. I think so, this is very common case. it need more detail discussion with team. - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126242 ------- On 三月 30, 2016, 8:13 a.m., Deshi Xiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45474/ > --- > > (Updated 三月 30, 2016, 8:13 a.m.) > > > Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu. > > > Bugs: MESOS-1739 > https://issues.apache.org/jira/browse/MESOS-1739 > > > Repository: mesos > > > Description > --- > > Phase 1 > Make SlaveInfo mutable throughout the stack, and allow for expansion of > resources and attributes only (Which allows testing to make sure it > propagates to the allocator, shows up in offers, etc). Ensure there is > unified checking for incompatibilities in both the slave and master (the > slave should validate the config, the master should validate that all > operations the slave takes are legal). > > it derived from another PR(https://reviews.apache.org/r/25525/) > > > Diffs > - > > src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a > > Diff: https://reviews.apache.org/r/45474/diff/ > > > Testing > --- > > make check on localhost > > > Thanks, > > Deshi Xiao > >
Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 三月 31, 2016, 3:38 a.m.) Review request for mesos, haosdent huang and Cong Wang. Bugs: MESOS-1104 https://issues.apache.org/jira/browse/MESOS-1104 Repository: mesos Description --- other exists code under src/linux/, e.g. perf.hpp, ns.hpp I think remove mesos::internal:: should be enough. Diffs (updated) - src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 src/tests/containerizer/port_mapping_tests.cpp e062daa9fcfc776144b48325daa1f1284c5e59a4 Diff: https://reviews.apache.org/r/45500/diff/ Testing --- make check on localhost(centos) Thanks, Deshi Xiao
Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
> On 三月 30, 2016, 6:40 p.m., Cong Wang wrote: > > You must be joking when you say you tested this Linux change on your osx... > > Deshi Xiao wrote: > Oops. let me testing it again on centos. Wang Cong, are u a ex-redhatter? if u have alternative linux, please help testing with the changes. thanks a lot. - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review126169 --- On 三月 30, 2016, 6:47 p.m., Deshi Xiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45500/ > --- > > (Updated 三月 30, 2016, 6:47 p.m.) > > > Review request for mesos, haosdent huang and Cong Wang. > > > Bugs: MESOS-1104 > https://issues.apache.org/jira/browse/MESOS-1104 > > > Repository: mesos > > > Description > --- > > other exists code under src/linux/, e.g. perf.hpp, ns.hpp > I think remove mesos::internal:: should be enough. > > > Diffs > - > > src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 > > Diff: https://reviews.apache.org/r/45500/diff/ > > > Testing > --- > > make check on localhost(centos) > > > Thanks, > > Deshi Xiao > >
Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 三月 30, 2016, 6:44 p.m.) Review request for mesos and haosdent huang. Bugs: MESOS-1104 https://issues.apache.org/jira/browse/MESOS-1104 Repository: mesos Description --- other exists code under src/linux/, e.g. perf.hpp, ns.hpp I think remove mesos::internal:: should be enough. Diffs - src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 Diff: https://reviews.apache.org/r/45500/diff/ Testing (updated) --- make check on localhost(centos) Thanks, Deshi Xiao
Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
> On 三月 30, 2016, 6:40 p.m., Cong Wang wrote: > > You must be joking when you say you tested this Linux change on your osx... Oops. let me testing it again on centos. - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review126169 --- On 三月 30, 2016, 6:34 p.m., Deshi Xiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45500/ > --- > > (Updated 三月 30, 2016, 6:34 p.m.) > > > Review request for mesos and haosdent huang. > > > Bugs: MESOS-1104 > https://issues.apache.org/jira/browse/MESOS-1104 > > > Repository: mesos > > > Description > --- > > other exists code under src/linux/, e.g. perf.hpp, ns.hpp > I think remove mesos::internal:: should be enough. > > > Diffs > - > > src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 > > Diff: https://reviews.apache.org/r/45500/diff/ > > > Testing > --- > > make check on mac_osx 11 > > > Thanks, > > Deshi Xiao > >
Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- Review request for mesos and haosdent huang. Bugs: MESOS-1104 https://issues.apache.org/jira/browse/MESOS-1104 Repository: mesos Description --- other exists code under src/linux/, e.g. perf.hpp, ns.hpp I think remove mesos::internal:: should be enough. Diffs - src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 Diff: https://reviews.apache.org/r/45500/diff/ Testing --- make check on mac_osx 11 Thanks, Deshi Xiao
Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.
> On 三月 30, 2016, 9:08 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 3541-3545 > > <https://reviews.apache.org/r/45474/diff/3/?file=1318849#file1318849line3541> > > > > Here you shutdown the slave and wait (you'll probably want to advance > > the clock rather than wait for 90s) for the slave to be declared > > SLAVE_LOST. Once this occurs, the master will no longer allow the slave to > > reregister with the same slaveId, and the slave will be told to kill all > > running tasks. The slave will do so and then restart and register as a new > > slaveId. > > This is what is meant by the quote from the design doc: "Currently this > > can only be handled by stopping / draining a mesos slave entirely (Killing > > all of its running jobs), removing it from the cluster, then bringing it > > back up as a brand new slave." > > > > To truly observe this behavior, you should start a task on the slave > > before you shut it down. Then you will see a TASK_LOST and the task will be > > killed. Thanks Adam, i will udpate the test case. - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126066 --- On 三月 30, 2016, 8:13 a.m., Deshi Xiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45474/ > --- > > (Updated 三月 30, 2016, 8:13 a.m.) > > > Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu. > > > Bugs: MESOS-1739 > https://issues.apache.org/jira/browse/MESOS-1739 > > > Repository: mesos > > > Description > --- > > Phase 1 > Make SlaveInfo mutable throughout the stack, and allow for expansion of > resources and attributes only (Which allows testing to make sure it > propagates to the allocator, shows up in offers, etc). Ensure there is > unified checking for incompatibilities in both the slave and master (the > slave should validate the config, the master should validate that all > operations the slave takes are legal). > > it derived from another PR(https://reviews.apache.org/r/25525/) > > > Diffs > - > > src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a > > Diff: https://reviews.apache.org/r/45474/diff/ > > > Testing > --- > > make check on localhost > > > Thanks, > > Deshi Xiao > >
Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.
> On 三月 30, 2016, 6:52 a.m., haosdent huang wrote: > > I think the better place to put this test case is > > `slave_recovery_tests.cpp`. i don't think so. the test aim to focus on reconfiguration from restart slave. it doesn't care the recovery state. - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126042 --- On 三月 30, 2016, 7:03 a.m., Deshi Xiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45474/ > --- > > (Updated 三月 30, 2016, 7:03 a.m.) > > > Review request for mesos and haosdent huang. > > > Bugs: MESOS-1739 > https://issues.apache.org/jira/browse/MESOS-1739 > > > Repository: mesos > > > Description > --- > > Phase 1 > Make SlaveInfo mutable throughout the stack, and allow for expansion of > resources and attributes only (Which allows testing to make sure it > propagates to the allocator, shows up in offers, etc). Ensure there is > unified checking for incompatibilities in both the slave and master (the > slave should validate the config, the master should validate that all > operations the slave takes are legal). > > it derived from another PR(https://reviews.apache.org/r/25525/) > > > Diffs > - > > src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a > > Diff: https://reviews.apache.org/r/45474/diff/ > > > Testing > --- > > make check on localhost > > > Thanks, > > Deshi Xiao > >
Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/ --- (Updated 三月 30, 2016, 7:03 a.m.) Review request for mesos and haosdent huang. Changes --- adopted from haosdent's comments. Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos Description --- Phase 1 Make SlaveInfo mutable throughout the stack, and allow for expansion of resources and attributes only (Which allows testing to make sure it propagates to the allocator, shows up in offers, etc). Ensure there is unified checking for incompatibilities in both the slave and master (the slave should validate the config, the master should validate that all operations the slave takes are legal). it derived from another PR(https://reviews.apache.org/r/25525/) Diffs (updated) - src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a Diff: https://reviews.apache.org/r/45474/diff/ Testing --- make check on localhost Thanks, Deshi Xiao
Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/ --- (Updated 三月 30, 2016, 6:52 a.m.) Review request for mesos. Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos Description --- Phase 1 Make SlaveInfo mutable throughout the stack, and allow for expansion of resources and attributes only (Which allows testing to make sure it propagates to the allocator, shows up in offers, etc). Ensure there is unified checking for incompatibilities in both the slave and master (the slave should validate the config, the master should validate that all operations the slave takes are legal). it derived from another PR(https://reviews.apache.org/r/25525/) Diffs (updated) - src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a Diff: https://reviews.apache.org/r/45474/diff/ Testing --- make check on localhost Thanks, Deshi Xiao
Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/ --- Review request for mesos. Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos Description --- Phase 1 Make SlaveInfo mutable throughout the stack, and allow for expansion of resources and attributes only (Which allows testing to make sure it propagates to the allocator, shows up in offers, etc). Ensure there is unified checking for incompatibilities in both the slave and master (the slave should validate the config, the master should validate that all operations the slave takes are legal). it derived from another PR(https://reviews.apache.org/r/25525/) Diffs - src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a Diff: https://reviews.apache.org/r/45474/diff/ Testing --- make check on localhost Thanks, Deshi Xiao
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
> On 三月 23, 2016, 8:21 a.m., Deshi Xiao wrote: > > can we ignore .md scan? the .md possible container non-ascii characters. > > Neil Conway wrote: > Are non-ASCII characters in .md files actually required? We should be > able to use HTML character entities instead (e.g., `Ӓ`) instead. > > Deshi Xiao wrote: > Neil, see this case: > > quoted from haosdent's comments: > If disable no-ascii characters, we could not use emoji and some > languages which contains no-ascii characters. For the powered-by-mesos.md and > user-groups.html.md, this hard limit seems inconvenient. > > haosdent huang wrote: > Still could convert them to unicode code and represented by html > character entities. Just looks confuse and not straightforward. > > Deshi Xiao wrote: > same here same concerns > > Neil Conway wrote: > Personally I would opt for allowing only ASCII characters in .md files > and using character entities for the (rare) cases where non-ASCII characters > are required. if we can strict the md only contain ASCII characters, the opt for is fine. so here we need a shepherd to help us guideline the way. - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124992 --- On 三月 23, 2016, 2:46 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated 三月 23, 2016, 2:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, haosdent > huang, Neil Conway, and Deshi Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add a commit hook for checking non-ascii > characters. It scans .cpp, .hpp, .cc, .h files and report > error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > Note: .md scan is skipped based on feedback from review request. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 > support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 > support/non-ascii.py PRE-CREATION > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
> On 三月 23, 2016, 8:21 a.m., Deshi Xiao wrote: > > can we ignore .md scan? the .md possible container non-ascii characters. > > Neil Conway wrote: > Are non-ASCII characters in .md files actually required? We should be > able to use HTML character entities instead (e.g., `Ӓ`) instead. > > Deshi Xiao wrote: > Neil, see this case: > > quoted from haosdent's comments: > If disable no-ascii characters, we could not use emoji and some > languages which contains no-ascii characters. For the powered-by-mesos.md and > user-groups.html.md, this hard limit seems inconvenient. > > haosdent huang wrote: > Still could convert them to unicode code and represented by html > character entities. Just looks confuse and not straightforward. same here same concerns - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124992 --- On 三月 23, 2016, 2:46 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated 三月 23, 2016, 2:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, haosdent > huang, Neil Conway, and Deshi Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add a commit hook for checking non-ascii > characters. It scans .cpp, .hpp, .cc, .h files and report > error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > Note: .md scan is skipped based on feedback from review request. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 > support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 > support/non-ascii.py PRE-CREATION > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
> On 三月 23, 2016, 8:21 a.m., Deshi Xiao wrote: > > can we ignore .md scan? the .md possible container non-ascii characters. > > Neil Conway wrote: > Are non-ASCII characters in .md files actually required? We should be > able to use HTML character entities instead (e.g., `Ӓ`) instead. Neil, see this case: quoted from haosdent's comments: If disable no-ascii characters, we could not use emoji and some languages which contains no-ascii characters. For the powered-by-mesos.md and user-groups.html.md, this hard limit seems inconvenient. - Deshi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124992 --- On 三月 23, 2016, 2:46 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated 三月 23, 2016, 2:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, haosdent > huang, Neil Conway, and Deshi Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add a commit hook for checking non-ascii > characters. It scans .cpp, .hpp, .cc, .h files and report > error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > Note: .md scan is skipped based on feedback from review request. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 > support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 > support/non-ascii.py PRE-CREATION > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124992 --- can we ignore .md scan? the .md possible container non-ascii characters. - Deshi Xiao On 三月 22, 2016, 11:49 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated 三月 22, 2016, 11:49 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, haosdent > huang, Neil Conway, and Deshi Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add a commit hook for checking non-ascii > characters. It scans .cpp, .hpp, .cc, .h, and .md files and report > error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 > support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 > support/non-ascii.py PRE-CREATION > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >