Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated March 2, 2016, 6:15 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. Changes --- More changes to handle rename in automake of leveldb to leveldb-1.4. Bugs: MESOS-4746 https://issues.apache.org/jira/browse/MESOS-4746 Repository: mesos Description --- CMake: Add leveldb library to 3rdparty external builds. Diffs (updated) - 3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 3rdparty/cmake/Mesos3rdpartyConfigure.cmake aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 3rdparty/leveldb-1.4.tar.gz PRE-CREATION 3rdparty/leveldb.patch 3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 LICENSE c3aaa437af10533132698df3348114195d338965 src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 Diff: https://reviews.apache.org/r/43889/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated March 2, 2016, 12:52 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. Summary (updated) - CMake: Add leveldb library to 3rdparty external builds. Bugs: MESOS-4746 https://issues.apache.org/jira/browse/MESOS-4746 Repository: mesos Description (updated) --- CMake: Add leveldb library to 3rdparty external builds. Diffs (updated) - 3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 3rdparty/cmake/Mesos3rdpartyConfigure.cmake aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 3rdparty/leveldb-1.4.tar.gz PRE-CREATION 3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 Diff: https://reviews.apache.org/r/43889/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Re: Review Request 43995: CMake: CompilationConfigure-Creating MACROS to get time and date.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43995/ --- (Updated Feb. 26, 2016, 3:16 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Removed unnecessary dependency. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description --- CMake: CompilationConfigure-Creating MACROS to get time and date. Diffs - cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b Diff: https://reviews.apache.org/r/43995/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Re: Review Request 44044: CMake: src CMakeLists-Added source to build master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44044/ --- (Updated Feb. 26, 2016, 3:10 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Added leveldb dependencies. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description --- CMake: src CMakeLists-Added source to build master. Diffs - src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a Diff: https://reviews.apache.org/r/44044/diff/ Testing --- "mesos-master" builds on Ubuntu. Thanks, Diana Arroyo
Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.
> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote: > > 3rdparty/libprocess/cmake/macros/External.cmake, line 38 > > <https://reviews.apache.org/r/43889/diff/1/?file=1265841#file1265841line38> > > > > And why we need change `EXTERNAL` macro here? I prososal add a version > > to our leveldb.tar.gz > > Diana Arroyo wrote: > I expect we will need to get an agreement with the folks who maintain the > make build. Who is the person that need to be pulled into this discussion? > > haosdent huang wrote: > I think maybe @tillt I added @tillt to the reviewers. Will await response. - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review120353 ------- On Feb. 25, 2016, 7:42 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43889/ > --- > > (Updated Feb. 25, 2016, 7:42 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, Joseph Wu, and Till Toenshoff. > > > Bugs: MESOS-4746 > https://issues.apache.org/jira/browse/MESOS-4746 > > > Repository: mesos > > > Description > --- > > CMAKE: Add leveldb library to 3rdparty external builds. > > > Diffs > - > > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > 0c80fb8d799ea1252492cd98ac0780f1228aadcd > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 3a2e0999722007475c023ade75719093e35cfc80 > 3rdparty/libprocess/cmake/macros/External.cmake > e3901b67048f1c028216ae8323ee1c318a46f3cc > > Diff: https://reviews.apache.org/r/43889/diff/ > > > Testing > --- > > Tested on Ubuntu. > > > Thanks, > > Diana Arroyo > >
Review Request 44044: CMake: src CMakeLists-Added source to build master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44044/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description --- CMake: src CMakeLists-Added source to build master. Diffs - src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a Diff: https://reviews.apache.org/r/44044/diff/ Testing --- "mesos-master" builds on Ubuntu. Thanks, Diana Arroyo
Re: Review Request 44001: CMake: Add MasterConfigure for master executable build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44001/ --- (Updated Feb. 25, 2016, 8:53 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Added check to call FindApr and FindSvn in non-windows build environment. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description --- CMake: Add MasterConfigure for master executable build. Diffs (updated) - src/master/cmake/MasterConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/44001/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Re: Review Request 44001: CMake: Add MasterConfigure for master executable build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44001/ --- (Updated Feb. 25, 2016, 8:13 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Added a check for non-windows before making the call to FindApr and FindSvn. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description --- CMake: Add MasterConfigure for master executable build. Diffs (updated) - src/master/cmake/MasterConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/44001/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated Feb. 25, 2016, 7:42 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. Changes --- Corrected LEVELDB_LIB to point to leveldb library. Bugs: MESOS-4746 https://issues.apache.org/jira/browse/MESOS-4746 Repository: mesos Description --- CMAKE: Add leveldb library to 3rdparty external builds. Diffs (updated) - 3rdparty/cmake/Mesos3rdpartyConfigure.cmake 0c80fb8d799ea1252492cd98ac0780f1228aadcd 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3a2e0999722007475c023ade75719093e35cfc80 3rdparty/libprocess/cmake/macros/External.cmake e3901b67048f1c028216ae8323ee1c318a46f3cc Diff: https://reviews.apache.org/r/43889/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Re: Review Request 43995: CMake: CompilationConfigure-Creating MACROS to get time and date.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43995/ --- (Updated Feb. 25, 2016, 6:04 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Added escaped quotes to return value in macros. Summary (updated) - CMake: CompilationConfigure-Creating MACROS to get time and date. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description (updated) --- CMake: CompilationConfigure-Creating MACROS to get time and date. Diffs (updated) - cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b Diff: https://reviews.apache.org/r/43995/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Review Request 44005: CMake: StoutTestsConfigure-removed FindApr & FindSvn, moved to master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44005/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description --- CMake: StoutTestsConfigure-removed FindApr & FindSvn, moved to master. Diffs - 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake a27cb98fa45cbd135ebfeca65e215fb3ff054739 Diff: https://reviews.apache.org/r/44005/diff/ Testing --- Tested on Ubuntu along with: https://reviews.apache.org/r/44007/ https://reviews.apache.org/r/44008/ Thanks, Diana Arroyo
Review Request 44008: CMake: Top CMakeLists-add master to cmake module path.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44008/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description --- CMake: Top CMakeLists-add master to cmake module path. Diffs - CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053 Diff: https://reviews.apache.org/r/44008/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Review Request 44007: CMake: MesosConfigure-add include of master configure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44007/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description --- CMake: MesosConfigure-add include of master configure. Diffs - cmake/MesosConfigure.cmake 9a4fdb57e1281d9ec421e639819de5786c11744a Diff: https://reviews.apache.org/r/44007/diff/ Testing --- Tested on Ubuntu along with: https://reviews.apache.org/r/44008/ Thanks, Diana Arroyo
Review Request 44003: CMake: Add CMakeLists for master executable build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44003/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description --- CMake: Add CMakeLists for master executable build. Diffs - src/master/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/44003/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Review Request 44001: CMake: Add MasterConfigure for master executable build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44001/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description --- CMake: Add MasterConfigure for master executable build. Diffs - src/master/cmake/MasterConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/44001/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Review Request 43997: CMake: Move FindApr and FindSvn to master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43997/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description --- CMake: Move FindApr and FindSvn to master. Diffs - src/master/cmake/FindApr.cmake PRE-CREATION src/master/cmake/FindSvn.cmake PRE-CREATION Diff: https://reviews.apache.org/r/43997/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated Feb. 25, 2016, 8:22 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. Changes --- Corrected LEVELDB_LIB definition. Summary (updated) - CMAKE: Add leveldb library to 3rdparty external builds. Bugs: MESOS-4746 https://issues.apache.org/jira/browse/MESOS-4746 Repository: mesos Description (updated) --- CMAKE: Add leveldb library to 3rdparty external builds. Diffs (updated) - 3rdparty/cmake/Mesos3rdpartyConfigure.cmake 0c80fb8d799ea1252492cd98ac0780f1228aadcd 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3a2e0999722007475c023ade75719093e35cfc80 3rdparty/libprocess/cmake/macros/External.cmake e3901b67048f1c028216ae8323ee1c318a46f3cc Diff: https://reviews.apache.org/r/43889/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Review Request 43995: CMake: Creating MACROS to get time and date.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43995/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4773 https://issues.apache.org/jira/browse/MESOS-4773 Repository: mesos Description --- CMake: Creating MACROS to get time and date. Diffs - cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b Diff: https://reviews.apache.org/r/43995/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Review Request 43964: CMAKE: Add leveldb library (3rdparty project).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43964/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4746 https://issues.apache.org/jira/browse/MESOS-4746 Repository: mesos Description --- CMAKE: Add leveldb library (3rdparty project). Diffs - 3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d Diff: https://reviews.apache.org/r/43964/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds
> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote: > > 3rdparty/libprocess/cmake/macros/External.cmake, line 38 > > <https://reviews.apache.org/r/43889/diff/1/?file=1265841#file1265841line38> > > > > And why we need change `EXTERNAL` macro here? I prososal add a version > > to our leveldb.tar.gz I expect we will need to get an agreement with the folks who maintain the make build. Who is the person that need to be pulled into this discussion? - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review120353 --- On Feb. 24, 2016, 2:05 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43889/ > --- > > (Updated Feb. 24, 2016, 2:05 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-4746 > https://issues.apache.org/jira/browse/MESOS-4746 > > > Repository: mesos > > > Description > --- > > CMAKE: Add leveldb library to 3rdparty external builds > > > Diffs > - > > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > 0c80fb8d799ea1252492cd98ac0780f1228aadcd > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 3a2e0999722007475c023ade75719093e35cfc80 > 3rdparty/libprocess/cmake/macros/External.cmake > e3901b67048f1c028216ae8323ee1c318a46f3cc > > Diff: https://reviews.apache.org/r/43889/diff/ > > > Testing > --- > > Tested on Ubuntu. > > > Thanks, > > Diana Arroyo > >
Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated Feb. 24, 2016, 2:05 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Addressed Alex's Comments Bugs: MESOS-4746 https://issues.apache.org/jira/browse/MESOS-4746 Repository: mesos Description --- CMAKE: Add leveldb library to 3rdparty external builds Diffs (updated) - 3rdparty/cmake/Mesos3rdpartyConfigure.cmake 0c80fb8d799ea1252492cd98ac0780f1228aadcd 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3a2e0999722007475c023ade75719093e35cfc80 3rdparty/libprocess/cmake/macros/External.cmake e3901b67048f1c028216ae8323ee1c318a46f3cc Diff: https://reviews.apache.org/r/43889/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds
> On Feb. 23, 2016, 6:15 p.m., haosdent huang wrote: > > Hi, I think the bug field for this review should be `MESOS-4746`? Fixed. - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review120349 --- On Feb. 23, 2016, 6:13 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43889/ > --- > > (Updated Feb. 23, 2016, 6:13 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-4647 > https://issues.apache.org/jira/browse/MESOS-4647 > > > Repository: mesos > > > Description > --- > > CMAKE: Add leveldb library to 3rdparty external builds > > > Diffs > - > > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > 0c80fb8d799ea1252492cd98ac0780f1228aadcd > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 3a2e0999722007475c023ade75719093e35cfc80 > 3rdparty/libprocess/cmake/macros/External.cmake > e3901b67048f1c028216ae8323ee1c318a46f3cc > > Diff: https://reviews.apache.org/r/43889/diff/ > > > Testing > --- > > Tested on Ubuntu. > > > Thanks, > > Diana Arroyo > >
Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4647 https://issues.apache.org/jira/browse/MESOS-4647 Repository: mesos Description --- CMAKE: Add leveldb library to 3rdparty external builds Diffs - 3rdparty/cmake/Mesos3rdpartyConfigure.cmake 0c80fb8d799ea1252492cd98ac0780f1228aadcd 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3a2e0999722007475c023ade75719093e35cfc80 3rdparty/libprocess/cmake/macros/External.cmake e3901b67048f1c028216ae8323ee1c318a46f3cc Diff: https://reviews.apache.org/r/43889/diff/ Testing --- Tested on Ubuntu. Thanks, Diana Arroyo
Re: Review Request 41092: CMake: Added CMake file for agent executable build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/ --- (Updated Feb. 13, 2016, 4:23 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Rebase per Alex's request. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Added CMake file for agent executable build. Diffs (updated) - src/slave/CMakeLists.txt PRE-CREATION src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b Diff: https://reviews.apache.org/r/41092/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- (Updated Feb. 13, 2016, 3:53 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Rebase per Alex's request. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- See summary. Diffs (updated) - src/slave/cmake/FindCurl.cmake PRE-CREATION src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b Diff: https://reviews.apache.org/r/41108/diff/ Testing --- Tested on Ubuntu and OSX. Tested if and else path of new logic added to FindCurl.cmake. Thanks, Diana Arroyo
Re: Review Request 41092: CMake: Added CMake file for agent executable build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/ --- (Updated Jan. 26, 2016, 1:54 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Cleanup code. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Added CMake file for agent executable build. Diffs (updated) - src/slave/CMakeLists.txt PRE-CREATION src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b Diff: https://reviews.apache.org/r/41092/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Re: Review Request 41092: CMake: Added CMake file for agent executable build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/ --- (Updated Jan. 21, 2016, 4:58 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Addressed latest review comments. Summary (updated) - CMake: Added CMake file for agent executable build. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Added CMake file for agent executable build. Diffs (updated) - src/slave/CMakeLists.txt PRE-CREATION src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b Diff: https://reviews.apache.org/r/41092/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- (Updated Jan. 13, 2016, 6:31 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- See summary. Diffs (updated) - src/slave/cmake/FindCurl.cmake df81fd538b06bf0c3e842a502bd5ef4083d897b5 src/slave/cmake/SlaveConfigure.cmake cf378a27297474b2a9f338e0c832612370f7302a Diff: https://reviews.apache.org/r/41108/diff/ Testing --- Tested on Ubuntu and OSX. Tested if and else path of new logic added to FindCurl.cmake. Thanks, Diana Arroyo
Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- (Updated Jan. 13, 2016, 6:09 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- See summary. Diffs (updated) - src/slave/cmake/FindCurl.cmake PRE-CREATION src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b Diff: https://reviews.apache.org/r/41108/diff/ Testing --- Tested on Ubuntu and OSX. Tested if and else path of new logic added to FindCurl.cmake. Thanks, Diana Arroyo
Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.
> On Jan. 8, 2016, 4:43 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [41096, 41185, 41108] > > > > Failed command: ./support/apply-review.sh -n -r 41108 > > > > Error: > > 2016-01-08 16:43:43 URL:https://reviews.apache.org/r/41108/diff/raw/ > > [4052/4052] -> "41108.patch" [1] > > error: patch failed: src/slave/cmake/FindCurl.cmake:31 > > error: src/slave/cmake/FindCurl.cmake: patch does not apply > > Alex Clemmer wrote: > It looks like you need to update your master and rebase this commit to > come after the last commit on the master branch? Ping me if you need help > with this. Please see: https://reviews.apache.org/r/42250/ - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/#review113487 --- On Jan. 8, 2016, 3:29 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41108/ > --- > > (Updated Jan. 8, 2016, 3:29 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/slave/cmake/FindCurl.cmake PRE-CREATION > src/slave/cmake/SlaveConfigure.cmake > fbdfdaa27fbd8c7429861eea5baf401a221f748b > > Diff: https://reviews.apache.org/r/41108/diff/ > > > Testing > --- > > Tested on Ubuntu and OSX. > Tested if and else path of new logic added to FindCurl.cmake. > > > Thanks, > > Diana Arroyo > >
Review Request 42250: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42250/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory. Diffs - src/slave/cmake/FindCurl.cmake PRE-CREATION src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b Diff: https://reviews.apache.org/r/42250/diff/ Testing --- originally https://reviews.apache.org/r/41108/. When attempting to address final review this review was created instead of modifiying original. See https://reviews.apache.org/r/41108/ for testing comments. Thanks, Diana Arroyo
Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- (Updated Jan. 8, 2016, 3:29 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Actually included the code changes that reflect the comments this time. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- See summary. Diffs (updated) - src/slave/cmake/FindCurl.cmake PRE-CREATION src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b Diff: https://reviews.apache.org/r/41108/diff/ Testing --- Tested on Ubuntu and OSX. Tested if and else path of new logic added to FindCurl.cmake. Thanks, Diana Arroyo
Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- (Updated Dec. 18, 2015, 8:25 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Cleaned up FindCurl based on my findings and comments of Alex's review regarding line number 58. Summary (updated) - CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description (updated) --- See summary. Diffs (updated) - src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b Diff: https://reviews.apache.org/r/41108/diff/ Testing (updated) --- Tested on Ubuntu and OSX. Tested if and else path of new logic added to FindCurl.cmake. Thanks, Diana Arroyo
Re: Review Request 41108: Add curl, sasl and dl link flags and add protobuf library directory
> On Dec. 9, 2015, 5:59 p.m., Alex Clemmer wrote: > > src/slave/cmake/SlaveConfigure.cmake, line 62 > > <https://reviews.apache.org/r/41108/diff/1/?file=1156611#file1156611line62> > > > > Same comment about the include directories, but with libraries. We > > probably want to include `CURL_LIBS` here. > > Diana Arroyo wrote: > So I wanted to verify the CURL_LIBS label that was being built in > FindCurl before adding it to AGENT_LIB_DIRS. Here is the debug message > output of a build: > > AGENT_LIB_DIRS = > /root/mesos/build/3rdparty/libprocess/3rdparty/glog-0.3.3/src/glog-0.3.3-lib/lib/lib;/root/mesos/build/3rdparty/libprocess/3rdparty/http_parser-1c3624a/src/http_parser-1c3624a-build;/root/mesos/build/3rdparty/libprocess/3rdparty/libev-4.15/src/libev-4.15-build/.libs;/root/mesos/build/3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protobuf-2.5.0-lib/lib/lib;/root/mesos/build/3rdparty/libprocess/3rdparty/glog-0.3.3/src/glog-0.3.3-lib/lib/lib;/root/mesos/build/3rdparty/zookeeper-3.4.5/src/zookeeper-3.4.5-lib/lib/lib > > CURL_LIBS = /usr/lib/x86_64-linux-gnu/libcurl.so > > CURL_LIB = /usr/lib/x86_64-linux-gnu/libcurl.so > > There is no lib directory field built in FindCurl. I can add this but > note that this would differ from the FindApr and FindSvn scripts. Please > advise. Per our conversation earlier this week regarding the comment above I did some additional investigation. The result is that adding the _LIB(S) (e.g. CURL_LIB or APR_LIBS) variable to link_directories() (-L option) is not the correct way and essentially be ignored. Adding the _LIB(S) to target_link_libraries() (-l option) will do the trick. In addition I found that the logic exported duplicate variables for the same value so I removed one variable (CURL_LIBS) and kept one variable (CURL_LIB). I will open a JIRA to fix APR and SVN find setup to reflex my findings above. - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/#review109566 ------- On Dec. 8, 2015, 11:09 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41108/ > --- > > (Updated Dec. 8, 2015, 11:09 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > --- > > Add curl, sasl and dl link flags and add protobuf library directory > > > Diffs > - > > src/slave/cmake/SlaveConfigure.cmake > fbdfdaa27fbd8c7429861eea5baf401a221f748b > > Diff: https://reviews.apache.org/r/41108/diff/ > > > Testing > --- > > Tested on Ubuntu and OSX. > > > Thanks, > > Diana Arroyo > >
Re: Review Request 41108: Add curl, sasl and dl link flags and add protobuf library directory
> On Dec. 9, 2015, 5:59 p.m., Alex Clemmer wrote: > > src/slave/cmake/SlaveConfigure.cmake, line 62 > > <https://reviews.apache.org/r/41108/diff/1/?file=1156611#file1156611line62> > > > > Same comment about the include directories, but with libraries. We > > probably want to include `CURL_LIBS` here. So I wanted to verify the CURL_LIBS label that was being built in FindCurl before adding it to AGENT_LIB_DIRS. Here is the debug message output of a build: AGENT_LIB_DIRS = /root/mesos/build/3rdparty/libprocess/3rdparty/glog-0.3.3/src/glog-0.3.3-lib/lib/lib;/root/mesos/build/3rdparty/libprocess/3rdparty/http_parser-1c3624a/src/http_parser-1c3624a-build;/root/mesos/build/3rdparty/libprocess/3rdparty/libev-4.15/src/libev-4.15-build/.libs;/root/mesos/build/3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protobuf-2.5.0-lib/lib/lib;/root/mesos/build/3rdparty/libprocess/3rdparty/glog-0.3.3/src/glog-0.3.3-lib/lib/lib;/root/mesos/build/3rdparty/zookeeper-3.4.5/src/zookeeper-3.4.5-lib/lib/lib CURL_LIBS = /usr/lib/x86_64-linux-gnu/libcurl.so CURL_LIB = /usr/lib/x86_64-linux-gnu/libcurl.so There is no lib directory field built in FindCurl. I can add this but note that this would differ from the FindApr and FindSvn scripts. Please advise. - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/#review109566 --- On Dec. 8, 2015, 11:09 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41108/ > --- > > (Updated Dec. 8, 2015, 11:09 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > --- > > Add curl, sasl and dl link flags and add protobuf library directory > > > Diffs > - > > src/slave/cmake/SlaveConfigure.cmake > fbdfdaa27fbd8c7429861eea5baf401a221f748b > > Diff: https://reviews.apache.org/r/41108/diff/ > > > Testing > --- > > Tested on Ubuntu and OSX. > > > Thanks, > > Diana Arroyo > >
Review Request 41185: CMake: Updated LFLAG for dl library to defined label
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41185/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- CMake: Updated LFLAG for dl library to defined label Diffs - 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 9893d741cd7c611dc65eba76be03e06dac618132 Diff: https://reviews.apache.org/r/41185/diff/ Testing --- Thanks, Diana Arroyo
Re: Review Request 41096: CMake: Added LFLAGs need for linux cmake build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41096/ --- (Updated Dec. 10, 2015, 3:16 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Added AGENT target definition. Summary (updated) - CMake: Added LFLAGs need for linux cmake build Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description (updated) --- See summary. Diffs (updated) - 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake a9cd9902567cef4c7ab4125463a68e19907db0b4 Diff: https://reviews.apache.org/r/41096/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Re: Review Request 41090: CMake: Added FindCurl.cmake script to locate curl library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/ --- (Updated Dec. 10, 2015, 1:10 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Addresses latest review comments. Summary (updated) - CMake: Added FindCurl.cmake script to locate curl library. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description (updated) --- See summary. Diffs (updated) - src/slave/cmake/FindCurl.cmake PRE-CREATION Diff: https://reviews.apache.org/r/41090/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Re: Review Request 40951: CMake: Added missing source files to src/CMakeLists.txt.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 9, 2015, 11:35 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Changed the summary to match the commit message. Summary (updated) - CMake: Added missing source files to src/CMakeLists.txt. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description (updated) --- See summary. Diffs - src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef Diff: https://reviews.apache.org/r/40951/diff/ Testing --- Tested to make sure library builds successfully. Thanks, Diana Arroyo
Re: Review Request 40951: Initial set of source files missing for cmake agent binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 9, 2015, 10:48 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Initial set of source files missing for cmake agent binary. Diffs (updated) - src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef Diff: https://reviews.apache.org/r/40951/diff/ Testing --- Tested to make sure library builds successfully. Thanks, Diana Arroyo
Re: Review Request 40951: Initial set of source files missing for cmake agent binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 9, 2015, 9:15 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Merge later review r41104 into this review. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Initial set of source files missing for cmake agent binary. Diffs (updated) - src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef Diff: https://reviews.apache.org/r/40951/diff/ Testing --- Tested to make sure library builds successfully. Thanks, Diana Arroyo
Re: Review Request 41090: Second iteration of changes for cmake build on linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/ --- (Updated Dec. 9, 2015, 3:45 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Second iteration of changes for cmake build on linux. Diffs (updated) - src/slave/cmake/FindCurl.cmake PRE-CREATION Diff: https://reviews.apache.org/r/41090/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Re: Review Request 40951: Initial set of source files missing for cmake agent binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 9, 2015, 3:45 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Initial set of source files missing for cmake agent binary. Diffs (updated) - src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef Diff: https://reviews.apache.org/r/40951/diff/ Testing --- Tested to make sure library builds successfully. Thanks, Diana Arroyo
Re: Review Request 41092: Added CMake file for agent executable build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/ --- (Updated Dec. 9, 2015, 3:43 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Added CMake file for agent executable build. Diffs (updated) - src/slave/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/41092/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Review Request 41096: Added LFLAGs need for linux cmake build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41096/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Added LFLAGs need for linux cmake build Diffs - 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake a9cd9902567cef4c7ab4125463a68e19907db0b4 Diff: https://reviews.apache.org/r/41096/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Re: Review Request 39597: Add Newbie guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/ --- (Updated Dec. 8, 2015, 11:40 p.m.) Review request for mesos, Timothy Chen and Vinod Kone. Changes --- Changes as a result of reviews. Bugs: MESOS-3224 https://issues.apache.org/jira/browse/MESOS-3224 Repository: mesos Description --- Add Newbie guide. Diffs (updated) - docs/NewbieQuickStart.md PRE-CREATION Diff: https://reviews.apache.org/r/39597/diff/ Testing --- Thanks, Diana Arroyo
Re: Review Request 39597: Add Newbie guide.
> On Nov. 6, 2015, 5:18 p.m., Vaibhav Khanduja wrote: > > docs/NewbieQuickStart.md, line 108 > > <https://reviews.apache.org/r/39597/diff/1/?file=1104937#file1104937line108> > > > > I am a "newbie" so was referring to your wip guide. I tried to run this > > command, but looks like it did not work me. > > > > a) the options --gtest-filter, --gtest-shuffle and --gtest-repeat are > > having "underscore" and not "hyphen" > > > > --gtest_filter, --gtest_shuffle and --gtest_repeat > > > > b) The command did not filter on Docker testcases, but ran all test > > cases. > > > > sudo GLOG_v=1 ./bin/mesos-tests.sh –gtest_filter=”*DOCKER*” > > --break-on-error –gtest_shuffle –gtest_repeat=100 > > > > is there something wrong here? > > Timothy Chen wrote: > You need two dashes (--gtest_filter), otherwise it should work. > > Vaibhav Khanduja wrote: > Thanks Tim ... suggestions in "a)" should be made .. the options have > underscore between than hyphen e.g. "--gtest_filter" and not "--gtest-filter" I corrected the "--gtest_filter" parameter in the document and added a "sudo" at the beginning as well. Thanks Vaibhav! - Diana ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review105466 --- On Oct. 30, 2015, 9 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39597/ > --- > > (Updated Oct. 30, 2015, 9 p.m.) > > > Review request for mesos, Timothy Chen and Vinod Kone. > > > Bugs: MESOS-3224 > https://issues.apache.org/jira/browse/MESOS-3224 > > > Repository: mesos > > > Description > --- > > Add Newbie guide. > > > Diffs > - > > docs/NewbieQuickStart.md PRE-CREATION > > Diff: https://reviews.apache.org/r/39597/diff/ > > > Testing > --- > > > Thanks, > > Diana Arroyo > >
Re: Review Request 39597: Add Newbie guide.
> On Nov. 21, 2015, 1:05 a.m., Timothy Chen wrote: > > Diana are you still able to finish the comments? > > Diana Arroyo wrote: > Hey Tim, Yes, I'll finish them up. Done. I only have to outstanding items from Neil I didn't fix but provided a comment instead. Do we wait for Neil to agree to the comments before we merge? Please advise. - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review107462 --- On Oct. 30, 2015, 9 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39597/ > --- > > (Updated Oct. 30, 2015, 9 p.m.) > > > Review request for mesos, Timothy Chen and Vinod Kone. > > > Bugs: MESOS-3224 > https://issues.apache.org/jira/browse/MESOS-3224 > > > Repository: mesos > > > Description > --- > > Add Newbie guide. > > > Diffs > - > > docs/NewbieQuickStart.md PRE-CREATION > > Diff: https://reviews.apache.org/r/39597/diff/ > > > Testing > --- > > > Thanks, > > Diana Arroyo > >
Re: Review Request 39597: Add Newbie guide.
> On Nov. 2, 2015, 7:01 p.m., Timothy Chen wrote: > > Thanks for doing this Diana! Sorry for the delay, we need to figure out a > > place to put this on the website as well. You have suggestions? How about in this page: http://mesos.apache.org/community/ under the title: "Contribute a core patch"? - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review104758 --- On Oct. 30, 2015, 9 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39597/ > --- > > (Updated Oct. 30, 2015, 9 p.m.) > > > Review request for mesos, Timothy Chen and Vinod Kone. > > > Bugs: MESOS-3224 > https://issues.apache.org/jira/browse/MESOS-3224 > > > Repository: mesos > > > Description > --- > > Add Newbie guide. > > > Diffs > - > > docs/NewbieQuickStart.md PRE-CREATION > > Diff: https://reviews.apache.org/r/39597/diff/ > > > Testing > --- > > > Thanks, > > Diana Arroyo > >
Re: Review Request 39597: Add Newbie guide.
> On Nov. 2, 2015, 8:59 p.m., Neil Conway wrote: > > docs/NewbieQuickStart.md, line 86 > > <https://reviews.apache.org/r/39597/diff/1/?file=1104937#file1104937line86> > > > > Links to other docs pages should take the form "(anchor-text)[foo.md]", > > rather than using the full URL. I didn't add the above suggestion because it doesn't seem to work with the docs online. See: http://mesos.apache.org/documentation/latest/architecture/ and scroll down to the hotlink "App/Framework development guide". If you select the link it fails. The underlying text in the architecture.md file is: (see the [App/Framework development guide](app-framework-development-guide.md). > On Nov. 2, 2015, 8:59 p.m., Neil Conway wrote: > > docs/NewbieQuickStart.md, line 99 > > <https://reviews.apache.org/r/39597/diff/1/?file=1104937#file1104937line99> > > > > See above re: link. Same changes also needed below in a few places. See response comment above. - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review104791 --- On Oct. 30, 2015, 9 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39597/ > --- > > (Updated Oct. 30, 2015, 9 p.m.) > > > Review request for mesos, Timothy Chen and Vinod Kone. > > > Bugs: MESOS-3224 > https://issues.apache.org/jira/browse/MESOS-3224 > > > Repository: mesos > > > Description > --- > > Add Newbie guide. > > > Diffs > - > > docs/NewbieQuickStart.md PRE-CREATION > > Diff: https://reviews.apache.org/r/39597/diff/ > > > Testing > --- > > > Thanks, > > Diana Arroyo > >
Re: Review Request 39597: Add Newbie guide.
> On Oct. 23, 2015, 4:07 p.m., James Peach wrote: > > I'm pretty sure that Mesos only builds with the bundled GLog and GTest. At > > least I've always been unsuccessful in building against unbundled versions > > of those components. Hi James, do you think we should change some content based on your review comment above? Please advise. Thanks. - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review103781 --- On Oct. 30, 2015, 9 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39597/ > --- > > (Updated Oct. 30, 2015, 9 p.m.) > > > Review request for mesos, Timothy Chen and Vinod Kone. > > > Bugs: MESOS-3224 > https://issues.apache.org/jira/browse/MESOS-3224 > > > Repository: mesos > > > Description > --- > > Add Newbie guide. > > > Diffs > - > > docs/NewbieQuickStart.md PRE-CREATION > > Diff: https://reviews.apache.org/r/39597/diff/ > > > Testing > --- > > > Thanks, > > Diana Arroyo > >
Review Request 41108: Add curl, sasl and dl link flags and add protobuf library directory
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Add curl, sasl and dl link flags and add protobuf library directory Diffs - src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b Diff: https://reviews.apache.org/r/41108/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Review Request 41104: Addes some additional missing source files and put the source files in proper order
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41104/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Addes some additional missing source files and put the source files in proper order Diffs - src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef Diff: https://reviews.apache.org/r/41104/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Review Request 41092: Added CMake file for agent executable build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Added CMake file for agent executable build. Diffs - src/slave/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/41092/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Re: Review Request 41090: Second iteration of changes for cmake build on linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/ --- (Updated Dec. 8, 2015, 5:52 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Second iteration of changes for cmake build on linux. Diffs (updated) - src/slave/cmake/FindCurl.cmake PRE-CREATION Diff: https://reviews.apache.org/r/41090/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Review Request 41090: Second iteration of changes for cmake build on linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Second iteration of changes for cmake build on linux. Diffs - src/slave/cmake/FindCurl.cmake PRE-CREATION Diff: https://reviews.apache.org/r/41090/diff/ Testing --- Tested on Ubuntu and OSX. Thanks, Diana Arroyo
Re: Review Request 40951: Initial set of source files missing for cmake agent binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 8, 2015, 3:59 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Initial set of source files missing for cmake agent binary. Diffs (updated) - src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef Diff: https://reviews.apache.org/r/40951/diff/ Testing --- Tested to make sure library builds successfully. Thanks, Diana Arroyo
Re: Review Request 40951: Initial set of source files missing for cmake agent binary.
> On Dec. 4, 2015, 9:48 p.m., Joseph Wu wrote: > > Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and `jvanremoortere` > > to this review (and future CMake reviews)? > > > > --- > > > > Ran `cmake .. && make` on OSX. Hit this error: > > ``` > > mesos/src/slave/containerizer/mesos/linux_launcher.cpp:20:10: fatal error: > > 'linux/sched.h' file not found > > #include > > ``` > > > > Note that `src/Makefile.am` does this: > > ``` > > if OS_LINUX > > libmesos_no_3rdparty_la_SOURCES += $(MESOS_LINUX_FILES) > > else > > EXTRA_DIST += $(MESOS_LINUX_FILES) > > endif > > ``` > > And `linux_launcher.cpp` is in `MESOS_LINUX_FILES`. > > Diana Arroyo wrote: > Reference: "can you add hausdorff, kaysoky, hartem, and jvanremoortere to > this review (and future CMake reviews)?": Done. > Reference: "fatal error: 'linux/sched.h' file not found": working... Reference: "fatal error: 'linux/sched.h' file not found": Fixed. - Diana ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109032 --- On Dec. 5, 2015, 3:35 a.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40951/ > --- > > (Updated Dec. 5, 2015, 3:35 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > --- > > Initial set of source files missing for cmake agent binary. > > > Diffs > - > > src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef > > Diff: https://reviews.apache.org/r/40951/diff/ > > > Testing > --- > > Tested to make sure library builds successfully. > > > Thanks, > > Diana Arroyo > >
Re: Review Request 40951: Initial set of source files missing for cmake agent binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 5, 2015, 3:35 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Initial set of source files missing for cmake agent binary. Diffs (updated) - src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef Diff: https://reviews.apache.org/r/40951/diff/ Testing --- Tested to make sure library builds successfully. Thanks, Diana Arroyo
Re: Review Request 40951: Initial set of source files missing for cmake agent binary.
> On Dec. 4, 2015, 9:48 p.m., Joseph Wu wrote: > > Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and `jvanremoortere` > > to this review (and future CMake reviews)? > > > > --- > > > > Ran `cmake .. && make` on OSX. Hit this error: > > ``` > > mesos/src/slave/containerizer/mesos/linux_launcher.cpp:20:10: fatal error: > > 'linux/sched.h' file not found > > #include > > ``` > > > > Note that `src/Makefile.am` does this: > > ``` > > if OS_LINUX > > libmesos_no_3rdparty_la_SOURCES += $(MESOS_LINUX_FILES) > > else > > EXTRA_DIST += $(MESOS_LINUX_FILES) > > endif > > ``` > > And `linux_launcher.cpp` is in `MESOS_LINUX_FILES`. Reference: "can you add hausdorff, kaysoky, hartem, and jvanremoortere to this review (and future CMake reviews)?": Done. Reference: "fatal error: 'linux/sched.h' file not found": working... - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109032 --- On Dec. 4, 2015, 6:30 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40951/ > --- > > (Updated Dec. 4, 2015, 6:30 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > --- > > Initial set of source files missing for cmake agent binary. > > > Diffs > - > > src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef > > Diff: https://reviews.apache.org/r/40951/diff/ > > > Testing > --- > > Tested to make sure library builds successfully. > > > Thanks, > > Diana Arroyo > >
Re: Review Request 40951: Initial set of source files missing for cmake agent binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 4, 2015, 6:30 p.m.) Review request for mesos. Bugs: MESOS-3843 https://issues.apache.org/jira/browse/MESOS-3843 Repository: mesos Description --- Initial set of source files missing for cmake agent binary. Diffs - src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef Diff: https://reviews.apache.org/r/40951/diff/ Testing --- Tested to make sure library builds successfully. Thanks, Diana Arroyo
Review Request 40951: Initial set of source files missing for cmake agent binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- Review request for mesos. Repository: mesos Description --- Initial set of source files missing for cmake agent binary. Diffs - src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef Diff: https://reviews.apache.org/r/40951/diff/ Testing --- Tested to make sure library builds successfully. Thanks, Diana Arroyo
Re: Review Request 39597: Add Newbie guide.
> On Nov. 21, 2015, 1:05 a.m., Timothy Chen wrote: > > Diana are you still able to finish the comments? Hey Tim, Yes, I'll finish them up. - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review107462 --- On Oct. 30, 2015, 9 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39597/ > --- > > (Updated Oct. 30, 2015, 9 p.m.) > > > Review request for mesos, Timothy Chen and Vinod Kone. > > > Bugs: MESOS-3224 > https://issues.apache.org/jira/browse/MESOS-3224 > > > Repository: mesos > > > Description > --- > > Add Newbie guide. > > > Diffs > - > > docs/NewbieQuickStart.md PRE-CREATION > > Diff: https://reviews.apache.org/r/39597/diff/ > > > Testing > --- > > > Thanks, > > Diana Arroyo > >
Review Request 39597: Add Newbie guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-3224 https://issues.apache.org/jira/browse/MESOS-3224 Repository: mesos Description --- Add Newbie guide. Diffs - docs/NewbieQuickStart.md PRE-CREATION Diff: https://reviews.apache.org/r/39597/diff/ Testing --- Thanks, Diana Arroyo
