Re: Review Request 45300: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45300/#review125453 --- Ship it! Ship It! - Yi Sun On March 25, 2016, 6:12 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45300/ > --- > > (Updated March 25, 2016, 6:12 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Containerizer:[2/2] Transitioned codebase to use `os::pagesize`. > > > Diffs > - > > src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a > src/tests/containerizer/cgroups_tests.cpp > acaed9b3f8a04964092cef413133834d0cf5a145 > src/tests/containerizer/memory_test_helper.cpp > 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6 > > Diff: https://reviews.apache.org/r/45300/diff/ > > > Testing > --- > > make check > > > Thanks, > > Alex Clemmer > >
Re: Review Request 45299: Stout:[1/2] transitioned codebase to use `os::pagesize`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45299/#review125452 --- Fix it, then Ship it! Ship It! 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp (line 87) <https://reviews.apache.org/r/45299/#comment188235> nit: getpagesize() is irrelevant now. - Yi Sun On March 25, 2016, 6:12 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45299/ > --- > > (Updated March 25, 2016, 6:12 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Stout:[1/2] transitioned codebase to use `os::pagesize`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 7bd4bfbc2ec5922879dcefddc12137336b11be52 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp > 6b81bf1ea3d571e8f5fb170076b85223b02efe2c > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp > 182ac9cfbacd4535fb355aac6ec38559d786e63a > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp > 692fa483ee8a75dedae5ad0e7d2a4aa70dafa8a3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/pagesize.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pagesize.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pagesize.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 9ee233b988c08d953e70345c55bcdd5c2f7c101b > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > 6a391ff198ab724f689bcef79d4e2e05a786cbc2 > > Diff: https://reviews.apache.org/r/45299/diff/ > > > Testing > --- > > make check > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44084: Windows: Forked os::rename().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/#review125451 --- Ship it! Ship It! - Yi Sun On March 24, 2016, 2:59 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44084/ > --- > > (Updated March 24, 2016, 2:59 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows: Forked os::rename(). > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 7bd4bfbc2ec5922879dcefddc12137336b11be52 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp > 7b2215208bcaa5613426d8ede9cab21d1a084631 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp > 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 > > Diff: https://reviews.apache.org/r/44084/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 45009: Transition `filesystem_tests.cpp` to use `path::join`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45009/#review125448 --- Ship it! Ship It! - Yi Sun On March 18, 2016, 12:51 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45009/ > --- > > (Updated March 18, 2016, 12:51 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Transition `filesystem_tests.cpp` to use `path::join`. > > This commit will fix a test that fails due to inconsistent usage of path > delimiting characters. > > Historically in Mesos, it has been common to join paths by adding > strings. For example: `somePath + "/yourFile"`. The '/' character in > particular is contentious, and can cause problems if you're not > consistent in your usage. For example, if `somePath` already uses '\' as > a path separator, then joining the string `"/yourFile"` introduces > inconsistency in the path delimiter usage, resulting in undesirable > behavior. > > Review: https://reviews.apache.org/r/45009 > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp > 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 > > Diff: https://reviews.apache.org/r/45009/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45015/#review125446
---
Fix it, then Ship it!
Ship It!
3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 149)
<https://reviews.apache.org/r/45015/#comment188232>
Nit: expect.
- Yi Sun
On March 24, 2016, 7:58 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45015/
> ---
>
> (Updated March 24, 2016, 7:58 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan,
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Currently on Windows, `os::exists` will return true if a component of a
> path does not exist. For example if you have `a/fancy/path`, and you ask
> `os::exists("a/fake/path")`, the result currently reports `true`. In
> other words, the Windows code path only checks for the error that a file
> does not exist, and ignores the error that says the path is not valid.
>
> This commit will fix this, and also add a test that will verify we don't
> regress.
>
>
> Diffs
> -
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/exists.hpp
> 9211851e4562e04045276421b359c3c78cdae7f1
> 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83
>
> Diff: https://reviews.apache.org/r/45015/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44081/#review123541 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 9:10 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44081/ > --- > > (Updated March 14, 2016, 9:10 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 9ee233b988c08d953e70345c55bcdd5c2f7c101b > > Diff: https://reviews.apache.org/r/44081/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44082/#review123540 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 9:12 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44082/ > --- > > (Updated March 14, 2016, 9:12 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Stout: Un-commented out functions and marked them as deleted instead. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > 6a391ff198ab724f689bcef79d4e2e05a786cbc2 > > Diff: https://reviews.apache.org/r/44082/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44808: Fixup POSIX build by removing headers from load.*.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44808/#review123536 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 9:06 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44808/ > --- > > (Updated March 14, 2016, 9:06 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Fixup POSIX build by removing headers from load.*. > > > Diffs > - > > src/slave/qos_controllers/load.hpp 098a6d0b2dfc54b5b95a261a780eea70a838c12d > src/slave/qos_controllers/load.cpp dd44f9209ad283bfea95f16a8c1017e309757f23 > > Diff: https://reviews.apache.org/r/44808/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44808: Fixup POSIX build by removing headers from load.*.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44808/#review123535 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 9:06 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44808/ > --- > > (Updated March 14, 2016, 9:06 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Fixup POSIX build by removing headers from load.*. > > > Diffs > - > > src/slave/qos_controllers/load.hpp 098a6d0b2dfc54b5b95a261a780eea70a838c12d > src/slave/qos_controllers/load.cpp dd44f9209ad283bfea95f16a8c1017e309757f23 > > Diff: https://reviews.apache.org/r/44808/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44080: Windows:[1/2] Implemented `os::gmtime_r`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44080/#review123537 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 8:48 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44080/ > --- > > (Updated March 14, 2016, 8:48 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4462 > https://issues.apache.org/jira/browse/MESOS-4462 > > > Repository: mesos > > > Description > --- > > Windows:[1/2] Implemented `os::gmtime_r`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 9ee233b988c08d953e70345c55bcdd5c2f7c101b > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > 6a391ff198ab724f689bcef79d4e2e05a786cbc2 > > Diff: https://reviews.apache.org/r/44080/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/#review123252 --- Ship it! Ship It! - Yi Sun On March 12, 2016, 1:28 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44747/ > --- > > (Updated March 12, 2016, 1:28 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3641 > https://issues.apache.org/jira/browse/MESOS-3641 > > > Repository: mesos > > > Description > --- > > Stout: Added implementation of `write` that works on Windows. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/write.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp > a2a5d0b7af673fee89f66e2722846af7b7fd059a > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/write.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp > 1715bf5e6c590e7d14f59d517b30a281346365be > > Diff: https://reviews.apache.org/r/44747/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review123251 --- Ship it! Ship It! - Yi Sun On March 12, 2016, 1:28 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44748/ > --- > > (Updated March 12, 2016, 1:28 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3641 > https://issues.apache.org/jira/browse/MESOS-3641 > > > Repository: mesos > > > Description > --- > > Stout: Added implementation of `read` that works on Windows. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp > d494cbf8a2a24c88b0569634cfcbf29de0784797 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44748/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44045: Style fixes to `stout/include/Makefile.am`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44045/#review123008 --- Ship it! Ship It! - Yi Sun On Feb. 25, 2016, 10:28 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44045/ > --- > > (Updated Feb. 25, 2016, 10:28 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Style fixes to `stout/include/Makefile.am`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 03eff5a831283f6d298e9a1feecfdc7369cacfe7 > > Diff: https://reviews.apache.org/r/44045/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44042: Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44042/#review123007 --- Ship it! Ship It! - Yi Sun On Feb. 25, 2016, 9:16 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44042/ > --- > > (Updated Feb. 25, 2016, 9:16 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > f1d38029eef7e89dfdb8915158fba17865e6855b > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 84a2a021859d4e5c8547ad2a509eebda428a8255 > 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp > 625636525ee0fb35214cc3df3a304c40c9a0b0a6 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > d3ba0b4ff5d2d125252389a0f8f618c78aa6d948 > > Diff: https://reviews.apache.org/r/44042/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44078/#review123006 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44078/ > --- > > (Updated Feb. 26, 2016, 4:11 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3632 > https://issues.apache.org/jira/browse/MESOS-3632 > > > Repository: mesos > > > Description > --- > > Windows: Added Socket compatibility `#define`s to windows.hpp. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > d3ba0b4ff5d2d125252389a0f8f618c78aa6d948 > > Diff: https://reviews.apache.org/r/44078/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44077: Windows:[3/3] Transitioned Windows `system` to use `os::execlp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44077/#review123005 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44077/ > --- > > (Updated Feb. 26, 2016, 4:11 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3632 > https://issues.apache.org/jira/browse/MESOS-3632 > > > Repository: mesos > > > Description > --- > > Windows:[3/3] Transitioned Windows `system` to use `os::execlp`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp > 42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b > > Diff: https://reviews.apache.org/r/44077/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44076/#review123004 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44076/ > --- > > (Updated Feb. 26, 2016, 4:11 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3632 > https://issues.apache.org/jira/browse/MESOS-3632 > > > Repository: mesos > > > Description > --- > > Windows: [2/3] Used `os::execlp` in launch.cpp. > > > Diffs > - > > src/slave/containerizer/mesos/launch.cpp > 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 > > Diff: https://reviews.apache.org/r/44076/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44075/#review123003 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44075/ > --- > > (Updated Feb. 26, 2016, 4:11 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3632 > https://issues.apache.org/jira/browse/MESOS-3632 > > > Repository: mesos > > > Description > --- > > Isolated shell argouments in a namespace. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp > e0039fdab20ba547dc2bb78c544549c30c535294 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp > 42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b > > Diff: https://reviews.apache.org/r/44075/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44046: Windows: Used `evutil_socket_t` typedef for sockets.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44046/#review123001 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:09 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44046/ > --- > > (Updated Feb. 26, 2016, 4:09 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows: Used `evutil_socket_t` typedef for sockets. > > > Diffs > - > > 3rdparty/libprocess/src/libevent.cpp > c787fa9622a22894535ebe64327dd33cfaf1fcd7 > > Diff: https://reviews.apache.org/r/44046/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.
> On March 1, 2016, 11:47 p.m., Yi Sun wrote: > > 3rdparty/libprocess/src/windows/subprocess.cpp, line 152 > > <https://reviews.apache.org/r/44141/diff/1/?file=1272989#file1272989line152> > > > > The second param for strcpy_s is the number of chars to be copied. It > > doesn't seem right here. It's the size of the dest buffer. I got it wrong. - Yi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44141/#review121541 --- On March 1, 2016, 8:58 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44141/ > --- > > (Updated March 1, 2016, 8:58 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows: Forked subprocess.cpp, added `Windows` implementation. > > > Diffs > - > > 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d > 3rdparty/libprocess/include/process/subprocess.hpp > e0c306aa5cf5f393abb73768bbd287c45730f076 > 3rdparty/libprocess/src/CMakeLists.txt > 12dfaf61b801372b6ec70c535080fde350866fb8 > 3rdparty/libprocess/src/subprocess.cpp > 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c > 3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION > 3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44141/diff/ > > > Testing > --- > > OSX: make check > Windows: build/run > > > Thanks, > > Daniel Pravat > >
Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44141/#review121543 --- Ship it! Ship It! - Yi Sun On March 1, 2016, 8:58 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44141/ > --- > > (Updated March 1, 2016, 8:58 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows: Forked subprocess.cpp, added `Windows` implementation. > > > Diffs > - > > 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d > 3rdparty/libprocess/include/process/subprocess.hpp > e0c306aa5cf5f393abb73768bbd287c45730f076 > 3rdparty/libprocess/src/CMakeLists.txt > 12dfaf61b801372b6ec70c535080fde350866fb8 > 3rdparty/libprocess/src/subprocess.cpp > 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c > 3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION > 3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44141/diff/ > > > Testing > --- > > OSX: make check > Windows: build/run > > > Thanks, > > Daniel Pravat > >
Re: Review Request 43695: Windows:[4/4] Included Socket library for 64-bit builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43695/#review119674 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:28 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43695/ > --- > > (Updated Feb. 18, 2016, 2:28 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3525 > https://issues.apache.org/jira/browse/MESOS-3525 > > > Repository: mesos > > > Description > --- > > Windows:[4/4] Included Socket library for 64-bit builds. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake > a27cb98fa45cbd135ebfeca65e215fb3ff054739 > > Diff: https://reviews.apache.org/r/43695/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43694/#review119673 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:28 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43694/ > --- > > (Updated Feb. 18, 2016, 2:28 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3525 > https://issues.apache.org/jira/browse/MESOS-3525 > > > Repository: mesos > > > Description > --- > > Windows:[3/4] Transitioned to static-everything builds on Windows. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 9b61376ea6aad304607c20c9823d9ef19013eca0 > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > 2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 3a2e0999722007475c023ade75719093e35cfc80 > 3rdparty/libprocess/src/CMakeLists.txt > 12dfaf61b801372b6ec70c535080fde350866fb8 > > Diff: https://reviews.apache.org/r/43694/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43693: CMake:[2/4] Transitioned ZK build to be 64-bit and static.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43693/#review119666 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:27 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43693/ > --- > > (Updated Feb. 18, 2016, 2:27 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3525 > https://issues.apache.org/jira/browse/MESOS-3525 > > > Repository: mesos > > > Description > --- > > CMake:[2/4] Transitioned ZK build to be 64-bit and static. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 9b61376ea6aad304607c20c9823d9ef19013eca0 > 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat > 8da05bcf8e6b2335770cff7c43218b823721d50c > 3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake > 632696e883e8ccb9bfa82288f62e7ad3771b043e > > Diff: https://reviews.apache.org/r/43693/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43692/#review119665 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:26 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43692/ > --- > > (Updated Feb. 18, 2016, 2:26 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3525 > https://issues.apache.org/jira/browse/MESOS-3525 > > > Repository: mesos > > > Description > --- > > CMake:[1/4] Transitioned to 64-bit build of ZK on Windows. > > > Diffs > - > > 3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > 0c80fb8d799ea1252492cd98ac0780f1228aadcd > 3rdparty/zookeeper-06d3f3f.patch 8f8f72cb712c4bca328bf865ab082926106fbd94 > cmake/MesosConfigure.cmake 9a4fdb57e1281d9ec421e639819de5786c11744a > src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 > > Diff: https://reviews.apache.org/r/43692/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43699: CMake:[3/3] Used Stout config script in agent build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43699/#review119661 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 4:35 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43699/ > --- > > (Updated Feb. 18, 2016, 4:35 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4703 > https://issues.apache.org/jira/browse/MESOS-4703 > > > Repository: mesos > > > Description > --- > > CMake:[3/3] Used Stout config script in agent build. > > > Diffs > - > > CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053 > src/slave/cmake/SlaveConfigure.cmake > a8270a9ac6ceee4f370e185bee82126c309ec134 > > Diff: https://reviews.apache.org/r/43699/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43698/#review119659 --- 3rdparty/libprocess/cmake/ProcessConfigure.cmake (line 53) <https://reviews.apache.org/r/43698/#comment180999> Does STOUT_DEPENDENCIES already contain PICOJSON_TARGET? 3rdparty/libprocess/cmake/ProcessConfigure.cmake (line 70) <https://reviews.apache.org/r/43698/#comment181004> Already included in STOUT_INCLUDE_DIRS? - Yi Sun On Feb. 18, 2016, 4:34 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43698/ > --- > > (Updated Feb. 18, 2016, 4:34 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4703 > https://issues.apache.org/jira/browse/MESOS-4703 > > > Repository: mesos > > > Description > --- > > CMake:[2/3] Use new Stout config script in libprocess 3rdparty build. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 9b61376ea6aad304607c20c9823d9ef19013eca0 > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > 2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca > > Diff: https://reviews.apache.org/r/43698/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43697/#review119657 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 5:49 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43697/ > --- > > (Updated Feb. 18, 2016, 5:49 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4703 > https://issues.apache.org/jira/browse/MESOS-4703 > > > Repository: mesos > > > Description > --- > > CMake:[1/3] Move Stout configuration to its own file. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake > a27cb98fa45cbd135ebfeca65e215fb3ff054739 > > Diff: https://reviews.apache.org/r/43697/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43697/#review119656 --- 3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake (line 105) <https://reviews.apache.org/r/43697/#comment180997> This seems like new. I suppose this is now needed. - Yi Sun On Feb. 18, 2016, 5:49 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43697/ > --- > > (Updated Feb. 18, 2016, 5:49 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4703 > https://issues.apache.org/jira/browse/MESOS-4703 > > > Repository: mesos > > > Description > --- > > CMake:[1/3] Move Stout configuration to its own file. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake > a27cb98fa45cbd135ebfeca65e215fb3ff054739 > > Diff: https://reviews.apache.org/r/43697/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43689: CMake: Begin to require 64-bit builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43689/#review119653 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:29 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43689/ > --- > > (Updated Feb. 18, 2016, 2:29 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3525 > https://issues.apache.org/jira/browse/MESOS-3525 > > > Repository: mesos > > > Description > --- > > CMake: Candidate compilation configuration finalization. > > > Diffs > - > > cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b > > Diff: https://reviews.apache.org/r/43689/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43691/#review119650 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:24 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43691/ > --- > > (Updated Feb. 18, 2016, 2:24 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > CMake:[2/2] Fixed http-parser library directory for Windows builds. > > > Diffs > - > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 > > Diff: https://reviews.apache.org/r/43691/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43418: Windows: Added slave/status_update_manager.cpp and other files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43418/#review119648 --- src/CMakeLists.txt (line 219) <https://reviews.apache.org/r/43418/#comment180993> Is it intentional to drop slave/resource_estimator.cpp? - Yi Sun On Feb. 18, 2016, 1:01 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43418/ > --- > > (Updated Feb. 18, 2016, 1:01 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows: Added slave/status_update_manager.cpp and other files. > > > Diffs > - > > src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 > > Diff: https://reviews.apache.org/r/43418/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43700/#review119645 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:31 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43700/ > --- > > (Updated Feb. 18, 2016, 2:31 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > CMake: Fixed Find* scripts to not explode if invoked twice. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake > 4b28aa170f48d37ae9096bc28a64d8a32e8d35dd > 3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake > c975a16975e76b38f028d7575775abd31c9090f5 > > Diff: https://reviews.apache.org/r/43700/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43410: Windows: Added support for dynamic library loading.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43410/#review119099 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 6:01 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43410/ > --- > > (Updated Feb. 10, 2016, 6:01 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4496 > https://issues.apache.org/jira/browse/MESOS-4496 > > > Repository: mesos > > > Description > --- > > Originally review #40583, this was resurrected when Dario went on > paternity leave. Minor changes were made, the review itself remains > largely in tact. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp > 166c97d3e4b07451b8b4c01092cecb69315c691a > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/dynamiclibrary.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/43410/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/#review119098 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 7:13 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43416/ > --- > > (Updated Feb. 10, 2016, 7:13 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows: Removed ambiguous call to `::write`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp > 88b355e09f76f0412c74ad69556572f0079deb8f > > Diff: https://reviews.apache.org/r/43416/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43415/#review119097 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 7:13 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43415/ > --- > > (Updated Feb. 10, 2016, 7:13 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > CMake: Moved Windows build to version of glog that builds with CMake. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 9b61376ea6aad304607c20c9823d9ef19013eca0 > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 > > Diff: https://reviews.apache.org/r/43415/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43413: CMake:[1/2] Allow downloading third-party dependencies from mirror.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43413/#review119095 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 7:03 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43413/ > --- > > (Updated Feb. 10, 2016, 7:03 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > CMake:[1/2] Allow downloading third-party dependencies from mirror. > > > Diffs > - > > 3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d > CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053 > > Diff: https://reviews.apache.org/r/43413/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43414: CMake:[2/2] Canonicalize location of third-party dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43414/#review119096 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 7:13 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43414/ > --- > > (Updated Feb. 10, 2016, 7:13 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > CMake:[2/2] Canonicalize location of third-party dependencies. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 9b61376ea6aad304607c20c9823d9ef19013eca0 > > Diff: https://reviews.apache.org/r/43414/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43409: Windows: Added `src/resource_estimator.cpp` to build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43409/#review119093 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 6:44 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43409/ > --- > > (Updated Feb. 10, 2016, 6:44 a.m.) > > > Review request for mesos, Joris Van Remoortere and Michael Park. > > > Repository: mesos > > > Description > --- > > Windows: Added `src/resource_estimator.cpp` to build. > > > Diffs > - > > src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 > > Diff: https://reviews.apache.org/r/43409/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43407/#review119092 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 11:36 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43407/ > --- > > (Updated Feb. 10, 2016, 11:36 p.m.) > > > Review request for mesos, Joris Van Remoortere and Michael Park. > > > Repository: mesos > > > Description > --- > > CMake: Force GMock to build and link statically. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 9b61376ea6aad304607c20c9823d9ef19013eca0 > > Diff: https://reviews.apache.org/r/43407/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 42016: Windows: Apply patch.exe without elevation prompt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/#review116126 --- Ship it! Ship It! - Yi Sun On Jan. 14, 2016, 12:43 a.m., M Lawindi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42016/ > --- > > (Updated Jan. 14, 2016, 12:43 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Alex Clemmer, M > Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows:[2/2] Added zookeeper-3.4.5 to Mesos build > > > Diffs > - > > 3rdparty/CMakeLists.txt ac5c25a8797a687e84384682975ab99fb3e30448 > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > 34e61ff90eca0ffdddb6b6b8e2f8e552691637fa > 3rdparty/patch.exe.manifest PRE-CREATION > CMakeLists.txt 9b7044b7860fd64b854ac27b28a48d297dfdeae8 > src/slave/cmake/SlaveConfigure.cmake > cf378a27297474b2a9f338e0c832612370f7302a > > Diff: https://reviews.apache.org/r/42016/diff/ > > > Testing > --- > > > Thanks, > > M Lawindi > >
Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review113581 --- Ship it! Ship It! 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp (line 55) <https://reviews.apache.org/r/39802/#comment174322> So the entry is always pointing to the allocated memory when success. - Yi Sun On Jan. 4, 2016, 11:20 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39802/ > --- > > (Updated Jan. 4, 2016, 11:20 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > Windows: Implemented `stout/os/windows/ls.hpp`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/ls.hpp > 7dba79d31559d15a3e84eff506ce7df3e57cf5f3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp > 5b6fba13ce215af5801fd0867f6e774e100689ca > > Diff: https://reviews.apache.org/r/39802/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112953 --- Ship it! Ship It! - Yi Sun On Jan. 5, 2016, 11:04 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39584/ > --- > > (Updated Jan. 5, 2016, 11:04 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > Windows: Implemented `os::rmdir.hpp`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > e738cdbf5846950c475c159fb9a770acc45159f5 > > Diff: https://reviews.apache.org/r/39584/diff/ > > > Testing > --- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112717 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 54) <https://reviews.apache.org/r/39584/#comment173203> the current function is not os::rmdir. 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 64) <https://reviews.apache.org/r/39584/#comment173202> What does "Previous" mean here? Should it be "Parent"? 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 87) <https://reviews.apache.org/r/39584/#comment173204> os::rmdir is not the right func name. Also, "found it was not a valid directory" does not make sense because we only hit here when it's not a directory. 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 96) <https://reviews.apache.org/r/39584/#comment173205> os::rmdir - Yi Sun On Jan. 4, 2016, 11:26 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39584/ > --- > > (Updated Jan. 4, 2016, 11:26 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > Windows: Implemented `os::rmdir.hpp`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > e738cdbf5846950c475c159fb9a770acc45159f5 > > Diff: https://reviews.apache.org/r/39584/diff/ > > > Testing > --- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review112701 --- Ship it! Ship It! - Yi Sun On Jan. 5, 2016, 12:12 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39803/ > --- > > (Updated Jan. 5, 2016, 12:12 a.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Windows: Implemented stout/os/stat.hpp`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > PRE-CREATION > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp > 5b38b9af654d7d1c574f0cc573083b66693ced1d > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd > > Diff: https://reviews.apache.org/r/39803/diff/ > > > Testing > --- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review112686 --- 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp (line 65) <https://reviews.apache.org/r/39803/#comment173187> typo: sybolic->symbolic 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp (line 84) <https://reviews.apache.org/r/39803/#comment173189> We are not calling lstat here. - Yi Sun On Jan. 4, 2016, 11:26 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39803/ > --- > > (Updated Jan. 4, 2016, 11:26 p.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Windows: Implemented stout/os/stat.hpp`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > PRE-CREATION > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp > 5b38b9af654d7d1c574f0cc573083b66693ced1d > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd > > Diff: https://reviews.apache.org/r/39803/diff/ > > > Testing > --- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
