Re: Review Request 39154: Log IP addresses together with failure messages.

2016-07-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39154/#review141491
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Oct. 9, 2015, 1:42 a.m., Brice Arnould wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39154/
> ---
> 
> (Updated Oct. 9, 2015, 1:42 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1661
> https://issues.apache.org/jira/browse/MESOS-1661
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Log IP addresses together with failure messages.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp 
> 28ed102972a9d8f88048aea4046ed837b6a25b35 
> 
> Diff: https://reviews.apache.org/r/39154/diff/
> 
> 
> Testing
> ---
> 
> Ran "make check"
> 
> 
> Thanks,
> 
> Brice Arnould
> 
>

Re: Review Request 39154: Log IP addresses together with failure messages.

2015-10-09 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39154/#review102026
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Oct. 9, 2015, 1:42 a.m., Brice Arnould wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39154/
> ---
> 
> (Updated Oct. 9, 2015, 1:42 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1661
> https://issues.apache.org/jira/browse/MESOS-1661
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Log IP addresses together with failure messages.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp 
> 28ed102972a9d8f88048aea4046ed837b6a25b35 
> 
> Diff: https://reviews.apache.org/r/39154/diff/
> 
> 
> Testing
> ---
> 
> Ran "make check"
> 
> 
> Thanks,
> 
> Brice Arnould
> 
>

Re: Review Request 39154: Log IP addresses together with failure messages.

2015-10-08 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39154/#review102002
---



3rdparty/libprocess/src/poll_socket.cpp (line 31)


Would help me to understand why `anonymous` is necessary here?



3rdparty/libprocess/src/poll_socket.cpp (line 32)


Personally, `stringify_` maybe better.



3rdparty/libprocess/src/poll_socket.cpp (line 113)


`Socket` has the following API, is it OK to use to get address?

  Try address() const
  {
return impl->address();
  }



3rdparty/libprocess/src/poll_socket.cpp (line 167)


s/.//



3rdparty/libprocess/src/poll_socket.cpp (line 178)


s/failed/ failed/



3rdparty/libprocess/src/poll_socket.cpp (line 206)


s/failed/ failed/



3rdparty/libprocess/src/poll_socket.cpp (line 218)


Can we pass `this` as parameter? So all info are there in 
`socket_send_data`; I'd like to leave this to your shepherd.


- Klaus Ma


On Oct. 9, 2015, 1:42 a.m., Brice Arnould wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39154/
> ---
> 
> (Updated Oct. 9, 2015, 1:42 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1661
> https://issues.apache.org/jira/browse/MESOS-1661
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Log IP addresses together with failure messages.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp 
> 28ed102972a9d8f88048aea4046ed837b6a25b35 
> 
> Diff: https://reviews.apache.org/r/39154/diff/
> 
> 
> Testing
> ---
> 
> Ran "make check"
> 
> 
> Thanks,
> 
> Brice Arnould
> 
>

Re: Review Request 39154: Log IP addresses together with failure messages.

2015-10-08 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39154/#review102003
---


BTW, please add your shepherd into pepole field.

- Klaus Ma


On Oct. 9, 2015, 1:42 a.m., Brice Arnould wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39154/
> ---
> 
> (Updated Oct. 9, 2015, 1:42 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1661
> https://issues.apache.org/jira/browse/MESOS-1661
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Log IP addresses together with failure messages.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp 
> 28ed102972a9d8f88048aea4046ed837b6a25b35 
> 
> Diff: https://reviews.apache.org/r/39154/diff/
> 
> 
> Testing
> ---
> 
> Ran "make check"
> 
> 
> Thanks,
> 
> Brice Arnould
> 
>