Re: Review Request 40225: Fixed the Review Board URL in the commit message.

2015-11-14 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40225/
---

(Updated Nov. 14, 2015, 9:08 a.m.)


Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and 
Vinod Kone.


Summary (updated)
-

Fixed the Review Board URL in the commit message.


Repository: mesos


Description
---

Adjusted Review Board URL in comment.


Diffs
-

  support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 

Diff: https://reviews.apache.org/r/40225/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

2015-11-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40225/#review106305
---

Ship it!


Ship It!

- Vinod Kone


On Nov. 12, 2015, 7:12 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40225/
> ---
> 
> (Updated Nov. 12, 2015, 7:12 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted Review Board URL in comment.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 
> 
> Diff: https://reviews.apache.org/r/40225/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

2015-11-12 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40225/
---

(Updated Nov. 12, 2015, 11:12 a.m.)


Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and 
Vinod Kone.


Changes
---

Addressed comment.


Repository: mesos


Description
---

Adjusted Review Board URL in comment.


Diffs (updated)
-

  support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 

Diff: https://reviews.apache.org/r/40225/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

2015-11-12 Thread Vinod Kone 


> On Nov. 12, 2015, 6 p.m., Vinod Kone wrote:
> > support/apply-reviews.py, line 23
> > 
> >
> > s/ui_//
> > 
> > What's a UI URL?
> 
> Artem Harutyunyan wrote:
> BenM noticed that instead of putting the Review Board UI URL in the 
> commit message (as in https://reviews.apache.org/r/40225/) we had a Review 
> Board API URL there (as in 
> https://reviews.apache.org/api/review-requests/40225/).
> 
> Artem Harutyunyan wrote:
> RB mangled the second link, it should be  
> https://reviews.apache.org/api/review-requests/40225/
> 
> Do you have a suggestion for a better name?

how about just calling it review_url since we already named the other thing 
review_api_url


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40225/#review106276
---


On Nov. 12, 2015, 5:56 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40225/
> ---
> 
> (Updated Nov. 12, 2015, 5:56 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted Review Board URL in comment.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 
> 
> Diff: https://reviews.apache.org/r/40225/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

2015-11-12 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40225/
---

(Updated Nov. 12, 2015, 9:56 a.m.)


Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and 
Vinod Kone.


Changes
---

Splitting the commit into two following Ben Mahler's suggestion.


Repository: mesos


Description (updated)
---

Adjusted Review Board URL in comment.


Diffs (updated)
-

  support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 

Diff: https://reviews.apache.org/r/40225/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

2015-11-12 Thread Artem Harutyunyan 


> On Nov. 12, 2015, 10 a.m., Vinod Kone wrote:
> > support/apply-reviews.py, line 23
> > 
> >
> > s/ui_//
> > 
> > What's a UI URL?
> 
> Artem Harutyunyan wrote:
> BenM noticed that instead of putting the Review Board UI URL in the 
> commit message (as in https://reviews.apache.org/r/40225/) we had a Review 
> Board API URL there (as in 
> https://reviews.apache.org/api/review-requests/40225/).

RB mangled the second link, it should be  
https://reviews.apache.org/api/review-requests/40225/

Do you have a suggestion for a better name?


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40225/#review106276
---


On Nov. 12, 2015, 9:56 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40225/
> ---
> 
> (Updated Nov. 12, 2015, 9:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted Review Board URL in comment.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 
> 
> Diff: https://reviews.apache.org/r/40225/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

2015-11-12 Thread Artem Harutyunyan 


> On Nov. 12, 2015, 10 a.m., Vinod Kone wrote:
> > support/apply-reviews.py, line 23
> > 
> >
> > s/ui_//
> > 
> > What's a UI URL?

BenM noticed that instead of putting the Review Board UI URL in the commit 
message (as in https://reviews.apache.org/r/40225/) we had a Review Board API 
URL there (as in https://reviews.apache.org/api/review-requests/40225/).


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40225/#review106276
---


On Nov. 12, 2015, 9:56 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40225/
> ---
> 
> (Updated Nov. 12, 2015, 9:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted Review Board URL in comment.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 
> 
> Diff: https://reviews.apache.org/r/40225/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

2015-11-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40225/#review106276
---



support/apply-reviews.py (line 22)


s/ui_//

What's a UI URL?


- Vinod Kone


On Nov. 12, 2015, 5:56 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40225/
> ---
> 
> (Updated Nov. 12, 2015, 5:56 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted Review Board URL in comment.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 
> 
> Diff: https://reviews.apache.org/r/40225/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

2015-11-12 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40225/
---

(Updated Nov. 12, 2015, 2:57 a.m.)


Review request for mesos, Ben Mahler, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Fixed a bug with hanging editor reported by Ben Mahler and adjusted Review 
Board URL in comment.


Diffs
-

  support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 

Diff: https://reviews.apache.org/r/40225/diff/


Testing
---


Thanks,

Artem Harutyunyan