Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-04-07 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/
---

(Updated April 7, 2016, 7:35 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
9ee233b988c08d953e70345c55bcdd5c2f7c101b 

Diff: https://reviews.apache.org/r/44081/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-04-07 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/
---

(Updated April 7, 2016, 9:11 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
9ee233b988c08d953e70345c55bcdd5c2f7c101b 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
6a391ff198ab724f689bcef79d4e2e05a786cbc2 

Diff: https://reviews.apache.org/r/44081/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-04-04 Thread Michael Park 


> On March 18, 2016, 7:27 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 118
> > 
> >
> > This is not necessarily `LD_LIBRARY_PATH` anymore, right? Here and 
> > below.
> 
> Alex Clemmer wrote:
> That's right, but the only platform that's not true on is Windows, where 
> this functionality is not really available. Since we have no chance to 
> generalize it to the Windows case, my inclination is to keep it as is.

Sounds good.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/#review124257
---


On March 31, 2016, 5:15 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44081/
> ---
> 
> (Updated March 31, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 9ee233b988c08d953e70345c55bcdd5c2f7c101b 
> 
> Diff: https://reviews.apache.org/r/44081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-03-31 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/
---

(Updated March 31, 2016, 5:15 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
9ee233b988c08d953e70345c55bcdd5c2f7c101b 

Diff: https://reviews.apache.org/r/44081/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-03-31 Thread Alex Clemmer 


> On March 18, 2016, 7:27 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 118
> > 
> >
> > This is not necessarily `LD_LIBRARY_PATH` anymore, right? Here and 
> > below.

That's right, but the only platform that's not true on is Windows, where this 
functionality is not really available. Since we have no chance to generalize it 
to the Windows case, my inclination is to keep it as is.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/#review124257
---


On March 14, 2016, 9:10 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44081/
> ---
> 
> (Updated March 14, 2016, 9:10 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 9ee233b988c08d953e70345c55bcdd5c2f7c101b 
> 
> Diff: https://reviews.apache.org/r/44081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-03-19 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/#review124257
---




3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (lines 74 - 76)


We should make this a `namespace` similar to what we did for `Shell` in 
`shell.hpp`.



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 78)


`s/process.lib/process.dll/`, right?



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 79)


Once `Library` is a `namespace`, this should no longer be declared 
`static`. Here and below.



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 118)


This is not necessarily `LD_LIBRARY_PATH` anymore, right? Here and below.



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 131)


`setenv` in `stout/windows/os.hpp` is commented out and unimplemeneted. How 
does this work?


- Michael Park


On March 14, 2016, 9:10 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44081/
> ---
> 
> (Updated March 14, 2016, 9:10 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 9ee233b988c08d953e70345c55bcdd5c2f7c101b 
> 
> Diff: https://reviews.apache.org/r/44081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-03-18 Thread Michael Park 


> On March 18, 2016, 7:27 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 131
> > 
> >
> > `setenv` in `stout/windows/os.hpp` is commented out and unimplemeneted. 
> > How does this work?

This seems to be tackled in https://reviews.apache.org/r/44082.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/#review124257
---


On March 14, 2016, 9:10 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44081/
> ---
> 
> (Updated March 14, 2016, 9:10 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 9ee233b988c08d953e70345c55bcdd5c2f7c101b 
> 
> Diff: https://reviews.apache.org/r/44081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-03-14 Thread Yi Sun 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/#review123541
---


Ship it!




Ship It!

- Yi Sun


On March 14, 2016, 9:10 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44081/
> ---
> 
> (Updated March 14, 2016, 9:10 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 9ee233b988c08d953e70345c55bcdd5c2f7c101b 
> 
> Diff: https://reviews.apache.org/r/44081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>