Re: Review Request 44851: Renamed an allocator metric.

[Ben Mahler]

> On March 22, 2016, 5:50 p.m., Ben Mahler wrote:
> > The changelog update would be great as well here, I'll take care of that 
> > before committing. Thanks!

I'll also update the existing test:

```
$ grep -R allocator/event_queue_dispatches src/tests
src/tests/master_tests.cpp:  EXPECT_EQ(1u, 
snapshot.values.count("allocator/event_queue_dispatches"));
```


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44851/#review124840
---


On March 22, 2016, 5:32 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44851/
> ---
> 
> (Updated March 22, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-5001
> https://issues.apache.org/jira/browse/MESOS-5001
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since allocators can be replaced with a custom module instead use a
> name clearly communicating that the metrics reported here are related
> to the default (hierarchical) allocator.
> 
> For backwards compatibility we continue to support the old metrics
> name.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338 
>   src/master/allocator/mesos/metrics.hpp 
> d04e9a11c77b6fb2d522608e3085f81f8a6657ca 
>   src/master/allocator/mesos/metrics.cpp 
> 46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace 
> 
> Diff: https://reviews.apache.org/r/44851/diff/
> 
> 
> Testing
> ---
> 
> check make check (OS X, clang-trunk) here and with later patches using other 
> allocator metrics.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44851: Renamed an allocator metric.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44851/#review124840
---


Fix it, then Ship it!




The changelog update would be great as well here, I'll take care of that before 
committing. Thanks!


docs/upgrades.md (line 157)


Looks like this is missing the "-x" from your href above?


- Ben Mahler


On March 22, 2016, 5:32 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44851/
> ---
> 
> (Updated March 22, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-5001
> https://issues.apache.org/jira/browse/MESOS-5001
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since allocators can be replaced with a custom module instead use a
> name clearly communicating that the metrics reported here are related
> to the default (hierarchical) allocator.
> 
> For backwards compatibility we continue to support the old metrics
> name.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338 
>   src/master/allocator/mesos/metrics.hpp 
> d04e9a11c77b6fb2d522608e3085f81f8a6657ca 
>   src/master/allocator/mesos/metrics.cpp 
> 46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace 
> 
> Diff: https://reviews.apache.org/r/44851/diff/
> 
> 
> Testing
> ---
> 
> check make check (OS X, clang-trunk) here and with later patches using other 
> allocator metrics.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44851: Renamed an allocator metric.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44851/
---

(Updated March 22, 2016, 6:32 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Fixed accidentally mutilation of unrelated paragraphs.


Bugs: MESOS-5001
https://issues.apache.org/jira/browse/MESOS-5001


Repository: mesos


Description
---

Since allocators can be replaced with a custom module instead use a
name clearly communicating that the metrics reported here are related
to the default (hierarchical) allocator.

For backwards compatibility we continue to support the old metrics
name.


Diffs (updated)
-

  docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338 
  src/master/allocator/mesos/metrics.hpp 
d04e9a11c77b6fb2d522608e3085f81f8a6657ca 
  src/master/allocator/mesos/metrics.cpp 
46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace 

Diff: https://reviews.apache.org/r/44851/diff/


Testing
---

check make check (OS X, clang-trunk) here and with later patches using other 
allocator metrics.


Thanks,

Benjamin Bannier

Re: Review Request 44851: Renamed an allocator metric.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44851/
---

(Updated March 22, 2016, 2:42 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Bugs: MESOS-5001
https://issues.apache.org/jira/browse/MESOS-5001


Repository: mesos


Description
---

Since allocators can be replaced with a custom module instead use a
name clearly communicating that the metrics reported here are related
to the default (hierarchical) allocator.

For backwards compatibility we continue to support the old metrics
name.


Diffs (updated)
-

  docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338 
  src/master/allocator/mesos/metrics.hpp 
d04e9a11c77b6fb2d522608e3085f81f8a6657ca 
  src/master/allocator/mesos/metrics.cpp 
46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace 

Diff: https://reviews.apache.org/r/44851/diff/


Testing
---

check make check (OS X, clang-trunk) here and with later patches using other 
allocator metrics.


Thanks,

Benjamin Bannier

Re: Review Request 44851: Renamed an allocator metric.

[Benjamin Bannier]

> On March 18, 2016, 3:59 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/metrics.hpp, lines 40-42
> > 
> >
> > Can you please file a JIRA to desribe the problem? Not quite catch why 
> > do we need to add a metrics in 0.29 and then remove it in 0.30?
> > 
> > Or else can you please update the comments to be more clear?

Follow-up commits will add more allocator-specific metrics. Since they are all 
specific to the mesos allocator we should properly communicate that in their 
names.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44851/#review124143
---


On March 17, 2016, 6:41 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44851/
> ---
> 
> (Updated March 17, 2016, 6:41 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since allocators can be replaced with a custom module instead use a
> name clearly communicating that the metrics reported here are related
> to the default (hierarchical) allocator.
> 
> For backwards compatibility we continue to support the old metrics
> name.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/metrics.hpp 
> d04e9a11c77b6fb2d522608e3085f81f8a6657ca 
>   src/master/allocator/mesos/metrics.cpp 
> 46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace 
> 
> Diff: https://reviews.apache.org/r/44851/diff/
> 
> 
> Testing
> ---
> 
> check make check (OS X, clang-trunk) here and with later patches using other 
> allocator metrics.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44851: Renamed an allocator metric.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44851/#review124143
---




src/master/allocator/mesos/metrics.hpp (lines 40 - 42)


Can you please file a JIRA to desribe the problem? Not quite catch why do 
we need to add a metrics in 0.29 and then remove it in 0.30?

Or else can you please update the comments to be more clear?


- Guangya Liu


On 三月 17, 2016, 5:41 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44851/
> ---
> 
> (Updated 三月 17, 2016, 5:41 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since allocators can be replaced with a custom module instead use a
> name clearly communicating that the metrics reported here are related
> to the default (hierarchical) allocator.
> 
> For backwards compatibility we continue to support the old metrics
> name.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/metrics.hpp 
> d04e9a11c77b6fb2d522608e3085f81f8a6657ca 
>   src/master/allocator/mesos/metrics.cpp 
> 46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace 
> 
> Diff: https://reviews.apache.org/r/44851/diff/
> 
> 
> Testing
> ---
> 
> check make check (OS X, clang-trunk) here and with later patches using other 
> allocator metrics.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44851: Renamed an allocator metric.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44851/
---

(Updated March 17, 2016, 6:41 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Be more explicit about deprecation.


Repository: mesos


Description
---

Since allocators can be replaced with a custom module instead use a
name clearly communicating that the metrics reported here are related
to the default (hierarchical) allocator.

For backwards compatibility we continue to support the old metrics
name.


Diffs (updated)
-

  src/master/allocator/mesos/metrics.hpp 
d04e9a11c77b6fb2d522608e3085f81f8a6657ca 
  src/master/allocator/mesos/metrics.cpp 
46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace 

Diff: https://reviews.apache.org/r/44851/diff/


Testing
---

check make check (OS X, clang-trunk) here and with later patches using other 
allocator metrics.


Thanks,

Benjamin Bannier

Re: Review Request 44851: Renamed an allocator metric.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44851/#review124053
---




src/master/allocator/mesos/metrics.hpp (lines 40 - 41)


Can you clarify here what the deprecation cycle is? It would be helpful to 
say that the new one was added in 0.29.0.

Could you also update the CHANGELOG with this deprecation and point users 
towards using the new metric name?


- Ben Mahler


On March 15, 2016, 2:51 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44851/
> ---
> 
> (Updated March 15, 2016, 2:51 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since allocators can be replaced with a custom module instead use a
> name clearly communicating that the metrics reported here are related
> to the default (hierarchical) allocator.
> 
> For backwards compatibility we continue to support the old metrics
> name.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/metrics.hpp 
> d04e9a11c77b6fb2d522608e3085f81f8a6657ca 
>   src/master/allocator/mesos/metrics.cpp 
> 46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace 
> 
> Diff: https://reviews.apache.org/r/44851/diff/
> 
> 
> Testing
> ---
> 
> check make check (OS X, clang-trunk) here and with later patches using other 
> allocator metrics.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>