Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48927/
---

(Updated June 22, 2016, 11:28 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebased


Bugs: MESOS-5502
https://issues.apache.org/jira/browse/MESOS-5502


Repository: mesos


Description
---

Implemented DESTROY_VOLUMES Call in v1 master API.


Diffs (updated)
-

  src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e 
  src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 

Diff: https://reviews.apache.org/r/48927/diff/


Testing
---

Please check https://reviews.apache.org/r/48938/ , which adds the test case for 
both create/destroy volumes api.


Thanks,

Shuai Lin

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48927/#review139004
---


Ship it!




Ship It!

- haosdent huang


On June 22, 2016, 12:53 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48927/
> ---
> 
> (Updated June 22, 2016, 12:53 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented DESTROY_VOLUMES Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 92504a4786b302828d080a1919c4eadb7a2392be 
>   src/master/master.hpp 98fb1fa3adab4dad5de156bf83a6c074eb2ffc64 
> 
> Diff: https://reviews.apache.org/r/48927/diff/
> 
> 
> Testing
> ---
> 
> Please check https://reviews.apache.org/r/48938/ , which adds the test case 
> for both create/destroy volumes api.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48927/
---

(Updated June 22, 2016, 12:53 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebased


Bugs: MESOS-5502
https://issues.apache.org/jira/browse/MESOS-5502


Repository: mesos


Description
---

Implemented DESTROY_VOLUMES Call in v1 master API.


Diffs (updated)
-

  src/master/http.cpp 92504a4786b302828d080a1919c4eadb7a2392be 
  src/master/master.hpp 98fb1fa3adab4dad5de156bf83a6c074eb2ffc64 

Diff: https://reviews.apache.org/r/48927/diff/


Testing
---

Please check https://reviews.apache.org/r/48938/ , which adds the test case for 
both create/destroy volumes api.


Thanks,

Shuai Lin

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48927/#review138913
---


Ship it!




Ship It!

- Vinod Kone


On June 21, 2016, 12:11 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48927/
> ---
> 
> (Updated June 21, 2016, 12:11 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented DESTROY_VOLUMES Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
>   src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
> 
> Diff: https://reviews.apache.org/r/48927/diff/
> 
> 
> Testing
> ---
> 
> Please check https://reviews.apache.org/r/48938/ , which adds the test case 
> for both create/destroy volumes api.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48927/
---

(Updated June 21, 2016, 12:11 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Use `_destroyVolumes` in old api as well.


Bugs: MESOS-5502
https://issues.apache.org/jira/browse/MESOS-5502


Repository: mesos


Description
---

Implemented DESTROY_VOLUMES Call in v1 master API.


Diffs (updated)
-

  src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
  src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 

Diff: https://reviews.apache.org/r/48927/diff/


Testing
---

Please check https://reviews.apache.org/r/48938/ , which adds the test case for 
both create/destroy volumes api.


Thanks,

Shuai Lin

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

[Shuai Lin]

> On June 20, 2016, 5:25 p.m., haosdent huang wrote:
> > src/master/http.cpp, lines 1234-1242
> > 
> >
> > How about update it to reuse
> > ```
> > Future Master::Http::_destroyVolumes(
> > ```

Good catch!


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48927/#review138639
---


On June 20, 2016, 1:59 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48927/
> ---
> 
> (Updated June 20, 2016, 1:59 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented DESTROY_VOLUMES Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
>   src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
> 
> Diff: https://reviews.apache.org/r/48927/diff/
> 
> 
> Testing
> ---
> 
> Please check https://reviews.apache.org/r/48938/ , which adds the test case 
> for both create/destroy volumes api.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48927/#review138704
---



LGTM modulo haosdent's comment.

- Vinod Kone


On June 20, 2016, 1:59 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48927/
> ---
> 
> (Updated June 20, 2016, 1:59 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented DESTROY_VOLUMES Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
>   src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
> 
> Diff: https://reviews.apache.org/r/48927/diff/
> 
> 
> Testing
> ---
> 
> Please check https://reviews.apache.org/r/48938/ , which adds the test case 
> for both create/destroy volumes api.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48927/#review138639
---




src/master/http.cpp (lines 1234 - 1242)


How about update it to reuse
```
Future Master::Http::_destroyVolumes(
```


- haosdent huang


On June 20, 2016, 1:59 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48927/
> ---
> 
> (Updated June 20, 2016, 1:59 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented DESTROY_VOLUMES Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
>   src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
> 
> Diff: https://reviews.apache.org/r/48927/diff/
> 
> 
> Testing
> ---
> 
> Please check https://reviews.apache.org/r/48938/ , which adds the test case 
> for both create/destroy volumes api.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48927/
---

(Updated June 20, 2016, 1:59 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-5502
https://issues.apache.org/jira/browse/MESOS-5502


Repository: mesos


Description
---

Implemented DESTROY_VOLUMES Call in v1 master API.


Diffs
-

  src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
  src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 

Diff: https://reviews.apache.org/r/48927/diff/


Testing (updated)
---

Please check https://reviews.apache.org/r/48938/ , which adds the test case for 
both create/destroy volumes api.


Thanks,

Shuai Lin

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48927/
---

(Updated June 20, 2016, 1:54 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-5502
https://issues.apache.org/jira/browse/MESOS-5502


Repository: mesos


Description
---

Implemented DESTROY_VOLUMES Call in v1 master API.


Diffs (updated)
-

  src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
  src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 

Diff: https://reviews.apache.org/r/48927/diff/


Testing
---

Would follow up with a test case for both create/destroy volumes api soon.


Thanks,

Shuai Lin

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48927/#review138473
---



Patch looks great!

Reviews applied: [48926, 48927]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 19, 2016, 4:43 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48927/
> ---
> 
> (Updated June 19, 2016, 4:43 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented DESTROY_VOLUMES Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
>   src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
> 
> Diff: https://reviews.apache.org/r/48927/diff/
> 
> 
> Testing
> ---
> 
> Would follow up with a test case for both create/destroy volumes api soon.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48927/
---

(Updated June 19, 2016, 4:43 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-5502
https://issues.apache.org/jira/browse/MESOS-5502


Repository: mesos


Description
---

Implemented DESTROY_VOLUMES Call in v1 master API.


Diffs
-

  src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
  src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 

Diff: https://reviews.apache.org/r/48927/diff/


Testing
---

Would follow up with a test case for both create/destroy volumes api soon.


Thanks,

Shuai Lin