Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/#review139126
---



Patch looks great!

Reviews applied: [48926, 48927, 48938]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 22, 2016, 11:28 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48938/
> ---
> 
> (Updated June 22, 2016, 11:28 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.CreateAndDetroyVolumes`.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 321e0ccf3fdeb30b3529caaa31cc6b565d467e1c 
>   src/internal/evolve.cpp 6b1cf3c4b69d0c39fca6d3bc8482b599494c4805 
>   src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2 
> 
> Diff: https://reviews.apache.org/r/48938/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-22 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/
---

(Updated June 22, 2016, 11:28 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebased


Bugs: MESOS-5502
https://issues.apache.org/jira/browse/MESOS-5502


Repository: mesos


Description
---

Added test case `MasterAPITest.CreateAndDetroyVolumes`.


Diffs (updated)
-

  src/internal/evolve.hpp 321e0ccf3fdeb30b3529caaa31cc6b565d467e1c 
  src/internal/evolve.cpp 6b1cf3c4b69d0c39fca6d3bc8482b599494c4805 
  src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2 

Diff: https://reviews.apache.org/r/48938/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc.


Thanks,

Shuai Lin

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/#review139030
---



Bad patch!

Reviews applied: [48938, 48927, 48926]

Failed command: ./support/apply-review.sh -n -r 48938

Error:
2016-06-22 08:08:48 URL:https://reviews.apache.org/r/48938/diff/raw/ 
[6457/6457] -> "48938.patch" [1]
error: patch failed: src/tests/api_tests.cpp:938
error: src/tests/api_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13936/console

- Mesos ReviewBot


On June 22, 2016, 12:53 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48938/
> ---
> 
> (Updated June 22, 2016, 12:53 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.CreateAndDetroyVolumes`.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 321e0ccf3fdeb30b3529caaa31cc6b565d467e1c 
>   src/internal/evolve.cpp 6b1cf3c4b69d0c39fca6d3bc8482b599494c4805 
>   src/tests/api_tests.cpp 8bc05432c758f8997bc89db1ff772c6910f0883c 
> 
> Diff: https://reviews.apache.org/r/48938/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/#review139003
---


Ship it!




Ship It!

- haosdent huang


On June 22, 2016, 12:53 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48938/
> ---
> 
> (Updated June 22, 2016, 12:53 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.CreateAndDetroyVolumes`.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 321e0ccf3fdeb30b3529caaa31cc6b565d467e1c 
>   src/internal/evolve.cpp 6b1cf3c4b69d0c39fca6d3bc8482b599494c4805 
>   src/tests/api_tests.cpp 8bc05432c758f8997bc89db1ff772c6910f0883c 
> 
> Diff: https://reviews.apache.org/r/48938/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/
---

(Updated June 22, 2016, 12:53 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebased


Bugs: MESOS-5502
https://issues.apache.org/jira/browse/MESOS-5502


Repository: mesos


Description
---

Added test case `MasterAPITest.CreateAndDetroyVolumes`.


Diffs (updated)
-

  src/internal/evolve.hpp 321e0ccf3fdeb30b3529caaa31cc6b565d467e1c 
  src/internal/evolve.cpp 6b1cf3c4b69d0c39fca6d3bc8482b599494c4805 
  src/tests/api_tests.cpp 8bc05432c758f8997bc89db1ff772c6910f0883c 

Diff: https://reviews.apache.org/r/48938/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc.


Thanks,

Shuai Lin

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/#review138914
---


Ship it!




Can you rebase?

- Vinod Kone


On June 21, 2016, 12:12 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48938/
> ---
> 
> (Updated June 21, 2016, 12:12 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.CreateAndDetroyVolumes`.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 7ce62d92a87f4885d8c4faab542c49d5bfb251d3 
>   src/internal/evolve.cpp 67c550342c06acdfcd0ed5cbe860ad29e41e6846 
>   src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf 
> 
> Diff: https://reviews.apache.org/r/48938/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/#review138837
---



Bad patch!

Reviews applied: [48938, 48927, 48926]

Failed command: ./support/apply-review.sh -n -r 48938

Error:
2016-06-21 14:46:27 URL:https://reviews.apache.org/r/48938/diff/raw/ 
[6433/6433] -> "48938.patch" [1]
error: patch failed: src/tests/api_tests.cpp:57
error: src/tests/api_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13922/console

- Mesos ReviewBot


On June 21, 2016, 12:12 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48938/
> ---
> 
> (Updated June 21, 2016, 12:12 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.CreateAndDetroyVolumes`.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 7ce62d92a87f4885d8c4faab542c49d5bfb251d3 
>   src/internal/evolve.cpp 67c550342c06acdfcd0ed5cbe860ad29e41e6846 
>   src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf 
> 
> Diff: https://reviews.apache.org/r/48938/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/
---

(Updated June 21, 2016, 12:12 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Address review comments.


Bugs: MESOS-5502
https://issues.apache.org/jira/browse/MESOS-5502


Repository: mesos


Description
---

Added test case `MasterAPITest.CreateAndDetroyVolumes`.


Diffs (updated)
-

  src/internal/evolve.hpp 7ce62d92a87f4885d8c4faab542c49d5bfb251d3 
  src/internal/evolve.cpp 67c550342c06acdfcd0ed5cbe860ad29e41e6846 
  src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf 

Diff: https://reviews.apache.org/r/48938/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc.


Thanks,

Shuai Lin

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Shuai Lin 


> On June 20, 2016, 5:36 p.m., haosdent huang wrote:
> > src/tests/api_tests.cpp, line 765
> > 
> >
> > Insert a blank line below, refer to 
> > https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#empty-lines

Thanks for the tip.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/#review138642
---


On June 20, 2016, 1:54 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48938/
> ---
> 
> (Updated June 20, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.CreateAndDetroyVolumes`.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 7ce62d92a87f4885d8c4faab542c49d5bfb251d3 
>   src/internal/evolve.cpp 67c550342c06acdfcd0ed5cbe860ad29e41e6846 
>   src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf 
> 
> Diff: https://reviews.apache.org/r/48938/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-20 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/#review138705
---




src/internal/evolve.cpp (line 163)


2 blank lines.



src/tests/api_tests.cpp (line 741)


s/api/API/



src/tests/api_tests.cpp (line 742)


s/api/API/



src/tests/api_tests.cpp (line 743)


s/the volume/using the volume/

s/api/API/



src/tests/api_tests.cpp (line 751)


s/api/API/


- Vinod Kone


On June 20, 2016, 1:54 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48938/
> ---
> 
> (Updated June 20, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.CreateAndDetroyVolumes`.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 7ce62d92a87f4885d8c4faab542c49d5bfb251d3 
>   src/internal/evolve.cpp 67c550342c06acdfcd0ed5cbe860ad29e41e6846 
>   src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf 
> 
> Diff: https://reviews.apache.org/r/48938/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/#review138645
---



Patch looks great!

Reviews applied: [48926, 48927, 48938]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 20, 2016, 1:54 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48938/
> ---
> 
> (Updated June 20, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.CreateAndDetroyVolumes`.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 7ce62d92a87f4885d8c4faab542c49d5bfb251d3 
>   src/internal/evolve.cpp 67c550342c06acdfcd0ed5cbe860ad29e41e6846 
>   src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf 
> 
> Diff: https://reviews.apache.org/r/48938/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-20 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/#review138642
---




src/tests/api_tests.cpp (line 765)


Insert a blank line below, refer to 
https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#empty-lines



src/tests/api_tests.cpp (line 879)


I think need
```
AWAIT_READY(v1DestroyVolumesResponse) here
```
?


- haosdent huang


On June 20, 2016, 1:54 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48938/
> ---
> 
> (Updated June 20, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
> https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.CreateAndDetroyVolumes`.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 7ce62d92a87f4885d8c4faab542c49d5bfb251d3 
>   src/internal/evolve.cpp 67c550342c06acdfcd0ed5cbe860ad29e41e6846 
>   src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf 
> 
> Diff: https://reviews.apache.org/r/48938/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>