Re: Review Request 51668: Changed the nested ContainerID from hashmap to list in memory.

2016-09-12 Thread Gilbert Song 


> On Sept. 6, 2016, 4:16 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.hpp, line 333
> > 
> >
> > Any reason not use a 'vector'?
> 
> Jie Yu wrote:
> IN fact, why not use hashset here?

Actually, we dont track the containerIDs in a consistently ways. We used list, 
vector, hashset in our code for the group of `containerIds`. We should use 
`hashset` consistently.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51668/#review147941
---


On Sept. 12, 2016, 11:42 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51668/
> ---
> 
> (Updated Sept. 12, 2016, 11:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the nested ContainerID from hashmap to list in memory.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 078ef4f4e7bf5e1522804a720c51cfa5518d8efd 
> 
> Diff: https://reviews.apache.org/r/51668/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51668: Changed the nested ContainerID from hashmap to list in memory.

2016-09-12 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51668/
---

(Updated Sept. 12, 2016, 11:42 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
Wu, and Kevin Klues.


Repository: mesos


Description
---

Changed the nested ContainerID from hashmap to list in memory.


Diffs
-

  src/slave/containerizer/mesos/containerizer.hpp 
078ef4f4e7bf5e1522804a720c51cfa5518d8efd 

Diff: https://reviews.apache.org/r/51668/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 51668: Changed the nested ContainerID from hashmap to list in memory.

2016-09-11 Thread Jie Yu 


> On Sept. 6, 2016, 11:16 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.hpp, line 333
> > 
> >
> > Any reason not use a 'vector'?

IN fact, why not use hashset here?


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51668/#review147941
---


On Sept. 10, 2016, 10:15 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51668/
> ---
> 
> (Updated Sept. 10, 2016, 10:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the nested ContainerID from hashmap to list in memory.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 078ef4f4e7bf5e1522804a720c51cfa5518d8efd 
> 
> Diff: https://reviews.apache.org/r/51668/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 51668: Changed the nested ContainerID from hashmap to list in memory.

2016-09-10 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51668/
---

(Updated Sept. 10, 2016, 3:15 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
Wu, and Kevin Klues.


Repository: mesos


Description
---

Changed the nested ContainerID from hashmap to list in memory.


Diffs
-

  src/slave/containerizer/mesos/containerizer.hpp 
078ef4f4e7bf5e1522804a720c51cfa5518d8efd 

Diff: https://reviews.apache.org/r/51668/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 51668: Changed the nested ContainerID from hashmap to list in memory.

2016-09-06 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51668/#review147941
---




src/slave/containerizer/mesos/containerizer.hpp (line 333)


Any reason not use a 'vector'?


- Jie Yu


On Sept. 6, 2016, 9:53 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51668/
> ---
> 
> (Updated Sept. 6, 2016, 9:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the nested ContainerID from hashmap to list in memory.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 078ef4f4e7bf5e1522804a720c51cfa5518d8efd 
> 
> Diff: https://reviews.apache.org/r/51668/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>