Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/
---

(Updated March 15, 2017, 6:18 p.m.)


Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and 
Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-7004
https://issues.apache.org/jira/browse/MESOS-7004


Repository: mesos


Description
---

This patch updates the Mesos code to allow master and agent
to load multiple HTTP authenticator modules.


Diffs (updated)
-

  src/common/http.cpp 0848f70ad4fa9e67c74c9fbdd882d7ab5ed6eabf 


Diff: https://reviews.apache.org/r/56476/diff/7/

Changes: https://reviews.apache.org/r/56476/diff/6-7/


Testing
---

Still need to add tests which test the master and agent with multiple 
authenticator modules loaded.


Thanks,

Greg Mann

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/#review169005
---


Fix it, then Ship it!





src/common/http.cpp
Line 964 (original), 957 (patched)


This function is not "loading" the authenticator so logging so is a bit 
weird. maybe call it "creating" or move this statement to 
`initializeAuthenticators`



src/common/http.cpp
Line 987 (original), 977 (patched)


ditto. not "loading".


- Vinod Kone


On March 14, 2017, 5:07 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56476/
> ---
> 
> (Updated March 14, 2017, 5:07 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7004
> https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the Mesos code to allow master and agent
> to load multiple HTTP authenticator modules.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp 0848f70ad4fa9e67c74c9fbdd882d7ab5ed6eabf 
> 
> 
> Diff: https://reviews.apache.org/r/56476/diff/6/
> 
> 
> Testing
> ---
> 
> Still need to add tests which test the master and agent with multiple 
> authenticator modules loaded.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/
---

(Updated March 14, 2017, 5:07 p.m.)


Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and 
Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-7004
https://issues.apache.org/jira/browse/MESOS-7004


Repository: mesos


Description
---

This patch updates the Mesos code to allow master and agent
to load multiple HTTP authenticator modules.


Diffs (updated)
-

  src/common/http.cpp 0848f70ad4fa9e67c74c9fbdd882d7ab5ed6eabf 


Diff: https://reviews.apache.org/r/56476/diff/6/

Changes: https://reviews.apache.org/r/56476/diff/5-6/


Testing
---

Still need to add tests which test the master and agent with multiple 
authenticator modules loaded.


Thanks,

Greg Mann

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/
---

(Updated March 14, 2017, 5:32 a.m.)


Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and 
Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-7004
https://issues.apache.org/jira/browse/MESOS-7004


Repository: mesos


Description
---

This patch updates the Mesos code to allow master and agent
to load multiple HTTP authenticator modules.


Diffs (updated)
-

  src/common/http.cpp 0848f70ad4fa9e67c74c9fbdd882d7ab5ed6eabf 


Diff: https://reviews.apache.org/r/56476/diff/5/

Changes: https://reviews.apache.org/r/56476/diff/4-5/


Testing
---

Still need to add tests which test the master and agent with multiple 
authenticator modules loaded.


Thanks,

Greg Mann

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/#review168667
---




src/common/http.cpp
Line 975 (original), 965 (patched)


Custom authenticator case



src/common/http.cpp
Lines 996 (patched)


s/tryAuthenticator/authenticator_/



src/common/http.cpp
Lines 996-997 (patched)


create two helpers, one for basic and one for modules (later for JWT)



src/common/http.cpp
Line 991 (original), 1001 (patched)


s/Could not create/Failed to create/



src/common/http.cpp
Lines 1011 (patched)


s/tryAuthenticator/authenticator_/



src/common/http.cpp
Lines 1016 (patched)


s/Could not create/Failed to create/



src/common/http.cpp
Lines 1023-1024 (patched)


Remove comment


- Greg Mann


On March 9, 2017, 11:41 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56476/
> ---
> 
> (Updated March 9, 2017, 11:41 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7004
> https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the Mesos code to allow master and agent
> to load multiple HTTP authenticator modules.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp 0848f70ad4fa9e67c74c9fbdd882d7ab5ed6eabf 
> 
> 
> Diff: https://reviews.apache.org/r/56476/diff/4/
> 
> 
> Testing
> ---
> 
> Still need to add tests which test the master and agent with multiple 
> authenticator modules loaded.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/
---

(Updated March 9, 2017, 11:41 p.m.)


Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and 
Vinod Kone.


Changes
---

Reworked the patch to accommodate the new 'CombinedAuthenticator'.


Bugs: MESOS-7004
https://issues.apache.org/jira/browse/MESOS-7004


Repository: mesos


Description
---

This patch updates the Mesos code to allow master and agent
to load multiple HTTP authenticator modules.


Diffs (updated)
-

  src/common/http.cpp 0848f70ad4fa9e67c74c9fbdd882d7ab5ed6eabf 


Diff: https://reviews.apache.org/r/56476/diff/4/

Changes: https://reviews.apache.org/r/56476/diff/3-4/


Testing
---

Still need to add tests which test the master and agent with multiple 
authenticator modules loaded.


Thanks,

Greg Mann

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

[Greg Mann]

> On Feb. 9, 2017, 2:10 p.m., Jan Schlicht wrote:
> > src/common/http.cpp, line 910
> > 
> >
> > s/name/httpAuthenticatorName/
> > Just `name` feels too general.

I went with the compromise of `authenticatorName`.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/#review164922
---


On Feb. 11, 2017, 12:46 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56476/
> ---
> 
> (Updated Feb. 11, 2017, 12:46 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7004
> https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the Mesos code to allow master and agent
> to load multiple HTTP authenticator modules.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp abfbf7248beb2d4068be06b7f5f829d7617f943e 
> 
> Diff: https://reviews.apache.org/r/56476/diff/
> 
> 
> Testing
> ---
> 
> Still need to add tests which test the master and agent with multiple 
> authenticator modules loaded.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/
---

(Updated Feb. 11, 2017, 12:46 a.m.)


Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and 
Vinod Kone.


Changes
---

Renamed a variable.


Bugs: MESOS-7004
https://issues.apache.org/jira/browse/MESOS-7004


Repository: mesos


Description
---

This patch updates the Mesos code to allow master and agent
to load multiple HTTP authenticator modules.


Diffs (updated)
-

  src/common/http.cpp abfbf7248beb2d4068be06b7f5f829d7617f943e 

Diff: https://reviews.apache.org/r/56476/diff/


Testing
---

Still need to add tests which test the master and agent with multiple 
authenticator modules loaded.


Thanks,

Greg Mann

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/
---

(Updated Feb. 11, 2017, 12:24 a.m.)


Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and 
Vinod Kone.


Changes
---

Fixed indentation.


Bugs: MESOS-7004
https://issues.apache.org/jira/browse/MESOS-7004


Repository: mesos


Description
---

This patch updates the Mesos code to allow master and agent
to load multiple HTTP authenticator modules.


Diffs (updated)
-

  src/common/http.cpp abfbf7248beb2d4068be06b7f5f829d7617f943e 

Diff: https://reviews.apache.org/r/56476/diff/


Testing
---

Still need to add tests which test the master and agent with multiple 
authenticator modules loaded.


Thanks,

Greg Mann

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/#review164922
---


Fix it, then Ship it!





src/common/http.cpp (line 907)


s/name/httpAuthenticatorName/
Just `name` feels too general.



src/common/http.cpp (line 956)


Not yours, but please indent with 4 spaces.


- Jan Schlicht


On Feb. 9, 2017, 2:06 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56476/
> ---
> 
> (Updated Feb. 9, 2017, 2:06 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7004
> https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the Mesos code to allow master and agent
> to load multiple HTTP authenticator modules.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp abfbf7248beb2d4068be06b7f5f829d7617f943e 
> 
> Diff: https://reviews.apache.org/r/56476/diff/
> 
> 
> Testing
> ---
> 
> Still need to add tests which test the master and agent with multiple 
> authenticator modules loaded.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/#review164862
---



Patch looks great!

Reviews applied: [56474, 56475, 56476]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Feb. 9, 2017, 1:06 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56476/
> ---
> 
> (Updated Feb. 9, 2017, 1:06 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7004
> https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the Mesos code to allow master and agent
> to load multiple HTTP authenticator modules.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp abfbf7248beb2d4068be06b7f5f829d7617f943e 
> 
> Diff: https://reviews.apache.org/r/56476/diff/
> 
> 
> Testing
> ---
> 
> Still need to add tests which test the master and agent with multiple 
> authenticator modules loaded.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>