Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

2017-09-18 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review185569
---


Fix it, then Ship it!





src/tests/resources_tests.cpp
Lines 2251 (patched)


s/ResourcesTest/DiskResourcesTest/

In fact, this test a bit dense and has a bunch of if/elses, making it hard 
to read.

Either split this into 3 tests (or 6 tests):
```
DiskResourcesTest.RawSource
DiskResourcesTest.MountBlockSource
DiskResourcesTest.PathSource

DiskResourcesTest.RawSourceWithID
DiskResourcesTest.MountBlockSourceWithID
DiskResourcesTest.PathSourceWithID
```

Or parameterize this test:
```
DiskResourcesSourceTest
```

Given that expectation is different for each source type, i am leaning 
towards option 1 (3 tests or 6 tests). And you don't need to print the param 
anymore.


- Jie Yu


On Sept. 13, 2017, 3:23 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> ---
> 
> (Updated Sept. 13, 2017, 3:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
>   include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
>   src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
>   src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
>   src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 
> 
> 
> Diff: https://reviews.apache.org/r/58048/diff/6/
> 
> 
> Testing
> ---
> 
> make check (OS X, Fedora25)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

2017-09-19 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/
---

(Updated Sept. 19, 2017, 6:53 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
---

Used parameterized test as suggested by Jie.


Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312


Repository: mesos


Description
---

Ids will allow to create distinguishable resources, e.g., of RAW or
BLOCK type. We also add a metadata field which can be used to expose
additional disk information.


Diffs (updated)
-

  include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
  include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
  src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
  src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
  src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 


Diff: https://reviews.apache.org/r/58048/diff/7/

Changes: https://reviews.apache.org/r/58048/diff/6-7/


Testing
---

make check (OS X, Fedora25)


Thanks,

Benjamin Bannier

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

2017-09-19 Thread Benjamin Bannier 


> On Sept. 18, 2017, 7:06 p.m., Jie Yu wrote:
> > src/tests/resources_tests.cpp
> > Lines 2251 (patched)
> > 
> >
> > s/ResourcesTest/DiskResourcesTest/
> > 
> > In fact, this test a bit dense and has a bunch of if/elses, making it 
> > hard to read.
> > 
> > Either split this into 3 tests (or 6 tests):
> > ```
> > DiskResourcesTest.RawSource
> > DiskResourcesTest.MountBlockSource
> > DiskResourcesTest.PathSource
> > 
> > DiskResourcesTest.RawSourceWithID
> > DiskResourcesTest.MountBlockSourceWithID
> > DiskResourcesTest.PathSourceWithID
> > ```
> > 
> > Or parameterize this test:
> > ```
> > DiskResourcesSourceTest
> > ```
> > 
> > Given that expectation is different for each source type, i am leaning 
> > towards option 1 (3 tests or 6 tests). And you don't need to print the 
> > param anymore.

I went for a parameterized test as this allows to reuse most of the setup 
logic. The code still branches at two points, but I believe it should be better 
now that we do not manually loop over parameter permutations in the test case.

I also got rid of the parameter printing as it is clear from the running 
instantiation number.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review185569
---


On Sept. 19, 2017, 6:53 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> ---
> 
> (Updated Sept. 19, 2017, 6:53 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
>   include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
>   src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
>   src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
>   src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 
> 
> 
> Diff: https://reviews.apache.org/r/58048/diff/7/
> 
> 
> Testing
> ---
> 
> make check (OS X, Fedora25)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

2017-09-12 Thread Benjamin Bannier 


> On Sept. 2, 2017, 6:27 p.m., Jie Yu wrote:
> > This might need to be adjusted based on this:
> > https://github.com/container-storage-interface/spec/pull/97
> > 
> > so `id` should be string, and `metadata` is labels given the above PR goes 
> > through

Like you suggested below, I moved `id` to `Source`, and also added a `metadata` 
field.

While `id` is considered when evaluating identity in the matrix you gave above, 
`metadata` just participates via equality.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review184432
---


On Sept. 12, 2017, 3:14 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> ---
> 
> (Updated Sept. 12, 2017, 3:14 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
>   include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
>   src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
>   src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
>   src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 
> 
> 
> Diff: https://reviews.apache.org/r/58048/diff/5/
> 
> 
> Testing
> ---
> 
> make check (OS X, Fedora25)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

2017-09-12 Thread Benjamin Bannier 


> On Aug. 28, 2017, 8:24 p.m., Jie Yu wrote:
> > src/common/resources.cpp
> > Line 187 (original), 187 (patched)
> > 
> >
> > We also need to update `addable` and `subtractable` similar to what we 
> > did for persistent volumes.
> > 
> > Depending on the "disk" source type, the semantics is different:
> > 1. RAW w/ id:
> >- Cannot be split into smaller pieces
> >- Cannot be merged even if they are equal
> > 2. RAW w/o id:
> >- Can be split into smaller pieces
> >- Can be merged if RAW parts equal
> > 3. PATH w/ id:
> >- Can be split into smaller pieces
> >- Can be merged if PATH parts equal
> > 4. PATH w/o id:
> >- Same as PATH w/ id
> > 5. MOUNT w/ id:
> >- Cannot be split into smaller pieces
> >- Cannot be merged even if they are equal
> > 6. MOUNT w/o id:
> >- Same as MOUNT w/ id

I updated the code to follow these semantics. You did not mention `BLOCK` 
sources above; I gave them the same semantics as `RAW` sources.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review183960
---


On Sept. 12, 2017, 3:14 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> ---
> 
> (Updated Sept. 12, 2017, 3:14 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
>   include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
>   src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
>   src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
>   src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 
> 
> 
> Diff: https://reviews.apache.org/r/58048/diff/5/
> 
> 
> Testing
> ---
> 
> make check (OS X, Fedora25)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

2017-09-12 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/
---

(Updated Sept. 12, 2017, 3:14 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
---

Addressed a number of comments from Jie.


Summary (updated)
-

Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.


Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312


Repository: mesos


Description (updated)
---

Ids will allow to create distinguishable resources, e.g., of RAW or
BLOCK type. We also add a metadata field which can be used to expose
additional disk information.


Diffs (updated)
-

  include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
  include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
  src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
  src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
  src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 


Diff: https://reviews.apache.org/r/58048/diff/5/

Changes: https://reviews.apache.org/r/58048/diff/4-5/


Testing
---

make check (OS X, Fedora25)


Thanks,

Benjamin Bannier

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

2017-09-12 Thread Benjamin Bannier 


> On Sept. 6, 2017, 7:15 p.m., Jie Yu wrote:
> > include/mesos/mesos.proto
> > Lines 1044 (patched)
> > 
> >
> > Also, I'd suggest we put `id` into `source`. Given that the CSI spec 
> > change, we'll use string for `id` and `Labels` for metadata:
> > 
> > ```
> > message Source {
> >   optional string id;
> >   optional Labels metadata;
> > }
> > ```

Done, see above.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review184703
---


On Sept. 12, 2017, 3:14 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> ---
> 
> (Updated Sept. 12, 2017, 3:14 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
>   include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
>   src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
>   src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
>   src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 
> 
> 
> Diff: https://reviews.apache.org/r/58048/diff/5/
> 
> 
> Testing
> ---
> 
> make check (OS X, Fedora25)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

2017-09-12 Thread Benjamin Bannier 


> On April 17, 2017, 11:49 a.m., Jie Yu wrote:
> > src/tests/resources_tests.cpp
> > Lines 2255 (patched)
> > 
> >
> > instead of relying on 'count', let's use `size()` instead.
> 
> Qian Zhang wrote:
> I think here the intention is to count how many `disks` are in `(r1 + 
> r2)`, so `count()` should be the right method to call.
> 
> Benjamin Bannier wrote:
> Yes, exactly. Note that we could use `size` and explicit value checks 
> here, but this would introduce dependencies to the exact disk values which in 
> my opinion makes the code harder to understand.

I removed the code here, but `count` has incorrect semantics (number of users 
of shared resource instead of number of appearances of a specific `Resource`). 
I use `size` in newly added code now (an alternative possibility would have 
been to first filter for a `Resource` and then check the `size` of the result).


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review172076
---


On Sept. 12, 2017, 3:14 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> ---
> 
> (Updated Sept. 12, 2017, 3:14 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
>   include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
>   src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
>   src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
>   src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 
> 
> 
> Diff: https://reviews.apache.org/r/58048/diff/5/
> 
> 
> Testing
> ---
> 
> make check (OS X, Fedora25)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

2017-09-12 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review185248
---




src/common/resources.cpp
Lines 185 (patched)


hum, i think we also need to check? wondering if we need to fix the rest.
```
if (left.has_id() != right.has_id()) {
  return false;
}
```



src/common/resources.cpp
Lines 372 (patched)


I think we should treat BLOCK the same as MOUNT.



src/v1/resources.cpp
Lines 353-358 (original), 386-391 (patched)


Do you still need this?



src/v1/resources.cpp
Lines 487 (patched)


Ditto. Block should be treated the same as MOUNT



src/v1/resources.cpp
Lines 491-493 (patched)


I think for RAW and if id are equal, we should return true (same as we did 
for MOUNT)


- Jie Yu


On Sept. 12, 2017, 1:14 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> ---
> 
> (Updated Sept. 12, 2017, 1:14 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
>   include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
>   src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
>   src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
>   src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 
> 
> 
> Diff: https://reviews.apache.org/r/58048/diff/5/
> 
> 
> Testing
> ---
> 
> make check (OS X, Fedora25)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

2017-09-13 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/
---

(Updated Sept. 13, 2017, 5:23 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312


Repository: mesos


Description
---

Ids will allow to create distinguishable resources, e.g., of RAW or
BLOCK type. We also add a metadata field which can be used to expose
additional disk information.


Diffs (updated)
-

  include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
  include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
  src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
  src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
  src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 


Diff: https://reviews.apache.org/r/58048/diff/6/

Changes: https://reviews.apache.org/r/58048/diff/5-6/


Testing
---

make check (OS X, Fedora25)


Thanks,

Benjamin Bannier

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

2017-09-15 Thread Benjamin Bannier 


> On Sept. 13, 2017, 2:34 a.m., Jie Yu wrote:
> > src/common/resources.cpp
> > Lines 185 (patched)
> > 
> >
> > hum, i think we also need to check? wondering if we need to fix the 
> > rest.
> > ```
> > if (left.has_id() != right.has_id()) {
> >   return false;
> > }
> > ```

Yes, this was slightly broken. I pushed a fix in 
https://reviews.apache.org/r/62282/.


> On Sept. 13, 2017, 2:34 a.m., Jie Yu wrote:
> > src/common/resources.cpp
> > Lines 372 (patched)
> > 
> >
> > I think we should treat BLOCK the same as MOUNT.

Yes, per our offline discussion this makes sense to me now.


> On Sept. 13, 2017, 2:34 a.m., Jie Yu wrote:
> > src/v1/resources.cpp
> > Lines 353-358 (original), 386-391 (patched)
> > 
> >
> > Do you still need this?

Removed.


> On Sept. 13, 2017, 2:34 a.m., Jie Yu wrote:
> > src/v1/resources.cpp
> > Lines 491-493 (patched)
> > 
> >
> > I think for RAW and if id are equal, we should return true (same as we 
> > did for MOUNT)

Yes, this was missing. I updated the test to confirm self-containment 
(`assert(r.contains(r))`). I also fixed the unintentional fall-through in the 
handling of `MOUNT` just above.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review185248
---


On Sept. 13, 2017, 5:23 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> ---
> 
> (Updated Sept. 13, 2017, 5:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
>   include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
>   src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
>   src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
>   src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 
> 
> 
> Diff: https://reviews.apache.org/r/58048/diff/6/
> 
> 
> Testing
> ---
> 
> make check (OS X, Fedora25)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>