Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review184712
---




3rdparty/CMakeLists.txt
Lines 208 (patched)


This needs to change, but I'm not sure how to use cmake appropriately here. 
 We should be able to inherit the configure command from the main mesos build, 
I think.  How would I do this? Maybe an "add_subdirectory"?


- John Kordich


On Sept. 6, 2017, 12:05 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> ---
> 
> (Updated Sept. 6, 2017, 12:05 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus_sasl-2.1.27rc3.patch PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 4d5dc13f363f5d8886983d7dd06a5cecc177c345 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> faf94909f995f7486b5f9cb7532af58a90a9eed3 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
> ee5ea3dee3be197e923be544aab96806f0adf1cf 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
> 76cc007963b4cbe162556d03d3e41a0a5e660167 
>   src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 
> 2bc9b0890d384e9ce8d5d4679c974c5e88231eed 
> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review184717
---



Also make sure you pull the master branch and rebase so this review doesn't 
contain reverts.

- Joseph Wu


On Sept. 5, 2017, 5:05 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> ---
> 
> (Updated Sept. 5, 2017, 5:05 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus_sasl-2.1.27rc3.patch PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 4d5dc13f363f5d8886983d7dd06a5cecc177c345 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> faf94909f995f7486b5f9cb7532af58a90a9eed3 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
> ee5ea3dee3be197e923be544aab96806f0adf1cf 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
> 76cc007963b4cbe162556d03d3e41a0a5e660167 
>   src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 
> 2bc9b0890d384e9ce8d5d4679c974c5e88231eed 
> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/
---

(Updated Sept. 6, 2017, 8:35 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.


Changes
---

Rebased on master


Bugs: MESOS-3384
https://issues.apache.org/jira/browse/MESOS-3384


Repository: mesos


Description
---

Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
  3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
  3rdparty/cyrus_sasl-2.1.27rc3.patch PRE-CREATION 


Diff: https://reviews.apache.org/r/62105/diff/2/

Changes: https://reviews.apache.org/r/62105/diff/1-2/


Testing
---


Thanks,

John Kordich

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review184728
---




3rdparty/CMakeLists.txt
Lines 194 (patched)


Unless `cyrus_sasl` can build as both shared and static on Windows, we 
should code this specifically to `STATIC` instead of `${LIBRARY_LINKAGE}`.



3rdparty/CMakeLists.txt
Lines 197-198 (patched)


I think Joe ended up committing slightly different formatting conventions 
here, with another line break, e.g.:

```
set_target_properties(
cyrus_sasl PROPERTIES
...
)
```



3rdparty/CMakeLists.txt
Lines 208-209 (patched)


These two lines should be removed as `ExternalProject_Add` will default to 
"doing the right thing" and building with CMake (and we shouldn't ever hard 
code the generator here).

Also I don't mean "set to `${CMAKE_NOOP}` but instead not set at all (lines 
deleted).



3rdparty/cmake/Versions.cmake
Lines 7-8 (patched)


This is a question for Joe: should we place these two lines under the `else 
()` below, since this is only bundled on Windows? Otherwise it may confusingly 
indicate that all builds (including Linux) use this version, but on Linux we 
actually use the system library.



3rdparty/cyrus_sasl-2.1.27rc3.patch
Lines 1 (patched)


Since it's a patch, I won't review it too much. However, we should ensure 
we submit this change upstream to libsasl2, and at that point clean it up a bit.


- Andrew Schwartzmeyer


On Sept. 6, 2017, 1:35 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> ---
> 
> (Updated Sept. 6, 2017, 1:35 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus_sasl-2.1.27rc3.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[Joseph Wu]

> On Sept. 6, 2017, 1:48 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 197-198 (patched)
> > 
> >
> > I think Joe ended up committing slightly different formatting 
> > conventions here, with another line break, e.g.:
> > 
> > ```
> > set_target_properties(
> > cyrus_sasl PROPERTIES
> > ...
> > )
> > ```

Yes, and with the trailing parentheses on the same line as the last line with 
content (not by itself).


> On Sept. 6, 2017, 1:48 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/cmake/Versions.cmake
> > Lines 7-8 (patched)
> > 
> >
> > This is a question for Joe: should we place these two lines under the 
> > `else ()` below, since this is only bundled on Windows? Otherwise it may 
> > confusingly indicate that all builds (including Linux) use this version, 
> > but on Linux we actually use the system library.

Yeah, we should move these down into the Windows-only section


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review184728
---


On Sept. 6, 2017, 1:35 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> ---
> 
> (Updated Sept. 6, 2017, 1:35 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus_sasl-2.1.27rc3.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/
---

(Updated Sept. 7, 2017, 1:11 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.


Changes
---

Addressed comments


Bugs: MESOS-3384
https://issues.apache.org/jira/browse/MESOS-3384


Repository: mesos


Description
---

Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
  3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
  3rdparty/cyrus_sasl-2.1.27rc3.patch PRE-CREATION 


Diff: https://reviews.apache.org/r/62105/diff/3/

Changes: https://reviews.apache.org/r/62105/diff/2-3/


Testing
---


Thanks,

John Kordich

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[John Kordich via Review Board]

> On Sept. 6, 2017, 8:48 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/cyrus_sasl-2.1.27rc3.patch
> > Lines 1 (patched)
> > 
> >
> > Since it's a patch, I won't review it too much. However, we should 
> > ensure we submit this change upstream to libsasl2, and at that point clean 
> > it up a bit.

Unfortunately, they will not take this patch.  I had to make some changes to 
make libsasl2 build statically, and enabled it to build only one of the 
modules.  In order to build many of the authentication modules, many different 
development headers need to be installed on the system building those modules, 
which we don't have right now.  I could spend more time and make the build  
configurable so only modules which have headers would be built, but I think 
that's not within the scope of what I'm working on right now. But if Li thinks 
this is important, I'm fine with doing it.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review184728
---


On Sept. 7, 2017, 1:11 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> ---
> 
> (Updated Sept. 7, 2017, 1:11 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus_sasl-2.1.27rc3.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review184912
---




3rdparty/CMakeLists.txt
Lines 193-195 (patched)


We should actually call the target `sasl2` so that its target name matches 
that used on Linux.

Our goal is that this section of code contains all the necessary data to 
build and link to `sasl2`, such that any other target which needs to link to it 
can simply do `target_link_libraries(mesos PUBLIC sasl2)`. This can be acheived 
by keeping the target name identical, and setting the compilation definitions 
as public properties here.


- Andrew Schwartzmeyer


On Sept. 6, 2017, 6:11 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> ---
> 
> (Updated Sept. 6, 2017, 6:11 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus_sasl-2.1.27rc3.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/
---

(Updated Sept. 8, 2017, 10:13 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.


Changes
---

Addressed new comments


Bugs: MESOS-3384
https://issues.apache.org/jira/browse/MESOS-3384


Repository: mesos


Description
---

Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
  3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
  3rdparty/cyrus-sasl-2.1.27rc3.patch PRE-CREATION 


Diff: https://reviews.apache.org/r/62105/diff/4/

Changes: https://reviews.apache.org/r/62105/diff/3-4/


Testing
---


Thanks,

John Kordich

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review185613
---




3rdparty/CMakeLists.txt
Lines 189-213 (patched)


Formatting issues:

Since this is under a conditional, it all needs to be indented two spaces.

The call to `external` we ended up standardizing as `EXTERNAL` to 
distinguish our functions from CMake built-ins.

The `MAKE_INCLUDE_DIR` should come after `ExternalProject_Add` for 
consistency with the rest of the file.



3rdparty/CMakeLists.txt
Lines 192 (patched)


And this is just me being super nitpicky, but I was trying to keep the 
`` headers to the length of the comments above them, and I added a short 
project description after the the name so anyone new can easily know what the 
dependency is for. Final thing is that the link is to an FTP server, but I 
would recommend just linking to the homepage "https://cyrusimap.org/sasl/";.



3rdparty/CMakeLists.txt
Lines 201-202 (patched)


Since this is an unconditionally static library, the `IMPLIB` properties do 
not need to be defined (these are specifically for dealing with DLLs and their 
associated imports).



3rdparty/CMakeLists.txt
Lines 203-204 (patched)


Perfect!


- Andrew Schwartzmeyer


On Sept. 8, 2017, 3:13 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> ---
> 
> (Updated Sept. 8, 2017, 3:13 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus-sasl-2.1.27rc3.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/
---

(Updated Sept. 19, 2017, 4:57 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Greg Mann, Joseph 
Wu, and Till Toenshoff.


Changes
---

Addressed comments


Bugs: MESOS-3384
https://issues.apache.org/jira/browse/MESOS-3384


Repository: mesos


Description
---

Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
  3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
  3rdparty/cyrus-sasl-2.1.27rc3.patch PRE-CREATION 


Diff: https://reviews.apache.org/r/62105/diff/5/

Changes: https://reviews.apache.org/r/62105/diff/4-5/


Testing
---


Thanks,

John Kordich

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review185747
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Sept. 19, 2017, 9:57 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> ---
> 
> (Updated Sept. 19, 2017, 9:57 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Greg Mann, 
> Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus-sasl-2.1.27rc3.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review186622
---


Ship it!




I can make the tweaks listed below before committing.

Tested on Windows via:
```
cmake --build . --config Debug --target sasl2-2.1.27rc3
```


3rdparty/cyrus-sasl-2.1.27rc3.patch
Lines 10-14 (patched)


These could be `string(APPEND ...)`



3rdparty/cyrus-sasl-2.1.27rc3.patch
Lines 25-26 (patched)


What is this comment referring to?

I can remove it if not relevant.



3rdparty/cyrus-sasl-2.1.27rc3.patch
Lines 104-124 (patched)


Instead of commenting out, we can just delete these definitions within the 
patch.


- Joseph Wu


On Sept. 27, 2017, 12:19 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> ---
> 
> (Updated Sept. 27, 2017, 12:19 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Greg Mann, 
> Joseph Wu, Li Li, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus-sasl-2.1.27rc3.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> John Kordich
> 
>