Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-24 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/#review203775
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67247', '67099', '67282', '67059']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67059

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67059/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (105 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1000 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (35 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (769 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (793 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (734 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (759 ms total)

[--] Global test environment tear-down
[==] 981 tests from 95 test cases ran. (440516 ms total)
[  PASSED  ] 980 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] 
DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67059/logs/mesos-tests-stderr.log):

```
I0524 16:12:37.297600 21032 master.cpp:10843] Updating the state of task 
1d5d0213-21ca-4cfe-994d-eb62f07f5648 oI0524 16:12:37.140612 19832 exec.cpp:162] 
Version: 1.7.0
I0524 16:12:37.165616 22184 exec.cpp:236] Executor registered on agent 
cef0344d-7a02-417f-aadb-7eb5013cc9b4-S0
I0524 16:12:37.168619 18068 executor.cpp:178] Received SUBSCRIBED event
I0524 16:12:37.173619 18068 executor.cpp:182] Subscribed executor on 
windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0524 16:12:37.173619 18068 executor.cpp:178] Received LAUNCH event
I0524 16:12:37.178612 18068 executor.cpp:665] Starting task 
1d5d0213-21ca-4cfe-994d-eb62f07f5648
I0524 16:12:37.256613 18068 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0524 16:12:37.272620 18068 executor.cpp:678] Forked command at 16964
I0524 16:12:37.299602 18816 exec.cpp:445] Executor asked to shutdown
I0524 16:12:37.300601  8596 executor.cpp:178] Received SHUTDOWN event
I0524 16:12:37.300601  8596 executor.cpp:781] Shutting down
I0524 16:12:37.300601  8596 executor.cpp:894] Sending SIGTERM to process tree 
at pid 16f framework cef0344d-7a02-417f-aadb-7eb5013cc9b4- (latest state: 
TASK_KILLED, status update state: TASK_KILLED)
I0524 16:12:37.297600 16972 slave.cpp:3935] Shutting down framework 
cef0344d-7a02-417f-aadb-7eb5013cc9b4-
I0524 16:12:37.298601 16972 slave.cpp:6656] Shutting down executor 
'1d5d0213-21ca-4cfe-994d-eb62f07f5648' of framework 
cef0344d-7a02-417f-aadb-7eb5013cc9b4- at executor(1)@192.10.1.6:49351
I0524 16:12:37.299602 16972 slave.cpp:929] Agent terminating
W0524 16:12:37.300601 16972 slave.cpp:3931] Ignoring shutdown framework 
cef0344d-7a02-417f-aadb-7eb5013cc9b4- because it is terminating
I0524 16:12:37.300601 21032 master.cpp:10942] Removing task 
1d5d0213-21ca-4cfe-994d-eb62f07f5648 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework cef0344d-7a02-417f-aadb-7eb5013cc9b4- on 
agent cef0344d-7a02-417f-aadb-7eb5013cc9b4-S0 at slave(448)@192.10.1.6:49330 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 16:12:37.304608 21032 master.cpp:1293] Agent 
cef0344d-7a02-417f-aadb-7eb5013cc9b4-S0 at slave(448)@192.10.1.6:49330 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0524 16:12:37.304608 21032 master.cpp:3303] Disconnecting agent 
cef0344d-7a02-417f-aadb-7eb5013cc9b4-S0 at slave(448)@192.10.1.6:49330 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 16:12:37.304608 21032 master.cpp:3322] Deactivating agent 
cef0344d-7a02-417f-aadb-7eb5013cc9b4-S0 at slave(448)@192.10.1.6:49330 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-24 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/
---

(Updated May 24, 2018, 2:45 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
and Kevin Klues.


Changes
---

Changed dependency, improved README, and better pylint handling.


Bugs: MESOS-8770
https://issues.apache.org/jira/browse/MESOS-8770


Repository: mesos


Description
---

The scripts are in a temporary directory, support/python3.

The scripts have been ported using 2to3, the official tool to do so.
Many of these scripts require testing from the community before being
used by default.

The script building the virtual environment and the git hooks have
been updated to use the new scripts if the environment variable
`MESOSSUPPORTPYTHON` is set to `3` by the user.


Diffs (updated)
-

  support/README.md e812e9638ca555c56e4c52e52485240e75cb8229 
  support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
  support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
  support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
  support/python3/apply-reviews.py PRE-CREATION 
  support/python3/generate-endpoint-help.py PRE-CREATION 
  support/python3/jsonurl.py PRE-CREATION 
  support/python3/mesos-gtest-runner.py PRE-CREATION 
  support/python3/mesos-split.py PRE-CREATION 
  support/python3/mesos-style.py PRE-CREATION 
  support/python3/post-reviews.py PRE-CREATION 
  support/python3/push-commits.py PRE-CREATION 
  support/python3/test-upgrade.py PRE-CREATION 
  support/python3/verify-reviews.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67059/diff/4/

Changes: https://reviews.apache.org/r/67059/diff/3-4/


Testing
---

All the files are OK for our linter, I have tested `mesos-style.py` and 
`post-reviews.py` (used for this review request).

We will likely see error messages `TypeError: cannot use a string pattern on a 
bytes-like object`, they are very easy to fix (we just need to add 
`.decode("utf-8")` but detecting all of them requires to use the scripts. 
Please do so and create issues.


Thanks,

Armand Grillet

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-24 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/#review203732
---



Patch looks great!

Reviews applied: [67247, 67099, 67059]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 22, 2018, 3:55 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67059/
> ---
> 
> (Updated May 22, 2018, 3:55 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The scripts are in a temporary directory, support/python3.
> 
> The scripts have been ported using 2to3, the official tool to do so.
> Many of these scripts require testing from the community before being
> used by default.
> 
> The script building the virtual environment and the git hooks have
> been updated to use the new scripts if the environment variable
> `MESOSSUPPORTPYTHON` is set to `3` by the user.
> 
> 
> Diffs
> -
> 
>   support/README.md e812e9638ca555c56e4c52e52485240e75cb8229 
>   support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
>   support/python3/apply-reviews.py PRE-CREATION 
>   support/python3/generate-endpoint-help.py PRE-CREATION 
>   support/python3/jsonurl.py PRE-CREATION 
>   support/python3/mesos-gtest-runner.py PRE-CREATION 
>   support/python3/mesos-split.py PRE-CREATION 
>   support/python3/mesos-style.py PRE-CREATION 
>   support/python3/post-reviews.py PRE-CREATION 
>   support/python3/push-commits.py PRE-CREATION 
>   support/python3/test-upgrade.py PRE-CREATION 
>   support/python3/verify-reviews.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67059/diff/3/
> 
> 
> Testing
> ---
> 
> All the files are OK for our linter, I have tested `mesos-style.py` and 
> `post-reviews.py` (used for this review request).
> 
> We will likely see error messages `TypeError: cannot use a string pattern on 
> a bytes-like object`, they are very easy to fix (we just need to add 
> `.decode("utf-8")` but detecting all of them requires to use the scripts. 
> Please do so and create issues.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-23 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/#review203684
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On May 22, 2018, 8:55 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67059/
> ---
> 
> (Updated May 22, 2018, 8:55 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The scripts are in a temporary directory, support/python3.
> 
> The scripts have been ported using 2to3, the official tool to do so.
> Many of these scripts require testing from the community before being
> used by default.
> 
> The script building the virtual environment and the git hooks have
> been updated to use the new scripts if the environment variable
> `MESOSSUPPORTPYTHON` is set to `3` by the user.
> 
> 
> Diffs
> -
> 
>   support/README.md e812e9638ca555c56e4c52e52485240e75cb8229 
>   support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
>   support/python3/apply-reviews.py PRE-CREATION 
>   support/python3/generate-endpoint-help.py PRE-CREATION 
>   support/python3/jsonurl.py PRE-CREATION 
>   support/python3/mesos-gtest-runner.py PRE-CREATION 
>   support/python3/mesos-split.py PRE-CREATION 
>   support/python3/mesos-style.py PRE-CREATION 
>   support/python3/post-reviews.py PRE-CREATION 
>   support/python3/push-commits.py PRE-CREATION 
>   support/python3/test-upgrade.py PRE-CREATION 
>   support/python3/verify-reviews.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67059/diff/3/
> 
> 
> Testing
> ---
> 
> All the files are OK for our linter, I have tested `mesos-style.py` and 
> `post-reviews.py` (used for this review request).
> 
> We will likely see error messages `TypeError: cannot use a string pattern on 
> a bytes-like object`, they are very easy to fix (we just need to add 
> `.decode("utf-8")` but detecting all of them requires to use the scripts. 
> Please do so and create issues.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-22 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/#review203594
---



PASS: Mesos patch 67059 was successfully built and tested.

Reviews applied: `['67247', '67099', '67059']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67059

- Mesos Reviewbot Windows


On May 22, 2018, 3:55 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67059/
> ---
> 
> (Updated May 22, 2018, 3:55 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The scripts are in a temporary directory, support/python3.
> 
> The scripts have been ported using 2to3, the official tool to do so.
> Many of these scripts require testing from the community before being
> used by default.
> 
> The script building the virtual environment and the git hooks have
> been updated to use the new scripts if the environment variable
> `MESOSSUPPORTPYTHON` is set to `3` by the user.
> 
> 
> Diffs
> -
> 
>   support/README.md e812e9638ca555c56e4c52e52485240e75cb8229 
>   support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
>   support/python3/apply-reviews.py PRE-CREATION 
>   support/python3/generate-endpoint-help.py PRE-CREATION 
>   support/python3/jsonurl.py PRE-CREATION 
>   support/python3/mesos-gtest-runner.py PRE-CREATION 
>   support/python3/mesos-split.py PRE-CREATION 
>   support/python3/mesos-style.py PRE-CREATION 
>   support/python3/post-reviews.py PRE-CREATION 
>   support/python3/push-commits.py PRE-CREATION 
>   support/python3/test-upgrade.py PRE-CREATION 
>   support/python3/verify-reviews.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67059/diff/3/
> 
> 
> Testing
> ---
> 
> All the files are OK for our linter, I have tested `mesos-style.py` and 
> `post-reviews.py` (used for this review request).
> 
> We will likely see error messages `TypeError: cannot use a string pattern on 
> a bytes-like object`, they are very easy to fix (we just need to add 
> `.decode("utf-8")` but detecting all of them requires to use the scripts. 
> Please do so and create issues.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-22 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/
---

(Updated May 22, 2018, 3:55 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
and Kevin Klues.


Changes
---

Resolved issues raised in /r/67101/


Repository: mesos


Description
---

The scripts are in a temporary directory, support/python3.

The scripts have been ported using 2to3, the official tool to do so.
Many of these scripts require testing from the community before being
used by default.

The script building the virtual environment and the git hooks have
been updated to use the new scripts if the environment variable
`MESOSSUPPORTPYTHON` is set to `3` by the user.


Diffs (updated)
-

  support/README.md e812e9638ca555c56e4c52e52485240e75cb8229 
  support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
  support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
  support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
  support/python3/apply-reviews.py PRE-CREATION 
  support/python3/generate-endpoint-help.py PRE-CREATION 
  support/python3/jsonurl.py PRE-CREATION 
  support/python3/mesos-gtest-runner.py PRE-CREATION 
  support/python3/mesos-split.py PRE-CREATION 
  support/python3/mesos-style.py PRE-CREATION 
  support/python3/post-reviews.py PRE-CREATION 
  support/python3/push-commits.py PRE-CREATION 
  support/python3/test-upgrade.py PRE-CREATION 
  support/python3/verify-reviews.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67059/diff/3/

Changes: https://reviews.apache.org/r/67059/diff/2-3/


Testing
---

All the files are OK for our linter, I have tested `mesos-style.py` and 
`post-reviews.py` (used for this review request).

We will likely see error messages `TypeError: cannot use a string pattern on a 
bytes-like object`, they are very easy to fix (we just need to add 
`.decode("utf-8")` but detecting all of them requires to use the scripts. 
Please do so and create issues.


Thanks,

Armand Grillet

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-15 Thread Andrew Schwartzmeyer 


> On May 10, 2018, 1:34 p.m., Andrew Schwartzmeyer wrote:
> > support/build-virtualenv
> > Lines 49-51 (original), 49-51 (patched)
> > 
> >
> > I didn't know where else to comment to open this issue:
> > 
> > We should add a BIG AND LOUD deprecation warning to the existing 
> > scripts that devs must start using the Python 3 scripts, as on "June 1st" 
> > the existing Python 3 scripts WILL BE DELETED.
> > 
> > Something to that effect :)
> 
> Armand Grillet wrote:
> /r/67099/

Thanks!


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/#review202864
---


On May 11, 2018, 2:57 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67059/
> ---
> 
> (Updated May 11, 2018, 2:57 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The scripts are in a temporary directory, support/python3.
> 
> The scripts have been ported using 2to3, the official tool to do so.
> Many of these scripts require testing from the community before being
> used by default.
> 
> The script building the virtual environment and the git hooks have
> been updated to use the new scripts if the environment variable
> `MESOSSUPPORTPYTHON` is set to `3` by the user.
> 
> 
> Diffs
> -
> 
>   support/README.md e812e9638ca555c56e4c52e52485240e75cb8229 
>   support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
>   support/python3/apply-reviews.py PRE-CREATION 
>   support/python3/generate-endpoint-help.py PRE-CREATION 
>   support/python3/jsonurl.py PRE-CREATION 
>   support/python3/mesos-gtest-runner.py PRE-CREATION 
>   support/python3/mesos-split.py PRE-CREATION 
>   support/python3/mesos-style.py PRE-CREATION 
>   support/python3/post-reviews.py PRE-CREATION 
>   support/python3/push-commits.py PRE-CREATION 
>   support/python3/test-upgrade.py PRE-CREATION 
>   support/python3/verify-reviews.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67059/diff/2/
> 
> 
> Testing
> ---
> 
> All the files are OK for our linter, I have tested `mesos-style.py` and 
> `post-reviews.py` (used for this review request).
> 
> We will likely see error messages `TypeError: cannot use a string pattern on 
> a bytes-like object`, they are very easy to fix (we just need to add 
> `.decode("utf-8")` but detecting all of them requires to use the scripts. 
> Please do so and create issues.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-15 Thread Andrew Schwartzmeyer 


> On May 10, 2018, 1:34 p.m., Andrew Schwartzmeyer wrote:
> > support/python3/apply-reviews.py
> > Lines 2-17 (patched)
> > 
> >
> > It's unfortunate that due to a staged replacement, we can't review the 
> > diffs of these on ReviewBoard :/
> > 
> > Armand, for the purposes of review, could you put up a parallel review 
> > where the scripts are replaced so that we can review the diff, and then 
> > when it's given ship-its, we take the finished ported scripts and put them 
> > here (trusting they're the same as the reviewed ones).
> 
> Armand Grillet wrote:
> /r/67101/

Thanks!


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/#review202864
---


On May 11, 2018, 2:57 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67059/
> ---
> 
> (Updated May 11, 2018, 2:57 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The scripts are in a temporary directory, support/python3.
> 
> The scripts have been ported using 2to3, the official tool to do so.
> Many of these scripts require testing from the community before being
> used by default.
> 
> The script building the virtual environment and the git hooks have
> been updated to use the new scripts if the environment variable
> `MESOSSUPPORTPYTHON` is set to `3` by the user.
> 
> 
> Diffs
> -
> 
>   support/README.md e812e9638ca555c56e4c52e52485240e75cb8229 
>   support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
>   support/python3/apply-reviews.py PRE-CREATION 
>   support/python3/generate-endpoint-help.py PRE-CREATION 
>   support/python3/jsonurl.py PRE-CREATION 
>   support/python3/mesos-gtest-runner.py PRE-CREATION 
>   support/python3/mesos-split.py PRE-CREATION 
>   support/python3/mesos-style.py PRE-CREATION 
>   support/python3/post-reviews.py PRE-CREATION 
>   support/python3/push-commits.py PRE-CREATION 
>   support/python3/test-upgrade.py PRE-CREATION 
>   support/python3/verify-reviews.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67059/diff/2/
> 
> 
> Testing
> ---
> 
> All the files are OK for our linter, I have tested `mesos-style.py` and 
> `post-reviews.py` (used for this review request).
> 
> We will likely see error messages `TypeError: cannot use a string pattern on 
> a bytes-like object`, they are very easy to fix (we just need to add 
> `.decode("utf-8")` but detecting all of them requires to use the scripts. 
> Please do so and create issues.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-11 Thread Armand Grillet 


> On mai 10, 2018, 8:34 après-midi, Andrew Schwartzmeyer wrote:
> > support/build-virtualenv
> > Lines 49-51 (original), 49-51 (patched)
> > 
> >
> > I didn't know where else to comment to open this issue:
> > 
> > We should add a BIG AND LOUD deprecation warning to the existing 
> > scripts that devs must start using the Python 3 scripts, as on "June 1st" 
> > the existing Python 3 scripts WILL BE DELETED.
> > 
> > Something to that effect :)

/r/67099/


> On mai 10, 2018, 8:34 après-midi, Andrew Schwartzmeyer wrote:
> > support/python3/apply-reviews.py
> > Lines 2-17 (patched)
> > 
> >
> > It's unfortunate that due to a staged replacement, we can't review the 
> > diffs of these on ReviewBoard :/
> > 
> > Armand, for the purposes of review, could you put up a parallel review 
> > where the scripts are replaced so that we can review the diff, and then 
> > when it's given ship-its, we take the finished ported scripts and put them 
> > here (trusting they're the same as the reviewed ones).

/r/67101/


- Armand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/#review202864
---


On mai 11, 2018, 9:57 après-midi, Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67059/
> ---
> 
> (Updated mai 11, 2018, 9:57 après-midi)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The scripts are in a temporary directory, support/python3.
> 
> The scripts have been ported using 2to3, the official tool to do so.
> Many of these scripts require testing from the community before being
> used by default.
> 
> The script building the virtual environment and the git hooks have
> been updated to use the new scripts if the environment variable
> `MESOSSUPPORTPYTHON` is set to `3` by the user.
> 
> 
> Diffs
> -
> 
>   support/README.md e812e9638ca555c56e4c52e52485240e75cb8229 
>   support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
>   support/python3/apply-reviews.py PRE-CREATION 
>   support/python3/generate-endpoint-help.py PRE-CREATION 
>   support/python3/jsonurl.py PRE-CREATION 
>   support/python3/mesos-gtest-runner.py PRE-CREATION 
>   support/python3/mesos-split.py PRE-CREATION 
>   support/python3/mesos-style.py PRE-CREATION 
>   support/python3/post-reviews.py PRE-CREATION 
>   support/python3/push-commits.py PRE-CREATION 
>   support/python3/test-upgrade.py PRE-CREATION 
>   support/python3/verify-reviews.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67059/diff/2/
> 
> 
> Testing
> ---
> 
> All the files are OK for our linter, I have tested `mesos-style.py` and 
> `post-reviews.py` (used for this review request).
> 
> We will likely see error messages `TypeError: cannot use a string pattern on 
> a bytes-like object`, they are very easy to fix (we just need to add 
> `.decode("utf-8")` but detecting all of them requires to use the scripts. 
> Please do so and create issues.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-11 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/
---

(Updated mai 11, 2018, 9:57 après-midi)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
and Kevin Klues.


Changes
---

Fixed some issues, new review requests for the ones not fixed.


Repository: mesos


Description (updated)
---

The scripts are in a temporary directory, support/python3.

The scripts have been ported using 2to3, the official tool to do so.
Many of these scripts require testing from the community before being
used by default.

The script building the virtual environment and the git hooks have
been updated to use the new scripts if the environment variable
`MESOSSUPPORTPYTHON` is set to `3` by the user.


Diffs (updated)
-

  support/README.md e812e9638ca555c56e4c52e52485240e75cb8229 
  support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
  support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
  support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
  support/python3/apply-reviews.py PRE-CREATION 
  support/python3/generate-endpoint-help.py PRE-CREATION 
  support/python3/jsonurl.py PRE-CREATION 
  support/python3/mesos-gtest-runner.py PRE-CREATION 
  support/python3/mesos-split.py PRE-CREATION 
  support/python3/mesos-style.py PRE-CREATION 
  support/python3/post-reviews.py PRE-CREATION 
  support/python3/push-commits.py PRE-CREATION 
  support/python3/test-upgrade.py PRE-CREATION 
  support/python3/verify-reviews.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67059/diff/2/

Changes: https://reviews.apache.org/r/67059/diff/1-2/


Testing
---

All the files are OK for our linter, I have tested `mesos-style.py` and 
`post-reviews.py` (used for this review request).

We will likely see error messages `TypeError: cannot use a string pattern on a 
bytes-like object`, they are very easy to fix (we just need to add 
`.decode("utf-8")` but detecting all of them requires to use the scripts. 
Please do so and create issues.


Thanks,

Armand Grillet

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-10 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/#review202886
---



Patch looks great!

Reviews applied: [67055, 67059]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 10, 2018, 9:24 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67059/
> ---
> 
> (Updated May 10, 2018, 9:24 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The scripts are in a temporary directory, `support/python3`.
> 
> The scripts have been ported using `2to3`, the official tool to do so.
> Many of these scripts require testing from the community before being
> used by default.
> 
> The script building the virtual environment and the git hooks have
> been updated to use the new scripts.
> 
> 
> Diffs
> -
> 
>   support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
>   support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
>   support/python3/apply-reviews.py PRE-CREATION 
>   support/python3/generate-endpoint-help.py PRE-CREATION 
>   support/python3/jsonurl.py PRE-CREATION 
>   support/python3/mesos-gtest-runner.py PRE-CREATION 
>   support/python3/mesos-split.py PRE-CREATION 
>   support/python3/mesos-style.py PRE-CREATION 
>   support/python3/post-reviews.py PRE-CREATION 
>   support/python3/push-commits.py PRE-CREATION 
>   support/python3/test-upgrade.py PRE-CREATION 
>   support/python3/verify-reviews.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67059/diff/1/
> 
> 
> Testing
> ---
> 
> All the files are OK for our linter, I have tested `mesos-style.py` and 
> `post-reviews.py` (used for this review request).
> 
> We will likely see error messages `TypeError: cannot use a string pattern on 
> a bytes-like object`, they are very easy to fix (we just need to add 
> `.decode("utf-8")` but detecting all of them requires to use the scripts. 
> Please do so and create issues.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-10 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/#review202864
---




support/build-virtualenv
Lines 49-51 (original), 49-51 (patched)


I didn't know where else to comment to open this issue:

We should add a BIG AND LOUD deprecation warning to the existing scripts 
that devs must start using the Python 3 scripts, as on "June 1st" the existing 
Python 3 scripts WILL BE DELETED.

Something to that effect :)



support/hooks/commit-msg
Line 11 (original), 11 (patched)


I think we need to add `TODO`s to remember to change each of these back as 
we intend to move the scripts back fairly quickly.



support/hooks/post-rewrite
Line 33 (original), 33 (patched)


Ditto.



support/hooks/post-rewrite
Line 40 (original), 40 (patched)


Ditto.



support/python3/apply-reviews.py
Lines 1 (patched)


Can this reliably be set to `python3` so that the script isn't ever run 
with `python2`?



support/python3/apply-reviews.py
Lines 2-17 (patched)


It's unfortunate that due to a staged replacement, we can't review the 
diffs of these on ReviewBoard :/

Armand, for the purposes of review, could you put up a parallel review 
where the scripts are replaced so that we can review the diff, and then when 
it's given ship-its, we take the finished ported scripts and put them here 
(trusting they're the same as the reviewed ones).


- Andrew Schwartzmeyer


On May 10, 2018, 9:24 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67059/
> ---
> 
> (Updated May 10, 2018, 9:24 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The scripts are in a temporary directory, `support/python3`.
> 
> The scripts have been ported using `2to3`, the official tool to do so.
> Many of these scripts require testing from the community before being
> used by default.
> 
> The script building the virtual environment and the git hooks have
> been updated to use the new scripts.
> 
> 
> Diffs
> -
> 
>   support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
>   support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
>   support/python3/apply-reviews.py PRE-CREATION 
>   support/python3/generate-endpoint-help.py PRE-CREATION 
>   support/python3/jsonurl.py PRE-CREATION 
>   support/python3/mesos-gtest-runner.py PRE-CREATION 
>   support/python3/mesos-split.py PRE-CREATION 
>   support/python3/mesos-style.py PRE-CREATION 
>   support/python3/post-reviews.py PRE-CREATION 
>   support/python3/push-commits.py PRE-CREATION 
>   support/python3/test-upgrade.py PRE-CREATION 
>   support/python3/verify-reviews.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67059/diff/1/
> 
> 
> Testing
> ---
> 
> All the files are OK for our linter, I have tested `mesos-style.py` and 
> `post-reviews.py` (used for this review request).
> 
> We will likely see error messages `TypeError: cannot use a string pattern on 
> a bytes-like object`, they are very easy to fix (we just need to add 
> `.decode("utf-8")` but detecting all of them requires to use the scripts. 
> Please do so and create issues.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-10 Thread Andrew Schwartzmeyer 


> On May 10, 2018, 12:36 p.m., Benjamin Bannier wrote:
> > Thanks for the work of porting these over to python3 Armand!
> > 
> > Two more high-level comments:
> > 
> > * Why are we not using code compatible with both python2 and 3 instead of 
> > effectively forking the code? Maintaining two supposedly identical 
> > implementations requires more work and we risk of the implementations 
> > diverging as features are added to only one of them, see e.g., the 
> > autotools and cmake build setups. I don't think it is a good idea to 
> > introduce that additional amount of work for these scripts. 
> > * looking at the _Testing Done_ section, it sounds like only a part of the 
> > files have been verified, even though you want to "ported" versions for all 
> > scripts. We should not expect users to do rough verification; otherwise we 
> > risk of nobody adopting these scripts. Please do not add untested code to 
> > the repo.
> > 
> > I would feel much more comfortable if we'd write some temporary less pretty 
> > code which can support both python2 and 3, see e.g., 
> > http://python-future.org/overview.html and the tools for automatic 
> > migration listed there (which are IMO more advanced than `2to3`). We can 
> > always tidy it up the code should we decide to drop python2 support.
> > 
> > I am a -1 on this patch.

> Why are we not using code compatible with both python2 and 3 instead of 
> effectively forking the code?

Two parts to the answer to this question:

(1) We do not want to maintain single-source Python 2 and Python3  
compatibility because it's costly and unncessary. It can be done, but it's 
liable to break. So we want to move to Python 3 support _only_.

(2) We _do not_ want to have a fork of the code. The intention is to delete the 
Python 2 scripts about a week or two after these are merged, then `git mv 
support/python3/*.py support/`. So it's just a staged rewrite so that we don't 
immediately break developers' workflow.

Armand, I think as part of this staged rewrite, in the Python 2 scripts we 
should add really BIG AND LOUD DEPRECATION warnings that are emitted as they're 
used. To the point that I'm going to opena review issue ;)

> Please do not add untested code to the repo.

We don't intend to. That's why this WIP is up, so we all can try testing them 
before merging :) I have our CI team testing out `apply-reviews.py` right now; 
please help test anyway you can and report back here!


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/#review202861
---


On May 10, 2018, 9:24 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67059/
> ---
> 
> (Updated May 10, 2018, 9:24 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The scripts are in a temporary directory, `support/python3`.
> 
> The scripts have been ported using `2to3`, the official tool to do so.
> Many of these scripts require testing from the community before being
> used by default.
> 
> The script building the virtual environment and the git hooks have
> been updated to use the new scripts.
> 
> 
> Diffs
> -
> 
>   support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
>   support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
>   support/python3/apply-reviews.py PRE-CREATION 
>   support/python3/generate-endpoint-help.py PRE-CREATION 
>   support/python3/jsonurl.py PRE-CREATION 
>   support/python3/mesos-gtest-runner.py PRE-CREATION 
>   support/python3/mesos-split.py PRE-CREATION 
>   support/python3/mesos-style.py PRE-CREATION 
>   support/python3/post-reviews.py PRE-CREATION 
>   support/python3/push-commits.py PRE-CREATION 
>   support/python3/test-upgrade.py PRE-CREATION 
>   support/python3/verify-reviews.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67059/diff/1/
> 
> 
> Testing
> ---
> 
> All the files are OK for our linter, I have tested `mesos-style.py` and 
> `post-reviews.py` (used for this review request).
> 
> We will likely see error messages `TypeError: cannot use a string pattern on 
> a bytes-like object`, they are very easy to fix (we just need to add 
> `.decode("utf-8")` but detecting all of them requires to use the scripts. 
> Please do so and create issues.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-10 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/#review202861
---



Thanks for the work of porting these over to python3 Armand!

Two more high-level comments:

* Why are we not using code compatible with both python2 and 3 instead of 
effectively forking the code? Maintaining two supposedly identical 
implementations requires more work and we risk of the implementations diverging 
as features are added to only one of them, see e.g., the autotools and cmake 
build setups. I don't think it is a good idea to introduce that additional 
amount of work for these scripts. 
* looking at the _Testing Done_ section, it sounds like only a part of the 
files have been verified, even though you want to "ported" versions for all 
scripts. We should not expect users to do rough verification; otherwise we risk 
of nobody adopting these scripts. Please do not add untested code to the repo.

I would feel much more comfortable if we'd write some temporary less pretty 
code which can support both python2 and 3, see e.g., 
http://python-future.org/overview.html and the tools for automatic migration 
listed there (which are IMO more advanced than `2to3`). We can always tidy it 
up the code should we decide to drop python2 support.

I am a -1 on this patch.

- Benjamin Bannier


On May 10, 2018, 6:24 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67059/
> ---
> 
> (Updated May 10, 2018, 6:24 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The scripts are in a temporary directory, `support/python3`.
> 
> The scripts have been ported using `2to3`, the official tool to do so.
> Many of these scripts require testing from the community before being
> used by default.
> 
> The script building the virtual environment and the git hooks have
> been updated to use the new scripts.
> 
> 
> Diffs
> -
> 
>   support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
>   support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
>   support/python3/apply-reviews.py PRE-CREATION 
>   support/python3/generate-endpoint-help.py PRE-CREATION 
>   support/python3/jsonurl.py PRE-CREATION 
>   support/python3/mesos-gtest-runner.py PRE-CREATION 
>   support/python3/mesos-split.py PRE-CREATION 
>   support/python3/mesos-style.py PRE-CREATION 
>   support/python3/post-reviews.py PRE-CREATION 
>   support/python3/push-commits.py PRE-CREATION 
>   support/python3/test-upgrade.py PRE-CREATION 
>   support/python3/verify-reviews.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67059/diff/1/
> 
> 
> Testing
> ---
> 
> All the files are OK for our linter, I have tested `mesos-style.py` and 
> `post-reviews.py` (used for this review request).
> 
> We will likely see error messages `TypeError: cannot use a string pattern on 
> a bytes-like object`, they are very easy to fix (we just need to add 
> `.decode("utf-8")` but detecting all of them requires to use the scripts. 
> Please do so and create issues.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-10 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67059/#review202854
---



PASS: Mesos patch 67059 was successfully built and tested.

Reviews applied: `['67055', '67059']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67059

- Mesos Reviewbot Windows


On May 10, 2018, 4:24 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67059/
> ---
> 
> (Updated May 10, 2018, 4:24 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The scripts are in a temporary directory, `support/python3`.
> 
> The scripts have been ported using `2to3`, the official tool to do so.
> Many of these scripts require testing from the community before being
> used by default.
> 
> The script building the virtual environment and the git hooks have
> been updated to use the new scripts.
> 
> 
> Diffs
> -
> 
>   support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be 
>   support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 
>   support/python3/apply-reviews.py PRE-CREATION 
>   support/python3/generate-endpoint-help.py PRE-CREATION 
>   support/python3/jsonurl.py PRE-CREATION 
>   support/python3/mesos-gtest-runner.py PRE-CREATION 
>   support/python3/mesos-split.py PRE-CREATION 
>   support/python3/mesos-style.py PRE-CREATION 
>   support/python3/post-reviews.py PRE-CREATION 
>   support/python3/push-commits.py PRE-CREATION 
>   support/python3/test-upgrade.py PRE-CREATION 
>   support/python3/verify-reviews.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67059/diff/1/
> 
> 
> Testing
> ---
> 
> All the files are OK for our linter, I have tested `mesos-style.py` and 
> `post-reviews.py` (used for this review request).
> 
> We will likely see error messages `TypeError: cannot use a string pattern on 
> a bytes-like object`, they are very easy to fix (we just need to add 
> `.decode("utf-8")` but detecting all of them requires to use the scripts. 
> Please do so and create issues.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>