Re: Review Request 67823: Added a master benchmark test for metrics.

2018-07-31 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/
---

(Updated July 31, 2018, 5:22 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.


Bugs: MESOS-8911
https://issues.apache.org/jira/browse/MESOS-8911


Repository: mesos


Description
---

Added a master benchmark test for metrics.


Diffs (updated)
-

  src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 


Diff: https://reviews.apache.org/r/67823/diff/5/

Changes: https://reviews.apache.org/r/67823/diff/4-5/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67823: Added a master benchmark test for metrics.

2018-07-25 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/#review206475
---




src/tests/master_benchmarks.cpp
Lines 583-584 (patched)


It probably makes sense to disable master auth.


- Gastón Kleiman


On July 17, 2018, 6:47 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67823/
> ---
> 
> (Updated July 17, 2018, 6:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
> 
> 
> Bugs: MESOS-8911
> https://issues.apache.org/jira/browse/MESOS-8911
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a master benchmark test for metrics.
> 
> 
> Diffs
> -
> 
>   src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 
> 
> 
> Diff: https://reviews.apache.org/r/67823/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 67823: Added a master benchmark test for metrics.

2018-07-25 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/#review206471
---


Fix it, then Ship it!





src/tests/master_benchmarks.cpp
Lines 508 (patched)


I'd name this `numberOfActiveFrameworks` or `activeFrameworkCount`.



src/tests/master_benchmarks.cpp
Lines 553 (patched)


s/Wait all/Wait for/?


- Gastón Kleiman


On July 17, 2018, 6:47 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67823/
> ---
> 
> (Updated July 17, 2018, 6:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
> 
> 
> Bugs: MESOS-8911
> https://issues.apache.org/jira/browse/MESOS-8911
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a master benchmark test for metrics.
> 
> 
> Diffs
> -
> 
>   src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 
> 
> 
> Diff: https://reviews.apache.org/r/67823/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 67823: Added a master benchmark test for metrics.

2018-07-18 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/#review206200
---



Bad patch!

Reviews applied: [67823, 67187, 67878, 66870, 66856, 66855, 66843, 67814, 
67813, 67812, 67809, 67776, 66820, 67962]

Failed command: python support/apply-reviews.py -n -r 67809

Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-07-18 15:56:18 URL:https://reviews.apache.org/r/67809/diff/raw/ 
[5190/5190] -> "67809.patch" [1]
error: patch failed: src/master/master.hpp:380
error: src/master/master.hpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/22900/console

- Mesos Reviewbot


On July 17, 2018, 6:47 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67823/
> ---
> 
> (Updated July 17, 2018, 6:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
> 
> 
> Bugs: MESOS-8911
> https://issues.apache.org/jira/browse/MESOS-8911
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a master benchmark test for metrics.
> 
> 
> Diffs
> -
> 
>   src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 
> 
> 
> Diff: https://reviews.apache.org/r/67823/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 67823: Added a master benchmark test for metrics.

2018-07-17 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/#review206190
---



FAIL: Failed to apply the dependent review: 67809.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67809`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1949/mesos-review-67823

Relevant logs:

- 
[apply-review-67809-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1949/mesos-review-67823/logs/apply-review-67809-stdout.log):

```
error: patch failed: src/master/master.hpp:380
error: src/master/master.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On July 18, 2018, 1:47 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67823/
> ---
> 
> (Updated July 18, 2018, 1:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
> 
> 
> Bugs: MESOS-8911
> https://issues.apache.org/jira/browse/MESOS-8911
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a master benchmark test for metrics.
> 
> 
> Diffs
> -
> 
>   src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 
> 
> 
> Diff: https://reviews.apache.org/r/67823/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 67823: Added a master benchmark test for metrics.

2018-07-17 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/
---

(Updated July 18, 2018, 1:47 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.


Bugs: MESOS-8911
https://issues.apache.org/jira/browse/MESOS-8911


Repository: mesos


Description
---

Added a master benchmark test for metrics.


Diffs (updated)
-

  src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 


Diff: https://reviews.apache.org/r/67823/diff/4/

Changes: https://reviews.apache.org/r/67823/diff/3-4/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67823: Added a master benchmark test for metrics.

2018-07-09 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/#review205876
---



FAIL: Failed to apply the dependent review: 67813.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67813`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1887/mesos-review-67823

Relevant logs:

- 
[apply-review-67813-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1887/mesos-review-67823/logs/apply-review-67813-stdout.log):

```
error: patch failed: src/master/metrics.cpp:630
error: src/master/metrics.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On July 9, 2018, 9:08 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67823/
> ---
> 
> (Updated July 9, 2018, 9:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
> 
> 
> Bugs: MESOS-8911
> https://issues.apache.org/jira/browse/MESOS-8911
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a master benchmark test for metrics.
> 
> 
> Diffs
> -
> 
>   src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 
> 
> 
> Diff: https://reviews.apache.org/r/67823/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 67823: Added a master benchmark test for metrics.

2018-07-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/
---

(Updated July 9, 2018, 9:08 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.


Bugs: MESOS-8911
https://issues.apache.org/jira/browse/MESOS-8911


Repository: mesos


Description
---

Added a master benchmark test for metrics.


Diffs (updated)
-

  src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 


Diff: https://reviews.apache.org/r/67823/diff/3/

Changes: https://reviews.apache.org/r/67823/diff/2-3/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67823: Added a master benchmark test for metrics.

2018-07-04 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/#review205730
---



Patch looks great!

Reviews applied: [66882, 66819, 66820, 67808, 67809, 67812, 67813, 67814, 
66841, 66842, 66843, 67147, 66844, 66855, 66861, 66856, 66870, 66883, 67187, 
67235, 67823]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 3, 2018, 11:10 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67823/
> ---
> 
> (Updated July 3, 2018, 11:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
> 
> 
> Bugs: MESOS-8911
> https://issues.apache.org/jira/browse/MESOS-8911
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a master benchmark test for metrics.
> 
> 
> Diffs
> -
> 
>   src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 
> 
> 
> Diff: https://reviews.apache.org/r/67823/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 67823: Added a master benchmark test for metrics.

2018-07-03 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/#review205700
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66882', '66819', '66820', '67808', '67809', '67812', 
'67813', '67814', '66841', '66842', '66843', '67147', '66844', '66855', 
'66861', '66856', '66870', '66883', '67187', '67235', '67823']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67823

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67823/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (804 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (602 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1227 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (800 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1010 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (600 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5367 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5164 ms)
[--] 24 tests from DockerContainerizerTest (93548 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00717190BDB0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00717190C010.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @01CAC70715B8.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01CAC7CCF3B0.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01CAC81EE1F0.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67823/logs/mesos-tests-stderr.log):

```
I0703 23:52:05.459921  3464 authenticatee.cpp:259] Received SASL authentication 
step
I0703 23:52:05.459921   608 authenticator.cpp:232] Received SASL authentication 
step
I0703 23:52:05.459921   608 authenticator.cpp:318] Authentication success
I0703 23:52:05.460921  4608 authenticatee.cpp:299] Authentication success
I0703 23:52:05.460921  1696 master.cpp:9830] Successfully authenticated 
principal 'test-principal' at 
scheduler-e76bef89-a931-4544-9685-5ed32acf5e19@192.10.1.6:57425
I0703 23:52:05.461932  8588 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:57425
I0703 23:52:05.461932  4608 master.cpp:2941] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-e76bef89-a931-4544-9685-5ed32acf5e19@192.10.1.6:57425
I0703 23:52:05.461932  4608 master.cpp:2242] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0703 23:52:05.462924  3516 master.cpp:3022] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
E0703 23:52:05.467931  2100 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not recognized as an

Re: Review Request 67823: Added a master benchmark test for metrics.

2018-07-03 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/
---

(Updated July 3, 2018, 11:10 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.


Bugs: MESOS-8911
https://issues.apache.org/jira/browse/MESOS-8911


Repository: mesos


Description (updated)
---

Added a master benchmark test for metrics.


Diffs (updated)
-

  src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 


Diff: https://reviews.apache.org/r/67823/diff/2/

Changes: https://reviews.apache.org/r/67823/diff/1-2/


Testing
---


Thanks,

Greg Mann