Re: Review Request 71882: Added a stout function to compute relative paths.

2019-12-09 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71882/#review218986
---



Patch looks great!

Reviews applied: [71878, 71879, 71880, 71881, 71882]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Dec. 9, 2019, 8:48 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71882/
> ---
> 
> (Updated Dec. 9, 2019, 8:48 a.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-10062
> https://issues.apache.org/jira/browse/MESOS-10062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a stout function to compute relative paths.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/path.hpp 
> ba1f665ce94b9636d88a7ecce8643c56758f7b5c 
>   3rdparty/stout/tests/path_tests.cpp 
> 19dd910a534040468aeb48f15ebdf56dff32bc15 
> 
> 
> Diff: https://reviews.apache.org/r/71882/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71882: Added a stout function to compute relative paths.

2019-12-09 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71882/
---

(Updated Dec. 9, 2019, 5:48 p.m.)


Review request for mesos and Benno Evers.


Bugs: MESOS-10062
https://issues.apache.org/jira/browse/MESOS-10062


Repository: mesos


Description
---

Added a stout function to compute relative paths.


Diffs (updated)
-

  3rdparty/stout/include/stout/path.hpp 
ba1f665ce94b9636d88a7ecce8643c56758f7b5c 
  3rdparty/stout/tests/path_tests.cpp 19dd910a534040468aeb48f15ebdf56dff32bc15 


Diff: https://reviews.apache.org/r/71882/diff/2/

Changes: https://reviews.apache.org/r/71882/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 71882: Added a stout function to compute relative paths.

2019-12-09 Thread Benjamin Bannier 


> On Dec. 9, 2019, 1:09 p.m., Benno Evers wrote:
> > 3rdparty/stout/include/stout/path.hpp
> > Lines 21 (patched)
> > 
> >
> > This doesn't seem to be necessary anymore?

This is required for e.g., `CHECK_EQ` (now).


> On Dec. 9, 2019, 1:09 p.m., Benno Evers wrote:
> > 3rdparty/stout/include/stout/path.hpp
> > Lines 551 (patched)
> > 
> >
> > I found the description below easier to parse:
> > 
> > > Relative paths can only be computed between paths which are either 
> > both absolute or both relative.

Fixed.


> On Dec. 9, 2019, 1:09 p.m., Benno Evers wrote:
> > 3rdparty/stout/include/stout/path.hpp
> > Lines 590 (patched)
> > 
> >
> > How about
> > 
> > the range of `base`
> > 
> > the `base` range
> > 
> > the range `[base.begin(), base.end())`
> > 
> > to avoid the awkward backtick-single-quote?

Went with your first suggestion.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71882/#review218976
---


On Dec. 9, 2019, 5:48 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71882/
> ---
> 
> (Updated Dec. 9, 2019, 5:48 p.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-10062
> https://issues.apache.org/jira/browse/MESOS-10062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a stout function to compute relative paths.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/path.hpp 
> ba1f665ce94b9636d88a7ecce8643c56758f7b5c 
>   3rdparty/stout/tests/path_tests.cpp 
> 19dd910a534040468aeb48f15ebdf56dff32bc15 
> 
> 
> Diff: https://reviews.apache.org/r/71882/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71882: Added a stout function to compute relative paths.

2019-12-09 Thread Benno Evers 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71882/#review218976
---


Fix it, then Ship it!





3rdparty/stout/include/stout/path.hpp
Lines 21 (patched)


This doesn't seem to be necessary anymore?



3rdparty/stout/include/stout/path.hpp
Lines 551 (patched)


I found the description below easier to parse:

> Relative paths can only be computed between paths which are either both 
absolute or both relative.



3rdparty/stout/include/stout/path.hpp
Lines 556 (patched)


I personally don't really mind, but our styleguide doesn't seem to like 
this:

> Some trailing underscores are used to distinguish between similar 
variables in the same scope (think prime symbols), but this should be avoided 
as much as possible, including removing existing instances in the code base.



3rdparty/stout/include/stout/path.hpp
Lines 590 (patched)


How about

the range of `base`

the `base` range

the range `[base.begin(), base.end())`

to avoid the awkward backtick-single-quote?


- Benno Evers


On Dec. 5, 2019, 12:49 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71882/
> ---
> 
> (Updated Dec. 5, 2019, 12:49 p.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-10062
> https://issues.apache.org/jira/browse/MESOS-10062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a stout function to compute relative paths.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/path.hpp 
> ba1f665ce94b9636d88a7ecce8643c56758f7b5c 
>   3rdparty/stout/tests/path_tests.cpp 
> 19dd910a534040468aeb48f15ebdf56dff32bc15 
> 
> 
> Diff: https://reviews.apache.org/r/71882/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71882: Added a stout function to compute relative paths.

2019-12-05 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71882/#review218938
---



Bad patch!

Reviews applied: [71878, 71879, 71880, 71881, 71882]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71882"]

Error:
..
ibs/libev.a ../3rdparty/protobuf-3.5.0/src/.libs/libprotobuf.a 
../3rdparty/zookeeper-3.4.8/src/c/.libs/libzookeeper_mt.a -lz 
/usr/lib/x86_64-linux-gnu/libsvn_delta-1.so 
/usr/lib/x86_64-linux-gnu/libsvn_subr-1.so -lsasl2 
/usr/lib/x86_64-linux-gnu/libcurl-nss.so /usr/lib/x86_64-linux-gnu/libapr-1.so 
-lrt -L/usr/lib/gcc/x86_64-linux-gnu/4.8 
-L/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu 
-L/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../lib -L/lib/x86_64-linux-gnu 
-L/lib/../lib -L/usr/lib/x86_64-linux-gnu -L/usr/lib/../lib 
-L/usr/lib/gcc/x86_64-linux-gnu/4.8/../../.. -lstdc++ -lm -lc -lgcc_s 
/usr/lib/gcc/x86_64-linux-gnu/4.8/crtendS.o 
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/crtn.o  -O0   
-pthread -Wl,-soname -Wl,libmesos-1.10.0.so -o .libs/libmesos-1.10.0.so
removing 'build/bdist.linux-x86_64/egg' (and everything under it)
running bdist_wheel
running build
installing to build/bdist.linux-x86_64/wheel
running install
running install_lib
Skipping installation of build/bdist.linux-x86_64/wheel/mesos/__init__.py 
(namespace package)
copying mesos/interface/mesos_pb2.py -> 
build/bdist.linux-x86_64/wheel/mesos/interface
copying mesos/interface/__init__.py -> 
build/bdist.linux-x86_64/wheel/mesos/interface
running install_egg_info
Copying src/mesos.interface.egg-info to 
build/bdist.linux-x86_64/wheel/mesos.interface-1.10.0-py2.7.egg-info
Installing build/bdist.linux-x86_64/wheel/mesos.interface-1.10.0-py2.7-nspkg.pth
running install_scripts
creating build/bdist.linux-x86_64/wheel/mesos.interface-1.10.0.dist-info/WHEEL
running bdist_egg
running egg_info
creating src/mesos.scheduler.egg-info
writing requirements to src/mesos.scheduler.egg-info/requires.txt
writing src/mesos.scheduler.egg-info/PKG-INFO
writing namespace_packages to 
src/mesos.scheduler.egg-info/namespace_packages.txt
writing top-level names to src/mesos.scheduler.egg-info/top_level.txt
writing dependency_links to src/mesos.scheduler.egg-info/dependency_links.txt
writing manifest file 'src/mesos.scheduler.egg-info/SOURCES.txt'
reading manifest file 'src/mesos.scheduler.egg-info/SOURCES.txt'
writing manifest file 'src/mesos.scheduler.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_py
creating build
creating build/lib.linux-x86_64-2.7
creating build/lib.linux-x86_64-2.7/mesos
copying src/mesos/__init__.py -> build/lib.linux-x86_64-2.7/mesos
creating build/lib.linux-x86_64-2.7/mesos/scheduler
copying src/mesos/scheduler/__init__.py -> 
build/lib.linux-x86_64-2.7/mesos/scheduler
running build_ext
building 'mesos.scheduler._scheduler' extension
creating build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/src
creating build/temp.linux-x86_64-2.7/src/mesos
creating build/temp.linux-x86_64-2.7/src/mesos/scheduler
gcc -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g1 
-O0 -Wno-unused-local-typedefs -g1 -O0 -Wno-unused-local-typedefs -std=c++11 
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -fPIC 
-I/mesos/mesos-1.10.0/_build/../include -I/mesos/mesos-1.10.0/_build/include 
-I/mesos/mesos-1.10.0/_build/include/mesos -I/mesos/mesos-1.10.0/_build/src 
-I/mesos/mesos-1.10.0/_build/src/python/scheduler/src/mesos/scheduler 
-I/mesos/mesos-1.10.0/_build/src/python/native_common 
-I/mesos/mesos-1.10.0/_build/3rdparty/protobuf-3.5.0/src 
-I/usr/include/python2.7 -c src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 
-o build/temp.linux-x86_64-2.7/src/mesos/scheduler/mesos_scheduler_driver_impl.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC 
but not for C++ [enabled by default]
gcc -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g1 
-O0 -Wno-unused-local-typedefs -g1 -O0 -Wno-unused-local-typedefs -std=c++11 
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -fPIC 
-I/mesos/mesos-1.10.0/_build/../include -I/mesos/mesos-1.10.0/_build/include 
-I/mesos/mesos-1.10.0/_build/include/mesos -I/mesos/mesos-1.10.0/_build/src 
-I/mesos/mesos-1.10.0/_build/src/python/executor/src/mesos/executor 
-I/mesos/mesos-1.10.0/_build/src/python/native_common 
-I/mesos/mesos-1.10.0/_build/3rdparty/protobuf-3.5.0/src 
-I/usr/include/python2.7 -c src/mesos/executor/module.cpp -o 
build/temp.linux-x86_64-2.7/src/mesos/executor/module.o
cc1plus: warni